[PATCH] drm/panel-simple: Add a timing for the Raspberry Pi 7" panel

2022-02-01 Thread Detlev Casanova
From: Dave Stevenson The Raspberry Pi 7" 800x480 panel uses a Toshiba TC358762 DSI to DPI bridge chip, so there is a requirement for the timings to be specified for the end panel. Add such a definition. Signed-off-by: Dave Stevenson Signed-off-by: Detlev Casanova --- drivers/gpu/drm/

[PATCH v2 00/12] Add device tree for ArmSoM Sige 5 board

2024-08-23 Thread Detlev Casanova
/172441646605.877570.807594226105.b4...@sntech.de/ Detlev. Detlev Casanova (12): dt-bindings: arm: rockchip: Add ArmSoM Sige 5 dt-bindings: arm: rockchip: Add rk3576 compatible string to pmu.yaml dt-bindings: i2c: i2c-rk3x: Add rk3576 compatible dt-bindings: iio: adc: Add rockchip,rk3576-saradc string dt

[PATCH v2 01/12] dt-bindings: arm: rockchip: Add ArmSoM Sige 5

2024-08-23 Thread Detlev Casanova
Add devicetree binding for the ArmSoM Sige 5 board. Signed-off-by: Detlev Casanova Acked-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/arm/rockchip.yaml | 5 + 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation

[PATCH v2 02/12] dt-bindings: arm: rockchip: Add rk3576 compatible string to pmu.yaml

2024-08-23 Thread Detlev Casanova
Add the compatible for the pmu mfd on rk3576. Signed-off-by: Detlev Casanova Reviewed-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/arm/rockchip/pmu.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/rockchip/pmu.yaml b

[PATCH v2 03/12] dt-bindings: i2c: i2c-rk3x: Add rk3576 compatible

2024-08-23 Thread Detlev Casanova
Just like RK356x and RK3588, RK3576 is compatible to the existing rk3399 binding. Signed-off-by: Detlev Casanova Acked-by: Krzysztof Kozlowski Acked-by: Heiko Stuebner --- Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation

[PATCH v2 04/12] dt-bindings: iio: adc: Add rockchip, rk3576-saradc string

2024-08-23 Thread Detlev Casanova
Add rockchip,rk3576-saradc compatible string. The saradc on RK3576 is compatible with the one on RK3588, so they are used together in an arm of the oneOf. Signed-off-by: Detlev Casanova Reviewed-by: Krzysztof Kozlowski Acked-by: Heiko Stuebner --- Documentation/devicetree/bindings/iio/adc

[PATCH v2 05/12] dt-bindings: mfd: syscon: Add rk3576 QoS register compatible

2024-08-23 Thread Detlev Casanova
Document rk3576 compatible for QoS registers. Signed-off-by: Detlev Casanova Reviewed-by: Krzysztof Kozlowski Acked-by: Heiko Stuebner --- Documentation/devicetree/bindings/mfd/syscon.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml

[PATCH v2 06/12] dt-bindings: serial: snps-dw-apb-uart: Add Rockchip RK3576

2024-08-23 Thread Detlev Casanova
Add a Rockchip RK3576 compatible. Signed-off-by: Detlev Casanova Acked-by: Krzysztof Kozlowski Acked-by: Heiko Stuebner --- Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/serial/snps-dw-apb

[PATCH v2 07/12] dt-bindings: mmc: Add support for rk3576 eMMC

2024-08-23 Thread Detlev Casanova
The device is compatible with rk3588, so add an entry for the 2 compatibles together. The rk3576 device has a power-domain that needs to be on for the eMMC to be used. Add it as a requirement. Signed-off-by: Detlev Casanova --- .../bindings/mmc/snps,dwcmshc-sdhci.yaml | 32

[PATCH v2 08/12] dt-bindings: gpu: Add rockchip, rk3576-mali compatible

2024-08-23 Thread Detlev Casanova
Add the rockchip,rk3576-mali in arm,mali-bifrost.yaml Signed-off-by: Detlev Casanova --- Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml b/Documentation/devicetree

[PATCH v2 09/12] dt-bindings: watchdog: Add rockchip, rk3576-wdt compatible

2024-08-23 Thread Detlev Casanova
It is compatible with the other rockchip SoCs. Signed-off-by: Detlev Casanova --- Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml b/Documentation/devicetree/bindings

[PATCH v2 10/12] dt-bindings: spi: Add rockchip, rk3576-spi compatible

2024-08-23 Thread Detlev Casanova
It is compatible with the rockchip,rk3066-spi SPI core. Signed-off-by: Detlev Casanova --- Documentation/devicetree/bindings/spi/spi-rockchip.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/spi/spi-rockchip.yaml b/ Documentation/devicetree/bindings/spi

[PATCH v2 12/12] arm64: dts: rockchip: Add rk3576-armsom-sige5 board

2024-08-23 Thread Detlev Casanova
. Signed-off-by: Detlev Casanova --- arch/arm64/boot/dts/rockchip/Makefile | 1 + .../boot/dts/rockchip/rk3576-armsom-sige5.dts | 651 ++ 2 files changed, 652 insertions(+) create mode 100644 arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts diff --git a/arch/arm64

Re: [PATCH v2 11/12] arm64: dts: rockchip: Add rk3576 SoC base DT

2024-08-26 Thread Detlev Casanova
On Sunday, 25 August 2024 10:08:24 EDT Chukun Pan wrote: > Hi, > > > --- /dev/null > > +++ b/arch/arm64/boot/dts/rockchip/rk3576.dtsi > > ... > > + opp-141600 { > > + opp-hz = /bits/ 64 <141600>; > > + opp-microvolt = <725000 725000 95>; >

Re: [PATCH v2 12/12] arm64: dts: rockchip: Add rk3576-armsom-sige5 board

2024-08-26 Thread Detlev Casanova
Hi Chukun, On Sunday, 25 August 2024 10:25:09 EDT Chukun Pan wrote: > Hi, > > > --- /dev/null > > +++ b/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts > > ... > > + leds: leds { > > + compatible = "gpio-leds"; > > Maybe there should be a blank line. > > > + work_led:

[PATCH v3 08/11] dt-bindings: watchdog: Add rockchip, rk3576-wdt compatible

2024-08-28 Thread Detlev Casanova
It is compatible with the other rockchip SoCs. Signed-off-by: Detlev Casanova Acked-by: Krzysztof Kozlowski Acked-by: Guenter Roeck --- Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/watchdog

[PATCH v3 06/11] dt-bindings: mmc: Add support for rk3576 eMMC

2024-08-28 Thread Detlev Casanova
The device is compatible with rk3588, so add an entry for the 2 compatibles together. The rk3576 device has a power-domain that needs to be on for the eMMC to be used. Add it as a requirement. Signed-off-by: Detlev Casanova Reviewed-by: Krzysztof Kozlowski --- .../bindings/mmc/snps,dwcmshc

[PATCH v3 03/11] dt-bindings: i2c: i2c-rk3x: Add rk3576 compatible

2024-08-28 Thread Detlev Casanova
Just like RK356x and RK3588, RK3576 is compatible to the existing rk3399 binding. Signed-off-by: Detlev Casanova Acked-by: Krzysztof Kozlowski Acked-by: Heiko Stuebner --- Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation

[PATCH v3 01/11] dt-bindings: arm: rockchip: Add ArmSoM Sige 5

2024-08-28 Thread Detlev Casanova
Add devicetree binding for the ArmSoM Sige 5 board. Signed-off-by: Detlev Casanova Acked-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/arm/rockchip.yaml | 5 + 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation

[PATCH v3 02/11] dt-bindings: arm: rockchip: Add rk3576 compatible string to pmu.yaml

2024-08-28 Thread Detlev Casanova
Add the compatible for the pmu mfd on rk3576. Signed-off-by: Detlev Casanova Reviewed-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/arm/rockchip/pmu.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/rockchip/pmu.yaml b

[PATCH v3 00/11] Add device tree for ArmSoM Sige 5 board

2024-08-28 Thread Detlev Casanova
to match prior generations - Reorder fields consistently in nodes - Use correct #power-domain-cells values [0]: https://lore.kernel.org/all/918bb9e4-02d9-4dca-bed2-28bb123bd...@linaro.org/ [1]: https://lore.kernel.org/all/172441646605.877570.807594226105.b4...@sntech.de/ Detlev. Detlev

[PATCH v3 09/11] spi: dt-bindings: Add rockchip, rk3576-spi compatible

2024-08-28 Thread Detlev Casanova
It is compatible with the rockchip,rk3066-spi SPI core. Signed-off-by: Detlev Casanova Acked-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/spi/spi-rockchip.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/spi/spi-rockchip.yaml b

[PATCH v3 05/11] dt-bindings: serial: snps-dw-apb-uart: Add Rockchip RK3576

2024-08-28 Thread Detlev Casanova
Add a Rockchip RK3576 compatible. Signed-off-by: Detlev Casanova Acked-by: Krzysztof Kozlowski Acked-by: Heiko Stuebner --- Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/serial/snps-dw-apb

[PATCH v3 07/11] dt-bindings: gpu: Add rockchip, rk3576-mali compatible

2024-08-28 Thread Detlev Casanova
The rk3576 SoC has an ARM Mali G52 MC3 GPU, that is compatible with arm,mali-bifrost. Signed-off-by: Detlev Casanova Acked-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree

[PATCH v3 11/11] arm64: dts: rockchip: Add rk3576-armsom-sige5 board

2024-08-28 Thread Detlev Casanova
Add board file for the rk3576 based ArmSoM Sige5 board. While the hardware offers plenty of peripherals and connectivity this basic implementation just handles things required to successfully boot Linux from SD card and connect via UART or Ethernet. Signed-off-by: Detlev Casanova --- arch/arm64

[PATCH v3 04/11] dt-bindings: mfd: syscon: Add rk3576 QoS register compatible

2024-08-28 Thread Detlev Casanova
Document rk3576 compatible for QoS registers. Signed-off-by: Detlev Casanova Reviewed-by: Krzysztof Kozlowski Acked-by: Heiko Stuebner --- Documentation/devicetree/bindings/mfd/syscon.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml

[PATCH v4 5/9] dt-bindings: gpu: Add rockchip,rk3576-mali compatible

2024-09-03 Thread Detlev Casanova
The rk3576 SoC has an ARM Mali G52 MC3 GPU, that is compatible with arm,mali-bifrost. Signed-off-by: Detlev Casanova Acked-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree

[PATCH v4 0/9] Add device tree for ArmSoM Sige 5 board

2024-09-03 Thread Detlev Casanova
...@kernel.org/ Detlev. Detlev Casanova (9): dt-bindings: arm: rockchip: Add ArmSoM Sige 5 dt-bindings: arm: rockchip: Add rk3576 compatible string to pmu.yaml dt-bindings: i2c: i2c-rk3x: Add rk3576 compatible dt-bindings: serial: snps-dw-apb-uart: Add Rockchip RK3576 dt-bindings: gpu

[PATCH v4 6/9] dt-bindings: watchdog: Add rockchip, rk3576-wdt compatible

2024-09-03 Thread Detlev Casanova
It is compatible with the other rockchip SoCs. Signed-off-by: Detlev Casanova Acked-by: Krzysztof Kozlowski Acked-by: Guenter Roeck --- Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/watchdog

[PATCH v4 4/9] dt-bindings: serial: snps-dw-apb-uart: Add Rockchip RK3576

2024-09-03 Thread Detlev Casanova
Add a Rockchip RK3576 compatible. Signed-off-by: Detlev Casanova Acked-by: Krzysztof Kozlowski Acked-by: Heiko Stuebner --- Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/serial/snps-dw-apb

[PATCH v4 2/9] dt-bindings: arm: rockchip: Add rk3576 compatible string to pmu.yaml

2024-09-03 Thread Detlev Casanova
Add the compatible for the pmu mfd on rk3576. Signed-off-by: Detlev Casanova Reviewed-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/arm/rockchip/pmu.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/rockchip/pmu.yaml b

[PATCH v4 1/9] dt-bindings: arm: rockchip: Add ArmSoM Sige 5

2024-09-03 Thread Detlev Casanova
Add devicetree binding for the ArmSoM Sige 5 board. Signed-off-by: Detlev Casanova Acked-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/arm/rockchip.yaml | 5 + 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation

[PATCH v4 7/9] spi: dt-bindings: Add rockchip,rk3576-spi compatible

2024-09-03 Thread Detlev Casanova
It is compatible with the rockchip,rk3066-spi SPI core. Signed-off-by: Detlev Casanova Acked-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/spi/spi-rockchip.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/spi/spi-rockchip.yaml b

[PATCH v4 9/9] arm64: dts: rockchip: Add rk3576-armsom-sige5 board

2024-09-03 Thread Detlev Casanova
Add board file for the rk3576 based ArmSoM Sige5 board. While the hardware offers plenty of peripherals and connectivity this basic implementation just handles things required to successfully boot Linux from SD card and connect via UART or Ethernet. Signed-off-by: Detlev Casanova --- arch/arm64

[PATCH v4 3/9] dt-bindings: i2c: i2c-rk3x: Add rk3576 compatible

2024-09-03 Thread Detlev Casanova
Just like RK356x and RK3588, RK3576 is compatible to the existing rk3399 binding. Signed-off-by: Detlev Casanova Acked-by: Krzysztof Kozlowski Acked-by: Heiko Stuebner --- Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation

Re: [PATCH v4 3/9] dt-bindings: i2c: i2c-rk3x: Add rk3576 compatible

2024-09-03 Thread Detlev Casanova
Hello, On Tuesday, 3 September 2024 11:46:00 EDT Andi Shyti wrote: > Hi, > > On Tue, Sep 03, 2024 at 11:22:33AM GMT, Detlev Casanova wrote: > > Just like RK356x and RK3588, RK3576 is compatible to the existing > > rk3399 binding. > > > > Signed-off-by: Detlev

[PATCH 0/3] drm/rockchip: vop2: Add VP clock resets support

2024-05-14 Thread Detlev Casanova
The clock reset must be used when the VOP is configured. Skipping it can put the VOP in an unknown state where the HDMI signal is either lost or not matching the selected mode. This adds support for rk3588(s) based SoCs. Detlev Casanova (3): drm/rockchip: vop2: Add clock resets support arm64

[PATCH 1/3] drm/rockchip: vop2: Add clock resets support

2024-05-14 Thread Detlev Casanova
At the end of initialization, each VP clock needs to be reset before they can be used. Failing to do so can put the VOP in an undefined state where the generated HDMI signal is either lost or not matching the selected mode. Signed-off-by: Detlev Casanova --- drivers/gpu/drm/rockchip

[PATCH 2/3] arm64: dts: rockchip: Add VOP clock resets for rk3588s

2024-05-14 Thread Detlev Casanova
This adds the needed clock resets for all rk3588(s) based SOCs. Signed-off-by: Detlev Casanova --- arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi index

[PATCH 3/3] dt-bindings: display: vop2: Add VP clock resets

2024-05-14 Thread Detlev Casanova
Add the documentation for VOP2 video ports reset clocks. One reset can be set per video port. Signed-off-by: Detlev Casanova --- .../display/rockchip/rockchip-vop2.yaml | 27 +++ 1 file changed, 27 insertions(+) diff --git a/Documentation/devicetree/bindings/display

Re: [PATCH 3/3] dt-bindings: display: vop2: Add VP clock resets

2024-05-21 Thread Detlev Casanova
On Wednesday, May 15, 2024 12:33:22 P.M. EDT Heiko Stübner wrote: > Am Mittwoch, 15. Mai 2024, 18:19:29 CEST schrieb Conor Dooley: > > On Tue, May 14, 2024 at 11:19:47AM -0400, Detlev Casanova wrote: > > > Add the documentation for VOP2 video ports reset clocks. > > &g

Re: [PATCH 3/3] dt-bindings: display: vop2: Add VP clock resets

2024-05-22 Thread Detlev Casanova
On Tuesday, May 21, 2024 2:31:51 P.M. EDT Conor Dooley wrote: > On Tue, May 21, 2024 at 01:15:46PM -0400, Detlev Casanova wrote: > > On Wednesday, May 15, 2024 12:33:22 P.M. EDT Heiko Stübner wrote: > > > Am Mittwoch, 15. Mai 2024, 18:19:29 CEST schrieb Conor Dooley: > >

[PATCH v2 0/3] drm: rockchip: vop2: Add VP clock resets support

2024-05-22 Thread Detlev Casanova
in vop2 bindings Detlev Casanova (3): vop2: Add clock resets support arm64: dts: rockchip: Add VOP clock resets for rk3588s dt-bindings: display: vop2: Add VP clock resets .../display/rockchip/rockchip-vop2.yaml | 40 +++ arch/arm64/boot/dts/rockchip/rk3588s.dtsi

[PATCH v2 1/3] vop2: Add clock resets support

2024-05-22 Thread Detlev Casanova
At the end of initialization, each VP clock needs to be reset before they can be used. Failing to do so can put the VOP in an undefined state where the generated HDMI signal is either lost or not matching the selected mode. Signed-off-by: Detlev Casanova --- drivers/gpu/drm/rockchip

[PATCH v2 2/3] arm64: dts: rockchip: Add VOP clock resets for rk3588s

2024-05-22 Thread Detlev Casanova
This adds the needed clock resets for all rk3588(s) based SOCs. Signed-off-by: Detlev Casanova --- arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi

[PATCH v2 3/3] dt-bindings: display: vop2: Add VP clock resets

2024-05-22 Thread Detlev Casanova
Add the documentation for VOP2 video ports reset clocks. One reset can be set per video port. Signed-off-by: Detlev Casanova --- .../display/rockchip/rockchip-vop2.yaml | 40 +++ 1 file changed, 40 insertions(+) diff --git a/Documentation/devicetree/bindings/display

[PATCH] drm: vop2: Do not divide height twice for YUV

2024-04-14 Thread Detlev Casanova
when down scaling to 1080 pixels from 2160. Signed-off-by: Detlev Casanova Fixes: 604be85547ce ("drm/rockchip: Add VOP2 driver") --- drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 22 +++- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/dr

Re: [PATCH v2 1/3] vop2: Add clock resets support

2024-11-08 Thread Detlev Casanova
On Thursday, 23 May 2024 23:09:26 EST Andy Yan wrote: > Hi Detlev, > > At 2024-05-23 02:57:48, "Detlev Casanova" wrote: > >At the end of initialization, each VP clock needs to be reset before > >they can be used. > > > >Failing to do so can

Re: [PATCH v2 1/3] vop2: Add clock resets support

2024-11-08 Thread Detlev Casanova
On Friday, 8 November 2024 11:39:57 EST Detlev Casanova wrote: > On Thursday, 23 May 2024 23:09:26 EST Andy Yan wrote: > > Hi Detlev, > > > > At 2024-05-23 02:57:48, "Detlev Casanova" > > wrote: > > >At the end of initialization, each VP clock

[PATCH v3 1/3] vop2: Add clock resets support

2024-11-08 Thread Detlev Casanova
. Depending on the setup, after about 10 mode switches, the signal will be lost and the value in register 0x890 (VSYNCWIDTH + VFRONT) will take the value `0x018c`. That makes VSYNCWIDTH=0, which is wrong. Adding the clock resets after the VOP configuration fixes the issue. Signed-off-by: Detlev Casanova

[PATCH v3 2/3] arm64: dts: rockchip: Add VOP clock resets for rk3588s

2024-11-08 Thread Detlev Casanova
This adds the needed clock resets for all rk3588(s) based SOCs. Signed-off-by: Detlev Casanova --- arch/arm64/boot/dts/rockchip/rk3588-base.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi b/arch/arm64/boot/dts/rockchip/rk3588

[PATCH v3 3/3] dt-bindings: display: vop2: Add VP clock resets

2024-11-08 Thread Detlev Casanova
Add the documentation for VOP2 video ports reset clocks. One reset can be set per video port. Reviewed-by: Conor Dooley Signed-off-by: Detlev Casanova --- .../display/rockchip/rockchip-vop2.yaml | 40 +++ 1 file changed, 40 insertions(+) diff --git a/Documentation

[PATCH v3 0/3] drm: rockchip: vop2: Add VP clock resets support

2024-11-08 Thread Detlev Casanova
reproduce the issue Changes since v1: - Add AXI and AHB clock resets - Set maxItems for !rk3588 in vop2 bindings Detlev Casanova (3): vop2: Add clock resets support arm64: dts: rockchip: Add VOP clock resets for rk3588s dt-bindings: display: vop2: Add VP clock resets .../display/rockchip/rockchip

Re: [PATCH v3 00/15] VOP Support for rk3576

2024-09-30 Thread Detlev Casanova
Hi Andy, I tested these on the RK3576 Armsom Sige 5 board: Tested-by: Detlev Casanova Regards, Detlev. On Friday, 20 September 2024 04:16:24 EDT Andy Yan wrote: > From: Andy Yan > > > Thanks for the basic work from Collabora, I can bringup a HDMI > display out on rk3576. &g

Re: [PATCH v4 0/3] drm: rockchip: vop2: Add VP clock resets support

2024-11-25 Thread Detlev Casanova
llo Detlev, > > At 2024-11-16 00:20:39, "Detlev Casanova" wrote: > >The clock reset must be used when the VOP is configured. Skipping it can > >put the VOP in an unknown state where the HDMI signal is either lost or > >not matching the selected mode. > &g

[PATCH v4 1/3] dt-bindings: display: vop2: Add VP clock resets

2024-11-15 Thread Detlev Casanova
Add the documentation for VOP2 video ports reset clocks. One reset can be set per video port. Reviewed-by: Conor Dooley Signed-off-by: Detlev Casanova --- .../display/rockchip/rockchip-vop2.yaml | 40 +++ 1 file changed, 40 insertions(+) diff --git a/Documentation

[PATCH v4 2/3] drm/rockchip: vop2: Add clock resets support

2024-11-15 Thread Detlev Casanova
. Depending on the setup, after about 10 mode switches, the signal will be lost and the value in register 0x890 (VSYNCWIDTH + VFRONT) will take the value `0x018c`. That makes VSYNCWIDTH=0, which is wrong. Adding the clock resets after the VOP configuration fixes the issue. Signed-off-by: Detlev Casanova

[PATCH v4 3/3] arm64: dts: rockchip: Add VOP clock resets for rk3588s

2024-11-15 Thread Detlev Casanova
This adds the needed clock resets for all rk3588(s) based SOCs. Signed-off-by: Detlev Casanova --- arch/arm64/boot/dts/rockchip/rk3588-base.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi b/arch/arm64/boot/dts/rockchip/rk3588

[PATCH v4 0/3] drm: rockchip: vop2: Add VP clock resets support

2024-11-15 Thread Detlev Casanova
- Reorder commits for different trees Changes since v2: - Rebase on latest master - Add details on how to reproduce the issue Changes since v1: - Add AXI and AHB clock resets - Set maxItems for !rk3588 in vop2 bindings Detlev Casanova (3): dt-bindings: display: vop2: Add VP clock resets drm

[PATCH v5 2/3] arm64: dts: rockchip: Add HDMI0 audio output for rk3588 SoC

2025-02-03 Thread Detlev Casanova
-off-by: Detlev Casanova --- arch/arm64/boot/dts/rockchip/rk3588-base.dtsi | 17 + 1 file changed, 17 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi index 8cfa30837ce72..767bdfc06b7ec 100644 --- a/arch/arm64

[PATCH v5 3/3] arm64: dts: rockchip: Enable HDMI0 audio output for Rock 5B

2025-02-03 Thread Detlev Casanova
HDMI audio is available on the Rock 5B HDMI TX port. Enable it. Signed-off-by: Detlev Casanova --- arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588

[PATCH v5 1/3] drm/bridge: synopsys: Add audio support for dw-hdmi-qp

2025-02-03 Thread Detlev Casanova
support. Signed-off-by: Sugar Zhang Reviewed-by: Dmitry Baryshkov Tested-by: Quentin Schulz Signed-off-by: Detlev Casanova --- drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c | 497 +++ 1 file changed, 497 insertions(+) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c

[PATCH v5 0/3] Add HDMI audio on the rk3588 SoC

2025-02-03 Thread Detlev Casanova
rames - Only access audio registers when connector is connected - Rebased on master branch Detlev Casanova (2): arm64: dts: rockchip: Add HDMI0 audio output for rk3588 SoC arm64: dts: rockchip: Enable HDMI0 audio output for Rock 5B Sugar Zhang (1): drm/bridge: synopsys: Add audio support f

Re: [PATCH v5 1/3] drm/bridge: synopsys: Add audio support for dw-hdmi-qp

2025-02-06 Thread Detlev Casanova
Hi Quentin, On Tuesday, 4 February 2025 04:59:12 EST Quentin Schulz wrote: > Hi Detlev, > > Just some drive-by comment inline. > > On 2/3/25 6:16 PM, Detlev Casanova wrote: > > From: Sugar Zhang > > > > Register the dw-hdmi-qp bridge driver as an HDMI audio co

Re: [PATCH v5 2/3] arm64: dts: rockchip: Add HDMI0 audio output for rk3588 SoC

2025-02-06 Thread Detlev Casanova
On Tuesday, 4 February 2025 05:14:37 EST Quentin Schulz wrote: > Hi Detlev, > > On 2/3/25 6:16 PM, Detlev Casanova wrote: > > Use the simple-audio-card driver with the hdmi0 QP node as CODEC and > > the i2s5 device as CPU. > > > > The simple-audio-card,mclk-fs

[PATCH v3 1/2] drm/bridge: synopsys: Add audio support for dw-hdmi-qp

2025-01-30 Thread Detlev Casanova
support. Signed-off-by: Sugar Zhang Signed-off-by: Detlev Casanova --- drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c | 497 +++ 1 file changed, 497 insertions(+) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c index

[PATCH v3 0/2] Add HDMI audio on the Radxa ROCK 5B

2025-01-30 Thread Detlev Casanova
mutex (was used downstream for multiple drivers access to audio functions) - Let hdmi_codec build and setup audio infoframes - Only access audio registers when connector is connected - Rebased on master branch Detlev Casanova (1): arm64: dts: rockchip: Add HDMI0 audio output on rock-5b

[PATCH v3 2/2] arm64: dts: rockchip: Add HDMI0 audio output on rock-5b

2025-01-30 Thread Detlev Casanova
-off-by: Detlev Casanova --- arch/arm64/boot/dts/rockchip/rk3588-base.dtsi | 1 + .../boot/dts/rockchip/rk3588-rock-5b.dts | 19 +++ 2 files changed, 20 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi

[PATCH v4 1/2] drm/bridge: synopsys: Add audio support for dw-hdmi-qp

2025-01-31 Thread Detlev Casanova
support. Signed-off-by: Sugar Zhang Reviewed-by: Dmitry Baryshkov Signed-off-by: Detlev Casanova --- drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c | 497 +++ 1 file changed, 497 insertions(+) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c b/drivers/gpu/drm/bridge

[PATCH v4 0/2] Add HDMI audio on the Radxa ROCK 5B

2025-01-31 Thread Detlev Casanova
t use connector_state duplicates Changes since v1: - Remove useless audio_mutex (was used downstream for multiple drivers access to audio functions) - Let hdmi_codec build and setup audio infoframes - Only access audio registers when connector is connected - Rebased on master branch Detlev Casano

[PATCH v4 2/2] arm64: dts: rockchip: Add HDMI0 audio output on rock-5b

2025-01-31 Thread Detlev Casanova
-off-by: Detlev Casanova --- arch/arm64/boot/dts/rockchip/rk3588-base.dtsi | 1 + .../boot/dts/rockchip/rk3588-rock-5b.dts | 19 +++ 2 files changed, 20 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi

Re: [PATCH v3 2/2] arm64: dts: rockchip: Add HDMI0 audio output on rock-5b

2025-01-31 Thread Detlev Casanova
Hi Quentin, On Friday, 31 January 2025 11:38:34 EST Quentin Schulz wrote: > Hi Detlev, > > On 1/30/25 5:45 PM, Detlev Casanova wrote: > > Use the simple-audio-card driver with the hdmi0 QP node as CODEC and > > the i2s5 device as CPU. > > > > The simple-audio-ca

Re: [PATCH v5 05/18] drm/rockchip: vop2: Set AXI id for rk3588

2024-12-11 Thread Detlev Casanova
On Wednesday, 11 December 2024 01:34:34 EST Andy Yan wrote: > Hi Detlev, > > At 2024-12-11 02:40:14, "Detlev Casanova" wrote: > >Hi Andy, > > > >On Monday, 9 December 2024 07:29:18 EST Andy Yan wrote: > >> From: Andy Yan > >> > >

Re: [PATCH v5 05/18] drm/rockchip: vop2: Set AXI id for rk3588

2024-12-10 Thread Detlev Casanova
Hi Andy, On Monday, 9 December 2024 07:29:18 EST Andy Yan wrote: > From: Andy Yan > > There are two AXI bus in vop2, windows attached on the same bus must > have a unique channel YUV and RGB channel ID. > > The default IDs will conflict with each other on the rk3588, so they > need to be reassi

Re: [PATCH v5 05/18] drm/rockchip: vop2: Set AXI id for rk3588

2024-12-13 Thread Detlev Casanova
On Thursday, 12 December 2024 02:52:34 EST Andy Yan wrote: > Hi Detlev, > > At 2024-12-11 23:45:01, "Detlev Casanova" wrote: > >On Wednesday, 11 December 2024 01:34:34 EST Andy Yan wrote: > >> Hi Detlev, > >> > >> At 2024-12-11 02:4

[PATCH v2 1/2] drm/bridge: synopsys: Add audio support for dw-hdmi-qp

2025-01-23 Thread Detlev Casanova
support. Signed-off-by: Sugar Zhang Signed-off-by: Detlev Casanova --- drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c | 424 +++ 1 file changed, 424 insertions(+) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c index

[PATCH v2 2/2] arm64: dts: rockchip: Add HDMI0 audio output on rock-5b

2025-01-23 Thread Detlev Casanova
-off-by: Detlev Casanova --- arch/arm64/boot/dts/rockchip/rk3588-base.dtsi | 1 + .../boot/dts/rockchip/rk3588-rock-5b.dts | 19 +++ 2 files changed, 20 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi

[PATCH v2 0/2] Add HDMI audio on the Radxa ROCK 5B

2025-01-23 Thread Detlev Casanova
ranch. Changes since v1: - Remove useless audio_mutex (was used downstream for multiple drivers access to audio functions) - Let hdmi_codec build and setup audio infoframes - Only access audio registers when connector is connected - Rebased on master branch Detlev Casanova (1): arm64

Re: [PATCH v2 1/2] drm/bridge: synopsys: Add audio support for dw-hdmi-qp

2025-01-27 Thread Detlev Casanova
On Friday, 24 January 2025 00:01:38 EST Dmitry Baryshkov wrote: > On Thu, Jan 23, 2025 at 05:28:06PM -0500, Detlev Casanova wrote: > > From: Sugar Zhang > > > > Register the dw-hdmi-qp bridge driver as an HDMI audio codec. > > > > The register values computati

[PATCH v1 0/2] Add HDMI audio on the Radxa ROCK 5B

2025-01-17 Thread Detlev Casanova
(tag: drm-misc-next-fixes-2025-01-16) [1]: https://lore.kernel.org/all/20241224-drm-bridge-hdmi-connector-v10-0-dc89577cd...@linaro.org/ Detlev Casanova (1): arm64: dts: rockchip: Add HDMI0 audio output on rock-5b Sugar Zhang (1): drm/bridge: synopsys: Add audio support for dw-hdmi-qp arch

[PATCH v1 1/2] drm/bridge: synopsys: Add audio support for dw-hdmi-qp

2025-01-17 Thread Detlev Casanova
support. Signed-off-by: Sugar Zhang Signed-off-by: Detlev Casanova --- drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c | 472 +++ 1 file changed, 472 insertions(+) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c index

[PATCH v1 2/2] arm64: dts: rockchip: Add HDMI0 audio output on rock-5b

2025-01-17 Thread Detlev Casanova
-off-by: Detlev Casanova --- arch/arm64/boot/dts/rockchip/rk3588-base.dtsi | 1 + .../boot/dts/rockchip/rk3588-rock-5b.dts | 19 +++ 2 files changed, 20 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi

[PATCH v6 0/3] Add HDMI audio on the rk3588 SoC

2025-02-14 Thread Detlev Casanova
(was used downstream for multiple drivers access to audio functions) - Let hdmi_codec build and setup audio infoframes - Only access audio registers when connector is connected - Rebased on master branch Detlev Casanova (2): arm64: dts: rockchip: Add HDMI0 audio output for rk3588 SoC

[PATCH v7 2/3] arm64: dts: rockchip: Add HDMI audio outputs for rk3588 SoC

2025-02-17 Thread Detlev Casanova
versions of the SoC. The simple-audio-card,mclk-fs value is set to 128 as it is done in the downstream driver. The #sound-dai-cells value is set to 0 in the hdmi0 and hdmi1 nodes so that they can be used as audio codec nodes. Tested-by: Quentin Schulz # RK3588 Tiger Haikou Signed-off-by: Detlev

[PATCH v7 0/3] Add HDMI audio on the rk3588 SoC

2025-02-17 Thread Detlev Casanova
udio_mutex (was used downstream for multiple drivers access to audio functions) - Let hdmi_codec build and setup audio infoframes - Only access audio registers when connector is connected - Rebased on master branch Detlev Casanova (2): arm64: dts: rockchip: Add HDMI audio outputs for rk3

[PATCH v7 1/3] drm/bridge: synopsys: Add audio support for dw-hdmi-qp

2025-02-17 Thread Detlev Casanova
support. Signed-off-by: Sugar Zhang Reviewed-by: Dmitry Baryshkov Tested-by: Quentin Schulz Reviewed-by: Robert Foss Signed-off-by: Detlev Casanova --- drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c | 489 +++ 1 file changed, 489 insertions(+) diff --git a/drivers/gpu/drm

[PATCH v7 3/3] arm64: dts: rockchip: Enable HDMI audio outputs for Rock 5B

2025-02-17 Thread Detlev Casanova
HDMI audio is available on the Rock 5B HDMI TX ports. Enable it for both ports. Reviewed-by: Quentin Schulz Signed-off-by: Detlev Casanova --- arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 16 1 file changed, 16 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip

[PATCH RESEND v6 1/3] drm/bridge: synopsys: Add audio support for dw-hdmi-qp

2025-02-14 Thread Detlev Casanova
support. Signed-off-by: Sugar Zhang Reviewed-by: Dmitry Baryshkov Tested-by: Quentin Schulz Signed-off-by: Detlev Casanova --- drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c | 489 +++ 1 file changed, 489 insertions(+) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c

[PATCH RESEND v6 2/3] arm64: dts: rockchip: Add HDMI0 audio output for rk3588 SoC

2025-02-14 Thread Detlev Casanova
-by: Quentin Schulz # RK3588 Tiger Haikou Signed-off-by: Detlev Casanova --- arch/arm64/boot/dts/rockchip/rk3588-base.dtsi | 17 + 1 file changed, 17 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi index

[PATCH RESEND v6 3/3] arm64: dts: rockchip: Enable HDMI0 audio output for Rock 5B

2025-02-14 Thread Detlev Casanova
HDMI audio is available on the Rock 5B HDMI TX port. Enable it. Reviewed-by: Quentin Schulz Signed-off-by: Detlev Casanova --- arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch

[PATCH RESEND v6 0/3] Add HDMI audio on the rk3588 SoC

2025-02-14 Thread Detlev Casanova
state duplicates Changes since v1: - Remove useless audio_mutex (was used downstream for multiple drivers access to audio functions) - Let hdmi_codec build and setup audio infoframes - Only access audio registers when connector is connected - Rebased on master branch Detlev Casanova (2):

Re: [PATCH v7 0/3] Add HDMI audio on the rk3588 SoC

2025-02-21 Thread Detlev Casanova
On Friday, 21 February 2025 06:42:31 EST Piotr Oniszczuk wrote: > Small data point: on rock5b switching in dts analog audio: from > audio-graph-card to simple-audio-card (so dts is: > https://gist.github.com/warpme/349b27e49bc6f617ef1041047e75adab ) makes > kernel oops go away with analog audio sti

Re: [PATCH v7 0/3] Add HDMI audio on the rk3588 SoC

2025-02-20 Thread Detlev Casanova
Hi Piotr, On Thursday, 20 February 2025 06:16:20 EST Piotr Oniszczuk wrote: > > Wiadomość napisana przez Detlev Casanova w > > dniu 17 lut 2025, o godz. 22:47: > > > > To support HDMI audio on the rk3588 based devices, the generic HDMI > > Codec framework is use

Re: [PATCH v7 0/3] Add HDMI audio on the rk3588 SoC

2025-02-25 Thread Detlev Casanova
Hi Morimoto-san, On Tuesday, 25 February 2025 01:16:50 EST Kuninori Morimoto wrote: > Hi Detlev, again > > > > Especially those commits: > > > ASoC: audio-graph-card2: use __free(device_node) for device node > > > ASoC: audio-graph-card: use __free(device_node) for device node > > >

Re: [PATCH 3/3] arm64: dts: rockchip: Add HDMI PHY PLL clock source to VOP2 on rk3576

2025-06-11 Thread Detlev Casanova
lk_vp2"; > + "dclk_vp2", > + "pll_hdmiphy0"; > iommus = <&vop_mmu>; > power-domains = <&power RK3576_PD_VOP>; > rockchip,grf = <&sys_grf>; I tested this on the ROCK 4D and can confirm that: - New modes like 2K are now working - Mode changes is now correctly supported So, Tested-By: Detlev Casanova Regards, Detlev.

[PATCH 3/3] drm/bridge: synopsys: Do not warn about audio params computation

2025-07-17 Thread Detlev Casanova
There is no need to warn about non pre-computed values, just change it to dbg. Signed-off-by: Detlev Casanova --- drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c b/drivers/gpu/drm

[PATCH 1/3] drm/bridge: dw-hdmi-qp: Return 0 in audio prepare when disconnected

2025-07-17 Thread Detlev Casanova
eally make sense. Using a cached regmap to be dumped when a cable is connected won't work because writing order is important and some data needs to be retrieved from registers to write others. Returning 0 to silently fail sounds like the best and simplest solution. Signed-off-by: Detlev Casanov

[PATCH 2/3] ASoC: hdac_hdmi: Use dev_info on invalid ELD version

2025-07-17 Thread Detlev Casanova
/pcm_drm_eld.c This avoids printing multiple messages like: HDMI: Unknown ELD version 0 in the kernel log when userspace tries to open the sound device. Signed-off-by: Detlev Casanova --- sound/soc/codecs/hdac_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound

[PATCH 0/3] Clean some logs on rockchip hdmi audio

2025-07-17 Thread Detlev Casanova
HDMI audio is showing lots of logs, particularly when HDMI is disconnected. It doubled on RK3588 with the addition of the second HDMI TX port, so clean it up to avoid missing important log lines. Detlev Casanova (3): drm/bridge: dw-hdmi-qp: Return 0 in audio prepare when disconnected ASoC

Re: [PATCH v2 2/3] ASoC: hdac_hdmi: Use dev_info on invalid ELD version

2025-07-23 Thread Detlev Casanova
Hi Mark, On Wednesday, 23 July 2025 06:40:13 EDT Mark Brown wrote: > On Tue, Jul 22, 2025 at 03:54:36PM -0400, Detlev Casanova wrote: > > When disconnected, the ELD data cannot be read by the display driver, so > > it just sets the data to 0. > > Please don't put patche

  1   2   >