[PATCH] drm/client: remove the exporting of drm_client_close

2019-07-04 Thread Denis Efremov
er modules can. Relying on the fact that this is the internal function and it's not a crucial part of the API, the patch removes the EXPORT_SYMBOL marking of drm_client_close. Signed-off-by: Denis Efremov --- drivers/gpu/drm/drm_client.c | 1 - 1 file changed, 1 deletion(-) diff --git a/

Re: [PATCH] drm/client: remove the exporting of drm_client_close

2019-07-04 Thread Denis Efremov
> > Out of curiosity: Did you use some tool to spot this? > Just regular expressions: https://github.com/evdenis/export_checking But it's not very reliable because of false positives. I think I can try to implement this kind of check as a part of modpost in addition to CONFIG_DEBUG_SECTION_MISM

Re: [PATCH v2 1/2] drm/client: Dual licence the file in GPL-2 and MIT

2020-02-17 Thread Denis Efremov
15.02.2020 21:09, Emmanuel Vadot пишет: > From: Emmanuel Vadot > > Contributors for this file are : > Chris Wilson > Denis Efremov > Jani Nikula > Maxime Ripard > Noralf Trønnes > Sam Ravnborg > Thomas Zimmermann > > Signed-off-by: Emmanuel Vadot

[PATCH v3 01/11] checkpatch: check for nested (un)?likely() calls

2019-08-29 Thread Denis Efremov
/1559767582-11081-1-git-send-email-i...@metux.net/ Signed-off-by: Denis Efremov Cc: Joe Perches Cc: Andrew Morton Cc: Andy Whitcroft --- scripts/checkpatch.pl | 6 ++ 1 file changed, 6 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 93a7edfe0f05..56969ce06df4

[PATCH v3 02/11] drm/msm: remove unlikely() from WARN_ON() conditions

2019-08-29 Thread Denis Efremov
"unlikely(WARN_ON(x))" is excessive. WARN_ON() already uses unlikely() internally. Signed-off-by: Denis Efremov Cc: Rob Clark Cc: Sean Paul Cc: Joe Perches Cc: Andrew Morton Cc: linux-arm-...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/msm/disp/mdp5/

Re: [PATCH v3 01/11] checkpatch: check for nested (un)?likely() calls

2019-08-31 Thread Denis Efremov
On 31.08.2019 12:15, Markus Elfring wrote: >> +# nested likely/unlikely calls >> +    if ($line =~ >> /\b(?:(?:un)?likely)\s*\(\s*!?\s*(IS_ERR(?:_OR_NULL|_VALUE)?|WARN)/) { >> +    WARN("LIKELY_MISUSE", > > How do you think about to use the specification > “(?:IS_ERR(?:_(?:OR_NULL

Re: [PATCH v3 01/11] checkpatch: check for nested (un)?likely() calls

2019-08-31 Thread Denis Efremov
On 31.08.2019 19:45, Markus Elfring wrote: +# nested likely/unlikely calls +    if ($line =~ /\b(?:(?:un)?likely)\s*\(\s*!?\s*(IS_ERR(?:_OR_NULL|_VALUE)?|WARN)/) { +    WARN("LIKELY_MISUSE", >>> >>> How do you think about to use the specification >>> “(?:IS_ERR(

[PATCH] drm/gma500: Fix direction check in psb_accel_2d_copy()

2020-06-23 Thread Denis Efremov
kernel.org Signed-off-by: Denis Efremov --- drivers/gpu/drm/gma500/accel_2d.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/gma500/accel_2d.c b/drivers/gpu/drm/gma500/accel_2d.c index adc0507545bf..8dc86aac54d2 100644 --- a/drivers/gpu/drm/gma500/accel_

[PATCH] drm/radeon: fix fb_div check in ni_init_smc_spll_table()

2020-06-23 Thread Denis Efremov
clk_s is checked twice in a row in ni_init_smc_spll_table(). fb_div should be checked instead. Fixes: 69e0b57a91ad ("drm/radeon/kms: add dpm support for cayman (v5)") Cc: sta...@vger.kernel.org Signed-off-by: Denis Efremov --- drivers/gpu/drm/radeon/ni_dpm.c | 2 +- 1 file changed, 1

[PATCH] drm/panfrost: Use kvfree() to free bo->sgts in panfrost_mmu_map_fault_addr()

2020-06-07 Thread Denis Efremov
Use kvfree() to free bo->sgts, because the memory is allocated with kvmalloc_array(). Fixes: 187d2929206e ("drm/panfrost: Add support for GPU heap allocations") Cc: sta...@vger.kernel.org Signed-off-by: Denis Efremov --- drivers/gpu/drm/panfrost/panfrost_mmu.c | 2 +- 1 fi

[PATCH v2] drm/panfrost: Use kvfree() to free bo->sgts

2020-06-09 Thread Denis Efremov
Use kvfree() to free bo->sgts, because the memory is allocated with kvmalloc_array() in panfrost_mmu_map_fault_addr(). Fixes: 187d2929206e ("drm/panfrost: Add support for GPU heap allocations") Cc: sta...@vger.kernel.org Signed-off-by: Denis Efremov --- Change in v2: - kvfr