It forgot to call bochs_hw_fini() to release related resources when
bochs_pci_probe() fail. eg: io virtual address get by ioremap().
Fixes: 81da8c3b8d3df6 ("drm/bochs: add drm_driver.release callback.")
CC: Andy Shevchenko
Signed-off-by: Dejin Zheng
---
drivers/gpu/drm/bochs/bochs
if do_take_over_console() return an error in the newport_probe(),
due to the io virtual address is not released, it will cause a leak.
Fixes: e84de0c6190503 ("MIPS: GIO bus support for SGI IP22/28")
CC: Andy Shevchenko
Signed-off-by: Dejin Zheng
---
drivers/video/console/newport
On Tue, Apr 21, 2020 at 08:24:24PM +0300, Andy Shevchenko wrote:
> On Tue, Apr 21, 2020 at 7:45 PM Dejin Zheng wrote:
> >
> > It forgot to call bochs_hw_fini() to release related resources when
> > bochs_pci_probe() fail. eg: io virtual address get by ioremap().
>
> G
the sfb->fb->screen_base is not save the value get by iounmap() when
the chip id is 0x720. so iounmap() for address sfb->fb->screen_base
is not right.
Fixes: 1461d6672864854 ("staging: sm7xxfb: merge sm712fb with fbdev")
CC: Andy Shevchenko
Signed-off-by: Dejin Zheng
--
On Wed, Apr 22, 2020 at 05:40:51PM +0300, Andy Shevchenko wrote:
> On Wed, Apr 22, 2020 at 4:52 PM Dejin Zheng wrote:
> >
> > On Tue, Apr 21, 2020 at 08:24:24PM +0300, Andy Shevchenko wrote:
> > > On Tue, Apr 21, 2020 at 7:45 PM Dejin Zheng wrote:
> > > >
>
On Thu, Apr 23, 2020 at 02:14:48PM +0200, Markus Elfring wrote:
> > the sfb->fb->screen_base is not save the value get by iounmap() when
> > the chip id is 0x720.
>
> I suggest to improve this change description.
> How did you determine relevant differences for the mentioned chip model?
>
Read and
On Thu, Apr 23, 2020 at 12:14:20PM +0200, Gerd Hoffmann wrote:
> Hi,
>
> > I am a newbie, andy gave me some directions to submit the patch, eg: check
> > ioremap leak. At this time, I found that the bochs driver may have similar
> > problems, so I submitted this patch, then, Andy said the best i
On Thu, Apr 23, 2020 at 04:55:35PM +0200, Bartlomiej Zolnierkiewicz wrote:
>
> Hi,
>
> I believe that the patch summary line should be:
>
> "[PATCH v2] console: newport_con: ..."
>
OK, thanks!
> On 4/23/20 4:26 PM, Dejin Zheng wrote:
> > A call of the fu
On Thu, Apr 23, 2020 at 01:10:14PM +0200, Markus Elfring wrote:
> > if do_take_over_console() return an error in the newport_probe(),
> > due to the io virtual address is not released, it will cause a leak.
>
> How do you think about a wording variant like the following?
>
>Subject:
>[PAT
On Thu, Apr 23, 2020 at 05:52:09PM +0300, Andy Shevchenko wrote:
> On Thu, Apr 23, 2020 at 5:26 PM Dejin Zheng wrote:
> >
> > A call of the function do_take_over_console() can fail here.
> > The corresponding system resources were not released then.
> > Thus add a c
On Thu, Apr 23, 2020 at 05:23:29PM +0200, Markus Elfring wrote:
> >> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/scripts/coccinelle/free/iounmap.cocci
> >>
> >> How do you think about to extend presented software analysis approaches?
> >>
> > Sorry, I am not familiar wit
("[PATCH] VT binding: Make newport_con support binding")
Cc: Andy Shevchenko
Suggested-by: Bartlomiej Zolnierkiewicz
Signed-off-by: Dejin Zheng
---
v2 -> v3:
- modify commit tag CC to Cc by Andy's suggestion.
- modify Subject 'console: console:&#x
Shevchenko
Signed-off-by: Dejin Zheng
---
v1 -> v2:
- modify the commit comments by Markus'suggestion.
drivers/video/console/newport_con.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/video/console/newport_con.c
b/drivers/video/console/newport_con.c
On Fri, Apr 24, 2020 at 06:54:41PM +0200, Markus Elfring wrote:
> > The corresponding system resources were not released then.
>
> How do you think about a wording variant like the following?
>
Markus, I think my commit comments is a sufficiently clear description
for this patch. Someone has told
14 matches
Mail list logo
