Hi Maxime,
Thanks for the reviews.
On Fri, 14 Mar 2025 at 13:33, Maxime Ripard wrote:
> I also think that it's wrong, it's not just about audio. It just needs
> to be called as part of detect no matter what the status is. Audio is
> one thing that it will possibly handle depending on the driver,
Update the comment on drm_atomic_helper_connector_hdmi_hotplug() to
clarify that it must be called for all status updates.
Signed-off-by: David Turner
---
drivers/gpu/drm/display/drm_hdmi_state_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/display
Add ALSA jack detection to the vc4-hdmi audio driver so userspace knows
when to add/remove HDMI audio devices.
Signed-off-by: Stefan Wahren
Reviewed-by: Maxime Ripard
Signed-off-by: David Turner
---
drivers/gpu/drm/vc4/vc4_hdmi.c | 18 ++
drivers/gpu/drm/vc4/vc4_hdmi.h | 7
mitry Baryshkov
Signed-off-by: Stefan Wahren
Reviewed-by: Maxime Ripard
Signed-off-by: David Turner
---
drivers/gpu/drm/vc4/vc4_hdmi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/v
clarify that it must be called for disconnets too
Changes in V2:
- split initial patch into fix and jack detection feature as
suggested by Dmitry
Signed-off-by: David Turner
---
David Turner (2):
drm/display: Update comment on hdmi hotplug helper
drm/vc4: hdmi: Add jack detection to
Hi all,
On Thu, 6 Mar 2025 at 13:39, Maxime Ripard wrote:
> It looks fairly generic to me. Is there any reason you didn't put it in
> the HDMI audio helpers?
I originally wrote the downstream patch last year on 6.6, before the
generic HDMI audio code existed.
I just had a look at doing this. A
drm_atomic_helper_connector_hdmi_hotplug() to
clarify that it must be called for disconnets too
Changes in V2:
- split initial patch into fix and jack detection feature as
suggested by Dmitry
Signed-off-by: David Turner
---
David Turner (1):
drm/vc4: hdmi: Add jack detection to HDMI audio driver
Stefan Wahren (1
Add ALSA jack detection to the vc4-hdmi audio driver so userspace knows
when to add/remove HDMI audio devices.
Signed-off-by: Stefan Wahren
Signed-off-by: David Turner
---
drivers/gpu/drm/vc4/vc4_hdmi.c | 18 ++
drivers/gpu/drm/vc4/vc4_hdmi.h | 7 +++
2 files changed, 25
Fixes: 2ea9ec5d2c20 ("drm/vc4: hdmi: use
drm_atomic_helper_connector_hdmi_hotplug()")
Suggested-by: Dmitry Baryshkov
Signed-off-by: Stefan Wahren
Signed-off-by: David Turner
---
drivers/gpu/drm/display/drm_hdmi_state_helper.c | 3 ++-
drivers/gpu/drm/vc4/vc4_hdmi.c | 4 ++--
