[ANNOUNCE] kmscon: Lazy-web's DRM based terminal emulator

2012-04-01 Thread David Herrmann
Hi On Wed, Mar 28, 2012 at 7:30 PM, Jesse Barnes wrote: > On Tue, 27 Mar 2012 16:57:29 +0200 > David Herrmann wrote: > >> Hi >> >> Motivated by Jesse's letter to the lazyweb [1] I worked on a kmscon >> program. It provides a >> terminal-emulator simi

[PATCH] egl-fbdev: Fix compile-error by including errno.h

2012-04-14 Thread David Herrmann
We use errno and EINVAL so include errno.h. Signed-off-by: David Herrmann --- src/gallium/state_trackers/egl/fbdev/native_fbdev.c |1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/state_trackers/egl/fbdev/native_fbdev.c b/src/gallium/state_trackers/egl/fbdev/native_fbdev.c

[PATCH RESEND] egl-fbdev: Fix compile-error by including errno.h

2012-04-22 Thread David Herrmann
27;ed mesa-dev and the people who reviewed the original patch this time as I have no idea who I need to send this to. Thanks David ** egl-fbdev: Fix compile-error by including errno.h We use errno and EINVAL so include errno.h. Signed-off-by: Davi

[PATCH RESEND] egl-fbdev: Fix compile-error by including errno.h

2012-04-29 Thread David Herrmann
We use errno and EINVAL so include errno.h. This patch introduced this bug: http://cgit.freedesktop.org/mesa/mesa/commit/src/gallium/state_trackers/egl/fbdev/native_fbdev.c?id=b60120608f6ddf4098bc324363197c979ee04cb7 Signed-off-by: David Herrmann Cc: Chia-I Wu Cc: Dave Airlie Cc: Adam Jackson

FOSDEM2013: DevRoom or not?

2012-12-26 Thread David Herrmann
Hi Michael On Sat, Dec 1, 2012 at 3:54 AM, Michael Hasselmann wrote: > On Fri, 2012-09-28 at 23:51 +0200, Luc Verhaegen wrote: >> We still have, i hope (depends on what the FOSDEM organizers have left >> for us), 6 slots fully open: first come first serve, and the earlier >> bird gets the nicer s

DRM KMS Modesetting

2011-11-14 Thread David Herrmann
Hi I thought it's better to ask this question here again as it is easier to comment via mail. I tried writing a simple kms modesetting program. I have written it similar to: http://virtuousgeek.org/blog/index.php/jbarnes?blog=2&title=writing_stanalone_programs_with_egl_and_ and wayland compositor

DRM KMS Modesetting

2011-11-14 Thread David Herrmann
On Mon, Nov 14, 2011 at 9:38 PM, Jesse Barnes wrote: > On Mon, 14 Nov 2011 21:25:56 +0100 > David Herrmann wrote: > >> Hi >> >> I thought it's better to ask this question here again as it is easier >> to comment via mail. >> >> I tried writing a

DRM KMS Modesetting

2011-11-15 Thread David Herrmann
2011/11/15 Kristian H?gsberg : > On Mon, Nov 14, 2011 at 5:54 PM, Jesse Barnes > wrote: >> On Mon, 14 Nov 2011 21:47:09 +0100 >> David Herrmann wrote: >>> > I had to modify the resolution the test was searching for >>> > to 1920x1200 instead o

DRM KMS Modesetting

2011-11-18 Thread David Herrmann
2011/11/15 Kristian H?gsberg : > 2011/11/15 David Herrmann : >> 2011/11/15 Kristian H?gsberg : >>> On Mon, Nov 14, 2011 at 5:54 PM, Jesse Barnes >>> wrote: >>>> On Mon, 14 Nov 2011 21:47:09 +0100 >>>> David Herrmann wrote: >>>&g

DRM KMS Modesetting

2011-11-18 Thread David Herrmann
On Fri, Nov 18, 2011 at 10:41 PM, Jesse Barnes wrote: > On Fri, 18 Nov 2011 22:35:13 +0100 > David Herrmann wrote: > >> 2011/11/15 Kristian H?gsberg : >> > 2011/11/15 David Herrmann : >> >> 2011/11/15 Kristian H?gsberg : >> >>

[PATCH 1/2] simplefb: fix unmapping fb during destruction

2013-10-02 Thread David Herrmann
e with the parent-device removal. Instead, we rely on unregister_framebuffer() as barrier and we're safe. Reported-by: Tom Gundersen Signed-off-by: David Herrmann --- Hi I know that simplefb was supposed to stay "as simple as possible" but I really think this series is the

[PATCH 2/2] simplefb: use write-combined remapping

2013-10-02 Thread David Herrmann
Framebuffers shouldn't be cached and it is usually very uncommon to read them. Therefore, use ioremap_wc() to get significant speed improvements on systems which provide it. On all other systems it's aliased to ioremap_nocache() which is also fine. Reported-by: Tom Gundersen Signed-off

Re: [REGRESSION] v3.12-rc1: i915_driver_load oopses when sysfb enabled

2013-10-02 Thread David Herrmann
Hi Tom On Sun, Sep 8, 2013 at 11:38 AM, Tom Gundersen wrote: > On Sun, Sep 8, 2013 at 2:13 AM, David Herrmann wrote: >> Hi >> >> On Sun, Sep 8, 2013 at 1:22 AM, Tom Gundersen wrote: >>> Hi David, >>> >>> On Sat, Sep 7, 2013 at 11:57 PM, Tom Gunde

Re: [PATCH v4 1/6] drm: add SimpleDRM driver

2013-10-02 Thread David Herrmann
Hi Tom On Sat, Sep 21, 2013 at 4:18 PM, Tom Gundersen wrote: > Hi David, > > On Sun, Sep 1, 2013 at 3:36 PM, David Herrmann wrote: >> The SimpleDRM driver binds to simple-framebuffer devices and provides a >> DRM/KMS API. It provides only a single CRTC+encoder+connector co

Re: [PATCH 1/2] simplefb: fix unmapping fb during destruction

2013-10-02 Thread David Herrmann
Hi On Wed, Oct 2, 2013 at 6:16 PM, Stephen Warren wrote: > On 10/02/2013 08:58 AM, David Herrmann wrote: >> Unfortunately, fbdev does not create its own "struct device" for >> framebuffers. Instead, it attaches to the device of the parent layer. This >> has the

Re: [PATCH 2/5] drm: merge device setup into drm_dev_register()

2013-10-03 Thread David Herrmann
Hi Daniel On Thu, Oct 3, 2013 at 3:15 PM, Daniel Vetter wrote: > On Wed, Oct 02, 2013 at 11:23:35AM +0200, David Herrmann wrote: >> All bus drivers do device setup themselves. This requires us to adjust all >> of them if we introduce new core features. Thus, merge all these in

Re: SimpleFB drivers repository?

2013-10-14 Thread David Herrmann
Hi On Mon, Oct 14, 2013 at 6:19 PM, Gary Mort wrote: > Is there a repository for the SimpleFB drivers[the DRI driver and the plain > framebuffer driver]? Which drivers are you exactly talking about? Do you have links to the patches? There're several independent projects called "simplefb". If you

[PATCH 5/5] drm/i915: Kick out vga console

2014-06-30 Thread David Herrmann
Hi On Mon, Jun 30, 2014 at 8:59 AM, Chris Wilson wrote: > On Sat, Jun 28, 2014 at 11:55:19PM -0400, Ed Tomlinson wrote: >> On Saturday 28 June 2014 15:28:22 Ed Tomlinson wrote: >> >> Resend without html krud which causes list to bounce the message. >> >> > Hi >> > >> > This commit ( a4de05268e67

User ptr horror show

2014-06-30 Thread David Herrmann
Hi On Mon, Jun 30, 2014 at 8:21 PM, Jerome Glisse wrote: > So in light of the radeon patch to add user ptr, i took a look at > intel code and it is time to put an end to this non sense. It > violate so many mm assumptions that it just not a doable options. > > So Intel code only register a range_

User ptr horror show

2014-06-30 Thread David Herrmann
Hi On Mon, Jun 30, 2014 at 9:04 PM, Jerome Glisse wrote: > On Mon, Jun 30, 2014 at 08:47:31PM +0200, David Herrmann wrote: >> Additionally to what AIO and Direct-IO do, intel userptr adds the >> range_start callback to release pinned pages whenever the pages are >> unmapped

[PATCH 00/11] SimpleDRM & Sysfb

2014-03-03 Thread David Herrmann
Hi On Mon, Mar 3, 2014 at 11:12 AM, Tomi Valkeinen wrote: > Hi, > > On 23/01/14 16:14, David Herrmann wrote: >> Hi >> >> Another round of SimpleDRM patches. I somehow lost track of the last ones >> and as >> this is a major rewrite, I'll just sta

[PATCH 00/11] SimpleDRM & Sysfb

2014-03-03 Thread David Herrmann
Hi On Mon, Mar 3, 2014 at 11:45 AM, Tomi Valkeinen wrote: > On 03/03/14 12:29, David Herrmann wrote: > >>> What's the status with this one? Headed for 3.15? >>> >>> Are the SimpleDRM and sysfb linked somehow? (I.e. do they need to be in >>> the sa

[PATCH 1/4] drm: Add support for CRTC primary planes

2014-03-03 Thread David Herrmann
Hi On Thu, Feb 27, 2014 at 11:14 PM, Matt Roper wrote: > Allow drivers to provide a drm_plane structure corresponding to a CRTC's > primary plane. These planes will be included in the plane list for any > clients setting the DRM_CLIENT_CAP_EXPOSE_PRIMARY_PLANES capability bit. > > Signed-off-by

Should drm's modetest work when an X server is running?

2014-03-04 Thread David Herrmann
Hi On Tue, Mar 4, 2014 at 12:53 AM, Daniel Kurtz wrote: > Dear dri developers, > > Should libdrm's modetest work when an X server is running? > Should drmOpen(name, NULL) succeed when the drm device is already open? > Is "name" passed to drmOpen() the "drm" name returned by drmGetVersion()? > Or,

[PATCH 1/2] drm: Make control nodes master-less

2014-03-05 Thread David Herrmann
Hi On Wed, Feb 19, 2014 at 2:40 PM, Thomas Hellstrom wrote: > Like for render-nodes, there is no point in maintaining the master concept > for control nodes, so set the struct drm_file::master pointer to NULL. > > At the same time, make sure DRM_MASTER | DRM_CONTROL_ALLOW ioctls are always > all

[PATCH 2/2] drm: Remove the minor master list

2014-03-05 Thread David Herrmann
Hi On Wed, Feb 19, 2014 at 2:40 PM, Thomas Hellstrom wrote: > It doesn't appear to be used anywhere. Looks good. Reviewed-by: David Herrmann Thanks David > Signed-off-by: Thomas Hellstrom > --- > drivers/gpu/drm/drm_stub.c |5 - > include/drm/drmP.h

[PATCH 00/11] SimpleDRM & Sysfb

2014-03-06 Thread David Herrmann
Hi Tomi On Mon, Mar 3, 2014 at 12:22 PM, Tomi Valkeinen wrote: > On 03/03/14 13:09, David Herrmann wrote: > >>> What do you think, would it be possible to keep the sysfb stuff in >>> arch/x86, and still be able to do the rest of the stuff here? And then >>>

[RFC] drm: add kernel-log renderer

2014-03-06 Thread David Herrmann
disable CONFIG_FB, CONFIG_VT and CONFIG_FRAMEBUFFER_CONSOLE. Combined with a proper user-space system-console, you will end up with more features, less bugs and definitely some happy kernel maintainers. Signed-off-by: David Herrmann --- drivers/gpu/drm/Kconfig |6 + drivers/gpu/drm/Makefil

[RFC] drm: add kernel-log renderer

2014-03-07 Thread David Herrmann
Hi On Thu, Mar 6, 2014 at 10:56 PM, Bruno Pr?mont wrote: > Hi David, > > On Thu, 06 March 2014 David Herrmann wrote: >> On modern linux user-space, the VT subsystem is no longer needed for >> system consoles. Although most DEs will fail if VTs are disabled, there >> a

[RFC] drm: add kernel-log renderer

2014-03-07 Thread David Herrmann
Hi >> I don't think it makes sense to modify drm_log_ensure_size(). I mean, >> the worst that can happen is that the *text*-backlog is twice as big >> as required. But if you have a high-dpi display, you already require >> like 10x as much space for each framebuffer than for the entire >> log-buff

[PATCH 00/11] SimpleDRM & Sysfb

2014-03-07 Thread David Herrmann
Hi On Fri, Mar 7, 2014 at 1:44 PM, Tomi Valkeinen wrote: > On 06/03/14 14:16, David Herrmann wrote: >> Hi Tomi >> >> On Mon, Mar 3, 2014 at 12:22 PM, Tomi Valkeinen >> wrote: >>> On 03/03/14 13:09, David Herrmann wrote: >>> >>>>> Wha

[PATCH 00/11] SimpleDRM & Sysfb

2014-03-07 Thread David Herrmann
Hi Tomi On Fri, Mar 7, 2014 at 2:52 PM, Tomi Valkeinen wrote: > On 07/03/14 15:05, David Herrmann wrote: > >> If you can take these two patches, that's fine. They're not strictly >> needed by the series and I'd be happy to see them upstream. The other >>

[RFC] drm: add kernel-log renderer

2014-03-08 Thread David Herrmann
Hi On Fri, Mar 7, 2014 at 10:58 PM, One Thousand Gnomes wrote: >> - The renderer supports *any* RGB target, from 8bit to 32bit with >>big-endian and little-endian support. The related pixel-renderer will >>probably never win a beauty-contest, but it works.. Again, who cares >>for deb

[PATCH 1/2] drm: Make control nodes master-less

2014-03-12 Thread David Herrmann
Hi > You didn't miss any patches. It was I who missed the usage in drm_crtc.c. > I guess this, and Daniel's reply prompts a discussion about control > nodes and the master concept. > > First I'd like to give some background about the use-case: I'd like to > use the control node for a daemon that t

[PATCH 1/2] drm: Make control nodes master-less

2014-03-12 Thread David Herrmann
Hi >>> You didn't miss any patches. It was I who missed the usage in drm_crtc.c. >>> I guess this, and Daniel's reply prompts a discussion about control >>> nodes and the master concept. >>> >>> First I'd like to give some background about the use-case: I'd like to >>> use the control node for a d

[PATCH 1/5] drm: Have the crtc code only reference master from legacy nodes

2014-03-13 Thread David Herrmann
lace all these minor-id-tests with "if (!mode_group)". This moves the group-selection to the head of the function and makes the remaining parts just work on the selected group (or global if NULL). Same for the two conditions below.. Apart from that: Reviewed-by: David Herrma

[PATCH 2/5] drm: Break out ioctl permission check to a separate function

2014-03-13 Thread David Herrmann
} > + goto err_i1; > + } > > - if (cmd & IOC_IN) { > - if (copy_from_user(kdata, (void __user *)arg, > - usize) != 0) { > -

[PATCH 3/5] drm: Make control nodes master-less v2

2014-03-13 Thread David Herrmann
Hi On Thu, Mar 13, 2014 at 11:57 AM, Thomas Hellstrom wrote: > Like for render-nodes, there is no point in maintaining the master concept > for control nodes, so set the struct drm_file::master pointer to NULL. > > At the same time, make sure DRM_MASTER | DRM_CONTROL_ALLOW ioctls are always > all

[PATCH 2/5] drm: Break out ioctl permission check to a separate function

2014-03-13 Thread David Herrmann
Hi On Thu, Mar 13, 2014 at 1:11 PM, Thomas Hellstrom wrote: > Hi. > > Thanks for reviewing. I'll incorporate your suggestions, except this > one, and resend. > > > On 03/13/2014 12:19 PM, David Herrmann wrote: >> Hi >> >> On Thu, Mar 13,

[PULL 1/3] drm-fixes

2014-03-16 Thread David Herrmann
t "ret" in drm_gem_mmap() (2014-03-16 12:11:01 +0100) ---- David Herrmann (6): drm/udl: fix error-path when damage-req fails drm/udl: fix Bpp calculation in dumb_create() drm/gem: fix indentation drm/gem: free vm

[PULL 0/3] Pending patches for 3.15

2014-03-16 Thread David Herrmann
Hi Dave As requested, these 3 pulls contain all my pending patches for 3.15. Branch #1 should be fairly trivial, all reviewed and minor fixes. Branch #2 contains the drm-minor rework, which have also been on the list and reviewed/tested by Daniel and Thierry. Branch #3 contains the drm-anon stuff

[PULL 2/3] drm-minor

2014-03-16 Thread David Herrmann
drm-minor for you to fetch changes up to 0d639883ee26359e1bf38195df1dbca0f879e239: drm: make minors independent of global lock (2014-03-16 12:54:21 +0100) -------- David Herrmann (14): drm: group dev-lifetime related members

[PULL 3/3] drm-anon

2014-03-16 Thread David Herrmann
non for you to fetch changes up to 44d847b7439bdea0b6c5640446427daa3ebcc7fa: drm: init TTM dev_mapping in ttm_bo_device_init() (2014-03-16 12:23:42 +0100) ---- David Herrmann (3): drm: add pseudo filesystem for shared inodes

[PATCH] drm: enable render-nodes by default

2014-03-16 Thread David Herrmann
We introduced render-nodes about 1/2 year ago and no problems showed up. Remove the drm_rnodes argument and enable them by default now. Signed-off-by: David Herrmann --- Hi Dave This does _not_ depend on the "drm-minor" branch. We decided to not provide reliable minor-numbers. User-sp

[PATCH v2] drm: enable render-nodes by default

2014-03-17 Thread David Herrmann
We introduced render-nodes about 1/2 year ago and no problems showed up. Remove the drm_rnodes argument and enable them by default now. Signed-off-by: David Herrmann Acked-by: Daniel Vetter --- v2: - rebased on drm-next drivers/gpu/drm/drm_stub.c | 7 +-- include/drm/drmP.h | 1

[PATCH RFC] drm: Make the drm_vma_manager authentication mechanism a bit more versatile

2014-03-19 Thread David Herrmann
, I'm fine with that. Just make sure you don't use drm_vma_node_verify_access for TTM directly as TTM passes in a file pointer. Reviewed-by: David Herrmann Thanks David > Signed-off-by: Thomas Hellstrom > --- > drivers/gpu/drm/drm_vma_manager.c | 22 +++

[PATCH 0/6] File Sealing & memfd_create()

2014-03-19 Thread David Herrmann
independent, but the described use-cases would greatly benefit from the combination of both. Hence, I merged them into the same series. Please also note that this series is based on earlier works (ashmem, memfd, shmgetfd, ..) and unifies these attempts. Comments welcome! Thanks David David Her

[PATCH 1/6] fs: fix i_writecount on shmem and friends

2014-03-19 Thread David Herrmann
doesn't use alloc_file() (and thus not affected by this bug), it's rather unlikely that this is a serious issue. But stuff like anon_inode shares a *single* inode across a huge set of interfaces. If any of these is broken like pipe(), it will affect all of these (ranging from dma-buf t

[PATCH 2/6] shm: add sealing API

2014-03-19 Thread David Herrmann
sers (just like mandatory locking). Signed-off-by: David Herrmann --- fs/fcntl.c | 12 ++- include/linux/shmem_fs.h | 17 include/uapi/linux/fcntl.h | 13 +++ mm/shmem.c | 200 - 4 files changed, 236 insertions(+), 6 d

[PATCH 3/6] shm: add memfd_create() syscall

2014-03-19 Thread David Herrmann
ompared to O_TMPFILE, it does not require a tmpfs mount-point and is not subject to quotas and alike. Signed-off-by: David Herrmann --- arch/x86/syscalls/syscall_32.tbl | 1 + arch/x86/syscalls/syscall_64.tbl | 1 + include/linux/syscalls.h | 1 + include/uapi/linux/memfd.h | 9

[PATCH 4/6] selftests: add memfd_create() + sealing tests

2014-03-19 Thread David Herrmann
Some basic tests to verify sealing on memfds works as expected and guarantees the advertised semantics. Signed-off-by: David Herrmann --- tools/testing/selftests/Makefile | 1 + tools/testing/selftests/memfd/.gitignore | 2 + tools/testing/selftests/memfd/Makefile | 29

[PATCH man-pages 5/6] fcntl.2: document SHMEM_SET/GET_SEALS commands

2014-03-19 Thread David Herrmann
The SHMEM_GET_SEALS and SHMEM_SET_SEALS commands allow retrieving and modifying the active set of seals on a file. They're only supported on selected file-systems (currently shmfs) and are linux-only. Signed-off-by: David Herrmann --- man2/fcntl.2

[PATCH man-pages 6/6] memfd_create.2: add memfd_create() man-page

2014-03-19 Thread David Herrmann
The memfd_create() syscall creates anonymous files similar to O_TMPFILE but does not require an active mount-point. Signed-off-by: David Herrmann --- man2/memfd_create.2 | 110 1 file changed, 110 insertions(+) create mode 100644 man2

[PATCH v2] drm: enable render-nodes by default

2014-03-20 Thread David Herrmann
Hi On Thu, Mar 20, 2014 at 7:43 AM, Thomas Hellstrom wrote: > On 03/17/2014 05:43 PM, David Herrmann wrote: >> We introduced render-nodes about 1/2 year ago and no problems showed up. >> Remove the drm_rnodes argument and enable them by default now. > > So what about

[PATCH 0/6] File Sealing & memfd_create()

2014-03-20 Thread David Herrmann
Hi On Thu, Mar 20, 2014 at 4:49 AM, Linus Torvalds wrote: > Is there really any use-case where the sealer isn't also the same > thing that *created* the file in the first place? Because I would be a > ton happier with the notion that you can only seal things that you > yourself created. At that p

[PATCH v2] drm: enable render-nodes by default

2014-03-20 Thread David Herrmann
Hi Thomas On Thu, Mar 20, 2014 at 9:48 AM, Thomas Hellstrom wrote: > I'm merely trying to envision the situation where a distro wants to > create, for example an udev rule for the render nodes. > > How should the distro know that the implementation is not insecure? > > Historically drm has refus

[PATCH v2] drm: enable render-nodes by default

2014-03-20 Thread David Herrmann
Hi On Thu, Mar 20, 2014 at 10:27 AM, Thomas Hellstrom wrote: > A user logs in to a system where DRI clients use render nodes. The > system grants rw permission on the render nodes for the console user. > User starts editing a secret document, starts some GPGPU structural FEM > computations of th

[PATCH 3/6] shm: add memfd_create() syscall

2014-03-20 Thread David Herrmann
Hi On Thu, Mar 20, 2014 at 10:01 AM, Pavel Emelyanov wrote: > On 03/20/2014 12:47 PM, Cyrill Gorcunov wrote: >> If I'm not mistaken in something obvious, this looks similar to >> /proc/pid/map_files >> feature, Pavel? > > It is, but the map_files will work "in the opposite direction" :) In the

[PATCH 0/6] File Sealing & memfd_create()

2014-03-20 Thread David Herrmann
Hi On Thu, Mar 20, 2014 at 3:41 PM, One Thousand Gnomes wrote: > I think you want two things at minimum > > owner to seal > root can always override Why should root be allowed to override? > I would query the name too. Right now your assumption is 'shmem only' but > that might change with other

[PATCH 0/6] File Sealing & memfd_create()

2014-03-20 Thread David Herrmann
Hi On Thu, Mar 20, 2014 at 4:32 PM, wrote: > Why not make sealing an attribute of the "struct file", and enforce it > at the VFS layer? That way all file system objects would have access > to sealing interface, and for memfd_shmem, you can't get another > struct file pointing at the object, the

dma-buf and ->dev refcount fun

2014-03-25 Thread David Herrmann
Hi On Tue, Mar 25, 2014 at 9:01 AM, Daniel Vetter wrote: > Besides the issue at hand though I think drivers need to make sure > that the device they use for attaching does outlive the dma-buf. Which > for real hotpluggin probably means that drivers need to drop all > attachment on unplug (the dma

[PATCH v2 4/4] Documentation: drm: describing plane alpha and color blending property

2014-03-26 Thread David Herrmann
Hi On Tue, Mar 25, 2014 at 3:32 PM, wrote: > From: Sagar Kamble > > v2: Added description for "src-color" and "constant-alpha" property. > > Cc: Rob Landley > Cc: Dave Airlie > Cc: Daniel Vetter > Cc: Laurent Pinchart > Cc: David Herrmann

[PATCH] drm: Try to acquire modeset lock on panic or sysrq

2014-03-26 Thread David Herrmann
per->dev; > + > + if (dev->switch_power_state == DRM_SWITCH_POWER_OFF) > + continue; > + > + if (!mutex_trylock(&dev->mode_config.mutex)) { > + error = true; Reviewed-by: David Herrmann Thanks David

[PATCH 04/16] drm: Improve on minor type helpers v2

2014-03-26 Thread David Herrmann
Hi On Tue, Mar 25, 2014 at 2:18 PM, Thomas Hellstrom wrote: > Add a drm_is_legacy() helper, constify argument to drm_is_render_client(), > and use / change helpers where appropriate. > > v2: s/drm_is_legacy/drm_is_legacy_client/ and adapt to new code context. Could we avoid using "legacy" for t

[PATCH 03/16] drm: Make control nodes master-less v3

2014-03-26 Thread David Herrmann
s are always > allowed when called through the control node. Previously the caller also > needed to be master. > > v2: Adapt to refactoring of ioctl permission check. > v3: Formatting of logical expression. Use drm_is_control_client() instead of > drm_is_control(). Looks good now

[PATCH 06/16] drm: Protect the master management with a drm_device::master_mutex

2014-03-26 Thread David Herrmann
Hi On Tue, Mar 25, 2014 at 2:18 PM, Thomas Hellstrom wrote: > The master management was previously protected by the > drm_device::struct_mutex. > In order to avoid locking order violations in a reworked dropped master > security check in the vmwgfx driver, break it out into a separate > master

[PATCH v3 1/1] Documentation: drm: describing plane alpha and color blending property

2014-03-27 Thread David Herrmann
Hi On Thu, Mar 27, 2014 at 10:50 AM, wrote: > From: Sagar Kamble > > v2: Added description for "src-color" and "constant-alpha" property. > [Review by Laurent Pinchart] > > v3: Fixed typos. [Review by David Herrmann] > > Cc: Rob Landley

[PATCH 06/16] drm: Protect the master management with a drm_device::master_mutex

2014-03-28 Thread David Herrmann
Hi On Wed, Mar 26, 2014 at 9:40 PM, Thomas Hellstrom wrote: >> - Why don't add a spin-lock to "drm_file" instead? Use that one to >> manage master contexts, but keep "struct_mutex" whenever calling into >> driver callbacks (set_master/drop_master) > > See above. We can't have a lock in the drm_

[PATCH 06/16] drm: Protect the master management with a drm_device::master_mutex v2

2014-03-28 Thread David Herrmann
Hi On Thu, Mar 27, 2014 at 9:23 PM, Thomas Hellstrom wrote: > The master management was previously protected by the > drm_device::struct_mutex. > In order to avoid locking order violations in a reworked dropped master > security check in the vmwgfx driver, break it out into a separate > master

[PATCH 06/16] drm: Protect the master management with a drm_device::master_mutex v3

2014-03-28 Thread David Herrmann
Hi On Fri, Mar 28, 2014 at 10:34 AM, Thomas Hellstrom wrote: > The master management was previously protected by the > drm_device::struct_mutex. > In order to avoid locking order violations in a reworked dropped master > security check in the vmwgfx driver, break it out into a separate > master

[PATCH 06/16] drm: Protect the master management with a drm_device::master_mutex v3

2014-03-28 Thread David Herrmann
Hi On Fri, Mar 28, 2014 at 12:52 PM, Thomas Hellstrom wrote: > Thanks. Want a Reviewed-By: or Acked-By: added? Oh, sure: Reviewed-by: David Herrmann Thanks David

Atomicity in KMS panic notifier

2014-05-06 Thread David Herrmann
Hi On Tue, May 6, 2014 at 3:27 PM, Takashi Iwai wrote: > At Mon, 5 May 2014 16:52:45 +0200, > Daniel Vetter wrote: >> >> On Mon, May 5, 2014 at 4:48 PM, Takashi Iwai wrote: >> > >> > The current problem I see is that the rest of panic notifier chain >> > won't be called once when we hit the prob

Atomicity in KMS panic notifier

2014-05-06 Thread David Herrmann
Hi On Tue, May 6, 2014 at 3:38 PM, Takashi Iwai wrote: > At Tue, 6 May 2014 15:32:21 +0200, > David Herrmann wrote: >> fbcon is called through the VT or fbdev layer, which is called by >> bust_spinlocks(1) via either unblank_screen() or console_unblank(). > > You mean

[Intel-gfx] Design review request: DRM color manager

2014-05-12 Thread David Herrmann
Hi On Mon, May 12, 2014 at 12:26 PM, Sharma, Shashank wrote: > Benefits of using color manager: > > 1. Unique framework for all the color correction properties, across all >DRM drivers, across various platforms. > 2. Only one set/get call for all kind of prope

[Intel-gfx] Design review request: DRM color manager

2014-05-12 Thread David Herrmann
Hi On Mon, May 12, 2014 at 5:28 PM, Daniel Vetter wrote: > Those are all just reasons for atomic modeset and maybe an atomic modeget > ioctl which transfers the entire blob of things. Maybe we should start > with the atomic modeget to get things rolling. Otoh you can always do that > in userspace

[PATCH 09/10] i915: add DP 1.2 MST support (v0.3)

2014-05-13 Thread David Herrmann
Hi Dave On Mon, May 12, 2014 at 8:46 AM, Dave Airlie wrote: > From: Dave Airlie > > This adds DP 1.2 MST support on Haswell systems. > > Notes: > a) this reworks irq handling for DP MST ports, so that we can > avoid the mode config locking in the current hpd handlers, as > we need to process up/

[PATCH v2 1/7] drm: Introduce drm_set_unique()

2014-05-13 Thread David Herrmann
ent */ as it is part of device initialization and API. > }; > > #define DRM_SWITCH_POWER_ON 0 > @@ -1680,6 +1682,7 @@ static __inline__ void drm_core_dropmap(struct > drm_local_map *map) > > #include > > +int drm_set_unique(struct drm_device *dev, const char *fmt, ...); Again just a minor style-nitpick: Move that below the drm_dev_*() declarations, not above. Usual kernel-style is to have allocators/lifetime-management first, followed by runtime management. Otherwise looks good: Reviewed-by: David Herrmann Thanks David > struct drm_device *drm_dev_alloc(struct drm_driver *driver, > struct device *parent); > void drm_dev_ref(struct drm_device *dev); > -- > 1.9.2 >

[PATCH v2 7/7] drm: Document how to register devices without struct drm_bus

2014-05-13 Thread David Herrmann
Hi On Tue, May 13, 2014 at 5:30 PM, Thierry Reding wrote: > From: Thierry Reding > > With the recent addition of the drm_set_unique() function, devices can > now be registered without requiring a drm_bus. Add a brief description > to the DRM docbook to show how that can be achieved. > > Signed-o

[PATCH 09/10] i915: add DP 1.2 MST support (v0.3)

2014-05-14 Thread David Herrmann
Hi On Wed, May 14, 2014 at 2:03 AM, Dave Airlie wrote: > Since any objects you get with find are only valid under mode_config.mutex, > yes some drivers mess this up, but they should be fixed. Didn't know that we have such a rule. Then it's fine, of course. The page-flip code is what worried me,

Adopt a libdrm man page

2012-09-17 Thread David Herrmann
Hi Jesse On Mon, Sep 17, 2012 at 5:12 PM, Jesse Barnes wrote: > I just pushed some basic man page stuff to the libdrm repo, but won't > have time to do any more pages for the next week or two. > > But regardless, it would be cool if people could adopt some pages and > push them out. The goal is

[PATCH libdrm 0/4] Overview man-pages for libdrm

2012-09-23 Thread David Herrmann
really ugly to read. Regards David Some parts are copied from (I hope nobody minds?): http://lwn.net/Articles/283798/ http://lwn.net/Articles/499261/ David Herrmann (4): man: use automake man_MANS to allow multiple suffixes man: add man/drm.7 overview page man: add KMS overview pa

[PATCH libdrm 1/4] man: use automake man_MANS to allow multiple suffixes

2012-09-23 Thread David Herrmann
-page headers. Signed-off-by: David Herrmann --- man/Makefile.am | 16 +++- man/drmAvailable.3 | 26 + man/drmAvailable.man| 25 - man/drmHandleEvent.3| 48 man/drmHandleEvent.man | 45

[PATCH libdrm 2/4] man: add man/drm.7 overview page

2012-09-23 Thread David Herrmann
. Signed-off-by: David Herrmann --- man/Makefile.am | 1 + man/drm.7 | 99 + 2 files changed, 100 insertions(+) create mode 100644 man/drm.7 diff --git a/man/Makefile.am b/man/Makefile.am index f003101..6193a95 100644 --- a/man

[PATCH libdrm 3/4] man: add KMS overview page

2012-09-23 Thread David Herrmann
, framebuffers, planes and cursors. Signed-off-by: David Herrmann --- man/Makefile.am | 1 + man/drm-kms.7 | 269 2 files changed, 270 insertions(+) create mode 100644 man/drm-kms.7 diff --git a/man/Makefile.am b/man/Makefile.am index 6193a95

[PATCH libdrm 4/4] man: add drm-memory man-page

2012-09-23 Thread David Herrmann
driver-dependent information is needed. Signed-off-by: David Herrmann --- man/Makefile.am | 4 + man/drm-gem.7| 1 + man/drm-memory.7 | 412 +++ man/drm-mm.7 | 1 + man/drm-ttm.7| 1 + 5 files changed, 419 insertions(+) create

[PATCH libdrm 4/4] man: add drm-memory man-page

2012-09-24 Thread David Herrmann
Hi Michel On Mon, Sep 24, 2012 at 9:45 AM, Michel D?nzer wrote: > On Son, 2012-09-23 at 16:40 +0200, David Herrmann wrote: >> + >> +.SS TTM >> +.B TTM >> +stands for >> +.B Translation Table Manager >> +and is another generic memory-manager provided by the

[PATCH libdrm 0/4] Overview man-pages for libdrm

2012-09-24 Thread David Herrmann
Hi Thierry On Mon, Sep 24, 2012 at 9:51 PM, Thierry Reding wrote: > On Sun, Sep 23, 2012 at 04:40:03PM +0200, David Herrmann wrote: >> Hi >> >> This tries to continue the effort to document libdrm. I actually removed the >> X11-like man-page generation code as autotool

[PATCH libdrm 0/4] Manpages for libdrm

2012-09-28 Thread David Herrmann
. Thanks for reviewing! Regards David David Herrmann (4): man: convert manpages to XML instead of plain troff man: add drm.7 overview page man: add drm-kms overview page man: add drm-memory overview page .gitignore | 4 + configure.ac| 24 +-- man

[PATCH libdrm 1/4] man: convert manpages to XML instead of plain troff

2012-09-28 Thread David Herrmann
If we want to use the manpages in external documentation other than normal manpages, we should rather use XML. Furthermore, almost no-one knows troff today, anyway, and XML allows others to easily add more pages without having to learn troff. Signed-off-by: David Herrmann --- .gitignore

[PATCH libdrm 2/4] man: add drm.7 overview page

2012-09-28 Thread David Herrmann
The drm.xml file compiles to drm.7 and is meant as a global overview page for libdrm. It is targeted to new users of libdrm and redirects to all other main man-pages. Signed-off-by: David Herrmann Reviewed-by: Jesse Barnes --- man/Makefile.am | 1 + man/drm.xml | 137

[PATCH libdrm 3/4] man: add drm-kms overview page

2012-09-28 Thread David Herrmann
This is an overview page for KMS. It is again targeted at novice users that need redirection to the correct function man-pages. Signed-off-by: David Herrmann Reviewed-by: Jesse Barnes --- man/Makefile.am | 1 + man/drm-kms.xml | 342 2

[PATCH libdrm 4/4] man: add drm-memory overview page

2012-09-28 Thread David Herrmann
This adds an overview page that describes Dumb-Buffers, TTM and GEM. It does not describe chipset-specific features. You should do that in the driver-manpages. Signed-off-by: David Herrmann Reviewed-by: Jesse Barnes --- man/Makefile.am| 9 +- man/drm-memory.xml | 430

Standalone DRM application

2013-04-18 Thread David Herrmann
Hi On Wed, Apr 17, 2013 at 11:05 PM, Byron Stanoszek wrote: > David, > > I'm developing a small application that uses libdrm (DRM ioctls) to change > the > resolution of a single graphics display and show a framebuffer. I've run > into > two problems with this implementation that I'm hoping you c

[PATCH] drm: don't push static constants on stack for %*ph

2013-08-02 Thread David Herrmann
Hi On Fri, Aug 2, 2013 at 1:09 PM, Andy Shevchenko wrote: > There is no need to pass constants via stack. The width may be explicitly > specified in the format. Yupp, all 3 make sense and actually speed up "format_decode()". Reviewed-by: David Herrmann Regards David >

[PATCH 3/3] drm: Remove drm_mode_validate_clocks

2013-08-02 Thread David Herrmann
Hi On Wed, Jul 31, 2013 at 2:23 AM, St?phane Marchesin wrote: > Signed-off-by: St?phane Marchesin Something like "unused" in the commit message makes "git log [--oneline]" much more verbose without the need to read the patch. Apart from that: Reviewed-by: David Herrma

[PATCH 1/4] drm/mm: add "best_match" flag to drm_mm_insert_node()

2013-08-06 Thread David Herrmann
Hi On Mon, Aug 5, 2013 at 9:46 AM, Daniel Vetter wrote: > On Sat, Jul 27, 2013 at 01:36:27PM +0200, David Herrmann wrote: >> Add a "best_match" flag similar to the drm_mm_search_*() helpers so we >> can convert TTM to use them in follow up patches. We can also inline t

[drm-intel:drm-intel-nightly 243/249] undefined reference to `drm_agp_clear'

2013-08-07 Thread David Herrmann
Hi On Wed, Aug 7, 2013 at 10:19 AM, kbuild test robot wrote: > tree: git://people.freedesktop.org/~danvet/drm-intel.git drm-intel-nightly > head: 3224cf6c3ee5ab9c280052c9fbed4f660310c411 > commit: 28ec711cd427f8b61f73712a43b8100ba8ca933b [243/249] drm/agp: move AGP > cleanup paths to drm_agp

[PATCH] drm: Fix undefined reference to drm_agp_clear() on non-AGP platforms

2013-08-07 Thread David Herrmann
Hi On Wed, Aug 7, 2013 at 2:39 PM, Laurent Pinchart wrote: > Hi Daniel, > > On Wednesday 07 August 2013 14:19:34 Daniel Vetter wrote: >> On Wed, Aug 7, 2013 at 2:17 PM, Laurent Pinchart wrote: >> > The drm_agp_clear() function is only defined on platforms with AGP >> > support. Move the drm_core_

[PATCH] drm: provide agp dummies for CONFIG_AGP=n

2013-08-07 Thread David Herrmann
d by: commit 28ec711cd427f8b61f73712a43b8100ba8ca933b Author: David Herrmann Date: Sat Jul 27 16:37:00 2013 +0200 drm/agp: move AGP cleanup paths to drm_agpsupport.c Cc: Laurent Pinchart Cc: Daniel Vetter Signed-off-by: David Herrmann --- Hi guys I test-compiled this with AGP=y and AGP=n but I don't have the

[PATCH] drm: provide agp dummies for CONFIG_AGP=n

2013-08-07 Thread David Herrmann
Hi On Wed, Aug 7, 2013 at 5:53 PM, Laurent Pinchart wrote: > Hi David, > > On Wednesday 07 August 2013 15:53:15 David Herrmann wrote: >> We currently rely on gcc dead-code elimination so the drm_agp_* helpers >> are not called if drm_core_has_AGP() is false. That's

<    2   3   4   5   6   7   8   9   10   11   >