Hi
On Thu, Sep 11, 2014 at 3:06 PM, Daniel Vetter wrote:
> On Thu, Sep 11, 2014 at 02:22:55PM +0200, David Herrmann wrote:
>> actual-brightness is a bit more tricky. Currently, DRM caches property
>> values, so there is no read_property() hook. We'd have to add this.
>>
irectly passing
> in a variable as a format string.
>
> Signed-off-by: Kees Cook
Reviewed-by: David Herrmann
Thanks
David
> ---
> drivers/gpu/drm/ttm/ttm_memory.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_memory.c
Hi
On Fri, Sep 19, 2014 at 10:11 AM, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann
> ---
> drivers/gpu/drm/cirrus/cirrus_mode.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/cirrus/cirrus_mode.c
> b/drivers/gpu/drm/cirrus/cirrus_mode.c
> index e1c5c32..c7c5a9d
Hi
On Mon, Sep 8, 2014 at 10:43 AM, Boris BREZILLON
wrote:
[snip]
> +static int atmel_hlcdc_dc_drm_probe(struct platform_device *pdev)
> +{
> + int ret;
> +
> + ret = dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(32));
> + if (ret)
> + return ret;
> +
> + re
Hi
On Fri, Sep 19, 2014 at 7:47 AM, Mark yao wrote:
[snip]
> +static int rockchip_drm_bind(struct device *dev)
> +{
> + return drm_platform_init(&rockchip_drm_driver,
> to_platform_device(dev));
Please avoid drm_platform_*() usage. We're about to drop all the
drm_bus midlayers. See the te
Alex Deucher
> Cc: "Christian K?nig"
> Cc: David Herrmann
> Cc: Rashika
> Cc: Josh Triplett
> Cc: Daniel Vetter
> Cc: Fabian Frederick
> Cc: Gerd Hoffmann
> Cc: Ben Skeggs
> Cc: Alexandre Courbot
> Cc: Maarten Lankhorst
> Cc: Christian Engelmay
drm_gem_mmap) in i915, not in the core code.
Agreed! Drivers should just add the hacks themselves if there is
user-space that needs it. Same as for patch #1:
Reviewed-by: David Herrmann
Thanks
David
> So good riddance to another entry point of the legacy buffer mapping
> code.
>
>
somehow I've missed that in my
> previous header rework.
Reviewed-by: David Herrmann
Thanks
David
> Signed-off-by: Daniel Vetter
> ---
> drivers/gpu/drm/drm_internal.h | 1 -
> drivers/gpu/drm/drm_vm.c| 6 +++---
> drivers/gpu/drm/i810/i810_drv.c
besides drm_gem.c and drm_vm.c, (branch drm-next).
Reviewed-by: David Herrmann
Thanks
David
>
> Signed-off-by: Daniel Vetter
> ---
> drivers/gpu/drm/drm_internal.h | 1 +
> drivers/gpu/drm/drm_vm.c | 1 -
> include/drm/drmP.h | 1 -
> 3 files changed, 1
Hi
On Tue, Sep 23, 2014 at 3:46 PM, Daniel Vetter
wrote:
> Somehow I've missed these three, fix this up asap. Plus move
> drm_master_create since while at it.
s/since//
Reviewed-by: David Herrmann
Thanks
David
> Signed-off-by: Daniel Vetter
> ---
> drivers/gpu/dr
Hi
On Tue, Sep 23, 2014 at 3:46 PM, Daniel Vetter
wrote:
> In my header cleanup I've missed the debugfs functions completely.
I'd actually prefer a drm_debugfs.h, but I have some local patches
that refactor drm-debugfs stuff, anyway. So I can do it later myself:
Reviewed-by: D
Hi
On Tue, Sep 23, 2014 at 3:46 PM, Daniel Vetter
wrote:
> v2: Don't forget git add, noticed by David.
>
> Cc: David Herrmann
Acked-by: David Herrmann
Thanks
David
> Signed-off-by: Daniel Vetter
> ---
> drivers/gpu/drm/armada/armada_gem.h | 2 +
> dri
Hi
On Tue, Sep 23, 2014 at 3:46 PM, Daniel Vetter
wrote:
> Only !P can be used together with a function list.
You say !P, but you use !F?
Thanks
David
> Cc: Ville Syrj?l?
> Signed-off-by: Daniel Vetter
> ---
> Documentation/DocBook/drm.tmpl | 2 +-
> 1 file changed, 1 insertion(+), 1 delet
Hi
On Tue, Sep 23, 2014 at 3:46 PM, Daniel Vetter
wrote:
> So the main part here is the extraction of drm_gem.h. With a bit of prep work
> to
> ditch the legacy mmap stuff out of gem/ttm drivers. Plus a few random pieces
> of
> leftover cleanup that I've missed in my earlier header rework or j
days, which probably originated in radeon.
>>
>> Cc: David Airlie
>> Cc: Alex Deucher
>> Cc: "Christian K?nig"
>> Cc: David Herrmann
>> Cc: Rashika
>> Cc: Josh Triplett
>> Cc: Daniel Vetter
>> Cc: Fabian Frederick
>> Cc:
Hi
On Tue, Sep 22, 2015 at 11:55 AM, Daniel Vetter
wrote:
> From: Matt Roper
>
> Starting with commit
>
> commit 28cc504e8d52248962f5b485bdc65f539e3fe21d
> Author: Rob Clark
> Date: Tue Aug 25 15:36:00 2015 -0400
>
> drm/i915: enable atomic fb-helper
>
> I
Hi
On Tue, Sep 22, 2015 at 12:33 PM, Maarten Lankhorst
wrote:
> Hey,
>
> Op 22-09-15 om 11:55 schreef Daniel Vetter:
>> From: Matt Roper
>>
>> Starting with commit
>>
>> commit 28cc504e8d52248962f5b485bdc65f539e3fe21d
>> Author: Rob Clark
>> Date: Tue Aug 25 15:36:00 2
ne->state->fb;
> + if (new_fb)
> + drm_framebuffer_reference(new_fb);
> + plane->fb = new_fb;
> + plane->crtc = plane->state->crtc;
> +
> + if (plane->old_fb)
>
round after they quit and handover
to the next stage. We have to stay around for hand-over, which is
nasty and requires a back-channel which is otherwise not needed at
all.
Reviewed-by: David Herrmann
Thanks
David
Hi
On Thu, Sep 10, 2015 at 12:15 PM, Tvrtko Ursulin
wrote:
> On 09/10/2015 10:56 AM, Daniel Vetter wrote:
>> That's not different from the compositor just freezing instead of
>> crashing: Screen contents stays on and nothing happens. Imo this really is
>> all just broken userspace, and the kernel
s are preserved.
>
> Signed-off-by: Maarten Lankhorst
> ---
> drivers/gpu/drm/drm_crtc.c | 11 +--
> 1 file changed, 1 insertion(+), 10 deletions(-)
Same as 1/2:
Reviewed-by: David Herrmann
Thanks
David
> diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/dr
Hi
On Thu, Sep 24, 2015 at 1:24 PM, Tomi Valkeinen
wrote:
>
> On 11/09/15 19:10, David Herrmann wrote:
>> Currently, for each open() on an fbdev device, we pin the underlying
>> fbdev device and driver module. On close(), we release both. This
>> guarantees that the f
Hi
On Sat, Sep 26, 2015 at 8:01 PM, Geert Uytterhoeven
wrote:
> Hi Alex,
>
> On Sat, Sep 26, 2015 at 7:07 PM, Alex Deucher
> wrote:
>> On Sat, Sep 26, 2015 at 4:28 AM, Geert Uytterhoeven
>> wrote:
>>> On Thu, Sep 24, 2015 at 5:23 PM, Daniel Vetter wrote:
On Thu, Sep 24, 2015 at 02:46:21P
-by: Daniel Vetter
I recommend pushing it on your fdo branch to let the kbuild-bots run
it for some tests. But otherwise, looks good to me:
Reviewed-by: David Herrmann
Thanks
David
> ---
> drivers/gpu/drm/Makefile | 3 ++-
> drivers/gpu/drm/drm_agpsupport.c | 4 ---
ature.
>
> Signed-off-by: Daniel Vetter
Reviewed-by: David Herrmann
Thanks
David
> ---
> Documentation/DocBook/drm.tmpl | 1 +
> drivers/gpu/drm/drm_ioctl.c| 76
> ++
> 2 files changed, 55 insertions(+), 22 deletions(-)
>
>
Hi
On Tue, Sep 8, 2015 at 1:56 PM, Daniel Vetter wrote:
> With the prep patches for i915 all kms drivers either have
> DRM_UNLOCKED on all their ioctls. Or the ioctl always directly returns
> with an invariant return value when in modeset mode. But that's only
> the case for i915 and radeon. The
M lock might deadlock
> -*/
> - if (!(flags & DRM_UNLOCKED)) {
> - DRM_ERROR("Refusing locked ioctl access.\n");
> - return ERR_PTR(-EDEADLK);
> - }
Yeah, just drop that right away, regardless of the core changes. We
have lockdep or WARN_
gt; v4: Rebase on top of render-node support in exynos.
>
> Signed-off-by: Daniel Vetter
With the core-patch fixed:
Reviewed-by: David Herrmann
Maybe, as a followup, you might want to turn all core-ioctls to
include a DRM_GLOBAL_LOCK flag and then drop DRM_UNLOCKED entirely.
This is more e
Hi
On Tue, Sep 8, 2015 at 1:56 PM, Daniel Vetter wrote:
> They're only used in the drm ioctl table, and there they're excluded
> when AGP support is disabled. So this is just dead code ripe for
> removal.
>
> Signed-off-by: Daniel Vetter
Reviewed-by: Davi
't support it, we can keep what we have.
>>
>> That, of course, doesn't get rid of the midlayer, so perhaps a better
>> way forward would be to tell driver writers that they should be doing
>> subsystem-level setup between drm_dev_alloc() and drm_dev_register().
>
> That's exactly what this patch tries to accomplish by updating the
> kerneldoc and docbook. New sequence should be
>
> device_probe_callback_or_whatever()
> {
> drm_dev_alloc();
>
> ... driver init code ...
>
> drm_dev_register();
>
> return 0;
> }
_Yes_!
Acked-by: David Herrmann
Thanks
David
Hey
Since this commit:
34db50e55656 efifb: Copy the ACPI BGRT
the kernel will override boot-splashs unasked. This breaks the
graphical boot-process on our setups. In particular, we have a setup
where an efi-boot-entry draws the early boot-splash on-screen, then
hands-over to the linux-kernel
Hey
On Mon, Sep 3, 2018 at 4:47 PM Hans de Goede wrote:
>
> Hi,
>
> On 03-09-18 16:16, Bartlomiej Zolnierkiewicz wrote:
> >
> > Hi,
> >
> > On Monday, September 03, 2018 03:23:38 PM David Herrmann wrote:
> >> Hey
> >>
> >> Since thi
Hi
On Wed, Sep 12, 2018 at 11:12 AM Hans de Goede wrote:
>
> In some setups restoring the BGRT logo is undesirable, allow passing
> video=efifb:nobgrt on the kernel commandline to disable it.
>
> Cc: David Herrmann
> Reported-by: David Herrmann
> Signed-off-by: Hans de Go
VMA offsets are 64bit so do not cast them to "unsigned int". Also remove
the (now useless) offset-retrieval helper. The VMA manager provides simple
enough helpers.
Cc: Thierry Reding
Cc: "Terje Bergstr?m"
Cc: Arto Merilainen
Signed-off-by: David Herrmann
---
drivers/gpu/
hared anon_inode_inode, I'd be
happy to implement it. However, I didn't succeed and I am actually not sure that
separate "struct address_space" are actually supported. For instance, DRM core
uses code like:
container_of(dev_mapping, struct inode, i_data)
which would break in thi
mount, we extend it to also provide
anonymous inodes for use in drivers like DRM.
Signed-off-by: David Herrmann
Wanted-by: Daniel Vetter
---
fs/anon_inodes.c| 36 +---
include/linux/anon_inodes.h | 1 +
2 files changed, 30 insertions(+), 7 deletions
r what reason?), but I remember Daniel
told me that i810 might.
Tested with nouveau on x86_64.
Signed-off-by: David Herrmann
Reviewed-by: Daniel Vetter
---
drivers/gpu/drm/drm_drv.c | 1 -
drivers/gpu/drm/drm_fops.c | 24 +++-
driver
Ben Skeggs
Cc: Maarten Lankhorst
Cc: Alex Deucher
Cc: Thomas Hellstrom
Signed-off-by: David Herrmann
---
drivers/gpu/drm/ast/ast_ttm.c | 4 +++-
drivers/gpu/drm/cirrus/cirrus_ttm.c| 4 +++-
drivers/gpu/drm/mgag200/mgag200_ttm.c | 4 +++-
drivers/gpu/drm/nouveau/nouveau_gem.c
anon_inode->i_mapping is always set. This was needed before we introduced
anon_inodes. We can safely remove it now.
Cc: Rob Clark
Signed-off-by: David Herrmann
---
drivers/gpu/drm/omapdrm/omap_gem.c | 32 +++-
1 file changed, 15 insertions(+), 17 deletions(-)
d
>
> To make really sure no mis-guided user in a kms driver pops up again
> explicitly check for that in the new ioctl implementation.
>
> v2: Drop the unused variable I've accidentally left in the code,
> spotted by David Herrmann.
>
> Cc: David Herrmann
> Signe
when X is being restarted), so
> keep this around. But give it a clear drm_legacy_ prefix and
> conditionalize the code on !DRIVER_MODESET.
>
> Cc: David Herrmann
> Signed-off-by: Daniel Vetter
Reviewed-by: David Herrmann
Regards
David
> ---
> drivers/gpu/drm/drm_drv.c | 27 ++
ie
> Cc: Laurent Pinchart
> Cc: Rob Clark
> Acked-by: Laurent Pinchart
> Signed-off-by: Daniel Vetter
Looks good now. It reminds me that I should resend the O_NONBLOCK
implementation of drm_read() which would properly replace any SIGIO
uses...
Reviewed-by: David Herrmann
GEM drivers and call
drm_vma_node_allow() and drm_vma_node_revoke() respectively. Just let me know
what you think is cleaner.
Cheers
David
David Herrmann (16):
drm/vma: add access management helpers
drm/ast: implement mmap access managament
drm/cirrus: implement mmap access managament
drm/mgag200: i
r mmap() should be supported on the
bo and avoid access-management if not.
- .. there are probably more ideas once we have benchmarks ..
Signed-off-by: David Herrmann
---
drivers/gpu/drm/drm_gem.c | 1 +
drivers/gpu/drm/drm_vma_manager.c | 155 ++
Correctly allow and revoke buffer access on each open/close via the new
VMA offset manager.
Cc: Dave Airlie
Signed-off-by: David Herrmann
---
drivers/gpu/drm/ast/ast_drv.c | 2 ++
drivers/gpu/drm/ast/ast_drv.h | 4
drivers/gpu/drm/ast/ast_main.c | 15 +++
3 files changed
Correctly allow and revoke buffer access on each open/close via the new
VMA offset manager.
Cc: Dave Airlie
Signed-off-by: David Herrmann
---
drivers/gpu/drm/cirrus/cirrus_drv.h | 4
drivers/gpu/drm/cirrus/cirrus_main.c | 15 +++
2 files changed, 19 insertions(+)
diff --git
Correctly allow and revoke buffer access on each open/close via the new
VMA offset manager.
Cc: Dave Airlie
Signed-off-by: David Herrmann
---
drivers/gpu/drm/mgag200/mgag200_drv.c | 2 ++
drivers/gpu/drm/mgag200/mgag200_drv.h | 4
drivers/gpu/drm/mgag200/mgag200_main.c | 15
Correctly allow and revoke buffer access on each open/close via the new
VMA offset manager.
Cc: Ben Skeggs
Signed-off-by: David Herrmann
---
drivers/gpu/drm/nouveau/nouveau_gem.c | 19 +++
1 file changed, 15 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/nouveau
Correctly allow and revoke buffer access on each open/close via the new
VMA offset manager.
Cc: Alex Deucher
Signed-off-by: David Herrmann
---
drivers/gpu/drm/radeon/radeon_gem.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/gpu/drm/radeon/radeon_gem.c
b/drivers/gpu/drm
Correctly allow and revoke buffer access on each open/close via the new
VMA offset manager.
Cc: Dave Airlie
Signed-off-by: David Herrmann
---
drivers/gpu/drm/qxl/qxl_gem.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/qxl/qxl_gem.c b/drivers/gpu/drm
Correctly allow and revoke buffer access on each open/close via the new
VMA offset manager. We also need to make vmw_user_dmabuf_reference()
correctly increase the vma-allow counter, but it is unused so remove it
instead.
Cc: Thomas Hellstrom
Signed-off-by: David Herrmann
---
drivers/gpu/drm
Set DRIVER_GEM_MMAP to make GEM core track buffer accesses via the DRM VMA
Offset Manager.
Cc: Daniel Vetter
Signed-off-by: David Herrmann
---
drivers/gpu/drm/i915/i915_drv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm
urrently unused, though.
All TTM drivers already use the new VMA offset manager access management
so we can enable TTM mmap access management now.
Signed-off-by: David Herrmann
---
drivers/gpu/drm/ttm/ttm_bo_vm.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/driv
don't need its mmap helpers. To avoid unnecessary
overhead, we limit GEM access management to drivers using DRIVER_GEM_MMAP.
So for TTM drivers GEM will not call any *_allow() or *_revoke() helpers.
Signed-off-by: David Herrmann
---
Documentation/DocBook/drm.tmpl | 13 +
drive
Set DRIVER_GEM_MMAP to make GEM core track buffer accesses via the DRM VMA
Offset Manager.
Cc: Inki Dae
Signed-off-by: David Herrmann
---
drivers/gpu/drm/exynos/exynos_drm_drv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c
b
Set DRIVER_GEM_MMAP to make GEM core track buffer accesses via the DRM VMA
Offset Manager.
Cc: Rob Clark
Signed-off-by: David Herrmann
---
drivers/gpu/drm/omapdrm/omap_drv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c
b/drivers/gpu
Set DRIVER_GEM_MMAP to make GEM core track buffer accesses via the DRM VMA
Offset Manager.
Cc: David Airlie
Signed-off-by: David Herrmann
---
drivers/gpu/drm/udl/udl_drv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/udl/udl_drv.c b/drivers/gpu/drm/udl
Set DRIVER_GEM_MMAP to make GEM core track buffer accesses via the DRM VMA
Offset Manager.
Cc: Patrik Jakobsson
Signed-off-by: David Herrmann
---
drivers/gpu/drm/gma500/psb_drv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/gma500/psb_drv.c b/drivers
Set DRIVER_GEM_MMAP to make GEM core track buffer accesses via the DRM VMA
Offset Manager.
Cc: Thierry Reding
Cc: "Terje Bergstr?m"
Cc: Arto Merilainen
Signed-off-by: David Herrmann
---
drivers/gpu/host1x/drm/drm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Hi
On Tue, Aug 13, 2013 at 9:38 PM, David Herrmann
wrote:
> Correctly allow and revoke buffer access on each open/close via the new
> VMA offset manager. We also need to make vmw_user_dmabuf_reference()
> correctly increase the vma-allow counter, but it is unused so remove it
> ins
unused and
the callbacks are all empty (or BUG()).
And the diff-stat looks pretty nice, too.
Cheers
David
David Herrmann (7):
drm/ast: remove unused driver_private access
drm/mgag200: remove unused driver_private access
drm/cirrus: remove unused driver_private access
drm/qxl: re
gem_bo->driver_private is never read by ast nor DRM core. No need to set
it. Besides, drm core clears it during setup, anyway.
Cc: Dave Airlie
Signed-off-by: David Herrmann
---
drivers/gpu/drm/ast/ast_ttm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/ast/ast_ttm.
gem_bo->driver_private is never read by mgag200 nor DRM core. No need to
set it. Besides, drm core clears it during setup, anyway.
Cc: Dave Airlie
Signed-off-by: David Herrmann
---
drivers/gpu/drm/mgag200/mgag200_ttm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/mgag
gem_bo->driver_private is never read by cirrus nor DRM core. No need to
set it. Besides, drm core clears it during setup, anyway.
Cc: Dave Airlie
Signed-off-by: David Herrmann
---
drivers/gpu/drm/cirrus/cirrus_ttm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/cir
These two helpers are unused. Remove them. They rely on
gem_obj->driver_private, which is set to NULL during setup. As this field
isn't used by the driver, anymore, we can remove this assignment as well.
Cc: Dave Airlie
Signed-off-by: David Herrmann
---
drivers/gpu/drm/qxl/qxl_drv.h
This field is never read. No need to set it in radeon. Besides, DRM gem
core clears it during setup, anyway.
Cc: Dave Airlie
Cc: Alex Deucher
Signed-off-by: David Herrmann
---
drivers/gpu/drm/radeon/radeon_object.c | 1 -
drivers/gpu/drm/radeon/radeon_prime.c | 1 -
2 files changed, 2
previous style. However, we no
longer can check for bo->gem != NULL to test for a valid gem object. This
wasn't done before, so we should be safe now.
Cc: Ben Skeggs
Cc: Maarten Lankhorst
Cc: Martin Peres
Signed-off-by: David Herrmann
---
drivers/gpu/drm/nouveau/nouveau_abi16.c | 4
ie
Cc: Alex Deucher
Cc: Daniel Vetter
Cc: Jerome Glisse
Cc: Rob Clark
Cc: Inki Dae
Cc: Ben Skeggs
Cc: Patrik Jakobsson
Signed-off-by: David Herrmann
---
drivers/gpu/drm/ast/ast_drv.c | 1 -
drivers/gpu/drm/ast/ast_drv.h | 1 -
drivers/gpu/drm/ast/ast_main.c
Hi
On Wed, Aug 14, 2013 at 4:31 PM, Maarten Lankhorst
wrote:
> Op 14-08-13 15:07, David Herrmann schreef:
>> There is no reason to keep the gem object separately allocated. nouveau is
>> the last user of gem_obj->driver_private, so if we embed it, we can get
>> rid
Hi
On Thu, Aug 8, 2013 at 3:41 PM, Daniel Vetter wrote:
> The new arch_phys_wc_add/del functions do the right thing both with
> and without MTRR support in the kernel. So we can drop these
> additional checks.
>
> David Herrmann suggest to also kill the DRIVER_USE_MTRR flag s
Hi
On Wed, Aug 14, 2013 at 7:35 PM, Thomas Hellstrom
wrote:
> (CC'ing the proper people since I'm still on parental leave).
>
> On 08/13/2013 11:44 PM, David Herrmann wrote:
>
> Please see inline comments.
>
>
>> Hi
>>
>> On Tue,
Hi
On Fri, Aug 16, 2013 at 5:33 PM, Thomas Hellstrom
wrote:
> On 08/16/2013 03:19 PM, David Herrmann wrote:
>>
>> Hi
>>
>> On Wed, Aug 14, 2013 at 7:35 PM, Thomas Hellstrom
>> wrote:
>>>
>>> (CC'ing the proper people since I'm st
er.c. On the other hand, this
file exclusively uses "drm_vma_node_*" and "drm_vma_offset_*"
prefixes, so maybe we're fine here. Don't know..
I tried removing drm_vma_open/close entirely, but it seems not all
drivers set vma->vma_file->private_data to the drm_devi
Hi
On Wed, Aug 21, 2013 at 12:33 PM, Inki Dae wrote:
> This patch adds lock and poll callbacks to dma buf file operations,
> and these callbacks will be called by fcntl and select system calls.
>
> fcntl and select system calls can be used to wait for the completion
> of DMA or CPU access to a sh
he end,
though.
Maybe we can get this into 3.11?
Regards
David
David Herrmann (4):
drm/vma: add access management helpers
drm/gem: implement vma access management
drm: verify vma access in TTM+GEM drivers
drm: implement experimental render nodes
Kristian H?gsberg (1):
drm/i915: Sup
r mmap() should be supported on the
bo and avoid access-management if not.
- .. there are probably more ideas once we have benchmarks ..
Signed-off-by: David Herrmann
---
drivers/gpu/drm/drm_gem.c | 1 +
drivers/gpu/drm/drm_vma_manager.c | 155 ++
done for drm_gem_mmap(). TTM drivers use the
TTM mmap helpers, which need to do that separately.
Signed-off-by: David Herrmann
---
drivers/gpu/drm/drm_gem.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
index d6122ae
the buffer must have a valid embedded gem object. This is
true for all TTM+GEM drivers. But that's why this patch doesn't touch pure
TTM drivers (ie, vmwgfx).
Cc: Dave Airlie
Cc: Alex Deucher
Cc: Ben Skeggs
Cc: Maarten Lankhorst
Cc: Jerome Glisse
Signed-off-by: David Herrmann
---
DRM-Master if they
support DRIVER_RENDER.
So far render-nodes are protected by "drm_rnodes". As long as this
module-parameter is not set to 1, a driver will not create render nodes.
This allows us to experiment with the API a bit before we stabilize it.
Signed-off-by: David Herrmann
---
From: Kristian H?gsberg
Enable support for drm render nodes for i915 by flagging the ioctls that
are safe and just needed for rendering.
Cc: Daniel Vetter
Signed-off-by: Kristian H?gsberg
Signed-off-by: David Herrmann
---
drivers/gpu/drm/i915/i915_dma.c | 36
From: Martin Peres
Enable support for drm render nodes for nouveau by flagging the ioctls that
are safe and just needed for rendering.
Cc: Ben Skeggs
Cc: Maarten Lankhorst
Signed-off-by: Martin Peres
Signed-off-by: David Herrmann
---
drivers/gpu/drm/nouveau/nouveau_drm.c | 24
Hi
On Tue, Aug 13, 2013 at 11:05 PM, Daniel Vetter wrote:
> On Tue, Aug 13, 2013 at 09:38:31PM +0200, David Herrmann wrote:
>> Implement automatic access management for mmap offsets for all GEM
>> drivers. This prevents user-space applications from "guessing" GEM BO
Hi
On Fri, Aug 23, 2013 at 1:28 PM, Christian K?nig
wrote:
> Hi David,
>
> Am 23.08.2013 13:13, schrieb David Herrmann:
>
>> Hi
>>
>> I reduced the vma access-management patches to a minimum. I now do filp*
>> tracking in gem unconditionally and force dr
Hi
On Fri, Aug 23, 2013 at 2:34 PM, Christian K?nig
wrote:
>> Feel free to send a patch to dri-devel or just let me know the ioctls
>> and I will include it in this series.
>
>
> Do you have a branch somewhere I can grab?
>
> That's a bit easier than applying the patchset from the list.
https://
Hi
On Fri, Aug 23, 2013 at 3:45 PM, Christian K?nig
wrote:
> From: Christian K?nig
>
> Enable support for drm render nodes for radeon by flagging the ioctls that
> are safe and just needed for rendering.
>
> Signed-off-by: Christian K?nig
Looks good to me. I queued it locally. v3 will include
Hi
On Fri, Aug 23, 2013 at 2:00 PM, Martin Peres wrote:
> Le 23/08/2013 13:13, David Herrmann a ?crit :
>
>> Hi
>>
>> I reduced the vma access-management patches to a minimum. I now do filp*
>> tracking in gem unconditionally and force drm_gem_mmap() to check this
r mmap() should be supported on the
bo and avoid access-management if not.
- .. there are probably more ideas once we have benchmarks ..
v2: add drm_vma_node_verify_access() helper
Signed-off-by: David Herrmann
---
drivers/gpu/drm/drm_gem.c | 1 +
driv
done for drm_gem_mmap(). TTM drivers use the
TTM mmap helpers, which need to do that separately.
Signed-off-by: David Herrmann
---
drivers/gpu/drm/drm_gem.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
index d6122ae
patch doesn't touch pure
TTM drivers (ie, vmwgfx).
v2: Switch to drm_vma_node_verify_access() to correctly return -EACCES if
access was denied.
Cc: Dave Airlie
Cc: Alex Deucher
Cc: Ben Skeggs
Cc: Maarten Lankhorst
Cc: Jerome Glisse
Signed-off-by: David Herrmann
---
drivers/g
use of dmabuf
Signed-off-by: David Herrmann
---
Documentation/DocBook/drm.tmpl | 69 ++
drivers/gpu/drm/drm_drv.c | 13
drivers/gpu/drm/drm_fops.c | 14 -
drivers/gpu/drm/drm_pci.c | 9 ++
drivers/gpu/drm/drm_pl
From: Kristian H?gsberg
Enable support for drm render nodes for i915 by flagging the ioctls that
are safe and just needed for rendering.
v2: mark reg_read, set_caching and get_caching (ickle, danvet)
Signed-off-by: Kristian H?gsberg
Signed-off-by: David Herrmann
Reviewed-by: Daniel Vetter
From: Martin Peres
Enable support for drm render nodes for nouveau by flagging the ioctls that
are safe and just needed for rendering.
Cc: Ben Skeggs
Cc: Maarten Lankhorst
Signed-off-by: Martin Peres
Signed-off-by: David Herrmann
---
drivers/gpu/drm/nouveau/nouveau_drm.c | 24
From: Christian K?nig
Enable support for drm render nodes for radeon by flagging the ioctls that
are safe and just needed for rendering.
Signed-off-by: Christian K?nig
Signed-off-by: David Herrmann
---
drivers/gpu/drm/radeon/radeon_drv.c | 2 +-
drivers/gpu/drm/radeon/radeon_kms.c | 22
this. Users shouldn't test for errors during
GEM_CLOSE, anyway. And it is still better than a failing MODE_GETFB call.
Cc:
Signed-off-by: David Herrmann
---
drivers/gpu/drm/drm_crtc.c | 18 +++---
1 file changed, 15 insertions(+), 3 deletions(-)
diff --git a/drivers/gp
accept this. Users shouldn't test for errors during
GEM_CLOSE, anyway. And it is still better as a failing MODE_GETFB call.
v2: add capable(CAP_SYS_ADMIN) check for compatibility with i-g-t
Cc:
Signed-off-by: David Herrmann
---
drivers/gpu/drm/drm_crtc.c | 18 +++---
1 file change
Hi
On Thu, Dec 5, 2013 at 1:19 AM, Ilia Mirkin wrote:
> All instances of drm_dev_register are followed by drm_dev_free on
> failure. Don't free dev->control/render/primary on failure, as they will
> be freed by drm_dev_free since commit 8f6599da8e (drm: delay minor
> destruction to drm_dev_free()
tion to drm_dev_free()). Instead unplug them.
>
> Reported-by: Bruno Pr?mont
> Signed-off-by: Ilia Mirkin
> ---
Thanks, looks good now:
Reviewed-by: David Herrmann
Thanks
David
> v2: use drm_unplug_minor instead of just removing the puts, as suggested by
> David Herrma
allocation flags into separate enums
> Make checkpatch happy where logical/easy
>
> v3 by Ben:
> Rebased on top of the many drm_mm changes since the original patches
> Remove ATOMIC from allocator flags (Chris)
> Reverse order of TOPDOWN and BOTTOMUP
CC'ing dri-devel as I'm
e offset manager a type pointer and fix up msm, omapdrm
> and tilcdc.
>
> v2: Fixup compile fail.
>
> Cc: David Herrmann
> Cc: Rob Clark
> Signed-off-by: Daniel Vetter
> ---
> drivers/gpu/drm/drm_gem.c | 27 ---
> drivers/gpu/drm
Hi
On Wed, Dec 18, 2013 at 8:37 AM, Gerd Hoffmann wrote:
> On Mi, 2013-12-18 at 11:52 +1000, Dave Airlie wrote:
>> On Wed, Dec 18, 2013 at 3:04 AM, Gerd Hoffmann wrote:
>> > DRM driver for (virtual) vga cards using the bochs dispi
>> > interface, such as the qemu standard vga (qemu -vga std).
>>
301 - 400 of 1115 matches
Mail list logo
