Re: [PATCH 1/1] drm/amdkfd: Add IPC API

2020-07-13 Thread Dave Airlie
On Tue, 14 Jul 2020 at 13:14, Felix Kuehling wrote: > > This allows exporting and importing buffers. The API generates handles > that can be used with the HIP IPC API, i.e. big numbers rather than > file descriptors. First up why? I get the how. > + * @share_handle is a 128 bit random number gen

Re: [PATCH 1/1] drm/amdkfd: Add IPC API

2020-07-13 Thread Dave Airlie
On Tue, 14 Jul 2020 at 14:09, Felix Kuehling wrote: > > Am 2020-07-13 um 11:28 p.m. schrieb Dave Airlie: > > On Tue, 14 Jul 2020 at 13:14, Felix Kuehling wrote: > >> This allows exporting and importing buffers. The API generates handles > >> that can be used

Re: [PATCH 0/8] drm/mgag200: Support desktop chips

2020-07-15 Thread Dave Airlie
On Thu, 16 Jul 2020 at 00:59, Thomas Zimmermann wrote: > > This patchset puts device initialization in the correct order and > adds support for G200 Desktop chips (PCI ids 0x520 and 0x521). why? :-) I'm pretty sure I NAKed the previous version because the userspace experience for these old cards

[git pull] drm fixes for 5.8-rc6

2020-07-16 Thread Dave Airlie
st encoders ahead of time (v4) Charan Teja Kalla (1): dmabuf: use spinlock to access dmabuf->name Chris Wilson (2): drm/i915/gt: Ignore irq enabling on the virtual engines drm/i915/gt: Only swap to a random sibling once upon creation Dave Airlie (4): Merge branch &#

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf.rst: Document why indefinite fences are a bad idea

2020-07-21 Thread Dave Airlie
> > >> That's also why I'm not positive on the "no hw preemption, only > >> scheduler" case: You still have a dma_fence for the batch itself, > >> which means still no userspace controlled synchronization or other > >> form of indefinite batches allowed. So not getting us any closer to > >> enablin

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf.rst: Document why indefinite fences are a bad idea

2020-07-21 Thread Dave Airlie
On Tue, 21 Jul 2020 at 18:47, Thomas Hellström (Intel) wrote: > > > On 7/21/20 9:45 AM, Christian König wrote: > > Am 21.07.20 um 09:41 schrieb Daniel Vetter: > >> On Mon, Jul 20, 2020 at 01:15:17PM +0200, Thomas Hellström (Intel) > >> wrote: > >>> Hi, > >>> > >>> On 7/9/20 2:33 PM, Daniel Vetter

Re: warning in omap_connector

2020-07-22 Thread Dave Airlie
Jun 30, 2020 at 10:19:23AM -0400, Alex Deucher wrote: > > > > On Tue, Jun 30, 2020 at 10:15 AM Ville Syrjälä wrote: > > > > > > > > > > On Tue, Jun 30, 2020 at 04:33:37PM +1000, Dave Airlie wrote: > > > > > > Hey Laurent, > > > &g

Re: [PATCH] drm/drm_fb_helper: fix fbdev with sparc64

2020-07-23 Thread Dave Airlie
On Tue, 14 Jul 2020 at 18:56, Thomas Zimmermann wrote: > > Hi > > Am 14.07.20 um 10:41 schrieb Daniel Vetter: > > On Tue, Jul 14, 2020 at 08:41:58AM +0200, Thomas Zimmermann wrote: > >> Hi > >> > >> Am 13.07.20 um 18:21 schrieb Daniel Vetter: > >>> On Fri, Jul 10, 2020 at 08:28:16AM +0200, Thomas

[git pull] drm fixes for 5.8-rc7

2020-07-23 Thread Dave Airlie
- Chen-Yu Tsai (1): drm: sun4i: hdmi: Fix inverted HPD result Dave Airlie (2): Merge tag 'drm-misc-fixes-2020-07-22' of git://anongit.freedesktop.org/drm/drm-misc into drm-fixes Merge tag 'amd-drm-fixes-5.8-2020-07-22' of git://people.freedesktop.org/~agd

[PATCH] nouveau: use ttm populate mapping functions.

2020-07-27 Thread Dave Airlie
From: Dave Airlie Instead of rolling driver copies of them. Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/nouveau_bo.c | 32 ++-- 1 file changed, 2 insertions(+), 30 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau

[PATCH] drm/vmwgfx: consolidate ttm object creation and populate

2020-07-27 Thread Dave Airlie
From: Dave Airlie These two functions has the same code in them, create a common helper function instead. Signed-off-by: Dave Airlie --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.h| 4 ++ drivers/gpu/drm/vmwgfx/vmwgfx_mob.c| 60 ++ drivers/gpu/drm/vmwgfx

[PATCH] drm/vmwgfx: drop bo map/unmap dma functions.

2020-07-27 Thread Dave Airlie
From: Dave Airlie The map one was used once, just inline it, and drop them both. Signed-off-by: Dave Airlie --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.h| 2 - drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c | 46 +++--- 2 files changed, 6 insertions(+), 42 deletions(-) diff

ttm_tt_set_placement_caching on vram->ram transfers

2020-07-27 Thread Dave Airlie
Hi Christian + Ben, Just been reviewing around driver TTM code, and found an inconsistency, amdgpu + radeon both call the above before binding the ttm and going gpu vram->ram copies, but I don't see nouveau doing it Not sure if it could cause any issues, but it does look inconsistent. Dave.

[PATCH] nouveau: use ttm populate mapping functions. (v2)

2020-07-27 Thread Dave Airlie
From: Dave Airlie Instead of rolling driver copies of them. v2: cleanup return handling (Ben) Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/nouveau_bo.c | 38 ++-- 1 file changed, 2 insertions(+), 36 deletions(-) diff --git a/drivers/gpu/drm/nouveau

[PATCH] ttm: ttm_bo_swapout_all doesn't use it's argument.

2020-07-27 Thread Dave Airlie
From: Dave Airlie Just drop the argument from this. This does ask the question if this is the function vmwgfx should be using or should it be doing an evict all like the other drivers. Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_bo.c| 2 +- drivers/gpu/drm/vmwgfx

[PATCH] drm/ttm: make ttm_tt unbind function return void.

2020-07-27 Thread Dave Airlie
From: Dave Airlie The return value just led to BUG_ON, I think if a driver wants to BUG_ON here it can do it itself. (don't BUG_ON). Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c| 5 ++--- drivers/gpu/drm/nouveau/nouveau_sgdma.c| 3 +-- drivers/gpu/dr

[PATCH] drm/ttm/nouveau: don't call tt destroy callback on alloc failure.

2020-07-27 Thread Dave Airlie
From: Dave Airlie This is confusing, and from my reading of all the drivers only nouveau got this right. Just make the API act under driver control of it's own allocation failing, and don't call destroy, if the page table fails to create there is nothing to cleanup here. (I&#x

[PATCH] drm/ttm: drop unusued function declaration

2020-07-27 Thread Dave Airlie
From: Dave Airlie This was removed in f5a9a9383f279de9da63296cb623a6418a66196b drm/ttm: remove TTM_MEMTYPE_FLAG_CMA but the the declaration was left dangling. Signed-off-by: Dave Airlie --- include/drm/ttm/ttm_bo_driver.h | 11 --- 1 file changed, 11 deletions(-) diff --git a

[PATCH] drm/ttm/nouveau: consolidate slowpath reserve

2020-07-27 Thread Dave Airlie
From: Dave Airlie The WARN_ON in the non-underscore path is off questionable value (can we drop it from the non-slowpath?). At least for nouveau where it's just looked up the gem object we know the ttm object has a reference always so we can skip the check. It's probably nouveau

Re: [PATCH] drm/ttm/nouveau: consolidate slowpath reserve

2020-07-28 Thread Dave Airlie
On Tue, 28 Jul 2020 at 17:30, Christian König wrote: > > Am 28.07.20 um 08:24 schrieb Dave Airlie: > > From: Dave Airlie > > > > The WARN_ON in the non-underscore path is off questionable value > > (can we drop it from the non-slowpath?). At least for nouveau >

[PATCH] drm/ttm/amdgpu: consolidate ttm reserve paths

2020-07-28 Thread Dave Airlie
From: Dave Airlie Drop the WARN_ON and consolidate the two paths into one. Use the consolidate slowpath in the execbuf utils code. Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 2 +- drivers/gpu/drm/ttm/ttm_execbuf_util.c | 12 +-- include/drm/ttm

Re: [PATCH] drm/ttm: drop unusued function declaration

2020-07-28 Thread Dave Airlie
On Tue, 28 Jul 2020 at 17:49, Christian König wrote: > > Am 28.07.20 um 06:51 schrieb Dave Airlie: > > From: Dave Airlie > > > > This was removed in > > f5a9a9383f279de9da63296cb623a6418a66196b drm/ttm: remove > > TTM_MEMTYPE_FLAG_CMA > > >

Re: [PATCH] drm/ttm/nouveau: don't call tt destroy callback on alloc failure.

2020-07-28 Thread Dave Airlie
On Tue, 28 Jul 2020 at 17:49, Christian König wrote: > > Am 28.07.20 um 06:17 schrieb Dave Airlie: > > From: Dave Airlie > > > > This is confusing, and from my reading of all the drivers only > > nouveau got this right. > > > > Just make the API act u

Re: [Nouveau] [PATCH v2] drm/nouveau: Accept 'legacy' format modifiers

2020-07-28 Thread Dave Airlie
On Tue, 28 Jul 2020 at 04:51, James Jones wrote: > > On 7/23/20 9:06 PM, Ben Skeggs wrote: > > On Sat, 18 Jul 2020 at 13:34, James Jones wrote: > >> > >> Accept the DRM_FORMAT_MOD_NVIDIA_16BX2_BLOCK() > >> family of modifiers to handle broken userspace > >> Xorg modesetting and Mesa drivers. Exis

[git pull] drm fixes for 5.8-rc8

2020-07-28 Thread Dave Airlie
module unload when fbcon init has failed for some reason drm/nouveau/fbcon: zero-initialise the mode_cmd2 structure Biju Das (1): drm: of: Fix double-free bug Dave Airlie (2): Merge branch 'linux-5.8' of git://github.com/skeggsb/linux into drm-fixes Merge tag '

Re: PROBLEM: 5.8-rc7 no video output with nouveau on NV36 (regression)

2020-07-28 Thread Dave Airlie
On Wed, 29 Jul 2020 at 15:05, Nick Bowler wrote: > > Hi, > > After installing Linux 5.8-rc7 I seem to get no video output on my > NV36 card once the nouveau module is loaded. The display (connected > to the digital output) simply reports "No Signal". > > I bisected to the following commit, and re

Re: [drm/ttm] Memory corruption problem when ttm_tt_init() fails.

2020-07-28 Thread Dave Airlie
On Wed, 15 Jul 2020 at 17:00, Tetsuo Handa wrote: > > On 2020/07/14 18:13, Gu Jinxiang wrote: > > I've encountered [BUG: unable to handle kernel NULL pointer dereference at] > > which has call stack like your pattern2. > > And before this happended, I got a lot of memory allocation failure > > w

Re: [PATCH 1/9] drm/ttm: initialize the system domain with defaults

2020-07-28 Thread Dave Airlie
On Fri, 24 Jul 2020 at 16:43, Thomas Zimmermann wrote: > > > > Am 23.07.20 um 17:17 schrieb Christian König: > > Instead of repeating that in each driver. > > > > Signed-off-by: Christian König > > Reviewed-by: Thomas Zimmermann I'm not sure what happened but the patchwork copies of this series

Re: [PATCH 1/9] drm/ttm: initialize the system domain with defaults

2020-07-28 Thread Dave Airlie
On Wed, 29 Jul 2020 at 16:21, Dave Airlie wrote: > > On Fri, 24 Jul 2020 at 16:43, Thomas Zimmermann wrote: > > > > > > > > Am 23.07.20 um 17:17 schrieb Christian König: > > > Instead of repeating that in each driver. > > > > > > Si

[git pull] drm fixes for 5.8-rc8 (part 2)

2020-07-30 Thread Dave Airlie
uncovered by another change in 5.7 Alex Deucher (1): Revert "drm/amdgpu: Fix NULL dereference in dpm sysfs handlers" Dave Airlie (1): Merge tag 'amd-drm-fixes-5.8-2020-07-30' of git://people.freedesktop.org/~agd5f/linux into drm-fixes James Jones (

[PATCH 00/49] ttm mem manager refactoring.

2020-07-30 Thread Dave Airlie
I started pulling on a thread, and it led me down a hole. This series refactors the ttm ttm_mem_type_manager object into a driver owned, allocated, subclassaed object. It starts with two minor fixes for some bad assumptions in two drivers. Enables a new init path, ports all the drivers to the ne

[PATCH 04/49] drm/ttm: provide a driver-led init path for generic mm manager.

2020-07-30 Thread Dave Airlie
From: Dave Airlie This lets the generic mm manager be initialised by the driver. Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_bo_manager.c | 23 --- include/drm/ttm/ttm_bo_driver.h | 3 +++ 2 files changed, 23 insertions(+), 3 deletions(-) diff --git a

[PATCH 01/49] drm/qxl/ttm: call ttm manager debug

2020-07-30 Thread Dave Airlie
From: Dave Airlie This code was poking inside a struct and assuming it was a drm_mm at the start. Call the proper API. Signed-off-by: Dave Airlie --- drivers/gpu/drm/qxl/qxl_ttm.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_ttm.c b

[PATCH 05/49] drm/amdgpu/ttm: init managers from the driver side.

2020-07-30 Thread Dave Airlie
From: Dave Airlie Use new init calls to unwrap manager init Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 19 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 37 +++- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h | 4 +-- drivers/gpu

[PATCH 06/49] drm/radeon: use new ttm man init path

2020-07-30 Thread Dave Airlie
From: Dave Airlie Use the new common manager init path. Signed-off-by: Dave Airlie --- drivers/gpu/drm/radeon/radeon_ttm.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c index dbd1d2766279

[PATCH 10/49] drm/vmwgfx/ttm: convert vram mm init to new code paths

2020-07-30 Thread Dave Airlie
From: Dave Airlie Split out the vram thp init path vs the range manager init. Signed-off-by: Dave Airlie --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 25 +++-- drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 4 +--- drivers/gpu/drm/vmwgfx/vmwgfx_thp.c | 12 3 files

[PATCH 02/49] drm/vram-helper: call the ttm manager debug function

2020-07-30 Thread Dave Airlie
From: Dave Airlie This code was assuming there was a drm_mm here, don't do that call the correct API. Signed-off-by: Dave Airlie --- drivers/gpu/drm/drm_gem_vram_helper.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c b/dr

[PATCH 03/49] drm/ttm: split the mm manager init code

2020-07-30 Thread Dave Airlie
From: Dave Airlie This will allow the driver to control the ordering here better. Eventually the old path will be removed. Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_bo.c| 34 +++-- include/drm/ttm/ttm_bo_api.h| 4 include/drm/ttm

[PATCH 12/49] drm/ttm: convert system manager init to new code.

2020-07-30 Thread Dave Airlie
From: Dave Airlie Remove the exit path, since this can't fail now. Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_bo.c | 30 +- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c

[PATCH 22/49] drm/qxl/ttm: use new takedown path

2020-07-30 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/qxl/qxl_ttm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_ttm.c b/drivers/gpu/drm/qxl/qxl_ttm.c index ac22971cd20b..acc4497887a6 100644 --- a/drivers/gpu/drm/qxl/qxl_ttm.c +++ b

[PATCH 21/49] drm/radeon/ttm: use new takedown paths

2020-07-30 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/radeon/radeon_ttm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c index a5043a5b7d89..e65297b4b678 100644 --- a/drivers/gpu/drm

[PATCH 19/49] drm/vram_helper: call explicit mm takedown

2020-07-30 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/drm_gem_vram_helper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c b/drivers/gpu/drm/drm_gem_vram_helper.c index 8a5d45a55ac7..c6cc90d42f56 100644 --- a/drivers/gpu/drm

[PATCH 20/49] drm/nouveau: use new cleanup paths

2020-07-30 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/nouveau_ttm.c | 41 --- 1 file changed, 30 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_ttm.c b/drivers/gpu/drm/nouveau/nouveau_ttm.c index e3c57c612765

[PATCH 15/49] drm/ttm: make some inline helper functions for cleanup paths.

2020-07-30 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_bo.c| 6 ++ include/drm/ttm/ttm_bo_driver.h | 12 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index 84e399395e4f

[PATCH 17/49] drm/amdgpu/ttm: use new takedown path

2020-07-30 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 15 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 10 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h | 2 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 15

[PATCH 24/49] drm/ttm: remove range manager legacy takedown path

2020-07-30 Thread Dave Airlie
From: Dave Airlie Now no drivers have been converted, drop the non-driver path. Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_bo_manager.c | 28 +--- 1 file changed, 9 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo_manager.c b/drivers

[PATCH 07/49] drm/qxl/ttm: use new init path for manager

2020-07-30 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/qxl/qxl_ttm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_ttm.c b/drivers/gpu/drm/qxl/qxl_ttm.c index 59478761efe8..ac22971cd20b 100644 --- a/drivers/gpu/drm/qxl/qxl_ttm.c +++ b

[PATCH 11/49] drm/vmwgfx/ttm: switch gmrid allocator to new init paths.

2020-07-30 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 17 - drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 2 +- drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c | 19 --- 3 files changed, 17 insertions(+), 21 deletions

[PATCH 08/49] drm/vram_helper: use new ttm manager init function

2020-07-30 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/drm_gem_vram_helper.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c b/drivers/gpu/drm/drm_gem_vram_helper.c index b6f158ab0f5a..8a5d45a55ac7 100644 --- a/drivers/gpu

[PATCH 13/49] drm/ttm: purge old manager init path.

2020-07-30 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_bo.c | 19 --- drivers/gpu/drm/ttm/ttm_bo_manager.c | 27 +-- include/drm/ttm/ttm_bo_api.h | 2 -- include/drm/ttm/ttm_bo_driver.h | 14 -- 4 files

[PATCH 18/49] drm/vmwgfx: takedown vram manager

2020-07-30 Thread Dave Airlie
From: Dave Airlie Don't bother returning EBUSY, nobody cares enough, if the driver has a problem, it should deal with it. Signed-off-by: Dave Airlie --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 13 - drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 1 + drivers/gpu/drm/vmwgfx/vmwgfx_thp.c

[PATCH 14/49] drm/ttm: pass man around instead of mem_type in some places

2020-07-30 Thread Dave Airlie
From: Dave Airlie This makes it easier to cleanup things Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_bo.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index 101a7910f9f7..84e399395e4f

[PATCH 26/49] drm/ttm: add wrapper to get manager from bdev.

2020-07-30 Thread Dave Airlie
From: Dave Airlie This will allow different abstractions later. Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_bo.c | 34 +++ drivers/gpu/drm/ttm/ttm_bo_util.c | 20 +- drivers/gpu/drm/ttm/ttm_bo_vm.c | 2 +- include/drm/ttm

[PATCH 29/49] drm/nouveau/ttm: use wrapper to access memory managers

2020-07-30 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/nouveau_ttm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_ttm.c b/drivers/gpu/drm/nouveau/nouveau_ttm.c index 2ccfdf203c52..ed651d7679fe 100644 --- a

[PATCH 33/49] drm/ttm: rename manager variable to make sure wrapper is used.

2020-07-30 Thread Dave Airlie
From: Dave Airlie Other users of this should notice this change and switch to wrapper. Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_bo.c| 2 +- include/drm/ttm/ttm_bo_driver.h | 7 +-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/ttm

[PATCH 35/49] drm/nouveau/ttm: don't fill in blank ttm debug callback

2020-07-30 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/nouveau_ttm.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_ttm.c b/drivers/gpu/drm/nouveau/nouveau_ttm.c index ed651d7679fe..1b9d9362132d 100644 --- a/drivers/gpu/drm

[PATCH 25/49] drm/ttm: make TTM responsible for cleaning system only.

2020-07-30 Thread Dave Airlie
From: Dave Airlie drivers should all be cleaning up their memory managers themselves now, so let the core just clean the system one up. Remove the legacy cleaning interface. Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_bo.c| 55 +++-- include/drm/ttm

[PATCH 09/49] drm/nouveau: use new memory manager init paths

2020-07-30 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/nouveau_ttm.c | 43 --- 1 file changed, 19 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_ttm.c b/drivers/gpu/drm/nouveau/nouveau_ttm.c index b0012021ae12

[PATCH 40/49] drm/ttm: move range manager to subclassed driver allocation

2020-07-30 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_bo_manager.c | 32 +--- 1 file changed, 20 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo_manager.c b/drivers/gpu/drm/ttm/ttm_bo_manager.c index 2f5fa44b6474..2782ccff9b66

[PATCH 36/49] drm/vmwgfx/gmrid: don't provide pointless ttm debug callback

2020-07-30 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c b/drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c index 3fa809b5e3bd..2db99f0449b0 100644 --- a

[PATCH 38/49] drm/amdgpu/ttm: use bo manager subclassing for vram/gtt mgrs

2020-07-30 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 35 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 36 +--- 2 files changed, 44 insertions(+), 27 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu

[PATCH 34/49] drm/ttm: make manager debug function optional

2020-07-30 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_bo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index 92de8a6d7647..1e8fda1c9b3a 100644 --- a/drivers/gpu/drm/ttm/ttm_bo.c +++ b/drivers

[PATCH 32/49] drm/vmwgfx/ttm: use wrapper to access memory manager

2020-07-30 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 21 --- drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c | 4 ++-- drivers/gpu/drm/vmwgfx/vmwgfx_thp.c | 4 ++-- 3 files changed, 17 insertions(+), 12 deletions(-) diff

[PATCH 39/49] drm/ttm: make ttm_bo_man_init/takedown take type + args

2020-07-30 Thread Dave Airlie
From: Dave Airlie This makes it easier to move these to a driver allocated system Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 15 +-- drivers/gpu/drm/drm_gem_vram_helper.c | 10 drivers/gpu/drm/nouveau/nouveau_ttm.c | 21

[PATCH 27/49] drm/amdgfx/ttm: use wrapper to get ttm memory managers

2020-07-30 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 3 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 6 +++--- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 ++--- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 12 +-- drivers/gpu

[PATCH 37/49] drm/ttm: allow drivers to provide their own manager subclasses

2020-07-30 Thread Dave Airlie
From: Dave Airlie This will get removed eventually and all drivers will use this. Signed-off-by: Dave Airlie --- include/drm/ttm/ttm_bo_driver.h | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/include/drm/ttm/ttm_bo_driver.h b/include/drm/ttm/ttm_bo_driver.h

[PATCH 31/49] drm/radeon/ttm: use wrapper to access memory manager

2020-07-30 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/radeon/radeon_gem.c | 2 +- drivers/gpu/drm/radeon/radeon_ttm.c | 13 ++--- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_gem.c b/drivers/gpu/drm/radeon/radeon_gem.c index

[PATCH 28/49] drm/vram-helper: use wrapper to access memory managers

2020-07-30 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/drm_gem_vram_helper.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c b/drivers/gpu/drm/drm_gem_vram_helper.c index c6cc90d42f56..08fbfa32540a 100644 --- a/drivers

[PATCH 49/49] drm/ttm: consolidate manager used apis into a set and get.

2020-07-30 Thread Dave Airlie
From: Dave Airlie This is probably something we could consider removing, vmwgfx is the only user, and we might be able to faciliate it another way but for now just consolidate it all into accessors. Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 4

[PATCH 16/49] drm/ttm: start allowing drivers to use new takedown path

2020-07-30 Thread Dave Airlie
From: Dave Airlie Allow the takedown path callback to be optional as well. Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_bo.c | 8 +--- drivers/gpu/drm/ttm/ttm_bo_manager.c | 21 +++-- include/drm/ttm/ttm_bo_driver.h | 5 - 3 files changed, 28

[PATCH 44/49] drm/ttm: drop priv pointer in memory manager

2020-07-30 Thread Dave Airlie
From: Dave Airlie This isn't needed anymore by any drivers. Signed-off-by: Dave Airlie --- include/drm/ttm/ttm_bo_driver.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/drm/ttm/ttm_bo_driver.h b/include/drm/ttm/ttm_bo_driver.h index 6319d85d7270..a38704fe0737 100644

[PATCH 30/49] drm/qxl/ttm: use wrapper to access memory manager

2020-07-30 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/qxl/qxl_ttm.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_ttm.c b/drivers/gpu/drm/qxl/qxl_ttm.c index acc4497887a6..9aea35a66e25 100644 --- a/drivers/gpu/drm/qxl

[PATCH 23/49] drm/vmwgfx: fix gmrid takedown paths to new interface

2020-07-30 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 10 +- drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 1 + drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c | 11 --- 3 files changed, 14 insertions(+), 8 deletions(-) diff --git a

[PATCH 43/49] drm/nouveau/ttm: move to driver allocated manager

2020-07-30 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/nouveau_ttm.c | 41 ++- 1 file changed, 28 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_ttm.c b/drivers/gpu/drm/nouveau/nouveau_ttm.c index 225f9af2eaa1

[PATCH 45/49] drm/amdgpu/ttm: remove man->bdev references.

2020-07-30 Thread Dave Airlie
From: Dave Airlie Just store the device in the private so the link can be removed from the manager Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu

[PATCH 41/49] drm/vmwgfx/ttm: move thp to driver managed

2020-07-30 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/vmwgfx/vmwgfx_thp.c | 33 +++-- 1 file changed, 22 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_thp.c b/drivers/gpu/drm/vmwgfx/vmwgfx_thp.c index 0dd619c9d207..d2dde8159c3d

[PATCH 46/49] drm/ttm: drop man->bdev link.

2020-07-30 Thread Dave Airlie
From: Dave Airlie This link isn't needed anymore, drop it from the init interface. Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 2 +- drivers/gpu/drm/nouveau/nouveau_ttm.c | 6 ++ driver

[PATCH 48/49] drm/ttm: drop type manager has_type

2020-07-30 Thread Dave Airlie
From: Dave Airlie under driver control, this flag isn't needed anymore Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_bo.c| 6 ++ include/drm/ttm/ttm_bo_driver.h | 5 - 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/dr

[PATCH 47/49] drm/ttm: drop list of memory managers from device.

2020-07-30 Thread Dave Airlie
From: Dave Airlie The driver now controls these, the core just controls the system memory one. Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_bo.c| 2 -- include/drm/ttm/ttm_bo_driver.h | 6 -- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/ttm

[PATCH 42/49] drm/vmwgfx/gmrid: convert to driver controlled allocation.

2020-07-30 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c | 33 +++ 1 file changed, 20 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c b/drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c index

Re: [PATCH 03/49] drm/ttm: split the mm manager init code

2020-07-30 Thread Dave Airlie
On Fri, 31 Jul 2020 at 15:44, Sam Ravnborg wrote: > > Hi Dave. > > On Fri, Jul 31, 2020 at 02:04:34PM +1000, Dave Airlie wrote: > > From: Dave Airlie > > > > This will allow the driver to control the ordering here better. > > > > Eventually the old p

Re: [PATCH 03/49] drm/ttm: split the mm manager init code

2020-07-30 Thread Dave Airlie
On Fri, 31 Jul 2020 at 15:51, Dave Airlie wrote: > > On Fri, 31 Jul 2020 at 15:44, Sam Ravnborg wrote: > > > > Hi Dave. > > > > On Fri, Jul 31, 2020 at 02:04:34PM +1000, Dave Airlie wrote: > > > From: Dave Airlie > > > > > > This

oops in drm-next on vmwgfx

2020-07-30 Thread Dave Airlie
I booted up drm-next to test my ttm rework, but hey drm-next oops on startup without it. Probably need to get that fixed, haven't bisected yet. Dave. [2.689057] [drm] DMA map mode: Caching DMA mappings. [2.689151] [drm] Capabilities: [2.689151] [drm] Rect copy. [2.689151] [drm]

Re: [PATCH 04/49] drm/ttm: provide a driver-led init path for generic mm manager.

2020-07-31 Thread Dave Airlie
On Fri, 31 Jul 2020 at 16:57, Thomas Zimmermann wrote: > > Hi > > Am 31.07.20 um 06:04 schrieb Dave Airlie: > > From: Dave Airlie > > > > This lets the generic mm manager be initialised by the driver. > > > > Signed-off-by: Dave Airlie > > --

Re: [PATCH 26/49] drm/ttm: add wrapper to get manager from bdev.

2020-07-31 Thread Dave Airlie
On Fri, 31 Jul 2020 at 17:14, Thomas Zimmermann wrote: > > Hi > > Am 31.07.20 um 06:04 schrieb Dave Airlie: > > From: Dave Airlie > > > > This will allow different abstractions later. > > You should consider moving this patch to the beginning of the series, s

[git pull] drm fixes for 5.7-rc3

2020-04-23 Thread Dave Airlie
r free fix Alex Deucher (2): drm/amdgpu/display: fix aux registration (v2) drm/amdgpu/display: give aux i2c buses more meaningful names Chris Wilson (1): drm/i915/gt: Update PMINTRMSK holding fw Christian König (1): drm/scheduler: fix drm_sched_get_cleanup_job Dave

[git pull] drm fixes for 5.7-rc4

2020-04-30 Thread Dave Airlie
/gt: Check cacheline is valid before acquiring Daniel Vetter (1): dma-buf: Fix SET_NAME ioctl uapi Dave Airlie (3): Merge tag 'drm-misc-fixes-2020-04-30' of git://anongit.freedesktop.org/drm/drm-misc into drm-fixes Merge tag 'drm-intel-fixes-2020-04-30' of git:/

Re: [PATCH] RFC: i915: Drop relocation support on Gen12+

2020-05-07 Thread Dave Airlie
On Fri, 8 May 2020 at 01:44, Chris Wilson wrote: > > Quoting Jason Ekstrand (2020-05-07 16:36:00) > > The Vulkan driver in Mesa for Intel hardware never uses relocations if > > it's running on a version of i915 that supports at least softpin which > > all versions of i915 supporting Gen12 do. On

[git pull] drm fixes for 5.7-rc5

2020-05-07 Thread Dave Airlie
ssing module support Arnd Bergmann (1): sun6i: dsi: fix gcc-4.8 Aurabindo Pillai (1): drm/amd/display: Prevent dpcd reads with passive dongles Daniel Kolesa (1): drm/amd/display: work around fp code being emitted outside of DC_FP_START/END Dave Airlie (2):

Re: [RFC] Remove AGP support from Radeon/Nouveau/TTM

2020-05-11 Thread Dave Airlie
On Tue, 12 May 2020 at 06:28, Alex Deucher wrote: > > On Mon, May 11, 2020 at 4:22 PM Al Dunsmuir wrote: > > > > On Monday, May 11, 2020, 1:17:19 PM, "Christian König" wrote: > > > Hi guys, > > > > > Well let's face it AGP is a total headache to maintain and dead for at > > > least 10+ years. >

Re: [Intel-gfx] [PATCH 3/3] misc/habalabs: don't set default fence_ops->wait

2020-05-11 Thread Dave Airlie
On Mon, 11 May 2020 at 19:37, Oded Gabbay wrote: > > On Mon, May 11, 2020 at 12:11 PM Daniel Vetter wrote: > > > > It's the default. > Thanks for catching that. > > > > > Also so much for "we're not going to tell the graphics people how to > > review their code", dma_fence is a pretty core piece

Re: [RFC] Remove AGP support from Radeon/Nouveau/TTM

2020-05-12 Thread Dave Airlie
On Wed, 13 May 2020 at 04:21, Alex Deucher wrote: > > On Tue, May 12, 2020 at 1:02 PM Rui Salvaterra wrote: > > > > On Tue, 12 May 2020 at 17:38, Daniel Vetter wrote: > > > > > > Otherwise all agree, agp is a mighty mess and essentially just > > > crapshot outside of x86. It kinda worked for the

Re: [PULL] drm-intel-next

2020-05-13 Thread Dave Airlie
On Thu, 14 May 2020 at 03:10, Joonas Lahtinen wrote: > > Ping for merging this? If there are no issues, I'd prefer to pull in > next gvt-next and tag the final pull sooner than later. Can you check that I'm correct and this isn;'t in patchwork. I've checked both the dri-devel and intel-gfx patchw

Re: [PATCH v11 1/2] drm/panel: add support for rm69299 visionox panel driver

2020-05-13 Thread Dave Airlie
On Thu, 7 May 2020 at 04:57, Sam Ravnborg wrote: > > Hi Harigovindan > > On Wed, Apr 29, 2020 at 11:15:14AM +0530, Harigovindan P wrote: > > Add support for Visionox panel driver. > > > > Signed-off-by: Harigovindan P > > Reviewed-by: Matthias Kaehlcke > > Thanks for your persistence on this. >

[git pull] drm nouveau fixes for 5.9 final

2020-10-07 Thread Dave Airlie
Hi Linus, Karol found two last minute nouveau fixes, they both fix crashes, the TTM one follows what other drivers do already, and the other is for bailing on load on unrecognised chipsets. Thanks, Dave. drm-fixes-2020-10-08: drm nouveau fixes for 5.9 final nouveau: - fix crash in TTM alloc fai

Re: [PATCH 3/5] drm/vmwgfx: add a move callback.

2020-10-07 Thread Dave Airlie
On Thu, 8 Oct 2020 at 13:41, Zack Rusin wrote: > > > > On Oct 5, 2020, at 20:06, Dave Airlie wrote: > > > > From: Dave Airlie > > > > This just copies the fallback to vmwgfx, I'm going to iterate on this > > a bit until it's not the same as t

[git pull] drm amdgpu fixes for 5.9 final

2020-10-08 Thread Dave Airlie
-- Alex Deucher (1): drm/amdgpu/swsmu: fix ARC build errors Dave Airlie (1): Merge tag 'amd-drm-fixes-5.9-2020-10-08' of git://people.freedesktop.org/~agd5f/linux into drm-fixes Dirk Gouders (1): drm/amdgpu: fix NULL pointer dereference for Renoir Yongqiang Sun (

Re: [git pull] drm next pull for 5.10-rc1

2020-10-14 Thread Dave Airlie
On Thu, 15 Oct 2020 at 11:33, Dave Airlie wrote: > > Hi Linus, > > This is the main drm pull request for 5.10. > > Not a major amount of change, the i915 trees got split into display > and gt trees to better facilitate higher level review, and there's a > major refac

Re: [git pull] drm next pull for 5.10-rc1

2020-10-15 Thread Dave Airlie
On Fri, 16 Oct 2020 at 04:42, Linus Torvalds wrote: > > On Thu, Oct 15, 2020 at 10:51 AM Linus Torvalds > wrote: > > > > Thanks, looks good to me [..] > > Uhhuh. I already pushed things out, but my clang build (which I don't > do between each merge) shows a problem: > > drivers/gpu/drm/amd/amdg

Re: It appears drm-next TTM cleanup broke something . . .

2020-10-18 Thread Dave Airlie
On Mon, 19 Oct 2020 at 05:15, Kevin Brace wrote: > > Hi Dave, > > It is a little urgent, so I am writing this right now. > As usual, I pulled in DRM repository code for an out of tree OpenChrome DRM > repository a few days ago. > While going through the changes I need to make to OpenChrome DRM to

<    5   6   7   8   9   10   11   12   13   14   >