On Tue, Jul 20, 2021 at 10:28:32PM +0200, Marek Vasut wrote:
> On 7/19/21 1:22 PM, Daniel Thompson wrote:
> > On Sun, Jul 18, 2021 at 11:14:15PM +0200, Marek Vasut wrote:
> > > If the backlight enable GPIO is configured as input, the driver currently
> > > unconditionall
On Wed, Jul 21, 2021 at 05:09:57PM +0200, Marek Vasut wrote:
> On 7/21/21 12:49 PM, Daniel Thompson wrote:
> > > I'm not sure that's correct, we can simply say that any new uses of the
> > > pwm-backlight should specify the initial GPIO configuration, and for the
>
On Wed, Jul 21, 2021 at 05:09:57PM +0200, Marek Vasut wrote:
> On 7/21/21 12:49 PM, Daniel Thompson wrote:
> > > > However, on the basis of making things less fragile, I think the
> > > > underlying problem here is the assumption that it is safe to modify
> > >
On Wed, Jul 21, 2021 at 08:46:42PM +0200, Marek Vasut wrote:
> On 7/21/21 6:12 PM, Daniel Thompson wrote:
> > On Wed, Jul 21, 2021 at 05:09:57PM +0200, Marek Vasut wrote:
> > > On 7/21/21 12:49 PM, Daniel Thompson wrote:
> > > > > I'm not sure that's corr
also risks flickers).
Fix this by moving the code to configure the GPIO output mode until after
we have examines the handover state. That allows us to initialize
enable_gpio to off if the backlight is currently off and on if the
backlight is on.
Reported-by: Marek Vasut
Signed-off-by: Daniel Th
also risks flickers).
Fix this by moving the code to configure the GPIO output mode until after
we have examines the handover state. That allows us to initialize
enable_gpio to off if the backlight is currently off and on if the
backlight is on.
Reported-by: Marek Vasut
Signed-off-by: Daniel Th
On Thu, Jul 22, 2021 at 09:02:04PM +0200, Marek Vasut wrote:
> On 7/22/21 1:28 PM, Daniel Thompson wrote:
> > On Wed, Jul 21, 2021 at 08:46:42PM +0200, Marek Vasut wrote:
> > > On 7/21/21 6:12 PM, Daniel Thompson wrote:
> > > > On Wed, Jul 21, 2021 at 05:09
about how pwm_bl inherits
the initial state established by the bootloader (or by power-on reset if
the bootloader doesn't do anything to the backlight). Let's take this
chance to document the four handover cases.
Reported-by: Marek Vasut
Signed-off-by: Daniel Thompson
Cc: sta...@v
On Fri, Jul 23, 2021 at 11:15:10AM +0100, Daniel Thompson wrote:
> On Thu, Jul 22, 2021 at 09:02:04PM +0200, Marek Vasut wrote:
> > On 7/22/21 1:28 PM, Daniel Thompson wrote:
> > > On Wed, Jul 21, 2021 at 08:46:42PM +0200, Marek Vasut wrote:
> > > > On 7/21/21
On Mon, Apr 26, 2021 at 03:18:11PM +0800, cy_huang wrote:
> From: ChiYuan Huang
>
> Adds support for Richtek RT4831 backlight.
>
> Signed-off-by: ChiYuan Huang
> Reviewed-by: Daniel Thompson
> ---
> Resend this v6 patch series to loop devicetree reviewers.
>
On Sat, Apr 24, 2021 at 03:25:04AM +0530, Rajeev Nandan wrote:
> Add backlight driver for the panels supporting backlight control
> using DPCD registers on the DisplayPort aux channel.
>
> Changes in v2:
> - New (most of the code reused from drm_dp_aux_backlight.c of v1)
Did you respond to Jani's
On Mon, Apr 26, 2021 at 06:50:15PM +0800, ChiYuan Huang wrote:
> Hi,
>
> Daniel Thompson 於 2021年4月26日 週一 下午6:19寫道：
> >
> > On Mon, Apr 26, 2021 at 03:18:11PM +0800, cy_huang wrote:
> > > From: ChiYuan Huang
> > >
> > > Adds support for Ric
On Fri, Apr 23, 2021 at 01:04:23PM +, pgeiem wrote:
> Dear all,
>
> On a custom board I have a simple DPI panel. Panel's backlight is
> drive with an I2C led driver (PCA9632). led-backlight driver is sued
> to manage this as a backlight.
>
> When using brightness-levels and default-brightness
On Thu, Apr 29, 2021 at 11:31:20AM +, pgeiem wrote:
> On Thursday, April 29, 2021 1:00 PM, Daniel Thompson
> wrote:
>
> > On Fri, Apr 23, 2021 at 01:04:23PM +, pgeiem wrote:
> >
> > > Dear all,
> > > On a custom board I have a simple DPI panel. P
Shamoun
> Signed-off-by: Konrad Dybcio
> Signed-off-by: Marijn Suijten
LGTM, although an acked-by from Kiran would be nice to have:
Reviewed-by: Daniel Thompson
Daniel.
> ---
> drivers/video/backlight/qcom-wled.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
On Sun, Mar 21, 2021 at 12:43:41PM +0100, Linus Walleij wrote:
> The KTD259 works just like KTD253 so add this compatible
> to the driver.
>
> Signed-off-by: Linus Walleij
Oh no... there's more of them ;-) .
Reviewed-by: Daniel Thompson
Daniel.
> ---
> drivers
On Sun, Mar 21, 2021 at 12:43:40PM +0100, Linus Walleij wrote:
> The KTD259 is just a newer version of the KTD253 and works
> all the same.
>
> Signed-off-by: Linus Walleij
(For Lee) Acked-by: Daniel Thompson
Daniel.
> ---
> .../bindings/leds/backlight/kinetic,ktd253
On Sun, Feb 28, 2021 at 01:41:04PM +0100, Konrad Dybcio wrote:
> Document the newly added PMI8994 compatible.
>
> Signed-off-by: Konrad Dybcio
(For Lee) Acked-by: Daniel Thompson
Daniel.
> ---
> Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml | 1 +
>
On Sun, Feb 28, 2021 at 01:41:05PM +0100, Konrad Dybcio wrote:
> Add a compatible for PMI8994 WLED. It uses the V4 of WLED IP.
>
> Signed-off-by: Konrad Dybcio
Reviewed-by: Daniel Thompson
Daniel.
> ---
> drivers/video/backlight/qcom-wled.c | 1 +
> 1 file ch
c0d17 ("backlight: Adds HP Jornada 700 series backlight driver")
> Signed-off-by: Arnd Bergmann
I'm dubious that the re-indent matches the original authors intent...
but it certainly does match what was actually written and tested so
on that basis:
Reviewed-by: Daniel Thompson
On Tue, Mar 23, 2021 at 08:39:35AM +, Lee Jones wrote:
> On Mon, 22 Mar 2021, Daniel Thompson wrote:
>
> > On Sun, Feb 28, 2021 at 01:41:05PM +0100, Konrad Dybcio wrote:
> > > Add a compatible for PMI8994 WLED. It uses the V4 of WLED IP.
> > >
>
On Thu, Dec 17, 2020 at 11:00:43PM +0800, cy_huang wrote:
> From: ChiYuan Huang
>
> Adds support for Richtek RT4831 backlight.
>
> Signed-off-by: ChiYuan Huang
Looks ok but there are a few minor niggles.
> ---
> drivers/video/backlight/Kconfig| 8 ++
> drivers/video/backlight/Ma
On Thu, Mar 25, 2021 at 04:22:11PM +0800, ChiYuan Huang wrote:
> Dear reviewers:
>
>Didn't get any response about this backlight patch.
> Is there any part need to be refined?
Thanks for the reminders and sorry for the delay. Have just replied
to the original message!
Daniel.
__
It's common used to drive the display WLED. There're four channels
Nitpicking but I was expecting the original typo be converted to
"commonly".
With that addressed:
Reviewed-by: Daniel Thompson
Daniel.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Sun, Mar 28, 2021 at 11:24:17PM +0800, cy_huang wrote:
> From: ChiYuan Huang
>
> Adds DT binding document for Richtek RT4831 backlight.
>
> Signed-off-by: ChiYuan Huang
Reviewed-by: Daniel Thompson
___
dri-devel mailing
backlight_class->dev_groups = bl_device_groups;
> backlight_class->pm = &backlight_class_dev_pm_ops;
> INIT_LIST_HEAD(&backlight_dev_list);
> - mutex_init(&backlight_dev_list_mutex);
> BLOCKING_INIT_NOTIFIER_HEAD(&backlight_notifier);
On Mon, 4 Jan 2021
On Mon, Feb 01, 2021 at 08:41:38AM -0600, Wenjia Zhao wrote:
> Signed-off-by: Wenjia Zhao
There should be a patch description here explaining why the patch
is needed and how it works.
> ---
> drivers/video/backlight/pcf50633-backlight.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
plementing unused and untested special cases that
they would have to reason about.
Daniel.
>
> Daniel Thompson 于2021年2月2日周二 上午3:25写道：
>
> > On Mon, Feb 01, 2021 at 08:41:38AM -0600, Wenjia Zhao wrote:
> > > Signed-off-by: Wenjia Zhao
> >
> > There should be
ly avoided.
Therefore, slightly grudgingly,
Reviewed-by: Daniel Thompson
Daniel.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Wed, Feb 24, 2021 at 09:20:47AM +0530, Kiran Gunda wrote:
> Currently, for WLED5, after FSC register update MOD_SYNC_BIT
> is toggled instead of SYNC_BIT. MOD_SYNC_BIT has to be toggled
> after the brightness update and SYNC_BIT has to be toggled after
> FSC update for WLED5. Fix it.
Code looks
On Wed, Feb 24, 2021 at 09:20:48AM +0530, Kiran Gunda wrote:
> Currently the FSC SYNC_BIT and MOD_SYNC_BIT are toggled
> from 1 to 0 to update the FSC and brightenss settings.
> Change this sequence form 0 to 1 as per the hardware team
> recommendation to update the FSC and brightness correctly.
A
s
> update. For an FSC update we need to toggle the SYNC bits instead.
>
> Fix it by adopting the common wled3_sync_toggle() for WLED5 and
> introducing new code to the brightness update path to compensate.
>
> Signed-off-by: Kiran Gunda
Reviewed-by: Daniel Thompson
Daniel.
On Fri, Feb 26, 2021 at 05:42:24PM +0530, Kiran Gunda wrote:
> As per the current implementation, after FSC (Full Scale Current)
> and brightness update the sync bits are transitioned from 1 to 0.
This still seems to incorrectly describe the current behaviour.
Surely in most cases (i.e. every tim
On Mon, Mar 01, 2021 at 02:15:12PM +0530, kgu...@codeaurora.org wrote:
> On 2021-02-26 22:56, Daniel Thompson wrote:
> > On Fri, Feb 26, 2021 at 05:42:24PM +0530, Kiran Gunda wrote:
> > > As per the current implementation, after FSC (Full Scale Current)
> > > and brig
ous register state.
>
> Signed-off-by: Kiran Gunda
With one of each of the changes proposed above:
Reviewed-by: Daniel Thompson
Daniel.
> ---
> drivers/video/backlight/qcom-wled.c | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/dr
my way to this
patch, which fixed the problem for me.
Mine is an Armv8 system but there is nothing particularly exotic from a
graphics card or software point of view: Debian bullseye/wayland
(gnome-shell 3.38.3, mesa-20.3.4) running on a GT-710.
However FWIW:
Tested-by: Daniel Thompson
Danie
upport")
> Cc: Brian Masney
> Cc: Dan Murphy
> Signed-off-by: Andy Shevchenko
Reviewed-by: Daniel Thompson
> ---
> drivers/video/backlight/lm3630a_bl.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/video/backlight/lm3630a_bl.c
On Mon, May 17, 2021 at 11:58:39AM +0200, Juerg Haefliger wrote:
> Remove leading spaces before tabs in Kconfig file(s) by running the
> following command:
>
> $ find drivers/video/backlight -name 'Kconfig*' | \
> xargs sed -r -i 's/^[ ]+\t/\t/'
>
> Signed-off-by: Juerg Haefliger
> ---
>
On Wed, May 19, 2021 at 01:03:00PM +0200, Juerg Haefliger wrote:
> Remove leading whitespaces, replace multi spaces with tabs, and fix help
> text indentation.
>
> Signed-off-by: Juerg Haefliger
Reviewed-by: Daniel Thompson
Daniel.
> ---
> drivers/video/back
helper in
> backlight.c")
> Signed-off-by: Marek Vasut
> Cc: Daniel Thompson
> Cc: Meghana Madhyastha
> Cc: Noralf Trønnes
> Cc: Sean Paul
> Cc: Thierry Reding
I have to admit that this patch really does makes it clear just how
nasty the hack in of_find_backlight() cu
e we need to make sure the Fixes: tag doesn't provoke regressions
in v4.19.
Is this the syntax appropriate?
Cc: # 5.4+
Cc: # 4.19.x: ec665b756e6f7: backlight:
gpio-backlight: Correct initial power state handling
> > Signed-off-by: Marek Vasut
> > Cc: Daniel Thompson
&
d-off-by: Marek Vasut
> Cc: Christian Gmeiner
> Cc: Daniel Thompson
> Cc: Heiko Stuebner
> Cc: Philipp Zabel
> Cc: Thierry Reding
> Cc: linux-...@vger.kernel.org
> Cc: linux-fb...@vger.kernel.org
> To: dri-devel@lists.freedesktop.org
> ---
> NOTE: I think this wh
;
> Dear Lee,
>
> Could you take care about this patch?
Just in case Lee wants it:
Acked-by: Daniel Thompson
Daniel.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
e.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=ehreask5sqxpwr9y7k9sa6cwx...@mail.gmail.com/
> Signed-off-by: Jakob Koschel
Reviewed-by: Daniel Thompson
Daniel.
On Thu, Mar 03, 2022 at 03:26:57PM +0800, Xiaomeng Tong wrote:
> On Thu, 3 Mar 2022 04:58:23 +, David Laight wrote:
> > on 3 Mar 2022 10:27:29 +0800, Xiaomeng Tong wrote:
> > > The problem is the mis-use of iterator outside the loop on exit, and
> > > the iterator will be the HEAD's container_o
le at it, remove a useless test in devm_backlight_release(). 'data' is
> known to be not NULL when this function is called.
>
> Signed-off-by: Christophe JAILLET
Reviewed-by: Daniel Thompson
Daniel.
On Mon, Sep 06, 2021 at 11:55:25PM +0200, Thomas Weißschuh wrote:
> backlight.h documents "struct backlight_ops->get_brightness()" to return
> a negative errno on failure.
> So far these errors have not been handled in the backlight core.
> This leads to negative values being exposed through sysfs
ing exposed through sysfs although only
> positive values are documented to be reported.
>
> Signed-off-by: Thomas Weißschuh
Reviewed-by: Daniel Thompson
> ---
>
> v1:
> https://lore.kernel.org/dri-devel/20210906215525.15418-1-li...@weissschuh.net/
>
> v1 -&
On Fri, Sep 17, 2021 at 11:13:06AM +0800, Cai Huoqing wrote:
> When possible use dev_err_probe help to properly deal with the
> PROBE_DEFER error, the benefit is that DEFER issue will be logged
> in the devices_deferred debugfs file.
> Using dev_err_probe() can reduce code size, and the error value
On Fri, Sep 17, 2021 at 07:05:28PM +0800, Cai Huoqing wrote:
> Hi
> Thanks for your feedback.
> On 17 9月 21 10:17:29, Daniel Thompson wrote:
> > On Fri, Sep 17, 2021 at 11:13:06AM +0800, Cai Huoqing wrote:
> > > When possible use dev_err_probe help to properly deal with the
On Fri, Sep 17, 2021 at 08:53:23PM +0800, Cai Huoqing wrote:
> When possible use dev_err_probe help to properly deal with the
> PROBE_DEFER error, the benefit is that DEFER issue will be logged
> in the devices_deferred debugfs file.
> Using dev_err_probe() can reduce code size, and the error value
On Wed, Sep 22, 2021 at 04:10:14PM +0100, Mark Brown wrote:
> Currently autoloading for SPI devices does not use the DT ID table, it uses
> SPI modalises. Supporting OF modalises is going to be difficult if not
> impractical, an attempt was made but has been reverted, so ensure that
> module autolo
On Mon, Sep 27, 2021 at 12:47:27PM +0100, Mark Brown wrote:
> On Mon, Sep 27, 2021 at 10:42:00AM +0100, Daniel Thompson wrote:
>
> > Based on this I had expected to find spi_get_device_id() and a ->driver_data
> > somewhere in this patch.
>
> > Where will this .dri
On Mon, Sep 27, 2021 at 02:30:56PM +0100, Mark Brown wrote:
> On Mon, Sep 27, 2021 at 02:24:17PM +0100, Daniel Thompson wrote:
>
> > In that case what is the point of including unconsumed driver data? Most
> > DT centric drivers that included this for modalias reasons leave it
&
ten
> Reviewed-by: AngeloGioacchino Del Regno
>
Reviewed-by: Daniel Thompson
> ---
> drivers/video/backlight/qcom-wled.c | 13 ++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/video/backlight/qcom-wled.c
> b/drivers/video
chino Del Regno
>
Reviewed-by: Daniel Thompson
> ---
> drivers/video/backlight/qcom-wled.c | 25 +++--
> 1 file changed, 11 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/video/backlight/qcom-wled.c
> b/drivers/video/backlight/qcom-wled.c
> index 6a
On Mon, Oct 04, 2021 at 09:27:35PM +0200, Marijn Suijten wrote:
> The strings passed in DT may possibly cause out-of-bounds register
> accesses and should be validated before use.
>
> Fixes: 775d2ffb4af6 ("backlight: qcom-wled: Restructure the driver for WLED3")
The first half of this patch actua
On Mon, Oct 04, 2021 at 09:27:36PM +0200, Marijn Suijten wrote:
> When not specifying num-strings in the DT the default is used, but +1 is
> added to it which turns wled3 into 4 and wled4/5 into 5 strings instead
> of 3 and 4 respectively, causing out of bounds reads and register
> read/writes. Th
; not mapped to the desired purpose.
> Removing this value gets rid of undesired confusion and avoids the
> possibility of accessing registers at this offset even if the 4th array
> element is used by accident.
>
> Signed-off-by: Marijn Suijten
> Reviewed-by: AngeloGioacchino Del
ed, resuling in every string-specific register write
> (currently only the setup and config functions, brightness follows in a
> future patch) to only configure the zero'th string multiple times.
>
> Signed-off-by: Marijn Suijten
> Reviewed-by: AngeloGioacchino Del Regno
>
Reviewed-by: Daniel Thompson
>
Reviewed-by: Daniel Thompson
On Mon, Oct 04, 2021 at 09:27:40PM +0200, Marijn Suijten wrote:
> The hardware is capable of controlling any non-contiguous sequence of
> LEDs specified in the DT using qcom,enabled-strings as u32
> array, and this also follows from the DT-bindings documentation. The
> numbers specified in this ar
> and how many strings to enable.
>
> Fixes: 775d2ffb4af6 ("backlight: qcom-wled: Restructure the driver for WLED3")
> Signed-off-by: Marijn Suijten
> Reviewed-by: AngeloGioacchino Del Regno
>
Reviewed-by: Daniel Thompson
On Tue, Oct 05, 2021 at 12:06:06PM +0200, Marijn Suijten wrote:
> On 2021-10-05 10:19:47, Daniel Thompson wrote:
> > On Mon, Oct 04, 2021 at 09:27:36PM +0200, Marijn Suijten wrote:
> > > When not specifying num-strings in the DT the default is used, but +1 is
> > > ad
On Tue, Oct 05, 2021 at 12:03:50PM +0200, Marijn Suijten wrote:
> On 2021-10-05 10:14:52, Daniel Thompson wrote:
> > On Mon, Oct 04, 2021 at 09:27:35PM +0200, Marijn Suijten wrote:
> > > The strings passed in DT may possibly cause out-of-bounds register
> > > acces
On Tue, Oct 05, 2021 at 11:38:43AM +0100, Daniel Thompson wrote:
> On Tue, Oct 05, 2021 at 12:06:06PM +0200, Marijn Suijten wrote:
> > On 2021-10-05 10:19:47, Daniel Thompson wrote:
> > > On Mon, Oct 04, 2021 at 09:27:36PM +0200, Marijn Suijten wrote:
> > > > When not
On Tue, Oct 05, 2021 at 01:44:35PM +0200, Marijn Suijten wrote:
> On 2021-10-05 11:53:12, Daniel Thompson wrote:
> > On Tue, Oct 05, 2021 at 11:38:43AM +0100, Daniel Thompson wrote:
> > > On Tue, Oct 05, 2021 at 12:06:06PM +0200, Marijn Suijten wrote:
> > > >
On Tue, Oct 05, 2021 at 05:23:26PM +0200, Marijn Suijten wrote:
> On 2021-10-05 15:03:49, Daniel Thompson wrote:
> [..]
> > > At that point one might ask why qcom,num_strings remains at all when
> > > DT can use qcom,enabled_strings instead. We will supposedly have
On Tue, Oct 05, 2021 at 07:34:00PM +0200, Marijn Suijten wrote:
> On 2021-10-05 17:24:53, Daniel Thompson wrote:
> > On Tue, Oct 05, 2021 at 05:23:26PM +0200, Marijn Suijten wrote:
> > > Since there don't seem to be any substantial platforms/PMICs using this
> > > f
On Fri, Jan 21, 2022 at 01:54:29PM -0300, Luiz Sampaio wrote:
> The enum led_brightness, which contains the declaration of LED_OFF,
> LED_ON, LED_HALF and LED_FULL is obsolete, as the led class now supports
> max_brightness.
Reviewed-by: Daniel Thompson
BTW it looks like this patch mi
MPT_RT kernels
(and avoid calling any kernel API that uses regular spinlocks).
Fix this by removing the spurious additional flag.
This change is required for my Snapdragon 7cx Gen2 tablet to boot-to-GUI
with PREEMPT_RT enabled.
Signed-off-by: Daniel Thompson
---
Notes:
Just in case any
nges in v2:
- Split into separate patches (Dmitry B)
Daniel Thompson (2):
drm/msm/dsi: Remove spurious IRQF_ONESHOT flag
drm/msm/hdmi: Remove spurious IRQF_ONESHOT flag
drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +-
drivers/gpu/drm/msm/hdmi/hdmi.c| 2 +-
2 files changed, 2 insertions(+), 2
nlock API for locking (in msm_hdmi_hdcp_irq() ). Neither
of these APIs can be called from no-thread interrupt handlers on
PREEMPT_RT systems.
Fix this by removing IRQF_ONESHOT.
Signed-off-by: Daniel Thompson
---
drivers/gpu/drm/msm/hdmi/hdmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
MPT_RT kernels
(and avoid calling any kernel API that uses regular spinlocks).
Fix this by removing the spurious additional flag.
This change is required for my Snapdragon 7cx Gen2 tablet to boot-to-GUI
with PREEMPT_RT enabled.
Signed-off-by: Daniel Thompson
---
drivers/gpu/drm/msm/dsi/dsi_host.c
elevant
function pointers ;-) ).
Improve the kernel doc comments accordingly.
Signed-off-by: Daniel Thompson
---
Notes:
Changes in v3:
- Rebased on v5.17-rc2
- Minor improvements to wording.
Changes in v2:
- Oops. I did a final proof read and acidentally committed these
On Tue, Nov 02, 2021 at 10:04:55AM +, Corentin LABBE wrote:
> From: Jean-Jacques Hiblot
>
> This patch adds support for an "enable GPIO".
Before taking this kind of change is there a good reason why backlight
should manage the GPIO? I thought that the LED subsystem was a sub
system for LEDs
On Tue, Nov 02, 2021 at 11:19:42AM +, Daniel Thompson wrote:
> On Tue, Nov 02, 2021 at 10:04:55AM +, Corentin LABBE wrote:
> > From: Jean-Jacques Hiblot
> >
> > This patch adds support for an "enable GPIO".
>
> Before taking this kind of change
On Mon, Nov 01, 2021 at 07:55:17PM +0100, Hans de Goede wrote:
> The Xiaomi Mi Pad 2 tablet uses an ACPI enumerated LP8556 backlight
> controller for its LCD-panel, with a Xiaomi specific ACPI HID of
> "XMCC0001", add support for this.
>
> Note the new "if (id)" check also fixes a NULL pointer der
ing -EPROBE_DEFER errors for us.
>
> This is mostly a preparation for adding ACPI enumeration support which
> will use the new "dev" variable more.
>
> Signed-off-by: Hans de Goede
Reviewed-by: Daniel Thompson
Daniel.
g ACPI enumeration support.
>
> Signed-off-by: Hans de Goede
Reviewed-by: Daniel Thompson
Daniel.
On Mon, Nov 01, 2021 at 10:19:21AM -0300, Maíra Canal wrote:
> Remove legacy PWM interface (pwm_config, pwm_enable, pwm_disable) and
> replace it for the atomic PWM API.
>
> Signed-off-by: Maíra Canal
> ---
> V1 -> V2: Initialize variable and simply conditional loop
> V2 -> V3: Fix assignment of
ot; check also fixes a NULL pointer deref when a user
> tries to manually bind the driver from sysfs.
>
> When CONFIG_ACPI is disabled acpi_match_device() will always return NULL,
> so the lp855x_parse_acpi() call will get optimized away.
>
> Signed-off-by: Hans de Goede
Reviewed-by: Daniel Thompson
Daniel.
On Wed, Nov 03, 2021 at 06:28:15PM +0100, Hans de Goede wrote:
> Hi,
>
> On 11/3/21 18:17, Daniel Thompson wrote:
> > On Tue, Nov 02, 2021 at 11:55:04PM +0100, Hans de Goede wrote:
> >> The Xiaomi Mi Pad 2 tablet uses an ACPI enumerated LP8556 backlight
> >> con
On Thu, Nov 04, 2021 at 02:58:38PM -0300, Maíra Canal wrote:
> Remove legacy PWM interface (pwm_config, pwm_enable, pwm_disable) and
> replace it for the atomic PWM API.
>
> Signed-off-by: Maíra Canal
Reviewed-by: Daniel Thompson
Daniel.
ed-off-by: Marijn Suijten
> Reviewed-by: AngeloGioacchino Del Regno
>
Reviewed-by: Daniel Thompson
Daniel.
On Fri, Nov 12, 2021 at 01:26:57AM +0100, Marijn Suijten wrote:
> When not specifying num-strings in the DT the default is used, but +1 is
> added to it which turns WLED3 into 4 and WLED4/5 into 5 strings instead
> of 3 and 4 respectively, causing out-of-bounds reads and register
> read/writes. Th
On Fri, Nov 12, 2021 at 01:26:58AM +0100, Marijn Suijten wrote:
> The length of qcom,enabled-strings as property array is enough to
> determine the number of strings to be enabled, without needing to set
> qcom,num-strings to override the default number of strings when less
> than the default (whic
s on a different set of strings.
>
> Fixes: 775d2ffb4af6 ("backlight: qcom-wled: Restructure the driver for WLED3")
> Fixes: 03b2b5e86986 ("backlight: qcom-wled: Add support for WLED4 peripheral")
> Signed-off-by: Marijn Suijten
> Reviewed-by: AngeloGioacchino Del Regno
>
Reviewed-by: Daniel Thompson
Daniel.
On Fri, Nov 12, 2021 at 01:35:01PM +0100, Marijn Suijten wrote:
> On 2021-11-12 12:08:39, Daniel Thompson wrote:
> > On Fri, Nov 12, 2021 at 01:26:57AM +0100, Marijn Suijten wrote:
> > > + if (string_len > 0) {
> > > + dev_warn(dev, "qcom,
On Fri, Nov 12, 2021 at 01:45:22PM +0100, Marijn Suijten wrote:
> On 2021-11-12 12:12:38, Daniel Thompson wrote:
> > On Fri, Nov 12, 2021 at 01:26:58AM +0100, Marijn Suijten wrote:
> > > The length of qcom,enabled-strings as property array is enough to
> > > determine
On Fri, Nov 12, 2021 at 03:19:17PM +0100, Marijn Suijten wrote:
> On 2021-11-12 13:23:36, Daniel Thompson wrote:
> > On Fri, Nov 12, 2021 at 01:45:22PM +0100, Marijn Suijten wrote:
> > > On 2021-11-12 12:12:38, Daniel Thompson wrote:
> > > > On Fri, Nov 12, 2021 at 01
On Fri, Nov 12, 2021 at 10:43:37PM +0100, Marijn Suijten wrote:
> On 2021-11-12 13:35:03, Marijn Suijten wrote:
> > On 2021-11-12 12:08:39, Daniel Thompson wrote:
> > > On Fri, Nov 12, 2021 at 01:26:57AM +0100, Marijn Suijten wrote:
> > > > When not specifying num-st
return value of
> 'ili922x_write'
> ili922x.c:353: warning: No description found for return value of
> 'ili922x_poweron'
> ili922x.c:382: warning: No description found for return value of
> 'ili922x_poweroff'
>
> Fixes: 4cfbfa971478 ("vide
return value of
> 'ili922x_write'
> ili922x.c:353: warning: No description found for return value of
> 'ili922x_poweron'
> ili922x.c:382: warning: No description found for return value of
> 'ili922x_poweroff'
>
> Fixes: 4cfbfa971478 ("vide
chino Del Regno
>
Reviewed-by: Daniel Thompson
Daniel.
fixed read of
> four elements from that array (has been addressed in a prior patch) by
> setting a lower num-strings where desired.
>
> Fixes: 93c64f1ea1e8 ("leds: add Qualcomm PM8941 WLED driver")
> Signed-off-by: Marijn Suijten
> Reviewed-By: AngeloGioacchino Del Regno
>
Reviewed-by: Daniel Thompson
Daniel.
e of strings is needed (the majority of the cases), or to only set
> qcom,enabled-strings when a specific set of indices is desired.
>
> Fixes: 775d2ffb4af6 ("backlight: qcom-wled: Restructure the driver for WLED3")
> Signed-off-by: Marijn Suijten
> Reviewed-by: AngeloGi
Hi Lee
On Mon, Nov 15, 2021 at 09:34:50PM +0100, Marijn Suijten wrote:
> This patchset fixes WLED's handling of enabled-strings: besides some
> cleanup it is now actually possible to specify a non-contiguous array of
> enabled strings (not necessarily starting at zero) and the values from
> DT are
On Mon, Dec 14, 2020 at 09:34:58PM +0800, Zheng Yongjun wrote:
> Replace a comma between expression statements by a semicolon.
>
> Signed-off-by: Zheng Yongjun
Weird! I guess it was harmless but still seriously weird ;-)
Reviewed-by: Daniel Thompson
Thanks!
> ---
> drivers/
On Wed, Dec 23, 2020 at 10:10:35PM +0800, Zheng Yongjun wrote:
> Signed-off-by: Zheng Yongjun
Can you explain the Subject for this patch in more detail?
If this patch is required to correct a bug then it looks to me like it
is incomplete.
Daniel.
> ---
> drivers/video/backlight/backlight.c
1 - 100 of 780 matches
Mail list logo
