[PATCH 6/8] drm: Make drm_fb_cma_describe() static

This function is only used in drm_fb_cma_helper.c. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_fb_cma_helper.c | 5 ++--- include/drm/drm_fb_cma_helper.h | 1 - 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm

[PATCH 7/8] drm: Remove unused PCI ids

Signed-off-by: Damien Lespiau --- include/drm/drm_pciids.h | 30 -- 1 file changed, 30 deletions(-) diff --git a/include/drm/drm_pciids.h b/include/drm/drm_pciids.h index 34efaf6..0a85e5c 100644 --- a/include/drm/drm_pciids.h +++ b/include/drm/drm_pciids.h @@ -690,29

[PATCH 8/8] drm: Make drm_get_platform_dev() static

It's only used in drm_platform.c. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_platform.c | 7 +++ include/drm/drmP.h | 3 --- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/drm_platform.c b/drivers/gpu/drm/drm_platform.c index b8

Re: [PATCH 8/8] drm: Make drm_get_platform_dev() static

On Tue, Aug 20, 2013 at 07:56:42AM -0700, Ian Romanick wrote: > On 08/19/2013 04:53 PM, Damien Lespiau wrote: > >It's only used in drm_platform.c. > > > >Signed-off-by: Damien Lespiau > >--- > > drivers/gpu/drm/drm_platform.c | 7 +++ > > include

Re: [PATCH 09/12] drm/edid: Move HDMI_IDENTIFIER to hdmi.h

On Mon, Aug 19, 2013 at 09:31:42PM +0200, Thierry Reding wrote: > On Mon, Aug 19, 2013 at 02:49:50PM +0100, Damien Lespiau wrote: > > On Thu, Aug 15, 2013 at 05:12:00PM +0200, Thierry Reding wrote: > > > On Wed, Aug 14, 2013 at 06:19:12PM +0100, Damien Lespiau wrote: > >

[PATCH] drm: Remove the dithering_mode_property field

truct drm_mode_config. Signed-off-by: Damien Lespiau --- include/drm/drm_crtc.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index 0a9f73e..960a27c 100644 --- a/include/drm/drm_crtc.h +++ b/include/drm/drm_crtc.h @@ -837,7 +837,6 @@ struct drm_mode_c

Re: [Linaro-mm-sig] [RFC 0/4] Atomic Display Framework

On Thu, Aug 29, 2013 at 10:58:51AM +0300, Ville Syrjälä wrote: > After that we need to figure out how we can expose them to userspace w/o > risking breaking stuff too much. Maybe a new ioctl to enumerate private > planes only? And the maybe only accept direct use of private planes via > the atomic

Re: [PATCH 6/6] intel: Update package name and description in libdrm_intel.pc

On Thu, Aug 29, 2013 at 09:31:54PM +0100, Emil Velikov wrote: > Currently the package name and description duplicate that of the > core libdrm. Update those to reflect reality. > > Cc: Daniel Vetter > Signed-off-by: Emil Velikov Looks good to me: Reviewed-by: Damien Lespi

[PATCH] drm: Fix kerneldoc of drm_crtc_convert_umode()

>From the copy and paste of drm_crtc_convert_to_umode()'s kerneldoc, forgetting to update the symbol name (and they look so similar!). Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_

[libdrm] Stereo 3D

libdrm's support for: http://lists.freedesktop.org/archives/dri-devel/2013-September/044885.html -- Damien ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 3/9] drm: Make sure every ioctl structure has a typedef

Just for consistency. Signed-off-by: Damien Lespiau --- include/uapi/drm/drm.h | 29 + 1 file changed, 29 insertions(+) diff --git a/include/uapi/drm/drm.h b/include/uapi/drm/drm.h index b8604d2..0430fab 100644 --- a/include/uapi/drm/drm.h +++ b/include/uapi/drm

[PATCH 1/9] drm: Move the GET_CAP macros next to the corresponding ioctl structure

It's a tiny bit more logical to find the different capabilities you can use with the GET_CAP ioctl next to the structure rather than putting them at the end of the file. Signed-off-by: Damien Lespiau --- include/uapi/drm/drm.h | 20 ++-- 1 file changed, 10 insertions(+

[PATCH 2/9] drm: Sort userspace typedefs by ioctl number

This way, it's easier to catch ioctl structures that are not yet typedef'ed and provide a more consistent API. Signed-off-by: Damien Lespiau --- include/uapi/drm/drm.h | 45 - 1 file changed, 24 insertions(+), 21 deletions(-) diff --git

[PATCH 7/9] drm/edid: Expose mandatory stereo modes for HDMI sinks

For now, let's just look at the 3D_present flag of the CEA HDMI vendor block to detect if the sink supports a small list of then mandatory 3D formats. See the HDMI 1.4a 3D extraction for detail: http://www.hdmi.org/manufacturer/specification.aspx Signed-off-by: Damien Lespiau --- driver

[PATCH 4/9] drm: Add a SET_CAP ioctl

This ioctl can be used to turn some knobs in a DRM driver. This is the counterpart of GET_CAP and serves a similar role than the various SETPARAM ioctls that are driver specific, but for DRM core. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_drv.c | 1 + drivers/gpu/drm/drm_ioctl.c

[PATCH 5/9] drm: Add HDMI stereo 3D flags to struct drm_mode_modeinfo

HDMI 1.4a defines a few layouts that we'd like to expose. This commits add new modeinfo flags that can be used to list the supported stereo layouts (when querying the list of modes) and to set a given stereo 3D mode (when setting a mode). Signed-off-by: Damien Lespiau --- include/drm/drm_c

Stereo 3D v3

Follow up of: http://lists.freedesktop.org/archives/dri-devel/2012-September/028278.html Let's try again! This time, intead of a magic connector property to select if we want to return more modeinfo flags to userspace, this series introduces a new SET_CAP ioctl. So the flow goes as following:

[PATCH 6/9] drm: Add a DRM_CAP_STEREO_3D capability for SET_CAP ioctl

3D flags from the user mode modeinfo structure by default, and let them through if we are being told otherwise. stereo_allowed is bound to the drm_file structure to make it a per-client setting, not a global one. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_crtc.c | 16

[PATCH 9/9] drm: Set the relevant infoframe field when scanning out a 3D mode

When scanning out a 3D mode on HDMI, we need to send an HDMI infoframe with the corresponding layout to the sink. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_edid.c | 25 +++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 8/9] drm: Reject modes with more than 1 stereo flags set

When setting a stereo 3D mode, there can be only one bit set describing the layout of the frambuffer(s). So reject invalid modes early. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_crtc.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu

[PATCH libdrm 1/3] drm: Synchronize the stereo 3D mode flags from the kernel headers

Signed-off-by: Damien Lespiau --- include/drm/drm_mode.h | 36 ++-- xf86drmMode.h | 36 ++-- 2 files changed, 44 insertions(+), 28 deletions(-) diff --git a/include/drm/drm_mode.h b/include/drm/drm_mode.h index d41d76b

[PATCH libdrm 2/3] drm: Sync the DRM_SET_CAP ioctl definition

Signed-off-by: Damien Lespiau --- include/drm/drm.h | 16 1 file changed, 16 insertions(+) diff --git a/include/drm/drm.h b/include/drm/drm.h index 71a2ac1..165231b 100644 --- a/include/drm/drm.h +++ b/include/drm/drm.h @@ -618,6 +618,21 @@ struct drm_get_cap { __u64

[PATCH libdrm 3/3] drm: Introduce a drmSetCap() wrapper

That wraps around the new DRM_SET_CAP ioctl. Signed-off-by: Damien Lespiau --- xf86drm.c | 7 +++ xf86drm.h | 1 + 2 files changed, 8 insertions(+) diff --git a/xf86drm.c b/xf86drm.c index 4791a05..dac6a52 100644 --- a/xf86drm.c +++ b/xf86drm.c @@ -823,6 +823,13 @@ int drmGetCap(int fd

Re: [PATCH 6/9] drm: Add a DRM_CAP_STEREO_3D capability for SET_CAP ioctl

On Sun, Sep 08, 2013 at 03:50:29PM +0200, David Herrmann wrote: > Hi > > On Fri, Sep 6, 2013 at 8:57 PM, Damien Lespiau > wrote: > > This capability allows user space to control the delivery of modes with > > the 3D flags set. This is to not play games with current

Re: Stereo 3D v3

On Sun, Sep 08, 2013 at 03:46:43PM +0200, David Herrmann wrote: > The series implements SET_CAP as a per _file_ capability set, not per > master. I like it this way. Note that with SET_VERSION, we already > have a per _master_ capability set. Compared to SET_CAP it only allows > incremental capabil

Re: [PATCH 3/9] drm: Make sure every ioctl structure has a typedef

On Sun, Sep 08, 2013 at 01:58:29PM +0200, Daniel Vetter wrote: > On Fri, Sep 06, 2013 at 07:57:19PM +0100, Damien Lespiau wrote: > > Just for consistency. > > > > Signed-off-by: Damien Lespiau > > Afaik kernel coding style is to echew typdefs for normal structures

[PATCH] drm/radeon: Fix hmdi typo

I keep making that one, so checked if I was the only one. Apparently not. Cc: Alex Deucher Signed-off-by: Damien Lespiau --- drivers/gpu/drm/radeon/r600d.h | 2 +- drivers/gpu/drm/radeon/radeon_connectors.c | 2 +- drivers/gpu/drm/radeon/rv770d.h| 2 +- 3 files changed

[PATCH 06/12] drm: Extract add_hdmi_mode() out of do_hdmi_vsdb_modes()

So we respect a nice design of having similar functions at the same level, in this case: do_hdmi_vsdb_modes() - add_hdmi_mandatory_stereo_modes() - add_hdmi_mode() Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_edid.c | 36 +--- 1 file changed, 21

[PATCH 08/12] drm: Set the relevant infoframe field when scanning out a 3D mode

When scanning out a 3D mode on HDMI, we need to send an HDMI infoframe with the corresponding layout to the sink. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_edid.c | 25 +++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 09/12] drm: Track the number of buffers that compose a framebuffer

DRM has supported multiple-buffers fbs since the introduction of ADDFB2. Let's track the number of buffers in a drm_framebuffer in the common structure so we can use it in the DRM core. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_crtc_helper.c | 20 includ

[PATCH 02/12] drm: Add a SET_CLIENT_CAP ioctl

SET_CAP to SET_CLIENT_CAP (Chris Wilson) Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_drv.c | 1 + drivers/gpu/drm/drm_ioctl.c | 9 + include/drm/drmP.h | 2 ++ include/uapi/drm/drm.h | 7 +++ 4 files changed, 19 insertions(+) diff --git a/drivers/gpu/drm

[PATCH 11/12] drm: Make drm_match_cea_mode() return the underlying 2D VIC for 3d modes

When scanning out a stereo mode, the AVI infoframe vic field has to be the underlyng 2D VIC. Before that commit, we weren't matching the CEA mode because of the extra stereo flag and then were setting the VIC field in the AVI infoframe to 0. Signed-off-by: Damien Lespiau --- drivers/gp

[PATCH 03/12] drm: Add HDMI stereo 3D flags to struct drm_mode_modeinfo

ff-by: Damien Lespiau --- include/drm/drm_crtc.h | 14 ++ include/uapi/drm/drm_mode.h | 36 ++-- 2 files changed, 36 insertions(+), 14 deletions(-) diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index f660ac5..bf242ac 100644 --- a/includ

[PATCH 01/12] drm: Move the GET_CAP macros next to the corresponding ioctl structure

gs of DRM_CAP_PRIME. Reviewed-by: David Herrmann (for v2) Signed-off-by: Damien Lespiau --- include/uapi/drm/drm.h | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/include/uapi/drm/drm.h b/include/uapi/drm/drm.h index 272580c..3ad0640 100644 --- a/include/uapi/drm/

[PATCH 10/12] drm: Don't allow multiple buffers fb with stereo modes

fbs and 2 buffers fbs (No.) So for now, and until I get access to hardware that can do that, let's just disallow 2 buffers stereo framebuffers to not introduce ABI we wouldn't be able to change afterwards. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_crtc.c | 11 +

[PATCH 07/12] drm: Reject modes with more than 1 stereo flags set

When setting a stereo 3D mode, there can be only one bit set describing the layout of the frambuffer(s). So reject invalid modes early. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_crtc.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu

[PATCH 12/12] drm: Carry over the stereo flags when adding the alternate mode

This allows to expose the alternate clock versions of the stereo modes. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_edid.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 6b74698..55dac77 100644 --- a/drivers/gpu/drm

Re: [PATCH 6/9] drm: Add a DRM_CAP_STEREO_3D capability for SET_CAP?ioctl

On Fri, Sep 13, 2013 at 04:04:02PM +, Joakim Plate wrote: > David Herrmann gmail.com> writes: > > > > > So just to be clear: Whenever a mode is present with 3D flags, it is > > also a valid non-3D mode? Is this guaranteed? > > > > Well.. Some HDTV's will when they receive a frame packed m

[libdrm] Stereo 3D v2

This series is the counterpart of "HDMI stereo support v4" and a revision of: http://lists.freedesktop.org/archives/dri-devel/2013-September/044895.html v2 is just to addresse the name change the DRM_SET_CLIENT_CAP ioctl from DRM_SET_CAP. -- Damien

[PATCH libdrm 2/3] drm: Sync the DRM_SET_CLIENT_CAP ioctl definition

v2: SET_CAP -> SET_CLIENT_CAP renaming Signed-off-by: Damien Lespiau --- include/drm/drm.h | 16 1 file changed, 16 insertions(+) diff --git a/include/drm/drm.h b/include/drm/drm.h index 71a2ac1..c7df023 100644 --- a/include/drm/drm.h +++ b/include/drm/drm.h @@ -618,6 +618

[PATCH libdrm 1/3] drm: Synchronize the stereo 3D mode flags from the kernel headers

Signed-off-by: Damien Lespiau --- include/drm/drm_mode.h | 36 ++-- xf86drmMode.h | 36 ++-- 2 files changed, 44 insertions(+), 28 deletions(-) diff --git a/include/drm/drm_mode.h b/include/drm/drm_mode.h index d41d76b

HDMI stereo support v4

Next installment of the HDMI stereo 3D series, following: http://lists.freedesktop.org/archives/dri-devel/2013-September/044885.html Quite a few changes here, and it's starting to "feel right": - We now expose each stereo layout as a separate mode, distinct from the 2D mode, instead of pig

Re: [PATCH 7/9] drm/edid: Expose mandatory stereo modes for HDMI sinks

On Fri, Sep 13, 2013 at 04:10:24PM +, Joakim Plate wrote: > Damien Lespiau intel.com> writes: > > > +static const struct s3d_mandatory_mode s3d_mandatory_modes[] = { > > + { 1920, 1080, 24, 0, > > + DRM_MODE_FLAG_3D_TOP_AND_BOTTOM | DRM_MODE_FLAG_3D_FRAME_P

[PATCH 04/12] drm: Add a STEREO_3D capability to the SET_CLIENT_CAP ioctl

are regular modes. v3: SET_CAP -> SET_CLIENT_CAP rename (Chris Wilson) Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_crtc.c | 19 ++- drivers/gpu/drm/drm_ioctl.c | 14 +- include/drm/drmP.h | 3 +++ include/uapi/drm/drm.h | 9 + 4 fi

[PATCH 05/12] drm/edid: Expose mandatory stereo modes for HDMI sinks

For now, let's just look at the 3D_present flag of the CEA HDMI vendor block to detect if the sink supports a small list of then mandatory 3D formats. See the HDMI 1.4a 3D extraction for detail: http://www.hdmi.org/manufacturer/specification.aspx Signed-off-by: Damien Lespiau --- driver

[PATCH libdrm 3/3] drm: Introduce a drmSetClientCap() wrapper

That wraps around the new DRM_SET_CLIENT_CAP ioctl. v2: SET_CAP -> SET_CLIENT_CAP renaming Signed-off-by: Damien Lespiau --- xf86drm.c | 7 +++ xf86drm.h | 2 ++ 2 files changed, 9 insertions(+) diff --git a/xf86drm.c b/xf86drm.c index 4791a05..720952f 100644 --- a/xf86drm.c ++

Re: [PATCH 05/12] drm/edid: Expose mandatory stereo modes for HDMI sinks

On Mon, Sep 16, 2013 at 09:29:31PM +0300, Ville Syrjälä wrote: > > static int > > do_hdmi_vsdb_modes(struct drm_connector *connector, const u8 *db, u8 len) > > @@ -2582,10 +2662,15 @@ do_hdmi_vsdb_modes(struct drm_connector *connector, > > const u8 *db, u8 len) > > > > /* the declared leng

Re: [Intel-gfx] [PATCH 11/12] drm: Make drm_match_cea_mode() return the underlying 2D VIC for 3d modes

On Tue, Sep 17, 2013 at 11:22:26AM +0300, Ville Syrjälä wrote: > On Mon, Sep 16, 2013 at 06:48:54PM +0100, Damien Lespiau wrote: > > When scanning out a stereo mode, the AVI infoframe vic field has to be > > the underlyng 2D VIC. Before that commit, we weren't matching the CEA

Re: [Intel-gfx] [PATCH 10/12] drm: Don't allow multiple buffers fb with stereo modes

On Tue, Sep 17, 2013 at 11:20:46AM +0300, Ville Syrjälä wrote: > +++ b/drivers/gpu/drm/drm_crtc.c > > @@ -2131,6 +2131,17 @@ int drm_mode_setcrtc(struct drm_device *dev, void > > *data, > > goto out; > > } > > > > + /* > > +* Do not allow th

Re: HDMI stereo support v4

On Mon, Sep 16, 2013 at 06:48:43PM +0100, Damien Lespiau wrote: > Next installment of the HDMI stereo 3D series, following: > http://lists.freedesktop.org/archives/dri-devel/2013-September/044885.html Seems like a v5 is shapping up. I'll summarise the discussion with Daniel on IRC ye

Re: [PATCH 7/9] drm/edid: Expose mandatory stereo modes for HDMI sinks

On Mon, Sep 16, 2013 at 06:35:12PM +0100, Damien Lespiau wrote: > On Fri, Sep 13, 2013 at 04:10:24PM +, Joakim Plate wrote: > > Damien Lespiau intel.com> writes: > > > > > +static const struct s3d_mandatory_mode s3d_mandatory_modes[] = {

Re: [Intel-gfx] [PATCH 10/12] drm: Don't allow multiple buffers fb with stereo modes

On Tue, Sep 17, 2013 at 12:37:48PM +0200, Daniel Vetter wrote: > I guess we should start to check that. For 3d framebuffers with 2 > separate buffer handles for each plane I think we need to add another flag > to addfb2, e.g. > > #define DRM_MODE_FB_3D_2_FRAMES (1<<1) /* separate left/right buffer

Re: [PATCH 05/12] drm/edid: Expose mandatory stereo modes for HDMI sinks

On Mon, Sep 16, 2013 at 09:29:31PM +0300, Ville Syrjälä wrote: > > +struct stereo_mandatory_mode { > > + int width, height, freq; [..] > > + unsigned int interlace_flag, layouts; > > What's the benefit of separating the two? Just that we can easily cycle through the layout flags and add a m

HDMI stereo support v5

v4 was: http://lists.freedesktop.org/archives/dri-devel/2013-September/045340.html Changes from v4: - The kernel is now in charge of adjusting the stereo mode timings. - There is a per-connector opt-in boolean to expose stereo modes, letting people enable stereo for each driver/connector.

[PATCH 01/20] drm: Add a SET_CLIENT_CAP ioctl

SET_CAP to SET_CLIENT_CAP (Chris Wilson) Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_drv.c | 1 + drivers/gpu/drm/drm_ioctl.c | 9 + include/drm/drmP.h | 2 ++ include/uapi/drm/drm.h | 7 +++ 4 files changed, 19 insertions(+) diff --git a/drivers/gpu/drm

[PATCH 02/20] drm: Add HDMI stereo 3D flags to struct drm_mode_modeinfo

ff-by: Damien Lespiau --- include/drm/drm_crtc.h | 14 ++ include/uapi/drm/drm_mode.h | 36 ++-- 2 files changed, 36 insertions(+), 14 deletions(-) diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index 24f4995..825d6fa 100644 --- a/includ

[PATCH 13/20] drm: Introduce a crtc_clock for struct drm_display_mode

Just like the various timings, make it possible to have a clock field what we can tweak before giving it to hardware. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_modes.c | 1 + include/drm/drm_crtc.h | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/gpu/drm

[PATCH 18/20] drm/i915: Ask the DRM core do make stereo timings adjustements

When scanning out big stereo buffers that are actually bigger that their natural 2D counterpart, we need to blow up the crtc timings as well. Not that this is only done for frame packing as this is the only stereo mode currently exposed needing this kind of ajdustements. Signed-off-by: Damien

[PATCH 14/20] drm: Implement timings adjustments for frame packing

etter Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_modes.c | 51 - include/drm/drm_crtc.h | 3 ++- 2 files changed, 52 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c index ef26eb2..d9c5a34 1

[PATCH 11/20] drm: Remove clock_index from struct drm_display_mode

This field was only accessed by the nouveau driver, but never set. So concluded we can rid of this one. Cc: Ben Skeggs Signed-off-by: Damien Lespiau --- drivers/gpu/drm/nouveau/dispnv04/crtc.c | 2 -- include/drm/drm_crtc.h | 1 - 2 files changed, 3 deletions(-) diff --git a

[PATCH 15/20] drm/i915: Use crtc_clock in intel_dump_crtc_timings()

We want to dump the parameters given to the hardware, so let's use crtc_clock here. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm

[PATCH 05/20] drm: Extract add_hdmi_mode() out of do_hdmi_vsdb_modes()

So we respect a nice design of having similar functions at the same level, in this case: do_hdmi_vsdb_modes() - add_hdmi_mandatory_stereo_modes() - add_hdmi_mode() Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_edid.c | 36 +--- 1 file changed, 21

[PATCH 17/20] drm/i915: Use adjusted_mode in the fastboot hack to disable pfit

When booting with i915.fastboot=1, we always take tha code path and end up undoing what we're trying to do with adjusted_mode. Hopefully, as the fastboot hardware readout code is using adjusted_mode as well, it should be equivalent. Signed-off-by: Damien Lespiau --- drivers/gpu/drm

[PATCH 06/20] drm: Reject modes with more than 1 stereo flags set

When setting a stereo 3D mode, there can be only one bit set describing the layout of the frambuffer(s). So reject invalid modes early. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_crtc.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu

[PATCH 04/20] drm/edid: Expose mandatory stereo modes for HDMI sinks

atory structure a bit more compact, fix some white space issues and add a couple of const (Ville Syrjälä) Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_edid.c | 110 ++--- 1 file changed, 103 insertions(+), 7 deletions(-) diff --git a/dr

[PATCH 03/20] drm: Add a STEREO_3D capability to the SET_CLIENT_CAP ioctl

are regular modes. v3: SET_CAP -> SET_CLIENT_CAP rename (Chris Wilson) Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_crtc.c | 19 ++- drivers/gpu/drm/drm_ioctl.c | 14 +- include/drm/drmP.h | 3 +++ include/uapi/drm/drm.h | 9 + 4 fi

[PATCH 12/20] drm: Remove synth_clock from struct drm_display_mode

This field is unused. Garbage collect it. Signed-off-by: Damien Lespiau --- include/drm/drm_crtc.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index 011baaa..8e9716e 100644 --- a/include/drm/drm_crtc.h +++ b/include/drm/drm_crtc.h @@ -156,7

[PATCH 08/20] drm: Make drm_match_cea_mode() return the underlying 2D VIC for 3d modes

When scanning out a stereo mode, the AVI infoframe vic field has to be the underlyng 2D VIC. Before that commit, we weren't matching the CEA mode because of the extra stereo flag and then were setting the VIC field in the AVI infoframe to 0. Signed-off-by: Damien Lespiau --- drivers/gp

[PATCH 09/20] drm: Carry over the stereo flags when adding the alternate mode

This allows to expose the alternate clock versions of the stereo modes. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_edid.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 48f1746..c24af1d 100644 --- a/drivers/gpu/drm

[PATCH 07/20] drm: Set the relevant infoframe field when scanning out a 3D mode

When scanning out a 3D mode on HDMI, we need to send an HDMI infoframe with the corresponding layout to the sink. v2: Make s3d_structure_from_display_mode() less subtle (Ville Syrjälä) Reviewed-by: Ville Syrjälä Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_edid.c | 40

[PATCH 10/20] drm: Make exposing stereo modes a per-connector opt-in

Just like with interlaced or double scan modes, make stereo modes a per-connector opt-in to give a chance to driver authors to make it work before enabling it. Suggested-by: Daniel Vetter Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_crtc_helper.c | 8 +++- include/drm/drm_crtc.h

[PATCH 16/20] drm/i915: Use crtc_clock with the adjusted mode

k. No functional change. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_crt.c | 2 +- drivers/gpu/drm/i915/intel_display.c | 36 ++-- drivers/gpu/drm/i915/intel_dp.c | 11 +++ drivers/gpu/drm/i915/intel_drv.h | 2 +- drivers/gp

[PATCH 19/20] drm/i915: Prefer crtc_{h|v}display for pipe src dimensions

Now that we ask to adjust the crtc timings for stereo modes, the correct pipe_src_w and pipe_src_h can be found in crtc_vdisplay and crtc_hdisplay. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_display.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a

[PATCH 20/20] drm/i915: Allow stereo modes on HDMI

Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_hdmi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c index f21a57f..0d4403e 100644 --- a/drivers/gpu/drm/i915/intel_hdmi.c +++ b/drivers/gpu/drm/i915

[edid-decode] Finish the list of 3D layouts 3D_Structure_ALL can code for

Signed-off-by: Damien Lespiau --- edid-decode.c | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/edid-decode.c b/edid-decode.c index bf0c3da..d3e3118 100644 --- a/edid-decode.c +++ b/edid-decode.c @@ -829,12 +829,26 @@ cea_hdmi_block(unsigned char *x

Re: [PATCH 17/20] drm/i915: Use adjusted_mode in the fastboot hack to disable pfit

On Fri, Sep 20, 2013 at 05:54:55PM +0300, Ville Syrjälä wrote: > On Thu, Sep 19, 2013 at 05:40:32PM +0100, Damien Lespiau wrote: > > When booting with i915.fastboot=1, we always take tha code path and end > > up undoing what we're trying to do with adjusted_mode. > &

[PATCH] drm: Fix comment referring to the long gone ->probe() connector vfunc

drm_helper_probe_single_connector_modes() can be used to implement ->fill_modes(), not ->probe(). Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_crtc_helper.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/g

Check the fb size against the correct CRTC viewport for stereo modes

I've sent this 2 patches separately from the main stereo series so we can have the usual rounds of review without having to resend the full 20+ patches. Once that last bit has been reviewed as well, I'll send a consolidated series that will be a serious candidate for merging. -- Damien _

[PATCH 1/2] drm: Factor out common CRTC viewport checking code

Both setcrtc and page_flip are checking that the framebuffer is big enough for the defined crtc viewport (x, y, hdisplay, vdisplay). Factor that code out in a single function. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_crtc.c | 70 -- 1

[PATCH 2/2] drm: Check the fb size against the adjusted v/hdisplay for stereo modes

Some stereo modes, like frame packing, need a larger CRTC viewport than the "natural" underlying 2D mode and thus drm_crtc_check_viewport() needs to query the adjusted mode to use the correct h/vdisplay. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_crtc.c | 8 1 fi

[PATCH] drm: Implement timings adjustments for frame packing

tiply the clock by 2 instead of reconstructing it (Ville Syrjälä) Suggested-by: Daniel Vetter Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_modes.c | 22 +- include/drm/drm_crtc.h | 3 ++- 2 files changed, 23 insertions(+), 2 deletions(-) diff --git a/driver

HDMI stereo support v6

v5 was: http://lists.freedesktop.org/archives/dri-devel/2013-September/045576.html Changes from v5: - Added a size check on frame packing fbs - Addressed the various reviews - All the patches now have r-b tags -- Damien ___ dri-devel mailing l

[PATCH 01/22] drm: Move the GET_CAP macros next to the corresponding ioctl structure

gs of DRM_CAP_PRIME. v4: Rebase on top of latest bits (DRM_CAP_ASYNC_PAGE_FLIP was introduced) Reviewed-by: David Herrmann (for v2) Signed-off-by: Damien Lespiau --- include/uapi/drm/drm.h | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/include/uapi/drm/dr

[PATCH 02/22] drm: Add a SET_CLIENT_CAP ioctl

SET_CAP to SET_CLIENT_CAP (Chris Wilson) Reviewed-by: Ville Syrjälä Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_drv.c | 1 + drivers/gpu/drm/drm_ioctl.c | 9 + include/drm/drmP.h | 2 ++ include/uapi/drm/drm.h | 7 +++ 4 files changed, 19 insertions(+) diff

[PATCH 03/22] drm: Add HDMI stereo 3D flags to struct drm_mode_modeinfo

Ville Syrjälä Signed-off-by: Damien Lespiau --- include/drm/drm_crtc.h | 14 ++ include/uapi/drm/drm_mode.h | 36 ++-- 2 files changed, 36 insertions(+), 14 deletions(-) diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index 24f4995..82

[PATCH 04/22] drm: Add a STEREO_3D capability to the SET_CLIENT_CAP ioctl

are regular modes. v3: SET_CAP -> SET_CLIENT_CAP rename (Chris Wilson) Reviewed-by: Ville Syrjälä Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_crtc.c | 19 ++- drivers/gpu/drm/drm_ioctl.c | 14 +- include/drm/drmP.h | 3 +++ include/uapi/drm/dr

[PATCH 05/22] drm/edid: Expose mandatory stereo modes for HDMI sinks

atory structure a bit more compact, fix some white space issues and add a couple of const (Ville Syrjälä) Reviewed-by: Ville Syrjälä Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_edid.c | 110 ++--- 1 file changed, 103 insertions(+), 7 dele

[PATCH 06/22] drm: Extract add_hdmi_mode() out of do_hdmi_vsdb_modes()

So we respect a nice design of having similar functions at the same level, in this case: do_hdmi_vsdb_modes() - add_hdmi_mandatory_stereo_modes() - add_hdmi_mode() Reviewed-by: Ville Syrjälä Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_edid.c | 36

[PATCH 07/22] drm: Reject modes with more than 1 stereo flags set

When setting a stereo 3D mode, there can be only one bit set describing the layout of the frambuffer(s). So reject invalid modes early. Reviewed-by: Ville Syrjälä Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_crtc.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu

[PATCH 09/22] drm: Make drm_match_cea_mode() return the underlying 2D VIC for 3d modes

When scanning out a stereo mode, the AVI infoframe vic field has to be the underlyng 2D VIC. Before that commit, we weren't matching the CEA mode because of the extra stereo flag and then were setting the VIC field in the AVI infoframe to 0. Reviewed-by: Ville Syrjälä Signed-off-by: D

[PATCH 10/22] drm: Carry over the stereo flags when adding the alternate mode

This allows to expose the alternate clock versions of the stereo modes. Reviewed-by: Ville Syrjälä Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_edid.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 48f1746..c24af1d

[PATCH 11/22] drm: Make exposing stereo modes a per-connector opt-in

Just like with interlaced or double scan modes, make stereo modes a per-connector opt-in to give a chance to driver authors to make it work before enabling it. Suggested-by: Daniel Vetter Reviewed-by: Ville Syrjälä Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_crtc_helper.c | 8

[PATCH 12/22] drm: Factor out common CRTC viewport checking code

Both setcrtc and page_flip are checking that the framebuffer is big enough for the defined crtc viewport (x, y, hdisplay, vdisplay). Factor that code out in a single function. Reviewed-by: Ville Syrjälä Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_crtc.c | 70

[PATCH 15/22] drm: Remove synth_clock from struct drm_display_mode

This field is unused. Garbage collect it. Reviewed-by: Ville Syrjälä Signed-off-by: Damien Lespiau --- include/drm/drm_crtc.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index 011baaa..8e9716e 100644 --- a/include/drm/drm_crtc.h +++ b

[PATCH 08/22] drm: Set the relevant infoframe field when scanning out a 3D mode

When scanning out a 3D mode on HDMI, we need to send an HDMI infoframe with the corresponding layout to the sink. v2: Make s3d_structure_from_display_mode() less subtle (Ville Syrjälä) Reviewed-by: Ville Syrjälä Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_edid.c | 40

[PATCH 14/22] drm: Remove clock_index from struct drm_display_mode

This field was only accessed by the nouveau driver, but never set. So concluded we can rid of this one. Acked-by: Ben Skeggs Reviewed-by: Ville Syrjälä Signed-off-by: Damien Lespiau --- drivers/gpu/drm/nouveau/dispnv04/crtc.c | 2 -- include/drm/drm_crtc.h | 1 - 2 files

[PATCH 16/22] drm: Introduce a crtc_clock for struct drm_display_mode

Just like the various timings, make it possible to have a clock field what we can tweak before giving it to hardware. Reviewed-by: Ville Syrjälä Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_modes.c | 1 + include/drm/drm_crtc.h | 1 + 2 files changed, 2 insertions(+) diff --git

[PATCH 13/22] drm: Check the fb size against the adjusted v/hdisplay for stereo modes

Some stereo modes, like frame packing, need a larger CRTC viewport than the "natural" underlying 2D mode and thus drm_crtc_check_viewport() needs to query the adjusted mode to use the correct h/vdisplay. Reviewed-by: Ville Syrjälä Signed-off-by: Damien Lespiau --- drivers/gpu/drm/

[PATCH 17/22] drm: Implement timings adjustments for frame packing

tiply the clock by 2 instead of reconstructing it (Ville Syrjälä) Suggested-by: Daniel Vetter Reviewed-by: Ville Syrjälä Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_modes.c | 22 +- include/drm/drm_crtc.h | 3 ++- 2 files changed, 23 insertions(+), 2 dele

[PATCH 18/22] drm/i915: Use crtc_clock in intel_dump_crtc_timings()

We want to dump the parameters given to the hardware, so let's use crtc_clock here. Reviewed-by: Ville Syrjälä Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_display

<    1   2   3   4   5   6   >