Re: [Nouveau] [PATCH 5/6] drm: Delete "mandatory" stereographic modes

On Wed, Jan 18, 2017 at 12:10:56AM -0500, Ilia Mirkin wrote: > On Tue, Jan 17, 2017 at 5:42 PM, Alastair Bridgewater > wrote: > > HDMI specification 1.4a, table 8-15 is very explicitly a "must > > support at least one of" table, not a "must support all of" table. > > It is not hard to find hardwar

Re: [Nouveau] [PATCH 5/6] drm: Delete "mandatory" stereographic modes

On Wed, Jan 18, 2017 at 04:33:43PM +, Damien Lespiau wrote: > On Wed, Jan 18, 2017 at 11:27:16AM -0500, Ilia Mirkin wrote: > > Damien - did you ever test these mandatory modes on an actual > > commercial 3D TV or similar device? > > My main testing device was a Samsung TV

Re: [Nouveau] [PATCH 5/6] drm: Delete "mandatory" stereographic modes

On Wed, Jan 18, 2017 at 11:27:16AM -0500, Ilia Mirkin wrote: > Damien - did you ever test these mandatory modes on an actual > commercial 3D TV or similar device? My main testing device was a Samsung TV with this 3D_present bit set and all the advertised modes were working. Can't quite remember if

Re: [Nouveau] [PATCH 5/6] drm: Delete "mandatory" stereographic modes

On Wed, Jan 18, 2017 at 01:48:04PM -0500, Ilia Mirkin wrote: > After some more conversations with Alastair, it sounds like what's > actually going on is that it's just the frame-packing modes that > aren't working, but all the side-by-side and top-and-bottom modes from > the "mandatory" list work.

[Intel-gfx] drivers/gpu/drm/i915/i915_gem_gtt.c

On Fri, May 22, 2015 at 02:17:32PM -0700, Andrew Morton wrote: > I'm not sure what's happened to the drm code in linux-next - it's > exploding all over the place. Did someone turn on -Werror without > doing anywhere near enough testing? > > Anyway, I don't know how to fix this i386 build error:

[PATCH libdrm] xf86drm: Bound strstr() to the allocated data

We are reading at most sizeof(data) bytes, but then data may not contain a terminating '\0', at least in theory, so strstr() may overflow the stack allocated array. Make sure that data always contains at least one '\0'. Signed-off-by: Damien Lespiau --- xf86drm.c | 3 ++

[Intel-gfx] [PATCH libdrm] xf86drm: Bound strstr() to the allocated data

On Fri, Jan 22, 2016 at 04:48:05PM +0200, Ville Syrjälä wrote: > On Fri, Jan 22, 2016 at 12:51:23PM +0000, Damien Lespiau wrote: > > We are reading at most sizeof(data) bytes, but then data may not contain > > a terminating '\0', at least in theory, so strstr() m

[PATCH] drm/mst: Avoid reading uninitialized value

A static analysis tool tells me that we could try to read an uninitialized 'ret' value. Plug that. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_dp_mst_topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drive

[PATCH] drm/mst: Don't use uninitialized fields of the sideband message header

We could be using uninitialized fields of the header in drm_dp_encode_sideband_msg_hdr(), for instance hdr->somt is set to 1 in the first patcket but never set to 0 otherwise. Always clear the header at the start then. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_dp_mst_topology.c

[Intel-gfx] [PATCH] drivers/gpu/drm/i915/dma: style fixes

On Mon, Jun 02, 2014 at 04:59:39PM +0200, Robin Schroer wrote: > Fixed several double space pointer notations, and added one newline > > Signed-off-by: Robin Schroer Reviewed-by: Damien Lespiau -- Damien

[PATCH] drm/doc: Add the "type" plane property to the list of properties

Matt aded this plane property before we had a table giving a summary of the properties. Add it there. Cc: Matt Roper Signed-off-by: Damien Lespiau --- Documentation/DocBook/drm.tmpl | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/Documentation/DocBook/drm.tmpl b

[PATCH] drm: Remove spurious ';'

One small step after another, the never-ending crusade towards better code continues. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/ast/ast_post.c | 4 ++-- drivers/gpu/drm/exynos/exynos_dp_core.c | 2 +- drivers/gpu/drm/exynos/exynos_drm_dpi.c

[PATCH 0/3] A couple of fixes about the ioctl number split

It was reported a long time ago the various comments about the DRM/driver specific ioctl split were confusing. So tried to fix that. Patch #1 is a bonus patch that removes DRM_ARRAY_SIZE(). -- Damien Damien Lespiau (3): drm: Remove DRM_ARRAY_SIZE() for ARRAY_SIZE() drm: Driver-specific

[PATCH 2/3] drm: Driver-specific ioctls range from 0x40 to 0x9f

DRM_COMMAND_END is 0xa0, so the last driver ioctl is 0x9f, not 0x99. Signed-off-by: Damien Lespiau --- include/uapi/drm/drm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/drm/drm.h b/include/uapi/drm/drm.h index 9abbeb9..b0b8556 100644 --- a/include/uapi/drm

[PATCH 1/3] drm: Remove DRM_ARRAY_SIZE() for ARRAY_SIZE()

I cannot see a need to provide a DRM_ version of ARRAY_SIZE(), only used in a few places. I suspect its usage has been spread by copy & paste rather than anything else. Let's just remove it for plain ARRAY_SIZE(). Signed-off-by: Damien Lespiau --- drivers/gpu/drm/armada/armada_drv.

[PATCH 3/3] drm/i915: Fix the confusing comment about the ioctl limits

It was reported that this comment was confusing, and indeed it is. Signed-off-by: Damien Lespiau --- include/uapi/drm/i915_drm.h | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/include/uapi/drm/i915_drm.h b/include/uapi/drm/i915_drm.h index ff57f07..eacd063 100644

[PATCH] drm/doc: Fix nouveau typo

Signed-off-by: Damien Lespiau --- Documentation/DocBook/drm.tmpl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/DocBook/drm.tmpl b/Documentation/DocBook/drm.tmpl index efef637..0854aed 100644 --- a/Documentation/DocBook/drm.tmpl +++ b/Documentation/DocBook

[PATCH libdrm 1/2] intel: Sync the command parser version parameter from kernel

Cc: Bradley Volkin Signed-off-by: Damien Lespiau --- include/drm/i915_drm.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/drm/i915_drm.h b/include/drm/i915_drm.h index 2f4eb8c..980dbf8 100644 --- a/include/drm/i915_drm.h +++ b/include/drm/i915_drm.h @@ -337,6 +337,7 @@ typedef

[PATCH libdrm 2/2] intel: Sync typo fix from the kernel sources.

Signed-off-by: Damien Lespiau --- include/drm/i915_drm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/i915_drm.h b/include/drm/i915_drm.h index 980dbf8..8eb0cb3 100644 --- a/include/drm/i915_drm.h +++ b/include/drm/i915_drm.h @@ -722,7 +722,7 @@ struct

[PATCH libdrm 1/2] intel: Sync the command parser version parameter from kernel

On Thu, Jun 19, 2014 at 09:28:08AM -0700, Volkin, Bradley D wrote: > On Thu, Jun 19, 2014 at 11:31:53AM +0100, Damien Lespiau wrote: > > Cc: Bradley Volkin > > Signed-off-by: Damien Lespiau > > Thanks for taking care of this Damien. > > Reviewed-by: Brad Volkin Th

[edid-decode] Decode HDMI 1.4 4k VICs

Signed-off-by: Damien Lespiau --- edid-decode.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/edid-decode.c b/edid-decode.c index 9840db6..f74bbe4 100644 --- a/edid-decode.c +++ b/edid-decode.c @@ -625,7 +625,7 @@ cea_hdmi_block(unsigned char *x

[PATCH] drm: Don't generate invalid AVI infoframes for CEA modes

rry Reding Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_edid.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 95d6f4b..8d1139f 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -3107,6 +310

Re: [PATCH] drm: Don't generate invalid AVI infoframes for CEA modes

On Mon, Aug 05, 2013 at 04:54:06PM +0300, Ville Syrjälä wrote: > On Mon, Aug 05, 2013 at 02:36:47PM +0100, Damien Lespiau wrote: > > >From CEA-861: > > > > Data Byte 1, bit A0 indicates whether Active Format Data is present in > > Data Byte 2 bits R3 through R0.

Re: [PATCH] drm: Don't generate invalid AVI infoframes for CEA modes

On Mon, Aug 05, 2013 at 09:07:05PM +0300, Ville Syrjälä wrote: > On Mon, Aug 05, 2013 at 02:36:47PM +0100, Damien Lespiau wrote: > > >From CEA-861: > > > > Data Byte 1, bit A0 indicates whether Active Format Data is present in > > Data Byte 2 bits R3 through R0.

Port the i915 HDMI infoframe code to the common infrastructure v2

Re-posting the whole series because I forgot dri-devel in the first version and also added a few patches from the review. Version 2 of the series: http://lists.freedesktop.org/archives/intel-gfx/2013-August/031183.html With Ville's comments so far addressed. I've also added the already posted

[PATCH 01/12] video/hdmi: Replace the payload length by their defines

Cc: Thierry Reding Reviewed-by: Ville Syrjälä Signed-off-by: Damien Lespiau --- drivers/video/hdmi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/video/hdmi.c b/drivers/video/hdmi.c index 4017833..dbd882f 100644 --- a/drivers/video/hdmi.c +++ b/drivers

[PATCH 02/12] video/hdmi: Introduce a generic hdmi_infoframe union

And a way to pack hdmi_infoframe generically. Cc: Thierry Reding Reviewed-by: Ville Syrjälä Signed-off-by: Damien Lespiau --- drivers/video/hdmi.c | 43 +++ include/linux/hdmi.h | 17 + 2 files changed, 60 insertions(+) diff --git a

[PATCH 03/12] video/hdmi: Add a macro to return the size of a full infoframe

Cc: Thierry Reding Reviewed-by: Ville Syrjälä Signed-off-by: Damien Lespiau --- include/linux/hdmi.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/linux/hdmi.h b/include/linux/hdmi.h index 0f3f82e..bc6743e 100644 --- a/include/linux/hdmi.h +++ b/include/linux/hdmi.h @@ -23,6

[PATCH 04/12] video/hmdi: Clear the whole incoming buffer, not just the infoframe size

x27;s zero the whole incoming buffer as those extra bytes are also used to compute the ECC and need to be 0. Signed-off-by: Damien Lespiau --- drivers/video/hdmi.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/video/hdmi.c b/drivers/video/hdmi.c index f7

[PATCH 05/12] drm: Don't generate invalid AVI infoframes for CEA modes

Reding Reviewed-by: Ville Syrjälä Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_edid.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 95d6f4b..8d1139f 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c

[PATCH 06/12] drm/i915/hdmi: Change the write_infoframe vfunc to take a buffer and a type

mix signs (Ville Syrjälä) Signed-off-by: Damien Lespiau Signed-off-by: Paulo Zanoni Signed-off-by: Thierry Reding --- drivers/gpu/drm/i915/intel_drv.h | 4 +- drivers/gpu/drm/i915/intel_hdmi.c | 106 -- 2 files changed, 59 insertions(+), 51 deletions(-) di

[PATCH 08/12] drm/i915/sdvo: Port the infoframe code to the shared infrastructure

Reviewed-by: Ville Syrjälä Signed-off-by: Damien Lespiau Signed-off-by: Paulo Zanoni Signed-off-by: Thierry Reding --- drivers/gpu/drm/i915/intel_sdvo.c | 38 -- 1 file changed, 20 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/i915

[PATCH 11/12] drm: Set aspect ratio fields in the AVI infoframe even for non CEA modes

I cannot find any evidence what we shouldn't try to set those fields when setting a non-CEA mode on an HDMI sink. So just kill that return. Suggested-by: Ville Syrjälä Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_edid.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/driver

[PATCH 07/12] drm/i915/hdmi: Port the infoframe code to the common hdmi helpers

Ville Syrjälä) Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_hdmi.c | 82 +++ 1 file changed, 58 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c index ee67e23..455dfa7 100644

[PATCH 12/12] drm/i915/hmdi: Rename set_infoframe() to write_infoframe()

set_frame() wraps the write_frame() vfunc. Be consistent and name the wrapping function like the vfunc being called. It's doubly confusing as we also have a set_infoframes() vfunc and set_infoframe() doesn't wrap it. Reviewed-by: Ville Syrjälä Signed-off-by: Damien Lespiau --- drive

[PATCH 09/12] drm/i915: Remove the now obsolete infoframe definitions

All the HDMI infoframe code has been ported to use video/hdmi.c, so it's time to say bye bye to this code. Reviewed-by: Ville Syrjälä Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_drv.h | 61 --- drivers/gpu/drm/i915/intel_hdmi.c

[PATCH 10/12] drm: Handle the DBLCLK flag in the common infoframe helper

Suggested-by: Ville Syrjälä Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_edid.c| 3 +++ drivers/gpu/drm/i915/intel_hdmi.c | 3 --- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 8d1139f..a9c8980

Re: [Intel-gfx] [PATCH 04/12] video/hmdi: Clear the whole incoming buffer, not just the infoframe size

On Wed, Aug 07, 2013 at 01:56:58PM +0300, Ville Syrjälä wrote: > On Tue, Aug 06, 2013 at 08:32:16PM +0100, Damien Lespiau wrote: > > If the user if this API is providing a bigger buffer than the infoframe > > size, it could be for a could reason. For instance it could be because &

Some edid-decode patches

A bit more context than the previous patch that was a bit alone. This series parses yet a bit more of the EDID: - The HDMI VICs in the HDMI vendor specific block (HDMI 1.4, 4k modes) - The CEA Video Capability Data Block It also includes 2 EDIDs of TVs that have those bits. -- Damien __

[edid-decode 1/7] Print the resolutions next to the CEA VICs

Signed-off-by: Damien Lespiau --- edid-decode.c | 84 +-- 1 file changed, 82 insertions(+), 2 deletions(-) diff --git a/edid-decode.c b/edid-decode.c index 9840db6..7515181 100644 --- a/edid-decode.c +++ b/edid-decode.c @@ -32,6 +32,8

[edid-decode 2/7] Add Skyworth 50E780U 50" edid (4k TV)

Signed-off-by: Damien Lespiau --- data/skyworth-50e780u-hdmi | Bin 0 -> 256 bytes 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 data/skyworth-50e780u-hdmi diff --git a/data/skyworth-50e780u-hdmi b/data/skyworth-50e780u-hdmi new file mode 100644 in

[edid-decode 3/7] Decode HDMI 1.4 4k VICs

Signed-off-by: Damien Lespiau --- edid-decode.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/edid-decode.c b/edid-decode.c index 7515181..55e48a7 100644 --- a/edid-decode.c +++ b/edid-decode.c @@ -705,7 +705,7 @@ cea_hdmi_block(unsigned char *x

[edid-decode 4/7] Print the HDMI resolution next to the HDMI VICs

Signed-off-by: Damien Lespiau --- edid-decode.c | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/edid-decode.c b/edid-decode.c index 55e48a7..5061228 100644 --- a/edid-decode.c +++ b/edid-decode.c @@ -659,6 +659,13 @@ cea_video_block(unsigned char *x

[edid-decode 5/7] Add the EDID of a Samsung TV that has a VCDB

--- data/samsung-UE40D8000YU-hmdi | Bin 0 -> 256 bytes 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 data/samsung-UE40D8000YU-hmdi diff --git a/data/samsung-UE40D8000YU-hmdi b/data/samsung-UE40D8000YU-hmdi new file mode 100644 index

[edid-decode 6/7] Add a small framework to decode fields generically

Signed-off-by: Damien Lespiau --- edid-decode.c | 69 +-- 1 file changed, 67 insertions(+), 2 deletions(-) diff --git a/edid-decode.c b/edid-decode.c index 5061228..7aed3c6 100644 --- a/edid-decode.c +++ b/edid-decode.c @@ -32,8 +32,6

[edid-decode 7/7] Decode the Video Capability Data Block

Signed-off-by: Damien Lespiau --- edid-decode.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/edid-decode.c b/edid-decode.c index 7aed3c6..58297c9 100644 --- a/edid-decode.c +++ b/edid-decode.c @@ -861,6 +861,44 @@ cea_hdmi_block(unsigned char *x

[edid-decode] Add a small framework to decode fields generically

v2: Fix rebase fail that removed a necessary hunk Signed-off-by: Damien Lespiau --- edid-decode.c | 67 +++ 1 file changed, 67 insertions(+) diff --git a/edid-decode.c b/edid-decode.c index 5061228..083ddd9 100644 --- a/edid-decode.c

HDMI 4k support

(and in 2.21.14) Author: Damien Lespiau Date: Wed Jul 31 18:50:51 2013 +0100 uxa/display: Keep the EDID blob around for the lifetime of an output * My "Use the TMDS maximum frequency to check mode dot clock" xserver series: http://lists.x.org/archiv

[PATCH 1/2] drm/edid: Fix add_cea_modes() style issues

A few styles issues have creept in here, fix them before touching this code again. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_edid.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 95d6f4b

[PATCH 2/2] drm/edid: Parse the HDMI CEA block and look for 4k modes

HDMI 1.4 adds 4 "4k x 2k" modes in the the CEA vendor specific block. With this commit, we now parse this block and expose the 4k modes that we find there. Signed-off-by: Damien Lespiau Tested-by: Cancan Feng Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=67030 --- drive

HDMI 4k support v2

Following up the first instance of this series: http://lists.freedesktop.org/archives/dri-devel/2013-August/043125.html Here is a v2 with Ville's review pass and a few additions: - Alternate clock modes for 4k resolutions - HDMI vendor specific infoframe support in drivers/video/hdmi.c - E

[PATCH 01/12] drm: Don't export drm_find_cea_extension() any more

This function is only used inside drm_edid.c. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_edid.c | 5 ++--- include/drm/drm_crtc.h | 1 - 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index dfc7a1b..e014785

[PATCH 02/12] drm/edid: Fix add_cea_modes() style issues

A few styles issues have crept in here, fix them before touching this code again. v2: constify arguments that can be (Ville Syrjälä) Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_edid.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 03/12] drm/edid: Parse the HDMI CEA block and look for 4k modes

earer that offset is relative to the end of the required fields of the HDMI VSDB (Ville Syrjälä) Signed-off-by: Damien Lespiau Tested-by: Cancan Feng Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=67030 --- drivers/gpu/drm/drm_edid.c | 124 +++--

[PATCH 04/12] drm: Add support for alternate clocks of 4k modes

Suggested-by: Ville Syrjälä Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_edid.c | 68 ++ 1 file changed, 62 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 0faa08e..606335f 100644

[PATCH 05/12] video/hdmi: Don't let the user of this API create invalid infoframes

To set the active aspect ratio value in the AVI infoframe today, you not only have to set the active_aspect field, but also the active_info_valid bit. Out of the 1 user of this API, we had 100% misuse, forgetting the _valid bit. This was fixed in: Author: Damien Lespiau Date: Tue Aug 6 20

[PATCH 06/12] video/hdmi: Derive the bar data valid bit from the bar data fields

Just like: Author: Damien Lespiau Date: Mon Aug 12 11:53:24 2013 +0100 video/hdmi: Don't let the user of this API create invalid infoframes But this time for the horizontal/vertical bar data present bits. Signed-off-by: Damien Lespiau --- drivers/video/hdmi.c | 5 +++-- in

[PATCH 07/12] video/hdmi: Introduce helpers for the HDMI vendor specific infoframe

Provide the programming model than the other infoframe types. The generic _pack() function can't handle those yet as we need to move the vendor OUI in the generic hdmi_vendor_infoframe structure to know which kind of vendor infoframe we are dealing with. Signed-off-by: Damien Le

[PATCH 08/12] gpu: host1x: Port the HDMI vendor infoframe code the common helpers

I just wrote the bits to define and pack HDMI vendor specific infoframe. Port the host1x driver to use those so I can refactor the infoframe code a bit more. Cc: Thierry Reding Cc: Terje Bergström Cc: linux-te...@vger.kernel.org Signed-off-by: Damien Lespiau --- drivers/gpu/host1x/drm/hdmi.c

[PATCH 09/12] drm/edid: Move HDMI_IDENTIFIER to hdmi.h

HDMI, but details..) Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_edid.c | 1 - include/linux/hdmi.h | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index ec47eb8..9a07a33 100644 --- a/drivers/gpu/drm/drm_ed

[PATCH 10/12] video/hdmi: Hook the HDMI vendor infoframe with the generic _pack()

this API has been ported in: Author: Damien Lespiau Date: Mon Aug 12 18:08:37 2013 +0100 gpu: host1x: Port the HDMI vendor infoframe code the common helpers Signed-off-by: Damien Lespiau --- drivers/video/hdmi.c | 45 + include/linux/h

[PATCH 11/12] drm: Add a helper to forge HDMI vendor infoframes

This can then be used by DRM drivers to setup their vendor infoframes. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_edid.c | 36 include/drm/drm_edid.h | 4 2 files changed, 40 insertions(+) diff --git a/drivers/gpu/drm/drm_edid.c b

[PATCH 12/12] drm/i915/hdmi: Write HDMI vendor specific infoframes

With all the common infoframe bits now in place, we can finally write the vendor specific infoframes in our driver. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_reg.h | 2 ++ drivers/gpu/drm/i915/intel_hdmi.c | 28 2 files changed, 30 insertions

HDMI 4k support v3

Follow up on v2: http://lists.freedesktop.org/archives/dri-devel/2013-August/043604.html With the quick and nice reviews from Ville and Simon, it's time for a v3: - Fix embarrassing hmdi typo - Fix the sending of vendor specific infoframes for side-by-side half modes - Smaller changes here

[PATCH 01/12] drm: Don't export drm_find_cea_extension() any more

This function is only used inside drm_edid.c. Signed-off-by: Damien Lespiau Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/drm_edid.c | 5 ++--- include/drm/drm_crtc.h | 1 - 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm

[PATCH 02/12] drm/edid: Fix add_cea_modes() style issues

A few styles issues have crept in here, fix them before touching this code again. v2: constify arguments that can be (Ville Syrjälä) v3: constify, but better (Ville Syrjälä) Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_edid.c | 12 +++- 1 file changed, 7 insertions(+), 5

[PATCH 03/12] drm/edid: Parse the HDMI CEA block and look for 4k modes

earer that offset is relative to the end of the required fields of the HDMI VSDB (Ville Syrjälä) v3: Fix 'Unknow' typo (Simon Farnsworth) Signed-off-by: Damien Lespiau Tested-by: Cancan Feng Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=67030 Reviewed-by: Simon Farnsworth -

[PATCH 04/12] drm: Add support for alternate clocks of 4k modes

v2: Fix hmdi typo (Simon Farnsworth, Ville Syrjälä) Suggested-by: Ville Syrjälä Signed-off-by: Damien Lespiau Reviewed-by: Ville Syrjälä Reviewed-by: Simon Farnsworth --- drivers/gpu/drm/drm_edid.c | 68 ++ 1 file changed, 62 insertions(+), 6

[PATCH 05/12] video/hdmi: Don't let the user of this API create invalid infoframes

To set the active aspect ratio value in the AVI infoframe today, you not only have to set the active_aspect field, but also the active_info_valid bit. Out of the 1 user of this API, we had 100% misuse, forgetting the _valid bit. This was fixed in: Author: Damien Lespiau Date: Tue Aug 6 20

[PATCH 06/12] video/hdmi: Derive the bar data valid bit from the bar data fields

Just like: Author: Damien Lespiau Date: Mon Aug 12 11:53:24 2013 +0100 video/hdmi: Don't let the user of this API create invalid infoframes But this time for the horizontal/vertical bar data present bits. Signed-off-by: Damien Lespiau Reviewed-by: Ville Syrjälä --- dr

[PATCH 08/12] gpu: host1x: Port the HDMI vendor infoframe code the common helpers

imp up the commit message with the note about the length (Ville Syrjälä) Cc: Thierry Reding Cc: Terje Bergström Cc: linux-te...@vger.kernel.org Signed-off-by: Damien Lespiau --- drivers/gpu/host1x/drm/hdmi.c | 24 1 file changed, 4 insertions(+), 20 deletions(-) di

[PATCH 07/12] video/hdmi: Introduce helpers for the HDMI vendor specific infoframe

-side (half), hmdi typo, pack 3D_Ext_Data (Ville Syrjälä) Signed-off-by: Damien Lespiau --- drivers/video/hdmi.c | 88 include/linux/hdmi.h | 26 2 files changed, 114 insertions(+) diff --git a/drivers/video/hdmi.c b/drivers/

[PATCH 10/12] video/hdmi: Hook the HDMI vendor infoframe with the generic _pack()

this API has been ported in: Author: Damien Lespiau Date: Mon Aug 12 18:08:37 2013 +0100 gpu: host1x: Port the HDMI vendor infoframe code the common helpers v2: Change oui to be an unsigned int (Ville Syrjälä) Signed-off-by: Damien Lespiau Reviewed-by: Ville Syrjälä --- drivers/

[PATCH 09/12] drm/edid: Move HDMI_IDENTIFIER to hdmi.h

HDMI, but details..) Signed-off-by: Damien Lespiau Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/drm_edid.c | 1 - include/linux/hdmi.h | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index d76d608..3aa653f 100644 ---

[PATCH 11/12] drm: Add a helper to forge HDMI vendor infoframes

This can then be used by DRM drivers to setup their vendor infoframes. v2: Fix hmdi typo (Simon Farnsworth) Signed-off-by: Damien Lespiau Reviewed-by: Simon Farnsworth Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/drm_edid.c | 36 include/drm/drm_edid.h

[PATCH 12/12] drm/i915/hdmi: Write HDMI vendor specific infoframes

With all the common infoframe bits now in place, we can finally write the vendor specific infoframes in our driver. Signed-off-by: Damien Lespiau Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_reg.h | 2 ++ drivers/gpu/drm/i915/intel_hdmi.c | 28 2

Re: [Intel-gfx] [PATCH] i915: Add a Kconfig option to turn on i915.preliminary_hw_support by default

something similar in mind for this on other little parameters/debug features). Reviewed-by: Damien Lespiau It doesn't apply cleanly to drm-intel/drm-intel-nightly which is the preferred branch to base patches on. Daniel might fix this himself as this is rather trivial to solve. -- Damien &

Re: [PATCH 09/12] drm/edid: Move HDMI_IDENTIFIER to hdmi.h

On Thu, Aug 15, 2013 at 05:12:00PM +0200, Thierry Reding wrote: > On Wed, Aug 14, 2013 at 06:19:12PM +0100, Damien Lespiau wrote: > [...] > > +#define HDMI_IDENTIFIER 0x000c03 > > HDMI_IDENTIFIER sounds really generic. Perhaps HDMI_INFOFRAME_OUI_HDMI? This identifier is not

HDMI 4k support v4

Follow up on v3: http://lists.freedesktop.org/archives/dri-devel/2013-August/043696.html Changes between v3 and v4: - Future proof the sending of 3D_Ext_Data - Renamed struct hdmi_hdmi_infoframe to hdmi_vendor_infoframe (by, in turn, renaming the hdmi_vendor_infoframe enum to hdmi_vendor

[PATCH 01/14] drm: Don't export drm_find_cea_extension() any more

This function is only used inside drm_edid.c. Signed-off-by: Damien Lespiau Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/drm_edid.c | 5 ++--- include/drm/drm_crtc.h | 1 - 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm

[PATCH 02/14] drm/edid: Fix add_cea_modes() style issues

A few styles issues have crept in here, fix them before touching this code again. v2: constify arguments that can be (Ville Syrjälä) v3: constify, but better (Ville Syrjälä) Signed-off-by: Damien Lespiau Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/drm_edid.c | 12 +++- 1 file

[PATCH 03/14] drm/edid: Parse the HDMI CEA block and look for 4k modes

earer that offset is relative to the end of the required fields of the HDMI VSDB (Ville Syrjälä) v3: Fix 'Unknow' typo (Simon Farnsworth) Signed-off-by: Damien Lespiau Tested-by: Cancan Feng Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=67030 Reviewed-by: Simon Farnswor

[PATCH 04/14] drm: Add support for alternate clocks of 4k modes

v2: Fix hmdi typo (Simon Farnsworth, Ville Syrjälä) Suggested-by: Ville Syrjälä Signed-off-by: Damien Lespiau Reviewed-by: Ville Syrjälä Reviewed-by: Simon Farnsworth --- drivers/gpu/drm/drm_edid.c | 68 ++ 1 file changed, 62 insertions(+), 6

[PATCH 05/14] video/hdmi: Don't let the user of this API create invalid infoframes

To set the active aspect ratio value in the AVI infoframe today, you not only have to set the active_aspect field, but also the active_info_valid bit. Out of the 1 user of this API, we had 100% misuse, forgetting the _valid bit. This was fixed in: Author: Damien Lespiau Date: Tue Aug 6 20

[PATCH 06/14] video/hdmi: Derive the bar data valid bit from the bar data fields

Just like: Author: Damien Lespiau Date: Mon Aug 12 11:53:24 2013 +0100 video/hdmi: Don't let the user of this API create invalid infoframes But this time for the horizontal/vertical bar data present bits. Signed-off-by: Damien Lespiau Reviewed-by: Ville Syrjälä --- dr

[PATCH 07/14] video/hdmi: Introduce helpers for the HDMI vendor specific infoframe

-side (half), hmdi typo, pack 3D_Ext_Data (Ville Syrjälä) v3: Future proof the sending of 3D_Ext_Data (Ville Syrjälä), Fix multi-lines comment style (Thierry Reding) Signed-off-by: Damien Lespiau Reviewed-by: Ville Syrjälä --- drivers/video/hdmi.c

[PATCH 08/14] gpu: host1x: Port the HDMI vendor infoframe code the common helpers

imp up the commit message with the note about the length (Ville Syrjälä) Cc: Thierry Reding Cc: Terje Bergström Cc: linux-te...@vger.kernel.org Signed-off-by: Damien Lespiau --- drivers/gpu/host1x/drm/hdmi.c | 24 1 file changed, 4 insertions(+), 20 deletions(-) di

[PATCH 10/14] video/hdmi: Hook the HDMI vendor infoframe with the generic _pack()

this API has been ported in: Author: Damien Lespiau Date: Mon Aug 12 18:08:37 2013 +0100 gpu: host1x: Port the HDMI vendor infoframe code the common helpers v2: Change oui to be an unsigned int (Ville Syrjälä) Signed-off-by: Damien Lespiau Reviewed-by: Ville Syrjälä --- drivers/

[PATCH 09/14] drm/edid: Move HDMI_IDENTIFIER to hdmi.h

HDMI, but details..) Signed-off-by: Damien Lespiau Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/drm_edid.c | 1 - include/linux/hdmi.h | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index d76d608..3aa653f 100644 ---

[PATCH 11/14] video/hdmi: Use hdmi_vendor_infoframe for the HDMI specific infoframe

We just got rid of the version of hdmi_vendor_infoframe that had a byte array for anyone to poke at. It's now time to shuffle around the naming of hdmi_hdmi_infoframe to make hdmi_vendor_infoframe become the HDMI vendor specific structure. Cc: Thierry Reding Signed-off-by: Damien Le

[PATCH 12/14] drm: Add a helper to forge HDMI vendor infoframes

This can then be used by DRM drivers to setup their vendor infoframes. v2: Fix hmdi typo (Simon Farnsworth) v3: Adapt to the hdmi_vendor_infoframe rename Signed-off-by: Damien Lespiau Reviewed-by: Simon Farnsworth Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/drm_edid.c | 36

[PATCH 13/14] drm/i915/hdmi: Write HDMI vendor specific infoframes

With all the common infoframe bits now in place, we can finally write the vendor specific infoframes in our driver. Signed-off-by: Damien Lespiau Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_reg.h | 2 ++ drivers/gpu/drm/i915/intel_hdmi.c | 28 2

[PATCH 14/14] video/hdmi: Rename HDMI_IDENTIFIER to HDMI_IEEE_OUI

HDMI_IDENTIFIER was felt too generic, rename it to what it is, the IEEE OUI corresponding to HDMI Licensing, LLC. http://standards.ieee.org/develop/regauth/oui/oui.txt Cc: Thierry Reding Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_edid.c | 2 +- drivers/video/hdmi.c | 4

Re: [PATCH 06/12] video/hdmi: Derive the bar data valid bit from the bar data fields

On Thu, Aug 15, 2013 at 04:45:56PM +0200, Thierry Reding wrote: > On Wed, Aug 14, 2013 at 06:19:09PM +0100, Damien Lespiau wrote: > > Just like: > > > > Author: Damien Lespiau > > Date: Mon Aug 12 11:53:24 2013 +0100 > > > > video/hdmi: Don&#x

A gentle scrub

A small pass on drm headers to remove some stale prototypes/functions/defines and to make static a few functions. drivers/gpu/drm/drm_crtc.c | 38 +++-- drivers/gpu/drm/drm_fb_cma_helper.c | 5 ++--- drivers/gpu/drm/drm_modes.c | 21 --

[PATCH 1/8] drm: Remove stale prototypes

A few prototypes have been left in the headers, their function friends long gone. Signed-off-by: Damien Lespiau --- include/drm/drmP.h | 5 - include/drm/drm_crtc.h | 11 --- 2 files changed, 16 deletions(-) diff --git a/include/drm/drmP.h b/include/drm/drmP.h index 39911dc

[PATCH 2/8] drm: Remove drm_mode_create_dithering_property()

This was last used by nouveau, replaced by a driver-specific property in: commit de69185573586302ada2e59ba41835df36986277 Author: Ben Skeggs Date: Mon Oct 17 12:23:41 2011 +1000 drm/nouveau: improve dithering properties, and implement proper auto mode Signed-off-by: Damien

[PATCH 4/8] drm: Make drm_mode_remove() static

It's only used in drm_crtc.c. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_crtc.c | 7 +++ include/drm/drm_crtc.h | 1 - 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index ffb791f..54b4169 100644

[PATCH 3/8] drm: Remove drm_mode_list_concat()

code adding modes. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_modes.c | 21 - include/drm/drm_crtc.h | 2 -- 2 files changed, 23 deletions(-) diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c index 504a602..fc2adb6 100644 --- a/drivers/gpu

[PATCH 5/8] drm: Remove 2 unused defines

These were introduced in the very first DRM commit: commit f453ba0460742ad027ae0c4c7d61e62817b3e7ef Author: Dave Airlie Date: Fri Nov 7 14:05:41 2008 -0800 DRM: add mode setting support Add mode setting support to the DRM layer. But are unused. Signed-off-by: Damien

  1   2   3   4   5   6   >