On Tue, Jul 20 2021, Jason Gunthorpe wrote:
> Compared to mbochs_remove() two cases are missing from the
> vfio_register_group_dev() unwind. Add them in.
>
> Fixes: 681c1615f891 ("vfio/mbochs: Convert to use vfio_register_group_dev()")
> Reported-by: Cornelia Huc
On Tue, Jul 20 2021, Jason Gunthorpe wrote:
> On Tue, Jul 20, 2021 at 04:01:27PM -0600, Alex Williamson wrote:
>> Hmm, doesn't this suggest we need another atomic conversion? (untested)
>
> Sure why not, I can add this as another patch
Yes, I think that should be another patch.
ples/vfio-mdev/mbochs.c | 2 ++
> samples/vfio-mdev/mdpy.c | 25 ++
> samples/vfio-mdev/mtty.c | 27
> 10 files changed, 64 insertions(+), 33 deletions(-)
Reviewed-by: Cornelia Huck
46 +-
> include/linux/mdev.h | 2 +
> include/linux/vfio.h | 19 +
> 4 files changed, 167 insertions(+), 22 deletions(-)
Reviewed-by: Cornelia Huck
ned-off-by: Yishai Hadas
> Signed-off-by: Jason Gunthorpe
> ---
> drivers/vfio/platform/vfio_platform_common.c | 79 ---
> drivers/vfio/platform/vfio_platform_private.h | 1 -
> 2 files changed, 32 insertions(+), 48 deletions(-)
Reviewed-by: Cornelia Huck
This also fixes the dependencies for vfio-ccw, which never depended on
VFIO_MDEV_DEVICE directly...
Reviewed-by: Cornelia Huck
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
81c1615f891 ("vfio/mbochs: Convert to use vfio_register_group_dev()")
> Reported-by: Cornelia Huck
> Co-developed-by: Alex Williamson
> Reviewed-by: Christoph Hellwig
> Signed-off-by: Jason Gunthorpe
> ---
> samples/vfio-mdev/mbochs.c | 24 +++-
&g
y: Yishai Hadas
> Reviewed-by: Christoph Hellwig
> Signed-off-by: Jason Gunthorpe
> ---
> drivers/vfio/pci/vfio_pci.c | 162 +++-
> drivers/vfio/pci/vfio_pci_private.h | 7 --
> 2 files changed, 37 insertions(+), 132 deletions(-)
Reviewed-by: Cornelia Huck
evice_lock() and removes a hard wiring to &vfio_pci_driver.
>
> Signed-off-by: Jason Gunthorpe
> ---
> drivers/vfio/pci/vfio_pci.c | 182 +++++---
> 1 file changed, 86 insertions(+), 96 deletions(-)
Reviewed-by: Cornelia Huck
> This eliminates a memory allocation and get/put traffic and another
> improperly locked test of pci_dev_driver().
>
> Reviewed-off-by: Christoph Hellwig
> Signed-off-by: Jason Gunthorpe
> ---
> drivers/vfio/pci/vfio_pci.c | 213 +++-----
> 1 file changed, 89 insertions(+), 124 deletions(-)
Reviewed-by: Cornelia Huck
io/vfio.c | 14 +-
> include/linux/mdev.h | 7 ---
> include/linux/vfio.h | 4
> 4 files changed, 1 insertion(+), 46 deletions(-)
Reviewed-by: Cornelia Huck
amples/vfio-mdev/mbochs.c| 2 +-
> samples/vfio-mdev/mdpy.c | 2 +-
> samples/vfio-mdev/mtty.c | 2 +-
> 8 files changed, 8 insertions(+), 9 deletions(-)
Reviewed-by: Cornelia Huck
___
dri-devel mailing list
dri-devel@lists.
vfio/mdev/mdev_sysfs.c| 11 ++-
> include/linux/mdev.h | 11 +++
> samples/vfio-mdev/mbochs.c| 26 +++---
> samples/vfio-mdev/mdpy.c | 24 ++++++--
> samples/vfio-mdev/mtty.c | 18 +-
> 9
On Tue, 4 May 2021 15:00:39 +0200
Christoph Hellwig wrote:
> On Tue, May 04, 2021 at 02:59:07PM +0200, Greg Kroah-Hartman wrote:
> > > Hi Christoph,
> > >
> > > FYI, these uapi changes break build of QEMU.
> >
> > What uapi changes?
> >
> > What exactly breaks?
> >
> > Why does QEMU require
c01 ("vfio/mdpy: Convert to use vfio_register_group_dev()")
> Fixes: 681c1615f891 ("vfio/mbochs: Convert to use vfio_register_group_dev()")
> Signed-off-by: Jason Gunthorpe
> ---
> samples/vfio-mdev/mbochs.c | 4
> samples/vfio-mdev/mdpy.c | 4
> 2
On Wed, Jul 14 2021, Jason Gunthorpe wrote:
> From: Max Gurtovoy
>
> This pairs with vfio_init_group_dev() and allows undoing any state that is
> stored in the vfio_device unrelated to registration. Add appropriately
> placed calls to all the drivers.
>
> The following patch will use this to add
On Mon, Jul 19 2021, Jason Gunthorpe wrote:
> On Mon, Jul 19, 2021 at 02:11:38PM +0200, Cornelia Huck wrote:
>> On Wed, Jul 14 2021, Jason Gunthorpe wrote:
>>
>> > From: Max Gurtovoy
>> >
>> > This pairs with vfio_init_group_dev() and allows un
On Wed, Jul 14 2021, Jason Gunthorpe wrote:
> Currently the driver ops have an open/release pair that is called once
> each time a device FD is opened or closed. Add an additional set of
> open/close_device() ops which are called when the device FD is opened for
> the first time and closed for th
t; Signed-off-by: Jason Gunthorpe
> ---
> samples/vfio-mdev/mbochs.c | 6 --
> samples/vfio-mdev/mdpy.c | 11 ---
> samples/vfio-mdev/mtty.c | 13 -
> 3 files changed, 30 deletions(-)
Reviewed-by: Cornelia Huck
drivers/s390/crypto/vfio_ap_ops.c | 8
> 2 files changed, 8 insertions(+), 8 deletions(-)
Reviewed-by: Cornelia Huck
_device() so it only runs on the last close.
>
> Signed-off-by: Jason Gunthorpe
> ---
> samples/vfio-mdev/mbochs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Cornelia Huck
ertions(+), 4 deletions(-)
Reviewed-by: Cornelia Huck
On Fri, Sep 10 2021, Christoph Hellwig wrote:
> On Thu, Sep 09, 2021 at 04:38:41PM -0300, Jason Gunthorpe wrote:
>> +
>> +private = kzalloc(sizeof(*private), GFP_KERNEL | GFP_DMA);
>> +if (!private)
>> +return ERR_PTR(-ENOMEM);
>
> Nit: there is no need to add GFP_KERNEL when
On Tue, Sep 14 2021, Jason Gunthorpe wrote:
> On Mon, Sep 13, 2021 at 04:31:54PM -0400, Eric Farman wrote:
>> > I rebased it and fixed it up here:
>> >
>> > https://github.com/jgunthorpe/linux/tree/vfio_ccw
>> >
>> > Can you try again?
>>
>> That does address the crash, but then why is it proc
On Fri, Sep 17 2021, Jason Gunthorpe wrote:
> On Fri, Sep 17, 2021 at 01:59:16PM +0200, Cornelia Huck wrote:
>> >ret = cio_cancel_halt_clear(sch, &iretry);
>> > -
>> >if (ret == -EIO) {
>> >pr_err("vfio_c
gt; drivers/s390/cio/vfio_ccw_ops.c | 37 +
> 1 file changed, 15 insertions(+), 22 deletions(-)
Reviewed-by: Cornelia Huck
On Thu, Sep 09 2021, Jason Gunthorpe wrote:
> The subchannel should be left in a quiescent state unless the VFIO device
> FD is opened. When the FD is opened bring the chanel to active and allow
> the VFIO device to operate. When the device FD is closed then quiesce the
> channel.
>
> To make thi
On Thu, Sep 09 2021, Jason Gunthorpe wrote:
> Many of the mdev drivers use a simple counter for keeping track of the
> available instances. Move this code to the core code and store the counter
> in the mdev_type. Implement it using correct locking, fixing mdpy.
>
> Drivers provide a get_availabl
Hi Gerd,
flipping the virtio-gpu edid support in QEMU to default enabled exposed
the following backtrace in my guest (from my bisect run down to the
initial commit in Linux):
[drm] virgl 3d acceleration not supported by guest
[drm] EDID support available.
[drm] number of scanouts: 1
[drm] number
pin_unlock(&vgdev->display_info_lock);
>
> kfree(old_edid);
This gets rid of the sleeping while atomic traces I've been seeing with
an s390x guest (both virtio-gpu-pci and virtio-gpu-ccw).
Tested-by: Cornelia Huck
I have also looked at the code a bit, but don't fee
On Wed, 26 Jun 2019 02:00:46 +0200
Gerd Hoffmann wrote:
> On Tue, Jun 25, 2019 at 05:15:41PM +0200, Cornelia Huck wrote:
> > Hi Gerd,
> >
> > flipping the virtio-gpu edid support in QEMU to default enabled exposed
> > the following backtrace in my guest (fro
o/mdev/Kconfig | 2 +-
Reviewed-by: Cornelia Huck [vfio-related parts]
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Tue, Jul 19 2022, Jason Gunthorpe wrote:
> On Thu, Jul 07, 2022 at 03:37:16PM -0600, Alex Williamson wrote:
>> On Mon, 4 Jul 2022 21:59:03 -0300
>> Jason Gunthorpe wrote:
>> > diff --git a/drivers/s390/cio/vfio_ccw_ops.c
>> > b/drivers/s390/cio/vfio_ccw_ops.c
>> > index b49e2e9db2dc6f..09e0
d_devicetable.h | 8 ++
> samples/vfio-mdev/mbochs.c| 1 +
> samples/vfio-mdev/mdpy.c | 1 +
> samples/vfio-mdev/mtty.c | 1 +
> 13 files changed, 76 insertions(+)
Reviewed-by: Cornelia Huck
_
le2alias.c | 11 +++
> 3 files changed, 16 insertions(+)
Reviewed-by: Cornelia Huck
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Tue, 5 Nov 2019 17:32:37 +0800
Jason Wang wrote:
> Currently, except for the create and remove, the rest of
> mdev_parent_ops is designed for vfio-mdev driver only and may not help
> for kernel mdev driver. With the help of class id, this patch
> introduces device specific callbacks inside md
/mdev_private.h | 2 +
> include/linux/mdev.h | 6 ++
> include/linux/mdev_virtio_ops.h | 149 +++
> 4 files changed, 178 insertions(+)
> create mode 100644 include/linux/mdev_virtio_ops.h
Reviewed-by: Cornelia Huck
On Tue, 5 Nov 2019 10:44:18 -0700
Alex Williamson wrote:
> On Tue, 5 Nov 2019 17:50:25 +0100
> Cornelia Huck wrote:
>
> > On Tue, 5 Nov 2019 17:32:37 +0800
> > Jason Wang wrote:
> >
> > > Currently, except for the create and remove, the rest of
> &
ops now.
>
> Signed-off-by: Jason Wang
> ---
> drivers/virtio/Kconfig | 7 +
> drivers/virtio/Makefile | 1 +
> drivers/virtio/virtio_mdev.c | 407 +++
> 3 files changed, 415 insertions(+)
> create mode 100644 drive
et.c
Have not really reviewed this, but looks sane at a glance.
Acked-by: Cornelia Huck
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
v/mbochs.c| 20 ---
> samples/vfio-mdev/mdpy.c | 20 ---
> samples/vfio-mdev/mtty.c | 18 ---
> 13 files changed, 206 insertions(+), 99 deletions(-)
> create mode 100644 include/linux/mdev_vfio_ops.h
Reviewed-by
/mdev_core.c| 21 +
> drivers/vfio/mdev/mdev_private.h | 2 +
> include/linux/mdev.h | 6 ++
> include/linux/mdev_virtio_ops.h | 147 +++
> 5 files changed, 177 insertions(+)
> create mode 100644 include/linux/mdev_virt
appropriate virtio mdev device
implementation that operates on a physical device to allow the datapath
of virtio to be offloaded to hardware."
?
> +
> + If unsure, say M
Building this as a module should not hurt (but please add a trailing
'.' here :)
&g
On Wed, 6 Nov 2019 21:35:25 +0800
Jason Wang wrote:
> Hi all:
>
> There are hardwares that can do virtio datapath offloading while
> having its own control path. This path tries to implement a mdev based
> unified API to support using kernel virtio driver to drive those
> devices. This is done
ng
> ---
> MAINTAINERS| 1 +
> samples/Kconfig| 10 +
> samples/vfio-mdev/Makefile | 1 +
> samples/vfio-mdev/mvnet_loopback.c | 687 +
> 4 files changed, 699 insertions(+)
> crea
v/mbochs.c| 20 ---
> samples/vfio-mdev/mdpy.c | 20 ---
> samples/vfio-mdev/mtty.c | 18 ---
> 13 files changed, 206 insertions(+), 99 deletions(-)
> create mode 100644 include/linux/mdev_vfio_
On Mon, 18 Nov 2019 18:59:23 +0800
Jason Wang wrote:
[Note: I have not looked into the reworked architecture of this *at all*
so far; just something that I noted...]
> This sample driver creates mdev device that simulate virtio net device
> over virtio mdev transport. The device is implemented t
On Fri, 11 Oct 2019 16:15:51 +0800
Jason Wang wrote:
> Mdev bus only supports vfio driver right now, so it doesn't implement
> match method. But in the future, we may add drivers other than vfio,
> the first driver could be virtio-mdev. This means we need to add
> device class id support in bus m
On Fri, 11 Oct 2019 16:15:52 +0800
Jason Wang wrote:
> This patch adds bus uevent support for mdev bus in order to allow
> cooperation with userspace.
>
> Signed-off-by: Jason Wang
> ---
> drivers/vfio/mdev/mdev_driver.c | 8
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers
On Fri, 11 Oct 2019 16:15:54 +0800
Jason Wang wrote:
> Currently, except for the create and remove, the rest of
> mdev_parent_ops is designed for vfio-mdev driver only and may not help
> for kernel mdev driver. With the help of class id, this patch
> introduces device specific callbacks inside md
On Wed, 16 Oct 2019 05:50:08 +
Parav Pandit wrote:
> Hi Alex,
>
> > -Original Message-
> > From: Alex Williamson
> > Sent: Tuesday, October 15, 2019 12:27 PM
> > To: Jason Wang
> > Cc: Cornelia Huck ; k...@vger.kernel.org; linux-
On Thu, 17 Oct 2019 16:30:43 +0800
Jason Wang wrote:
> On 2019/10/17 上午12:53, Alex Williamson wrote:
> >>> Yet another suggestion: have the class id derive from the function
> >>> you use to set up the ops.
> >>>
> >>> void mdev_set_vfio_ops(struct mdev_device *mdev, const struct
> >>> vfio_mdev
On Thu, 17 Oct 2019 18:48:33 +0800
Jason Wang wrote:
> Currently, except for the create and remove, the rest of
> mdev_parent_ops is designed for vfio-mdev driver only and may not help
> for kernel mdev driver. With the help of class id, this patch
> introduces device specific callbacks inside md
On Thu, 17 Oct 2019 11:53:10 -0600
Alex Williamson wrote:
> On Thu, 17 Oct 2019 17:07:55 +0200
> Cornelia Huck wrote:
>
> > On Thu, 17 Oct 2019 18:48:33 +0800
> > Jason Wang wrote:
> >
> > > Currently, except for the create and remove, the rest of
> &
On Thu, 17 Oct 2019 18:48:34 +0800
Jason Wang wrote:
> This patch implements basic support for mdev driver that supports
> virtio transport for kernel virtio driver.
>
> Signed-off-by: Jason Wang
> ---
> drivers/vfio/mdev/mdev_core.c | 12 +++
> include/linux/mdev.h | 4 +
> includ
On Fri, 18 Oct 2019 18:55:02 +0800
Jason Wang wrote:
> On 2019/10/18 下午5:46, Cornelia Huck wrote:
> > On Thu, 17 Oct 2019 18:48:34 +0800
> > Jason Wang wrote:
> >> + * @get_vendor_id:Get virtio vendor id
> >> + *
On Thu, 17 Oct 2019 18:48:35 +0800
Jason Wang wrote:
> This patch introduces a new mdev transport for virtio. This is used to
> use kernel virtio driver to drive the mediated device that is capable
> of populating virtqueue directly.
>
> A new virtio-mdev driver will be registered to the mdev bu
On Mon, 21 Oct 2019 13:59:23 +0800
Jason Wang wrote:
> On 2019/10/18 下午10:20, Cornelia Huck wrote:
> > On Thu, 17 Oct 2019 18:48:35 +0800
> > Jason Wang wrote:
> >
> >> This patch introduces a new mdev transport for virtio. This is used to
> >> use ker
f_ctrl_hdr(entry);
> DRM_ERROR_RATELIMITED("response 0x%x (command
> 0x%x)\n",
Reviewed-by: Cornelia Huck
Endianness continues to be fun.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Thu, 12 Sep 2019 17:40:11 +0800
Jason Wang wrote:
> Mdev bus only support vfio driver right now, so it doesn't implement
> match method. But in the future, we may add drivers other than vfio,
> one example is virtio-mdev[1] driver. This means we need to add device
> id support in bus match met
On Thu, 12 Sep 2019 17:40:12 +0800
Jason Wang wrote:
> Currently, except for the crate and remove. The rest fields of
> mdev_parent_ops is just designed for vfio-mdev driver and may not help
> for kernel mdev driver. So follow the device id support by previous
> patch, this patch introduces devic
3 +--
> drivers/vfio/mdev/mdev_core.c| 16 ++--
> drivers/vfio/mdev/mdev_private.h | 2 ++
> drivers/vfio/mdev/vfio_mdev.c| 24 +---
> samples/Kconfig | 6 +++---
> 9 files changed, 23 insertions(+), 40 deletions(-)
I think you missed my earlier
Reviewed-by: Cornelia Huck
_driver_attach and bind_store]
> Signed-off-by: Christoph Hellwig
> ---
> drivers/base/bus.c | 2 +-
> drivers/base/dd.c | 32 ++--
> 2 files changed, 11 insertions(+), 23 deletions(-)
Reviewed-by: Cornelia Huck
| 29 -
> 2 files changed, 21 insertions(+), 14 deletions(-)
Reviewed-by: Cornelia Huck
to the
> error return of device_driver_attach().
>
> Signed-off-by: Jason Gunthorpe
> Signed-off-by: Christoph Hellwig
> ---
> drivers/base/base.h| 1 -
> drivers/base/dd.c | 3 +++
> include/linux/device.h | 2 ++
> 3 files changed, 5 insertions(+), 1 deletion(-)
Reviewed-by: Cornelia Huck
6 +++---
> 9 files changed, 23 insertions(+), 40 deletions(-)
Reviewed-by: Cornelia Huck
son Gunthorpe
> Signed-off-by: Christoph Hellwig
> ---
> drivers/vfio/mdev/mdev_core.c | 30 ++
> drivers/vfio/mdev/mdev_driver.c | 10 ++
> include/linux/mdev.h| 2 ++
> 3 files changed, 34 insertions(+), 8 deletions(-)
Reviewed-by: Cornelia Huck
%d\n",
> + drv->name, dev_name(dev), ret);
Convert these two pr_* to dev_* when touching the code anyway?
> + break;
> + }
> +
> + return ret;
> +}
(...)
Reviewed-by: Cornelia Huck
t bothering
> the sysfs bind case.
>
> Signed-off-by: Christoph Hellwig
> Reviewed-by: Greg Kroah-Hartman
> ---
> drivers/base/dd.c | 78 +--
> 1 file changed, 42 insertions(+), 36 deletions(-)
>
Reviewed-by: Cornelia Huck
son Gunthorpe
> Signed-off-by: Christoph Hellwig
> ---
> drivers/vfio/mdev/mdev_core.c | 30 ++
> drivers/vfio/mdev/mdev_driver.c | 10 ++
> include/linux/mdev.h| 2 ++
> 3 files changed, 34 insertions(+), 8 deletions(-)
>
Reviewed-by: Cornelia Huck
1 -
> samples/vfio-mdev/mbochs.c| 1 -
> samples/vfio-mdev/mdpy.c | 1 -
> samples/vfio-mdev/mtty.c | 1 -
> 12 files changed, 4 insertions(+), 35 deletions(-)
Reviewed-by: Cornelia Huck
On Wed, 29 Mar 2017 23:48:44 +0300
"Michael S. Tsirkin" wrote:
> We are going to add more parameters to find_vqs, let's wrap the call so
> we don't need to tweak all drivers every time.
>
> Signed-off-by: Michael S. Tsirkin
> ---
> drivers/block/virtio_blk.c | 3 +--
> drivers/
d, 4 insertions(+), 4 deletions(-)
Reviewed-by: Cornelia Huck
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Thu, 8 Dec 2016 04:29:39 +0200
"Michael S. Tsirkin" wrote:
> By now, linux is mostly endian-clean. Enabling endian-ness
> checks for everyone produces about 200 new sparse warnings for me -
> less than 10% over the 2000 sparse warnings already there.
Out of curiousity: Where do most of those
74 matches
Mail list logo
