[PATCH] dt-bindings: display: delete ilitek,ili9341.txt

2022-06-17 Thread Conor Dooley
From: Conor Dooley ilitek,ili9341.txt was replaced by ilitek,ili9341.yaml but the txt binding was not deleted. Do so. Signed-off-by: Conor Dooley --- .../bindings/display/ilitek,ili9341.txt | 27 --- 1 file changed, 27 deletions(-) delete mode 100644 Documentation

[PATCH v4 00/14] Canaan devicetree fixes

2022-07-01 Thread Conor Dooley
From: Conor Dooley Hey all, This series should rid us of dtbs_check errors for the RISC-V Canaan k210 based boards. To make keeping it that way a little easier, I changed the Canaan devicetree Makefile so that it would build all of the devicetrees in the directory if SOC_CANAAN. I *DO NOT* have

[PATCH v4 01/14] dt-bindings: display: convert ilitek, ili9341.txt to dt-schema

2022-07-01 Thread Conor Dooley
From: Conor Dooley A dt-schema binding for the Ilitek ili9341 was created as panel/ilitek,ili9341.yaml but the txt binding was ignored in the process. Move the remaining items in the txt binding to the yaml one & delete it. The example in the txt binding has a spi-max-frequency which disag

[PATCH v4 02/14] dt-bindings: display: ili9341: document canaan kd233's lcd

2022-07-01 Thread Conor Dooley
From: Conor Dooley The Canaan KD233 development board has a built in LCD. Add a specific compatible for it. Signed-off-by: Conor Dooley --- .../devicetree/bindings/display/panel/ilitek,ili9341.yaml| 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings

[PATCH v4 03/14] ASoC: dt-bindings: convert designware-i2s to dt-schema

2022-07-01 Thread Conor Dooley
From: Conor Dooley Convert the Synopsys DesignWare I2S controller binding to dt-schema. There was no listed maintainer but Jose Abreu was the last editor of the txt binding so add him as maintainer. Signed-off-by: Conor Dooley --- .../bindings/sound/designware-i2s.txt | 35

[PATCH v4 04/14] dt-bindings: dma: dw-axi-dmac: extend the number of interrupts

2022-07-01 Thread Conor Dooley
From: Conor Dooley The Canaan k210 apparently has a Sysnopsys Designware AXI DMA controller, but according to the documentation & devicetree it has 6 interrupts rather than the standard one. Support the 6 interrupt configuration by unconditionally extending the binding to a maximum of 8

[PATCH v4 05/14] dt-bindings: memory-controllers: add canaan k210 sram controller

2022-07-01 Thread Conor Dooley
From: Conor Dooley The k210 U-Boot port has been using the clocks defined in the devicetree to bring up the board's SRAM, but this violates the dt-schema. As such, move the clocks to a dedicated node with the same compatible string & document it. Signed-off-by: Conor Dooley --- .

[PATCH v4 06/14] riscv: dts: canaan: fix the k210's memory node

2022-07-01 Thread Conor Dooley
From: Conor Dooley The k210 U-Boot port has been using the clocks defined in the devicetree to bring up the board's SRAM, but this violates the dt-schema. As such, move the clocks to a dedicated node with the same compatible string. The regs property does not fit in either node, so is rep

[PATCH v4 07/14] riscv: dts: canaan: fix the k210's timer nodes

2022-07-01 Thread Conor Dooley
From: Conor Dooley The timers on the k210 have non standard interrupt configurations, which leads to dtbs_check warnings: k210_generic.dtb: timer@502d: interrupts: [[14], [15]] is too long >From schema: Documentation/devicetree/bindings/timer/snps,dw-apb-timer.yaml Split the timer nodes

[PATCH v4 08/14] riscv: dts: canaan: fix mmc node names

2022-07-01 Thread Conor Dooley
From: Conor Dooley The newly-converted-to-dt-schema binding expects the mmc node name to be '^mmc(@.*)?$' so align the devicetree with the schema. Tested-by: Niklas Cassel Signed-off-by: Conor Dooley --- arch/riscv/boot/dts/canaan/canaan_kd233.dts | 2 +- arch/riscv/boot/

[PATCH v4 09/14] riscv: dts: canaan: fix kd233 display spi frequency

2022-07-01 Thread Conor Dooley
From: Conor Dooley The binding for the ili9341 specifies a const spi-max-frequency of 10 MHz but the kd233 devicetree entry has it listed at 15 Mhz. Align the devicetree with the value in the binding. Signed-off-by: Conor Dooley --- arch/riscv/boot/dts/canaan/canaan_kd233.dts | 2 +- 1 file

[PATCH v4 10/14] riscv: dts: canaan: use custom compatible for k210 i2s

2022-07-01 Thread Conor Dooley
From: Conor Dooley The devicetrees using the Canaan k210 all have a sound-dai-cells value of 1, whereas the standard binding example for the DesignWare i2s and other use cases suggest 0. Use a k210 specific compatible which supports this difference. Signed-off-by: Conor Dooley --- arch/riscv

[PATCH v4 11/14] riscv: dts: canaan: remove spi-max-frequency from controllers

2022-07-01 Thread Conor Dooley
From: Conor Dooley spi-max-frequency is a device, not a controller property and should be removed. Link: https://lore.kernel.org/lkml/20220526014141.2872567-1-r...@kernel.org/ Tested-by: Niklas Cassel Signed-off-by: Conor Dooley --- arch/riscv/boot/dts/canaan/k210.dtsi | 5 + 1 file

[PATCH v4 12/14] riscv: dts: canaan: fix bus {ranges,reg} warnings

2022-07-01 Thread Conor Dooley
From: Conor Dooley The k210 devicetrees warn about missing/empty reg and/or ranges properties: arch/riscv/boot/dts/canaan/k210.dtsi:408.22-460.5: Warning (unit_address_vs_reg): /soc/bus@5200: node has a unit name, but no reg or ranges property arch/riscv/boot/dts/canaan/k210.dtsi:352.22

[PATCH v4 13/14] riscv: dts: canaan: add specific compatible for kd233's LCD

2022-07-01 Thread Conor Dooley
From: Conor Dooley Add the recently introduced compatible for the LCD on the Canaan KD233. Signed-off-by: Conor Dooley --- arch/riscv/boot/dts/canaan/canaan_kd233.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/riscv/boot/dts/canaan/canaan_kd233.dts b/arch/riscv

[PATCH v4 14/14] riscv: dts: canaan: build all devicetress if SOC_CANAAN

2022-07-01 Thread Conor Dooley
From: Conor Dooley Testing & checking the Canaan devicetrees is inconvenient as only the devicetree corresponding to SOC_CANAAN_K210_DTB_BUILTIN will be built. Change the Makefile so that all devicetrees are built by default if SOC_CANAAN but only the one specified by SOC_CANAAN_K210_DTB_BUI

Re: [PATCH] dt-bindings: yamllint: Require a space after a comment '#'

2023-03-03 Thread Conor Dooley
> '#'. A couple of cases with comments which were not intended to be > comments are revealed. Those were in ti,sa2ul.yaml, ti,cal.yaml, and > brcm,bcmgenet.yaml. > > Signed-off-by: Rob Herring > --- > Cc: Conor Dooley > diff --git a/Documentation/devicetree/bi

Re: [PATCH v2 00/11] pwm: Allow .get_state to fail

2022-12-01 Thread Conor Dooley
Hey Uwe! On Wed, Nov 30, 2022 at 04:21:37PM +0100, Uwe Kleine-König wrote: > Hello, > > I forgot about this series and was remembered when I talked to Conor > Dooley about how .get_state() should behave in an error case. In the context of "my" driver, get_state() the pro

Re: [PATCH v2 00/11] pwm: Allow .get_state to fail

2022-12-01 Thread Conor Dooley
On Thu, Dec 01, 2022 at 02:19:07PM +0100, Uwe Kleine-König wrote: > Hello Conor, > > On Thu, Dec 01, 2022 at 11:11:51AM +0000, Conor Dooley wrote: > > TL;DR, I quite like the ability to return an error and not mislead the > > caller. > > Is this an Ack? It is if

Re: [PATCH v3 0/4] docs & checkpatch: allow Closes tags with links

2023-03-31 Thread Conor Dooley
On Fri, Mar 31, 2023 at 11:39:22AM +0200, Thorsten Leemhuis wrote: > -Please check the link to make sure that it is actually working and points > -to the relevant message. > +If the URL points to a bug report that is fixed by the patch, use 'Closes:' > +instead. This is not specifically a comment

Re: [PATCH 1/9] dt-bindings: mfd: Add bindings for SAM9X7 LCD controller

2023-06-14 Thread Conor Dooley
On Tue, Jun 13, 2023 at 07:18:25PM +0100, Conor Dooley wrote: > On Tue, Jun 13, 2023 at 12:34:18PM +0530, Manikandan Muralidharan wrote: > > Add new compatible string for the XLCD controller on SAM9X7 SoC. > > You should probably indicate here why this is not compatible with the

Re: [PATCH 5/9] drm: atmel-hlcdc: add compatible string check for XLCDC and HLCDC

2023-06-14 Thread Conor Dooley
On Tue, Jun 13, 2023 at 07:16:06PM +0100, Conor Dooley wrote: > On Tue, Jun 13, 2023 at 12:34:22PM +0530, Manikandan Muralidharan wrote: > > + /* Other SoC's that supports HLCDC IP */ > > Should this be "Other SoCs that do not support HLCDC IP"? Clearl

Re: [PATCH 1/9] dt-bindings: mfd: Add bindings for SAM9X7 LCD controller

2023-06-14 Thread Conor Dooley
On Wed, Jun 14, 2023 at 04:40:50PM +0200, Nicolas Ferre wrote: > On 13/06/2023 at 20:21, Conor Dooley wrote: > > On Tue, Jun 13, 2023 at 08:17:13PM +0200, Krzysztof Kozlowski wrote: > > > On 13/06/2023 09:04, Manikandan Muralidharan wrote: > > > > Add new compatible

Re: [PATCH] dt-bindings: display: sony,td4353-jdi: allow width-mm and height-mm

2023-06-17 Thread Conor Dooley
h any of the regexes: 'pinctrl-[0-9]+' > > Signed-off-by: Krzysztof Kozlowski Acked-by: Conor Dooley Cheers, Conor. signature.asc Description: PGP signature

Re: [PATCH v4 4/6] dt-bindings: display: stm32-ltdc: add optional st,fb-bpp property

2023-06-19 Thread Conor Dooley
Hey, On Mon, Jun 19, 2023 at 06:55:23PM +0200, Dario Binacchi wrote: > Boards that use the STM32F{4,7} series have limited amounts of RAM. The > added property allows to size, within certain limits, the memory footprint > required by the framebuffer. Hmm, this sounds quite a lot like "software po

Re: [PATCH 2/9] mfd: atmel-hlcdc: Add compatible for SAM9X7 HLCD controller

2023-06-21 Thread Conor Dooley
On Wed, Jun 21, 2023 at 06:56:45PM +0100, Lee Jones wrote: > On Tue, 13 Jun 2023, Manikandan Muralidharan wrote: > > > Add compatible for SAM9X7 HLCD controller. > > > > Signed-off-by: Manikandan Muralidharan > > --- > > drivers/mfd/atmel-hlcdc.c | 1 + > > 1 file changed, 1 insertion(+) > > A

Re: [PATCH 1/9] dt-bindings: mfd: Add bindings for SAM9X7 LCD controller

2023-06-26 Thread Conor Dooley
On Mon, Jun 26, 2023 at 05:31:59AM +, manikanda...@microchip.com wrote: > On 21/06/23 13:17, Nicolas Ferre wrote: > > On 16/06/2023 at 08:44, Manikandan M - I67131 wrote: > >> On 14/06/23 20:10, Nicolas Ferre wrote: > >>> On 13/06/2023 at 20:21, Conor Dooley wrot

Re: [PATCH v6 8/9] dt-bindings: arm: amlogic: Document the MNT Reform 2 CM4 adapter with a BPI-CM4 Module

2023-06-30 Thread Conor Dooley
On Fri, Jun 30, 2023 at 06:29:15PM +0200, Neil Armstrong wrote: > The MNT Reform 2 CM4 adapter can be populated with any Raspberry Pi CM4 > compatible module such as a BPI-CM4 Module, document that. > > Signed-off-by: Neil Armstrong Acked-by: Conor Dooley Cheers, Conor. s

Re: [PATCH v6 1/9] dt-bindings: clk: g12a-clkc: add CTS_ENCL clock ids

2023-06-30 Thread Conor Dooley
On Fri, Jun 30, 2023 at 06:29:08PM +0200, Neil Armstrong wrote: > Add new CLK ids for the CTS_ENCL and CTS_ENCL_SEL clocks > on G12A compatible SoCs. > > Signed-off-by: Neil Armstrong Acked-by: Conor Dooley Cheers, Conor. signature.asc Description: PGP signature

Re: [PATCH] dt-bindings: cleanup DTS example whitespaces

2023-07-03 Thread Conor Dooley
On Sun, Jul 02, 2023 at 08:23:08PM +0200, Krzysztof Kozlowski wrote: > The DTS code coding style expects spaces around '=' sign. > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Conor Dooley Cheers, Conor. signature.asc Description: PGP signature

Re: [PATCH v4 04/13] dt-bindings: display: add Amlogic MIPI DSI Host Controller bindings

2023-05-12 Thread Conor Dooley
Cs. > > Signed-off-by: Neil Armstrong > Signed-off-by: Neil Armstrong This looks fine to me, Reviewed-by: Conor Dooley but I would like Krzysztof to take a look too to be on the safe side! Cheers, Conor. > --- > .../display/amlogic,meson-g12a-dw-mipi-dsi.yaml| 117 > ++

Re: [PATCH 7/7] dt-bindings: Add bidings for mtk,apu-drm

2023-05-17 Thread Conor Dooley
On Wed, May 17, 2023 at 05:04:00PM +0200, AngeloGioacchino Del Regno wrote: > Il 17/05/23 16:52, Alexandre Bailon ha scritto: > > This adds the device tree bindings for the APU DRM driver. > > > > Signed-off-by: Alexandre Bailon > > Reviewed-by: Julien Stephan > > --- > > .../devicetree/bindin

Re: [PATCH v3 2/3] dt-bindings: display: st,stm32-dsi: Remove unnecessary fields

2023-05-17 Thread Conor Dooley
27; subnode. By doing so, address > and size fields become then unnecessary, creating a warning at build time. > > Signed-off-by: Raphael Gallais-Pou Acked-by: Conor Dooley Thanks, Conor. signature.asc Description: PGP signature

Re: [PATCH v2] dt-bindings: display: panel: add panel-mipi-dsi-bringup

2023-05-18 Thread Conor Dooley
On Thu, May 18, 2023 at 04:47:08PM +0200, Paulo Pavacic wrote: > > So, the driver has to be panel-fannal-c3004.c and binding to be > > fannal,c3004.yaml. > > I believe I have covered this and all the other problems in following > patch which I will submit as a V3 of the conversation in a patchset

Re: [PATCH 1/2] dt-bindings: display: panel: add fannal,c3004

2023-05-19 Thread Conor Dooley
Hey Paulo, On Fri, May 19, 2023 at 04:24:55PM +0200, Paulo Pavacic wrote: > > Added fannal to vendor-prefixes and dt bindings for Fannal C3004. > Fannal C3004 is a 480x800 MIPI DSI Panel which requires > DCS initialization sequences with certain delays between certain > commands. > > Signed-off-

Re: [PATCH v5 1/3] dt-bindings: display: panel: Add Samsung S6D7AA0 LCD panel controller

2023-05-19 Thread Conor Dooley
iptions > - Fixed license Looks like you've resolved the things Krzysztof and Rob took issue with. Reviewed-by: Conor Dooley Thanks, Conor. signature.asc Description: PGP signature

Re: [PATCH net-next v3 1/6] dt-bindings: net: brcm,unimac-mdio: Add asp-v2.0

2023-05-22 Thread Conor Dooley
On Fri, May 19, 2023 at 02:19:39PM -0700, Justin Chen wrote: > The ASP 2.0 Ethernet controller uses a brcm unimac. > > Signed-off-by: Florian Fainelli > Signed-off-by: Justin Chen > --- > Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > d

Re: [PATCH net-next v3 2/6] dt-bindings: net: Brcm ASP 2.0 Ethernet controller

2023-05-22 Thread Conor Dooley
On Fri, May 19, 2023 at 02:19:40PM -0700, Justin Chen wrote: > From: Florian Fainelli > > Add a binding document for the Broadcom ASP 2.0 Ethernet controller. > > Signed-off-by: Florian Fainelli > Signed-off-by: Justin Chen > --- Same deal here, usual mailer is refusing to reply cos of: Proble

Re: [PATCH net-next v3 1/6] dt-bindings: net: brcm,unimac-mdio: Add asp-v2.0

2023-05-22 Thread Conor Dooley
On Mon, May 22, 2023 at 11:25:54AM -0700, Florian Fainelli wrote: > On 5/22/23 11:17, Conor Dooley wrote: > > On Fri, May 19, 2023 at 02:19:39PM -0700, Justin Chen wrote: > > > The ASP 2.0 Ethernet controller uses a brcm unimac. > > > > > > Signed-off-by: Fl

Re: [PATCH v2 1/3] dt-bindings: display: move LVDS data-mapping definition to separate file

2023-05-23 Thread Conor Dooley
chemas/display/lvds-data-mapping.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: LVDS Data Mapping > + > +maintainers: > + - Laurent Pinchart > + - Thierry Reding > + > +description: |+ Apparently this + is a "chomping indicator", but I

Re: [PATCH v2 2/3] dt-bindings: display: simple: support non-default data-mapping

2023-05-23 Thread Conor Dooley
> v1 -> v2: - worked in Rob's review findings (thanks for reviewing my > work): use extracted common property instead of duplicating > the property That looks to be true (and Rob's AFK at the moment, hence unable to reply to your ping) so, Reviewed-by

Re: [PATCH] dt-bindings: backlight: pwm: Make power-supply not required

2023-05-23 Thread Conor Dooley
commit deaeeda2051fa280 ("backlight: pwm_bl: Don't rely > on a disabled PWM emiting inactive state"), the Linux driver considers > the power supply optional. > > Fix this by synchronizing the bindings with actual driver behavior by > making the "power-supply"

Re: [PATCH net-next v4 2/6] dt-bindings: net: Brcm ASP 2.0 Ethernet controller

2023-05-23 Thread Conor Dooley
Hey Justin, On Tue, May 23, 2023 at 02:53:43PM -0700, Justin Chen wrote: > + compatible: > +enum: > + - brcm,asp-v2.0 > + - brcm,bcm72165-asp > + - brcm,asp-v2.1 > + - brcm,bcm74165-asp > +compatible = "brcm,bcm72165-asp", "brcm,asp-v2.0"; You can't do this, as

Re: [PATCH net-next v4 2/6] dt-bindings: net: Brcm ASP 2.0 Ethernet controller

2023-05-23 Thread Conor Dooley
Hey Justin, On Tue, May 23, 2023 at 04:27:12PM -0700, Justin Chen wrote: > On Tue, May 23, 2023 at 3:55 PM Conor Dooley wrote: > > On Tue, May 23, 2023 at 02:53:43PM -0700, Justin Chen wrote: > > > > > + compatible: > > > +enum: > > > + - brcm

Re: [PATCH net-next v4 2/6] dt-bindings: net: Brcm ASP 2.0 Ethernet controller

2023-05-24 Thread Conor Dooley
On Wed, May 24, 2023 at 07:51:07AM +0100, Conor Dooley wrote: > Hey Justin, > On Tue, May 23, 2023 at 04:27:12PM -0700, Justin Chen wrote: > > On Tue, May 23, 2023 at 3:55 PM Conor Dooley wrote: > > > On Tue, May 23, 2023 at 02:53:43PM -0700, Justin Chen wrote: > &

Re: [PATCH 1/2] dt-bindings: display: panel-simple: Add Ampire AM-800480L1TMQW-T00H

2023-05-24 Thread Conor Dooley
On Wed, May 24, 2023 at 02:32:10PM +0200, Geert Uytterhoeven wrote: > Document support for the Ampire AM-800480L1TMQW-T00H 5" WVGA TFT LCD > panel. > > Signed-off-by: Geert Uytterhoeven Acked-by: Conor Dooley Thanks, Conor. signature.asc Description: PGP signature

Re: [v2 0/4] Support Starry-himax83102-j02 and Starry-ili9882t TDDI MIPI-DSI panel

2023-05-24 Thread Conor Dooley
dt-bindings: display: panel: Add compatible for Starry himax83102-j02 > dt-bindings: display: panel: Add compatible for Starry ili9882t These two are Acked-by: Conor Dooley Thanks, Conor. signature.asc Description: PGP signature

Re: [PATCH net-next v4 2/6] dt-bindings: net: Brcm ASP 2.0 Ethernet controller

2023-05-24 Thread Conor Dooley
On Wed, May 24, 2023 at 02:47:59PM -0700, Justin Chen wrote: > On Tue, May 23, 2023 at 11:56 PM Conor Dooley > wrote: > Gotcha. I got something like this now. > > compatible: > oneOf: > - items: > - enum: > - brcm,bcm74165-asp &g

Re: [v3 2/4] drm/panel: Support for Starry-himax83102-j02 TDDI MIPI-DSI panel

2023-05-24 Thread Conor Dooley
ulled high, so > increase lp11_before_reset flag. > > [1]: > https://github.com/HimaxSoftware/Doc/tree/main/Himax_Chipset_Power_Sequence > > Signed-off-by: Cong Yang > Reviewed-by: Douglas Anderson > Acked-by: Conor Dooley I didn't Ack this (or 4/4). If the patches are

Re: [PATCH net-next v5 2/6] dt-bindings: net: Brcm ASP 2.0 Ethernet controller

2023-05-25 Thread Conor Dooley
> +const: 1 > + > + compatible: > +oneOf: > + - items: > + - enum: > + - brcm,bcm74165-asp > + - const: brcm,asp-v2.1 > + - items: > + - enum: > + - brcm,bcm72165-asp > + - cons

Re: [PATCH 2/3] dt-bindings: display: panel: Add panels based on ILITEK ILI9806E

2023-07-19 Thread Conor Dooley
t; +backlight: backlight { > +compatible = "gpio-backlight"; > +gpios = <&gpio 22 GPIO_ACTIVE_HIGH>; > +}; > +spi { Just a nit, a blank line between properties please. Clearly no respinning needed for that... Otherwise, Reviewed-by: Conor D

Re: [PATCH v4 1/3] dt-bindings: display: move LVDS data-mapping definition to separate file

2023-07-29 Thread Conor Dooley
t; v4: none > > v2 -> v3: worked in Conor's and Laurent's review findings (thank you > for reviewing my work): drop +| on description I think both Laurent & I provided reviewed-bys on v2. Is there a reason you did not include them? Here's mine back again:

Re: [PATCH v4 2/3] dt-bindings: display: simple: support non-default data-mapping

2023-07-29 Thread Conor Dooley
ular you didn't pick up the tags? Here it is against, since all that appears to have changed is some typos. Reviewed-by: Conor Dooley signature.asc Description: PGP signature

Re: [PATCH v1 v1 1/7] MAINTAINERS: Update starfive maintainers

2023-08-01 Thread Conor Dooley
On Tue, Aug 01, 2023 at 06:10:24PM +0800, Keith Zhao wrote: > update starfive maintainers > > Signed-off-by: Keith Zhao Why is this a standalone patch, before you've even added any of the files in question? > --- > MAINTAINERS | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/MA

Re: [PATCH v1 v1 2/7] dt-bindings: display: Add yamls for JH7110 display system

2023-08-01 Thread Conor Dooley
On Tue, Aug 01, 2023 at 06:10:25PM +0800, Keith Zhao wrote: > StarFive SoCs JH7110 display system: > lcd-controller bases verisilicon dc8200 IP, > and hdmi bases Innosilicon IP. > Add bindings for them. Please, you can use more than 46 characters in a line! Also, "v1 v1" does not a v2 make. > >

Re: [PATCH 1/2] dt-bindings: display: simple: Add Innolux G156HCE-L01 panel

2023-08-01 Thread Conor Dooley
Rev.C3_Datasheet.pdf > > Signed-off-by: Marek Vasut > --- > Cc: Conor Dooley Acked-by: Conor Dooley Thanks, Conor. signature.asc Description: PGP signature

Re: [PATCH 07/14] dt-bindings: display: rockchip-dw-mipi-dsi: Document rv1126 DSI

2023-08-01 Thread Conor Dooley
On Mon, Jul 31, 2023 at 04:30:05PM +0530, Jagan Teki wrote: > Document the MIPI DSI for Rockchip RV1126. > > Signed-off-by: Jagan Teki Acked-by: Conor Dooley Thanks, Conor. > --- > Cc: dri-devel@lists.freedesktop.org > Cc: devicet...@vger.kernel.org > Cc: Rob Her

Re: [PATCH 05/14] dt-bindings: display: rockchip-vop: Document rv1126 vop

2023-08-01 Thread Conor Dooley
f appending to enum is the right thing to do? Ditto the other binding. Thanks, Conor. > --- > Cc: dri-devel@lists.freedesktop.org > Cc: devicet...@vger.kernel.org > Cc: Rob Herring > Cc: Krzysztof Kozlowski > Cc: Conor Dooley > Cc: Sandy Huang > Cc: David Airlie >

Re: [PATCH 05/14] dt-bindings: display: rockchip-vop: Document rv1126 vop

2023-08-02 Thread Conor Dooley
On Wed, Aug 02, 2023 at 08:07:55PM +0530, Jagan Teki wrote: > On Wed, 2 Aug 2023 at 02:37, Conor Dooley wrote: > > > > On Mon, Jul 31, 2023 at 04:30:03PM +0530, Jagan Teki wrote: > > > Document the VOP for Rockchip RV1126. > > > > > > Signed-off-by: Jaga

Re: [PATCH] Revert "dt-bindings: bridge: samsung-dsim: Make some flags optional"

2023-05-26 Thread Conor Dooley
On Fri, May 26, 2023 at 09:27:16AM +0200, Neil Armstrong wrote: > This reverts commit cfaf76d349837f695c8aa6d7077847fec4231fe5 which was applied > without review due to a bad tool manipulation. Is it a dt-binding maintainer review that you are missing on that patch? For this one: Acked-by:

Re: [PATCH V8 7/7] dt-bindings: bridge: samsung-dsim: Make some flags optional

2023-05-26 Thread Conor Dooley
Adam, Neil, I meant to get to this earlier today, but broken CI got in the way... On Thu, May 25, 2023 at 10:05:59PM -0500, Adam Ford wrote: > In the event a device is connected to the samsung-dsim > controller that doesn't support the burst-clock, the > driver is able to get the requested pixel

Re: [PATCH V8 7/7] dt-bindings: bridge: samsung-dsim: Make some flags optional

2023-05-26 Thread Conor Dooley
On Fri, May 26, 2023 at 02:24:21PM -0500, Adam Ford wrote: > On Fri, May 26, 2023 at 1:19 PM Conor Dooley wrote: > > On Thu, May 25, 2023 at 10:05:59PM -0500, Adam Ford wrote: > > > description: > > > - DSIM high speed burst mode frequency. > > &g

Re: [PATCH 2/7] dt-bindings: display/msm: dsi-controller-main: Add msm8226 compatible

2023-05-29 Thread Conor Dooley
On Mon, May 29, 2023 at 11:43:59AM +0200, Luca Weiss wrote: > Add the compatible for the DSI found on MSM8226. > > Signed-off-by: Luca Weiss Acked-by: Conor Dooley Thanks, Conor. signature.asc Description: PGP signature

Re: [PATCH 3/7] dt-bindings: display/msm: qcom,mdp5: Add msm8226 compatible

2023-05-29 Thread Conor Dooley
On Mon, May 29, 2023 at 11:44:00AM +0200, Luca Weiss wrote: > Add the compatible for the MDP5 found on MSM8226. > > Signed-off-by: Luca Weiss Acked-by: Conor Dooley Thanks, Conor. signature.asc Description: PGP signature

Re: [PATCH 1/7] dt-bindings: msm: dsi-phy-28nm: Document msm8226 compatible

2023-05-29 Thread Conor Dooley
t; + - qcom,dsi-phy-28nm-8226 How come the order is different in both places? Acked-by: Conor Dooley Thanks, Conor. >- qcom,dsi-phy-28nm-8960 > >reg: > diff --git a/Documentation/devicetree/bindings/display/msm/qcom,mdss.yaml > b/Documentation/devicetree/bindi

Re: [PATCH v5 16/17] dt-bindings: arm: amlogic: Document the MNT Reform 2 CM4 adapter with a BPI-CM4 Module

2023-05-30 Thread Conor Dooley
On Tue, May 30, 2023 at 09:38:17AM +0200, Neil Armstrong wrote: > The MNT Reform 2 CM4 adapter can be populated with any Raspberry Pi CM4 > compatible module such as a BPI-CM4 Module, document that. > > Signed-off-by: Neil Armstrong Acked-by: Conor Dooley Thanks, Conor. s

Re: [PATCH v5 03/17] dt-bindings: clk: g12a-clkc: add VCLK2_SEL and CTS_ENCL clock ids

2023-05-30 Thread Conor Dooley
On Tue, May 30, 2023 at 09:38:04AM +0200, Neil Armstrong wrote: > Add new CLK ids for the VCLK2_SEL, CTS_ENCL and CTS_ENCL_SEL clocks > on G12A compatible SoCs. > > Signed-off-by: Neil Armstrong Acked-by: Conor Dooley Thanks, Conor. signature.asc Description: PGP signature

Re: [PATCH v5 06/17] dt-bindings: display: add Amlogic MIPI DSI Host Controller bindings

2023-05-30 Thread Conor Dooley
ies. > > Signed-off-by: Neil Armstrong > Signed-off-by: Neil Armstrong Welp, I was happy with it last time around before Krzysztof took a look, and the things he pointed out seem to be fixed, so you can have my R-b back. Reviewed-by: Conor Dooley Thanks, Conor. signature.asc Description: PGP signature

Re: [PATCH 1/2] dt-bindings: display: bridge: tc358762: Document reset-gpios

2023-05-30 Thread Conor Dooley
On Tue, May 30, 2023 at 09:28:04PM +0200, Marek Vasut wrote: > This chip has one reset GPIO input, document it. The reset GPIO > is optional as it is sometimes not connected on some hardware. > > Signed-off-by: Marek Vasut Acked-by: Conor Dooley Cheers, Conor. signature.asc Desc

Re: [PATCH 4/6] dt-bindings: display: simple: add Rocktech RK043FN48H

2023-06-01 Thread Conor Dooley
,rk070er9427 > +# Rocktech Display Ltd. RK043FN48H 4.3" 480x272 LCD-TFT panel > + - rocktech,rk043fn48h I was going to ask why not alphanumerically, but clearly things are not in that order to begin with ¯\_(ツ)_/¯ Acked-by: Conor Dooley Cheers, Conor. > # Samsung

Re: [PATCH 1/9] dt-bindings: display: Add yamls for JH7110 display subsystem

2023-06-02 Thread Conor Dooley
Hey Keith, On Fri, Jun 02, 2023 at 03:40:35PM +0800, Keith Zhao wrote: > Add bindings for JH7110 display subsystem which > has a display controller verisilicon dc8200 > and an HDMI interface. > > Signed-off-by: Keith Zhao > --- > .../display/verisilicon/starfive-hdmi.yaml| 93 +

Re: [PATCH 1/2] dt-bindings: display: panel: add fannal,c3004

2023-06-05 Thread Conor Dooley
On Mon, Jun 05, 2023 at 04:33:15PM +0200, Paulo Pavacic wrote: > Hello Conor, > > pet, 19. svi 2023. u 18:41 Conor Dooley napisao je: > > > > Hey Paulo, > > > > On Fri, May 19, 2023 at 04:24:55PM +0200, Paulo Pavacic wrote: > > > > > > Added f

Re: [PATCH 1/2] dt-bindings: display: panel: add fannal,c3004

2023-06-05 Thread Conor Dooley
On Mon, Jun 05, 2023 at 04:56:13PM +0200, Paulo Pavacic wrote: > Hello Conor, > > pon, 5. lip 2023. u 16:43 Conor Dooley napisao je: > Sorry this is my first patch, I still don't understand, why should I > add `maxItems: 1` to the 'reg:' ? > Isn&

Re: [PATCH v3 1/2] dt-bindings: soc: imx93-media-blk-ctrl: Add PDFC subnode to schema and example

2023-06-06 Thread Conor Dooley
t; and add the subnode to example. The previous issues seem to be resolved & what you've got here looks fine to me. Perhaps Krzysztof will disagree! Reviewed-by: Conor Dooley Cheers, Conor. > > Signed-off-by: Liu Ying > --- > v2->v3: > * Newly introduced to rep

Re: [PATCH 1/9] dt-bindings: display: Add yamls for JH7110 display subsystem

2023-06-06 Thread Conor Dooley
On Wed, Jun 07, 2023 at 12:22:33AM +0200, Heiko Stübner wrote: > Am Dienstag, 6. Juni 2023, 20:41:17 CEST schrieb Shengyu Qu: > > > On Fri, Jun 02, 2023 at 03:40:35PM +0800, Keith Zhao wrote: > > >> Add bindings for JH7110 display subsystem which > > >> has a display controller verisilicon dc8200 >

Re: [PATCH v1 2/8] dt-bindings: display: panel: mipi-dbi-spi: add spi-3wire property

2023-06-07 Thread Conor Dooley
is enables a flicker-free boot. > > Signed-off-by: Leonard Göhrs Acked-by: Conor Dooley Cheers, Conor. signature.asc Description: PGP signature

Re: [PATCH v1 1/8] dt-bindings: display: panel: mipi-dbi-spi: add shineworld lh133k compatible

2023-06-07 Thread Conor Dooley
ription: SHIFT GmbH >"^shimafuji,.*": > description: Shimafuji Electric, Inc. > + "^shineworld,.*": > +description: ShineWorld Innovations >"^shiratech,.*": > description: Shiratech Solutions >"^si-en,.*": AFAIU, these are supposed to be split into separate patches. Otherwise, Acked-by: Conor Dooley Cheers, Conor. signature.asc Description: PGP signature

Re: [PATCH v2 2/5] dt-bindings: display: ssd1307fb: Remove default width and height values

2023-06-10 Thread Conor Dooley
On Fri, Jun 09, 2023 at 07:09:37PM +0200, Javier Martinez Canillas wrote: > A default resolution in the ssd130x driver isn't set to an arbitrary 96x16 > anymore. Instead is set to a width and height that's controller dependent. Did that change to the driver not break backwards compatibility with e

Re: [PATCH v2 2/5] dt-bindings: display: ssd1307fb: Remove default width and height values

2023-06-10 Thread Conor Dooley
On Sat, Jun 10, 2023 at 07:51:35PM +0200, Javier Martinez Canillas wrote: > Conor Dooley writes: > > > On Fri, Jun 09, 2023 at 07:09:37PM +0200, Javier Martinez Canillas wrote: > >> A default resolution in the ssd130x driver isn't set to an arbitrary 96x16 > >>

Re: [PATCH v2 2/5] dt-bindings: display: ssd1307fb: Remove default width and height values

2023-06-12 Thread Conor Dooley
On Mon, Jun 12, 2023 at 09:47:12AM +0200, Thomas Zimmermann wrote: > Am 11.06.23 um 01:18 schrieb Javier Martinez Canillas: > > But I will be OK to drop the "solomon,ssd130?fb-i2c" compatible strings > > from the DRM driver and only match against the new "solomon,ssd130?-i2c" > > compatible string

Re: [PATCH 5/9] drm: atmel-hlcdc: add compatible string check for XLCDC and HLCDC

2023-06-13 Thread Conor Dooley
On Tue, Jun 13, 2023 at 12:34:22PM +0530, Manikandan Muralidharan wrote: > From: Durai Manickam KR > > Add compatible string check to differentiate XLCDC and HLCDC code > within the atmel-hlcdc driver files. > > Signed-off-by: Durai Manickam KR > Signed-off-by: Manikandan Muralidharan > --- >

Re: [PATCH 6/9] drm: atmel_hlcdc: Add support for XLCDC in atmel LCD driver

2023-06-13 Thread Conor Dooley
On Tue, Jun 13, 2023 at 12:34:23PM +0530, Manikandan Muralidharan wrote: > - XLCDC in SAM9X7 has different sets of registers and additional > configuration bits when compared to previous HLCDC IP. Read/write > operation on the controller registers is now separated using the > XLCDC status flag. >

Re: [PATCH 1/9] dt-bindings: mfd: Add bindings for SAM9X7 LCD controller

2023-06-13 Thread Conor Dooley
the exact letters!)? If so, Acked-by: Conor Dooley Cheers, Conor. > > Signed-off-by: Manikandan Muralidharan > --- > Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/

Re: [PATCH 1/9] dt-bindings: mfd: Add bindings for SAM9X7 LCD controller

2023-06-13 Thread Conor Dooley
On Tue, Jun 13, 2023 at 08:17:13PM +0200, Krzysztof Kozlowski wrote: > On 13/06/2023 09:04, Manikandan Muralidharan wrote: > > Add new compatible string for the XLCD controller on SAM9X7 SoC. > > > > Signed-off-by: Manikandan Muralidharan > > --- > > Documentation/devicetree/bindings/mfd/atmel-h

Re: [PATCH] dt-bindings: backlight: kinetic,ktz8866: Add missing type for "current-num-sinks"

2023-06-13 Thread Conor Dooley
On Tue, Jun 13, 2023 at 02:10:22PM -0600, Rob Herring wrote: > "current-num-sinks" is missing a type, add it. > > Signed-off-by: Rob Herring Reviewed-by: Conor Dooley Cheers, Conor. signature.asc Description: PGP signature

Re: [PATCH] dt-bindings: display: Add missing property types

2023-06-13 Thread Conor Dooley
On Tue, Jun 13, 2023 at 02:11:14PM -0600, Rob Herring wrote: > A couple of display bridge properties are missing a type definition. Add > the types to them. > > Signed-off-by: Rob Herring Reviewed-by: Conor Dooley Cheers, Conor. signature.asc Description: PGP signature

Re: [PATCH 1/6] dt-bindings: trivial-devices: Remove national,lm75

2023-08-10 Thread Conor Dooley
hema: Documentation/devicetree/bindings/trivial-devices.yaml > > Signed-off-by: Alexander Stein Acked-by: Conor Dooley Thanks, Conor. > --- > Documentation/devicetree/bindings/trivial-devices.yaml | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/Documentation/devicetr

Re: [PATCH 0/6] imx6q related DT binding fixes

2023-08-10 Thread Conor Dooley
can be picked up > individually. These all seem fine to me, with the last one being really a question for those with knowledge of the hardware. Acked-by: Conor Dooley signature.asc Description: PGP signature

Re: [PATCH v2 1/3] dt-bindings: vendor-prefixes: add ShenZhen New Display Co.

2023-08-10 Thread Conor Dooley
On Thu, Aug 10, 2023 at 04:41:14PM +0200, Luca Ceresoli wrote: > ShenZhen New Display Co., Limited is the manufacturer of the > NDS040480800-V3 LCD panel according the datasheet. > > Signed-off-by: Luca Ceresoli Acked-by: Conor Dooley signature.asc Description: PGP signature

Re: [PATCH V2 1/2] dt-bindings: display: newvision,nv3051d: Add Anbernic 351V Support

2023-08-10 Thread Conor Dooley
On Wed, Aug 09, 2023 at 10:39:40AM -0500, Chris Morgan wrote: > From: Chris Morgan > > Document the Anbernic RG351V panel, which appears to be identical to > the panel used in their 353 series except for in inclusion of an > additional DSI format flag. Sure? Acked-by: Conor

Re: [PATCH] dt-bindings: mxsfb: Exclude i.MX8MQ from power-domains requirement

2023-08-10 Thread Conor Dooley
On Wed, Aug 02, 2023 at 11:51:17AM +0200, Guido Günther wrote: > Hi, > On Sun, Jul 30, 2023 at 09:41:20PM +0300, David Heidelberg wrote: > > i.MX8MQ uses as secondary compatible fsl,imx6sx-lcdif, which triggers > > requirement of power-domains, thou it's not required. > > > > Fixes: f62678a77d58 (

Re: [PATCH] dt-bindings: mxsfb: Exclude i.MX8MQ from power-domains requirement

2023-08-11 Thread Conor Dooley
On Thu, Aug 10, 2023 at 08:30:21PM +0100, Conor Dooley wrote: > On Wed, Aug 02, 2023 at 11:51:17AM +0200, Guido Günther wrote: > > Hi, > > On Sun, Jul 30, 2023 at 09:41:20PM +0300, David Heidelberg wrote: > > > i.MX8MQ uses as secondary compatible fsl,imx6sx-lcdif, which tr

Re: [PATCH 1/2] dt-bindings: display/lvds-codec: add ti,sn65lvds94

2023-08-27 Thread Conor Dooley
On Sun, Aug 27, 2023 at 12:54:28AM +0300, Dmitry Baryshkov wrote: > Add compatible strings for TI sn65lvds94, LVDS serdes receiver. > > Signed-off-by: Dmitry Baryshkov Acked-by: Conor Dooley Thanks, Conor. > --- > Documentation/devicetree/bindings/display/bridge/lvds-codec.

Re: [PATCH 1/3] dt-bindings: display: panel: add startek kd070fhfid015 support

2023-07-11 Thread Conor Dooley
: > + compatible: > +const: startek,kd070fhfid015 > + > + dcdc-gpios: true > + > + height-mm: > +const: 151 Are height-mm and width-mm useful if they are always a fixed value? Otherwise, it looks grand to me, Reviewed-by: Conor Dooley Cheers, Conor. > + >

Re: [PATCH v4 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

2023-07-15 Thread Conor Dooley
Hey Sarah, Your series does not appear to be threaded. `git send-email` can be passed, for example, a directory containing a whole series & will set the correct in-reply-to headers so that the series is in a single thread. On Fri, Jul 14, 2023 at 03:25:26PM +0100, Sarah Walker wrote: > Add the de

Re: [PATCH 2/2] dt-bindings: display: add rotation property to sitronix,st7789v

2023-07-18 Thread Conor Dooley
On Tue, Jul 18, 2023 at 05:12:46PM +0200, Michael Riesch wrote: > The sitronix-st7789v driver now considers the rotation property. > Add the property to the documentation. > > Signed-off-by: Michael Riesch Acked-by: Conor Dooley Thanks, Conor. > --- > Documentation/d

Re: [PATCH 1/4] dt-bindings: vendor-prefixes: add jasonic

2023-07-18 Thread Conor Dooley
On Tue, Jul 18, 2023 at 05:31:50PM +0200, Michael Riesch wrote: > Add vendor prefix for Jasonic Technology Ltd., a manufacturer > of custom LCD panels. > > Signed-off-by: Michael Riesch Acked-by: Conor Dooley Thanks, Conor. > --- > Documentation/devicetree/bindings/vendor

Re: [PATCH 2/4] dt-bindings: display: st7789v: add jasonic jt240mhqs-hwt-ek-e3 display

2023-07-18 Thread Conor Dooley
lay/panel/sitronix,st7789v.yaml > +++ b/Documentation/devicetree/bindings/display/panel/sitronix,st7789v.yaml > @@ -18,6 +18,7 @@ properties: > enum: >- edt,et028013dma >- inanbo,t28cp45tn89-v17 > + - jasonic,jt240mhqs-hwt-ek-e3 Acked-by: Conor Dooley Cheer

Re: [PATCH v4 3/4] dt-bindings: display: rockchip: Add schema for RK3588 HDMI TX Controller

2024-08-20 Thread Conor Dooley
On Tue, Aug 20, 2024 at 03:37:44PM +0300, Cristian Ciocaltea wrote: > On 8/19/24 7:53 PM, Conor Dooley wrote: > > On Mon, Aug 19, 2024 at 01:29:30AM +0300, Cristian Ciocaltea wrote: > >> Rockchip RK3588 SoC integrates the Synopsys DesignWare HDMI 2.1 > >> Quad-

Re: [PATCH v4 3/4] dt-bindings: display: rockchip: Add schema for RK3588 HDMI TX Controller

2024-08-21 Thread Conor Dooley
On Tue, Aug 20, 2024 at 11:12:45PM +0300, Cristian Ciocaltea wrote: > On 8/20/24 7:14 PM, Conor Dooley wrote: > > On Tue, Aug 20, 2024 at 03:37:44PM +0300, Cristian Ciocaltea wrote: > >> On 8/19/24 7:53 PM, Conor Dooley wrote: > >>> On Mon, Aug 19, 2024 at 01:29:

  1   2   3   4   5   >