Re: [PATCH][next] drm/mgag200: Fix uninitialized variable delta

On 17/08/2021 19:22, Thomas Zimmermann wrote: > Hi > > Am 17.08.21 um 18:32 schrieb Colin King: >> From: Colin Ian King >> >> The variable delta is not initialized and this will cause unexpected >> behaviour with the comparison of tmpdelta < delta. Fix this

Re: [PATCH] drm/bridge/tc358767: make the array ext_div static const, makes object smaller

On 19/08/2021 14:51, Joe Perches wrote: > On Thu, 2021-08-19 at 14:38 +0100, Colin King wrote: >> From: Colin Ian King >> >> Don't populate the array ext_div on the stack but instead it >> static const. Makes the object code smaller by 118 bytes: >> >&g

Re: [PATCH] drm/bridge/tc358767: make the array ext_div static const, makes object smaller

On 19/08/2021 15:40, Joe Perches wrote: > On Thu, 2021-08-19 at 14:54 +0100, Colin Ian King wrote: >> On 19/08/2021 14:51, Joe Perches wrote: >>> On Thu, 2021-08-19 at 14:38 +0100, Colin King wrote: >>>> From: Colin Ian King >>>> >>>> Don&#x

re: drm/ttm: switch to per device LRU lock

Hi, Static analysis with Coverity in linux-next has detected an issue in drivers/gpu/drm/ttm/ttm_bo.c with the follow commit: commit a1f091f8ef2b680a5184db065527612247cb4cae Author: Christian König Date: Tue Oct 6 17:26:42 2020 +0200 drm/ttm: switch to per device LRU lock Instead of

Re: [PATCH] drm/ttm: fix invalid NULL deref

On 25/03/2021 15:27, Christian König wrote: > The BO might be NULL in this function, use the bdev directly. > > Signed-off-by: Christian König > Reported-by: Colin Ian King > Fixes: a1f091f8ef2b ("drm/ttm: switch to per device LRU lock") > --- > drivers/gpu/d

re: drm/i915/selftests: Prepare gtt tests for obj->mm.lock removal

Hi, Static analysis with Coverity on Linux-next has detected a potential issue with the following commit: commit 480ae79537b28f30ef6e07b7de69a9ae2599daa7 Author: Maarten Lankhorst Date: Tue Mar 23 16:50:49 2021 +0100 drm/i915/selftests: Prepare gtt tests for obj->mm.lock removal The ana

Re: [PATCH][next] drm/amdgpu: Add missing BOOTUP_DEFAULT to profile_name[]

On 12/01/2021 10:07, Dan Carpenter wrote: > On Mon, Jan 11, 2021 at 11:46:38AM +, Colin King wrote: >> From: Colin Ian King >> >> A recent change added a new BOOTUP_DEFAULT power profile mode >> to the PP_SMC_POWER_PROFILE enum but omitted updating the >>

Re: [PATCH][next] drm/amdgpu: Add missing BOOTUP_DEFAULT to profile_name[]

On 15/01/2021 10:07, Christophe JAILLET wrote: > Le 15/01/2021 à 10:37, Colin Ian King a écrit : >> On 12/01/2021 10:07, Dan Carpenter wrote: >>> On Mon, Jan 11, 2021 at 11:46:38AM +, Colin King wrote: >>>> From: Colin Ian King >>>> >>>

re: drm/amd/display: Implement dmub trace event

Hi, Static analysis on linux-next wit Coverity has found a potential null pointer dereference in commit: commit 70732504c53b2d3aae2cebc457515a304672d5bb Author: Yongqiang Sun Date: Fri Feb 19 14:50:23 2021 -0500 drm/amd/display: Implement dmub trace event The analysis is as follows: 400

Re: [PATCH][next] drm/vmwgfx: Fix memory leak of object fifo on error return

On 14/05/2021 15:30, Dan Carpenter wrote: > On Wed, May 12, 2021 at 08:56:09PM +0100, Colin King wrote: >> From: Colin Ian King >> >> In the case where fifo->static_buffer fails to be allocated the >> error return path neglects to kfree the fifo object. Fix this by

re: drm/amdgpu/acpi: unify ATCS handling (v2) [uninitialized variable error]

Hi, Static analysis on linux-next with Coverity has detected an issue in drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c with the following commit: commit c1c4d8efdddec8a0ccc8525b29740640bd652ce8 Author: Alex Deucher Date: Wed May 19 15:47:42 2021 -0400 drm/amdgpu/acpi: unify ATCS handling (v2)

re: video: fbdev: sis: Fix set but not used warnings in init.c

Hi, Static analysis on linux-next with Coverity had detected a minor issue in the following commit: commit 2a74e8682a39d00e04ca278459ae7d7ecbdfb394 Author: Sam Ravnborg Date: Sat Nov 28 23:40:55 2020 +0100 video: fbdev: sis: Fix set but not used warnings in init.c The analysis is as fol

re: drm/amdkfd: implement counters for vm fault and migration

Hi, Static analysis with Coverity on linux-next has found a potential null pointer dereference in function svm_range_restore_pages in drivers/gpu/drm/amd/amdkfd/kfd_svm.c from the following commit: commit d4ebc2007040a0aff01bfe1b194085d3867328fd Author: Philip Yang Date: Tue Jun 22 00:12:32 20

re: drm/i915/ttm Initialize the ttm device and memory managers

Hi, Static analysis with Coverity on linux-next has found a potential issue in drivers/gpu/drm/i915/selftests/intel_memory_region.c in function igt_mock_fill - the problematic commit is as follows: commit d148738923fdb5077089e48ec1e6008100d0 Author: Thomas Hellström Date: Wed Jun 2 10:38:0

Re: [PATCH][next] drm/kmb: fix array out-of-bounds writes to kmb->plane_status[]

On 13/11/2020 14:55, Sam Ravnborg wrote: > Hi Colin. > > On Fri, Nov 13, 2020 at 12:01:21PM +, Colin King wrote: >> From: Colin Ian King >> >> Writes to elements in the kmb->plane_status array in function >> kmb_plane_atomic_disable are overrunning the a

Re: [PATCH][next] drm/atomic: avoid null pointer dereference on pointer crtc

On 16/11/2020 11:08, Simon Ser wrote: > On Monday, November 16, 2020 12:03 PM, Colin King > wrote: > >> From: Colin Ian King colin.k...@canonical.com >> >> Since moving to the new debug helper functions we now have a debug message >> that dereferences crtc to

Re: [PATCH][next] drm/kmb: fix array out-of-bounds writes to kmb->plane_status[]

On 16/11/2020 16:53, Chrisanthus, Anitha wrote: > Hi Sam and Colin, > >> -Original Message- >> From: Sam Ravnborg >> Sent: Friday, November 13, 2020 10:02 AM >> To: Colin Ian King >> Cc: Chrisanthus, Anitha ; Dea, Edmund J >> ; D

[PATCH] video: fbdev: kyro: make read-only array ODValues static const

Don't populate the read-only array ODValues on the stack but instead make it static const. Also makes the object code a little smaller. Signed-off-by: Colin Ian King --- drivers/video/fbdev/kyro/STG4000InitDevice.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dr

[PATCH] drm/amdgpu: Fix spelling mistake "regiser" -> "register"

There is a spelling mistake in a dev_error error message. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c

[PATCH] drm/i915/reg: Fix spelling mistake "Unsupport" -> "Unsupported"

There is a spelling mistake in a gvt_vgpu_err error message. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/i915/gvt/handlers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gvt/handlers.c b/drivers/gpu/drm/i915/gvt/handlers.c index

[PATCH] drm/nouveau: Fix spelling mistake "endianess" -> "endianness"

There is a spelling mistake in a nvdev_error error message. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/nouveau/nvkm/engine/device/base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/device/base.c b/drivers/gpu/drm

[PATCH] drm/i915: make a handful of read-only arrays static const

Don't populate the read-only arrays on the stack but instead make them static const. Also makes the object code a little smaller. Reformat the statements to clear up checkpatch warning. Signed-off-by: Colin Ian King --- drivers/gpu/drm/i915/display/intel_vdsc.c | 16 1

[PATCH][V2] drm/i915: make a handful of read-only arrays static const

Don't populate the read-only arrays on the stack but instead make them static const and signed 8 bit ints. Also makes the object code a little smaller. Reformat the statements to clear up checkpatch warning. Signed-off-by: Colin Ian King --- V2: Make arrays signed 8 bit integers as requ

[PATCH][next] drm/amdgpu: Fix missing assignment to variable r

/amdgpu_benchmark.c:168:7: warning: variable 'r' is uninitialized when used here [-Wuninitialized] Fixes: 9645c9c9fb15 ("drm/amdgpu: plumb error handling though amdgpu_benchmark()") Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/amdgpu/amdgpu_benchmark.c | 2 +- 1 file change

[PATCH][next] drm: ssd130x: remove redundant initialization of pointer mode

ization is never read [deadcode.DeadStores] Signed-off-by: Colin Ian King --- drivers/gpu/drm/solomon/ssd130x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/solomon/ssd130x.c b/drivers/gpu/drm/solomon/ssd130x.c index 92c1902f53e4..ce4dc20412e0 100644 ---

[PATCH] drm/rockchip: remove redundant assignment to pointer connector

; is never read [deadcode.DeadStores] Signed-off-by: Colin Ian King --- drivers/gpu/drm/rockchip/rockchip_rgb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_rgb.c b/drivers/gpu/drm/rockchip/rockchip_rgb.c index 2494b079489d..92a727931a49 100644 --- a/drive

[PATCH] drm/i915/dpll: make read-only array div1_vals static const

Don't populate the read-only array div1_vals on the stack but instead make it static const. Also makes the object code a little smaller. Signed-off-by: Colin Ian King --- drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dr

NAK: [PATCH] drm/msm/mdp4: Fix potential integer overflow on 32 bit multiply

On 29/09/2021 12:08, Colin King wrote: From: Colin Ian King In the case where clock is 2147485 or greater the 32 bit multiplication by 1000 will cause an integer overflow. Fix this by making the constant 1000 a long to ensure a long multiply occurs to avoid the overflow before assigning the

[PATCH] drm/radeon: remove redundant assignment to reg

' is never read [deadcode.DeadStores] Signed-off-by: Colin Ian King --- drivers/gpu/drm/radeon/radeon_object.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c index 56ede9d63b12..87536d205593 100644 --- a/dr

[PATCH] drm/i915/selftests: make static read-only array page_count const

The static array page_count is read-only so it make sense to make it const. Signed-off-by: Colin Ian King --- drivers/gpu/drm/i915/selftests/scatterlist.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/selftests/scatterlist.c b/drivers/gpu/drm/i915

[PATCH] drm/imx: make static read-only array channel_offsets const

The static array channel_offsets is read-only so it make sense to make it const. Signed-off-by: Colin Ian King --- drivers/gpu/ipu-v3/ipu-dc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/ipu-v3/ipu-dc.c b/drivers/gpu/ipu-v3/ipu-dc.c index ca96b235491a

[PATCH][next] drm/i915/guc: fix spelling mistake "notificaion" -> "notification"

There is a spelling mistake in a drm_err error message. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c b/drivers/gpu/drm/i915/gt/uc

[PATCH][next] drm/amdgpu: Fix a couple of spelling mistakes

There are two spelling mistakes in dev_err messages. Fix them. Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c

[PATCH][next] drm/amd/display: fix spelling mistake: synatpics -> synaptics

There are quite a few spelling mistakes in various function names and error messages. Fix these. Signed-off-by: Colin Ian King --- .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 32 +-- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/amd/display

[PATCH] drm/v3d: pass null pointers using NULL

There are a couple of calls that are passing null pointers as integer zeros rather than NULL. Fix this by using NULL instead. Fixes: 07c2a41658c4 ("drm/v3d: alloc and init job in one shot") Signed-off-by: Colin Ian King --- drivers/gpu/drm/v3d/v3d_gem.c | 4 ++-- 1 file changed, 2

[PATCH] video: fbdev: mb862xx: remove redundant assignment to pointer ptr

The pointer ptr is being assigned a value that is never read. The pointer is being re-assigned later in a loop. The assignment is redundant and can be removed. Signed-off-by: Colin Ian King --- drivers/video/fbdev/mb862xx/mb862xxfb_accel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH] video: fbdev: s3c-fb: remove redundant initialization of pointer bufs

ialization is never read [deadcode.DeadStores] void __iomem *buf = regs; Signed-off-by: Colin Ian King --- drivers/video/fbdev/s3c-fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/s3c-fb.c b/drivers/video/fbdev/s3c-fb.c index 3b134e1bbc38..68

[PATCH] video: fbdev: asiliantfb: remove redundant assignment to variable Ftarget

Variable Ftarget is being initialized with a value that is never read, it is being re-assigned a different value a little later on. The assignment is redundant and can be removed. Signed-off-by: Colin Ian King --- drivers/video/fbdev/asiliantfb.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH] i915: make array flex_regs static const

Don't populate the read-only array flex_regs on the stack but instead it static const. Also makes the object code a little smaller. Signed-off-by: Colin Ian King --- drivers/gpu/drm/i915/i915_perf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm

[PATCH] drm/bridge: adv7533: make array clock_div_by_lanes static const

Don't populate the read-only array clock_div_by_lanes on the stack but instead it static const. Also makes the object code a little smaller. Signed-off-by: Colin Ian King --- drivers/gpu/drm/bridge/adv7511/adv7533.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driver

[PATCH] fbdev: aty128fb: make some arrays static const

Don't populate some read-only arrays on the stack but instead make them static const. Also makes the object code a little smaller. Re-format one of the declarations. Add spaces between commas and make PostDivSet unsigned int to fixup checkpatch warnings. Signed-off-by: Colin Ian

[PATCH][RESEND] i915: make array flex_regs static const

Don't populate the read-only array flex_regs on the stack but instead it static const. Also makes the object code a little smaller. Signed-off-by: Colin Ian King --- RESEND: Use correct e-mail address for sign-off and From: in e-mail. --- drivers/gpu/drm/i915/i915_perf.c | 2 +- 1

[PATCH] drm/vc4: remove redundant assignment of variable size

PAGE_SIZE); Signed-off-by: Colin Ian King --- drivers/gpu/drm/vc4/vc4_bo.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_bo.c b/drivers/gpu/drm/vc4/vc4_bo.c index 6d1281a343e9..e451cc5bcfac 100644 --- a/drivers/gpu/drm/vc4/vc4_bo.c +++ b/drivers/gpu/drm/vc4/vc4_b

Re: [PATCH] drm/nouveau/bios/ramcfg: fix missing parentheses when calculating RON

ping? On 25/11/2018 17:09, Colin King wrote: > From: Colin Ian King > > Currently, the expression for calculating RON is always going to result > in zero no matter the value of ram->mr[1] because the ! operator has > higher precedence than the shift >> operator

Re: [PATCH] drm/nouveau/bios/dp: make array vsoff static, shrinks object size

ping? On 04/09/2018 16:23, Colin King wrote: > From: Colin Ian King > > Don't populate the array vsoff on the stack but instead make it > static. Makes the object code smaller by 67 bytes: > > Before: >text data bss dec hex filename >

Re: [PATCH] drm/nouveau/pmu: don't print reply values if exec is false

ping? On 19/12/2018 15:29, Colin King wrote: > From: Colin Ian King > > Currently the uninitialized values in the array reply are printed out > when exec is false and nvkm_pmu_send has not updated the array. Avoid > confusion by only dumping out these values if they have been act

Re: [PATCH][next] drm/i915: fix uninitialized variable 'subslice_mask'

On 29/05/2019 16:04, Jani Nikula wrote: > On Wed, 29 May 2019, Colin King wrote: >> From: Colin Ian King >> >> Currently subslice_mask is not initialized and so data is being >> bit-wise or'd into a garbage value. Fix this by inintializing >> subslice_

Re: [PATCH][next] drm/bridge: sii902x: fix comparision of u32 with less than zero

On 07/06/2019 10:41, Andrzej Hajda wrote: > On 03.06.2019 16:21, Colin King wrote: >> From: Colin Ian King >> >> The less than check for the variable num_lanes is always going to be >> false because the variable is a u32. Fix this by making num_lanes an >> int

re: drm: Add helpers to kick off self refresh mode in drivers

Hi, Static analysis with Coverity has picked up two potential issues with the commit in linux-next: commit 1452c25b0e60278820f3d2155c65f1bfcce5ee79 Author: Sean Paul Date: Wed Jun 12 10:50:19 2019 -0400 drm: Add helpers to kick off self refresh mode in drivers 1. There is a potential nul

Re: [PATCH] drm/vmwgfx: fix memory leak when too many retries have occurred

t; On Fri, 2019-06-21 at 23:35 +0100, Colin King wrote: >> From: Colin Ian King >> >> Currently when too many retries have occurred there is a memory >> leak on the allocation for reply on the error return path. Fix >> this by kfree'ing reply before returning. &

Re: [PATCH][next[ drm/amd/display: fix a couple of spelling mistakes

On 26/06/2019 14:25, Daniel Stone wrote: > Hi Colin, > > On Wed, 26 Jun 2019 at 14:24, Colin King wrote: >> There are a couple of spelling mistakes in dm_error messages and >> a comment. Fix these. > > Whilst there, you might fix the '[next[' typo in the commit message. Ugh, fickle fingers. May

Re: [PATCH][next] drm/amdgpu/psp: fix incorrect logic when checking asic_type

On 04/07/2019 17:22, walter harms wrote: > > > Am 04.07.2019 16:23, schrieb Colin King: >> From: Colin Ian King >> >> Currently the check of the asic_type is always returning true because >> of the use of ||. Fix this by using && instead. Also b

[PATCH] drm/v3d: Fix null pointer dereference of pointer perfmon

-by: Colin Ian King --- drivers/gpu/drm/v3d/v3d_perfmon.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/v3d/v3d_perfmon.c b/drivers/gpu/drm/v3d/v3d_perfmon.c index 0288ef063513..f6a88abccc7d 100644 --- a/drivers/gpu/drm/v3d/v3d_perfmon.c +++ b/drivers/g

[PATCH][next] drm/rockchip: Fix spelling mistake "aligened" -> "aligned"

There is a spelling mistake in a drm_err message. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2

[PATCH][next] drm/rockchip: Fix spelling mistake "aligened" -> "aligned"

There is a spelling mistake in a drm_err message. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2

[PATCH][next] drm/amdgpu/display: Fix spelling mistake "supporing" -> "supporting"

There is a spelling mistake in a dml_print message. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c b

[PATCH][next] drm/amdkfd: Fix spelling mistake "mechanim" -> "mechanism"

There is a spelling mistake in a pr_debug message. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c b/drivers/gpu/drm/amd/amdgpu

[PATCH][next] drm/i915/guc: Fix spelling mistake "heatbeat" -> "heartbeat"

There is a spelling mistake in a drm_err message. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/i915/gt/uc/selftest_guc_hangcheck.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/uc/selftest_guc_hangcheck.c b/drivers/gpu/drm/i915/gt/uc

[PATCH] fbdev: remove redundant initialization to variable identical

during its initialization is never read [deadcode.DeadStores] Signed-off-by: Colin Ian King --- drivers/video/fbdev/udlfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/udlfb.c b/drivers/video/fbdev/udlfb.c index c863244ef12c..216d49c9d47e 100644 --- a/dri

[PATCH][next] drm/amdkfd: Fix spelling mistake "detroyed" -> "destroyed"

There is a spelling mistake in a pr_debug message. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/amdkfd/kfd_migrate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c b/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c index

[PATCH] drm: Remove redundant assignments to variable count

The variable count is assigned a value but it is never read. The assignment is redundant and can be removed. Cleans up two clang scan build warnings: warning: Value stored to 'count' is never read [deadcode.DeadStores] Signed-off-by: Colin Ian King --- drivers/gpu/drm/drm_crtc_he

[PATCH] phy: phy-mtk-dp: make array driving_params static const

Don't populate the read-only array driving_params on the stack but instead make it static const. Also makes the object code a little smaller. Signed-off-by: Colin Ian King --- drivers/phy/mediatek/phy-mtk-dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driver

[PATCH][next] drm/amd/display: Fix spelling mistake "supporing" -> "supporting"

There is a spelling mistake in a dml_print message. Fix it. Signed-off-by: Colin Ian King --- .../gpu/drm/amd/display/dc/dml/dcn314/display_mode_vba_314.c| 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_mode_vba_314.c b

[PATCH] drm: flip-work: rename commited -> committed

There is a spelling mistake in the list head variable, rename it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/drm_flip_work.c | 10 +- include/drm/drm_flip_work.h | 6 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/drm_flip_work.c b

[PATCH][next] drm/i915/gt: remove redundant pointer sseu

Pointer sseu is being assigned a value that is never read. The pointer is redundant and can be removed. Cleans up clang scan warning: drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c:300:2: warning: Value stored to 'sseu' is never read [deadcode.DeadStores] Signed-off-by: Coli

[PATCH] drm/i915/userptr: remove redundation assignment to variable ret

stored to 'ret' is used in the enclosing expression, the value is never actually read from 'ret' [deadcode.DeadStores] Signed-off-by: Colin Ian King --- drivers/gpu/drm/i915/gem/i915_gem_userptr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driv

Re: [PATCH][next] dma-buf: heaps: remove redundant assignment to variable ret

On 30/10/2019 17:21, John Stultz wrote: > On Wed, Oct 30, 2019 at 8:45 AM Andrew F. Davis wrote: >> >> On 10/30/19 11:02 AM, Colin King wrote: >>> From: Colin Ian King >>> >>> The variable ret is being assigned with a value that is never >>>

re: drm/i915: Use the i915_device name for identifying our, request fences

Hi, Static analysis with Coverity has picked up an issue with the following commit: commit 65c29dbb19b2451990c5c477fef7ada3b8218f05 Author: Chris Wilson Date: Wed Dec 11 15:02:04 2019 + drm/i915: Use the i915_device name for identifying our request fences In source drivers/gpu/drm/i9

Re: drm/i915: Use the i915_device name for identifying our, request fences

On 12/12/2019 20:38, Chris Wilson wrote: > Quoting Colin Ian King (2019-12-12 19:53:33) >> Hi, >> >> Static analysis with Coverity has picked up an issue with the following >> commit: >> >> commit 65c29dbb19b2451990c5c477fef7ada3b8218f05 >> Author: Chri

re: drm/amd/display: Add HDCP module - static analysis bug report

Hi, Static analysis with Coverity has detected a potential issue with function validate_bksv in drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c with recent commit: commit ed9d8e2bcb003ec94658cafe9b1bb3960e2139ec Author: Bhawanpreet Lakha Date: Tue Aug 6 17:52:01 2019 -0400 drm/

Re: [PATCH][next] drm/komeda: remove redundant assignment to pointer disable_done

On 04/10/2019 20:27, Liviu Dudau wrote: > On Fri, Oct 04, 2019 at 05:21:56PM +0100, Colin King wrote: >> From: Colin Ian King >> >> The pointer disable_done is being initialized with a value that >> is never read and is being re-assigned a little later on. The >>

Re: [PATCH] drm/amdkfd: add missing void argument to function kgd2kfd_init

On 05/10/2019 19:10, Randy Dunlap wrote: > On 10/5/19 10:58 AM, Colin King wrote: >> From: Colin Ian King >> >> Function kgd2kfd_init is missing a void argument, add it >> to clean up the non-ANSI function declaration. >> >> Signed-off-by: Colin Ian King &

Re: [PATCH][next] drm/v3d: fix double free of bin

On 24/10/2019 13:38, Daniel Vetter wrote: > On Thu, Oct 24, 2019 at 11:48:01AM +0100, Colin King wrote: >> From: Colin Ian King >> >> Two different fixes have addressed the same memory leak of bin and >> this now causes a double free of bin. While the individual me

NAK: [PATCH][next] drm/tidss: fix spelling mistake "bufer" -> "buffer"

On 24/02/2020 15:15, Colin King wrote: > From: Colin Ian King > > There is a spelling mistake in a dev_dbg message. Fix it. > > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/tidss/tidss_dispc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [PATCH][V2] backlight: sky81452: insure while loop does not allow negative array indexing

On 27/02/2020 11:46, Daniel Thompson wrote: > On Wed, Feb 26, 2020 at 07:58:26PM +, Colin King wrote: >> From: Colin Ian King >> >> In the unlikely event that num_entry is zero, the while loop >> pre-decrements num_entry to cause negative array indexing into the &g

re: drm/amd/display: make PSR static screen entry within 30 ms

Hi, Static analysis with Coverity has detected a division by zero in the following commit: commit 5b5abe9526073ccbf3032d27b5864520829cdd9c Author: Anthony Koo Date: Mon Dec 9 17:26:34 2019 -0500 drm/amd/display: make PSR static screen entry within 30 ms Specifically: unsigned int

Re: [PATCH][next] drm/dp_mst: fix multiple frees of tx->bytes

On 20/11/2019 18:59, Lyude Paul wrote: > Heh, surprised I missed this one! > > Reviewed-by: Lyude Paul > > Do you need me to push this to drm-misc, or do you have commit rights already I have no commit rights. > > On Wed, 2019-11-20 at 17:35 +, Colin King wrote: &g

Re: [PATCH] drm/amdgpu/powerplay: fix spelling mistake "unsuported" -> "unsupported"

[drm-next] On 13/08/2019 11:33, Colin King wrote: > From: Colin Ian King > > There is a spelling mistake in a pr_err error message. Fix it. Also > add a space after a comma to clean up a checkpatch warning. > > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/a

Re: [PATCH] drm/vmwgfx: Fix double free in vmw_recv_msg()

On 15/08/2019 09:30, Dan Carpenter wrote: > We recently added a kfree() after the end of the loop: > > if (retries == RETRIES) { > kfree(reply); > return -EINVAL; > } > > There are two problems. First the test is wrong and because retries > equals RETRIES

Computation of return value being discarded in get_cpu_power() in drivers/platform/x86/intel_ips.c

Hi, I was reviewing some old unassigned variable warnings from static analysis by Coverity and found an issue introduced with the following commit: commit aa7ffc01d254c91a36bf854d57a14049c6134c72 Author: Jesse Barnes Date: Fri May 14 15:41:14 2010 -0700 x86 platform driver: intelligent po

gma500: issue with continue statement not doing anything useful

Hi, Static analysis with Coverity has found a rather old issue in drivers/gpu/drm/gma500/oaktrail_crtc.c with the following commit: commit 9bd81acdb648509dbbc32d4da0477c9fae0d6a73 Author: Patrik Jakobsson Date: Mon Dec 19 21:41:33 2011 + gma500: Convert Oaktrail to work with new outpu

Re: gma500: issue with continue statement not doing anything useful

On 18/06/2021 12:19, Patrik Jakobsson wrote: > On Fri, Jun 18, 2021 at 12:26 PM Colin Ian King > wrote: >> >> Hi, > > Hi Colin > >> >> Static analysis with Coverity has found a rather old issue in >> drivers/gpu/drm/gma500/oaktrail_crtc.c with t

[PATCH][next] i915/gvt: Fix spelling mistake "vender" -> "vendor"

There is a spelling mistake in a literal string. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/i915/gvt/firmware.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gvt/firmware.c b/drivers/gpu/drm/i915/gvt/firmware.c index dce93738e98a

[PATCH][next] drm/amd/display: Fix spelling mistakes of function name in error message

The function name is being reported as dc_link_contruct when it is actually dc_link_construct_phy. Fix this by using %s and the __func__ for the function name. Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/display/dc/link/link_factory.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH][next] habanalabs: Fix spelling mistake "offest" -> "offset"

There is a spelling mistake in a dev_err message. Fix it. Signed-off-by: Colin Ian King --- drivers/accel/habanalabs/common/command_submission.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/accel/habanalabs/common/command_submission.c b/drivers/accel/habanalabs

[PATCH][next] drm/sti: Fix spelling mistake "top_cmd_offest" -> "top_cmd_offset"

There is a spelling mistake in a variable name. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/sti/sti_hqvdp.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/sti/sti_hqvdp.c b/drivers/gpu/drm/sti/sti_hqvdp.c index 02b77279f6e4

[PATCH][next] accel/ivpu: Fix spelling mistake "tansition" -> "transition"

There are spelling mistakes in two ivpu_err error messages. Fix them. Signed-off-by: Colin Ian King --- drivers/accel/ivpu/ivpu_hw_mtl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/accel/ivpu/ivpu_hw_mtl.c b/drivers/accel/ivpu/ivpu_hw_mtl.c index b59b1f472b40

[PATCH] drm/i915/gem: remove redundant assignments to variable ret

-build warnings: warning: Although the value stored to 'ret' is used in the enclosing expression, the value is never actually read from 'ret' [deadcode.DeadStores] warning: Value stored to 'ret' is never read [deadcode.DeadStores] Signed-off-by: Colin Ian King

[PATCH] drm/i915/perf: remove redundant variable 'taken'

.DeadStores] Signed-off-by: Colin Ian King --- drivers/gpu/drm/i915/i915_perf.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c index 0defbb43ceea..15816df916c7 100644 --- a/drivers/gpu/drm/i915/i915_perf

[PATCH] drm/msm: Kconfig: Fix spelling mistake "throught" -> "through"

There is a spelling mistake in a Kconfig description. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/msm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig index 4e0cbd682725..3c9dfdb0b328 100644 --- a

[PATCH] drm/gma500: Fix spelling mistake "patter" -> "pattern"

There is a spelling mistake in a DRM_DEBUG_KMS message. Fix it. Also clean checkpatch warning on the overly long line and remove braces as the if statement is just one statement. Signed-off-by: Colin Ian King --- drivers/gpu/drm/gma500/cdv_intel_dp.c | 6 +++--- 1 file changed, 3 insertions

[PATCH] drm/i915: fix incorrect function name in comment block

The function name in the comment block for intel_vgpu_emulate_cfg_write is incorrect. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/i915/gvt/cfg_space.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gvt/cfg_space.c b/drivers/gpu/drm/i915

[PATCH] drm/qxl: remove variable num_relocs

The variable num_relocs is being incremented but it is never referenced, it is redundant and can be removed. Signed-off-by: Colin Ian King --- drivers/gpu/drm/qxl/qxl_ioctl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_ioctl.c b/drivers/gpu/drm

[PATCH] drm/vc4: Fix spelling mistake "mmaping" -> "mmapping"

There are a couple of spelling mistakes in DRM_DEBUG messages. Fix them. Signed-off-by: Colin Ian King --- drivers/gpu/drm/vc4/vc4_bo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_bo.c b/drivers/gpu/drm/vc4/vc4_bo.c index 231add8b8e12

[PATCH] video: fbdev: omapfb: remove redundant variable checksum

Variable checksum is being used to accumulate values however it is never read or used afterwards. It is redundant and can be removed. Signed-off-by: Colin Ian King --- drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/video/fbdev

[PATCH] drm/edid: make a couple of read-only arrays static const

Don't populate two read-only arrays on the stack but instead make them static const . Also makes the object code a little smaller. Signed-off-by: Colin Ian King --- drivers/gpu/drm/drm_edid.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_edi

[PATCH] drm: sti: Make array en_di static const

Don't populate the read-only array en_di on the stack but instead make it static. Also makes the object code a little smaller. Signed-off-by: Colin Ian King --- drivers/gpu/drm/sti/sti_hdmi.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/dr

[PATCH] drm/amd/display: Fix spelling mistake: "dram_clk_chanage" -> "dram_clk_change"

There is a spelling mistake in the struct field dram_clk_chanage. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubbub.c | 8 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 2 +- .../drm/amd/display/dc/dcn10

[PATCH][next] drm/amd/pm: Fix spelling mistake "aquire" -> "acquire"

There is a spelling mistake in the smu_i2c_bus_access prototype. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/pm/powerplay/inc/hwmgr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/pm/powerplay/inc/hwmgr.h b/drivers/gpu/drm/amd/pm

[PATCH][next] habanalabs: Fix spelling mistake "maped" -> "mapped"

There is a spelling mistake in a dev_err message. Fix it. Signed-off-by: Colin Ian King --- drivers/accel/habanalabs/common/memory_mgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/accel/habanalabs/common/memory_mgr.c b/drivers/accel/habanalabs/common

  1   2   3   >