Re: [PATCH v4 4/6] drm/sprd: add Unisoc's drm display controller driver

On Wed, 7 Apr 2021 at 18:45, Maxime Ripard wrote: > > Hi, > > Adding Jörg, Will and Robin, You forgot to add them actually :) I've added Robin and Joerg. > > On Wed, Mar 31, 2021 at 09:21:19AM +0800, Kevin Tang wrote: > > > > +static u32 check_mmu_isr(struct sprd_dpu *dpu, u32 reg_val) > > > > +

Re: [PATCH v5 4/6] drm/sprd: add Unisoc's drm display controller driver

layer position. > - Rebase to last drm misc branch. > > Cc: Orson Zhai > Cc: Chunyan Zhang > Signed-off-by: Kevin Tang > --- > drivers/gpu/drm/sprd/Kconfig| 1 + > drivers/gpu/drm/sprd/Makefile | 3 +- > drivers/gpu/drm/sprd/sprd_dpu.c | 939 +

Re: [PATCH] drm/sprd: Remove of_node_put() in sprd_crtc_init()

+ Kevin On Thu, 7 Jul 2022 at 11:25, Liang He wrote: > > As the new reference created in 'dpu->base.port' will be escaped out, > we need not to call of_node_put() again. > > Fixes: b07bcf34b6c9 ("drm/sprd: add Unisoc's drm display controller driver") > Signed-off-by: Liang He > --- > drivers/gp

Re: [PATCH v5 4/6] drm/sprd: add Unisoc's drm display controller driver

Hi Robin, On Tue, 18 May 2021 at 00:35, Robin Murphy wrote: > On 2021-05-17 10:27, Joerg Roedel wrote: > > On Fri, Apr 30, 2021 at 08:20:10PM +0800, Kevin Tang wrote: > >> Cc Robin & Joerg > > > > This is just some GPU internal MMU being used here, it seems. It doesn't > > use the IOMMU core co

Re: [PATCH v5 4/6] drm/sprd: add Unisoc's drm display controller driver

resend for switching to plain text mode. On Wed, 26 May 2021 at 15:59, Chunyan Zhang wrote: > > Hi Robin, > > On Tue, 18 May 2021 at 00:35, Robin Murphy wrote: >> >> On 2021-05-17 10:27, Joerg Roedel wrote: >> > On Fri, Apr 30, 2021 at 08:20:10PM +0800, Kevin Ta

Re: [PATCH v2 58/65] clk: sprd: composite: Switch to determine_rate

. > > Since we'll start mandating a determine_rate() implementation, let's > convert the round_rate() implementation to a determine_rate(), which > will also make the current behavior explicit. And if it was an > oversight, the clock behaviour can be adjusted later

Re: [PATCH] drm/sprd: remove redundant error logging

} > > ctx->irq = platform_get_irq(pdev, 0); > - if (ctx->irq < 0) { > - dev_err(dev, "failed to get dpu irq\n"); > + if (ctx->irq < 0) Thanks for the patch, it makes sense to me, so Acked-by: Chunyan Zhang >

Re: [PATCH RFC v7 1/6] dt-bindings: display: add Unisoc's drm master bindings

8, 2020 at 02:27:35PM +0800, Kevin Tang wrote: > > > > From: Kevin Tang > > > > > > > > The Unisoc DRM master device is a virtual device needed to list all > > > > DPU devices or other display interface nodes that comprise the > > > > graph

Re: [PATCH] drm:sprd: Correct left shift operator evaluating constant expression

1511468 Should we add a fixes tag, so that the patch can be backported to the stable branches. Apart from that, the patch looks good to me, so, Reviewed-by: Chunyan Zhang Thanks, Chunyan > > Signed-off-by: Karan Sanghavi > --- > Coverity Scan Message: > CID 151146

Re: [PATCH 06/12] drm/sprd: move to devm_platform_ioremap_resource() usage

gt; @@ > -struct resource *res; > ... > -res = platform_get_resource(pdev,...); > <... > -if (!res) { > -... > -} > ...> > -ioremap = devm_ioremap(...); > +ioremap = devm_platform_ioremap_resource(pdev,0); > > Cc: Chunyan Zhang > Cc: Dmitr

Re: [PATCH RESEND 06/12] drm/sprd: move to devm_platform_ioremap_resource() usage

gt; @@ > -struct resource *res; > ... > -res = platform_get_resource(pdev,...); > <... > -if (!res) { > -... > -} > ...> > -ioremap = devm_ioremap(...); > +ioremap = devm_platform_ioremap_resource(pdev,0); > > Cc: Chunyan Zhang > Cc: Dmitry Baryshkov &