Re: [RFC PATCH v3 0/3] new subsystem for compute accelerator devices

2022-11-11 Thread Christopher Friedt
Hi Oded, On Sun, Nov 6, 2022 at 4:03 PM Oded Gabbay wrote: > The patches are in the following repo: > https://git.kernel.org/pub/scm/linux/kernel/git/ogabbay/accel.git/log/?h=accel_v3 > > As in v2, The HEAD of that branch is a commit adding a dummy driver that > registers an accel device using th

[PATCH 1/1] drm/vmwgfx: correct fb_fix_screeninfo.line_length

2014-06-30 Thread Christopher Friedt
On Mon, Jun 30, 2014 at 7:48 AM, Thomas Hellstrom wrote: > I don't think we can blame video-vmware for this. A kernel driver change > that breaks existing user-space is by definition a kernel driver bug, > regardless whether exisiting user-space is doing something horrendously > stupid. I wouldn

[PATCH 1/1] drm/vmwgfx: correct fb_fix_screeninfo.line_length

2014-06-30 Thread Christopher Friedt
On Mon, Jun 30, 2014 at 8:49 AM, Christopher Friedt wrote: > That sounds a bit more accurate. Should kms and fbdev be setting both > registers then? I wonder if fbdev can use PITCHLOCK as well, rather than BYTES_PER_LINE. I will only be able to run both kms and fbdev functional tests a

[PATCH 1/1] drm/vmwgfx: correct fb_fix_screeninfo.line_length

2014-06-30 Thread Christopher Friedt
On Apr 1, 2014 6:00 AM, "Thomas Hellstrom" wrote: > > On 03/28/2014 02:45 AM, Dave Airlie wrote: > > On Fri, Mar 28, 2014 at 10:45 AM, Christopher Friedt > > wrote: > >> Previously, the vmwgfx_fb driver would allow users to call FBIOSET_VINFO, but it wou

[PATCH 1/1] drm/vmwgfx: correct fb_fix_screeninfo.line_length

2014-06-30 Thread Christopher Friedt
On Mon, Jun 30, 2014 at 8:39 AM, Thomas Hellstrom wrote: > xf86-video-vmware in kms mode uses the kernel driver to set these registers. > FWIW, the modesetting part of the kernel driver uses SVGA_REG_PITCHLOCK > instead of > SVGA_REG_BYTES_PER_LINE to set the pitch. That's probably where the > cl

[PATCH 1/1] drm/vmwgfx: correct fb_fix_screeninfo.line_length

2014-07-01 Thread Christopher Friedt
I have been unable to reproduce this issue in a plethora of test cases, although granted, I do not have access to a Win7 machine. For that, I have asked an Ubuntu tester to run through some tests for me. https://bugs.launchpad.net/ubuntu/+source/xserver-xorg-video-vmware/+bug/1328898/comments/8 W

[PATCH 1/1] drm/vmwgfx: correct fb_fix_screeninfo.line_length

2014-07-02 Thread Christopher Friedt
On Jul 2, 2014 12:16 AM, "Thomas Hellstrom" wrote: > > On 07/02/2014 05:01 AM, Christopher Friedt wrote: > > I have been unable to reproduce this issue in a plethora of test > > cases, although granted, I do not have access to a Win7 machine. For > > that, I

[PATCH 1/1] drm/vmwgfx: correct fb_fix_screeninfo.line_length

2014-07-02 Thread Christopher Friedt
At least one source has reported that vmwgfx_fb.c::vmw_fb_check_var() is not even a code path that is traversed when the bug occurs (i.e. inserted unique log message -> never seen in logs). Also, everyone encountering the bug seems to be on a slightly older version of VMWare Player. It does not se