Re: [PATCH 07/11] treewide: Replace the use of mem_encrypt_active() with prot_guest_has()

2021-08-02 Thread Christophe Leroy
Le 28/07/2021 à 00:26, Tom Lendacky a écrit : Replace occurrences of mem_encrypt_active() with calls to prot_guest_has() with the PATTR_MEM_ENCRYPT attribute. What about https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20210730114231.23445-1-w...@kernel.org/ ? Christophe Cc: T

[PATCH RESEND] drm/i915/gem: Use user_write_access_begin() instead of user_access_begin()

2021-05-01 Thread Christophe Leroy
eb_copy_relocations() only do unsafe_put_user(), it only requires write access to user. Use user_write_access_begin() instead of user_access_begin(). Signed-off-by: Christophe Leroy --- Resending with mm list in addition drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 6 +++--- 1 file

Re: [PATCH v2 61/63] powerpc: Split memset() to avoid multi-field overflow

2021-08-17 Thread Christophe Leroy
Le 18/08/2021 à 08:05, Kees Cook a écrit : In preparation for FORTIFY_SOURCE performing compile-time and run-time field bounds checking for memset(), avoid intentionally writing across neighboring fields. Instead of writing across a field boundary with memset(), move the call to just the arra

Re: [PATCH v2 57/63] powerpc/signal32: Use struct_group() to zero spe regs

2021-08-20 Thread Christophe Leroy
ribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Werror=attribute-warning] 195 |__write_overflow_field(); |^~~~ Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Christophe Leroy

Re: [PATCH 02/13] module: add a module_loaded helper

2021-01-22 Thread Christophe Leroy
Le 21/01/2021 à 08:49, Christoph Hellwig a écrit : > Add a helper that takes modules_mutex and uses find_module to check if a > given module is loaded. This provides a better abstraction for the two > callers, and allows to unexport modules_mutex and find_module. > > Signed-off-by: Christoph H

[PATCH] drm/i915/gem: Use user_write_access_begin() instead of user_access_begin()

2021-03-10 Thread Christophe Leroy
eb_copy_relocations() only do unsafe_put_user(), it only requires write access to user. Use user_write_access_begin() instead of user_access_begin(). Signed-off-by: Christophe Leroy --- drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions

Re: [PATCH 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-11-25 Thread Christophe Leroy
Le 21/05/2020 à 12:38, Christophe Leroy a écrit : Le 21/05/2020 à 09:02, Michael Ellerman a écrit : Arnd Bergmann writes: +On Wed, Apr 8, 2020 at 2:04 PM Michael Ellerman wrote: Benjamin Herrenschmidt writes: On Fri, 2020-04-03 at 15:59 +1100, Michael Ellerman wrote: Benjamin

Re: [PATCH] drm/nouveau/bios: Rename prom_init() and friends functions

2022-03-18 Thread Christophe Leroy
Hi Paul, Le 05/03/2022 à 10:51, Christophe Leroy a écrit : Le 05/03/2022 à 08:38, Christophe Leroy a écrit : Le 04/03/2022 à 21:24, Lyude Paul a écrit : This mostly looks good to me. Just one question (and one comment down below that needs addressing). Is this with ppc32? (I ask because

[PATCH v2] drm/nouveau/bios: Rename prom_init() and friends functions

2022-03-19 Thread Christophe Leroy
the ops structure as 'nvbios_prom' instead of 'nvbios_rom' in order to make it clear that it refers to the NV_PROM device. Signed-off-by: Christophe Leroy --- v2: using nvbios_prom prefix instead of nvbios_rom. Changed structure name to keep things consistant. drivers/gpu/drm

[PATCH] drm/nouveau/bios: Rename prom_init() and friends functions

2022-03-04 Thread Christophe Leroy
88: drivers/gpu/drm/nouveau/nvkm/subdev/bios/shadowrom.o] Error 1 powerpc and a few other architectures have a prom_init() global function. One day or another it will conflict with the one in shadowrom.c Those being static, they can easily be renamed. Do it. Signed-off-by: Christophe Leroy

Re: [PATCH] drm/nouveau/bios: Rename prom_init() and friends functions

2022-03-04 Thread Christophe Leroy
Le 04/03/2022 à 21:24, Lyude Paul a écrit : > This mostly looks good to me. Just one question (and one comment down below > that needs addressing). Is this with ppc32? (I ask because ppc64le doesn't > seem to hit this compilation error). That's with PPC64, see http://kisskb.ellerman.id.au/kissk

Re: [PATCH] drm/nouveau/bios: Rename prom_init() and friends functions

2022-03-05 Thread Christophe Leroy
Le 05/03/2022 à 08:38, Christophe Leroy a écrit : Le 04/03/2022 à 21:24, Lyude Paul a écrit : This mostly looks good to me. Just one question (and one comment down below that needs addressing). Is this with ppc32? (I ask because ppc64le doesn't seem to hit this compilation

Re: [PATCH v3 8/8] treewide: Replace the use of mem_encrypt_active() with cc_platform_has()

2021-09-09 Thread Christophe Leroy
On 9/8/21 10:58 PM, Tom Lendacky wrote: diff --git a/arch/powerpc/include/asm/mem_encrypt.h b/arch/powerpc/include/asm/mem_encrypt.h index ba9dab07c1be..2f26b8fc8d29 100644 --- a/arch/powerpc/include/asm/mem_encrypt.h +++ b/arch/powerpc/include/asm/mem_encrypt.h @@ -10,11 +10,6 @@ #incl

Re: [PATCH v3 2/8] mm: Introduce a function to check for confidential computing features

2021-09-09 Thread Christophe Leroy
On 9/8/21 10:58 PM, Tom Lendacky wrote: In prep for other confidential computing technologies, introduce a generic helper function, cc_platform_has(), that can be used to check for specific I have little problem with that naming. For me CC has always meant Compiler Collection. active conf

Re: [PATCH v3 4/8] powerpc/pseries/svm: Add a powerpc version of cc_platform_has()

2021-09-09 Thread Christophe Leroy
On 9/8/21 10:58 PM, Tom Lendacky wrote: Introduce a powerpc version of the cc_platform_has() function. This will be used to replace the powerpc mem_encrypt_active() implementation, so the implementation will initially only support the CC_ATTR_MEM_ENCRYPT attribute. Cc: Michael Ellerman Cc: B

Re: [PATCH v3 4/8] powerpc/pseries/svm: Add a powerpc version of cc_platform_has()

2021-09-14 Thread Christophe Leroy
Le 14/09/2021 à 13:58, Borislav Petkov a écrit : On Wed, Sep 08, 2021 at 05:58:35PM -0500, Tom Lendacky wrote: Introduce a powerpc version of the cc_platform_has() function. This will be used to replace the powerpc mem_encrypt_active() implementation, so the implementation will initially only

[PATCH] video: fbdev: use memset_io() instead of memset()

2021-09-15 Thread Christophe Leroy
t;[PATCH] ppc32: Remove CONFIG_PMAC_PBOOK") Reported-by: Stan Johnson Cc: Finn Thain Signed-off-by: Christophe Leroy --- drivers/video/fbdev/chipsfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/chipsfb.c b/drivers/video/fbdev/chipsfb.c index 9

Re: [PATCH v3 4/8] powerpc/pseries/svm: Add a powerpc version of cc_platform_has()

2021-09-15 Thread Christophe Leroy
Le 15/09/2021 à 12:08, Borislav Petkov a écrit : On Wed, Sep 15, 2021 at 10:28:59AM +1000, Michael Ellerman wrote: I don't love it, a new C file and an out-of-line call to then call back to a static inline that for most configuration will return false ... but whatever :) Yeah, hch thinks it

Re: [PATCH 09/22] docs: mark orphan documents as such

2019-06-03 Thread Christophe Leroy
Le 30/05/2019 à 01:23, Mauro Carvalho Chehab a écrit : Sphinx doesn't like orphan documents: Documentation/accelerators/ocxl.rst: WARNING: document isn't included in any toctree Documentation/arm/stm32/overview.rst: WARNING: document isn't included in any toctree Documentatio

[PATCH 2/4] scsi: cxlflash: Include missing linux/irqdomain.h

2022-06-11 Thread Christophe Leroy
aration of function 'irq_find_mapping'; did you mean 'is_cow_mapping'? [-Werror=implicit-function-declaration] 264 | if (irq_find_mapping(NULL, irq->hwirq)) { | ^~~~ | is_cow_mapping cc1: some warnings being treated as er

[PATCH 1/4] video: fbdev: offb: Include missing linux/platform_device.h

2022-06-11 Thread Christophe Leroy
h to allow cleaning asm/pci.h Cc: Thomas Zimmermann Fixes: 52b1b46c39ae ("of: Create platform devices for OF framebuffers") Signed-off-by: Christophe Leroy --- drivers/video/fbdev/offb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/fbdev/offb.c b/drivers/vide

[PATCH 3/4] powerpc: Remove asm/prom.h from asm/mpc52xx.h and asm/pci.h

2022-06-11 Thread Christophe Leroy
asm/pci.h and asm/mpc52xx.h don't need asm/prom.h Declare struct device_node locally to avoid including of.h Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/mpc52xx.h | 3 ++- arch/powerpc/include/asm/pci.h | 1 - 2 files changed, 2 insertions(+), 2 deletions(-) diff --

[PATCH 4/4] powerpc: Finally remove unnecessary headers from asm/prom.h

2022-06-11 Thread Christophe Leroy
Remove all headers included from asm/prom.h which are not used by asm/prom.h itself. Declare struct device_node and struct property locally to avoid including of.h Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/prom.h | 12 +++- 1 file changed, 3 insertions(+), 9

Re: [PATCH v5 1/2] module: update dependencies at try_module_get()

2022-05-01 Thread Christophe Leroy
Le 30/04/2022 à 22:04, Mauro Carvalho Chehab a écrit : > Sometimes, device drivers are bound into each other via try_module_get(), > making such references invisible when looking at /proc/modules or lsmod. > > Add a function to allow setting up module references for such > cases, and call it whe

Re: [PATCH 6/6] i2c: Make remove callback return void

2022-06-29 Thread Christophe Leroy
Le 29/06/2022 à 09:23, Uwe Kleine-König a écrit : > Hello, > > [I dropped nearly all individuals from the Cc: list because various > bounces reported to be unhappy about the long (logical) line.] Good idea, even patchwork made a mess of it, see https://patchwork.ozlabs.org/project/linuxppc-dev

[PATCH v3 3/4] powerpc: Remove asm/prom.h from asm/mpc52xx.h and asm/pci.h

2022-07-08 Thread Christophe Leroy
asm/pci.h and asm/mpc52xx.h don't need asm/prom.h Declare struct device_node locally to avoid including of.h Signed-off-by: Christophe Leroy --- v3: Add prom.h to prom.c --- arch/powerpc/include/asm/mpc52xx.h | 3 ++- arch/powerpc/include/asm/pci.h | 1 - arch/powerpc/kernel/p

[PATCH v3 1/4] video: fbdev: offb: Include missing linux/platform_device.h

2022-07-08 Thread Christophe Leroy
h to allow cleaning asm/pci.h Cc: Thomas Zimmermann Fixes: 52b1b46c39ae ("of: Create platform devices for OF framebuffers") Signed-off-by: Christophe Leroy Acked-by: Helge Deller --- drivers/video/fbdev/offb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/fbdev/of

[PATCH v3 4/4] powerpc: Finally remove unnecessary headers from asm/prom.h

2022-07-08 Thread Christophe Leroy
Remove all headers included from asm/prom.h which are not used by asm/prom.h itself. Declare struct device_node and struct property locally to avoid including of.h Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/prom.h | 10 ++ 1 file changed, 2 insertions(+), 8 deletions

[PATCH v3 2/4] scsi: cxlflash: Include missing linux/irqdomain.h

2022-07-08 Thread Christophe Leroy
aration of function 'irq_find_mapping'; did you mean 'is_cow_mapping'? [-Werror=implicit-function-declaration] 264 | if (irq_find_mapping(NULL, irq->hwirq)) { | ^~~~ | is_cow_mapping cc1: some warnings being treated as er

[PATCH] drm/radeon/combios: Prepare cleanup of powerpc's asm/prom.h

2022-04-02 Thread Christophe Leroy
powerpc's asm/prom.h brings some headers that it doesn't need itself. In order to clean it up, first add missing headers in users of asm/prom.h Signed-off-by: Christophe Leroy --- drivers/gpu/drm/radeon/radeon_combios.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/

[PATCH] video: fbdev: Prepare cleanup of powerpc's asm/prom.h

2022-04-02 Thread Christophe Leroy
powerpc's asm/prom.h brings some headers that it doesn't need itself. In order to clean it up, first add missing headers in users of asm/prom.h Signed-off-by: Christophe Leroy --- drivers/video/fbdev/aty/aty128fb.c | 1 - drivers/video/fbdev/aty/atyfb_base.c | 1 - dri

Re: [RFT 00/13] iomap: Constify ioreadX() iomem argument

2020-01-09 Thread Christophe Leroy
Hi Geert, Le 08/01/2020 à 09:43, Geert Uytterhoeven a écrit : Hi Christophe, On Wed, Jan 8, 2020 at 9:35 AM Christophe Leroy wrote: Le 08/01/2020 à 09:18, Krzysztof Kozlowski a écrit : On Wed, 8 Jan 2020 at 09:13, Geert Uytterhoeven wrote: On Wed, Jan 8, 2020 at 9:07 AM Geert Uytterhoeven

Re: [RFT 00/13] iomap: Constify ioreadX() iomem argument

2020-01-09 Thread Christophe Leroy
Le 08/01/2020 à 09:18, Krzysztof Kozlowski a écrit : On Wed, 8 Jan 2020 at 09:13, Geert Uytterhoeven wrote: Hi Krzysztof, On Wed, Jan 8, 2020 at 9:07 AM Geert Uytterhoeven wrote: On Tue, Jan 7, 2020 at 5:53 PM Krzysztof Kozlowski wrote: The ioread8/16/32() and others have inconsistent i

[PATCH v3 2/7] uaccess: Tell user_access_begin() if it's for a write or not

2020-01-24 Thread Christophe Leroy
s for write and return an opaque key that will be used by user_access_end() to know what was done by user_access_begin(). Signed-off-by: Christophe Leroy --- v3: new --- arch/x86/include/asm/uaccess.h | 5 +++-- drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 15 ++

Re: [PATCH v3 2/7] uaccess: Tell user_access_begin() if it's for a write or not

2020-01-24 Thread christophe leroy
Le 23/01/2020 à 19:02, Linus Torvalds a écrit : On Thu, Jan 23, 2020 at 4:59 AM Christophe Leroy wrote: On 32 bits powerPC (book3s/32), only write accesses to user are protected and there is no point spending time on unlocking for reads. Honestly, I'm starting to think that 32-bi

[PATCH] video: fbdev: mb862xx: Replace NO_IRQ by 0

2022-10-05 Thread Christophe Leroy
NO_IRQ is used to check the return of irq_of_parse_and_map(). On some architecture NO_IRQ is 0, on other architectures it is -1. irq_of_parse_and_map() returns 0 on error, independent of NO_IRQ. So use 0 instead of using NO_IRQ. Signed-off-by: Christophe Leroy --- drivers/video/fbdev/mb862xx

Re: [PATCH v3 3/5] treewide: use get_random_u32() when possible

2022-10-06 Thread Christophe Leroy
Le 06/10/2022 à 18:53, Jason A. Donenfeld a écrit : > The prandom_u32() function has been a deprecated inline wrapper around > get_random_u32() for several releases now, and compiles down to the > exact same code. Replace the deprecated wrapper with a direct call to > the real function. The same

Re: [PATCH v3 4/5] treewide: use get_random_bytes when possible

2022-10-06 Thread Christophe Leroy
eal function. > > Reviewed-by: Kees Cook > Signed-off-by: Jason A. Donenfeld Reviewed-by: Christophe Leroy (Powerpc part) > --- > arch/powerpc/crypto/crc-vpmsum_test.c | 2 +- > > diff --git a/arch/powerpc/crypto/crc-vpmsum_test.c > b/arch/powerpc/crypto/cr

Re: [PATCH v3 3/5] treewide: use get_random_u32() when possible

2022-10-06 Thread Christophe Leroy
Le 06/10/2022 à 19:24, Jason A. Donenfeld a écrit : > Hi Christophe, > > On Thu, Oct 6, 2022 at 11:21 AM Christophe Leroy > wrote: >> Le 06/10/2022 à 18:53, Jason A. Donenfeld a écrit : >>> The prandom_u32() function has been a deprecated inline wrapper around >&

Re: [PATCH v3 3/5] treewide: use get_random_u32() when possible

2022-10-06 Thread Christophe Leroy
Le 06/10/2022 à 19:31, Christophe Leroy a écrit : Le 06/10/2022 à 19:24, Jason A. Donenfeld a écrit : Hi Christophe, On Thu, Oct 6, 2022 at 11:21 AM Christophe Leroy wrote: Le 06/10/2022 à 18:53, Jason A. Donenfeld a écrit : The prandom_u32() function has been a deprecated inline

Re: [PATCH v3 3/5] treewide: use get_random_u32() when possible

2022-10-06 Thread Christophe Leroy
Le 07/10/2022 à 01:36, Jason A. Donenfeld a écrit : > On 10/6/22, Christophe Leroy wrote: >> >> >> Le 06/10/2022 à 19:31, Christophe Leroy a écrit : >>> >>> >>> Le 06/10/2022 à 19:24, Jason A. Donenfeld a écrit : >>>> Hi Christophe

Re: [PATCH 02/15] video: fbdev: atyfb: Introduce backlight_get_brightness()

2023-01-09 Thread Christophe Leroy
Le 07/01/2023 à 19:26, Sam Ravnborg via B4 Submission Endpoint a écrit : > From: Sam Ravnborg > > Introduce backlight_get_brightness() to simplify logic > and avoid direct access to backlight properties. When I read 'introduce' I understand that you are adding a new function. In fact backligh

[PATCH 2/5] powerpc: Replace _ALIGN_DOWN() by ALIGN_DOWN()

2020-04-20 Thread Christophe Leroy
_ALIGN_DOWN() is specific to powerpc ALIGN_DOWN() is generic and does the same Replace _ALIGN_DOWN() by ALIGN_DOWN() Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/book3s/32/pgtable.h | 2 +- arch/powerpc/include/asm/nohash/32/pgtable.h | 2 +- arch/powerpc/kernel/pci_64.c

[PATCH 5/5] powerpc: Remove _ALIGN_UP(), _ALIGN_DOWN() and _ALIGN()

2020-04-20 Thread Christophe Leroy
These three powerpc macros have been replaced by equivalent generic macros and are not used anymore. Remove them. Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/page.h | 7 --- 1 file changed, 7 deletions(-) diff --git a/arch/powerpc/include/asm/page.h b/arch/powerpc/include

[PATCH 4/5] powerpc: Replace _ALIGN() by ALIGN()

2020-04-20 Thread Christophe Leroy
_ALIGN() is specific to powerpc ALIGN() is generic and does the same Replace _ALIGN() by ALIGN() Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/book3s/32/pgtable.h | 2 +- arch/powerpc/include/asm/nohash/32/pgtable.h | 2 +- arch/powerpc/kernel/prom_init.c | 8

[PATCH 3/5] powerpc: Replace _ALIGN_UP() by ALIGN()

2020-04-20 Thread Christophe Leroy
_ALIGN_UP() is specific to powerpc ALIGN() is generic and does the same Replace _ALIGN_UP() by ALIGN() Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/iommu.h | 4 ++-- arch/powerpc/kernel/head_booke.h | 2 +- arch/powerpc/kernel/nvram_64.c

[PATCH 1/5] drivers/powerpc: Replace _ALIGN_UP() by ALIGN()

2020-04-20 Thread Christophe Leroy
_ALIGN_UP() is specific to powerpc ALIGN() is generic and does the same Replace _ALIGN_UP() by ALIGN() Signed-off-by: Christophe Leroy --- drivers/ps3/ps3-lpm.c | 6 +++--- drivers/vfio/pci/vfio_pci_nvlink2.c | 2 +- drivers/video/fbdev/ps3fb.c | 4 ++-- sound/ppc/snd_ps3

Re: [PATCH] drm/amd/display: Fix missing declaration of enable_kernel_vsx()

2020-10-19 Thread Christophe Leroy
patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Christophe-Leroy/drm-amd-display-Fix-missing-declaration-of-enable_kernel_vsx/20201019-174155 base: https://git.kernel.org/pub/scm/linux/

[PATCH] drm/amd/display: Fix missing declaration of enable_kernel_vsx()

2020-10-19 Thread Christophe Leroy
rs/gpu/drm/amd/amdgpu/../display/dc/calcs/dcn_calcs.o] Error 1 Fixes: 16a9dea110a6 ("amdgpu: Enable initial DCN support on POWER") Cc: sta...@vger.kernel.org Signed-off-by: Christophe Leroy --- drivers/gpu/drm/amd/display/dc/os_types.h | 1 + 1 file changed, 1 insertion(+) diff --g

Re: [PATCH 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-03-30 Thread Christophe Leroy
Le 27/03/2020 à 15:14, Andy Shevchenko a écrit : On Fri, Mar 27, 2020 at 02:22:55PM +0100, Arnd Bergmann wrote: On Fri, Mar 27, 2020 at 2:15 PM Andy Shevchenko wrote: On Fri, Mar 27, 2020 at 03:10:26PM +0200, Andy Shevchenko wrote: On Fri, Mar 27, 2020 at 01:54:33PM +0100, Arnd Bergmann wro

Re: [PATCH 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-03-31 Thread Christophe Leroy
Le 31/03/2020 à 07:30, Michael Ellerman a écrit : Christophe Leroy writes: Le 27/03/2020 à 15:14, Andy Shevchenko a écrit : On Fri, Mar 27, 2020 at 02:22:55PM +0100, Arnd Bergmann wrote: On Fri, Mar 27, 2020 at 2:15 PM Andy Shevchenko wrote: On Fri, Mar 27, 2020 at 03:10:26PM +0200, Andy

Re: [PATCH 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-04-01 Thread Christophe Leroy
Le 31/03/2020 à 09:19, Christophe Leroy a écrit : Le 31/03/2020 à 08:59, Michal Simek a écrit : On 31. 03. 20 8:56, Christophe Leroy wrote: Le 31/03/2020 à 07:30, Michael Ellerman a écrit : Christophe Leroy writes: Le 27/03/2020 à 15:14, Andy Shevchenko a écrit : On Fri, Mar 27, 2020

Re: [PATCH 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-04-01 Thread Christophe Leroy
Le 31/03/2020 à 08:59, Michal Simek a écrit : On 31. 03. 20 8:56, Christophe Leroy wrote: Le 31/03/2020 à 07:30, Michael Ellerman a écrit : Christophe Leroy writes: Le 27/03/2020 à 15:14, Andy Shevchenko a écrit : On Fri, Mar 27, 2020 at 02:22:55PM +0100, Arnd Bergmann wrote: On Fri

Re: [PATCH 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-04-01 Thread Christophe Leroy
Le 31/03/2020 à 12:04, Michal Simek a écrit : On 31. 03. 20 11:49, Christophe Leroy wrote: Le 31/03/2020 à 09:19, Christophe Leroy a écrit : Le 31/03/2020 à 08:59, Michal Simek a écrit : On 31. 03. 20 8:56, Christophe Leroy wrote: Le 31/03/2020 à 07:30, Michael Ellerman a écrit

Re: [PATCH 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-04-09 Thread Christophe Leroy
Le 08/04/2020 à 01:32, Benjamin Herrenschmidt a écrit : On Fri, 2020-04-03 at 15:59 +1100, Michael Ellerman wrote: Benjamin Herrenschmidt writes: On Tue, 2020-03-31 at 16:30 +1100, Michael Ellerman wrote: I have no attachment to 40x, and I'd certainly be happy to have less code in the tree,

Re: [PATCH 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-05-21 Thread Christophe Leroy
Le 21/05/2020 à 09:02, Michael Ellerman a écrit : Arnd Bergmann writes: +On Wed, Apr 8, 2020 at 2:04 PM Michael Ellerman wrote: Benjamin Herrenschmidt writes: On Fri, 2020-04-03 at 15:59 +1100, Michael Ellerman wrote: Benjamin Herrenschmidt writes: IBM still put 40x cores inside POWER

Re: [PATCH v2 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-06-04 Thread Christophe Leroy
t for v5.8, assuming there's no major objections. Sure. Just to let you know Christophe Leroy included this patch in his series about ppc405 removal. It should be the same. If you don't want to take that alsa patch I can send it separately and this patch can be taken from his series. I do

[PATCH v3 04/24] soc/fsl/qbman: use ioremap_cache() instead of ioremap_prot(0)

2018-10-10 Thread Christophe Leroy
ioremap_prot() with flag set to 0 relies on a hack in __ioremap_caller() which adds PAGE_KERNEL flags when the handed flags don't look like a valid set of flags (ie don't include _PAGE_PRESENT) The intention being to map cached memory, use ioremap_cache() instead. Signed-off-by: Christ

[PATCH v3 13/24] powerpc/mm: Split dump_pagelinuxtables flag_array table

2018-10-10 Thread Christophe Leroy
To reduce the complexity of flag_array, and allow the removal of default 0 value of non existing flags, lets have one flag_array table for each platform family with only the really existing flags. Reviewed-by: Aneesh Kumar K.V Signed-off-by: Christophe Leroy --- arch/powerpc/mm/Makefile

[PATCH v3 15/24] powerpc/mm: move __P and __S tables in the common pgtable.h

2018-10-10 Thread Christophe Leroy
__P and __S flags are the same for all platform and should remain as is in the future, so avoid duplication. Reviewed-by: Aneesh Kumar K.V Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/book3s/64/pgtable.h | 20 arch/powerpc/include/asm/pgtable.h

[PATCH v3 09/24] powerpc/mm: move some nohash pte helpers in nohash/[32:64]/pgtable.h

2018-10-10 Thread Christophe Leroy
In order to allow their use in nohash/32/pgtable.h, we have to move the following helpers in nohash/[32:64]/pgtable.h: - pte_mkwrite() - pte_mkdirty() - pte_mkyoung() - pte_wrprotect() Reviewed-by: Aneesh Kumar K.V Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/nohash/32

[PATCH v3 12/24] powerpc/mm: use pte helpers in generic code

2018-10-10 Thread Christophe Leroy
Get rid of platform specific _PAGE_ in powerpc common code and use helpers instead. mm/dump_linuxpagetables.c will be handled separately Reviewed-by: Aneesh Kumar K.V Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/book3s/32/pgtable.h | 9 +++-- arch/powerpc/include/asm

[PATCH v3 07/24] powerpc: handover page flags with a pgprot_t parameter

2018-10-10 Thread Christophe Leroy
In order to avoid multiple conversions, handover directly a pgprot_t to map_kernel_page() as already done for radix. Do the same for __ioremap_caller() and __ioremap_at(). Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/book3s/32/pgtable.h | 2 +- arch/powerpc/include/asm/book3s

[PATCH v3 08/24] powerpc/mm: don't use _PAGE_EXEC in book3s/32

2018-10-10 Thread Christophe Leroy
book3s/32 doesn't define _PAGE_EXEC, so no need to use it. All other platforms define _PAGE_EXEC so no need to check it is not NUL when not book3s/32. Reviewed-by: Aneesh Kumar K.V Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/book3s/32/pgtable.h | 2 +- arch/power

[PATCH v3 14/24] powerpc/mm: drop unused page flags

2018-10-10 Thread Christophe Leroy
flags in book3s/64/pgtable.h can be dropped as they are not used on this platform nor by common code. _PAGE_NA, _PAGE_RO, _PAGE_USER and _PAGE_PSIZE Reviewed-by: Aneesh Kumar K.V Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/book3s/64/pgtable.h | 10 +- arch/powerpc/include

[PATCH v3 21/24] powerpc/mm: Define platform default caches related flags

2018-10-10 Thread Christophe Leroy
Cache related flags like _PAGE_COHERENT and _PAGE_WRITETHRU are defined on most platforms. The platforms not defining them don't define any alternative. So we can give them a NUL value directly for those platforms directly. Reviewed-by: Aneesh Kumar K.V Signed-off-by: Christophe Leroy ---

[PATCH v3 11/24] powerpc/mm: don't use _PAGE_EXEC for calling hash_preload()

2018-10-10 Thread Christophe Leroy
placed by 'is_exec' which will be either true of false, and the PPC64 version of hash_preload() creates the access flag based on 'is_exec'. Signed-off-by: Christophe Leroy --- arch/powerpc/mm/hash_utils_64.c | 3 ++- arch/powerpc/mm/mem.c | 9 + arch/

[PATCH v3 23/24] powerpc/8xx: change name of a few page flags to avoid confusion

2018-10-10 Thread Christophe Leroy
7;t really tells that's it is a huge page but only that it is not a 4k page. Name it _PAGE_SPS instead of _PAGE_HUGE Reviewed-by: Aneesh Kumar K.V Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/nohash/32/pte-8xx.h | 28 ++-- arch/powerpc/ke

[PATCH v3 05/24] powerpc: don't use ioremap_prot() nor __ioremap() unless really needed.

2018-10-10 Thread Christophe Leroy
In many places, ioremap_prot() and __ioremap() can be replaced with higher level functions like ioremap(), ioremap_coherent(), ioremap_cache(), ioremap_wc() ... Signed-off-by: Christophe Leroy --- arch/powerpc/kernel/btext.c | 2 +- arch/powerpc/kernel/crash_dump.c | 2

[PATCH v3 06/24] powerpc/mm: properly set PAGE_KERNEL flags in ioremap()

2018-10-10 Thread Christophe Leroy
Set PAGE_KERNEL directly in the caller and do not rely on a hack adding PAGE_KERNEL flags when _PAGE_PRESENT is not set. As already done for PPC64, use pgprot_cache() helpers instead of _PAGE_XXX flags in PPC32 ioremap() derived functions. Signed-off-by: Christophe Leroy --- arch/powerpc

[PATCH v3 18/24] powerpc/mm: Distribute platform specific PAGE and PMD flags and definitions

2018-10-10 Thread Christophe Leroy
same with _PMD flags like _PMD_USER and _PMD_PRESENT_MASK Reviewed-by: Aneesh Kumar K.V Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/nohash/32/pte-40x.h | 29 ++ arch/powerpc/include/asm/nohash/32/pte-44x.h | 35 arch/powerpc/include/asm/nohash

[PATCH v3 00/24] ban the use of _PAGE_XXX flags outside platform specific code

2018-10-10 Thread Christophe Leroy
e_at(), see discussion at https://patchwork.ozlabs.org/patch/972630/ - compilation result: http://kisskb.ellerman.id.au/kisskb/head/914a399c8f1434f3c52013e625fb1665571033ef/ Christophe Leroy (24): powerpc/32: Add ioremap_wt() and ioremap_coherent() drivers/video/fbdev: use ioremap_wc/wt() instead of _

[PATCH v3 22/24] powerpc/mm: Get rid of pte-common.h

2018-10-10 Thread Christophe Leroy
Do not include pte-common.h in nohash/32/pgtable.h As that was the last includer, get rid of pte-common.h Reviewed-by: Aneesh Kumar K.V Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/nohash/32/pgtable.h | 23 +-- arch/powerpc/include/asm/pte-common.h

[PATCH v3 20/24] powerpc/mm: Allow platforms to redefine some helpers

2018-10-10 Thread Christophe Leroy
Kumar K.V Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/nohash/32/pgtable.h | 16 - arch/powerpc/include/asm/nohash/32/pte-40x.h | 16 + arch/powerpc/include/asm/nohash/32/pte-8xx.h | 51 arch/powerpc/include/asm/nohash/64/pgtable.h | 4

[PATCH v3 24/24] powerpc/book3s64: Avoid multiple endian conversion in pte helpers

2018-10-10 Thread Christophe Leroy
In the same spirit as already done in pte query helpers, this patch changes pte setting helpers to perform endian conversions on the constants rather than on the pte value. In the meantime, it changes pte_access_permitted() to use pte helpers for the same reason. Signed-off-by: Christophe Leroy

[PATCH v3 19/24] powerpc/nohash/64: do not include pte-common.h

2018-10-10 Thread Christophe Leroy
nohash/64 only uses book3e PTE flags, so it doesn't need pte-common.h This also allows to drop PAGE_SAO and H_PAGE_4K_PFN from pte_common.h as they are only used by PPC64 Reviewed-by: Aneesh Kumar K.V Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/nohash/64/pgtable.h

[PATCH v3 10/24] powerpc/mm: add pte helpers to query and change pte flags

2018-10-10 Thread Christophe Leroy
is no exec protection, so pte_mkexec() and pte_exprotect() are nops and pte_exec() returns always true. Reviewed-by: Aneesh Kumar K.V Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/book3s/32/pgtable.h | 41 arch/powerpc/include/asm/book3s/64/pgtable.h

[PATCH v3 02/24] drivers/video/fbdev: use ioremap_wc/wt() instead of __ioremap()

2018-10-10 Thread Christophe Leroy
. _PAGE_WRITETHRU is also platform specific flag. Use ioremap_wt() instead. Signed-off-by: Christophe Leroy --- drivers/video/fbdev/chipsfb.c| 3 +-- drivers/video/fbdev/controlfb.c | 5 + drivers/video/fbdev/platinumfb.c | 5 + drivers/video/fbdev/valkyriefb.c | 12 ++-- 4 files

[PATCH v3 01/24] powerpc/32: Add ioremap_wt() and ioremap_coherent()

2018-10-10 Thread Christophe Leroy
Other arches have ioremap_wt() to map IO areas write-through. Implement it on PPC as well in order to avoid drivers using __ioremap(_PAGE_WRITETHRU) Also implement ioremap_coherent() to avoid drivers using __ioremap(_PAGE_COHERENT) Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm

[PATCH v3 03/24] drivers/block/z2ram: use ioremap_wt() instead of __ioremap(_PAGE_WRITETHRU)

2018-10-10 Thread Christophe Leroy
_PAGE_WRITETHRU is a target specific flag. Prefer generic functions. Acked-by: Geert Uytterhoeven Signed-off-by: Christophe Leroy --- drivers/block/z2ram.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/block/z2ram.c b/drivers/block/z2ram.c index d0c5bc4e0703

[PATCH v3 16/24] powerpc/book3s/32: do not include pte-common.h

2018-10-10 Thread Christophe Leroy
-by: Aneesh Kumar K.V Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/book3s/32/pgtable.h | 97 ++-- arch/powerpc/include/asm/pte-common.h| 16 + 2 files changed, 96 insertions(+), 17 deletions(-) diff --git a/arch/powerpc/include/asm/book3s/32

[PATCH v3 17/24] powerpc/mm: Move pte_user() into nohash/pgtable.h

2018-10-10 Thread Christophe Leroy
Now the pte-common.h is only for nohash platforms, lets move pte_user() helper out of pte-common.h to put it together with other helpers. Reviewed-by: Aneesh Kumar K.V Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/nohash/pgtable.h | 10 ++ arch/powerpc/include/asm/pte

Re: [PATCH v3 02/24] drivers/video/fbdev: use ioremap_wc/wt() instead of __ioremap()

2018-10-12 Thread Christophe LEROY
Le 09/10/2018 à 15:51, Christophe Leroy a écrit : _PAGE_NO_CACHE is a platform specific flag. In addition, this flag is misleading because one would think it requests a noncached page whereas a noncached page is _PAGE_NO_CACHE | _PAGE_GUARDED _PAGE_NO_CACHE alone means write combined

Re: Crash on FSL Book3E due to pte_pgprot()? (was Re: [PATCH v3 12/24] powerpc/mm: use pte helpers in generic code)

2018-10-16 Thread Christophe Leroy
On 10/17/2018 12:59 AM, Michael Ellerman wrote: Christophe Leroy writes: Get rid of platform specific _PAGE_ in powerpc common code and use helpers instead. mm/dump_linuxpagetables.c will be handled separately Reviewed-by: Aneesh Kumar K.V Signed-off-by: Christophe Leroy --- arch

[PATCH RESEND 3/3] drivers/block/z2ram: use ioremap_wt() instead of __ioremap(_PAGE_WRITETHRU)

2018-08-27 Thread Christophe Leroy
_PAGE_WRITETHRU is a target specific flag. Prefer generic functions. Signed-off-by: Christophe Leroy --- drivers/block/z2ram.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/block/z2ram.c b/drivers/block/z2ram.c index d0c5bc4e0703..cfbd70520eeb 100644 --- a

[PATCH] drivers/video/fbdev: use ioremap_wc() instead of __ioremap(_PAGE_NO_CACHE)

2018-08-27 Thread Christophe Leroy
linux-fb...@vger.kernel.org, linux-ker...@vger.kernel.org, linuxppc-...@lists.ozlabs.org _PAGE_NO_CACHE is a target specific flag. Prefer generic functions. Signed-off-by: Christophe Leroy --- drivers/video/fbdev/chipsfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH RESEND 2/3] drivers/video/fbdev: use ioremap_wt() instead of __ioremap(_PAGE_WRITETHRU)

2018-08-27 Thread Christophe Leroy
_PAGE_WRITETHRU is a target specific flag. Prefer generic functions. Signed-off-by: Christophe Leroy --- drivers/video/fbdev/controlfb.c | 3 +-- drivers/video/fbdev/platinumfb.c | 3 +-- drivers/video/fbdev/valkyriefb.c | 10 ++ 3 files changed, 8 insertions(+), 8 deletions(-) diff

[PATCH 1/3] powerpc/32: Add ioremap_wt()

2018-08-27 Thread Christophe Leroy
Other arches have ioremap_wt() to map IO areas write-through. Implement it on PPC as well in order to avoid drivers using __ioremap(_PAGE_WRITETHRU) Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/io.h | 6 ++ arch/powerpc/mm/pgtable_32.c | 8 2 files changed, 14

[PATCH RESEND 1/3] powerpc/32: Add ioremap_wt()

2018-08-27 Thread Christophe Leroy
Other arches have ioremap_wt() to map IO areas write-through. Implement it on PPC as well in order to avoid drivers using __ioremap(_PAGE_WRITETHRU) Signed-off-by: Christophe Leroy --- No change. First serie didn't apply because I generated it on a working branch. arch/powerpc/includ

[PATCH 2/3] drivers/video/fbdev: use ioremap_wt() instead of __ioremap(_PAGE_WRITETHRU)

2018-08-27 Thread Christophe Leroy
_PAGE_WRITETHRU is a target specific flag. Prefer generic functions. Signed-off-by: Christophe Leroy --- drivers/video/fbdev/controlfb.c | 3 +-- drivers/video/fbdev/platinumfb.c | 3 +-- drivers/video/fbdev/valkyriefb.c | 10 ++ 3 files changed, 8 insertions(+), 8 deletions(-) diff

[PATCH 3/3] drivers/block/z2ram: use ioremap_wt() instead of __ioremap(_PAGE_WRITETHRU)

2018-08-27 Thread Christophe Leroy
_PAGE_WRITETHRU is a target specific flag. Prefer generic functions. Signed-off-by: Christophe Leroy --- drivers/block/z2ram.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/block/z2ram.c b/drivers/block/z2ram.c index d0c5bc4e0703..cfbd70520eeb 100644 --- a

Re: [PATCH] drivers/video/fbdev: use ioremap_wc() instead of __ioremap(_PAGE_NO_CACHE)

2018-08-27 Thread Christophe LEROY
Le 24/08/2018 à 13:05, Segher Boessenkool a écrit : On Fri, Aug 24, 2018 at 10:16:22AM +, Christophe Leroy wrote: _PAGE_NO_CACHE is a target specific flag. Prefer generic functions. #ifdef CONFIG_PPC - p->screen_base = __ioremap(addr, 0x20, _PAGE_NO_CACHE); +

[PATCH RESEND 3/3] drivers/block/z2ram: use ioremap_wt() instead of __ioremap(_PAGE_WRITETHRU)

2018-08-27 Thread Christophe Leroy
_PAGE_WRITETHRU is a target specific flag. Prefer generic functions. Signed-off-by: Christophe Leroy --- drivers/block/z2ram.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/block/z2ram.c b/drivers/block/z2ram.c index d0c5bc4e0703..cfbd70520eeb 100644 --- a

[PATCH RESEND 2/3] drivers/video/fbdev: use ioremap_wt() instead of __ioremap(_PAGE_WRITETHRU)

2018-08-27 Thread Christophe Leroy
_PAGE_WRITETHRU is a target specific flag. Prefer generic functions. Signed-off-by: Christophe Leroy --- drivers/video/fbdev/controlfb.c | 3 +-- drivers/video/fbdev/platinumfb.c | 3 +-- drivers/video/fbdev/valkyriefb.c | 10 ++ 3 files changed, 8 insertions(+), 8 deletions(-) diff

[PATCH v2 2/3] drivers/video/fbdev: use ioremap_wt() instead of __ioremap(_PAGE_WRITETHRU)

2018-08-28 Thread Christophe Leroy
_PAGE_WRITETHRU is a target specific flag. Prefer generic functions. Signed-off-by: Christophe Leroy --- v2: removed unnecessary includes headers drivers/video/fbdev/controlfb.c | 5 + drivers/video/fbdev/platinumfb.c | 5 + drivers/video/fbdev/valkyriefb.c | 12 ++-- 3

[PATCH v2] drivers/video/fbdev: use ioremap_wc() instead of __ioremap(_PAGE_NO_CACHE)

2018-08-28 Thread Christophe Leroy
: Christophe Leroy --- v2: removed unnecessary include and enhanced commit log follow Segher's comment drivers/video/fbdev/chipsfb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/video/fbdev/chipsfb.c b/drivers/video/fbdev/chipsfb.c index f103665

[PATCH v2 3/3] drivers/block/z2ram: use ioremap_wt() instead of __ioremap(_PAGE_WRITETHRU)

2018-08-28 Thread Christophe Leroy
_PAGE_WRITETHRU is a target specific flag. Prefer generic functions. Signed-off-by: Christophe Leroy --- v2: no change drivers/block/z2ram.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/block/z2ram.c b/drivers/block/z2ram.c index d0c5bc4e0703..cfbd70520eeb

[PATCH v2 1/3] powerpc/32: Add ioremap_wt()

2018-08-28 Thread Christophe Leroy
Other arches have ioremap_wt() to map IO areas write-through. Implement it on PPC as well in order to avoid drivers using __ioremap(_PAGE_WRITETHRU) Signed-off-by: Christophe Leroy --- v2: no change arch/powerpc/include/asm/io.h | 6 ++ arch/powerpc/mm/pgtable_32.c | 8 2 files

[PATCH v2 15/24] powerpc/mm: move __P and __S tables in the common pgtable.h

2018-09-13 Thread Christophe Leroy
__P and __S flags are the same for all platform and should remain as is in the future, so avoid duplication. Reviewed-by: Aneesh Kumar K.V Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/book3s/64/pgtable.h | 20 arch/powerpc/include/asm/pgtable.h

[PATCH v2 03/24] drivers/block/z2ram: use ioremap_wt() instead of __ioremap(_PAGE_WRITETHRU)

2018-09-13 Thread Christophe Leroy
_PAGE_WRITETHRU is a target specific flag. Prefer generic functions. Acked-by: Geert Uytterhoeven Signed-off-by: Christophe Leroy --- drivers/block/z2ram.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/block/z2ram.c b/drivers/block/z2ram.c index d0c5bc4e0703

  1   2   >