ore some freeing functions is not needed.
>
> Signed-off-by: Qiheng Lin
Reviewed-by: Christian Gmeiner
--
greets
--
Christian Gmeiner, MSc
https://christian-gmeiner.info/privacypolicy
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https:/
failures.
>
> Signed-off-by: Tian Tao
> Signed-off-by: Zihao Tang
> Signed-off-by: Jay Fang
Reviewed-by: Christian Gmeiner
--
greets
--
Christian Gmeiner, MSc
https://christian-gmeiner.info/privacypolicy
___
dri-devel mailing lis
t; is obviously bad.
>
> Rework the linear window offset calculation to be based on the command buffer
> physical address, making sure that the command buffer is always mappable.
>
> Signed-off-by: Lucas Stach
Reviewed-by: Christian Gmeiner
> ---
> driver
&
> VIVS_MMUv2_SEC_CONTROL_ENABLE)
> return;
>
> + if (gpu->mmu_context)
> + etnaviv_iommu_context_put(gpu->mmu_context);
> + gpu->mmu_context = etnaviv_iommu_context_get(context);
> +
I have seen this pattern now more than two times - maybe put the
assignment of a new mmu context into its own function?
> gpu_write(gpu, VIVS_MMUv2_PTA_ADDRESS_LOW,
> lower_32_bits(context->global->v2.pta_dma));
> gpu_write(gpu, VIVS_MMUv2_PTA_ADDRESS_HIGH,
> --
> 2.30.2
>
--
greets
--
Christian Gmeiner, MSc
https://christian-gmeiner.info/privacypolicy
Hi Lucas
Am Di., 24. Aug. 2021 um 09:54 Uhr schrieb Lucas Stach :
>
> Am Dienstag, dem 24.08.2021 um 09:24 +0200 schrieb Christian Gmeiner:
> > Am Fr., 20. Aug. 2021 um 22:18 Uhr schrieb Lucas Stach
> > :
> > >
> > > Move the refcount manipulation of th
Add the
> mssing context put to fix the leak.
>
> Cc: sta...@vger.kernel.org # 5.4
> Signed-off-by: Lucas Stach
> Tested-by: Michael Walle
Series is:
Reviewed-by: Christian Gmeiner
> ---
> drivers/gpu/drm/etnaviv/etnaviv_mmu.c | 1 +
> 1 file changed, 1 insertion(+)
Am Do., 26. Aug. 2021 um 14:10 Uhr schrieb Michael Walle :
>
> There is already a macro for the magic value. Use it.
>
> Signed-off-by: Michael Walle
Reviewed-by: Christian Gmeiner
I will wait for v2 for the rest of the changes to review.
> ---
> drivers/gpu/drm/etnaviv
ucas Stach
Reviewed-by: Christian Gmeiner
--
greets
--
Christian Gmeiner, MSc
https://christian-gmeiner.info/privacypolicy
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
lane for the
> TS buffer and the modifier defines the layout of this TS buffer.
>
I am unsure why you want to have the TS modifiers in drm_fourcc.h. Can
you share some insight on this?
--
greets
--
Christian Gmeiner, MSc
https://christian-gmeiner.
Am Sa., 20. März 2021 um 20:11 Uhr schrieb Daniel Vetter :
>
> On Sat, Mar 20, 2021 at 10:28 AM Christian Gmeiner
> wrote:
> >
> > Hi Lucas
> >
> > Am Fr., 19. März 2021 um 20:06 Uhr schrieb Lucas Stach
> > :
> > >
> > > Vivante TS (til
it.c:618:2-8: WARNING: NULL
> check before some freeing functions is not needed.
>
> ./drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c:616:2-8: WARNING: NULL
> check before some freeing functions is not needed.
>
> Reported-by: Abaci Robot
> Signed-off-by: Jiapeng Chong
R
+ .minor_features8 = 0x00e10ef3,
> + .minor_features9 = 0x04c8003c,
> + .minor_features10 = 0x4060,
> + .minor_features11 = 0x0024,
> + },
> {
> .model = 0x7000,
> .revision = 0x6214,
Am Di., 1. Dez. 2020 um 21:38 Uhr schrieb Lubomir Rintel :
>
> Just so that it's obvious what failed and why.
>
> Signed-off-by: Lubomir Rintel
Reviewed-by: Christian Gmeiner
> ---
> tests/etnaviv/etnaviv_2d_test.c | 16 ++--
> 1 file changed, 14
Am Di., 1. Dez. 2020 um 21:38 Uhr schrieb Lubomir Rintel :
>
> Run the test on a core capable of 2D rendering instead of hardcoding to
> core zero.
>
Thanks - I should have done this before landing this test :)
> Signed-off-by: Lubomir Rintel
Reviewed-by: Christian Gmeiner
e name is given as an argument. This also removes use of a hardcoded
> file name in a world writable directory, which is an unsafe thing to
> do anyway.
>
> Signed-off-by: Lubomir Rintel
Reviewed-by: Christian Gmeiner
> ---
> tests/etnaviv/etnaviv_2d_test.c | 29 +++
ed with coccinelle:
>
> @@
> expression E;
> @@
> - flush_workqueue(E);
> destroy_workqueue(E);
>
> Signed-off-by: Christophe JAILLET
For drm/etnaviv:
Reviewed-by: Christian Gmeiner
--
greets
--
Christian Gmeiner, MSc
https://christian-gmeiner.info/privacypolicy
put it in read-only memory.
>
> Signed-off-by: Rikard Falkeborn
Reviewed-by: Christian Gmeiner
> ---
> drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> b/driver
Make it possible for the user space to access these ID values.
Signed-off-by: Christian Gmeiner
---
drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 12
include/uapi/drm/etnaviv_drm.h| 3 +++
2 files changed, 15 insertions(+)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
b
ngle submit seems like a reasonably future-proof number for now. This
> number can be bumped if needed without breaking the interface.
>
> Cc: sta...@vger.kernel.org
> Reported-by: Dan Carpenter
> Signed-off-by: Lucas Stach
Reviewed-by: Christian Gmeiner
--
greets
--
Christian Gmeiner, MSc
https://christian-gmeiner.info/privacypolicy
U resets, also remember and consider the last completed fence seqno
> in the hang check.
>
> Reported-by: Joerg Albert
> Signed-off-by: Lucas Stach
Reviewed-by: Christian Gmeiner
--
greets
--
Christian Gmeiner, MSc
https://christian-gmeiner.info/privacypolicy
8ddd ("drm/etnaviv: limit submit sizes")
> Cc: sta...@vger.kernel.org
> Signed-off-by: Lucas Stach
Reviewed-by: Christian Gmeiner
--
greets
--
Christian Gmeiner, MSc
https://christian-gmeiner.info/privacypolicy
2016-04-21 22:17 GMT+02:00 Emil Velikov :
> Cc: Christian Gmeiner
> Cc: Russell King
> Cc: Lucas Stach
> Signed-off-by: Emil Velikov
Acked-by: Christian Gmeiner
> ---
> include/uapi/drm/etnaviv_drm.h | 8
> 1 file changed, 8 insertions(+)
>
> di
ther subtile problems.
>
> Rather than trying to work around this, just disable the linear memory
> window offset for those cores.
>
> Suggested-by: Russell King
> Signed-off-by: Lucas Stach
Reviewed-by: Christian Gmeiner
> ---
> driver
>
> Signed-off-by: Lucas Stach
Reviewed-by: Christian Gmeiner
> ---
> drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
>
__SHIFT) &
> VIVS_HI_INTR_ACKNOWLEDGE_INTR_VEC__MASK)
> +#define VIVS_HI_INTR_ACKNOWLEDGE_MMU_EXCEPTION 0x4000
> #define VIVS_HI_INTR_ACKNOWLEDGE_AXI_BUS_ERROR 0x8000
>
> #define VIVS_HI_INTR_ENBL 0x0014
Where can I find the rnndb patch? Just share it and I will take care
that it gets integrated.
greets
--
Christian Gmeiner, MSc
https://soundcloud.com/christian-gmeiner
Am Mo., 15. Apr. 2019 um 15:12 Uhr schrieb Lucas Stach :
>
> Setting the GFP flags does not need a new code block if moved to
> the right location, which makes this function a bit easier to read.
>
> Signed-off-by: Lucas Stach
Reviewed-by: Christian Gmeiner
> ---
> dr
Am Mi., 19. Dez. 2018 um 15:45 Uhr schrieb Lucas Stach :
>
> Keep the page at address 0 as faulting to catch any potential state
> setup issues early.
>
> Signed-off-by: Lucas Stach
I like this idea.. but I am unsure about Guido's GC7000 problem.
Reviewed-b
gt; * @funcs:
> *
> @@ -363,6 +382,8 @@ void drm_gem_put_pages(struct drm_gem_object *obj, struct
> page **pages,
> bool dirty, bool accessed);
>
> struct drm_gem_object *drm_gem_object_lookup(struct drm_file *filp, u32
> handle);
> +long drm_gem_reservation_object_wait(struct drm_file *filep, u32 handle,
> + bool wait_all, unsigned long timeout);
> int drm_gem_dumb_map_offset(struct drm_file *file, struct drm_device *dev,
> u32 handle, u64 *offset);
> int drm_gem_dumb_destroy(struct drm_file *file,
> --
> 2.19.1
>
--
greets
--
Christian Gmeiner, MSc
https://christian-gmeiner.info
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
: fix gem_prime_get_sg_table to return new
> SG table")
> Signed-off-by: Dan Carpenter
Reviewed-by: Christian Gmeiner
> ---
> drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/et
Am Mi., 19. Dez. 2018 um 15:45 Uhr schrieb Lucas Stach :
>
> The context isn't really related to the cmdbuf, but is a property of
> the job. This has been missed when moving to a properly refcounted
> etnaviv_gem_submit.
>
> Signed-off-by: Lucas Stach
Reviewe
checks that were off by one.
>
> Fixes: 9e2c2e273012 ("drm/etnaviv: add infrastructure to query perf counter")
> Signed-off-by: Dan Carpenter
Reviewed-by: Christian Gmeiner
Tested-by: Christian Gmeiner
> ---
> Not tested.
>
> diff --git a/drivers/gpu/drm/et
iver POV there is no distinction between primary and render
> > nodes, thus we can drop the token.
> >
> > Cc: Lucas Stach
> > Cc: Christian Gmeiner
> > Cc: etna...@lists.freedesktop.org
> > Cc: David Airlie
> > Cc: Daniel Vetter
> > Signed-of
Am Fr., 14. Juni 2019 um 22:36 Uhr schrieb Daniel Vetter
:
>
> They're the default.
>
> Aside: Would be really nice to switch the others over to
> drm_gem_object_funcs.
>
> Signed-off-by: Daniel Vetter
Reviewed-by: Christian Gmeiner
> Cc: Lucas Stach
> C
current_stream set,
> iterate over current streams' list of BOs before adding the BO to it
> and verify that the BO is not yet there.
>
> Signed-off-by: Marek Vasut
> Cc: Christian Gmeiner
> Cc: Lucas Stach
Reviewed-by: Christian Gmeiner
Will land this patch even libdr
ff-by: Marek Vasut
> Cc: Christian Gmeiner
> Cc: Lucas Stach
> ---
> etnaviv/etnaviv_bo.c | 6 +++---
> etnaviv/etnaviv_cmd_stream.c | 31 ++-
> etnaviv/etnaviv_priv.h | 17 ++---
> 3 files changed, 35 insertions(+),
Signed-off-by: Christian Gmeiner
---
drivers/gpu/drm/etnaviv/etnaviv_perfmon.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_perfmon.c
b/drivers/gpu/drm/etnaviv/etnaviv_perfmon.c
index 4227a4006c34..06e6d3ee1c34 100644
--- a/drivers/gpu
As seen at CodeAurora's linux-imx git repo in imx_4.19.35_1.0.0 branch.
Signed-off-by: Christian Gmeiner
---
drivers/gpu/drm/etnaviv/etnaviv_perfmon.c | 44 +--
1 file changed, 33 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_perfmon
Changes in V2:
- use indentation as suggested by Philipp Zabel.
Signed-off-by: Christian Gmeiner
---
drivers/gpu/drm/etnaviv/etnaviv_perfmon.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_perfmon.c
b/drivers/gpu/drm/etnaviv
Hi Philipp
Am Do., 1. Aug. 2019 um 11:22 Uhr schrieb Philipp Zabel
:
>
> Hi Christian,
>
> On Wed, 2019-07-31 at 23:29 +0200, Christian Gmeiner wrote:
> > Signed-off-by: Christian Gmeiner
> > ---
> > drivers/gpu/drm/etnaviv/etnaviv_perfmon.c | 4 ++--
> >
Track the pid per submit, so we can print the name and cmdline of
the task which submitted the batch that caused the gpu to hang.
Signed-off-by: Christian Gmeiner
---
drivers/gpu/drm/etnaviv/etnaviv_gem.h| 1 +
drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 6 ++
drivers/gpu/drm
This patch series add support for loadavg values for GPU
sub-components. I am adding a SMA algorithm as I was not
really sure if EWMA would be a good fit for this use case.
Changes v2:
- Addressed feedback from Lucas
Christian Gmeiner (4):
drm/etnaviv: add simple moving average (SMA)
drm
This adds a SMA algorithm inspired by Exponentially weighted moving
average (EWMA) algorithm found in the kernel.
Signed-off-by: Christian Gmeiner
---
drivers/gpu/drm/etnaviv/etnaviv_sma.h | 53 +++
1 file changed, 53 insertions(+)
create mode 100644 drivers/gpu/drm
Might be helpful to see the loadavg in debugfs.
Signed-off-by: Christian Gmeiner
---
drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
index
percentage based load of each sub-GPU
component.
Signed-off-by: Christian Gmeiner
---
drivers/gpu/drm/etnaviv/etnaviv_drv.c | 14 ++
drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 64 ++-
drivers/gpu/drm/etnaviv/etnaviv_gpu.h | 37
3 files changed, 114 insertions
Make it possible to access the sub-GPU component load value from
user space with the perfmon infrastructure.
Signed-off-by: Christian Gmeiner
---
drivers/gpu/drm/etnaviv/etnaviv_perfmon.c | 79 +++
1 file changed, 79 insertions(+)
diff --git a/drivers/gpu/drm/etnaviv
Hi Lucas
>
> Am Dienstag, dem 21.06.2022 um 09:20 +0200 schrieb Christian Gmeiner:
> > This adds a SMA algorithm inspired by Exponentially weighted moving
> > average (EWMA) algorithm found in the kernel.
> >
> Still not sure about this one. I _feel_ that a simple mov
Am Fr., 24. Juni 2022 um 11:38 Uhr schrieb Lucas Stach :
>
> Am Dienstag, dem 21.06.2022 um 09:20 +0200 schrieb Christian Gmeiner:
> > The GPU has an idle state register where each bit represents the idle
> > state of a sub-GPU component like FE or TX. Sample this register
s a starting point. I have no problem introducing per
process load avg
values .. lets see how the next version of this series will look like,
--
greets
--
Christian Gmeiner, MSc
https://christian-gmeiner.info/privacypolicy
han
forcing users to update their kernels to get this new database entry.
--
greets
--
Christian Gmeiner, MSc
https://christian-gmeiner.info/privacypolicy
o the same check
> to bundle them.
>
> Signed-off-by: Marco Felsch
> Signed-off-by: Lucas Stach
Reviewed-by: Christian Gmeiner
> ---
> drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 9 +
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu
>
> The GC300's features register doesn't specify that a 2D pipe is
> available, and like the GC600, its idle register reports zero bits where
> modules aren't present.
>
> Signed-off-by: Doug Brown
Reviewed-by: Christian Gmeiner
> ---
> dri
r possible solutions:
1) Add two seperate helpers ala gpu_read_power() and gpu_write_power()
where we do the if beast.
2) Add a power register offset variable to etnaviv_gpu and explicitly
use it on for reads and writes - like the Vivante driver does.
But that's just my personal opinion. Can't wait to hear what Lucas thinks.
--
greets
--
Christian Gmeiner, MSc
https://christian-gmeiner.info/privacypolicy
rs describe the interpretation of the tag bits in this
> buffer.
>
> Signed-off-by: Lucas Stach
Reviewed-by: Christian Gmeiner
--
greets
--
Christian Gmeiner, MSc
https://christian-gmeiner.info/privacypolicy
Hi Lucas,
Am Di., 29. Okt. 2019 um 18:18 Uhr schrieb Lucas Stach :
>
> Hi Christian,
>
> On Fr, 2019-10-25 at 12:39 +0200, Christian Gmeiner wrote:
> > etnaviv_iommuv2_dump_size(..) returns the number of PTE * SZ_4K but
> > etnaviv_iommuv2_dump(..)
> > increments b
Signed-off-by: Christian Gmeiner
---
include/uapi/drm/etnaviv_drm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/drm/etnaviv_drm.h b/include/uapi/drm/etnaviv_drm.h
index 09d0df8b71c5..5a62228298d1 100644
--- a/include/uapi/drm/etnaviv_drm.h
+++ b/include/uapi/drm/
Update the state HI header from rnndb commit
7f1ce75 ("rnndb: document some GPU identity register")
Signed-off-by: Christian Gmeiner
---
drivers/gpu/drm/etnaviv/state_hi.xml.h | 29 --
1 file changed, 18 insertions(+), 11 deletions(-)
diff --git a/drive
Take product id, customer id and eco id into account. If that
delivers no match try a search for model and revision.
Signed-off-by: Christian Gmeiner
---
drivers/gpu/drm/etnaviv/etnaviv_hwdb.c | 19 ++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu
They will be used for extended HWDB support. The eco id logic was taken
from galcore kernel driver sources.
Signed-off-by: Christian Gmeiner
---
drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 17 +
drivers/gpu/drm/etnaviv/etnaviv_gpu.h | 6 +++---
2 files changed, 20 insertions(+), 3
This patch series extends the hwdb for an entry for the gc400 found
in the ST STM32 SoC. With this patches we report the same limits and
features for this GPU as the galcore kernel driver does.
Christian Gmeiner (6):
drm/etnaviv: update hardware headers from rnndb
drm/etnaviv: determine
The information was taken from STM32 glacore driver hw database.
The entry is named as gc7000nano_0x4652.
Signed-off-by: Christian Gmeiner
---
drivers/gpu/drm/etnaviv/etnaviv_hwdb.c | 31 ++
1 file changed, 31 insertions(+)
diff --git a/drivers/gpu/drm/etnaviv
Use ~0U as marker for 'I do not care'. I am not sure what
GC7000 based devices are in the wild and I do not want to
break them. In the near future we should extend the hwdb.
Signed-off-by: Christian Gmeiner
---
drivers/gpu/drm/etnaviv/etnaviv_hwdb.c | 3 +++
1 file changed, 3
Signed-off-by: Christian Gmeiner
---
drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
index 253301be9e95..cecef5034db1 100644
--- a/drivers/gpu/drm/etnaviv
Report the correct perfmon domains and signals depending
on the supported feature flags.
Reported-by: Dan Carpenter
Fixes: 9e2c2e273012 ("drm/etnaviv: add infrastructure to query perf counter")
Cc: sta...@vger.kernel.org
Signed-off-by: Christian Gmeiner
---
drivers/gpu/d
Hi Lucas
Am Mo., 6. Jan. 2020 um 11:15 Uhr schrieb Lucas Stach :
>
> On Do, 2020-01-02 at 11:02 +0100, Christian Gmeiner wrote:
> > Take product id, customer id and eco id into account. If that
> > delivers no match try a search for model and revision.
> >
> > Si
Hi Lucas
Am Mo., 6. Jan. 2020 um 11:03 Uhr schrieb Lucas Stach :
>
> On Do, 2020-01-02 at 11:02 +0100, Christian Gmeiner wrote:
> > They will be used for extended HWDB support. The eco id logic was taken
> > from galcore kernel driver sources.
> >
> > Si
Hi Lucas,
Am Mo., 6. Jan. 2020 um 11:08 Uhr schrieb Lucas Stach :
>
> On Do, 2020-01-02 at 11:02 +0100, Christian Gmeiner wrote:
> > Signed-off-by: Christian Gmeiner
> > ---
> > drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 12
> > 1 file changed, 12 inse
Hi Lucas
Am Mo., 6. Jan. 2020 um 12:22 Uhr schrieb Lucas Stach :
>
> On Mo, 2020-01-06 at 11:57 +0100, Christian Gmeiner wrote:
> > Hi Lucas
> >
> > Am Mo., 6. Jan. 2020 um 11:03 Uhr schrieb Lucas Stach
> > :
> > > On Do, 2020-01-02 at 11:02 +0100, Christ
Signed-off-by: Christian Gmeiner
---
drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
index 7ee67e12141d..151033d58bfb 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
Take product id, customer id and eco id into account. If that
delivers no match try a search for model and revision.
Signed-off-by: Christian Gmeiner
---
drivers/gpu/drm/etnaviv/etnaviv_hwdb.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/etnaviv
This patch series extends the hwdb for an entry for the gc400 found
in the ST STM32 SoC. With this patches we report the same limits and
features for this GPU as the galcore kernel driver does.
Christian Gmeiner (6):
drm/etnaviv: update hardware headers from rnndb
drm/etnaviv: determine
Update the state HI header from rnndb commit
7f1ce75 ("rnndb: document some GPU identity register")
Signed-off-by: Christian Gmeiner
---
drivers/gpu/drm/etnaviv/state_hi.xml.h | 29 --
1 file changed, 18 insertions(+), 11 deletions(-)
diff --git a/drive
Use ~0U as marker for 'I do not care'. I am not sure what
GC7000 based devices are in the wild and I do not want to
break them. In the near future we should extend the hwdb.
Signed-off-by: Christian Gmeiner
---
drivers/gpu/drm/etnaviv/etnaviv_hwdb.c | 3 +++
1 file changed, 3
The information was taken from STM32 glacore driver hw database.
The entry is named as gc7000nano_0x4652.
Signed-off-by: Christian Gmeiner
---
drivers/gpu/drm/etnaviv/etnaviv_hwdb.c | 31 ++
1 file changed, 31 insertions(+)
diff --git a/drivers/gpu/drm/etnaviv
They will be used for extended HWDB support.
Signed-off-by: Christian Gmeiner
---
drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 11 ++-
drivers/gpu/drm/etnaviv/etnaviv_gpu.h | 6 +++---
2 files changed, 13 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
b
They don't really add any value to the
persistent kernel history."
https://lkml.org/lkml/2019/9/13/107
--
greets
--
Christian Gmeiner, MSc
https://christian-gmeiner.info/privacypolicy
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
and returning to sleep if necessary.
>
> Signed-off-by: Steven Price
Tested-by: Christian Gmeiner
Without this patch I get the following warning:
[ 242.935254] [ cut here ]
[ 242.940044] WARNING: CPU: 2 PID: 109 at kernel/sched/core.c:6731
__might_sleep+0x94/0xa
(e8a051f8)
[ 264.721727] ---[ end trace 8afcd79e9e2725b3 ]---
Fixes: afb7b3b1deb4 ("drm/etnaviv: implement IOMMUv2 translation")
Cc: sta...@vger.kernel.org
Signed-off-by: Christian Gmeiner
---
drivers/gpu/drm/etnaviv/etnaviv_iommu_v2.c | 6 --
1 file changed, 4 insertions(+), 2 deletio
ob.
>
> Fixes: 27b67278e007 (drm/etnaviv: rework MMU handling)
> [ Not really the first bad commit, but the one where this fix applies
> cleanly. Stable kernels need a manual backport. ]
> Reported-by: Christian Gmeiner
> Signed-off-by: Lucas Stach
Tested-by: Christian Gmeiner
&
Am Mo., 6. Jan. 2020 um 11:43 Uhr schrieb Christian Gmeiner
:
>
> Report the correct perfmon domains and signals depending
> on the supported feature flags.
>
> Reported-by: Dan Carpenter
> Fixes: 9e2c2e273012 ("drm/etnaviv: add infrastructure to query perf counter")
gentle ping
--
greets
--
Christian Gmeiner, MSc
https://christian-gmeiner.info/privacypolicy
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Report the correct perfmon domains and signals depending
on the supported feature flags.
Reported-by: Dan Carpenter
Fixes: 9e2c2e273012 ("drm/etnaviv: add infrastructure to query perf counter")
Cc: sta...@vger.kernel.org
Signed-off-by: Christian Gmeiner
---
Changes V1 -> V2:
-
Hi Lucas,
Am Mi., 26. Feb. 2020 um 16:19 Uhr schrieb Lucas Stach :
>
> Hi Christian,
>
> sorry for taking so long to get around to this.
>
No problem...
> On Mo, 2020-01-06 at 11:43 +0100, Christian Gmeiner wrote:
> > Report the correct perfmon domains and signals depend
Might be useful when debugging MMU exceptions.
Changes in V2:
- Use a static array of string for error message as suggested
by Lucas Stach.
Signed-off-by: Christian Gmeiner
---
drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a
Update the state HI header from rnndb commit
a04283591a8a (rnndb: update MMU exception causes).
Changes in V2:
- Only update state_hi.xml as suggested by Lucas Stach.
Signed-off-by: Christian Gmeiner
---
drivers/gpu/drm/etnaviv/state_hi.xml.h | 25 ++---
1 file changed, 14
Might be useful when debugging MMU exceptions.
Signed-off-by: Christian Gmeiner
---
drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 26 ++
1 file changed, 26 insertions(+)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
index
Am Fr., 6. Sept. 2019 um 12:11 Uhr schrieb Lucas Stach :
>
> On Fr, 2019-09-06 at 12:03 +0200, Christian Gmeiner wrote:
> > Update the state HI and common header from rnndb commit
> > a04283591a8a (rnndb: update MMU exception causes).
> >
> > Signed-off-by: Christian
Am Fr., 6. Sept. 2019 um 12:55 Uhr schrieb Lucas Stach :
>
> On Fr, 2019-09-06 at 12:03 +0200, Christian Gmeiner wrote:
> > Might be useful when debugging MMU exceptions.
> >
> > Signed-off-by: Christian Gmeiner
> > ---
> > driver
Am Di., 1. Juni 2021 um 16:06 Uhr schrieb Zheng Yongjun
:
>
> Eliminate the following coccicheck warning:
>
> drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c:84:2-8: WARNING:
> NULL check before some freeing functions is not needed.
>
> Signed-off-by: Zheng Yongjun
Reviewed-
2.31.0
>
Thanks for the patch, but there is an other one queued up in
etnaviv/next that fixes the same issue:
https://git.pengutronix.de/cgit/lst/linux/commit/?h=etnaviv/next&id=bdf622e0fade2cec72c948c708763378b656c01d
--
greets
--
Christian Gmeiner, MSc
https://christian-gmeiner.info/privacypolicy
kvfree(etnaviv_obj->pages);
> + kvfree(etnaviv_obj->pages);
>
> drm_prime_gem_destroy(&etnaviv_obj->base, etnaviv_obj->sgt);
> }
> --
> 2.31.0
>
Thanks for the patch, but there is an other one queued up in
etnaviv/next that fixes the same issue:
https://git.pengutronix.de/c
d-off-by: Lucas Stach
Reviewed-by: Christian Gmeiner
> ---
> drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c | 10 +-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c
> b/drivers/gpu/drm/etnaviv/etnaviv_gem_pri
Hi Lucas
Am Mi., 30. Nov. 2022 um 19:53 Uhr schrieb Lucas Stach :
>
> From: Christian Gmeiner
>
> The MMU tells us the fault status. While the raw register value is
> already printed, it's a bit more user friendly to translate the
> fault reasons into human readable fo
17e4660ae3d7 ("drm/etnaviv: implement per-process address spaces on
> MMUv2")
> Signed-off-by: Lucas Stach
Reviewed-by: Christian Gmeiner
> ---
> drivers/gpu/drm/etnaviv/etnaviv_dump.c | 14 +++---
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
>
f sram exporter.
--
greets
--
Christian Gmeiner, MSc
https://christian-gmeiner.info/privacypolicy
rk on it? If not I would like to help out
> > as we have a use case where we want to
> > use a dma-buf sram exporter.
> >
> >
>
> Sure, I've been keeping it alive in our evil vendor tree, but if
> there is interest upstream now I'll post a v2 and CC you.
That would be great!
--
greets
--
Christian Gmeiner, MSc
https://christian-gmeiner.info/privacypolicy
Hi Andrew
Am Di., 4. Apr. 2023 um 17:02 Uhr schrieb Christian Gmeiner
:
>
> > > Hi Andrew
> > >
> > >>
> > >>
> > >> Okay, will split for v2.
> > >>
> > >>
> > >
> > > Was there a follow-up v2 of
should not hurt most use-cases. The FE WAIT
> command seems to have some unknown discrete steps in the wait cycles so
> we may over/undershoot the target a bit, but that should be harmless.
>
> Signed-off-by: Lucas Stach
Reviewed-by: Christian Gmeiner
> ---
> drivers/gpu/drm/etna
Hi Lucas
>
> So it can use the event_free function without adding another
> forward declaration. No functional change.
>
> Signed-off-by: Lucas Stach
Reviewed-by: Christian Gmeiner
> ---
> drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 88 +--
> 1 fil
gpu->event_spinlock);
> for_each_set_bit(i, gpu->event_bitmap, ETNA_NR_EVENTS)
> - complete(&gpu->event_free);
> - bitmap_zero(gpu->event_bitmap, ETNA_NR_EVENTS);
> + event_free(gpu, i);
> spin_unlock(&gpu->event_spi
tnaviv_gem_submit *submit)
> unsigned int i, nr_events = 1, event[3];
> int ret;
>
> - if (!submit->runtime_resumed) {
> - ret = pm_runtime_get_sync(gpu->dev);
> - if (ret < 0) {
> - pm_runtime_put_noidle(gpu->dev);
> - return NULL;
> - }
> - submit->runtime_resumed = true;
> - }
> -
> /*
> * if there are performance monitor requests we need to have
> * - a sync point to re-configure gpu and process ETNA_PM_PROCESS_PRE
> --
> 2.39.2
>
--
greets
--
Christian Gmeiner, MSc
https://christian-gmeiner.info/privacypolicy
1 - 100 of 477 matches
Mail list logo
