Now that we have the name "block" free once more, we can use it to point
to the start of a block within the edid.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/drm_edid.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/drm_edid.c b/d
The "block" variable points to the entire edid, not individual blocks
despite it being named such.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/drm_edid.c | 38 +++---
1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/drivers/gpu/drm/dr
() itself with the bad block printing from
get_edid_block(), into a single warning associated with the connector
once all attempts to retrieve the EDID fail.
References: https://bugs.freedesktop.org/show_bug.cgi?id=98228
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/drm_edid.c | 42
on that is unlikely
> to be useful in the case of fence-arrays. If you need to wait on
> multiple fences from different timelines, you probably aren't doing
> that in hw.
For 2 i915 fences, I definitely do not want signaling enabled at
creation time.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
pturing frame CRCs")
> Cc: Benjamin Gaignard
> Cc: Daniel Vetter
> Cc: Emil Velikov
> Cc: Tomeu Vizoso
> Signed-off-by: Jani Nikula
Reviewed-by: Chris Wilson
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
irst.
>
> Fixes: 0853695c3ba4 ("drm: Add reference counting to drm_atomic_state")
> Cc: Chris Wilson
> Cc: Daniel Vetter
> Signed-off-by: Arnd Bergmann
Yup, missed that it jumps to fail before allocating state.
Function still looks a bit odd, but nvm
Reviewed-by: Ch
I plan to usurp the short name of struct fence for a core kernel struct,
and so I need to rename the specialised fence/timeline for DMA
operations to make room.
A consensus was reached in
https://lists.freedesktop.org/archives/dri-devel/2016-July/113083.html
that making clear this fence applies to
+ dma_fence_wait
|
- fence_context_alloc
+ dma_fence_context_alloc
|
- FENCE_TRACE
+ DMA_FENCE_TRACE
|
- FENCE_WARN
+ DMA_FENCE_WARN
|
- FENCE_ERR
+ DMA_FENCE_ERR
)
(
...
)
Signed-off-by: Chris Wilson
---
drivers/base/Kconfig | 6 +-
drivers/dma-buf/Makefile
On Thu, Oct 20, 2016 at 10:39:47AM -0400, Sean Paul wrote:
> On Thu, Oct 20, 2016 at 2:47 AM, Chris Wilson
> wrote:
> > I plan to usurp the short name of struct fence for a core kernel struct,
> > and so I need to rename the specialised fence/timeline for DMA
> >
the vma (or the bo as well as the vma).
> + dev_priv->perf.oa.oa_buffer.addr = i915_gem_object_pin_map(bo, map);
> + if (IS_ERR(dev_priv->perf.oa.oa_buffer.addr)) {
> + ret = PTR_ERR(dev_priv->perf.oa.oa_buffer.addr);
> + goto err_unpin;
> + }
--
Chris Wilson, Intel Open Source Technology Centre
).
Signed-off-by: Chris Wilson
Cc: Villle Syrjälä
Cc: Manasi Navare
---
drivers/gpu/drm/drm_probe_helper.c | 10 ++
drivers/gpu/drm/drm_sysfs.c| 19 +++
drivers/gpu/drm/i2c/tda998x_drv.c | 2 +-
drivers/gpu/drm/i915/intel_dp.c| 3 ++-
drivers
Date: Thu Oct 20 14:08:48 2016 +0800
drm/i915/gvt: fix spare warnings on odd constant _Bool cast
The function return values should has type int if it return
a integer value.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
).
v2: Don't convert intel_hotplug.c, it does a light probe and doesn't
need the force.
Signed-off-by: Chris Wilson
Cc: Villle Syrjälä
Cc: Manasi Navare
---
drivers/gpu/drm/drm_probe_helper.c | 10 ++
drivers/gpu/drm/drm_sysfs.c| 19 +++
drive
xercise this and at least for OACONTROL we are
fine. That test can supercede the negative BAT in gem_exec_parse.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
On Fri, Oct 21, 2016 at 12:46:53PM +0300, Ville Syrjälä wrote:
> On Fri, Oct 21, 2016 at 10:14:21AM +0100, Chris Wilson wrote:
> > If we know which connector was plugged/unplugged or
> > connected/disconnected, we can pass that information along to userspace
> > inside the
iled
Reported-by: kbuild test robot
Reported-by: Leonard Crestez
Fixes: 43dc7fe2b211 ("drm: Mark up accesses of vblank->enabled outside of its
spinlock")
Signed-off-by: Chris Wilson
Cc: Ville Syrjälä
Cc: Daniel Vetter
---
drivers/gpu/drm/drm_irq.c | 4 +++-
1 file changed, 3 in
if (a->type != b->type)
> return NULL;
> + if (a->type != SYNC_FILE_TYPE_FENCE)
> + return NULL;
No rules for containerisation? Being able to pass in an array of current
semaphore in-fences through a single fd? It will have a bigg
On Tue, Apr 04, 2017 at 12:52:32PM +0100, Chris Wilson wrote:
> On Tue, Apr 04, 2017 at 02:27:30PM +1000, Dave Airlie wrote:
> > +struct dma_fence *sync_file_replace_fence(struct sync_file *sync_file,
> > + struct dma_fence *fence)
> &
g vgem to justify the
changes? I'm also not particularly happy in losing testing of a virtual
platform device from our CI.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
ses.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
es to the reclaim code in addition of waiting a RCU grace
> period to pass.
We are not allowed to call flush_work() from the shrinker, the workqueue
doesn't have and can't have the right reclaim flags.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_
On Fri, Apr 07, 2017 at 01:23:45AM +0200, Andrea Arcangeli wrote:
> Just in case the llist model changes and NULL isn't valid
> initialization.
>
> Signed-off-by: Andrea Arcangeli
Applied, thanks.
-Chris
--
Chris Wilson, Intel Open Source
e6b10 R14: 0004 R15: 007e61f4
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100610
Fixes: e8fa5671183c ("drm: crc: Wait for a frame before returning from open()")
Signed-off-by: Chris Wilson
Cc: Tomeu Vizoso
Cc: Daniel Vetter
---
drivers/gpu/drm/drm_de
On Fri, Apr 07, 2017 at 03:06:00PM +0200, Andrea Arcangeli wrote:
> On Fri, Apr 07, 2017 at 11:02:11AM +0100, Chris Wilson wrote:
> > On Fri, Apr 07, 2017 at 01:23:44AM +0200, Andrea Arcangeli wrote:
> > > Waiting a RCU grace period only guarantees the work gets queued, but
>
On Fri, Apr 07, 2017 at 09:18:30AM -0700, Laura Abbott wrote:
> On 04/07/2017 12:39 AM, Chris Wilson wrote:
> > On Thu, Apr 06, 2017 at 04:18:33PM -0700, Laura Abbott wrote:
> >>
> >> Enable the GEM dma-buf import interfaces in addition to the export
> >> int
On Fri, Apr 07, 2017 at 06:42:46PM +0200, Daniel Vetter wrote:
> On Fri, Apr 07, 2017 at 01:55:00PM +0200, Tomeu Vizoso wrote:
> > On 04/07/2017 01:17 PM, Chris Wilson wrote:
> > > The code does not like to be interrupted when waiting for the first
> > > vblank after op
sation if
they so choose.
Signed-off-by: Chris Wilson
Cc: Laura Abbott
Cc: Sumit Semwal
Cc: Daniel Vetter
Cc: Sean Paul
---
drivers/dma-buf/dma-buf.c | 88 +++
1 file changed, 88 insertions(+)
diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-b
sation if
they so choose.
v2: Lots of little fixes, plus a real llseek() implements so that the
first basic little test cases work!
Testcase: igt/prime_rw
Signed-off-by: Chris Wilson
Cc: Laura Abbott
Cc: Sumit Semwal
Cc: Daniel Vetter
Cc: Sean Paul
---
drivers/dma-buf/dma-buf.c
Track the latest fence waited upon on each context, and only add a new
asynchronous wait if the new fence is more recent than the recorded
fence for that context. This requires us to filter out unordered
timelines, which are noted by DMA_FENCE_NO_CONTEXT.
Signed-off-by: Chris Wilson
Cc: Tvrtko
2 clflushes on two different objects are not ordered, and so do not
belong to the same timeline (context). Either we use a unique context
for each, or we reserve a special context (0 / DMA_FENCE_NO_CONTEXT) to
mean unordered.
Signed-off-by: Chris Wilson
Cc: Sumit Semwal
Cc: Gustavo Padovan
Cc
Reserve 0 for general use a token meaning that the fence doesn't belong
to an ordered timeline (fence context).
Signed-off-by: Chris Wilson
Cc: Sumit Semwal
Cc: Gustavo Padovan
Cc: Joonas Lahtinen
Cc: "Christian König"
Cc: Alex Deucher
---
drivers/dma-buf/dma-fence.c |
On Sat, Apr 08, 2017 at 07:49:37PM +0200, Christian König wrote:
> Am 08.04.2017 um 18:26 schrieb Chris Wilson:
> >Reserve 0 for general use a token meaning that the fence doesn't belong
> >to an ordered timeline (fence context).
>
> NAK, we kept context allocation c
On Sun, Apr 09, 2017 at 09:08:53AM +0200, Christian König wrote:
> Am 08.04.2017 um 20:00 schrieb Chris Wilson:
> >On Sat, Apr 08, 2017 at 07:49:37PM +0200, Christian König wrote:
> >>Am 08.04.2017 um 18:26 schrieb Chris Wilson:
> >>>Reserve 0 for general use a token
On Fri, Apr 07, 2017 at 06:48:58PM +0200, Andrea Arcangeli wrote:
> On Fri, Apr 07, 2017 at 04:30:11PM +0100, Chris Wilson wrote:
> > Not getting hangs is a good sign, but lockdep doesn't like it:
> >
> > [ 460.684901] WARNING: CPU: 1 PID: 172
a
memset(prop_values, 0xc5, foo);
drmIoctl(GETPROPERTY);
igt_assert(!memchr(prop_values, 0xc5, bar));
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://
wake_up(&sync_file->wq); /* only needs the first to redo the add */
}
will get the waiter to reset the callback on a new fence, or the old
fence replacing itself. Otherwise the waiter will never be woken over
the change in fence, not even when the old or new fence is signa
ease conduct yourself in a respectful and civilised manner when
> +interacting with community members on mailing lists, IRC, or bug
> +trackers. The community represents the project as a whole, and abusive
> +or bullying behaviour is not tolerated by the project.
Self-englightened Acked-by: Ch
truct dma_fence *fence)
> +{
> + struct vc4_fence *f = to_vc4_fence(fence);
> +
> + kfree_rcu(f, base.rcu);
> +}
Unless you have a plan to do more here, looks like you can just use
the default dma_fence_free as the release callback.
-Chris
--
Chris Wilson, Intel Open Sourc
ines. Searching kronos for VkSemaphore
https://www.khronos.org/registry/vulkan/specs/1.0/man/html/VkSemaphore.html
isn't enlightening...
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
___
dri-devel mailing list
dri-devel@lists.free
rlie
Reviewed-by: Chris Wilson
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
hat happens when the fence in the sync object
> was changed while we do the CS? Or even worse the handle got
> assigned to a new sync object.
We either ww_mutex the lot, or regard that as a userspace race where the
order between the two concurrent CS emits is undefined and who gets the
in-sema
On Wed, Apr 12, 2017 at 12:36:37PM +1000, Dave Airlie wrote:
> On 11 April 2017 at 17:50, Chris Wilson wrote:
> > On Tue, Apr 11, 2017 at 01:22:17PM +1000, Dave Airlie wrote:
> >> From: Dave Airlie
> >>
> >> This object can be used to implement the Vul
s an interesting debug story.
No, the rcu hang was not widely reported (or at least I have just two hits),
it dates back to ~v4.9. What was annoying many people was us failing to
write out the legacy context image under mempressure/suspend, which was
sent in the previous fixes cycle.
-Chris
On Wed, Apr 12, 2017 at 11:29:18AM -0700, Laura Abbott wrote:
> On 04/07/2017 02:25 PM, Chris Wilson wrote:
> > It is expected that processes will pass dma-buf fd between drivers, and
> > only using the fd themselves for mmaping and synchronisation ioctls.
> > However, it may
to handle it in the fops. Just be sure to leave a breadcrumb behind so
that the first person who does try to pass back a syncobj fd is reminded
that they need to fill in the fops.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Wed, Apr 12, 2017 at 12:57:00PM -0700, Laura Abbott wrote:
> On 04/12/2017 12:38 PM, Chris Wilson wrote:
> > On Wed, Apr 12, 2017 at 11:29:18AM -0700, Laura Abbott wrote:
> >> Both the read/write are missing the dma_buf_begin_cpu_access calls.
> >> When I add th
On Wed, Apr 12, 2017 at 09:01:32PM +0100, Chris Wilson wrote:
> On Thu, Apr 13, 2017 at 05:05:27AM +1000, Dave Airlie wrote:
> > >>
> > >> Not sure what the best semantics are there, any opinions on barring
> > >> wakeups/polling on semaphore sync_files, and
On Thu, Apr 13, 2017 at 06:51:17AM +1000, Dave Airlie wrote:
> On 13 April 2017 at 06:39, Chris Wilson wrote:
> > On Wed, Apr 12, 2017 at 09:01:32PM +0100, Chris Wilson wrote:
> >> On Thu, Apr 13, 2017 at 05:05:27AM +1000, Dave Airlie wrote:
> >> > >>
> &
fence *fence;
};
could be extracted and sync_file become fence_file. Would it not help to
avoid any further confusion by treating them as two very distinct classes
of fd?
And for me to stop calling the user interface sync_file.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_
ret_fence = sem_file_get_fence_locked(sem_file);
> + RCU_INIT_POINTER(sem_file->base.fence, fence);
> + mutex_unlock(&sem_file->lock);
Is xchg() universal?
struct dma_fence *sem_file_replace_fence(struct sem_file *sem_file,
10 13:54:45 2017 +0200
drm: Fix get_property logic fumble
Yet again I've proven that I can't negate conditions :(
Testcase: igt/kms_properties/get_property-sanity
Reviewed-by: Maarten Lankhorst
Reviewed-by: Sean Paul
Fixes: eb8eb02ed850 (&q
On Thu, Apr 13, 2017 at 10:52:17PM +0300, Dan Carpenter wrote:
> i915_gem_request_alloc() uses error pointers. It never returns NULLs.
>
> Fixes: 0daf0113cff6 ("drm/i915: Mock infrastructure for request emission")
> Signed-off-by: Dan Carpenter
Reviewed-by: Chris Wilson
ev for load-detection framebuffer\n");
if (IS_ERR(fb)) {
DRM_DEBUG_KMS("failed to allocate framebuffer for
load-detection\n");
+ ret = PTR_ERR(fb);
goto fail;
}
as well.
-Chris
--
Chris Wilson, Intel Open Source Technology
>
> My plans are to write some igt tests this week, and try
> to get some more review on what the API should allow (should
> I lock it down to drm syncobj is just semaphores for now).
Having an idr of handles is much, much nicer than fd and I want the same
for fences :)
-Chris
--
On Fri, Apr 14, 2017 at 10:54:25PM +0300, Dan Carpenter wrote:
> If "crtc" is NULL, then my static checker complains that "ret" isn't
> initialized on that path. It doesn't really cause a problem unless
> "ret" is somehow set to -EDEADLK which is n
On Wed, Apr 19, 2017 at 05:34:52AM +1000, Dave Airlie wrote:
> On 14 April 2017 at 19:45, Chris Wilson wrote:
> > On Tue, Apr 11, 2017 at 01:22:12PM +1000, Dave Airlie wrote:
> >> This set of sync object patches should address most of the issues
> >> raised in review.
a_buf))
> + return dma_buf;
> +
> + drm_dev_ref(dev);
> + drm_gem_object_reference(obj);
> +
> + return dma_buf;
> }
Please see drm_gem_dmabuf_export() and drm_gem_dmabuf_release() - unless
the double drm_dev_ref() wasn't an accident...
-Chris
--
dump is attached in case it is useful.
There are lots of very similar GPU hangs for mesa across a wide range of
kernels, with several reports noting a correlation with libreoffice.
At first glance, I would say you were just unlucky to hit it.
-Chris
--
Chris Wilson, Intel Open Source
drm_free_large(vgem_obj->pages);
Just drm_free_large(vgem_obj->pages); NULL -> kfree() which is NULL safe.
The series lgtm, doesn't compromise on any of the existing tests.
All 3,
Reviewed-by: Chris Wilson
You could always get Joonas to nitpick over style...
>
ffer be resident in memory.
>
> I'm still marking this as RFC as I haven't had a chance to finish
> a userspace test that can be integrated into igt.
Note, that it will be good to cc:intel-gfx@ so that our CI does run it
over the existing vgem tests.
-Chris
function to attach using a platform device associated
> with drm_device.
>
> Cc: intel-...@lists.freedesktop.org
> Reviewed-by: Chris Wilson
> Signed-off-by: Laura Abbott
> ---
> v3: Rebase to drm-misc-next. Prototype moved to a new header file. Comments
> added for n
On Wed, May 03, 2017 at 05:07:03PM +0200, Daniel Vetter wrote:
> On Wed, May 03, 2017 at 07:40:51AM -0700, Laura Abbott wrote:
> > On 05/03/2017 12:39 AM, Daniel Vetter wrote:
> > > On Tue, May 02, 2017 at 09:22:13PM +0100, Chris Wilson wrote:
> > >> On Tue, May 02, 2
On Thu, Mar 30, 2017 at 01:16:26PM +0300, Joonas Lahtinen wrote:
> On ke, 2017-03-29 at 10:10 +0100, Chris Wilson wrote:
> > Scatter a few cond_resched() in between phases of the drm_mm selftests
> > to try and prevent us incurring the wrath of the NMI watchdog.
> >
>
gal to call this
> + * without already holding a reference. No locks required.
> + */
> +static inline void
> +drm_syncobj_reference(struct drm_syncobj *obj)
> +{
> + kref_get(&obj->refcount);
We've been steadily converting to the kref_get style of nomenclature for
dr
INT and keeping
the maximum waittime intact.
> + dma_fence_put(fence);
> + if (ret < 0)
> + return ret;
> + if (ret == 0)
> + break;
> + }
> +
> + wait->out_status = (ret > 0);
> +
drm_dev_fini() and kfree(dev) as before.)
v3: Remember to add drm_dev_fini() to drm_drv.h
v4: Tidy language for kerneldoc
v5: Cross reference from drm_dev_init() to note that driver->release()
allows for arbitrary embedding.
Signed-off-by: Chris Wilson
Cc: Laurent Pinchart
Cc: Daniel Vetter
---
driv
Currently this tracepoint is solely used by dma_fence_enable_sw_signaling,
however I have a need to manually perform the hw enabling of the
signaling and would like to emit this tracepoint for completeness.
Signed-off-by: Chris Wilson
Cc: Sumit Semwal
Cc: Daniel Vetter
---
drivers/dma-buf/dma
uot;drm: Nuke fb->pixel_format").
Fixes: 438b74a5497c ("drm: Nuke fb->pixel_format")
Signed-off-by: Chris Wilson
Cc: Ville Syrjälä
Cc: Benjamin Gaignard
Cc: Vincent Abriou
---
drivers/gpu/drm/sti/sti_plane.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
d when the final reference to the
> &dma_buf itself is dropped and its &dma_buf_ops.release function is
> called. For GEM-based drivers this is done by using
> drm_gem_dmabuf_release()."
For GEM-based drivers, the dmabuf should be exported using
drm_gem_dmabuf_export() and th
Since moving drm_crtc_get_hv_timings() into drm_modes.c, the compiler
has been able to get smarter and spots that drm_mode_copy() is trying to
preserve garbage from the stack.
Fixes: 196cd5d3758c ("drm: s/drm_crtc_get_hv_timings/drm_mode_get_hv_timings/")
Signed-off-by: Chris Wilson
> Fixes: e5510fac98a7 ("drm/i915: add tracepoints for flip requests &
> completions")
> Signed-off-by: Andrey Ryabinin
That's old, and indeed does seem to be present from that commit and not
exposed by something later.
Cc: # v2.6.36+
Reviewed-by: Chris Wilson
-Chr
ay_plane, my plane is to move
that to an async fenced operation that is then naturally waited upon by
the atomic modeset.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://
On Fri, Jan 27, 2017 at 03:21:29PM +0100, Daniel Vetter wrote:
> On Fri, Jan 27, 2017 at 09:30:50AM +0000, Chris Wilson wrote:
> > On Thu, Jan 26, 2017 at 04:59:21PM +0100, Maarten Lankhorst wrote:
> > > When writing some testcases for nonblocking modesets. I found out that the
&
On Tue, Jan 24, 2017 at 11:57:58AM +, Chris Wilson wrote:
> Currently this tracepoint is solely used by dma_fence_enable_sw_signaling,
> however I have a need to manually perform the hw enabling of the
> signaling and would like to emit this tracepoint for completeness.
>
>
On Fri, Jan 27, 2017 at 03:58:08PM +0100, Daniel Vetter wrote:
> On Fri, Jan 27, 2017 at 02:31:55PM +0000, Chris Wilson wrote:
> > On Fri, Jan 27, 2017 at 03:21:29PM +0100, Daniel Vetter wrote:
> > > On Fri, Jan 27, 2017 at 09:30:50AM +, Chris Wilson wrote:
> > > &
ted with the struct drm_atomic_state and friends.
Signed-off-by: Chris Wilson
Cc: Laurent Pinchart
Cc: Daniel Vetter
Reviewed-by: Laurent Pinchart
---
drivers/gpu/drm/drm_drv.c | 65 ---
include/drm/drm_drv.h | 13 ++
2 files changed,
t_pages_internal().
> >
> > So limit the maximum page order to be used according to the maximum
> > swiotlb segment size instead to the complete swiotlb size.
> >
> > Signed-off-by: Juergen Gross
> Fixes: 920cf4194954 ("drm/i915: Introduce an internal allo
Check that if we request bottom-up allocation from drm_mm_insert_node()
we receive the next available hole from the bottom.
Signed-off-by: Chris Wilson
Reviewed-by: Joonas Lahtinen
---
drivers/gpu/drm/selftests/drm_mm_selftests.h | 1 +
drivers/gpu/drm/selftests/test-drm_mm.c | 100
!
v4: Kerneldoc for enum drm_mm_insert_mode.
Signed-off-by: Chris Wilson
Reviewed-by: Joonas Lahtinen
Cc: Alex Deucher
Cc: "Christian König"
Cc: David Airlie
Cc: Russell King
Cc: Daniel Vetter
Cc: Jani Nikula
Cc: Sean Paul
Cc: Lucas Stach
Cc: Christian Gmeiner
Cc: Rob Clark
C
r, ilog2(max_segment));
> >+}
> >+}
> > #endif
> >
> > gfp = GFP_KERNEL | __GFP_HIGHMEM | __GFP_RECLAIMABLE;
> >
>
> Looks OK to me. We could bikeshed it to only use
> swiotlb_max_segment() which I think was the intentio
!
v4: Kerneldoc for enum drm_mm_insert_mode.
Signed-off-by: Chris Wilson
Reviewed-by: Joonas Lahtinen
Cc: Alex Deucher
Cc: "Christian König"
Cc: David Airlie
Cc: Russell King
Cc: Daniel Vetter
Cc: Jani Nikula
Cc: Sean Paul
Cc: Lucas Stach
Cc: Christian Gmeiner
Cc: Rob Clark
C
old new delta
i915_gem_evict_for_node 719 693 -26
(No other users outside of the test harness.)
Signed-off-by: Chris Wilson
Cc: Joonas Lahtinen
---
drivers/gpu/drm/drm_mm.c| 2 +-
drivers/gpu/drm/selftests/test
On Mon, Feb 06, 2017 at 12:21:48PM +0200, Joonas Lahtinen wrote:
> On la, 2017-02-04 at 11:19 +0000, Chris Wilson wrote:
> > As we require valid start/end parameters, we can replace the initial
> > potential NULL with a pointer to the drm_mm.head_node and so reduce the
> > te
We can not allow the worker to run after its fbdev, or even the module,
has been removed.
Fixes: cfe63423d9be ("drm/fb-helper: Add drm_fb_helper_set_suspend_unlocked()")
Signed-off-by: Chris Wilson
Cc: Noralf Trønnes
Cc: Daniel Vetter
Cc: Jani Nikula
Cc: Sean Paul
Cc:
We can not allow the worker to run after its fbdev, or even the module,
has been removed.
Fixes: eaa434defaca ("drm/fb-helper: Add fb_deferred_io support")
Signed-off-by: Chris Wilson
Cc: Noralf Trønnes
Cc: Daniel Vetter
Cc: Jani Nikula
Cc: Sean Paul
Cc: dri-devel@lists.freedesk
;
> Note that I don't explain what release_fbi does, because that function
> will disappear in the next patch ...
>
> Cc: Chris Wilson
> Signed-off-by: Daniel Vetter
Reviewed-by: Chris Wilson
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
___
fb_helper->fbdev = NULL;
> +
> mutex_lock(&kernel_fb_helper_lock);
> if (!list_empty(&fb_helper->kernel_fb_list)) {
> list_del(&fb_helper->kernel_fb_list);
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
> b/drivers/gpu/drm/exyn
ths.
The error cleanup is a bit unobvious. The fbi is allocated during the
create/initial_fb callback, which is after a successful
framebuffer_init. The caller must be prepared to do a framebuffer_fini
(and so release_fbi will be handled if required) on failure or success.
-Chris
--
* drm_atomic_crtc_needs_modeset - compute combined modeset need
> * @state: &drm_crtc_state for the CRTC
> *
--
Chris Wilson, Intel Open Source Technology Centre
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Don't build test-drm_mm as a builtin? Or set a limit to the number of
tests to run, e.g. test-drm_mm.max_iterations=16 test-drm_mm.max_primes=16.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
The warnings from parsing the EDID are not driver errors, but the
"normal but significant" conditions from the external device. As such,
they do not need the ferocity of an *ERROR*, but can use the less harsh
DRM_NOTE instead.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/drm_e
nk goes the opposite way and leaks the state to
avoid the invalid deref, what we need is a ref around its existence on
the dependency queue if that is outside the lifetime of the commit.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Mon, Feb 13, 2017 at 08:41:10AM +0100, Thierry Reding wrote:
> On Fri, Feb 10, 2017 at 07:59:13PM +0000, Chris Wilson wrote:
> > The warnings from parsing the EDID are not driver errors, but the
> > "normal but significant" conditions from the external device. As such,
We are told not to set plane_state->fb directly, but use
drm_atomic_set_fb_for_plane() instead. Using the helper, means one less
piece of code that needs fixing should the interface change...
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/intel_display.c | 6 +-
1 file changed
T).
> 8 *
> 9 * Tests are executed in order by igt/drv_selftest
> 10 */
> > 11selftest(sanitycheck, i915_mock_sanitycheck) /* keep first (igt
> selfcheck) */
This is a named initializer for an anonymous union. It wasn't suppo
7;s a pre-existing error.
Signed-off-by: Chris Wilson
Cc: Sumit Semwal
Cc: Gustavo Padovan
Cc: Daniel Vetter
---
drivers/dma-buf/dma-fence.c | 17 ++---
drivers/dma-buf/sync_debug.c | 2 +-
drivers/dma-buf/sync_file.c | 8 +++-
include/linux/dma-fence.h| 2 ++
4 files ch
On Tue, Feb 14, 2017 at 11:40:38AM -0200, Gustavo Padovan wrote:
> Hi Chris,
>
> 2017-02-14 Chris Wilson :
> > diff --git a/drivers/dma-buf/sync_debug.c b/drivers/dma-buf/sync_debug.c
> > index c769dc653b34..bfead12390f2 100644
> > --- a/drivers/dma-buf/sync_debug.
On Tue, Feb 14, 2017 at 12:22:02PM -0200, Gustavo Padovan wrote:
> 2017-02-14 Chris Wilson :
>
> > On Tue, Feb 14, 2017 at 11:40:38AM -0200, Gustavo Padovan wrote:
> > > Hi Chris,
> > >
> > > 2017-02-14 Chris Wilson :
> > One thing that occ
On Tue, Feb 14, 2017 at 10:36:09PM +0100, Daniel Vetter wrote:
> On Mon, Feb 13, 2017 at 12:17:27PM -0500, Sean Paul wrote:
> > On Mon, Feb 13, 2017 at 3:59 AM, Chris Wilson
> > wrote:
> > > On Mon, Feb 13, 2017 at 08:41:10AM +0100, Thierry Reding wrote:
> > >>
On Wed, Feb 15, 2017 at 03:57:25PM -0200, Gustavo Padovan wrote:
> From: Gustavo Padovan
>
> Document return values for this function.
>
> Signed-off-by: Gustavo Padovan
Reviewed-by: Chris Wilson
-Chris
--
Chris Wilson, Intel Open Source Te
601 - 700 of 3785 matches
Mail list logo
