[PATCH 0/7] Add HDMI audio support on RK3288 veyron board

2019-06-02 Thread Cheng-Yi Chiang
e driver can set the correct hdmi-notifier on codec driver. Cheng-Yi Chiang (5): drm/bridge/synopsys: dw-hdmi: Add HDMI notifier support ASoC: rockchip_max98090: Add dai_link for HDMI ASoC: rockchip: rockchip-max98090: Add node for HDMI ASoC: rockchip_max98090: Add HDMI jack suppor

[PATCH 2/7] ASoC: hdmi-codec: use HDMI state notifier to add jack support

2019-06-02 Thread Cheng-Yi Chiang
From: Philipp Zabel Use HDMI connection / disconnection notifications to update an ALSA jack object. Also make a copy of the ELD block after every change. This was posted by Philipp Zabel at https://patchwork.kernel.org/patch/9430747/ Modified by Cheng-Yi Chiang: - Fix the conflict of removed

[PATCH 6/7] ASoC: rockchip_max98090: Add HDMI jack support

2019-06-02 Thread Cheng-Yi Chiang
In machine driver, create a jack and let hdmi-codec report jack status. Signed-off-by: Cheng-Yi Chiang --- sound/soc/rockchip/rockchip_max98090.c | 41 ++ 1 file changed, 41 insertions(+) diff --git a/sound/soc/rockchip/rockchip_max98090.c b/sound/soc/rockchip

[PATCH 1/7] video: add HDMI state notifier support

2019-06-02 Thread Cheng-Yi Chiang
object containing the HDMI state of an HDMI device. When a new notifier is registered the current state will be reported to that notifier at registration time. Based on Hans Verkuil's patch: https://patchwork.kernel.org/patch/9472521/ Modified by Cheng-Yi Chiang: - Add a section in MAINT

[PATCH 3/7] drm/bridge/synopsys: dw-hdmi: Add HDMI notifier support

2019-06-02 Thread Cheng-Yi Chiang
Use hdmi-notifier to notify codec driver that there is HDMI plug/unplug event. Signed-off-by: Cheng-Yi Chiang --- drivers/gpu/drm/bridge/synopsys/Kconfig | 1 + drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 28 +-- 2 files changed, 27 insertions(+), 2 deletions(-) diff

[PATCH 5/7] ASoC: rockchip: rockchip-max98090: Add node for HDMI

2019-06-02 Thread Cheng-Yi Chiang
Let user specify HDMI node so machine driver can use it to let codec driver register callback on correct hdmi-notifier. Signed-off-by: Cheng-Yi Chiang --- Documentation/devicetree/bindings/sound/rockchip-max98090.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree

[PATCH 7/7] ARM: dts: rockchip: Specify HDMI node to sound card node

2019-06-02 Thread Cheng-Yi Chiang
Sound card needs HDMI node in order to register jack callback on HDMI notifier. Signed-off-by: Cheng-Yi Chiang --- arch/arm/boot/dts/rk3288-veyron-analog-audio.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/rk3288-veyron-analog-audio.dtsi b/arch/arm/boot/dts/rk3288

[PATCH 4/7] ASoC: rockchip_max98090: Add dai_link for HDMI

2019-06-02 Thread Cheng-Yi Chiang
Use two dai_links. One for HDMI and one for max98090. With this setup, audio can play to speaker and HDMI selectively. Signed-off-by: Cheng-Yi Chiang --- sound/soc/rockchip/rockchip_max98090.c | 82 +++--- 1 file changed, 60 insertions(+), 22 deletions(-) diff --git a/sound

Re: [alsa-devel] [PATCH 2/7] ASoC: hdmi-codec: use HDMI state notifier to add jack support

2019-06-03 Thread Cheng-yi Chiang
On Mon, Jun 3, 2019 at 3:59 PM Amadeusz Sławiński wrote: > > On Mon, 3 Jun 2019 12:32:46 +0800 > Cheng-Yi Chiang wrote: > > > From: Philipp Zabel > > > > Use HDMI connection / disconnection notifications to update an ALSA > > jack object. Also make a copy

Re: [PATCH 1/7] video: add HDMI state notifier support

2019-06-03 Thread Cheng-yi Chiang
On Mon, Jun 3, 2019 at 3:46 PM Hans Verkuil wrote: > > On 6/3/19 6:32 AM, Cheng-Yi Chiang wrote: > > From: Hans Verkuil > > > > Add support for HDMI hotplug and EDID notifiers, which is used to convey > > information from HDMI drivers to their CEC and audio cou

Re: [PATCH 1/7] video: add HDMI state notifier support

2019-06-03 Thread Cheng-yi Chiang
On Mon, Jun 3, 2019 at 4:09 PM Daniel Vetter wrote: > > On Mon, Jun 03, 2019 at 09:45:49AM +0200, Hans Verkuil wrote: > > On 6/3/19 6:32 AM, Cheng-Yi Chiang wrote: > > > From: Hans Verkuil > > > > > > Add support for HDMI hotplug and EDID notifiers, which i

Re: [PATCH 1/7] video: add HDMI state notifier support

2019-06-11 Thread Cheng-yi Chiang
On Tue, Jun 4, 2019 at 3:24 PM Daniel Vetter wrote: > > On Tue, Jun 04, 2019 at 10:32:50AM +0800, Cheng-yi Chiang wrote: > > On Mon, Jun 3, 2019 at 4:09 PM Daniel Vetter wrote: > > > > > > On Mon, Jun 03, 2019 at 09:45:49AM +0200, Hans Verkuil wrote: > > &g

Re: [PATCH 1/7] video: add HDMI state notifier support

2019-06-18 Thread Cheng-yi Chiang
On Tue, Jun 11, 2019 at 8:35 PM Daniel Vetter wrote: > > On Tue, Jun 11, 2019 at 08:10:38PM +0800, Cheng-yi Chiang wrote: > > On Tue, Jun 4, 2019 at 3:24 PM Daniel Vetter wrote: > > > > > > On Tue, Jun 04, 2019 at 10:32:50AM +0800, Cheng-yi Chiang wrote: > >

Re: [PATCH 1/7] video: add HDMI state notifier support

2019-06-18 Thread Cheng-yi Chiang
On Tue, Jun 11, 2019 at 9:11 PM Hans Verkuil wrote: > > On 6/11/19 2:10 PM, Cheng-yi Chiang wrote: > > On Tue, Jun 4, 2019 at 3:24 PM Daniel Vetter wrote: > >> > >> On Tue, Jun 04, 2019 at 10:32:50AM +0800, Cheng-yi Chiang wrote: > >>> On Mon, J

Re: [PATCH 1/7] video: add HDMI state notifier support

2019-06-19 Thread Cheng-yi Chiang
On Tue, Jun 18, 2019 at 8:12 PM Daniel Vetter wrote: > > On Tue, Jun 18, 2019 at 07:48:06PM +0800, Cheng-yi Chiang wrote: > > On Tue, Jun 11, 2019 at 8:35 PM Daniel Vetter wrote: > > > > > > On Tue, Jun 11, 2019 at 08:10:38PM +0800, Cheng-yi Chiang wrote: > >

Re: [PATCH 1/7] video: add HDMI state notifier support

2019-06-20 Thread Cheng-yi Chiang
On Thu, Jun 20, 2019 at 5:25 PM Daniel Vetter wrote: > > On Wed, Jun 19, 2019 at 07:48:11PM +0800, Cheng-yi Chiang wrote: > > On Tue, Jun 18, 2019 at 8:12 PM Daniel Vetter wrote: > > > > > > On Tue, Jun 18, 2019 at 07:48:06PM +0800, Cheng-yi Chiang wrote: > >

Re: [PATCH 1/7] video: add HDMI state notifier support

2019-06-21 Thread Cheng-yi Chiang
On Fri, Jun 21, 2019 at 5:12 AM Daniel Vetter wrote: > > Massively cutting this thread, since halfway through in my previous reply > I realized that maybe hdmi_codec is a much better starting point. > ACK > On Thu, Jun 20, 2019 at 09:23:23PM +0800, Cheng-yi Chiang wrote: > >

[PATCH 0/4] Add HDMI jack support on RK3288

2019-07-04 Thread Cheng-Yi Chiang
a callback mechanism that is specific to hdmi-codec. Cheng-Yi Chiang (4): ASoC: hdmi-codec: Add an op to set callback function for plug event drm: bridge: dw-hdmi: Report connector status using callback ASoC: rockchip_max98090: Add dai_link for HDMI ASoC: rockchip_max98090: Add HDMI jack

[PATCH 2/4] drm: bridge: dw-hdmi: Report connector status using callback

2019-07-04 Thread Cheng-Yi Chiang
ce can register the callback. When connector plug/unplug event happens, report this event using the callback. Make sure that audio and drm are using the single source of truth for connector status. Signed-off-by: Cheng-Yi Chiang --- .../gpu/drm/bridge/synopsys/dw-hdmi-audio.h | 3 ++ .../drm/

[PATCH 1/4] ASoC: hdmi-codec: Add an op to set callback function for plug event

2019-07-04 Thread Cheng-Yi Chiang
Add an op in hdmi_codec_ops so codec driver can register callback function to handle plug event. Driver in DRM can use this callback function to report connector status. Signed-off-by: Cheng-Yi Chiang --- include/sound/hdmi-codec.h| 16 +++ sound/soc/codecs/hdmi-codec.c | 52

[PATCH 3/4] ASoC: rockchip_max98090: Add dai_link for HDMI

2019-07-04 Thread Cheng-Yi Chiang
Use two dai_links. One for HDMI and one for max98090. With this setup, audio can play to speaker and HDMI selectively. Signed-off-by: Cheng-Yi Chiang --- sound/soc/rockchip/rockchip_max98090.c | 91 +++--- 1 file changed, 68 insertions(+), 23 deletions(-) diff --git a/sound

[PATCH 4/4] ASoC: rockchip_max98090: Add HDMI jack support

2019-07-04 Thread Cheng-Yi Chiang
In machine driver, create a jack and let hdmi-codec report jack status. Signed-off-by: Cheng-Yi Chiang --- sound/soc/rockchip/rockchip_max98090.c | 21 + 1 file changed, 21 insertions(+) diff --git a/sound/soc/rockchip/rockchip_max98090.c b/sound/soc/rockchip

Re: [alsa-devel] [PATCH 2/4] drm: bridge: dw-hdmi: Report connector status using callback

2019-07-05 Thread Cheng-yi Chiang
On Fri, Jul 5, 2019 at 1:45 PM Jonas Karlman wrote: > > On 2019-07-05 06:26, Cheng-Yi Chiang wrote: > > Allow codec driver register callback function for plug event. > > > > The callback registration flow: > > dw-hdmi <--- hw-hdmi-i2s-audio <--- hdmi-codec

Re: [PATCH 2/4] drm: bridge: dw-hdmi: Report connector status using callback

2019-07-05 Thread Cheng-yi Chiang
On Fri, Jul 5, 2019 at 3:09 PM Tzung-Bi Shih wrote: > > On Fri, Jul 5, 2019 at 12:26 PM Cheng-Yi Chiang wrote: > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-audio.h > > b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-audio.h > > index 63b5756f463b..f523c590984e 1006

Re: [PATCH 3/4] ASoC: rockchip_max98090: Add dai_link for HDMI

2019-07-06 Thread Cheng-yi Chiang
On Fri, Jul 5, 2019 at 3:10 PM Tzung-Bi Shih wrote: > > On Fri, Jul 5, 2019 at 12:26 PM Cheng-Yi Chiang wrote: > > diff --git a/sound/soc/rockchip/rockchip_max98090.c > > b/sound/soc/rockchip/rockchip_max98090.c > > index c5fc24675a33..195309d1225a 100644 >

Re: [alsa-devel] [PATCH 2/4] drm: bridge: dw-hdmi: Report connector status using callback

2019-07-06 Thread Cheng-yi Chiang
On Sat, Jul 6, 2019 at 1:16 AM Mark Brown wrote: > > On Fri, Jul 05, 2019 at 03:31:24PM +0800, Cheng-yi Chiang wrote: > > > It was a long discussion. > > I think the conclusion was that if we are only talking about > > hdmi-codec, then we just need to extend the ops ex

Re: [PATCH 1/4] ASoC: hdmi-codec: Add an op to set callback function for plug event

2019-07-07 Thread Cheng-yi Chiang
On Fri, Jul 5, 2019 at 8:12 PM Mark Brown wrote: > > On Fri, Jul 05, 2019 at 03:08:37PM +0800, Tzung-Bi Shih wrote: > > On Fri, Jul 5, 2019 at 12:26 PM Cheng-Yi Chiang > > wrote: > > > > +typedef void (*hdmi_codec_plugged_c

Re: [PATCH 1/4] ASoC: hdmi-codec: Add an op to set callback function for plug event

2019-07-09 Thread Cheng-yi Chiang
On Tue, Jul 9, 2019 at 7:47 PM Cezary Rojewski wrote: > > On 2019-07-05 06:26, Cheng-Yi Chiang wrote: > > +static void hdmi_codec_jack_report(struct hdmi_codec_priv *hcp, > > +unsigned int jack_status) > > +{ > > + if (!hcp-&

Re: [PATCH 1/4] ASoC: hdmi-codec: Add an op to set callback function for plug event

2019-07-09 Thread Cheng-yi Chiang
On Mon, Jul 8, 2019 at 1:03 PM Cheng-yi Chiang wrote: > > On Fri, Jul 5, 2019 at 8:12 PM Mark Brown wrote: > > > > On Fri, Jul 05, 2019 at 03:08:37PM +0800, Tzung-Bi Shih wrote: > > > On Fri, Jul 5, 2019 at 12:26 PM Cheng-Yi Chiang > > > wrote: > > >

Re: [PATCH 5/7] ASoC: rockchip: rockchip-max98090: Add node for HDMI

2019-07-09 Thread Cheng-yi Chiang
On Wed, Jul 10, 2019 at 4:01 AM Rob Herring wrote: > > On Mon, Jun 03, 2019 at 12:32:49PM +0800, Cheng-Yi Chiang wrote: > > Let user specify HDMI node so machine driver can use it to let codec > > driver register callback on correct hdmi-notifier. > > > >

[PATCH v2 0/4] Add HDMI jack support on RK3288

2019-07-10 Thread Cheng-Yi Chiang
code when setting sysclk on cpu_dai and codec_dai. cpu_dai error should be reported. For HDMI codec_dai, there is no need to set sysclk. Cheng-Yi Chiang (4): ASoC: hdmi-codec: Add an op to set callback function for plug event drm: bridge: dw-hdmi: Report connector status using callback

[PATCH v2 1/4] ASoC: hdmi-codec: Add an op to set callback function for plug event

2019-07-10 Thread Cheng-Yi Chiang
Add an op in hdmi_codec_ops so codec driver can register callback function to handle plug event. Driver in DRM can use this callback function to report connector status. Signed-off-by: Cheng-Yi Chiang --- include/sound/hdmi-codec.h| 16 + sound/soc/codecs/hdmi-codec.c | 45

[PATCH v2 2/4] drm: bridge: dw-hdmi: Report connector status using callback

2019-07-10 Thread Cheng-Yi Chiang
ce can register the callback. When connector plug/unplug event happens, report this event using the callback. Make sure that audio and drm are using the single source of truth for connector status. Signed-off-by: Cheng-Yi Chiang --- .../gpu/drm/bridge/synopsys/dw-hdmi-audio.h | 3 + .../drm/

[PATCH v2 3/4] ASoC: rockchip_max98090: Add dai_link for HDMI

2019-07-10 Thread Cheng-Yi Chiang
Use two dai_links. One for HDMI and one for max98090. With this setup, audio can play to speaker and HDMI selectively. Signed-off-by: Cheng-Yi Chiang --- sound/soc/rockchip/rockchip_max98090.c | 95 +++--- 1 file changed, 72 insertions(+), 23 deletions(-) diff --git a/sound

[PATCH v2 4/4] ASoC: rockchip_max98090: Add HDMI jack support

2019-07-10 Thread Cheng-Yi Chiang
In machine driver, create a jack and let hdmi-codec report jack status. Signed-off-by: Cheng-Yi Chiang --- sound/soc/rockchip/rockchip_max98090.c | 21 + 1 file changed, 21 insertions(+) diff --git a/sound/soc/rockchip/rockchip_max98090.c b/sound/soc/rockchip

[PATCH v3 2/5] drm: bridge: dw-hdmi: Report connector status using callback

2019-07-12 Thread Cheng-Yi Chiang
ce can register the callback. When connector plug/unplug event happens, report this event using the callback. Make sure that audio and drm are using the single source of truth for connector status. Signed-off-by: Cheng-Yi Chiang --- .../gpu/drm/bridge/synopsys/dw-hdmi-audio.h | 3 + .../drm/

[PATCH v3 0/5] Add HDMI jack support on RK3288

2019-07-12 Thread Cheng-Yi Chiang
. - rockchip_max98090: Fix the dependency of hdmi-codec in Kconfig. Cheng-Yi Chiang (5): ASoC: hdmi-codec: Add an op to set callback function for plug event drm: bridge: dw-hdmi: Report connector status using callback drm: dw-hdmi-i2s: Use fixed id for codec device ASoC: rockchip_max98090: Add dai_link for

[PATCH v3 3/5] drm: dw-hdmi-i2s: Use fixed id for codec device

2019-07-12 Thread Cheng-Yi Chiang
should be fine because there will only be one hdmi-audio-codec device. Fix the codec name in rockchip rk3288_hdmi_analog machine driver. Signed-off-by: Cheng-Yi Chiang --- drivers/gpu/drm/bridge/synopsys/dw-hdmi-i2s-audio.c | 2 +- sound/soc/rockchip/rk3288_hdmi_analog.c | 3 ++- 2

[PATCH v3 1/5] ASoC: hdmi-codec: Add an op to set callback function for plug event

2019-07-12 Thread Cheng-Yi Chiang
Add an op in hdmi_codec_ops so codec driver can register callback function to handle plug event. Driver in DRM can use this callback function to report connector status. Signed-off-by: Cheng-Yi Chiang --- include/sound/hdmi-codec.h| 16 + sound/soc/codecs/hdmi-codec.c | 45

[PATCH v3 5/5] FROMLIST: ASoC: rockchip_max98090: Add HDMI jack support

2019-07-12 Thread Cheng-Yi Chiang
In machine driver, create a jack and let hdmi-codec report jack status. Signed-off-by: Cheng-Yi Chiang --- sound/soc/rockchip/rockchip_max98090.c | 20 1 file changed, 20 insertions(+) diff --git a/sound/soc/rockchip/rockchip_max98090.c b/sound/soc/rockchip

[PATCH v3 4/5] ASoC: rockchip_max98090: Add dai_link for HDMI

2019-07-12 Thread Cheng-Yi Chiang
Use two dai_links. One for HDMI and one for max98090. With this setup, audio can play to speaker and HDMI selectively. Signed-off-by: Cheng-Yi Chiang --- sound/soc/rockchip/Kconfig | 3 +- sound/soc/rockchip/rockchip_max98090.c | 96 -- 2 files changed, 75

Re: [PATCH v3 5/5] FROMLIST: ASoC: rockchip_max98090: Add HDMI jack support

2019-07-12 Thread Cheng-yi Chiang
On Fri, Jul 12, 2019 at 6:06 PM Cheng-Yi Chiang wrote: > > In machine driver, create a jack and let hdmi-codec report jack status. > > Signed-off-by: Cheng-Yi Chiang > --- > sound/soc/rockchip/rockchip_max98090.c | 20 > 1 file changed, 20 insertion

Re: [PATCH v3 1/5] ASoC: hdmi-codec: Add an op to set callback function for plug event

2019-07-16 Thread Cheng-yi Chiang
On Mon, Jul 15, 2019 at 11:56 PM Tzung-Bi Shih wrote: > > On Fri, Jul 12, 2019 at 6:58 PM Russell King - ARM Linux admin > wrote: > > > > On Fri, Jul 12, 2019 at 06:04:39PM +0800, Cheng-Yi Chiang wrote: > > > Add an op in hdmi_codec_ops so codec driver can regis

[PATCH v4 2/5] drm: bridge: dw-hdmi: Report connector status using callback

2019-07-16 Thread Cheng-Yi Chiang
def of hdmi_codec_plugged_cb to be used in dw-hdmi.c. Signed-off-by: Cheng-Yi Chiang --- drivers/gpu/drm/bridge/synopsys/Kconfig | 2 +- .../drm/bridge/synopsys/dw-hdmi-i2s-audio.c | 11 + drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 41 ++- include/drm/bridge/dw_

[PATCH v4 3/5] drm: dw-hdmi-i2s: Use fixed id for codec device

2019-07-16 Thread Cheng-Yi Chiang
should be fine because there will only be one hdmi-audio-codec device. Fix the codec name in rockchip rk3288_hdmi_analog machine driver. Signed-off-by: Cheng-Yi Chiang --- drivers/gpu/drm/bridge/synopsys/dw-hdmi-i2s-audio.c | 2 +- sound/soc/rockchip/rk3288_hdmi_analog.c | 3 ++- 2

[PATCH v4 0/5] Add HDMI jack support on RK3288

2019-07-16 Thread Cheng-Yi Chiang
hdmi-codec in Kconfig. - Fixed the incorrect FROMLIST title of patch 5/5. Cheng-Yi Chiang (5): ASoC: hdmi-codec: Add an op to set callback function for plug event drm: bridge: dw-hdmi: Report connector status using callback drm: dw-hdmi-i2s: Use fixed id for codec device ASoC

[PATCH v4 1/5] ASoC: hdmi-codec: Add an op to set callback function for plug event

2019-07-16 Thread Cheng-Yi Chiang
Add an op in hdmi_codec_ops so codec driver can register callback function to handle plug event. Driver in DRM can use this callback function to report connector status. Signed-off-by: Cheng-Yi Chiang --- include/sound/hdmi-codec.h| 17 + sound/soc/codecs/hdmi-codec.c | 46

[PATCH v4 4/5] ASoC: rockchip_max98090: Add dai_link for HDMI

2019-07-16 Thread Cheng-Yi Chiang
Use two dai_links. One for HDMI and one for max98090. With this setup, audio can play to speaker and HDMI selectively. Signed-off-by: Cheng-Yi Chiang --- sound/soc/rockchip/Kconfig | 3 +- sound/soc/rockchip/rockchip_max98090.c | 96 -- 2 files changed, 75

[PATCH v4 5/5] ASoC: rockchip_max98090: Add HDMI jack support

2019-07-16 Thread Cheng-Yi Chiang
In machine driver, create a jack and let hdmi-codec report jack status. Signed-off-by: Cheng-Yi Chiang --- sound/soc/rockchip/rockchip_max98090.c | 20 1 file changed, 20 insertions(+) diff --git a/sound/soc/rockchip/rockchip_max98090.c b/sound/soc/rockchip

Re: [PATCH v4 2/5] drm: bridge: dw-hdmi: Report connector status using callback

2019-07-16 Thread Cheng-yi Chiang
On Tue, Jul 16, 2019 at 10:13 PM Tzung-Bi Shih wrote: > > On Tue, Jul 16, 2019 at 7:57 PM Cheng-Yi Chiang wrote: > > > > Change the Kconfig of DRM_DW_HDMI so it selects SND_SOC_HDMI_CODEC. > > This is for the typedef of hdmi_codec_plugged_cb to be used in dw-hdmi.c. &

Re: [PATCH v3 2/5] drm: bridge: dw-hdmi: Report connector status using callback

2019-07-17 Thread Cheng-yi Chiang
On Fri, Jul 12, 2019 at 6:48 PM Russell King - ARM Linux admin wrote: > > On Fri, Jul 12, 2019 at 06:04:40PM +0800, Cheng-Yi Chiang wrote: > > Allow codec driver register callback function for plug event. > > > > The callback registration flow: > > dw-hdmi <---

Re: [PATCH v4 4/5] ASoC: rockchip_max98090: Add dai_link for HDMI

2019-07-17 Thread Cheng-yi Chiang
On Tue, Jul 16, 2019 at 10:14 PM Tzung-Bi Shih wrote: > > On Tue, Jul 16, 2019 at 7:58 PM Cheng-Yi Chiang wrote: > > > > diff --git a/sound/soc/rockchip/Kconfig b/sound/soc/rockchip/Kconfig > > index b43657e6e655..d610b553ea3b 100644 > > --- a/sound/soc/rockch

Re: [PATCH v4 5/5] ASoC: rockchip_max98090: Add HDMI jack support

2019-07-17 Thread Cheng-yi Chiang
On Tue, Jul 16, 2019 at 10:16 PM Tzung-Bi Shih wrote: > > On Tue, Jul 16, 2019 at 7:58 PM Cheng-Yi Chiang wrote: > > > > diff --git a/sound/soc/rockchip/rockchip_max98090.c > > b/sound/soc/rockchip/rockchip_max98090.c > > index c82948e383da..c81c4acda917 10064

[PATCH v5 1/5] ASoC: hdmi-codec: Add an op to set callback function for plug event

2019-07-17 Thread Cheng-Yi Chiang
Add an op in hdmi_codec_ops so codec driver can register callback function to handle plug event. Driver in DRM can use this callback function to report connector status. Signed-off-by: Cheng-Yi Chiang --- include/sound/hdmi-codec.h| 17 + sound/soc/codecs/hdmi-codec.c | 46

[PATCH v5 0/5] Add HDMI jack support on RK3288

2019-07-17 Thread Cheng-Yi Chiang
a callback mechanism that is specific to hdmi-codec. Changes from v4 to v5: - synopsys/Kconfig: Remove the incorrect dependency change in v4. - rockchip/Kconfig: Add dependency of hdmi-codec when it is really need for jack support. Cheng-Yi Chiang (5): ASoC: hdmi-codec: Add an op to set

[PATCH v5 2/5] drm: bridge: dw-hdmi: Report connector status using callback

2019-07-17 Thread Cheng-Yi Chiang
atform device can register the callback. When connector plug/unplug event happens, report this event using the callback. Make sure that audio and drm are using the single source of truth for connector status. Signed-off-by: Cheng-Yi Chiang --- .../drm/bridge/synopsys/dw-hdmi-i2s-audio.c

[PATCH v5 5/5] ASoC: rockchip_max98090: Add HDMI jack support

2019-07-17 Thread Cheng-Yi Chiang
In machine driver, create a jack and let hdmi-codec report jack status. Signed-off-by: Cheng-Yi Chiang --- sound/soc/rockchip/Kconfig | 3 ++- sound/soc/rockchip/rockchip_max98090.c | 20 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/sound/soc

[PATCH v5 3/5] drm: dw-hdmi-i2s: Use fixed id for codec device

2019-07-17 Thread Cheng-Yi Chiang
should be fine because there will only be one hdmi-audio-codec device. Fix the codec name in rockchip rk3288_hdmi_analog machine driver. Signed-off-by: Cheng-Yi Chiang --- drivers/gpu/drm/bridge/synopsys/dw-hdmi-i2s-audio.c | 2 +- sound/soc/rockchip/rk3288_hdmi_analog.c | 3 ++- 2

[PATCH v5 4/5] ASoC: rockchip_max98090: Add dai_link for HDMI

2019-07-17 Thread Cheng-Yi Chiang
Use two dai_links. One for HDMI and one for max98090. With this setup, audio can play to speaker and HDMI selectively. Signed-off-by: Cheng-Yi Chiang --- sound/soc/rockchip/rockchip_max98090.c | 96 -- 1 file changed, 73 insertions(+), 23 deletions(-) diff --git a/sound

[PATCH v8 0/6] Add HDMI jack support on RK3288

2019-10-28 Thread Cheng-Yi Chiang
. Cheng-Yi Chiang (6): drm: bridge: dw-hdmi: Report connector status using callback ASoC: rockchip-max98090: Support usage with and without HDMI ASoC: rockchip_max98090: Optionally support HDMI use case ASoC: rockchip_max98090: Add HDMI jack support ARM: dts: rockchip: Add HDMI support to

[PATCH v8 5/6] ARM: dts: rockchip: Add HDMI support to rk3288-veyron-analog-audio

2019-10-28 Thread Cheng-Yi Chiang
All boards using rk3288-veyron-analog-audio.dtsi have HDMI audio. Specify the support of HDMI audio on machine driver using compatible string so machine driver creates HDMI audio device. Signed-off-by: Cheng-Yi Chiang --- arch/arm/boot/dts/rk3288-veyron-analog-audio.dtsi | 3 ++- 1 file changed

[PATCH v8 1/6] drm: bridge: dw-hdmi: Report connector status using callback

2019-10-28 Thread Cheng-Yi Chiang
atform device can register the callback. When connector plug/unplug event happens, report this event using the callback. Make sure that audio and drm are using the single source of truth for connector status. Signed-off-by: Cheng-Yi Chiang --- .../drm/bridge/synopsys/dw-hdmi-i2s-audio.c

[PATCH v9 5/6] ARM: dts: rockchip: Add HDMI support to rk3288-veyron-analog-audio

2019-10-28 Thread Cheng-Yi Chiang
All boards using rk3288-veyron-analog-audio.dtsi have HDMI audio. Specify the support of HDMI audio on machine driver using rockchip,hdmi-codec property so machine driver creates HDMI audio device. Signed-off-by: Cheng-Yi Chiang --- arch/arm/boot/dts/rk3288-veyron-analog-audio.dtsi | 1 + 1

[PATCH v9 4/6] ASoC: rockchip_max98090: Add HDMI jack support

2019-10-28 Thread Cheng-Yi Chiang
In machine driver, create a jack and let hdmi-codec report jack status. Signed-off-by: Cheng-Yi Chiang --- sound/soc/rockchip/Kconfig | 3 ++- sound/soc/rockchip/rockchip_max98090.c | 22 ++ 2 files changed, 24 insertions(+), 1 deletion(-) diff --git a/sound

[PATCH v9 2/6] ASoC: rockchip-max98090: Support usage with and without HDMI

2019-10-28 Thread Cheng-Yi Chiang
ec "rockchip,headset-codec": The phandle of Ext chip for jack detection Signed-off-by: Cheng-Yi Chiang --- .../bindings/sound/rockchip-max98090.txt | 27 +-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/

[PATCH v8 2/6] ASoC: rockchip-max98090: Support usage with and without HDMI

2019-10-28 Thread Cheng-Yi Chiang
ec in rockchip-max98090. Add one optional property "rockchip,hdmi-codec" to let user specify HDMI device node in DTS so machine driver can find hdmi-codec device node for codec DAI. Signed-off-by: Cheng-Yi Chiang --- .../bindings/sound/rockchip-max98090.txt | 38 +-- 1

[PATCH v9 6/6] ARM: dts: rockchip: Add HDMI audio support to rk3288-veyron-mickey.dts

2019-10-28 Thread Cheng-Yi Chiang
Add HDMI audio support to veyron-mickey. The sound card should expose one audio device for HDMI. Signed-off-by: Cheng-Yi Chiang --- arch/arm/boot/dts/rk3288-veyron-mickey.dts | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/rk3288-veyron-mickey.dts b/arch/arm/boot

[PATCH v9 1/6] drm: bridge: dw-hdmi: Report connector status using callback

2019-10-28 Thread Cheng-Yi Chiang
atform device can register the callback. When connector plug/unplug event happens, report this event using the callback. Make sure that audio and drm are using the single source of truth for connector status. Signed-off-by: Cheng-Yi Chiang --- .../drm/bridge/synopsys/dw-hdmi-i2s-audio.c

Re: [PATCH v8 2/6] ASoC: rockchip-max98090: Support usage with and without HDMI

2019-10-28 Thread Cheng-yi Chiang
On Sat, Oct 26, 2019 at 12:22 AM Rob Herring wrote: > > On Fri, Oct 25, 2019 at 09:30:03PM +0800, Cheng-Yi Chiang wrote: > > There will be multiple boards sharing this machine driver. > > Use compatible string to specify the use case. > > > > "rockchip,rockchi

[PATCH v8 3/6] ASoC: rockchip_max98090: Optionally support HDMI use case

2019-10-28 Thread Cheng-Yi Chiang
backward compatibility. From devicetree, different compatible string can be passed to configure the usage. Signed-off-by: Cheng-Yi Chiang --- The checkpatch error "Macros with complex values should be enclosed in parentheses" seems not suitable for the macro usage for DAPM widget, route, an

[PATCH v8 6/6] ARM: dts: rockchip: Add HDMI audio support to rk3288-veyron-mickey.dts

2019-10-28 Thread Cheng-Yi Chiang
Add HDMI audio support to veyron-mickey. The sound card should expose one audio device for HDMI. Signed-off-by: Cheng-Yi Chiang --- arch/arm/boot/dts/rk3288-veyron-mickey.dts | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/rk3288-veyron-mickey.dts b/arch/arm/boot

[PATCH v8 4/6] ASoC: rockchip_max98090: Add HDMI jack support

2019-10-28 Thread Cheng-Yi Chiang
In machine driver, create a jack and let hdmi-codec report jack status. Signed-off-by: Cheng-Yi Chiang --- sound/soc/rockchip/Kconfig | 3 ++- sound/soc/rockchip/rockchip_max98090.c | 21 + 2 files changed, 23 insertions(+), 1 deletion(-) diff --git a/sound/soc

[PATCH v9 3/6] ASoC: rockchip_max98090: Optionally support HDMI use case

2019-10-28 Thread Cheng-Yi Chiang
-by: Cheng-Yi Chiang --- The checkpatch reported error "Macros with complex values should be enclosed in parentheses". It is ignored because it does not suit the usage in this patch. sound/soc/rockchip/rockchip_max98090.c | 291 +++-- 1 file changed, 226 inserti

[PATCH v9 0/6] Add HDMI jack support on RK3288

2019-10-28 Thread Cheng-Yi Chiang
chip,audio-codec to determine the presense of max98090 in sound card. Use the presence of rockchip,hdmi-codec to determine the presence of HDMI in sound card. Remove the compatible strings added in v8. 2. #include should be in the patch of adding HDMI jack support. Cheng-Yi Chiang

Re: [PATCH v8 3/6] ASoC: rockchip_max98090: Optionally support HDMI use case

2019-10-30 Thread Cheng-yi Chiang
e, please drop us a note to help > improve the system. BTW, we also suggest to use '--base' option to specify the > base tree in git format-patch, please see > https://stackoverflow.com/a/37406982] > > url: > https://github.com/0day-ci/linux/commits/Cheng-Yi-Chiang/Ad

Re: [PATCH v2 RESEND] drm/bridge: dw-hdmi: Restore audio when setting a mode

2019-10-07 Thread Cheng-yi Chiang
On Mon, Oct 7, 2019 at 7:57 PM Neil Armstrong wrote: > > Hi, > > On 03/10/2019 06:14, Cheng-Yi Chiang wrote: > > From: Daniel Kurtz > > > > When setting a new display mode, dw_hdmi_setup() calls > > dw_hdmi_enable_video_path(), which disables all hdmi c

[PATCH v3] drm/bridge: dw-hdmi: Restore audio when setting a mode

2019-10-08 Thread Cheng-Yi Chiang
, there will be HDMI audio on some monitors if i2s was played to headphone when the monitor was plugged. ACER H277HU and ASUS PB278 are two of the monitors showing this issue. Signed-off-by: Cheng-Yi Chiang Signed-off-by: Daniel Kurtz Signed-off-by: Yakir Yang --- Change from v2 to v3: - Remove

Re: [PATCH v5 0/5] Add HDMI jack support on RK3288

2019-09-18 Thread Cheng-yi Chiang
On Fri, Sep 13, 2019 at 5:33 PM Neil Armstrong wrote: > > Hi, > > On 09/09/2019 15:53, Mark Brown wrote: > > On Mon, Sep 09, 2019 at 09:37:14AM +0200, Neil Armstrong wrote: > > > >> I'd like some review from ASoC people and other drm bridge reviewers, > >> Jernej, Jonas & Andrzej. > > > >> Jonas c

[PATCH v6 1/4] drm: bridge: dw-hdmi: Report connector status using callback

2019-09-18 Thread Cheng-Yi Chiang
atform device can register the callback. When connector plug/unplug event happens, report this event using the callback. Make sure that audio and drm are using the single source of truth for connector status. Signed-off-by: Cheng-Yi Chiang --- .../drm/bridge/synopsys/dw-hdmi-i2s-audio.c

[PATCH v6 0/4] Add HDMI jack support on RK3288

2019-09-18 Thread Cheng-Yi Chiang
. 2. Rebase the rest of patches based on drm-misc-next tree. Cheng-Yi Chiang (4): drm: bridge: dw-hdmi: Report connector status using callback drm: dw-hdmi-i2s: Use fixed id for codec device ASoC: rockchip_max98090: Add dai_link for HDMI ASoC: rockchip_max98090: Add HDMI jack support

[PATCH v6 2/4] drm: dw-hdmi-i2s: Use fixed id for codec device

2019-09-18 Thread Cheng-Yi Chiang
should be fine because there will only be one hdmi-audio-codec device. Fix the codec name in rockchip rk3288_hdmi_analog machine driver. Signed-off-by: Cheng-Yi Chiang --- drivers/gpu/drm/bridge/synopsys/dw-hdmi-i2s-audio.c | 2 +- sound/soc/rockchip/rk3288_hdmi_analog.c | 3 ++- 2

Re: [PATCH v6 2/4] drm: dw-hdmi-i2s: Use fixed id for codec device

2019-09-18 Thread Cheng-yi Chiang
On Wed, Sep 18, 2019 at 4:43 PM Jerome Brunet wrote: > > > On Wed 18 Sep 2019 at 10:24, Cheng-Yi Chiang wrote: > > > The problem of using auto ID is that the device name will be like > > hdmi-audio-codec..auto. > > > > The number might be changed when th

[PATCH v6 3/4] ASoC: rockchip_max98090: Add dai_link for HDMI

2019-09-19 Thread Cheng-Yi Chiang
Use two dai_links. One for HDMI and one for max98090. With this setup, audio can play to speaker and HDMI selectively. Signed-off-by: Cheng-Yi Chiang --- sound/soc/rockchip/rockchip_max98090.c | 96 -- 1 file changed, 73 insertions(+), 23 deletions(-) diff --git a/sound

[PATCH v6 4/4] ASoC: rockchip_max98090: Add HDMI jack support

2019-09-19 Thread Cheng-Yi Chiang
In machine driver, create a jack and let hdmi-codec report jack status. Signed-off-by: Cheng-Yi Chiang --- sound/soc/rockchip/Kconfig | 3 ++- sound/soc/rockchip/rockchip_max98090.c | 20 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/sound/soc

[PATCH v7 2/4] ASoC: rockchip-max98090: Add description for rockchip,hdmi-codec

2019-09-19 Thread Cheng-Yi Chiang
Add support for HDMI codec in rockchip-max98090. Let user specify HDMI device node in DTS so machine driver can find hdmi-codec device node for codec DAI. Signed-off-by: Cheng-Yi Chiang --- Documentation/devicetree/bindings/sound/rockchip-max98090.txt | 2 ++ 1 file changed, 2 insertions

[PATCH v7 4/4] ASoC: rockchip_max98090: Add HDMI jack support

2019-09-19 Thread Cheng-Yi Chiang
In machine driver, create a jack and let hdmi-codec report jack status. Signed-off-by: Cheng-Yi Chiang --- sound/soc/rockchip/Kconfig | 3 ++- sound/soc/rockchip/rockchip_max98090.c | 20 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/sound/soc

[PATCH v7 0/4] Add HDMI jack support on RK3288

2019-09-20 Thread Cheng-Yi Chiang
. With this we don't need to set fixed id for the created hdmi-audio-codec device. Cheng-Yi Chiang (4): drm: bridge: dw-hdmi: Report connector status using callback ASoC: rockchip-max98090: Add description for rockchip,hdmi-codec ASoC: rockchip_max98090: Add dai_link for HDMI

[PATCH v7 1/4] drm: bridge: dw-hdmi: Report connector status using callback

2019-09-20 Thread Cheng-Yi Chiang
atform device can register the callback. When connector plug/unplug event happens, report this event using the callback. Make sure that audio and drm are using the single source of truth for connector status. Signed-off-by: Cheng-Yi Chiang --- .../drm/bridge/synopsys/dw-hdmi-i2s-audio.c

[PATCH v7 3/4] ASoC: rockchip_max98090: Add dai_link for HDMI

2019-09-20 Thread Cheng-Yi Chiang
Use two dai_links. One for HDMI and one for max98090. With this setup, audio can play to speaker and HDMI selectively. Signed-off-by: Cheng-Yi Chiang --- .../boot/dts/rk3288-veyron-analog-audio.dtsi | 1 + sound/soc/rockchip/rockchip_max98090.c| 129 ++ 2 files

Re: [PATCH v7 3/4] ASoC: rockchip_max98090: Add dai_link for HDMI

2019-09-20 Thread Cheng-yi Chiang
On Thu, Sep 19, 2019 at 11:08 PM Jernej Škrabec wrote: > > Hi! > > Dne četrtek, 19. september 2019 ob 15:54:49 CEST je Cheng-Yi Chiang > napisal(a): > > Use two dai_links. One for HDMI and one for max98090. > > With this setup, audio can play to speaker and HDMI selecti

[PATCH] drm/bridge: dw-hdmi: Restore audio when setting a mode

2019-09-30 Thread Cheng-Yi Chiang
, there will be HDMI audio on some monitors if i2s was played to headphone when the monitor was plugged. ACER H277HU and ASUS PB278 are two of the monitors showing this issue. Signed-off-by: Cheng-Yi Chiang Signed-off-by: Daniel Kurtz Signed-off-by: Yakir Yang --- drivers/gpu/drm/bridge/synopsys/dw

[PATCH v2] FROMLIST: drm/bridge: dw-hdmi: Restore audio when setting a mode

2019-10-02 Thread Cheng-Yi Chiang
, there will be HDMI audio on some monitors if i2s was played to headphone when the monitor was plugged. ACER H277HU and ASUS PB278 are two of the monitors showing this issue. Signed-off-by: Cheng-Yi Chiang Signed-off-by: Daniel Kurtz Signed-off-by: Yakir Yang --- Change from v1 to v2: - Use

[PATCH v2 RESEND] drm/bridge: dw-hdmi: Restore audio when setting a mode

2019-10-02 Thread Cheng-Yi Chiang
, there will be HDMI audio on some monitors if i2s was played to headphone when the monitor was plugged. ACER H277HU and ASUS PB278 are two of the monitors showing this issue. Signed-off-by: Cheng-Yi Chiang Signed-off-by: Daniel Kurtz Signed-off-by: Yakir Yang --- Change from v1 to v2: - Use

[PATCH] drm: dw-hdmi-i2s: enable audio clock in audio_startup

2019-08-28 Thread Cheng-Yi Chiang
in audio_startup ops before hw_param ops setting format. Signed-off-by: Cheng-Yi Chiang --- drivers/gpu/drm/bridge/synopsys/dw-hdmi-i2s-audio.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-i2s-audio.c b/drivers/gpu/drm/bridge/synopsys/dw

Re: [PATCH v5 0/5] Add HDMI jack support on RK3288

2019-08-29 Thread Cheng-yi Chiang
On Wed, Jul 17, 2019 at 6:28 PM Tzung-Bi Shih wrote: > > On Wed, Jul 17, 2019 at 4:33 PM Cheng-Yi Chiang wrote: > > > > This patch series supports HDMI jack reporting on RK3288, which uses > > DRM dw-hdmi driver and hdmi-codec codec driver. > > > > The prev

Re: [PATCH] drm: dw-hdmi-i2s: enable audio clock in audio_startup

2019-09-01 Thread Cheng-yi Chiang
On Sun, Sep 1, 2019 at 6:04 PM Jonas Karlman wrote: > > On 2019-08-29 06:29, Cheng-Yi Chiang wrote: > > In the designware databook, the sequence of enabling audio clock and > > setting format is not clearly specified. > > Currently, audio clock is enabled in the e

[PATCH v2] drm: dw-hdmi-i2s: enable audio clock in audio_startup

2019-09-01 Thread Cheng-Yi Chiang
in audio_startup ops before hw_param ops setting format. Signed-off-by: Cheng-Yi Chiang Reviewed-by: Douglas Anderson Reviewed-by: Jonas Karlman Tested-by: Douglas Anderson --- Changes from v1: 1. Move audio_startup to the front of audio_shutdown. 2. Fix the indentation of audio_startup

[PATCH] drm: bridge/dw_hdmi: add audio sample channel status setting

2019-09-02 Thread Cheng-Yi Chiang
come out on some monitors (e.g. LG 22CV241) Signed-off-by: Yakir Yang Signed-off-by: Cheng-Yi Chiang --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 59 +++ drivers/gpu/drm/bridge/synopsys/dw-hdmi.h | 20 2 files changed, 79 insertions(+) diff --git a/drivers/gpu

Re: [PATCH] drm: bridge/dw_hdmi: add audio sample channel status setting

2019-09-04 Thread Cheng-yi Chiang
Hi, On Tue, Sep 3, 2019 at 5:53 PM Neil Armstrong wrote: > > Hi, > > On 03/09/2019 07:51, Cheng-Yi Chiang wrote: > > From: Yakir Yang > > > > When transmitting IEC60985 linear PCM audio, we configure the > > Audio Sample Channel Status information of al

Re: [PATCH] drm: bridge/dw_hdmi: add audio sample channel status setting

2019-09-04 Thread Cheng-yi Chiang
On Wed, Sep 4, 2019 at 2:00 AM Neil Armstrong wrote: > > Hi, > > Le 03/09/2019 à 11:53, Neil Armstrong a écrit : > > Hi, > > > > On 03/09/2019 07:51, Cheng-Yi Chiang wrote: > >> From: Yakir Yang > >> > >> When transmitting IEC60985 lin

  1   2   >