Re: DRM Format Modifiers in v4l2

2017-08-30 Thread Brian Starkey
On Wed, Aug 30, 2017 at 10:10:01AM +0200, Hans Verkuil wrote: On 30/08/17 09:50, Daniel Vetter wrote: On Tue, Aug 29, 2017 at 10:47:01AM +0100, Brian Starkey wrote: The fact is, adding special formats for each combination is unmanageable - we're talking dozens in the case of our hardware.

Re: DRM Format Modifiers in v4l2

2017-08-30 Thread Brian Starkey
On Wed, Aug 30, 2017 at 11:53:58AM +0200, Hans Verkuil wrote: On 30/08/17 11:36, Brian Starkey wrote: On Wed, Aug 30, 2017 at 10:10:01AM +0200, Hans Verkuil wrote: On 30/08/17 09:50, Daniel Vetter wrote: On Tue, Aug 29, 2017 at 10:47:01AM +0100, Brian Starkey wrote: The fact is, adding

Re: DRM Format Modifiers in v4l2

2017-08-31 Thread Brian Starkey
Hi Laurent, On Thu, Aug 31, 2017 at 05:51:33PM +0300, Laurent Pinchart wrote: Hi Brian, On Wednesday, 30 August 2017 13:32:01 EEST Brian Starkey wrote: On Wed, Aug 30, 2017 at 11:53:58AM +0200, Hans Verkuil wrote: > On 30/08/17 11:36, Brian Starkey wrote: >> On Wed, Aug 30, 2017 at 1

Re: [PATCH 1/4] drm/uapi: The ctm matrix uses sign-magnitude representation

2018-02-23 Thread Brian Starkey
docs to match the current implementation, and change the type from __s64 to __u64 to drive the point home. I totally agree that this is a good idea, but... Cc: dri-devel@lists.freedesktop.org Cc: Mihail Atanassov Cc: Liviu Dudau Cc: Brian Starkey Cc: Mali DP Maintainers Cc: Johnson Lin Cc

Re: [PATCH 04/41] drm/arm: hdlcd: Use .dumb_map_offset and .dumb_destroy defaults

2017-07-24 Thread Brian Starkey
Hi Noralf, Thanks for the patch, On Sun, Jul 23, 2017 at 09:16:20PM +0200, Noralf Tr??nnes wrote: This driver can use the drm_driver.dumb_destroy and drm_driver.dumb_map_offset defaults, so no need to set them. Cc: Liviu Dudau Signed-off-by: Noralf Tr??nnes Acked-by: Brian Starkey

Re: [PATCH 05/41] drm/arm: mali-dp: Use .dumb_map_offset and .dumb_destroy defaults

2017-07-24 Thread Brian Starkey
Hi Noralf, On Sun, Jul 23, 2017 at 09:16:21PM +0200, Noralf Tr??nnes wrote: This driver can use the drm_driver.dumb_destroy and drm_driver.dumb_map_offset defaults, so no need to set them. Cc: Liviu Dudau Cc: Brian Starkey Signed-off-by: Noralf Tr??nnes Acked-by: Brian Starkey

Re: [PATCH] drm/fourcc: add LINEAR modifiers with an exact pitch alignment

2024-12-17 Thread Brian Starkey
On Tue, Dec 17, 2024 at 11:13:05AM +, Michel Dänzer wrote: > On 2024-12-17 10:14, Brian Starkey wrote: > > On Sun, Dec 15, 2024 at 03:53:14PM +, Marek Olšák wrote: > >> The comment explains the problem with DRM_FORMAT_MOD_LINEAR. > >> > >> Signed-off-by:

Re: [PATCH] drm/fourcc: add LINEAR modifiers with an exact pitch alignment

2024-12-17 Thread Brian Starkey
Hi, On Sun, Dec 15, 2024 at 03:53:14PM +, Marek Olšák wrote: > The comment explains the problem with DRM_FORMAT_MOD_LINEAR. > > Signed-off-by: Marek Olšák > > diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h > index 78abd819fd62e..8ec4163429014 100644 > --- a/inclu

Re: [PATCH] drm/fourcc: add LINEAR modifiers with an exact pitch alignment

2024-12-18 Thread Brian Starkey
On Wed, Dec 18, 2024 at 11:24:58AM +, Simona Vetter wrote: > > For that reason I think linear modifiers with explicit pitch/size > alignment constraints is a sound concept and fits into how modifiers work > overall. > -Sima Could we make it (more) clear that pitch alignment is a "special" con

Re: [PATCH] drm/fourcc: add LINEAR modifiers with an exact pitch alignment

2024-12-19 Thread Brian Starkey
On Wed, Dec 18, 2024 at 09:53:56PM +, Marek Olšák wrote: > On Wed, Dec 18, 2024 at 5:32 AM Brian Starkey wrote: > > > On Wed, Dec 18, 2024 at 11:24:58AM +, Simona Vetter wrote: > > > > > > For that reason I think linear modifiers with explicit pitch/size &g

Re: [PATCH] drm/fourcc: add LINEAR modifiers with an exact pitch alignment

2024-12-20 Thread Brian Starkey
el raised. That needs addressing. On Thu, Dec 19, 2024 at 07:33:07PM +, Marek Olšák wrote: > On Thu, Dec 19, 2024 at 5:32 AM Brian Starkey wrote: > > > On Wed, Dec 18, 2024 at 09:53:56PM +, Marek Olšák wrote: > > The pitch doesn't always describe the layout. In prac

<    1   2   3   4   5