Rob Clark
> Fixes: 2d99ced787e3d ("drm/msm: async commit support")
Nice job tracking down this fix!
Reviewed-by: Brian Masney
Tested-by: Brian Masney
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
upport")
> Cc: Brian Masney
> Cc: Dan Murphy
> Signed-off-by: Andy Shevchenko
Reviewed-by: Brian Masney
> Cc: Maarten Lankhorst
> Cc: Maxime Ripard
> Cc: dri-devel@lists.freedesktop.org
> Cc: Dave Airlie
> Cc: Thierry Reding
This patch fixes the build error that I see with qcom_defconfig in
linux-next.
Tested-by: Brian Masney
On Wed, Dec 30, 2020 at 05:29:42PM +0200, Iskren Chernev wrote:
> From: Craig Tatlor
>
> vram.size is needed when binding a gpu without an iommu and is defined
> in msm_init_vram(), so run that before binding it.
>
> Signed-off-by: Craig Tatlor
For the series:
Reviewe
On Thu, May 02, 2019 at 11:07:51AM +0100, Daniel Thompson wrote:
> On 24/04/2019 10:25, Brian Masney wrote:
> > lm3630a_bank_a_update_status() and lm3630a_bank_b_update_status()
> > both return the brightness value if the brightness was successfully
> > updated. Writing to
On Thu, May 02, 2019 at 11:19:50AM +0100, Daniel Thompson wrote:
> On 24/04/2019 10:25, Brian Masney wrote:
> > Add fwnode support to the lm3630a driver and optionally allow
> > configuring the label, default brightness level, and maximum brightness
> > level. The two outputs
Add drm_atomic_helper_dirtyfb() callback to the msm framebuffer driver
for the dirty ioctl.
Signed-off-by: Brian Masney
---
drivers/gpu/drm/msm/msm_fb.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/msm/msm_fb.c b/drivers/gpu/drm/msm/msm_fb.c
index 136058978e0f
_msm_gem_new() calls msm_gem_new_impl() with a NULL reservation_object
struct. msm_atomic_prepare_fb() assumes that the reservation_object is
always set, and attempts to reference a NULL pointer. Correct this by
checking to see if this value is NULL.
Signed-off-by: Brian Masney
---
drivers/gpu
Add necessary device tree nodes for the main LCD backlight.
Signed-off-by: Brian Masney
---
This requires this series that I submitted to the LED / backlight
subsystem:
https://lore.kernel.org/lkml/20190424092505.6578-1-masn...@onstation.org/
It's received 3 {Reviewed,Acked}-Bys, and h
Add the MDP5, DSI and DSI PHY blocks for the display found on the
msm8974 SoCs. This is based on work from msm8916.dtsi and Jonathan
Marek.
Signed-off-by: Brian Masney
---
arch/arm/boot/dts/qcom-msm8974.dtsi | 132
1 file changed, 132 insertions(+)
diff --git a
ot of power on
commands listed in the downstream device tree that aren't listed in
mipi_display.h.
Thanks in advance for any advice that you can provide.
Brian Masney (6):
drm/msm: fix null pointer dereference in msm_atomic_prepare_fb()
drm/msm: add dirty framebuffer helper
ARM: qcom_defc
Add the CMA (Contiguous Memory Allocator) for the MSM DRM driver, the
simple panel, and the TI LM3630A driver in order to support the display
on the LG Nexus 5 (hammerhead) phone.
Signed-off-by: Brian Masney
---
The panel and backlight are currently compiled into the kernel, but will
be moved to
Add initial support for the display found on the LG Nexus 5 (hammerhead)
phone.
Signed-off-by: Brian Masney
---
See the cover letter on this patch series for details about the issue
that I'm running into with this board.
.../qcom-msm8974-lge-nexus5-hammerhead.dts| 45 +
On Mon, May 06, 2019 at 08:42:36AM +0200, Linus Walleij wrote:
> On Sun, May 5, 2019 at 3:04 PM Brian Masney wrote:
>
> > mdp5_get_scanoutpos() and mdp5_get_vblank_counter() both return 0, which
> > is causing this stack trace to be dumped into the system log
by the prepare_fb callbacks.
- Add drm_plane_enable_fb_damage_clips() to plane init for mdp4, mdp5,
and dpu1.
- Add Linus Walleij's reviewed-by to patches 3-6
Brian Masney (6):
drm: msm: remove resv fields from msm_gem_object struct
drm: msm: add dirty framebuffer helper
ARM: qcom_defconfig: add display-related
On Mon, May 06, 2019 at 11:39:02PM -0700, Bjorn Andersson wrote:
> On Sun 05 May 06:04 PDT 2019, Brian Masney wrote:
> > diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi
> > b/arch/arm/boot/dts/qcom-msm8974.dtsi
> [..]
> > + cloc
Add necessary device tree nodes for the main LCD backlight.
Signed-off-by: Brian Masney
Reviewed-by: Linus Walleij
---
This requires this series that should be merged soon:
https://lore.kernel.org/lkml/20190424092505.6578-1-masn...@onstation.org/
The device tree bindings have been reviewed. The
Add initial support for the display found on the LG Nexus 5 (hammerhead)
phone.
Signed-off-by: Brian Masney
Reviewed-by: Linus Walleij
---
Changes since v1:
- None
.../qcom-msm8974-lge-nexus5-hammerhead.dts| 45 +++
1 file changed, 45 insertions(+)
diff --git a/arch/arm
On Wed, May 08, 2019 at 08:00:47PM -0700, Bjorn Andersson wrote:
> On Wed 08 May 19:25 PDT 2019, Rob Clark wrote:
>
> > On Wed, May 8, 2019 at 7:16 PM Brian Masney wrote:
> > >
> > > On Mon, May 06, 2019 at 11:39:02PM -0700, Bjorn Andersson wrote:
> > >
On Wed, May 08, 2019 at 10:03:46PM -0400, Brian Masney wrote:
> Here is a patch series that adds initial display support for the LG
> Nexus 5 (hammerhead) phone. It's not fully working so that's why some
> of these patches are RFC until we can get it fully working.
>
&
Add the CMA (Contiguous Memory Allocator) for the MSM DRM driver, the
simple panel, and the TI LM3630A driver in order to support the display
on the LG Nexus 5 (hammerhead) phone.
Signed-off-by: Brian Masney
Reviewed-by: Linus Walleij
---
Changes since v1:
- None
arch/arm/configs
Use drm_atomic_helper_dirtyfb() as the dirty callback in the
msm_framebuffer_funcs struct. Call drm_plane_enable_fb_damage_clips()
when the planes are initialized in mdp4, mdp5, and dpu1.
Signed-off-by: Brian Masney
---
Changes since v1:
- Add drm_plane_enable_fb_damage_clips() to plane init for
Add the MDP5, DSI and DSI PHY blocks for the display found on the
msm8974 SoCs. This is based on work from msm8916.dtsi and Jonathan
Marek.
Signed-off-by: Brian Masney
Reviewed-by: Linus Walleij
---
Changes since v1:
- None
arch/arm/boot/dts/qcom-msm8974.dtsi | 132
pointer. Correct those two cases to
point to the correct reservation object.
Signed-off-by: Brian Masney
Fixes: dd55cf6929e6 ("drm: msm: Switch to use drm_gem_object
reservation_object")
---
Patch introduced in v2
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 4 +---
drivers/g
On Mon, May 13, 2019 at 01:32:39PM -0700, Bjorn Andersson wrote:
> On Wed 08 May 19:03 PDT 2019, Brian Masney wrote:
>
> > The msm_gem_object structure contains resv and _resv fields that are
> > no longer needed since the reservation object is now stored on
msm_gem_describe() would attempt to dereference a NULL pointer via the
address space pointer when no IOMMU is present. Correct this by adding
the appropriate check.
Signed-off-by: Brian Masney
Fixes: 575f0485508b ("drm/msm: Clean up and enhance the output of the 'gem'
pointer. Correct those two cases to
point to the correct reservation object.
Signed-off-by: Brian Masney
Reviewed-by: Bjorn Andersson
Tested-by: Bjorn Andersson
Fixes: dd55cf6929e6 ("drm: msm: Switch to use drm_gem_object
reservation_object")
---
This is a split out version of this
Hi Rob,
On Fri, May 17, 2019 at 04:11:48PM -0500, Rob Herring wrote:
> On Wed, Apr 24, 2019 at 4:25 AM Brian Masney wrote:
> >
> > Add new backlight bindings for the TI LM3630A dual-string white LED.
> >
> > Signed-off-by: Brian Masney
> > Reviewed-by: Rob Herr
lidation error:
Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.example.dt.yaml:
led@0: 'ti,linear-mapping-mode' does not match any of the regexes:
'pinctrl-[0-9]+'
Fixes: 32fcb75c66a0 ("dt-bindings: backlight: Add lm3630a bindings")
Signed-off-by:
On Tue, May 28, 2019 at 03:46:14PM +0200, Linus Walleij wrote:
> On Thu, May 9, 2019 at 4:04 AM Brian Masney wrote:
>
> > Here is a patch series that adds initial display support for the LG
> > Nexus 5 (hammerhead) phone. It's not fully working so that's why some
On Tue, May 28, 2019 at 07:32:14PM -0600, Jeffrey Hugo wrote:
> On Tue, May 28, 2019 at 7:17 PM Brian Masney wrote:
> >
> > On Tue, May 28, 2019 at 03:46:14PM +0200, Linus Walleij wrote:
> > > On Thu, May 9, 2019 at 4:04 AM Brian Masney wrote:
> > >
> &g
On Tue, May 28, 2019 at 07:42:19PM -0600, Jeffrey Hugo wrote:
> > > Do you know if the nexus 5 has a video or command mode panel? There
> > > is some glitchyness with vblanks and command mode panels.
> >
> > Its in command mode. I know this because I see two 'pp done time out'
> > messages, even o
On Wed, May 29, 2019 at 08:23:17AM +0200, Linus Walleij wrote:
> On Wed, May 29, 2019 at 3:17 AM Brian Masney wrote:
>
> > It's in low speed mode but its usable.
>
> How low speed is that?
I don't have a number but my test with 4.17 is to run
'cat /etc/passwd
Hi Dan,
On Tue, Apr 02, 2019 at 08:44:22AM -0500, Dan Murphy wrote:
> Also one other comment I noticed when reviewing the code that there is no
> definition to
> which child led properties are optional and which are required?
With the new YAML bindings, there is a separate toplevel 'required' ta
defaults to
enabling both banks. This patch changes the default value to disable
both banks before parsing the firmware node so that just a single bank
can be enabled if desired. There are no in-tree users of this driver.
Driver was tested on a LG Nexus 5 (hammerhead) phone.
Signed-off-by: Brian Masney
Add new backlight bindings for the TI LM3630A dual-string white LED.
Signed-off-by: Brian Masney
---
Rob: Since the common bindings aren't converted to the new JSON schema
yet, I'm not sure how to do led-sources here. I would expect that we'd
have the uint32-array on the common
patches for the changelog.
Brian Masney (3):
backlight: lm3630a: return 0 on success in update_status functions
dt-bindings: backlight: add lm3630a bindings
backlight: lm3630a: add firmware node support
.../leds/backlight/lm3630a-backlight.yaml | 124
drivers/video/backlight
On Mon, Apr 15, 2019 at 07:10:04AM -0500, Dan Murphy wrote:
> I noticed we are missing "label". It is defined as optional and it is hard
> coded in the driver
> but wondering if there is a need to add it.
OK, I'll make it optional and have it fall back to the hardcoded values
if it is missing.
;s change it to correct that error.
Signed-off-by: Brian Masney
Fixes: 28e64a68a2ef ("backlight: lm3630: apply chip revision")
Acked-by: Pavel Machek
---
Changes since v2:
- None
drivers/video/backlight/lm3630a_bl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
patches for the changelog.
Brian Masney (3):
backlight: lm3630a: return 0 on success in update_status functions
dt-bindings: backlight: add lm3630a bindings
backlight: lm3630a: add firmware node support
.../leds/backlight/lm3630a-backlight.yaml | 128 +++
drivers/video/backlight
Add new backlight bindings for the TI LM3630A dual-string white LED.
Signed-off-by: Brian Masney
---
Rob: Since the common bindings aren't converted to the new JSON schema
yet, I'm not sure how to do led-sources here. I would expect that we'd
have the uint32-array on the common
defaults to
enabling both banks. This patch changes the default value to disable
both banks before parsing the firmware node so that just a single bank
can be enabled if desired. There are no in-tree users of this driver.
Driver was tested on a LG Nexus 5 (hammerhead) phone.
Signed-off-by: Brian
;s change it to correct that error.
Signed-off-by: Brian Masney
Fixes: 28e64a68a2ef ("backlight: lm3630: apply chip revision")
Acked-by: Pavel Machek
---
Changes since v3:
- None
Changes since v2:
- None
drivers/video/backlight/lm3630a_bl.c | 4 ++--
1 file changed, 2 insertions(+), 2
On Wed, Apr 17, 2019 at 08:34:33AM -0500, Rob Herring wrote:
> On Tue, Apr 16, 2019 at 6:54 PM Brian Masney wrote:
> >
> > Add new backlight bindings for the TI LM3630A dual-string white LED.
> >
> > Signed-off-by: Brian Masney
> > ---
> > Rob: Since the
Add new backlight bindings for the TI LM3630A dual-string white LED.
Signed-off-by: Brian Masney
---
Changes since v4:
- Drop $ref from led-sources
- Drop description from reg of i2c address
- Expand description of reg for the control bank
- Drop status from examples
Changes since v3:
- Add
defaults to
enabling both banks. This patch changes the default value to disable
both banks before parsing the firmware node so that just a single bank
can be enabled if desired. There are no in-tree users of this driver.
Driver was tested on a LG Nexus 5 (hammerhead) phone.
Signed-off-by: Brian
;s change it to correct that error.
Signed-off-by: Brian Masney
Fixes: 28e64a68a2ef ("backlight: lm3630: apply chip revision")
Acked-by: Pavel Machek
---
drivers/video/backlight/lm3630a_bl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/backligh
patches for the changelog.
Brian Masney (3):
backlight: lm3630a: return 0 on success in update_status functions
dt-bindings: backlight: add lm3630a bindings
backlight: lm3630a: add firmware node support
.../leds/backlight/lm3630a-backlight.yaml | 129 +++
drivers/video/backlight
On Tue, Apr 23, 2019 at 10:31:41AM -0500, Dan Murphy wrote:
> On 4/23/19 9:01 AM, Brian Masney wrote:
> > On Tue, Apr 23, 2019 at 08:49:20AM -0500, Dan Murphy wrote:
> >>> +static int lm3630a_parse_led_sources(struct fwnode_handle *node,
> >>> +
On Tue, Apr 23, 2019 at 08:49:20AM -0500, Dan Murphy wrote:
> > +static int lm3630a_parse_led_sources(struct fwnode_handle *node,
> > +int default_led_sources)
> > +{
> > + u32 sources[LM3630A_NUM_SINKS];
> > + int ret, num_sources, i;
> > +
> > + num_sources =
Add new backlight bindings for the TI LM3630A dual-string white LED.
Signed-off-by: Brian Masney
Reviewed-by: Rob Herring
---
Changes since v5:
- Change 'lm3630a_bl@38' in examples to 'led-controller@38'
Changes since v4:
- Drop $ref from led-sources
- Drop description fro
;s change it to correct that error.
Signed-off-by: Brian Masney
Fixes: 28e64a68a2ef ("backlight: lm3630: apply chip revision")
Acked-by: Pavel Machek
---
No changes since v2 when this patch was originally introduced.
drivers/video/backlight/lm3630a_bl.c | 4 ++--
1 file changed, 2 i
patches for the changelog.
Brian Masney (3):
backlight: lm3630a: return 0 on success in update_status functions
dt-bindings: backlight: add lm3630a bindings
backlight: lm3630a: add firmware node support
.../leds/backlight/lm3630a-backlight.yaml | 129 +++
drivers/video/backlight
defaults to
enabling both banks. This patch changes the default value to disable
both banks before parsing the firmware node so that just a single bank
can be enabled if desired. There are no in-tree users of this driver.
Driver was tested on a LG Nexus 5 (hammerhead) phone.
Signed-off-by: Brian
On Wed, May 29, 2019 at 08:41:31AM -0600, Jeffrey Hugo wrote:
> On Wed, May 29, 2019 at 4:28 AM Brian Masney wrote:
> >
> > On Tue, May 28, 2019 at 08:53:49PM -0600, Jeffrey Hugo wrote:
> > > On Tue, May 28, 2019 at 8:46 PM Brian Masney
> > > wrote:
> > &g
On Wed, May 29, 2019 at 01:58:16PM -0600, Jeffrey Hugo wrote:
> On 5/29/2019 1:30 PM, Brian Masney wrote:
> > On Wed, May 29, 2019 at 08:41:31AM -0600, Jeffrey Hugo wrote:
> > > On Wed, May 29, 2019 at 4:28 AM Brian Masney
> > > wrote:
> > > >
> >
Add the CMA (Contiguous Memory Allocator) for the MSM DRM/KMS driver,
the simple panel, and the TI LM3630A driver in order to support the
display on the LG Nexus 5 (hammerhead) phone.
Signed-off-by: Brian Masney
Reviewed-by: Linus Walleij
---
arch/arm/configs/qcom_defconfig | 5 +
1 file
Add initial support for the display found on the LG Nexus 5 (hammerhead)
phone. This is based on work from Jonathan Marek.
Signed-off-by: Brian Masney
---
.../qcom-msm8974-lge-nexus5-hammerhead.dts| 58 +++
1 file changed, 58 insertions(+)
diff --git a/arch/arm/boot/dts
Use drm_atomic_helper_dirtyfb() as the dirty callback in the
msm_framebuffer_funcs struct. Call drm_plane_enable_fb_damage_clips()
when the planes are initialized in mdp4, mdp5, and dpu1.
Signed-off-by: Brian Masney
---
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 3 +++
drivers/gpu/drm/msm
ned-off-by: Brian Masney
Suggested-by: Jeffrey Hugo
---
drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 16 +++-
drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 2 +-
2 files changed, 16 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c
b/drivers/gpu/drm/msm
Add the MDP5, DSI and DSI PHY blocks for the display found on the
msm8974 SoCs. This is based on work from msm8916.dtsi and Jonathan
Marek.
Signed-off-by: Brian Masney
Reviewed-by: Linus Walleij
---
arch/arm/boot/dts/qcom-msm8974.dtsi | 132
1 file changed, 132
Add necessary device tree nodes for the main LCD backlight.
Signed-off-by: Brian Masney
Reviewed-by: Linus Walleij
---
.../qcom-msm8974-lge-nexus5-hammerhead.dts| 34 +++
1 file changed, 34 insertions(+)
diff --git a/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts
nd dpu1.
- Add Linus Walleij's reviewed-by to patches 3-6
My status page at https://masneyb.github.io/nexus-5-upstream/
describes what is working so far with the upstream kernel on the Nexus
5.
Brian Masney (6):
drm/msm: add dirty framebuffer helper
drm/msm: add support for per-
put_iova() would attempt to dereference a NULL pointer via the
address space pointer when no IOMMU is present. Correct this by adding
the appropriate check.
Signed-off-by: Brian Masney
---
drivers/gpu/drm/msm/msm_gem.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a
OCMEM support is upstream.
Signed-off-by: Brian Masney
---
drivers/gpu/drm/msm/adreno/a3xx_gpu.c | 33 +++-
drivers/gpu/drm/msm/adreno/a3xx_gpu.h | 3 +-
drivers/gpu/drm/msm/adreno/a4xx_gpu.c | 30 ++
drivers/gpu/drm/msm/adreno/a4xx_gpu.h | 3 +-
drivers
From: Rob Clark
Add support for the OCMEM lock/unlock interface that is needed by the
On Chip MEMory (OCMEM) that is present on some Snapdragon devices.
Signed-off-by: Rob Clark
[masn...@onstation.org: ported to latest kernel; minor reformatting.]
Signed-off-by: Brian Masney
---
Rob's
with an upstream driver, this is just a minimal
implementation sufficient for statically allocating to the GPU it's
chunk of OCMEM.
Signed-off-by: Rob Clark
Co-developed-by: Brian Masney
Signed-off-by: Brian Masney
---
Changes since Rob's last version of this patch:
https://patchwork.
Some A3xx and A4xx Adreno GPUs do not have GMEM inside the GPU core and
must use the On Chip MEMory (OCMEM) in order to be functional. Add the
optional ocmem property to the Adreno Graphics Management Unit bindings.
Signed-off-by: Brian Masney
---
Documentation/devicetree/bindings/display/msm
From: Rob Clark
Add support to restore the secure configuration that is needed by the
On Chip MEMory (OCMEM) that is present on some Snapdragon devices.
Signed-off-by: Rob Clark
[masn...@onstation.org: ported to latest kernel; minor reformatting.]
Signed-off-by: Brian Masney
---
Rob's
Add device tree bindings for the On Chip Memory (OCMEM) that is present
on some Qualcomm Snapdragon SoCs.
Signed-off-by: Brian Masney
---
.../bindings/soc/qcom/qcom,ocmem.yaml | 66 +++
1 file changed, 66 insertions(+)
create mode 100644 Documentation/devicetree
was tested with the GPU on a LG Nexus 5 (hammerhead) phone and
this will work on other msm8974-based systems. For a summary of what
currently works upstream on the Nexus 5, see my status page at
https://masneyb.github.io/nexus-5-upstream/.
Brian Masney (3):
dt-bindings: soc: qcom: add On Chip MEM
Hi Bjorn,
On Sun, Jun 16, 2019 at 11:06:33AM -0700, Bjorn Andersson wrote:
> > diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> > b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> > index 6f7f4114afcf..e0a9409c8a32 100644
> > --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> > +++ b/drivers/gpu/drm
Hi Rob Clark,
On Sun, Jun 16, 2019 at 10:41:06AM -0700, Bjorn Andersson wrote:
> > diff --git a/drivers/soc/qcom/ocmem.xml.h b/drivers/soc/qcom/ocmem.xml.h
>
> I would prefer that these lived at the top of the c file, rather than
> being generated.
I think it would be nice to make this change as
OCMEM support is upstream.
Signed-off-by: Brian Masney
---
Changes since v1:
- remove CONFIG_QCOM_OCMEM #ifdefs
- use unsigned long for memory addresses instead of uint32_t
- add 'depends on QCOM_OCMEM || QCOM_OCMEM=n' to Kconfig
drivers/gpu/drm/msm/Kconfig | 1 +
drivers/g
driver, this is just a minimal
implementation sufficient for statically allocating to the GPU it's
chunk of OCMEM.
Signed-off-by: Brian Masney
Co-developed-by: Rob Clark
Signed-off-by: Rob Clark
---
Pay attention to qcom_scm_restore_sec_cfg() in the probe function,
specifically the 0 as the
-by: Brian Masney
---
Changes since v1:
- Use existing __qcom_scm_restore_sec_cfg() function stub in
qcom_scm-32.c that was unimplemented
- Set the cfg.ctx_bank_num to the spare function parameter. It was
previously set to the device_id.
drivers/firmware/qcom_scm-32.c | 17
Some A3xx and A4xx Adreno GPUs do not have GMEM inside the GPU core and
must use the On Chip MEMory (OCMEM) in order to be functional. Add the
optional ocmem property to the Adreno Graphics Management Unit bindings.
Signed-off-by: Brian Masney
---
Changes since v1:
- None
Documentation
From: Rob Clark
Add support for the OCMEM lock/unlock interface that is needed by the
On Chip MEMory (OCMEM) that is present on some Snapdragon devices.
Signed-off-by: Rob Clark
[masn...@onstation.org: ported to latest kernel; minor reformatting.]
Signed-off-by: Brian Masney
Reviewed-by
individual patches for the changelog.
This was tested with the GPU on a LG Nexus 5 (hammerhead) phone and
this will work on other msm8974-based systems. For a summary of what
currently works upstream on the Nexus 5, see my status page at
https://masneyb.github.io/nexus-5-upstream/.
Brian Masney
Add device tree bindings for the On Chip Memory (OCMEM) that is present
on some Qualcomm Snapdragon SoCs.
Signed-off-by: Brian Masney
---
Changes since v1:
- Rename qcom,ocmem-msm8974 to qcom,msm8974-ocmem
- Renamed reg-names to ctrl and mem
- update hardware description
- moved from soc to sram
On Tue, Jun 18, 2019 at 10:32:08PM -0400, Brian Masney wrote:
> +++ b/include/soc/qcom/ocmem.h
> @@ -0,0 +1,62 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +/*
> + * The On Chip Memory (OCMEM) allocator allows various clients to allocate
> + * memory from OCMEM based on pe
On Wed, Jun 19, 2019 at 01:21:20PM -0700, Rob Clark wrote:
> On Wed, Jun 19, 2019 at 1:17 PM Rob Herring wrote:
> >
> > On Sun, Jun 16, 2019 at 7:29 AM Brian Masney wrote:
> > >
> > > Some A3xx and A4xx Adreno GPUs do not have GMEM inside the GPU core and
> &g
The files a3xx_gpu.c and a4xx_gpu.c have ifdefs for the OCMEM support
that was missing upstream. Add two new functions (adreno_gpu_ocmem_init
and adreno_gpu_ocmem_cleanup) that removes some duplicated code.
Signed-off-by: Brian Masney
---
Changes since v2:
- Check for -ENODEV error of_get_ocmem
individual patches for the changelog.
This was tested with the GPU on a LG Nexus 5 (hammerhead) phone and
this will work on other msm8974-based systems. For a summary of what
currently works upstream on the Nexus 5, see my status page at
https://masneyb.github.io/nexus-5-upstream/.
Brian Masney
From: Rob Clark
Add support for the OCMEM lock/unlock interface that is needed by the
On Chip MEMory (OCMEM) that is present on some Snapdragon devices.
Signed-off-by: Rob Clark
[masn...@onstation.org: ported to latest kernel; minor reformatting.]
Signed-off-by: Brian Masney
Reviewed-by
ed to zero to match what the hardware
expects. The driver can be updated to read the reserved memory regions
from device tree once other users of OCMEM are added upstream.
Signed-off-by: Brian Masney
Co-developed-by: Rob Clark
Signed-off-by: Rob Clark
---
Changes since v2
- Changed static in
Some A3xx and A4xx Adreno GPUs do not have GMEM inside the GPU core and
must use the On Chip MEMory (OCMEM) in order to be functional. Add the
optional ocmem property to the Adreno Graphics Management Unit bindings.
Signed-off-by: Brian Masney
---
Changes since v2:
- Add a3xx example with OCMEM
Add device tree bindings for the On Chip Memory (OCMEM) that is present
on some Qualcomm Snapdragon SoCs.
Signed-off-by: Brian Masney
---
Changes since v2:
- Add *-sram node and gmu-sram to example.
Changes since v1:
- Rename qcom,ocmem-msm8974 to qcom,msm8974-ocmem
- Renamed reg-names to ctrl
-by: Brian Masney
---
Changes since v2:
- None
Changes since v1:
- Use existing __qcom_scm_restore_sec_cfg() function stub in
qcom_scm-32.c that was unimplemented
- Set the cfg.ctx_bank_num to the spare function parameter. It was
previously set to the device_id.
drivers/firmware/qcom_scm-32
Correct attempted NULL pointer dereference in context_init() when
running without an IOMMU.
Signed-off-by: Brian Masney
Fixes: 295b22ae596c ("drm/msm: Pass the MMU domain index in struct
msm_file_private")
---
The no IOMMU case seems like functionality that we may want to keep
bas
dsi_phy_regulator_init() already logs the error, so no need to log
the same error a second time in dsi_phy_driver_probe(). This patch
also changes dsi_phy_regulator_init() to not log the error if the
error code is -EPROBE_DEFER to reduce noise in dmesg.
Signed-off-by: Brian Masney
---
drivers/gpu
Hi Linus,
On Tue, Mar 05, 2019 at 11:42:15PM +0100, Linus Walleij wrote:
> On Sat, Nov 24, 2018 at 9:06 PM Brian Masney wrote:
>
> > Add binding for the LG ACX467AKM-7 4.95" 1080×1920 LCD panel that is
> > found on the LG Nexus 5 (hammerhead) phone. This appears to be a
;s change it to correct that error.
Signed-off-by: Brian Masney
Fixes: 28e64a68a2ef ("backlight: lm3630: apply chip revision")
---
drivers/video/backlight/lm3630a_bl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/backlight/lm3630a_bl.c
(from November):
- Don't use a trivial binding and expose some of the settings available
in the platform data.
Sorry for the long delay sending out v2. I got busy with other projects.
Brian Masney (3):
backlight: lm3630a: return 0 on success in update_status functions
dt-bindings: back
Add new backlight bindings for the TI LM3630A dual-string white LED.
Signed-off-by: Brian Masney
---
.../leds/backlight/lm3630a-backlight.yaml | 112 ++
1 file changed, 112 insertions(+)
create mode 100644
Documentation/devicetree/bindings/leds/backlight/lm3630a
Add device tree support to the lm3630a driver and allow configuring
independently on both banks the mapping mode (linear or exponential),
initial and maximum LED brightness.
Driver was tested on a LG Nexus 5 (hammerhead) phone.
Signed-off-by: Brian Masney
---
drivers/video/backlight
On Mon, Apr 01, 2019 at 11:39:26PM +0200, Pavel Machek wrote:
> On Mon 2019-04-01 06:30:33, Brian Masney wrote:
> > Add new backlight bindings for the TI LM3630A dual-string white LED.
> >
> > Signed-off-by: Brian Masney
> > ---
> > .../leds/backlight
On Mon, Apr 01, 2019 at 11:48:47PM +0200, Pavel Machek wrote:
> So ... we can have multiple LEDs, each can have up to two
> sources.. and the settings are really per source, not per LED.
>
> But you do not test for overlaps. What prevents me from having
>
>foo {
>led_sources = <0>;
>
On Tue, Apr 02, 2019 at 07:56:55AM -0500, Dan Murphy wrote:
> This would connect control bank B to control bank A. Or just use a flag to
> denote to connect them
> and not use led-sources. But led-sources is the property of choice.
>
> led@0 {
> reg = <0>;
> led-sources = < 0 1 >;
>
Hey Rob,
Since commit 2d99ced787e3 ("drm/msm: async commit support"), the frame
buffer console on my Nexus 5 began throwing these errors:
msm fd90.mdss: pp done time out, lm=0
The display still works.
I see that mdp5_flush_commit() was introduced in commit 9f6b65642bd2
("drm/msm: add kms->f
1 - 100 of 237 matches
Mail list logo
