Re: [PATCH v2] drm/i915: Fix page cleanup on DMA remap failure

2025-01-24 Thread Brian Geffon
On Wed, Jan 22, 2025 at 10:07 PM Srinivas, Vidya wrote: > > Hello Brian, Many thanks for the fix. I am adding my tested-by. > Tested-by: Vidya Srinivas Thanks for testing Vidya. Can we get a maintainer to take a look? > > > > -Original Message- > > From:

Re: [PATCH v2] drm/i915: Fix page cleanup on DMA remap failure

2025-01-27 Thread Brian Geffon
On Mon, Jan 27, 2025 at 1:47 PM Ville Syrjälä wrote: > > On Thu, Jan 16, 2025 at 10:53:40AM -0500, Brian Geffon wrote: > > When converting to folios the cleanup path of shmem_get_pages() was > > missed. When a DMA remap fails and the max segment size is greater than > > P

[PATCH v3] drm/i915: Fix page cleanup on DMA remap failure

2025-01-27 Thread Brian Geffon
t shmem_sg_free_table() to use a folio_batch") Signed-off-by: Brian Geffon Suggested-by: Tomasz Figa --- drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c b/drivers/gpu/drm/i915/

[PATCH v2] drm/i915: Fix page cleanup on DMA remap failure

2025-01-16 Thread Brian Geffon
rnel.org/lkml/20250116135636.410164-1-bgef...@google.com/ Fixes: 0b62af28f249 ("i915: convert shmem_sg_free_table() to use a folio_batch") Signed-off-by: Brian Geffon Suggested-by: Tomasz Figa --- drivers/gpu/drm/i915/gem/i915_gem_object.h | 3 +-- drivers/gpu/drm/i915/gem

Re: [PATCH] drm/i915: Fix page cleanup on DMA remap failure

2025-01-16 Thread Brian Geffon
On Thu, Jan 16, 2025 at 9:24 AM Ville Syrjälä wrote: > > On Thu, Jan 16, 2025 at 08:56:36AM -0500, Brian Geffon wrote: > > When converting to folios the cleanup path of shmem_get_pages() was > > missed. When a DMA remap fails and the max segment size is greater than > > P

Re: [PATCH] drm/i915: Fix page cleanup on DMA remap failure

2025-01-16 Thread Brian Geffon
On Thu, Jan 16, 2025 at 9:24 AM Ville Syrjälä wrote: > > On Thu, Jan 16, 2025 at 08:56:36AM -0500, Brian Geffon wrote: > > When converting to folios the cleanup path of shmem_get_pages() was > > missed. When a DMA remap fails and the max segment size is greater than > > P

Re: [PATCH] drm/i915: Fix page cleanup on DMA remap failure

2025-01-16 Thread Brian Geffon
On Thu, Jan 16, 2025 at 9:38 AM Ville Syrjälä wrote: > > On Thu, Jan 16, 2025 at 04:24:26PM +0200, Ville Syrjälä wrote: > > On Thu, Jan 16, 2025 at 08:56:36AM -0500, Brian Geffon wrote: > > > When converting to folios the cleanup path of shmem_get_pages() was > > >

[PATCH] drm/i915: Fix page cleanup on DMA remap failure

2025-01-16 Thread Brian Geffon
isn't handling compound pages correctly. Link: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13487 Fixes: 0b62af28f249 ("i915: convert shmem_sg_free_table() to use a folio_batch") Signed-off-by: Brian Geffon Suggested-by: Tomasz Figa --- drivers/gpu/drm/i915/gem/i