added documentation to drm_dev_unregister clarifying that devres managed
devices allocated with devm_drm_dev_alloc do not require calls to
drm_dev_put.
Signed-off-by: Brandon Pollack
---
This is my first patch to any tree. I've tried my best to read as many
kernel docs etc as possible
added a newline for block comment
checkpatch.pl output:
---
drivers/gpu/drm/vkms/vkms_drv.c
---
WARNING: Block comments use a trailing */ on a separate line
+* which ix XRGB in all cases. */
total: 0 errors, 1 warnings, 274 line
Any progress on this? Is it ok if yi...@chromium.org and I do the
followups on this patch so that we can also submit the Hotplug patch I
wrote (that's now archived?).
WIP: Need to run all tast criticals and test the multidisplay tests that
are WIP.
BUG=b:283357160
TEST=Booted on a betty-arc-r device and ran autologin.py -a
Change-Id: I13cef8cf019744813f51cfffed3d7ccb987834e8
Change-Id: Iae7d788bc4725dfdca044204fa1af27a5a1ec5a8
---
drivers/gpu/drm/vkms/Makefil
Thanks for taking the time, everyone! Sorry it took so long, we had some
internal shuffling etc going on and I was building out what we needed these
chagnes for in the first place, this will be the first of a few replies
followed by a new version of the series to be sent out.
First up is a respons
From: Maira Canal
Hi Jim,
On 6/23/23 19:23, Jim Shargo wrote:
> This change adds the basic scaffolding for ConfigFS, including setting
> up the default directories. It does not allow for the registration of
> configfs-backed devices, which is complex and provided in a follow-up
> commit.
>
>
Since Jim is busy with other work and I'm working on some things that
rely on this, I've taken up the task of doing the iterations. I've
addressed the comments as best I can (those replies are to each
individual change) and here is the patch set to go with those.
I added my own signoff to each co
Signed-off-by: Brandon Pollack
---
drivers/gpu/drm/vkms/vkms_drv.c| 128 +++--
drivers/gpu/drm/vkms/vkms_drv.h| 4 +-
drivers/gpu/drm/vkms/vkms_output.c | 6 +-
3 files changed, 71 insertions(+), 67 deletions(-)
diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b
re's still only ever one CRTC, this should be a no-op refactor.
Signed-off-by: Jim Shargo
Signed-off-by: Brandon Pollack
---
drivers/gpu/drm/vkms/vkms_composer.c | 30 +++
drivers/gpu/drm/vkms/vkms_crtc.c | 101 -
drivers/gpu/drm/vkms/vkms_drv.c | 12
From: Jim Shargo
This is a small refactor to make ConfigFS support easier. This should be
a no-op refactor.
Signed-off-by: Jim Shargo
Signed-off-by: Brandon Pollack
---
drivers/gpu/drm/vkms/vkms_drv.c| 14 --
drivers/gpu/drm/vkms/vkms_drv.h| 9 ++---
drivers/gpu/drm
reate a new device according to your configuration.
For now, this will fail, but the next change will add support for it.
Signed-off-by: Jim Shargo
Signed-off-by: Brandon Pollack
---
Documentation/gpu/vkms.rst | 18 +-
drivers/gpu/drm/Kconfig | 1 +
drivers/gpu
From: Jim Shargo
VKMS now supports creating and using virtual devices!
In addition to the enabling logic, this commit also prevents users from
adding new objects once a card is registered.
Signed-off-by: Jim Shargo
Signed-off-by: Brandon Pollack
---
drivers/gpu/drm/vkms/vkms_configfs.c
true to maintain backwards
compatibility.
Signed-off-by: Jim Shargo
Signed-off-by: Brandon Pollack
---
drivers/gpu/drm/vkms/vkms_drv.c | 45 ++---
1 file changed, 30 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms
alized multidisplay tests that involve
hotplugging displays (eg recompositing windows when a monitor is turned
off).
Signed-off-by: Brandon Pollack
---
Documentation/gpu/vkms.rst | 2 +-
drivers/gpu/drm/vkms/vkms_configfs.c | 68 ++--
drivers/gpu/drm/vkms/vkms_drv.
a lock for the configfs setup handler
> - Moved all the new docs into the relevant .c file
> - Addressed as many of s...@poorly.run as possible
>
>Testing
>===
>
> - New IGT tests (see
>gitlab.freedesktop.org/jshargo/igt-gpu-tools/-/merge_requests/1)
> - Existing
Signed-off-by: Brandon Pollack
---
drivers/gpu/drm/vkms/vkms_drv.c| 128 +++--
drivers/gpu/drm/vkms/vkms_drv.h| 4 +-
drivers/gpu/drm/vkms/vkms_output.c | 6 +-
3 files changed, 71 insertions(+), 67 deletions(-)
diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b
re's still only ever one CRTC, this should be a no-op refactor.
Signed-off-by: Jim Shargo
Signed-off-by: Brandon Pollack
---
drivers/gpu/drm/vkms/vkms_composer.c | 30 +++
drivers/gpu/drm/vkms/vkms_crtc.c | 101 -
drivers/gpu/drm/vkms/vkms_drv.c | 12
alized multidisplay tests that involve
hotplugging displays (eg recompositing windows when a monitor is turned
off).
Signed-off-by: Brandon Pollack
---
Documentation/gpu/vkms.rst | 2 +-
drivers/gpu/drm/vkms/vkms_configfs.c | 68 ++--
drivers/gpu/drm/vkms/vkms_drv.
From: Jim Shargo
This is a small refactor to make ConfigFS support easier. This should be
a no-op refactor.
Signed-off-by: Jim Shargo
Signed-off-by: Brandon Pollack
---
drivers/gpu/drm/vkms/vkms_drv.c| 14 --
drivers/gpu/drm/vkms/vkms_drv.h| 9 ++---
drivers/gpu/drm
From: Jim Shargo
VKMS now supports creating and using virtual devices!
In addition to the enabling logic, this commit also prevents users from
adding new objects once a card is registered.
Signed-off-by: Jim Shargo
Signed-off-by: Brandon Pollack
---
drivers/gpu/drm/vkms/vkms_configfs.c
reate a new device according to your configuration.
For now, this will fail, but the next change will add support for it.
Signed-off-by: Jim Shargo
Signed-off-by: Brandon Pollack
---
Documentation/gpu/vkms.rst | 18 +-
drivers/gpu/drm/Kconfig | 1 +
drivers/gpu
true to maintain backwards
compatibility.
Signed-off-by: Jim Shargo
Signed-off-by: Brandon Pollack
---
drivers/gpu/drm/vkms/vkms_drv.c | 45 ++---
1 file changed, 30 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms
umentation, taking over it is also mine.
Thank you everyone :)
Brandon Pollack (1):
drm/vkms Add hotplug support via configfs to VKMS.
Jim Shargo (6):
drm/vkms: Back VKMS with DRM memory management instead of static
objects
drm/vkms: Support multiple DRM objects (crtcs, etc.) per VKMS
Signed-off-by: Brandon Pollack
---
drivers/gpu/drm/vkms/vkms_drv.c| 128 +++--
drivers/gpu/drm/vkms/vkms_drv.h| 4 +-
drivers/gpu/drm/vkms/vkms_output.c | 6 +-
3 files changed, 71 insertions(+), 67 deletions(-)
diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b
re's still only ever one CRTC, this should be a no-op refactor.
Signed-off-by: Jim Shargo
Signed-off-by: Brandon Pollack
---
drivers/gpu/drm/vkms/vkms_composer.c | 30 +++
drivers/gpu/drm/vkms/vkms_crtc.c | 100 -
drivers/gpu/drm/vkms/vkms_drv.c | 12
From: Jim Shargo
This is a small refactor to make ConfigFS support easier. This should be
a no-op refactor.
Signed-off-by: Jim Shargo
Signed-off-by: Brandon Pollack
---
drivers/gpu/drm/vkms/vkms_drv.c| 14 --
drivers/gpu/drm/vkms/vkms_drv.h| 9 ++---
drivers/gpu/drm
reate a new device according to your configuration.
For now, this will fail, but the next change will add support for it.
Signed-off-by: Jim Shargo
Signed-off-by: Brandon Pollack
---
Documentation/gpu/vkms.rst | 18 +-
drivers/gpu/drm/Kconfig | 1 +
drivers/gpu
true to maintain backwards
compatibility.
Signed-off-by: Jim Shargo
Signed-off-by: Brandon Pollack
---
drivers/gpu/drm/vkms/vkms_drv.c | 45 ++---
1 file changed, 30 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms
From: Jim Shargo
VKMS now supports creating and using virtual devices!
In addition to the enabling logic, this commit also prevents users from
adding new objects once a card is registered.
Signed-off-by: Jim Shargo
Signed-off-by: Brandon Pollack
---
drivers/gpu/drm/vkms/vkms_configfs.c
alized multidisplay tests that involve
hotplugging displays (eg recompositing windows when a monitor is turned
off).
Signed-off-by: Brandon Pollack
---
Documentation/gpu/vkms.rst | 2 +-
drivers/gpu/drm/vkms/vkms_configfs.c | 68 ++--
drivers/gpu/drm/vkms/vkms_drv.
ges so I added an in-reply-to to that series. Not sure if that is
alright.
Signed-off-by: Brandon Pollack
---
Documentation/gpu/vkms.rst| 2 +-
drivers/gpu/drm/vkms/vkms_configfs.c | 96 ++-
drivers/gpu/drm/vkms/vkms_drv.h | 11 +++
drivers/gpu/drm/vkm
alized multidisplay tests that involve
hotplugging displays (eg recompositing windows when a monitor is turned
off).
Signed-off-by: Brandon Pollack
---
This is a first attempt and I am sure I could use some feedback. I have
this working locally and I'm continuing to develop the test frame
's input and tolerance in getting these
changes in. Jim's first patch series was this, and other than some
small cleanups and documentation, taking over it is also mine.
Thank you everyone :)
Brandon Pollack (1):
drm/vkms Add hotplug support via configfs to VKMS.
Jim Shargo (6):
Signed-off-by: Brandon Pollack
---
drivers/gpu/drm/vkms/vkms_drv.c| 128 +++--
drivers/gpu/drm/vkms/vkms_drv.h| 4 +-
drivers/gpu/drm/vkms/vkms_output.c | 6 +-
3 files changed, 71 insertions(+), 67 deletions(-)
diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b
re's still only ever one CRTC, this should be a no-op refactor.
Signed-off-by: Jim Shargo
Signed-off-by: Brandon Pollack
---
drivers/gpu/drm/vkms/vkms_composer.c | 30 +++
drivers/gpu/drm/vkms/vkms_crtc.c | 100 -
drivers/gpu/drm/vkms/vkms_drv.c | 12
From: Jim Shargo
This is a small refactor to make ConfigFS support easier. This should be
a no-op refactor.
Signed-off-by: Jim Shargo
Signed-off-by: Brandon Pollack
---
drivers/gpu/drm/vkms/vkms_drv.c| 14 --
drivers/gpu/drm/vkms/vkms_drv.h| 9 ++---
drivers/gpu/drm
reate a new device according to your configuration.
For now, this will fail, but the next change will add support for it.
Signed-off-by: Jim Shargo
Signed-off-by: Brandon Pollack
---
Documentation/gpu/vkms.rst | 18 +-
drivers/gpu/drm/Kconfig | 1 +
drivers/gpu
true to maintain backwards
compatibility.
Signed-off-by: Jim Shargo
Signed-off-by: Brandon Pollack
---
drivers/gpu/drm/vkms/vkms_drv.c | 45 ++---
1 file changed, 30 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms
alized multidisplay tests that involve
hotplugging displays (eg recompositing windows when a monitor is turned
off).
Signed-off-by: Brandon Pollack
---
Documentation/gpu/vkms.rst | 2 +-
drivers/gpu/drm/vkms/vkms_configfs.c | 68 ++--
drivers/gpu/drm/vkms/vkms_drv.
From: Jim Shargo
VKMS now supports creating and using virtual devices!
In addition to the enabling logic, this commit also prevents users from
adding new objects once a card is registered.
Signed-off-by: Jim Shargo
Signed-off-by: Brandon Pollack
---
drivers/gpu/drm/vkms/vkms_configfs.c
's input and tolerance in getting these
changes in. Jim's first patch series was this, and other than some
small cleanups and documentation, taking over it is also mine.
Thank you everyone :)
Brandon Pollack (1):
drm/vkms Add hotplug support via configfs to VKMS.
Jim Shargo (6):
Signed-off-by: Brandon Pollack
---
drivers/gpu/drm/vkms/vkms_drv.c| 128 +++--
drivers/gpu/drm/vkms/vkms_drv.h| 4 +-
drivers/gpu/drm/vkms/vkms_output.c | 6 +-
3 files changed, 71 insertions(+), 67 deletions(-)
diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b
re's still only ever one CRTC, this should be a no-op refactor.
Signed-off-by: Jim Shargo
Signed-off-by: Brandon Pollack
---
drivers/gpu/drm/vkms/vkms_composer.c | 30 +++
drivers/gpu/drm/vkms/vkms_crtc.c | 100 -
drivers/gpu/drm/vkms/vkms_drv.c | 12
From: Jim Shargo
This is a small refactor to make ConfigFS support easier. This should be
a no-op refactor.
Signed-off-by: Jim Shargo
Signed-off-by: Brandon Pollack
---
drivers/gpu/drm/vkms/vkms_drv.c| 14 --
drivers/gpu/drm/vkms/vkms_drv.h| 9 ++---
drivers/gpu/drm
true to maintain backwards
compatibility.
Signed-off-by: Jim Shargo
Signed-off-by: Brandon Pollack
---
drivers/gpu/drm/vkms/vkms_drv.c | 45 ++---
1 file changed, 30 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms
From: Jim Shargo
VKMS now supports creating and using virtual devices!
In addition to the enabling logic, this commit also prevents users from
adding new objects once a card is registered.
Signed-off-by: Jim Shargo
Signed-off-by: Brandon Pollack
---
drivers/gpu/drm/vkms/vkms_configfs.c
reate a new device according to your configuration.
For now, this will fail, but the next change will add support for it.
Signed-off-by: Jim Shargo
Signed-off-by: Brandon Pollack
---
Documentation/gpu/vkms.rst | 18 +-
drivers/gpu/drm/Kconfig | 1 +
drivers/gpu
alized multidisplay tests that involve
hotplugging displays (eg recompositing windows when a monitor is turned
off).
Signed-off-by: Brandon Pollack
---
Documentation/gpu/vkms.rst | 2 +-
drivers/gpu/drm/vkms/vkms_configfs.c | 68 ++--
drivers/gpu/drm/vkms/vkms_drv.
/c/chromiumos/platform/tast-tests/+/469
Outro:
=
I really appreciate everyone's input and tolerance in getting these
changes in. Jim's first patch series was this, and other than some
small cleanups and documentation, taking over it is also mine.
Thank you everyone :)
Brandon Poll
Signed-off-by: Brandon Pollack
---
drivers/gpu/drm/vkms/vkms_drv.c| 128 +++--
drivers/gpu/drm/vkms/vkms_drv.h| 4 +-
drivers/gpu/drm/vkms/vkms_output.c | 6 +-
3 files changed, 71 insertions(+), 67 deletions(-)
diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b
re's still only ever one CRTC, this should be a no-op refactor.
Signed-off-by: Jim Shargo
Signed-off-by: Brandon Pollack
---
drivers/gpu/drm/vkms/vkms_composer.c | 30 +++
drivers/gpu/drm/vkms/vkms_crtc.c | 100 -
drivers/gpu/drm/vkms/vkms_drv.c | 12
reate a new device according to your configuration.
For now, this will fail, but the next change will add support for it.
Signed-off-by: Jim Shargo
Signed-off-by: Brandon Pollack
---
Documentation/gpu/vkms.rst | 18 +-
drivers/gpu/drm/Kconfig | 1 +
drivers/gpu
From: Jim Shargo
VKMS now supports creating and using virtual devices!
In addition to the enabling logic, this commit also prevents users from
adding new objects once a card is registered.
Signed-off-by: Jim Shargo
Signed-off-by: Brandon Pollack
---
drivers/gpu/drm/vkms/vkms_configfs.c
From: Jim Shargo
This is a small refactor to make ConfigFS support easier. This should be
a no-op refactor.
Signed-off-by: Jim Shargo
Signed-off-by: Brandon Pollack
---
drivers/gpu/drm/vkms/vkms_drv.c| 14 --
drivers/gpu/drm/vkms/vkms_drv.h| 9 ++---
drivers/gpu/drm
alized multidisplay tests that involve
hotplugging displays (eg recompositing windows when a monitor is turned
off).
Signed-off-by: Brandon Pollack
---
Documentation/gpu/vkms.rst | 2 +-
drivers/gpu/drm/vkms/vkms_configfs.c | 68 ++--
drivers/gpu/drm/vkms/vkms_drv.
true to maintain backwards
compatibility.
Signed-off-by: Jim Shargo
Signed-off-by: Brandon Pollack
---
drivers/gpu/drm/vkms/vkms_drv.c | 45 ++---
1 file changed, 30 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms
56 matches
Mail list logo
