Re: clang and drm issue: objtool warnings from clang build

2025-04-28 Thread Bill Wendling
On Sat, Apr 26, 2025 at 1:57 PM Linus Torvalds wrote: > > On Sat, 26 Apr 2025 at 13:05, Nathan Chancellor wrote: > > > > KBUILD_CFLAGS += -mllvm -trap-unreachable > > Hmm. That certainly builds for me, but yeah, it generates new objtool > warnings, notably > >panic() missing __noreturn in

Re: clang and drm issue: objtool warnings from clang build

2025-04-28 Thread Bill Wendling
On Mon, Apr 28, 2025 at 12:34 PM Linus Torvalds wrote: > > On Mon, 28 Apr 2025 at 11:08, Bill Wendling wrote: > > > > This situation is one of the > > easier ones: "do something other than fall into the next function"; > > Note that the "fall i

Re: clang and drm issue: objtool warnings from clang build

2025-04-28 Thread Bill Wendling
On Sat, Apr 26, 2025 at 5:31 PM Linus Torvalds wrote: > So please. Clang people need to get a clue. Yes, we care *deeply* > about performance in the kernel, but a C compiler that thinks that > using UD to generate "better" code is a disgrace and pure garbage. > Because security matters a whole lot

Re: [PATCH 5/5] drm/print: require struct drm_device for drm_err() and friends

2025-05-16 Thread Bill Wendling
On Fri, May 16, 2025 at 2:48 AM Jani Nikula wrote: > On Thu, 15 May 2025, Bill Wendling wrote: > > On 1/23/25 7:09 AM, Jani Nikula wrote: > >> The expectation is that the struct drm_device based logging helpers get > >> passed an actual struct drm_device poin

Re: [PATCH 5/5] drm/print: require struct drm_device for drm_err() and friends

2025-05-16 Thread Bill Wendling
On 1/23/25 7:09 AM, Jani Nikula wrote: The expectation is that the struct drm_device based logging helpers get passed an actual struct drm_device pointer rather than some random struct pointer where you can dereference the ->dev member. Add a static inline helper to convert struct drm_device to

Re: [PATCH 5/5] drm/print: require struct drm_device for drm_err() and friends

2025-05-15 Thread Bill Wendling
On Thu, May 15, 2025 at 1:18 PM Bill Wendling wrote: > On 1/23/25 7:09 AM, Jani Nikula wrote: > > The expectation is that the struct drm_device based logging helpers get > > passed an actual struct drm_device pointer rather than some random > > struct pointer where you can