[PATCH 0/2] Add support of HDMI for rk3568

2021-07-06 Thread Benjamin Gaignard
Add a compatible and platform datas to support HDMI for rk3568 SoC. Benjamin Gaignard (2): dt-bindings: display: rockchip: Add compatible for rk3568 HDMI drm/rockchip: dw_hdmi: add rk3568 support .../display/rockchip/rockchip,dw-hdmi.yaml| 1 + drivers/gpu/drm/rockchip/dw_hdmi

[PATCH 1/2] dt-bindings: display: rockchip: Add compatible for rk3568 HDMI

2021-07-06 Thread Benjamin Gaignard
Define a new compatible for rk3568 HDMI. Signed-off-by: Benjamin Gaignard --- .../devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml b/Documentation

[PATCH 2/2] drm/rockchip: dw_hdmi: add rk3568 support

2021-07-06 Thread Benjamin Gaignard
Add a new dw_hdmi_plat_data struct and new compatible for rk3568. Signed-off-by: Benjamin Gaignard --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 28 + 1 file changed, 28 insertions(+) diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip

[PATCH v2 0/2] Add support of HDMI for rk3568

2021-07-08 Thread Benjamin Gaignard
Add a compatible and platform datas to support HDMI for rk3568 SoC. version 2: - Add the clocks needed for the phy. Benjamin Gaignard (2): dt-bindings: display: rockchip: Add compatible for rk3568 HDMI drm/rockchip: dw_hdmi: add rk3568 support .../display/rockchip/rockchip,dw-hdmi.yaml

[PATCH v2 2/2] drm/rockchip: dw_hdmi: add rk3568 support

2021-07-08 Thread Benjamin Gaignard
Add a new dw_hdmi_plat_data struct and new compatible for rk3568. This version of the HDMI hardware block need two clocks to provide phy reference clock: hclk_vio and hclk. Signed-off-by: Benjamin Gaignard --- version 2: - Add the clocks needed for the phy. drivers/gpu/drm/rockchip/dw_hdmi

[PATCH v2 1/2] dt-bindings: display: rockchip: Add compatible for rk3568 HDMI

2021-07-08 Thread Benjamin Gaignard
Define a new compatible for rk3568 HDMI. This version of HDMI hardware block needs two new clocks hclk_vio and hclk to provide phy reference clocks. Signed-off-by: Benjamin Gaignard --- version 2: - Add the clocks needed for the phy. .../bindings/display/rockchip/rockchip,dw-hdmi.yaml

[PATCH] drm/panel: boe-tv101wum-nl6: Fix errors cases handling in prepare function

2022-02-23 Thread Benjamin Gaignard
Make sure that pp3300 regulator and enable gpio are cleaned before leave in error cases. Fixes: 18c58153b8c62 ("drm/panel: boe-tv101wum-nl6: Support enabling a 3.3V rail") Signed-off-by: Benjamin Gaignard --- drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 7 +-- 1 file

Re: [PATCH v2, 0/4] Cooperate with DSI RX devices to modify dsi funcs and delay mipi high to cooperate with panel sequence

2022-03-04 Thread Benjamin Gaignard
Le 04/03/2022 à 11:15, xinlei@mediatek.com a écrit : From: Xinlei Lee In upstream-v5.8, dsi_enable will operate panel_enable, but this modification has been moved in v5.9. In order to ensure the timing of dsi_power_on/off and the timing of pulling up/down the MIPI signal, the modification

Re: [PATCH v2, 0/4] Cooperate with DSI RX devices to modify dsi funcs and delay mipi high to cooperate with panel sequence

2022-03-08 Thread Benjamin Gaignard
Le 08/03/2022 à 10:12, Hsin-Yi Wang a écrit : On Fri, Mar 4, 2022 at 7:25 PM Benjamin Gaignard wrote: Le 04/03/2022 à 11:15, xinlei@mediatek.com a écrit : From: Xinlei Lee In upstream-v5.8, dsi_enable will operate panel_enable, but this modification has been moved in v5.9. In order

Re: [PATCH v6, 12/15] media: mtk-vcodec: Support 34bits dma address for vdec

2021-10-07 Thread Benjamin Gaignard
Le 01/09/2021 à 10:32, Yunfei Dong a écrit : Use the dma_set_mask_and_coherent helper to set vdec DMA bit mask to support 34bits iova space(16GB) that the mt8192 iommu HW support. Whole the iova range separate to 0~4G/4G~8G/8G~12G/12G~16G, regarding which iova range VDEC actually locate, it de

Re: [PATCH v11, 01/19] media: mtk-vcodec: Get numbers of register bases from DT

2021-11-30 Thread Benjamin Gaignard
Le 29/11/2021 à 04:41, Yunfei Dong a écrit : Different platform may has different numbers of register bases. Gets the numbers of register bases from DT (sizeof(u32) * 4 bytes for each). Reviewed-by: Tzung-Bi Shih Signed-off-by: Yunfei Dong --- .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c |

Re: [PATCH v11, 04/19] media: mtk-vcodec: export decoder pm functions

2021-11-30 Thread Benjamin Gaignard
as a module we need to export mtk-vcodec-dec pm functions to make them visible by the other components" With that: Reviewed-by: Benjamin Gaignard Signed-off-by: Yunfei Dong --- drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

[PATCH] drm/agpsupport: Fix warning in functions documentation

2021-01-06 Thread Benjamin Gaignard
Fix the warnings reported in functions documentation when compiling with W=1 Signed-off-by: Benjamin Gaignard --- drivers/gpu/drm/drm_agpsupport.c | 111 --- 1 file changed, 59 insertions(+), 52 deletions(-) diff --git a/drivers/gpu/drm/drm_agpsupport.c b/drivers

[RFC 0/2] New feature: Framebuffer processors

2016-08-22 Thread Benjamin Gaignard
12 + >>> drivers/gpu/drm/drm_fbproc.c| 754 >>> >>> drivers/gpu/drm/drm_ioctl.c | 3 + >>> drivers/gpu/drm/exynos/Kconfig | 1 - >>> drivers/gpu/drm/exynos/exynos_drm_drv.c | 3 +- >>> drivers/gpu/drm/exynos/exynos_drm_rotator.c | 353 +++-- >>> drivers/gpu/drm/exynos/exynos_drm_rotator.h | 19 - >>> include/drm/drmP.h | 10 + >>> include/drm/drm_crtc.h | 211 >>> include/drm/drm_irq.h | 14 + >>> include/uapi/drm/drm.h | 13 + >>> include/uapi/drm/drm_mode.h | 39 ++ >>> 15 files changed, 1263 insertions(+), 183 deletions(-) >>> create mode 100644 drivers/gpu/drm/drm_fbproc.c >>> delete mode 100644 drivers/gpu/drm/exynos/exynos_drm_rotator.h >>> >> >> ___ >> dri-devel mailing list >> dri-devel at lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel > ___ > dri-devel mailing list > dri-devel at lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Benjamin Gaignard Graphic Study Group Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 1/2] drm/stm: ltdc: manage the get_irq probe defer case

2019-05-06 Thread Benjamin Gaignard
Le ven. 26 avr. 2019 à 14:30, Philippe CORNU a écrit : > > Hi Fabien, > and thank you for your patch, > > Acked-by: Philippe Cornu > > Philippe :-) > > On 4/24/19 4:03 PM, Fabien Dessenne wrote: > > Manage the -EPROBE_DEFER error case for the ltdc IRQ. > > > > Signed-off-by: Fabien Dessenne App

Re: [PATCH 2/2] drm/stm: ltdc: return appropriate error code during probe

2019-05-06 Thread Benjamin Gaignard
Le ven. 26 avr. 2019 à 14:30, Philippe CORNU a écrit : > > Hi Fabien, > and thank you for your patch, > > Acked-by: Philippe Cornu > > Philippe :-) > > On 4/24/19 4:03 PM, Fabien Dessenne wrote: > > During probe, return the "clk_get" error value instead of -ENODEV. > > > > Signed-off-by: Fabien D

Re: [RFC][PATCH 0/5 v4] DMA-BUF Heaps (destaging ION)

2019-05-14 Thread Benjamin Gaignard
buffer driver can implement > their own dma-buf exporter. > * Making sure the performance issues from potentially > unnecessary cache-management operations can be resolved > properly for system and cma heaps(outstanding issue from ION). > > > That said, the main user-inte

Re: [RFC][PATCH 4/5 v4] dma-buf: heaps: Add CMA heap to dmabuf heaps

2019-05-14 Thread Benjamin Gaignard
id ION implementation, so > > thanks to its original author and maintainters: > >Benjamin Gaignard, Laura Abbott, and others! > > > > Cc: Laura Abbott > > Cc: Benjamin Gaignard > > Cc: Sumit Semwal > > Cc: Liam Mark > > Cc: Pratik Patel >

Re: [PATCH v4 1/2] dt-bindings: display: stm32: add supply property to DSI controller

2019-05-17 Thread Benjamin Gaignard
Le mar. 14 mai 2019 à 11:36, Yannick Fertré a écrit : > > This patch adds documentation of a new property phy-dsi-supply to the > STM32 DSI controller. > > Signed-off-by: Yannick Fertré > Reviewed-by: Rob Herring > Reviewed-by: Philippe Cornu Applied on drm-misc-next, Thanks, Benjamin > ---

Re: [PATCH v4 2/2] drm/stm: dsi: add regulator support

2019-05-17 Thread Benjamin Gaignard
Le mar. 14 mai 2019 à 11:36, Yannick Fertré a écrit : > > Add support of regulator for the phy part of the DSI > controller. > > Signed-off-by: Yannick Fertré > Acked-by: Philippe Cornu Applied on drm-misc-next, Thanks, Benjamin > --- > drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 60 > ++

Re: [PATCH] drm/stm: dsi: check hardware version

2019-05-24 Thread Benjamin Gaignard
Le ven. 10 mai 2019 à 18:31, Philippe CORNU a écrit : > > > Dear Yannick, > Thank you for your patch, > > Acked-by: Philippe Cornu > > Dear Benjamin, > If you are fine with this patch, please push it *after* the patch named > "drm/stm: dsi: add support of an optional regulator" (if I well > under

Re: [PATCH v2] drm/stm: ltdc: remove clk_round_rate comment

2019-05-24 Thread Benjamin Gaignard
Le lun. 13 mai 2019 à 16:46, Philippe CORNU a écrit : > > Dear Yannick, > > Acked-by: Philippe Cornu > Applied on drm-misc-next, Benjamin > Thank you, > > Philippe :-) > > On 5/13/19 3:15 PM, Yannick Fertré wrote: > > Clk_round_rate returns rounded clock without changing > > the hardware in any

[PATCH] drm/stm: ltdc: restore calls to clk_{enable/disable}

2019-05-27 Thread Benjamin Gaignard
From: Benjamin Gaignard Restore calls to clk_{enable/disable} deleted after applying the wrong version of the patch Fixes: fd6905fca4f0 ("drm/stm: ltdc: remove clk_round_rate comment") Signed-off-by: Benjamin Gaignard --- drivers/gpu/drm/stm/ltdc.c | 2 ++ 1 file changed, 2

Re: [PATCH] drm/stm: ltdc: restore calls to clk_{enable/disable}

2019-05-28 Thread Benjamin Gaignard
> On 5/27/19 1:58 PM, Benjamin Gaignard wrote: > > From: Benjamin Gaignard > > > > Restore calls to clk_{enable/disable} deleted after applying the wrong > > version of the patch > > > > Fixes: fd6905fca4f0 ("drm/stm: ltdc: remove clk_round_rate comment

Re: [RFC][PATCH] libdrm: tests: Add planetest test from AOSP sources

2019-04-17 Thread Benjamin Gaignard
Le mar. 16 avr. 2019 à 20:48, John Stultz a écrit : > > On Tue, Apr 16, 2019 at 11:29 AM Sean Paul wrote: > > On Tue, Apr 16, 2019 at 09:43:49AM -0700, John Stultz wrote: > > > In trying to further align the AOSP libdrm branch with upstream, > > > I wanted to submit the added test planetest that

Re: [PATCH] drm/stm: ltdc: update planes at next vblank to avoid partial refresh

2019-04-24 Thread Benjamin Gaignard
Le lun. 1 avr. 2019 à 11:22, Philippe CORNU a écrit : > > Dear Yannick, > Thank you for your patch, works fine, > > Acked-by: Philippe Cornu > Applied on drm-misc-next, Thanks, Benjamin > Philippe :-) > > On 4/1/19 9:24 AM, Yannick Fertré wrote: > > Plane updates must be synchronized on vblank w

Re: [PATCH] drm/stm: ltdc: fix data enable polarity

2019-04-24 Thread Benjamin Gaignard
Le lun. 1 avr. 2019 à 11:18, Philippe CORNU a écrit : > > > > On 3/29/19 10:32 PM, Mukesh Ojha wrote: > > > > On 3/29/2019 9:20 PM, Yannick Fertré wrote: > >> Wrong DISPLAY_FLAGS used to set the data enable polarity. > > Used or checked? > > Can you also explain how it is wrong to check against th

Re: [PATCH] drm/stm: ltdc: use DRM_WARN for fifo & transfer error messages

2019-04-24 Thread Benjamin Gaignard
Le lun. 1 avr. 2019 à 11:20, Philippe CORNU a écrit : > > Dear Yannick, > Fully agree with this approach, > > Acked-by: Philippe Cornu > Applied on drm-misc-next, Thanks, Benjamin > Philippe :-) > > On 3/29/19 4:49 PM, Yannick Fertré wrote: > > From: Philippe Cornu > > > > Use DRM_WARN() inste

Re: [PATCH] drm/stm: ltdc: disable hw interrupts before its handler init

2019-04-24 Thread Benjamin Gaignard
Le lun. 1 avr. 2019 à 11:19, Philippe CORNU a écrit : > > > On 3/29/19 4:48 PM, Yannick Fertré wrote: > > Interrupt register must be disabled before call of > > devm_request_threaded_irq function to avoid dummy interruption. > > > > Signed-off-by: Yannick Fertré > > --- > > drivers/gpu/drm/stm/

Re: [PATCH] drm/stm: ltdc: limit number of layer to avoid memory overflow

2019-04-24 Thread Benjamin Gaignard
Le ven. 5 avr. 2019 à 18:30, Philippe CORNU a écrit : > > Dear Yannick, > Thank you for your patch, > > Acked-by: Philippe Cornu > Applied on drm-misc-next, Thanks, Benjamin > Philippe :) > > On 4/3/19 11:20 AM, Yannick Fertré wrote: > > If the number of layer is greater than LTDC_MAX_LAYER, we

Re: [PATCH] drm/stm: ltdc: reset controller to avoid partial refresh

2019-04-24 Thread Benjamin Gaignard
Le ven. 5 avr. 2019 à 18:31, Philippe CORNU a écrit : > > > > On 4/3/19 11:24 AM, Yannick Fertré wrote: > > Display controller reset must be done as soon as possible after enable > > the clock to avoid partial refresh on screen. > > > > Signed-off-by: Yannick Fertré > > --- > > drivers/gpu/drm/

Re: [PATCH] drm/stm: ltdc: add modifier support

2019-04-24 Thread Benjamin Gaignard
Le ven. 5 avr. 2019 à 18:32, Philippe CORNU a écrit : > > > > On 4/3/19 11:25 AM, Yannick Fertré wrote: > > Signed-off-by: Mickael Reulier > > Signed-off-by: Yannick Fertré > > --- > > drivers/gpu/drm/stm/ltdc.c | 21 - > > 1 file changed, 20 insertions(+), 1 deletion(-) >

Re: [PATCH -next] drm/stm: ltdc: remove set but not used variable 'src_h'

2019-01-21 Thread Benjamin Gaignard
Le lun. 21 janv. 2019 à 09:21, YueHaibing a écrit : > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/gpu/drm/stm/ltdc.c: In function 'ltdc_plane_atomic_check': > drivers/gpu/drm/stm/ltdc.c:694:13: warning: > variable 'src_y' set but not used [-Wunused-but-set-variable] > u32 src_x

Re: [PATCH v2 4/7] drm: sti: Cleanup drm_display_mode print str

2018-12-20 Thread Benjamin Gaignard
Le jeu. 20 déc. 2018 à 13:27, Shayenne Moura a écrit : > > This patch adjust the print string of drm_display_mode object > to remove drm_mode_object dependency in sti files. > > Signed-off-by: Shayenne Moura Acked-by: Benjamin Gaignard > > --- > Changes in v2: &g

Re: [PATCH v2 12/14] drm/stm: do not reply on drmP.h from drm_gem_cma_helper.h

2019-01-08 Thread Benjamin Gaignard
y modify it. > > > > Signed-off-by: Sam Ravnborg > > Cc: Yannick Fertre > > Cc: Philippe Cornu > > Cc: Benjamin Gaignard > > Cc: Vincent Abriou > > Cc: David Airlie > > Cc: Daniel Vetter > > --- > > Acked-by: Noralf Trønnes Acked-

Re: [PATCH v3 10/12] drm/stm: do not reply on drmP.h from drm_gem_cma_helper.h

2019-01-09 Thread Benjamin Gaignard
d-off-by: Sam Ravnborg > Acked-by: Noralf Trønnes > Acked-by: Benjamin Gaignard > Cc: Yannick Fertre > Cc: Philippe Cornu > Cc: Vincent Abriou > Cc: David Airlie > Cc: Daniel Vetter > --- > drivers/gpu/drm/stm/drv.c | 6 +- > drivers/gpu/drm/stm/ltdc.c | 9

Re: [PATCH v4 3/8] drm/stm: prepare for drmP.h removal from drm_modeset_helper.h

2019-01-14 Thread Benjamin Gaignard
gt; > Build tested on arm and x86 allmodconfig > Acked-by: Benjamin Gaignard > Signed-off-by: Sam Ravnborg > Cc: Yannick Fertre > Cc: Philippe Cornu > Cc: Benjamin Gaignard > Cc: Vincent Abriou > Cc: David Airlie > Cc: Daniel Vetter > --- > drivers/gpu/drm

Re: [EARLY RFC][PATCH] dma-buf: Add dma-buf heaps framework

2019-02-26 Thread Benjamin Gaignard
Le lun. 25 févr. 2019 à 15:36, Andrew F. Davis a écrit : > > This framework allows a unified userspace interface for dma-buf > exporters, allowing userland to allocate specific types of memory > for use in dma-buf sharing. > > Each heap is given its own device node, which a user can allocate > a d

Re: [RFC][PATCH 3/5 v2] dma-buf: heaps: Add system heap to dmabuf heaps

2019-03-06 Thread Benjamin Gaignard
n, so > thanks to its original authors and maintainters: > Rebecca Schultz Zavin, Colin Cross, Laura Abbott, and others! > > Cc: Laura Abbott > Cc: Benjamin Gaignard > Cc: Greg KH > Cc: Sumit Semwal > Cc: Liam Mark > Cc: Brian Starkey > Cc: Andrew F. Davis &g

Re: [RFC][PATCH 4/5 v2] dma-buf: heaps: Add CMA heap to dmabuf heapss

2019-03-06 Thread Benjamin Gaignard
ters: > Benjamin Gaignard, Laura Abbott, and others! > > Cc: Laura Abbott > Cc: Benjamin Gaignard > Cc: Greg KH > Cc: Sumit Semwal > Cc: Liam Mark > Cc: Brian Starkey > Cc: Andrew F. Davis > Cc: Chenbo Feng > Cc: Alistair Strachan > Cc: dri-de

Re: [RFC][PATCH 1/5 v2] dma-buf: Add dma-buf heaps framework

2019-03-06 Thread Benjamin Gaignard
given its own device node, which a user can > allocate a dma-buf fd from using the DMA_HEAP_IOC_ALLOC. > > This code is an evoluiton of the Android ION implementation, > and a big thanks is due to its authors/maintainers over time > for their effort: > Rebecca Schultz Zavin, C

Re: [RFC][PATCH 5/5 v2] kselftests: Add dma-heap test

2019-03-06 Thread Benjamin Gaignard
Le mar. 5 mars 2019 à 21:54, John Stultz a écrit : > > Add very trivial allocation test for dma-heaps. > > TODO: Need to actually do some validation on > the returned dma-buf. > > Cc: Laura Abbott > Cc: Benjamin Gaignard > Cc: Greg KH > Cc: Sumit Semwal > C

Re: [PATCH] drm/stm: fix CONFIG_FB dependency

2019-03-11 Thread Benjamin Gaignard
Le lun. 11 mars 2019 à 15:24, Arnd Bergmann a écrit : > > On Fri, Mar 8, 2019 at 4:50 PM Yannick FERTRE wrote: > > > > Reviewed-by: Yannick Fertré > > Thanks, > > > Arnd, > > could you merge the patch? > > I think that Benjamin could also merge it. > > I think this should go through the drm tree

Re: [PATCH] drm/crc-debugfs: User irqsafe spinlock in drm_crtc_add_crc_entry

2019-06-06 Thread Benjamin Gaignard
t; normal worker. Which really upsets lockdep. > > > > Cc: Rodrigo Siqueira > > Cc: Tomeu Vizoso > > Cc: Emil Velikov > > Cc: Benjamin Gaignard > > Signed-off-by: Daniel Vetter > > Reviewed-by: Ville Syrjälä Reviewed-by: Benjamin Gaignard > >

Re: [PATCH v1 1/1] drm/sti: drop use of drmP.h

2019-06-06 Thread Benjamin Gaignard
ures. Applied on drm-misc-next, Thanks, Benjamin > > Signed-off-by: Sam Ravnborg > Cc: Benjamin Gaignard > Cc: Vincent Abriou > Cc: David Airlie > Cc: Daniel Vetter > --- > drivers/gpu/drm/sti/sti_awg_utils.c| 2 ++ > drivers/gpu/drm/sti/sti_a

Re: [Intel-gfx] [PATCH] drm/crc-debugfs: Also sprinkle irqrestore over early exits

2019-06-07 Thread Benjamin Gaignard
"drm/crc-debugfs: User irqsafe spinlock in > > drm_crtc_add_crc_entry") > > Cc: Rodrigo Siqueira > > Cc: Tomeu Vizoso > > Cc: Emil Velikov > > Cc: Benjamin Gaignard > > Cc: Ville Syrjälä > > Signed-off-by: Daniel Vetter > > Reviewed-by: Emil Velikov

Re: [PATCH] drm/stm: support runtime power management

2019-06-07 Thread Benjamin Gaignard
Le ven. 7 juin 2019 à 13:19, Philippe CORNU a écrit : > > Hi Yannick, > > Thank you for your patch > > Acked-by: Philippe Cornu Applied on drm-misc-next Thanks, Benjamin > > Philippe :-) > > On 6/3/19 10:32 AM, Yannick Fertré wrote: > > This patch enables runtime power management (runtime PM) s

Re: [PATCH] drm/stm: ltdc: No message if probe

2019-06-07 Thread Benjamin Gaignard
Le ven. 7 juin 2019 à 10:51, Philippe CORNU a écrit : > > Hi Yannick, > > Thank you for your patch > > Acked-by: Philippe Cornu Applied on drm-misc-next Thanks, Benjamin > Philippe :-) > > On 6/3/19 10:31 AM, Yannick Fertré wrote: > > Print display controller hardware version in debug mode onl

Re: [PATCH] sti: no need to check return value of debugfs_create functions

2019-06-13 Thread Benjamin Gaignard
Le jeu. 13 juin 2019 à 13:46, Greg Kroah-Hartman a écrit : > > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Benjamin Gaignard &g

Re: [PATCH 1/3] drm/stm: drv: fix suspend/resume

2019-06-20 Thread Benjamin Gaignard
Le mar. 18 juin 2019 à 11:57, Philippe CORNU a écrit : > > Hi Yannick, > > Thank you for your patch. > > Acked-by: Philippe Cornu I have corrected Fixes sha1 (should be 12 digits) Applied on drm-misc-next. Benjamin > > Philippe :-) > > On 6/17/19 9:18 AM, Yannick Fertré wrote: > > Without this

Re: [PATCH 29/59] drm/sti: Drop drm_gem_prime_export/import

2019-06-20 Thread Benjamin Gaignard
Le ven. 14 juin 2019 à 22:36, Daniel Vetter a écrit : > > They're the default. > > Aside: Would be really nice to switch the others over to > drm_gem_object_funcs. > > Signed-off-by: Daniel Vetter > Cc: Benjamin Gaignard > Cc: Vincent Abriou Thanks

Re: [PATCH -next] drm/sti: Remove duplicated include from sti_drv.c

2019-06-21 Thread Benjamin Gaignard
Le jeu. 20 juin 2019 à 16:56, YueHaibing a écrit : > > Remove duplicated include. > > Signed-off-by: YueHaibing Applied on drm-misc-next, Thanks for the patch. Benjamin > --- > drivers/gpu/drm/sti/sti_drv.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/sti/sti_drv.c

Re: [PATCH v1 03/33] drm/stm: drop use of drmP.h

2019-07-01 Thread Benjamin Gaignard
Yannick Fertre > Cc: Philippe Cornu > Cc: Benjamin Gaignard > Cc: Vincent Abriou > Cc: David Airlie > Cc: Daniel Vetter > Cc: Maxime Coquelin > Cc: Alexandre Torgue > Cc: linux-st...@st-md-mailman.stormreply.com > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-st.

Re: [PATCH v2 04/14] drm/sti: Try to fix up the tvout possible clones

2019-07-09 Thread Benjamin Gaignard
t hda+hdmi cloning, but then > dvo also claims to be cloneable with hdmi, but hdmi won't recipricate. > > Benjamin tells me all encoders should be cloneable with each other, > so let's fix up the masks to indicate that. > Applied on drm-misc-next, Thanks, Benjamin >

Re: [PATCH v2 03/14] drm/sti: Remove pointless casts

2019-07-09 Thread Benjamin Gaignard
Le lun. 8 juil. 2019 à 18:21, Ville Syrjala a écrit : > > From: Ville Syrjälä > > There's no point in the cast for accessing the base class. Just > take the address of the struct instead. Applied on drm-misc-next, Thanks, Benjamin > > Cc: Benjamin Gaignard > C

Re: [RFC][PATCH 0/5 v2] DMA-BUF Heaps (destaging ION)

2019-03-19 Thread Benjamin Gaignard
Le mer. 13 mars 2019 à 23:31, John Stultz a écrit : > > On Wed, Mar 13, 2019 at 1:11 PM Liam Mark wrote: > > On Tue, 5 Mar 2019, John Stultz wrote: > > > > > > Eventual TODOS: > > > * Reimplement page-pool for system heap (working on this) > > > * Add stats accounting to system/cma heaps > > > *

Re: [RFC][PATCH 0/5 v2] DMA-BUF Heaps (destaging ION)

2019-03-20 Thread Benjamin Gaignard
Le mar. 19 mars 2019 à 23:36, John Stultz a écrit : > > On Tue, Mar 19, 2019 at 2:58 PM Rob Clark wrote: > > > > On Tue, Mar 19, 2019 at 1:00 PM Andrew F. Davis wrote: > > > > > > On 3/19/19 11:54 AM, Benjamin Gaignard wrote: > > > > Le mer. 13

Re: [RFC][PATCH 0/5 v2] DMA-BUF Heaps (destaging ION)

2019-03-20 Thread Benjamin Gaignard
Le mer. 20 mars 2019 à 15:54, Andrew F. Davis a écrit : > > On 3/20/19 4:16 AM, Benjamin Gaignard wrote: > > Le mar. 19 mars 2019 à 23:36, John Stultz a écrit : > >> > >> On Tue, Mar 19, 2019 at 2:58 PM Rob Clark wrote: > >>> > >>>

Re: [RFC][PATCH 4/6 v3] dma-buf: heaps: Add CMA heap to dmabuf heapss

2019-03-29 Thread Benjamin Gaignard
ters: > Benjamin Gaignard, Laura Abbott, and others! > > Cc: Laura Abbott > Cc: Benjamin Gaignard > Cc: Sumit Semwal > Cc: Liam Mark > Cc: Pratik Patel > Cc: Brian Starkey > Cc: Vincent Donnefort > Cc: Sudipto Paul > Cc: Andrew F. Davis > Cc: Xu YiPing

Re: [RFC][PATCH 4/6 v3] dma-buf: heaps: Add CMA heap to dmabuf heapss

2019-03-29 Thread Benjamin Gaignard
Le ven. 29 mars 2019 à 16:19, Andrew F. Davis a écrit : > > On 3/29/19 9:44 AM, Benjamin Gaignard wrote: > > Le ven. 29 mars 2019 à 01:16, John Stultz a écrit : > >> > >> This adds a CMA heap, which allows userspace to allocate > >> a dma-buf o

Re: [RFC][PATCH 4/6 v3] dma-buf: heaps: Add CMA heap to dmabuf heapss

2019-04-01 Thread Benjamin Gaignard
Le ven. 29 mars 2019 à 16:42, Andrew F. Davis a écrit : > > On 3/29/19 10:30 AM, Benjamin Gaignard wrote: > > Le ven. 29 mars 2019 à 16:19, Andrew F. Davis a écrit : > >> > >> On 3/29/19 9:44 AM, Benjamin Gaignard wrote: > >>> Le ven. 29 mars

Re: [PATCH] drm/stm: dw_mipi_dsi-stm: add sleep power management

2019-04-01 Thread Benjamin Gaignard
Le mar. 26 mars 2019 à 13:57, Philippe CORNU a écrit : > > Dear Yannick, > Many thanks for your patch. > > Acked-by: Philippe Cornu Applied on drm-misc-next. Benjamin > > Philippe :-) > > > On 3/21/19 9:13 AM, Yannick Fertré wrote: > > Implements system sleep power management ops. > > > > Sign

Re: [PATCH] drm/stm: add sleep power management

2019-04-01 Thread Benjamin Gaignard
Le mar. 26 mars 2019 à 14:02, Philippe CORNU a écrit : > > (+ Benjamin) > > Dear Yannick, > Many thanks for your patch. > Acked-by: Philippe Cornu > > Dear Benjamin, > May I ask you please to merge this patch + "drm/stm: dw_mipi_dsi-stm: > add sleep power management" on drm-misc, if you agree of

Re: [PATCH v4 15/23] drm: sti: Provide ddc symlink in hdmi connector sysfs directory

2019-07-12 Thread Benjamin Gaignard
Le jeu. 11 juil. 2019 à 13:30, Andrzej Pietrasiewicz a écrit : > > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz Reviewed-by: Benjamin Gaignard > --- > drivers/gpu/drm/sti/sti_hdmi.c | 1 + > 1 file changed, 1 insertio

Re: [PATCH v6 4/5] dma-buf: heaps: Add CMA heap to dmabuf heaps

2019-07-24 Thread Benjamin Gaignard
Le mer. 24 juil. 2019 à 09:00, Christoph Hellwig a écrit : > > On Mon, Jul 22, 2019 at 10:04:06PM -0700, John Stultz wrote: > > Apologies, I'm not sure I'm understanding your suggestion here. > > dma_alloc_contiguous() does have some interesting optimizations > > (avoiding allocating single page f

Re: [PATCH v2 1/3] drm/bridge: sii902x: fix missing reference to mclk clock

2019-07-25 Thread Benjamin Gaignard
Le lun. 22 juil. 2019 à 18:06, Olivier Moysan a écrit : > > Add devm_clk_get call to retrieve reference to master clock. > > Fixes: ff5781634c41 ("drm/bridge: sii902x: Implement HDMI audio support") > > Signed-off-by: Olivier Moysan > Reviewed-by: Jyri Sarha > Acked-by: Andrzej Hajda --- > dri

Re: [PATCH v2 2/3] dt-bindings: display: sii902x: Change audio mclk binding

2019-07-25 Thread Benjamin Gaignard
Le lun. 22 juil. 2019 à 18:06, Olivier Moysan a écrit : > > As stated in SiL9022/24 datasheet, master clock is not required for I2S. > Make mclk property optional in DT bindings. > > Fixes: 3f18021f43a3 ("dt-bindings: display: sii902x: Add HDMI audio bindings") > Applied on drm-misc-next. Thanks,

Re: [PATCH v2 3/3] drm/bridge: sii902x: make audio mclk optional

2019-07-25 Thread Benjamin Gaignard
Le lun. 22 juil. 2019 à 18:06, Olivier Moysan a écrit : > > The master clock on i2s bus is not mandatory, > as sii902X internal PLL can be used instead. > Make use of mclk optional. Applied on drm-misc-next. Thanks, Benjamin > > Signed-off-by: Olivier Moysan > Reviewed-by: Jyri Sarha > Acked-b

Re: [PATCH] drm/stm: attach gem fence to atomic state

2019-07-25 Thread Benjamin Gaignard
Le ven. 19 juil. 2019 à 15:35, Philippe CORNU a écrit : > > Hi Lucas & Ahmad, > > Many thanks for your patch, > > Tested successfully on stm32mp157-dk2 (weston & drm). > > Acked-by: Philippe Cornu > Tested-by: Philippe Cornu Applied on drm-misc-next. Thanks, Benjamin > > Philippe :-) > > On 7/

Re: [PATCH] drm/bridge: sii902x: add audio graph card support

2019-07-25 Thread Benjamin Gaignard
Le jeu. 11 juil. 2019 à 13:09, Jyri Sarha a écrit : > > On 03/07/2019 11:04, Olivier Moysan wrote: > > Implement get_dai_id callback of audio HDMI codec > > to support ASoC audio graph card. > > HDMI audio output has to be connected to sii902x port 3. > > get_dai_id callback maps this port to ASoC

Re: [PATCH v6 4/5] dma-buf: heaps: Add CMA heap to dmabuf heaps

2019-07-25 Thread Benjamin Gaignard
Le jeu. 25 juil. 2019 à 14:52, Christoph Hellwig a écrit : > > On Wed, Jul 24, 2019 at 11:46:24AM -0700, John Stultz wrote: > > I'm still not understanding how this would work. Benjamin and Laura > > already commented on this point, but for a simple example, with the > > HiKey boards, the DRM driv

Re: [PATCH v6 4/5] dma-buf: heaps: Add CMA heap to dmabuf heaps

2019-07-25 Thread Benjamin Gaignard
Le jeu. 25 juil. 2019 à 16:33, Christoph Hellwig a écrit : > > On Thu, Jul 25, 2019 at 03:20:11PM +0200, Benjamin Gaignard wrote: > > > But that just means we need a flag that memory needs to be contiguous, > > > which totally makes sense at the API level. But CMA is not

Re: [PATCH] drm: sti: Mark expected switch fall-throughs

2019-07-30 Thread Benjamin Gaignard
Le mar. 30 juil. 2019 à 00:27, Gustavo A. R. Silva a écrit : > > Mark switch cases where we are expecting to fall through. > > This patch fixes the following warning (Building: arm): > > drivers/gpu/drm/sti/sti_hdmi.c: In function ‘hdmi_audio_configure’: > drivers/gpu/drm/sti/sti_hdmi.c:851:13: wa

Re: [PATCH v6 16/24] drm: sti: Provide ddc symlink in hdmi connector sysfs directory

2019-07-30 Thread Benjamin Gaignard
Le ven. 26 juil. 2019 à 19:27, Andrzej Pietrasiewicz a écrit : > > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz Reviewed-by: Benjamin Gaignard > --- > drivers/gpu/drm/sti/sti_hdmi.c | 6 -- > 1 file changed, 4 inser

Re: [PATCH v2] drm: atomic helper: fix W=1 warnings

2019-11-07 Thread Benjamin Gaignard
Le mar. 22 oct. 2019 à 10:37, Daniel Vetter a écrit : > > On Tue, Oct 08, 2019 at 02:42:54PM +0200, Benjamin Gaignard wrote: > > Few for_each macro set variables that are never used later which led > > to generate unused-but-set-variable warnings. > > Add (void)(foo) ins

[PATCH] drm/dp_mst: Fix W=1 warnings

2019-11-12 Thread Benjamin Gaignard
Fix the warnings that show up with W=1. They are all about unused but set variables. Signed-off-by: Benjamin Gaignard --- drivers/gpu/drm/drm_dp_mst_topology.c | 50 +-- 1 file changed, 19 insertions(+), 31 deletions(-) diff --git a/drivers/gpu/drm

[PATCH] drm/modes: tag unused variables to avoid warnings

2019-12-11 Thread Benjamin Gaignard
Some variables are set but never used. To avoid warning when compiling with W=1 and keep the algorithm like it is tag theses variables with _maybe_unused macro. Signed-off-by: Benjamin Gaignard --- changes in this version: - do not modify the code to remove the unused variables just prefix

Re: [PATCH v3] drm/dp_mst: Fix W=1 warnings

2019-12-16 Thread Benjamin Gaignard
Le mer. 4 déc. 2019 à 17:47, Jani Nikula a écrit : > > On Thu, 28 Nov 2019, Benjamin Gaignard wrote: > > Fix the warnings that show up with W=1. > > They are all about unused but set variables. > > If functions returns are not used anymore make them void. > > > &

Re: [PATCH] drm/stm: ltdc: move pinctrl to encoder mode set

2019-12-20 Thread Benjamin Gaignard
Le lun. 2 déc. 2019 à 18:19, Philippe CORNU a écrit : > > Dear Yannick, > Thank you for your patch, > > Acked-by: Philippe Cornu > Applied on drm-misc-next, Thanks, Benjamin > Philippe :-) > > On 11/27/19 11:23 AM, Yannick Fertre wrote: > > From: Yannick Fertré > > > > The pin control must be

Re: [PATCH v3] drm/dp_mst: Fix W=1 warnings

2019-12-20 Thread Benjamin Gaignard
Le lun. 16 déc. 2019 à 09:28, Benjamin Gaignard a écrit : > > Le mer. 4 déc. 2019 à 17:47, Jani Nikula a > écrit : > > > > On Thu, 28 Nov 2019, Benjamin Gaignard wrote: > > > Fix the warnings that show up with W=1. > > > They are all about unused but se

Re: [PATCH v3] drm/dp_mst: Fix W=1 warnings

2020-01-07 Thread Benjamin Gaignard
Le ven. 20 déc. 2019 à 15:03, Benjamin Gaignard a écrit : > > Le lun. 16 déc. 2019 à 09:28, Benjamin Gaignard > a écrit : > > > > Le mer. 4 déc. 2019 à 17:47, Jani Nikula a > > écrit : > > > > > > On Thu, 28 Nov 2019, Benjamin Gaignard wrote: &

Re: [PATCH] drm/modes: tag unused variables to avoid warnings

2020-01-07 Thread Benjamin Gaignard
Le mer. 11 déc. 2019 à 10:20, Benjamin Gaignard a écrit : > > Some variables are set but never used. To avoid warning when compiling > with W=1 and keep the algorithm like it is tag theses variables > with _maybe_unused macro. Gentle ping. Thanks, Benjamin > > Signed-off-by:

Re: [PATCH v2 1/2] dt-bindings: one binding file for all simple panels

2020-01-07 Thread Benjamin Gaignard
Le jeu. 2 janv. 2020 à 11:17, Sam Ravnborg a écrit : > > There is an increasing number of new simple panels. > Common for many of these simple panels are that they have one > mandatory power-supply and some of them have backlight and / or > an enable gpio. > > The binding file to describe these pa

Re: [PATCH v2 2/2] dt-bindings: one file of all simple DSI panels

2020-01-07 Thread Benjamin Gaignard
Le jeu. 2 janv. 2020 à 11:17, Sam Ravnborg a écrit : > > To complement panel-simple.yaml, create panel-simple-dsi.yaml. > panel-simple-dsi-yaml are for all simple DSP panels with a single > power-supply and optional backlight / enable GPIO. > > Migrate panasonic,vvx10f034n00 over to the new file.

Re: [PATCH v2 2/2] dt-bindings: one file of all simple DSI panels

2020-01-08 Thread Benjamin Gaignard
Le mar. 7 janv. 2020 à 18:05, Rob Herring a écrit : > > On Tue, Jan 7, 2020 at 9:44 AM Benjamin Gaignard > wrote: > > > > Le jeu. 2 janv. 2020 à 11:17, Sam Ravnborg a écrit : > > > > > > To complement panel-simple.yaml, create panel-simple-dsi.yaml.

Re: [PATCH] drm/fb-cma-helpers: Fix include issue

2020-01-09 Thread Benjamin Gaignard
Le jeu. 9 janv. 2020 à 17:29, Benjamin GAIGNARD a écrit : > > > On 12/3/19 5:49 PM, Benjamin Gaignard wrote: > > Le mer. 20 nov. 2019 à 00:28, Benjamin Gaignard > > a écrit : > >> Exported functions prototypes are missing in drm_fb_cma_helper.c > >> Incl

Re: [PATCH] drm/modes: tag unused variables to avoid warnings

2020-01-09 Thread Benjamin GAIGNARD
On 1/7/20 2:24 PM, Thomas Zimmermann wrote: > Hi > > Am 10.12.19 um 11:24 schrieb Benjamin Gaignard: >> Some variables are set but never used. To avoid warning when compiling >> with W=1 and keep the algorithm like it is tag theses variables >> with _maybe_unused

[PATCH] dt-bindings: display: Convert stm32 display bindings to json-schema

2019-10-04 Thread Benjamin Gaignard
Convert the STM32 display binding to DT schema format using json-schema. Split the original bindings in two yaml files: - one for display controller (ltdc) - one for DSI controller Signed-off-by: Benjamin Gaignard --- .../devicetree/bindings/display/st,stm32-dsi.yaml | 130

Re: [PATCH] drm: atomic helper: fix W=1 warnings

2019-10-04 Thread Benjamin Gaignard
Le jeu. 3 oct. 2019 à 17:46, Ville Syrjälä a écrit : > > On Thu, Oct 03, 2019 at 05:37:15PM +0200, Benjamin Gaignard wrote: > > Le jeu. 3 oct. 2019 à 17:05, Ville Syrjälä > > a écrit : > > > > > > On Thu, Oct 03, 2019 at 04:46:54PM +0200, Benjamin Gaignard wro

Re: [PATCH] drm: atomic helper: fix W=1 warnings

2019-10-04 Thread Benjamin GAIGNARD
On 10/4/19 2:27 PM, Ville Syrjälä wrote: > On Fri, Oct 04, 2019 at 12:48:02PM +0200, Benjamin Gaignard wrote: >> Le jeu. 3 oct. 2019 à 17:46, Ville Syrjälä >> a écrit : >>> On Thu, Oct 03, 2019 at 05:37:15PM +0200, Benjamin Gaignard wrote: >>>> Le jeu. 3 oct.

[PATCH v2] drm: atomic helper: fix W=1 warnings

2019-10-08 Thread Benjamin Gaignard
Few for_each macro set variables that are never used later which led to generate unused-but-set-variable warnings. Add (void)(foo) inside the macros to remove these warnings Signed-off-by: Benjamin Gaignard --- include/drm/drm_atomic.h | 17 ++--- 1 file changed, 14 insertions(+), 3

[PATCH v2] dt-bindings: display: Convert stm32 display bindings to json-schema

2019-10-11 Thread Benjamin Gaignard
Convert the STM32 display binding to DT schema format using json-schema. Split the original bindings in two yaml files: - one for display controller (ltdc) - one for DSI controller Signed-off-by: Benjamin Gaignard --- changes in v2: - use BSD-2-Clause license - add panel property - fix

[PATCH v3] dt-bindings: display: Convert stm32 display bindings to json-schema

2019-10-14 Thread Benjamin Gaignard
Convert the STM32 display binding to DT schema format using json-schema. Split the original bindings in two yaml files: - one for display controller (ltdc) - one for DSI controller Signed-off-by: Benjamin Gaignard --- changes in v3: - use (GPL-2.0-only OR BSD-2-Clause) license changes in v2

[PATCH v4] dt-bindings: display: Convert stm32 display bindings to json-schema

2019-10-15 Thread Benjamin Gaignard
Convert the STM32 display binding to DT schema format using json-schema. Split the original bindings in two yaml files: - one for display controller (ltdc) - one for DSI controller Signed-off-by: Benjamin Gaignard --- changes in v4: - describe interruptions items - remove unit address from port

Re: [PATCH v12 4/5] dma-buf: heaps: Add CMA heap to dmabuf heaps

2019-10-18 Thread Benjamin Gaignard
n evolution of the Android ION implementation, so > > thanks to its original author and maintainters: > > Benjamin Gaignard, Laura Abbott, and others! > > > > NOTE: This patch only adds the default CMA heap. We will enable > > selectively adding other CMA memory regions

Re: [PATCH v2] drm: atomic helper: fix W=1 warnings

2019-10-21 Thread Benjamin Gaignard
Le mer. 9 oct. 2019 à 09:13, Benjamin Gaignard a écrit : > > Few for_each macro set variables that are never used later which led > to generate unused-but-set-variable warnings. > Add (void)(foo) inside the macros to remove these warnings > Gentle ping, Thanks, Benjamin

[PATCH v4 0/3] dt-bindings: add simple DSI panels

2020-02-07 Thread Benjamin Gaignard
with small variations. Create dedicated yaml files for them. Benjamin Gaignard (2): dt-bindings: panel: Convert raydium,rm68200 to json-schema dt-bindings: panel: Convert orisetech,otm8009a to json-schema Sam Ravnborg (1): dt-bindings: one file of all simple DSI panels .../bindings/display

[PATCH v4 2/3] dt-bindings: panel: Convert raydium, rm68200 to json-schema

2020-02-07 Thread Benjamin Gaignard
Convert raydium,rm68200 to json-schema. Signed-off-by: Benjamin Gaignard --- .../bindings/display/panel/raydium,rm68200.txt | 25 -- .../bindings/display/panel/raydium,rm68200.yaml| 56 ++ 2 files changed, 56 insertions(+), 25 deletions(-) delete mode 100644

[PATCH v4 1/3] dt-bindings: one file of all simple DSI panels

2020-02-07 Thread Benjamin Gaignard
simple DSI panels are: - Make it simpler to add bindings for simple DSI panels - Keep the number of bindings file lower - Keep the binding documentation for simple DSI panels more consistent Signed-off-by: Sam Ravnborg Signed-off-by: Benjamin Gaignard Cc: Thierry Reding Cc: Rob

[PATCH v4 3/3] dt-bindings: panel: Convert orisetech, otm8009a to json-schema

2020-02-07 Thread Benjamin Gaignard
Convert orisetech,otm8009a to json-schema. Signed-off-by: Benjamin Gaignard --- .../bindings/display/panel/orisetech,otm8009a.txt | 23 -- .../bindings/display/panel/orisetech,otm8009a.yaml | 53 ++ 2 files changed, 53 insertions(+), 23 deletions(-) delete mode

  1   2   3   4   5   6   7   8   >