If a plane supports a pixel format and the framebuffer does not pass any
modifiers, then drm_plane_check_pixel_format() should always return true
for the given format regardless of whether the plane supports any
modifiers or not.
Signed-off-by: Ayan Kumar Halder
---
drivers/gpu/drm/drm_plane.c
/uncompressed buffers for
VIDEO layers and compressed buffers only for GRAPHICS layer. SMART layer
behaves similar to that of Malidp-550.
Signed-off-by: Ayan Kumar halder
Reviewed-by: Brian Starkey
---
drivers/gpu/drm/arm/malidp_crtc.c | 31 ++--
drivers/gpu/drm/arm
commit messages
---
Ayan Kumar Halder (5):
drm/arm/malidp: Modified the prototype of malidp irq de-initializers
drm/arm/malidp: Split malidp interrupt initialization functions.
drm/arm/malidp: Enable/disable interrupts in runtime pm
drm/arm/malidp: Set the output_depth register in modeset
t drm_device' needs to be removed so as to
enable it to call from functions which receives 'struct malidp_hw_device'
as argument. Furthermore, there is no way to retrieve 'struct drm_device'
from 'struct malidp_hw_device'.
Signed-off-by: Ayan Kumar Halder
---
C
Display and scaling engine interrupts need to be disabled when the
runtime pm invokes malidp_runtime_pm_suspend(). Conversely, they
need to be enabled in malidp_runtime_pm_resume().
This patch depends on:
https://lkml.org/lkml/2017/5/15/695
Signed-off-by: Ayan Kumar Halder
Signed-off-by
()/malidp_se_irq_hw_init())
which will be later invoked from runtime_pm_resume function when it needs
to re-enable the interrupts.
Signed-off-by: Ayan Kumar Halder
---
Changes in v3:-
- Squashed https://patchwork.kernel.org/patch/10357203/ and
https://patchwork.kernel.org/patch/10357209/ into a single
One needs to store the value of the OUTPUT_DEPTH that one has parsed from
device tree, so that it can be restored on system resume. This value is
set in the modeset function as this gets reset when the system suspends.
Signed-off-by: Ayan Kumar Halder
---
Changes in v3:-
- Rebased the patch on
runtime suspend mode before system suspend was called, pm_runtime_work()
will put the device back in runtime suspended mode( after the complete system
has been resumed).
Signed-off-by: Ayan Kumar Halder
---
Changes in v3:-
- Rebased on top of earlier v3 patches,
Changes in v2:-
- Removed the
commit messages
---
Ayan Kumar Halder (5):
drm/arm/malidp: Modified the prototype of malidp irq de-initializers
drm/arm/malidp: Split malidp interrupt initialization functions.
drm/arm/malidp: Enable/disable interrupts in runtime pm
drm/arm/malidp: Set the output_depth register in modeset
t drm_device' needs to be removed so as to
enable it to call from functions which receives 'struct malidp_hw_device'
as argument. Furthermore, there is no way to retrieve 'struct drm_device'
from 'struct malidp_hw_device'.
Signed-off-by: Ayan Kumar Halder
---
C
Display and scaling engine interrupts need to be disabled when the
runtime pm invokes malidp_runtime_pm_suspend(). Conversely, they
need to be enabled in malidp_runtime_pm_resume().
This patch depends on:
https://lkml.org/lkml/2017/5/15/695
Signed-off-by: Ayan Kumar Halder
Signed-off-by
One needs to store the value of the OUTPUT_DEPTH that one has parsed from
device tree, so that it can be restored on system resume. This value is
set in the modeset function as this gets reset when the system suspends.
Signed-off-by: Ayan Kumar Halder
---
Changes in v3:-
- Rebased the patch on
()/malidp_se_irq_hw_init())
which will be later invoked from runtime_pm_resume function when it needs
to re-enable the interrupts.
Signed-off-by: Ayan Kumar Halder
---
Changes in v3:-
- Squashed https://patchwork.kernel.org/patch/10357203/ and
https://patchwork.kernel.org/patch/10357209/ into a single
runtime suspend mode before system suspend was called, pm_runtime_work()
will put the device back in runtime suspended mode( after the complete system
has been resumed).
Signed-off-by: Ayan Kumar Halder
---
Changes in v3:-
- Rebased on top of earlier v3 patches,
Changes in v2:-
- Removed the
contain subsampled (ie reduced) data (by a
factor of 2) and thus the
while calculating the byte position coresponding to the x and y co-ordinates,
one needs to be
divide it with the sampling factor.
Signed-off-by: Ayan Kumar halder
---
drivers/gpu/drm/drm_fb_cma_helper.c | 11 +--
1
The width and height needs to be swapped
Signed-off-by: Ayan Kumar halder
Reviewed-by: Brian Starkey
Reviewed-by: Alexandru Gheorghe
---
drivers/gpu/drm/arm/malidp_planes.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/arm/malidp_planes.c
b/drivers
, depending on the modifiers.
Signed-off-by: Ayan Kumar halder
Reviewed-by: Brian Starkey
---
drivers/gpu/drm/arm/malidp_hw.c | 27 -
drivers/gpu/drm/arm/malidp_hw.h | 2 +
drivers/gpu/drm/arm/malidp_planes.c | 81 +
drivers/gpu/drm/arm
the
necessary constraints on the size, alignment, offsets and pitch.
Signed-off-by: Ayan Kumar halder
Reviewed-by: Brian Starkey
Reviewed-by: Liviu Dudau
---
drivers/gpu/drm/arm/malidp_drv.c | 128 ++-
drivers/gpu/drm/arm/malidp_hw.h | 5 ++
2 files changed
|
AFBC_FORMAT_MOD_SPARSE | AFBC_FORMAT_MOD_YTR.
In future, we intend to add support for more combination of AFBC modifiers.
Currently, we are trying to enable a basic support of AFBC in malidp.
Ayan Kumar Halder (4):
drm/arm/malidp: Add modifier definitions for describing Arm
Framebuffer Compression
combinations are valid,
and different devices or use-cases may support different combinations.
Signed-off-by: Rosen Zhelev
Signed-off-by: Ayan Kumar halder
Reviewed-by: Brian Starkey
Reviewed-by: Liviu Dudau
Reviewed-by: James (Qian) Wang
---
include/uapi/drm/drm_fourcc.h | 83
On planes which support AFBC, expose an AFBC modifier for use with BGR888.
Signed-off-by: Ayan Kumar halder
Reviewed-by: Brian Starkey
Change-Id: I4739ff55c0f6d5715b268cb3947ed133a9ee7c2e
---
drivers/gpu/drm/arm/malidp_drv.c| 1 +
drivers/gpu/drm/arm/malidp_planes.c | 46
On planes which support AFBC, expose an AFBC modifier for use with BGR888.
Signed-off-by: Ayan Kumar halder
Reviewed-by: Brian Starkey
Reviewed-by: Liviu Dudau
Changes from v2:
- Removed the gerrit change-id
- Replaced DRM_ERROR() with DRM_DEBUG_KMS() in malidp_format_mod_supported()
to
combinations are valid,
and different devices or use-cases may support different combinations.
Signed-off-by: Rosen Zhelev
Signed-off-by: Ayan Kumar halder
Reviewed-by: Brian Starkey
Reviewed-by: Liviu Dudau
Reviewed-by: James (Qian) Wang
---
include/uapi/drm/drm_fourcc.h | 83
combinations are valid,
and different devices or use-cases may support different combinations.
Signed-off-by: Rosen Zhelev
Signed-off-by: Ayan Kumar halder
Reviewed-by: Brian Starkey
Reviewed-by: Liviu Dudau
Reviewed-by: James (Qian) Wang
---
include/uapi/drm/drm_fourcc.h | 83
Hi,
Apologies for spamming the list.
I forgot to 'no-disclaimer' email alias in my previous patch.
Regards,
Ayan Kumar Halder
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
On planes which support AFBC, expose an AFBC modifier for use with BGR888.
Signed-off-by: Ayan Kumar halder
Reviewed-by: Brian Starkey
Reviewed-by: Liviu Dudau
Changes from v2:
- Removed the gerrit change-id
- Replaced DRM_ERROR() with DRM_DEBUG_KMS() in malidp_format_mod_supported()
to
the
necessary constraints on the size, alignment, offsets and pitch.
Changes from v2:
- Replaced DRM_ERROR() with DRM_DEBUG_KMS() in
malidp_verify_afbc_framebuffer_caps() and malidp_verify_afbc_framebuffer_size()
Signed-off-by: Ayan Kumar halder
Reviewed-by: Brian Starkey
Reviewed-by: Liviu Dudau
-off-by: Ayan Kumar halder
Reviewed-by: Brian Starkey
---
drivers/gpu/drm/arm/malidp_hw.c | 27 +++-
drivers/gpu/drm/arm/malidp_hw.h | 2 +
drivers/gpu/drm/arm/malidp_planes.c | 83 +
drivers/gpu/drm/arm/malidp_regs.h | 20 +
4 files
combinations are valid,
and different devices or use-cases may support different combinations.
Changes from v2:-
- Added ack by Maarten Lankhorst
Signed-off-by: Rosen Zhelev
Signed-off-by: Ayan Kumar halder
Reviewed-by: Brian Starkey
Reviewed-by: Liviu Dudau
Reviewed-by: James (Qian) Wang
Acked-by
order to help
reviewers review the other patches (which are related to patch 1)
- For patches 2 and 4, replaced DRM_ERROR() with DRM_DEBUG_KMS()
- For patch 3, reworked malidp_de_set_plane_afbc() so as to consolidate
all afbc specific register configuration in this.
Ayan Kumar Halder (4):
drm/arm
ic
code in drm_fourcc.h ie the changes introduced by the following commits
were removed by git add -i :-
e065a8dd30af703b4794dc740c0825ee12b92efd
14d9deeb273c2bf4ec256589adabd8df65395d36
Change-Id: If050c17779ba16f8f47adcd825e3e2300676c247
Signed-off-by: Ayan Kumar halder
---
include/drm/drm_fou
nclusion of 'via_drmclient.h'.
vmwgfx:
- Added some DRM_VMW_* macros
- Renamed some structures like 'drm_vmw_dmabuf_rep' to 'drm_vmw_bo_rep', etc
- Added some new DRM_VMW_GB_SURFACE related structures and unions
Signed-off-by: Ayan Kumar halder
---
Dropped c
nclusion of 'via_drmclient.h'.
vmwgfx:
- Added some DRM_VMW_* macros
- Renamed some structures like 'drm_vmw_dmabuf_rep' to 'drm_vmw_bo_rep', etc
- Added some new DRM_VMW_GB_SURFACE related structures and unions
Changes in v2:
- Mentioned 'libdrm
Changes in v4:
- Removed the changes to vmwgfx_drm.h as it caused a build break ie
'make check' failed.
Change-Id: I018a06f65bf4a6a68400ab252b9cd05d041299b3
Signed-off-by: Ayan Kumar halder
Reviewed-by: Emil Velikov
---
include/drm/amdgpu_drm.h | 47 -
includ
A lot of drivers duplicate the function to check if a format is yuv or not.
If we add a field (to denote whether the format is yuv or not) in the
drm_format_info table, all the drivers can use this field and it will
prevent duplication of similar logic.
Signed-off-by: Ayan Kumar halder
drm_format_info table has a field 'is_yuv' to denote if the format
is yuv or not. The driver is expected to use this instead of
having a function for the same purpose.
Signed-off-by: Ayan Kumar halder
---
drivers/gpu/drm/i915/intel_display.c | 2 +-
drivers/gpu/drm/i915/intel_drv.
drm_format_info table has a field 'is_yuv' to denote if the format
is yuv or not. The driver is expected to use this instead of
having a function for the same purpose.
Signed-off-by: Ayan Kumar halder
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 24 +---
1 fi
drm_format_info table has a field 'is_yuv' to denote if the format
is yuv or not. The driver is expected to use this instead of
having a function for the same purpose.
Signed-off-by: Ayan Kumar halder
---
drivers/gpu/drm/sun4i/sun4i_backend.c | 12 +++-
1 file changed, 3
drm_format_info table has a field 'is_yuv' to denote if the format
is yuv or not. The driver is expected to use this instead of
having a function for the same purpose.
Signed-off-by: Ayan Kumar halder
---
drivers/gpu/drm/omapdrm/dss/dispc.c | 26 ++
1 file c
This issue was identified during a review on a previous patch:-
https://lists.freedesktop.org/archives/dri-devel/2018-July/183840.html
Signed-off-by: Ayan Kumar halder
---
drivers/gpu/drm/sun4i/sun4i_backend.c | 37 ++-
1 file changed, 6 insertions(+), 31 del
Kumar halder
---
drivers/gpu/drm/arm/malidp_planes.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/arm/malidp_planes.c
b/drivers/gpu/drm/arm/malidp_planes.c
index 7a44897..4af3c1f 100644
--- a/drivers/gpu/drm/arm/malidp_planes.c
+++ b/drivers/gpu/drm/arm
the destroy callback for each encoder. Thus tda998x_encoder_destroy()
gets invoked.
Signed-off-by: Ayan Kumar Halder
---
drivers/gpu/drm/i2c/tda998x_drv.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c
b/drivers/gpu/drm/i2c/tda998x_drv.c
index 9e67a7b..8ad1
is called for the corresponding drivers or by
drm_mode_config_cleanup().
Signed-off-by: Ayan Kumar Halder
---
Changes in v2:
- Reset the connectors' mask and the reference counts in drm_device
before unbinding any of its components (ie connectors and
encoders).
---
drivers/gpu/drm/arm/mali
truct malidp_hw_device'
as argument. Furthermore, there is no way to retrieve 'struct drm_device'
from 'struct malidp_hw_device'.
Signed-off-by: Ayan Kumar Halder
---
Changes in v2:-
- Removed the change id
---
drivers/gpu/drm/arm/malidp_drv.c | 9 ++---
drivers/gpu/drm/arm/
This patch series enhances and fixes certain issues relevant to system and
runtime power management on malidp.
---
Changes in v2:
- Removed the change ids and modified some commit messages
---
Ayan Kumar Halder (8):
drm/arm/malidp: Modified the prototype of malidp_de_irq_fini
drm/arm/malidp
One needs to store the value of the OUTPUT_DEPTH that one has parsed from
device tree, so that it can be restored on system resume. This value is
set in the modeset function as this gets reset when the system suspends.
Signed-off-by: Ayan Kumar Halder
---
Changes in v2:-
- Removed the change id
Extract the hardware initialisation part from malidp_de_irq_init() into the
malidp_de_irq_hw_init() which will be later invoked from runtime_pm_resume
function when it needs to re-enable the interrupts.
Signed-off-by: Ayan Kumar Halder
---
Changes in v2:-
- Removed the change id
---
drivers
Extract the hardware initialisation part from malidp_se_irq_init() into the
malidp_se_irq_hw_init() which will be later invoked from
malidpxxx_enable_memwrite() when it needs to re-enable the interrupts.
Signed-off-by: Ayan Kumar Halder
---
Changes in v2:-
- Removed the change id
---
drivers
hw_device'
as argument. Furthermore, there is no way to retrieve 'struct drm_device'
from 'struct malidp_hw_device'
Signed-off-by: Ayan Kumar Halder
---
Changes in v2:-
- Removed the change id
---
drivers/gpu/drm/arm/malidp_drv.c | 4 ++--
drivers/gpu/drm/arm/malidp
Display engine and core interrupts need to be disabled when the
system invokes malidp_runtime_pm_suspend. Consequently, they
need to be enabled in malidp_runtime_pm_resume.
Signed-off-by: Ayan Kumar Halder
---
Changes in v2:-
- Removed the change id
---
drivers/gpu/drm/arm/malidp_drv.c | 2
Scaling engine interrupts need to be enabled/disabled as and when memwrite
is enabled and disabled. The reason being scaling engine interrupts are
used only by the memory writeout layer.
This patch depends on:
https://lkml.org/lkml/2017/5/15/695
Signed-off-by: Ayan Kumar Halder
---
Changes in
runtime suspend mode before system suspend was called, pm_runtime_work()
will put the device back in runtime suspended mode( after the complete system
has been resumed).
Signed-off-by: Ayan Kumar Halder
---
Changes in v2:-
- Removed the change id and modified the commit message
---
drivers/gpu
truct malidp_hw_device'
as argument. Furthermore, there is no way to retrieve 'struct drm_device'
from 'struct malidp_hw_device'.
Change-Id: I39c38cc4c0c9dd951777fbcb13e2ee3168ea0141
Signed-off-by: Ayan Kumar Halder
---
drivers/gpu/drm/arm/malidp_drv.c | 9 ++---
drivers/gpu/drm
This patch series enhances and fixes certain issues relevant to system and
runtime power management on malidp.
Ayan Kumar Halder (8):
drm/arm/malidp: Modified the prototype of malidp_de_irq_fini
drm/arm/malidp: Modified the prototype of malidp_se_irq_fini
drm/arm/malidp: Split
hw_device'
as argument. Furthermore, there is no way to retrieve 'struct drm_device'
from 'struct malidp_hw_device'
Change-Id: Iab7ac99917f0faf739aee97b00e1758ad1ae787b
Signed-off-by: Ayan Kumar Halder
---
drivers/gpu/drm/arm/malidp_drv.c | 4 ++--
drivers/gpu/drm/arm/
One needs to store the value of the OUTPUT_DEPTH that one has parsed from
device tree, so that it can be restored on system resume. This value is
set in the modeset function as this gets reset when the system suspends.
Signed-off-by: Ayan Kumar Halder
Change-Id
Extract the hardware initialisation part from malidp_se_irq_init() into the
malidp_se_irq_hw_init() which will be later invoked from
malidpxxx_enable_memwrite() when it needs to re-enable the interrupts.
Signed-off-by: Ayan Kumar Halder
Change-Id: Ibb26e86b38141993539307705695e3f6a9e32caa
which enables the clocks and the interrupts
(previously disabled) and sets the runtime status as active.
Signed-off-by: Ayan Kumar Halder
Change-Id: I5f8c3d28f076314a1c9da2a46760a9c37039ccda
---
drivers/gpu/drm/arm/malidp_drv.c | 17 +
1 file changed, 17 insertions(+)
diff --git a
Display engine and core interrupts need to be disabled when the
system invokes malidp_runtime_pm_suspend. Consequently, they
need to be enabled in malidp_runtime_pm_resume.
Signed-off-by: Ayan Kumar Halder
Change-Id: Ib8e5e8319fdd768f8a97d9b5960fcfa8ba90eba3
---
drivers/gpu/drm/arm/malidp_drv.c
Extract the hardware initialisation part from malidp_de_irq_init() into the
malidp_de_irq_hw_init() which will be later invoked from runtime_pm_resume
function when it needs to re-enable the interrupts.
Change-Id: If8bdb0e246653cb7d7b7d6d63919c45b01350c10
Signed-off-by: Ayan Kumar Halder
Change-Id: Ic78aa5cd7b53998a1947067c4a15c19de239583b
Signed-off-by: Ayan Kumar Halder
---
drivers/gpu/drm/arm/malidp_hw.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/arm/malidp_hw.c b/drivers/gpu/drm/arm/malidp_hw.c
index f5633bc..90d76e4 100644
--- a/drivers/gpu/drm/arm/m
From: Ayan Halder
Mali dp needs to disable pixel alpha blending (use layer alpha blending) to
display color formats that do not contain alpha bits per pixel
This patch depends on:
"[PATCH v2 01/19] drm/fourcc: Add a alpha field to drm_format_info"
Signed-off-by: Ayan Kumar Halder
62 matches
Mail list logo
