RE: RE: [PATCH v2] usb: core:hub.c: do not print error log on -enomem

2016-11-30 Thread Atul Raj
ET_TT? */ return -ENOMEM; + } /* info that CLEAR_TT_BUFFER needs */ clear->tt = tt->multi ? udev->ttport : 1; -- 2.10.2.windows.1 > s/enomem/ENOMEM > > On 30-11-16, 06:32, Atul Raj wrote: > > All kmalloc-based functions print e

[PATCH] usb:hub: readibility and consistency in coding style

2016-11-30 Thread Atul Raj
It is suggested to keep braces if there is a comment in if case as comment also takes a line. --- drivers/usb/core/hub.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index 82059f26..f43e6302 100644 --- a/drivers/usb/core/hu

RE: Re: [PATCH] usb:hub: readibility and consistency in coding style

2016-11-30 Thread Atul Raj
ot; I got the name of people from get_maintainer.pl from now I will include only you. is it ok?? one more thing in another mail you replied to me as On Wed, Nov 30, 2016 at 11:40:28AM +0000, Atul Raj wrote: > changes in v2 > - added braces as suggested. Why is this here? >