[PATCH 01/10] drm/amd/display: Turn global functions into static

2023-02-13 Thread Arthur Grillo
Turn global functions that are only used locally into static ones. This reduces the number of -Wmissing-prototypes warnings. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/amd/display/dc/clk_mgr/dcn315/dcn315_clk_mgr.c | 2 +- drivers/gpu/drm/amd/display/dc/irq/dcn201/irq_service_dcn201.c | 2

[PATCH 00/10] Resolve warnings from AMDGPU

2023-02-13 Thread Arthur Grillo
Hi, This series resolve some of the warnings that appear when compiling AMDGPU with W=1. Each patch is focused in a specific warning. This is my First Patch for the GSoC Project Idea about increasing code coverage of the DRM code[1]. Thanks for reviewing! Best regards, Arthur Grillo [1

[PATCH 02/10] drm/amd/display: Add function prototypes to headers

2023-02-13 Thread Arthur Grillo
Add function prototypes to headers to reduce the number of -Wmissing-prototypes warnings. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/amd/display/dc/dcn31/dcn31_hubbub.h | 2 ++ drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hubbub.h | 2 ++ drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hubp.h

[PATCH 03/10] drm/amd/amdgpu: Add function prototypes to headers

2023-02-13 Thread Arthur Grillo
Add function prototypes to headers to reduce the number of -Wmissing-prototypes warnings. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.h b/drivers/gpu/drm/amd/amdgpu

[PATCH 04/10] drm/amd/display: Add previously missing includes

2023-02-13 Thread Arthur Grillo
Add includes that were previously missing to reduce the number of -Wmissing-prototypes warnings. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/amd/display/dc/dcn32/dcn32_init.c | 1 + drivers/gpu/drm/amd/display/dc/link/accessories/link_dp_trace.c | 1 + 2 files changed, 2

[PATCH 05/10] drm/amd/display: Fix excess arguments on kernel-doc

2023-02-13 Thread Arthur Grillo
Remove arguments present on kernel-doc that are not present on the function declaration and add the new ones if present. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c| 15 +++ drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 2 +- .../gpu

[PATCH 06/10] drm/amd/display: Fix implicit enum conversion

2023-02-13 Thread Arthur Grillo
| locals->ODMCombineEnablePerState[i][k] = true; | ^ Signed-off-by: Arthur Grillo --- .../amd/display/dc/dml/dcn20/display_mode_vba_20.c | 9 + .../amd/display/dc/dml/dc

[PATCH 07/10] drm/amd/amdgpu: Deal with possible fail allocation

2023-02-13 Thread Arthur Grillo
Deal with return value of an allocation. This reduces the number of -Wunused-but-set-variable warnings. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c b/drivers/gpu/drm/amd

[PATCH 08/10] drm/amd/display: Remove unused local variables

2023-02-13 Thread Arthur Grillo
Remove local variables that were just set but were never used. This decrease the number of -Wunused-but-set-variable warnings. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c | 3 --- drivers/gpu/drm/amd/display/dc/dcn201/dcn201_dpp.c | 7

[PATCH v2 1/3] drm/amd/display: Fix implicit enum conversion

2023-02-17 Thread Arthur Grillo
| locals->ODMCombineEnablePerState[i][k] = true; | ^ Signed-off-by: Arthur Grillo --- .../amd/display/dc/dml/dcn20/display_mode_vba_20.c | 9 + .../amd/display/dc/dml/dc

[PATCH v2 2/3] drm/amd/display: Remove unused local variables

2023-02-17 Thread Arthur Grillo
Remove local variables that were just set but were never used. This decrease the number of -Wunused-but-set-variable warnings. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c | 3 +-- drivers/gpu/drm/amd/display/dc/dcn201/dcn201_dpp.c | 7

[PATCH v2 3/3] drm/amd/display: Remove unused local variables and function

2023-02-17 Thread Arthur Grillo
Remove a couple of local variables that are only set but never used, also remove an static utility function that is never used in consequence of the variable removal. This decrease the number of -Wunused-but-set-variable warnings. Signed-off-by: Arthur Grillo --- .../gpu/drm/amd/display/dc

[PATCH v2 0/3] Resolve warnings from AMDGPU

2023-02-17 Thread Arthur Grillo
Hi, This series resolve some of the warnings that appear when compiling AMDGPU with W=1. Each patch is focused in a specific warning. This is my First Patch for the GSoC Project Idea about increasing code coverage of the DRM code[1]. Thanks for reviewing! Best regards, Arthur Grillo [1

[PATCH] drm/format_helper: Add Kunit tests for drm_fb_xrgb8888_to_mono()

2023-03-02 Thread Arthur Grillo
Extend the existing test cases to test the conversion from XRGB to monochromatic. Signed-off-by: Arthur Grillo --- .../gpu/drm/tests/drm_format_helper_test.c| 73 +++ 1 file changed, 73 insertions(+) diff --git a/drivers/gpu/drm/tests/drm_format_helper_test.c b/drivers

[PATCH] drm/tests: Add back seed value information

2022-10-27 Thread Arthur Grillo
As reported by Michał the drm_mm and drm_buddy unit tests lost the printk with seed value after they being refactored into kunit. This patch adds back this important information to assure reproducibility converting them to use the kunit api. Signed-off-by: Arthur Grillo Reported-by: Michał

[PATCH v2] drm/tests: Add back seed value information

2022-10-28 Thread Arthur Grillo
As reported by Michał the drm_mm and drm_buddy unit tests lost the printk with seed value after they where refactored into KUnit. This patch add back this important information to assure reproducibility and convert them to the KUnit API. Reported-by: Michał Winiarski Signed-off-by: Arthur Grillo

[PATCH v4] drm/tests: Add back seed value information

2022-10-28 Thread Arthur Grillo
As reported by Michał the drm_mm and drm_buddy unit tests lost the printk with seed value after they were refactored into KUnit. Add kunit_info with seed value information to assure reproducibility. Reported-by: Michał Winiarski Signed-off-by: Arthur Grillo --- v1->v2: https://lore.kernel.

[PATCH v3] drm/tests: Add back seed value information

2022-10-28 Thread Arthur Grillo
As reported by Michał the drm_mm and drm_buddy unit tests lost the printk with seed value after they were refactored into KUnit. Add kunit_info with seed value information to assure reproducibility. Reported-by: Michał Winiarski Signed-off-by: Arthur Grillo --- v1->v2: https://lore.kernel.

[PATCH v5] drm/tests: Add back seed value information

2022-10-28 Thread Arthur Grillo
As reported by Michał the drm_mm and drm_buddy unit tests lost the printk with seed value after they were refactored into KUnit. Add kunit_info with seed value information to assure reproducibility. Reported-by: Michał Winiarski Signed-off-by: Arthur Grillo --- v1->v2: https://lore.kernel.

[PATCH v5 0/5] Create tests for the drm_rect functions

2023-04-18 Thread Arthur Grillo
coverage report, I uploaded on the link below: https://grillo-0.github.io/coverage-reports/more-rect-tests/drivers/gpu/drm/drm_rect.c.gcov.html Thanks for reviewing! Best regards, ~Arthur Grillo --- v1->v2: https://lore.kernel.org/all/20230322140701.69852-1-arthurgri...@riseup.net/ - Cre

[PATCH v5 1/5] drm/tests: Add test cases for drm_rect_intersect()

2023-04-18 Thread Arthur Grillo
Insert parameterized tests for the drm_rect_intersect() to ensure correctness and prevent future regressions. Also, create a helper for testing if two drm_rects are equal. Signed-off-by: Arthur Grillo Reviewed-by: Maíra Canal --- drivers/gpu/drm/tests/drm_rect_test.c | 148

[PATCH v5 2/5] drm/tests: Add test cases for drm_rect_calc_hscale()

2023-04-18 Thread Arthur Grillo
Insert parameterized test for the drm_rect_calc_hscale() to ensure correctness and prevent future regressions. Besides the test for the usual case, tests the exceptions. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/tests/drm_rect_test.c | 72 +++ 1 file changed, 72

[PATCH v5 3/5] drm/tests: Add test cases for drm_rect_calc_vscale()

2023-04-18 Thread Arthur Grillo
Insert parameterized test for the drm_rect_calc_vscale() to ensure correctness and prevent future regressions. Besides the test for the usual case, tests the exceptions. It uses the same struct from drm_rect_calc_hscale(). Signed-off-by: Arthur Grillo --- drivers/gpu/drm/tests/drm_rect_test.c

[PATCH v5 4/5] drm/tests: Add test cases for drm_rect_rotate()

2023-04-18 Thread Arthur Grillo
Insert a parameterized test for the drm_rect_rotate() to ensure correctness and prevent future regressions. All possible rotation modes are covered by the test. Signed-off-by: Arthur Grillo Reviewed-by: Maíra Canal --- drivers/gpu/drm/tests/drm_rect_test.c | 72 +++ 1

[PATCH v5 5/5] drm/test: Add test cases for drm_rect_rotate_inv()

2023-04-18 Thread Arthur Grillo
Insert a parameterized test for the drm_rect_rotate_inv() to ensure its correctness and prevent future regressions. The test covers all rotation modes. It uses the same test cases from drm_test_rect_rotate(). Signed-off-by: Arthur Grillo Reviewed-by: Maíra Canal --- drivers/gpu/drm/tests

[PATCH v3 0/5] Create tests for the drm_rect functions

2023-04-04 Thread Arthur Grillo
! Best regards, ~Arthur Grillo --- v1->v2: https://lore.kernel.org/all/20230322140701.69852-1-arthurgri...@riseup.net/ - Create parameterized tests for drm_rect_intersect(). - Use .16 binary fixed point values on the drm_rect_calc_hscale() and drm_rect_calc_vscale() tests. - Replace INT_MIN fo

[PATCH v3 1/5] drm/tests: Add test cases for drm_rect_intersect()

2023-04-04 Thread Arthur Grillo
Insert parameterized tests for the drm_rect_intersect() to ensure correctness and prevent future regressions. Also, create a helper for testing if two drm_rects are equal. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/tests/drm_rect_test.c | 148 ++ 1 file changed

[PATCH v3 2/5] drm/tests: Add test cases for drm_rect_calc_hscale()

2023-04-04 Thread Arthur Grillo
Insert parameterized test for the drm_rect_calc_hscale() to ensure correctness and prevent future regressions. Besides the test for the usual case, tests the exceptions. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/tests/drm_rect_test.c | 72 +++ 1 file changed, 72

[PATCH v3 3/5] drm/tests: Add test cases for drm_rect_calc_vscale()

2023-04-04 Thread Arthur Grillo
Insert parameterized test for the drm_rect_calc_vscale() to ensure correctness and prevent future regressions. Besides the test for the usual case, tests the exceptions. It uses the same struct from drm_rect_calc_hscale(). Signed-off-by: Arthur Grillo --- drivers/gpu/drm/tests/drm_rect_test.c

[PATCH v3 4/5] drm/tests: Add test cases for drm_rect_rotate()

2023-04-04 Thread Arthur Grillo
Insert a parameterized test for the drm_rect_rotate() to ensure correctness and prevent future regressions. All possible rotation modes are covered by the test. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/tests/drm_rect_test.c | 72 +++ 1 file changed, 72

[PATCH v3 5/5] drm/test: Add test cases for drm_rect_rotate_inv()

2023-04-04 Thread Arthur Grillo
Insert a parameterized test for the drm_rect_rotate_inv() to ensure its correctness and prevent future regressions. The test covers all rotation modes. It uses the same test cases from drm_test_rect_rotate(). Signed-off-by: Arthur Grillo --- drivers/gpu/drm/tests/drm_rect_test.c | 11

[PATCH v4 0/5] Create tests for the drm_rect functions

2023-04-06 Thread Arthur Grillo
coverage report, I uploaded on the link below: https://grillo-0.github.io/coverage-reports/more-rect-tests/drivers/gpu/drm/drm_rect.c.gcov.html Thanks for reviewing! Best regards, ~Arthur Grillo --- v1->v2: https://lore.kernel.org/all/20230322140701.69852-1-arthurgri...@riseup.net/ - Cre

[PATCH v4 1/5] drm/tests: Add test cases for drm_rect_intersect()

2023-04-06 Thread Arthur Grillo
Insert parameterized tests for the drm_rect_intersect() to ensure correctness and prevent future regressions. Also, create a helper for testing if two drm_rects are equal. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/tests/drm_rect_test.c | 148 ++ 1 file changed

[PATCH v4 2/5] drm/tests: Add test cases for drm_rect_calc_hscale()

2023-04-06 Thread Arthur Grillo
Insert parameterized test for the drm_rect_calc_hscale() to ensure correctness and prevent future regressions. Besides the test for the usual case, tests the exceptions. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/tests/drm_rect_test.c | 72 +++ 1 file changed, 72

[PATCH v4 3/5] drm/tests: Add test cases for drm_rect_calc_vscale()

2023-04-06 Thread Arthur Grillo
Insert parameterized test for the drm_rect_calc_vscale() to ensure correctness and prevent future regressions. Besides the test for the usual case, tests the exceptions. It uses the same struct from drm_rect_calc_hscale(). Signed-off-by: Arthur Grillo --- drivers/gpu/drm/tests/drm_rect_test.c

[PATCH v4 4/5] drm/tests: Add test cases for drm_rect_rotate()

2023-04-06 Thread Arthur Grillo
Insert a parameterized test for the drm_rect_rotate() to ensure correctness and prevent future regressions. All possible rotation modes are covered by the test. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/tests/drm_rect_test.c | 72 +++ 1 file changed, 72

[PATCH v4 5/5] drm/test: Add test cases for drm_rect_rotate_inv()

2023-04-06 Thread Arthur Grillo
Insert a parameterized test for the drm_rect_rotate_inv() to ensure its correctness and prevent future regressions. The test covers all rotation modes. It uses the same test cases from drm_test_rect_rotate(). Signed-off-by: Arthur Grillo --- drivers/gpu/drm/tests/drm_rect_test.c | 11

[PATCH v2 0/2] drm/format-helper: Add Kunit tests for drm_fb_xrgb8888_to_mono()

2023-03-10 Thread Arthur Grillo
This patchset aims to insert a unit test for the conversion from XRGB to monochromatic. Previously this was a single patch, but as the changes grew from v1 to v2, I thought it would be better to split it in two. Thanks for reviewing! Best regards, ~Arthur Grillo --- v1->v2: ht

[PATCH v2 1/2] drm/format-helper: Add Kunit tests for drm_fb_xrgb8888_to_mono()

2023-03-10 Thread Arthur Grillo
Extend the existing test cases to test the conversion from XRGB to monochromatic. Signed-off-by: Arthur Grillo --- .../gpu/drm/tests/drm_format_helper_test.c| 62 +++ 1 file changed, 62 insertions(+) diff --git a/drivers/gpu/drm/tests/drm_format_helper_test.c b/drivers

[PATCH v2 2/2] drm/format-helper: Make "destination_pitch" test case usable for the monochrome case

2023-03-10 Thread Arthur Grillo
This test case uses an arbitrary pitch size, different of the default one, to test if the conversions methods obey. Change the "destination_pitch" colors to change the monochrome expected result from being just zeros, as this makes the arbitrary pitch use unusable. Signed-off-by: Art

[PATCH v3 0/2] drm/format-helper: Add Kunit tests for drm_fb_xrgb8888_to_mono()

2023-03-11 Thread Arthur Grillo
This patchset aims to insert a unit test for the conversion from XRGB to monochromatic. Previously this was a single patch, but as the changes grew from v1 to v2, I thought it would be better to split it in two. Thanks for reviewing! Best regards, ~Arthur Grillo --- v1->v2: ht

[PATCH v3 1/2] drm/format-helper: Add Kunit tests for drm_fb_xrgb8888_to_mono()

2023-03-11 Thread Arthur Grillo
Extend the existing test cases to test the conversion from XRGB to monochromatic. Signed-off-by: Arthur Grillo --- .../gpu/drm/tests/drm_format_helper_test.c| 62 +++ 1 file changed, 62 insertions(+) diff --git a/drivers/gpu/drm/tests/drm_format_helper_test.c b/drivers

[PATCH v3 2/2] drm/format-helper: Make "destination_pitch" test case usable for the monochrome case

2023-03-11 Thread Arthur Grillo
This test case uses an arbitrary pitch size, different of the default one, to test if the conversions methods obey. Change the "destination_pitch" colors to change the monochrome expected result from being just zeros, as this makes the arbitrary pitch use unusable. Signed-off-by: Art

[PATCH 0/5] Create tests for the drm_rect functions

2023-03-22 Thread Arthur Grillo
! Best regards, ~Arthur Grillo --- [1]: https://gcc.gnu.org/onlinedocs/gcc/Gcov.html#Gcov --- Arthur Grillo (5): drm/tests: Test drm_rect_intersect() drm/tests: Test drm_rect_calc_hscale() drm/tests: Test drm_rect_calc_vscale() drm/tests: Test drm_rect_rotate() drm/test: Test

[PATCH 1/5] drm/tests: Test drm_rect_intersect()

2023-03-22 Thread Arthur Grillo
Insert test for the drm_rect_intersect() function, it also create a helper for comparing drm_rects more easily. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/tests/drm_rect_test.c | 30 +++ 1 file changed, 30 insertions(+) diff --git a/drivers/gpu/drm/tests

[PATCH 2/5] drm/tests: Test drm_rect_calc_hscale()

2023-03-22 Thread Arthur Grillo
Insert test for the drm_rect_hscale() function, besides the test for the usual case it also test for the exceptions. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/tests/drm_rect_test.c | 58 +++ 1 file changed, 58 insertions(+) diff --git a/drivers/gpu/drm/tests

[PATCH 3/5] drm/tests: Test drm_rect_calc_vscale()

2023-03-22 Thread Arthur Grillo
Insert test for the drm_rect_vscale() function, besides the test for the usual case it also test for the exceptions. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/tests/drm_rect_test.c | 56 +++ 1 file changed, 56 insertions(+) diff --git a/drivers/gpu/drm/tests

[PATCH 4/5] drm/tests: Test drm_rect_rotate()

2023-03-22 Thread Arthur Grillo
Insert test for the drm_rect_rotate() function, create test cases for all the rotation modes. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/tests/drm_rect_test.c | 74 +++ 1 file changed, 74 insertions(+) diff --git a/drivers/gpu/drm/tests/drm_rect_test.c b/drivers

[PATCH 5/5] drm/test: Test drm_rect_rotate_inv()

2023-03-22 Thread Arthur Grillo
Insert test for the drm_rect_rotate_inv() function, by expanding the existing test framework for the drm_rect_rotate(). Signed-off-by: Arthur Grillo --- drivers/gpu/drm/tests/drm_rect_test.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/tests/drm_rect_test.c

[PATCH] drm/i915/overlay: Remove redundant drm_rect_visible() use

2023-03-24 Thread Arthur Grillo
The drm_rect_intersect() already returns if the intersection is visible or not, so the use of drm_rect_visible() is duplicate. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/i915/display/intel_overlay.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915

[PATCH v2] drm/i915/overlay: Remove redundant drm_rect_visible() use

2023-03-25 Thread Arthur Grillo
The drm_rect_intersect() already returns if the intersection is visible or not, so the use of drm_rect_visible() is duplicate. Signed-off-by: Arthur Grillo --- v1->v2: https://lore.kernel.org/all/20230324142533.6357-1-arthurgri...@riseup.net/ - Split the if condition. --- drivers/gpu/drm/i

[PATCH v2 0/5] Create tests for the drm_rect functions

2023-03-27 Thread Arthur Grillo
! Best regards, ~Arthur Grillo --- v1->v2: https://lore.kernel.org/all/20230322140701.69852-1-arthurgri...@riseup.net/ - Create parameterized tests for drm_rect_intersect(). - Use .16 binary fixed point values on the drm_rect_calc_hscale() and drm_rect_calc_vscale() tests. - Replace INT_MIN fo

[PATCH v2 1/5] drm/tests: Test drm_rect_intersect()

2023-03-27 Thread Arthur Grillo
Insert test for the drm_rect_intersect() function, it also create a helper for comparing drm_rects more easily. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/tests/drm_rect_test.c | 139 ++ 1 file changed, 139 insertions(+) diff --git a/drivers/gpu/drm/tests

[PATCH v2 3/5] drm/tests: Test drm_rect_calc_vscale()

2023-03-27 Thread Arthur Grillo
Insert test for the drm_rect_vscale() function, besides the test for the usual case it also test for the exceptions. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/tests/drm_rect_test.c | 56 +++ 1 file changed, 56 insertions(+) diff --git a/drivers/gpu/drm/tests

[PATCH v2 4/5] drm/tests: Test drm_rect_rotate()

2023-03-27 Thread Arthur Grillo
Insert test for the drm_rect_rotate() function, create test cases for all the rotation modes. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/tests/drm_rect_test.c | 72 +++ 1 file changed, 72 insertions(+) diff --git a/drivers/gpu/drm/tests/drm_rect_test.c b/drivers

[PATCH v2 2/5] drm/tests: Test drm_rect_calc_hscale()

2023-03-27 Thread Arthur Grillo
Insert test for the drm_rect_hscale() function, besides the test for the usual case it also test for the exceptions. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/tests/drm_rect_test.c | 57 +++ 1 file changed, 57 insertions(+) diff --git a/drivers/gpu/drm/tests

[PATCH v2 5/5] drm/test: Test drm_rect_rotate_inv()

2023-03-27 Thread Arthur Grillo
Insert test for the drm_rect_rotate_inv() function, by expanding the existing test framework for the drm_rect_rotate(). Signed-off-by: Arthur Grillo --- drivers/gpu/drm/tests/drm_rect_test.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/tests/drm_rect_test.c

[PATCH v3] drm/vkms: Add support to 1D gamma LUT

2023-06-15 Thread Arthur Grillo
used through the LUT procedure (Pekka) - Change the switch statement to a cast to __u16* (Pekka) - Make the apply_lut_to_channel_value return the computation result (Pekka) Signed-off-by: Arthur Grillo --- drivers/gpu/drm/vkms/vkms_composer.c | 82

[PATCH v4] drm/vkms: Add support to 1D gamma LUT

2023-06-21 Thread Arthur Grillo
drm_color_lut` (Pekka) - Remove unused variable (kernel test robot) Signed-off-by: Arthur Grillo Acked-by: Pekka Paalanen --- drivers/gpu/drm/vkms/vkms_composer.c | 86 drivers/gpu/drm/vkms/vkms_crtc.c | 3 + drivers/gpu/drm/vkms/vkms_drv.c | 20 ++- drivers

[PATCH 0/6] Increase code coverage on drm_format_helper.c

2023-07-21 Thread Arthur Grillo
://grillo-0.github.io/coverage-reports/gsoc-drm-format-test/drivers/gpu/drm/drm_format_helper.c.gcov.html Arthur Grillo (6): drm/format-helper: Test default pitch fallback drm/format-helper: Add KUnit tests for drm_fb_swab() drm/format-helper: Add KUnit tests for drm_fb_clip_offset() drm

[PATCH 1/6] drm/format-helper: Test default pitch fallback

2023-07-21 Thread Arthur Grillo
Test the default pitch fallback when NULL is passed as the dst_pitch on the conversion procedures. Signed-off-by: Arthur Grillo --- .../gpu/drm/tests/drm_format_helper_test.c| 132 -- 1 file changed, 87 insertions(+), 45 deletions(-) diff --git a/drivers/gpu/drm/tests

[PATCH 2/6] drm/format-helper: Add KUnit tests for drm_fb_swab()

2023-07-21 Thread Arthur Grillo
Insert parameterized test for the drm_fb_swab() to ensure correctness and prevent future regressions. Signed-off-by: Arthur Grillo --- .../gpu/drm/tests/drm_format_helper_test.c| 66 +++ 1 file changed, 66 insertions(+) diff --git a/drivers/gpu/drm/tests

[PATCH 3/6] drm/format-helper: Add KUnit tests for drm_fb_clip_offset()

2023-07-21 Thread Arthur Grillo
Insert parameterized test for the drm_fb_clip_offset() to ensure correctness and prevent future regressions. Signed-off-by: Arthur Grillo --- .../gpu/drm/tests/drm_format_helper_test.c| 91 +++ 1 file changed, 91 insertions(+) diff --git a/drivers/gpu/drm/tests

[PATCH 4/6] drm/format-helper: Add KUnit tests for drm_fb_build_fourcc_list()

2023-07-21 Thread Arthur Grillo
Insert parameterized test for the drm_fb_build_fourcc_list() to ensure correctness and prevent future regressions. Signed-off-by: Arthur Grillo --- .../gpu/drm/tests/drm_format_helper_test.c| 143 ++ 1 file changed, 143 insertions(+) diff --git a/drivers/gpu/drm/tests

[PATCH 6/6] drm/format-helper: Add KUnit tests for drm_fb_memcpy()

2023-07-21 Thread Arthur Grillo
Insert parameterized test for the drm_fb_memcpy() to ensure correctness and prevent future regressions. The test case can accept different formats. Signed-off-by: Arthur Grillo --- .../gpu/drm/tests/drm_format_helper_test.c| 391 ++ 1 file changed, 391 insertions(+) diff

[PATCH 5/6] drm/format-helper-test: Add multi-plane support to conversion_buf_size()

2023-07-21 Thread Arthur Grillo
The drm_fb_memcpy() supports multi-plane formats. To fully test it in the future, add multi-plane support to the conversion_buf_size() helper. Signed-off-by: Arthur Grillo --- .../gpu/drm/tests/drm_format_helper_test.c| 28 +-- 1 file changed, 14 insertions(+), 14 deletions

[PATCH] drm/tests: Remove CONFIG_DRM_FBDEV_EMULATION on .kunitconfig

2023-07-26 Thread Arthur Grillo
unction `fbcon_update_vcs': . . . make[3]: *** [../scripts/Makefile.vmlinux:36: vmlinux] Error 1 make[2]: *** [/home/grillo/projects/linux/Makefile:1238: vmlinux] Error 2 make[1]: *** [/home/grillo/projects/linux/Makefile:234: __sub-make] Error 2 make: *** [Makefile:234: __sub-make] Error 2 Fixes: c242

[PATCH] drm/tests: Alloc drm_device on drm_exec tests

2023-07-27 Thread Arthur Grillo
/2014 [15:05:50] RIP: 0010:drm_gem_private_object_init+0x60/0xc0 Fixes: e6303f323b1a ("drm: manager to keep track of GPUs VA mappings") Signed-off-by: Arthur Grillo --- drivers/gpu/drm/tests/drm_exec_test.c | 36 +-- 1 file changed, 29 insertions(+), 7 deletion

[PATCH v2] drm/tests: Alloc drm_device on drm_exec tests

2023-07-28 Thread Arthur Grillo
/2014 [15:05:50] RIP: 0010:drm_gem_private_object_init+0x60/0xc0 Fixes: e6303f323b1a ("drm: manager to keep track of GPUs VA mappings") Signed-off-by: Arthur Grillo Tested-by: Danilo Krummrich Acked-by: Danilo Krummrich Reviewed-by: Maíra Canal --- v1->v2: https://lore.k

[PATCH v3] drm/tests: Alloc drm_device on drm_exec tests

2023-07-31 Thread Arthur Grillo
/2014 [15:05:50] RIP: 0010:drm_gem_private_object_init+0x60/0xc0 Fixes: e6303f323b1a ("drm: manager to keep track of GPUs VA mappings") Signed-off-by: Arthur Grillo Tested-by: Danilo Krummrich Acked-by: Danilo Krummrich Reviewed-by: Maíra Canal --- v1->v2: https://lore.k

Re: [PATCH] drm: Drop select FRAMEBUFFER_CONSOLE for DRM_FBDEV_EMULATION

2023-08-04 Thread Arthur Grillo
previously had DRM=y > and FB=n now has FB_CORE=y and FRAMEBUFFER_CONSOLE=y. > > This leads to unmet direct dependencies detected for FRAMEBUFFER_CONSOLE > as reported by Arthur Grillo, e.g: > > WARNING: unmet direct dependencies detected for FRAMEBUFFER_CONSOLE > Depends on

[PATCH] drm/vkms: Add support to 1D gamma LUT

2023-06-02 Thread Arthur Grillo
Support a 1D gamma LUT for each color channel on the VKMS driver. Add a check for the LUT length by creating vkms_atomic_check(). Tested with: igt@kms_color@gamma igt@kms_color@legacy-gamma igt@kms_color@invalid-gamma-lut-sizes Signed-off-by: Arthur Grillo --- drivers/gpu/drm/vkms

Re: [PATCH -next 6/7] drm/format-helper: Remove unnecessary NULL values

2023-08-09 Thread Arthur Grillo
ff-by: Ruan Jinjie > --- > .../gpu/drm/tests/drm_format_helper_test.c| 28 +-- > 1 file changed, 14 insertions(+), 14 deletions(-) Reviewed-by: Arthur Grillo Best Regards, ~Arthur Grillo > > diff --git a/drivers/gpu/drm/tests/drm_format_helper_test.c > b/drivers/gp

Re: [PATCH 6/6] drm/format-helper: Add KUnit tests for drm_fb_memcpy()

2023-08-09 Thread Arthur Grillo
On 05/08/23 10:26, Maira Canal wrote: > On 7/21/23 15:23, Arthur Grillo wrote: >> Insert parameterized test for the drm_fb_memcpy() to ensure correctness >> and prevent future regressions. The test case can accept different >> formats. >> >> Signed-off-by: Arthu

[PATCH v2 0/6] Increase code coverage on drm_format_helper.c

2023-08-11 Thread Arthur Grillo
://grillo-0.github.io/coverage-reports/gsoc-drm-format-test/drivers/gpu/drm/drm_format_helper.c.gcov.html Signed-off-by: Arthur Grillo --- v1->v2: https://lore.kernel.org/r/20230721182316.560649-1-arthurgri...@riseup.net - Change patch prefix to "drm/tests" (Maíra Canal) - Simplif

[PATCH v2 1/6] drm/tests: Test default pitch fallback

2023-08-11 Thread Arthur Grillo
Test the default pitch fallback when NULL is passed as the dst_pitch on the conversion procedures. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/tests/drm_format_helper_test.c | 126 - 1 file changed, 81 insertions(+), 45 deletions(-) diff --git a/drivers/gpu/drm

[PATCH v2 4/6] drm/tests: Add KUnit tests for drm_fb_build_fourcc_list()

2023-08-11 Thread Arthur Grillo
Insert parameterized test for the drm_fb_build_fourcc_list() to ensure correctness and prevent future regressions. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/tests/drm_format_helper_test.c | 148 + 1 file changed, 148 insertions(+) diff --git a/drivers/gpu/drm

[PATCH v2 3/6] drm/tests: Add KUnit tests for drm_fb_clip_offset()

2023-08-11 Thread Arthur Grillo
Insert parameterized test for the drm_fb_clip_offset() to ensure correctness and prevent future regressions. Signed-off-by: Arthur Grillo Reviewed-by: Maíra Canal --- drivers/gpu/drm/tests/drm_format_helper_test.c | 91 ++ 1 file changed, 91 insertions(+) diff --git a

[PATCH v2 2/6] drm/tests: Add KUnit tests for drm_fb_swab()

2023-08-11 Thread Arthur Grillo
Insert parameterized test for the drm_fb_swab() to ensure correctness and prevent future regressions. Each expected color has it bytes reversed in order, so xrgb would be bgrx. Signed-off-by: Arthur Grillo Reviewed-by: Maíra Canal --- drivers/gpu/drm/tests/drm_format_helper_test.c | 66

[PATCH v2 5/6] drm/tests: Add multi-plane support to conversion_buf_size()

2023-08-11 Thread Arthur Grillo
The drm_fb_memcpy() supports multi-plane formats. To fully test it in the future, add multi-plane support to the conversion_buf_size() helper. Signed-off-by: Arthur Grillo Reviewed-by: Maíra Canal --- drivers/gpu/drm/tests/drm_format_helper_test.c | 28 +- 1 file

[PATCH v2 6/6] drm/tests: Add KUnit tests for drm_fb_memcpy()

2023-08-11 Thread Arthur Grillo
Insert parameterized test for the drm_fb_memcpy() to ensure correctness and prevent future regressions. The test case can accept different formats. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/tests/drm_format_helper_test.c | 391 + 1 file changed, 391 insertions

Re: [PATCH v2 6/6] drm/tests: Add KUnit tests for drm_fb_memcpy()

2023-08-14 Thread Arthur Grillo
On 13/08/23 10:30, Maira Canal wrote: > Hi Arthur, > > On 8/11/23 15:17, Arthur Grillo wrote: >> Insert parameterized test for the drm_fb_memcpy() to ensure correctness >> and prevent future regressions. The test case can accept different >> formats. >>

[PATCH v3 0/6] Increase code coverage on drm_format_helper.c

2023-08-14 Thread Arthur Grillo
://grillo-0.github.io/coverage-reports/gsoc-drm-format-test/drivers/gpu/drm/drm_format_helper.c.gcov.html Signed-off-by: Arthur Grillo --- v1->v2: https://lore.kernel.org/r/20230721182316.560649-1-arthurgri...@riseup.net - Change patch prefix to "drm/tests" (Maíra Canal) - Simplif

[PATCH v3 1/6] drm/tests: Test default pitch fallback

2023-08-14 Thread Arthur Grillo
Test the default pitch fallback when NULL is passed as the dst_pitch on the conversion procedures. Reviewed-by: Maíra Canal Signed-off-by: Arthur Grillo --- drivers/gpu/drm/tests/drm_format_helper_test.c | 126 - 1 file changed, 81 insertions(+), 45 deletions(-) diff

[PATCH v3 2/6] drm/tests: Add KUnit tests for drm_fb_swab()

2023-08-14 Thread Arthur Grillo
Insert parameterized test for the drm_fb_swab() to ensure correctness and prevent future regressions. Each expected color has it bytes reversed in order, so xrgb would be bgrx. Signed-off-by: Arthur Grillo Reviewed-by: Maíra Canal --- drivers/gpu/drm/tests/drm_format_helper_test.c | 66

[PATCH v3 3/6] drm/tests: Add KUnit tests for drm_fb_clip_offset()

2023-08-14 Thread Arthur Grillo
Insert parameterized test for the drm_fb_clip_offset() to ensure correctness and prevent future regressions. Signed-off-by: Arthur Grillo Reviewed-by: Maíra Canal --- drivers/gpu/drm/tests/drm_format_helper_test.c | 91 ++ 1 file changed, 91 insertions(+) diff --git a

[PATCH v3 4/6] drm/tests: Add KUnit tests for drm_fb_build_fourcc_list()

2023-08-14 Thread Arthur Grillo
Insert parameterized test for the drm_fb_build_fourcc_list() to ensure correctness and prevent future regressions. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/tests/drm_format_helper_test.c | 144 + 1 file changed, 144 insertions(+) diff --git a/drivers/gpu/drm

[PATCH v3 5/6] drm/tests: Add multi-plane support to conversion_buf_size()

2023-08-14 Thread Arthur Grillo
The drm_fb_memcpy() supports multi-plane formats. To fully test it in the future, add multi-plane support to the conversion_buf_size() helper. Signed-off-by: Arthur Grillo Reviewed-by: Maíra Canal --- drivers/gpu/drm/tests/drm_format_helper_test.c | 28 +- 1 file

[PATCH v3 6/6] drm/tests: Add KUnit tests for drm_fb_memcpy()

2023-08-14 Thread Arthur Grillo
Insert parameterized test for the drm_fb_memcpy() to ensure correctness and prevent future regressions. The test case can accept different formats. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/tests/drm_format_helper_test.c | 362 + 1 file changed, 362 insertions

[PATCH v5] drm/vkms: Add support to 1D gamma LUT

2023-07-08 Thread Arthur Grillo
lut_area` depends on the layout of `struct drm_color_lut` (Pekka) - Remove unused variable (kernel test robot) v5: - Mention that this will make it possible to run the test igt@kms_plane@pixel-format (Maíra) - s/had/has (Maíra) Signed-off-by: Arthur Grillo Acked-by: Pekka

[PATCH] drm/tests: Add KUnit tests for drm_fb_blit()

2023-09-01 Thread Arthur Grillo
Insert parameterized test for the drm_fb_blit() to ensure correctness and prevent future regressions. The test is done by adding a call to drm_fb_blit() on every format that has support. Also, to fully test the function, add new format conversion tests. Signed-off-by: Arthur Grillo --- drivers

[PATCH] drm/debugfs: Add inline to drm_debugfs_dev_init() to suppres -Wunused-function

2023-09-01 Thread Arthur Grillo
.feakbzej-...@intel.com/ Signed-off-by: Arthur Grillo --- include/drm/drm_drv.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h index 9850fe73b739..e2640dc64e08 100644 --- a/include/drm/drm_drv.h +++ b/include/drm/drm_drv.h @@ -584,7

[PATCH] drm/tests: Zero initialize fourccs_out

2023-09-01 Thread Arthur Grillo
tests for drm_fb_build_fourcc_list()") Signed-off-by: Arthur Grillo --- drivers/gpu/drm/tests/drm_format_helper_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tests/drm_format_helper_test.c b/drivers/gpu/drm/tests/drm_format_helper_test.c ind

[PATCH v2 0/2] Add KUnit tests for drm_fb_blit()

2023-09-05 Thread Arthur Grillo
drm_fb_blit(). The second patch adds those format conversion tests. Signed-off-by: Arthur Grillo --- Changes in v2: - Split the patch into two (Maíra Canal) - Link to v1: https://lore.kernel.org/r/20230901-final-gsoc-v1-1-e310c7685...@riseup.net --- Arthur Grillo (2): drm/tests: Add calls to

[PATCH v2 1/2] drm/tests: Add calls to drm_fb_blit() on supported format conversion tests

2023-09-05 Thread Arthur Grillo
Add a call to drm_fb_blit() on existing format conversion tests that has support. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/tests/drm_format_helper_test.c | 142 + 1 file changed, 142 insertions(+) diff --git a/drivers/gpu/drm/tests/drm_format_helper_test.c b

[PATCH v2 2/2] drm/tests: Add new format conversion tests to better cover drm_fb_blit()

2023-09-05 Thread Arthur Grillo
To fully cover drm_fb_blit(), add format conversion tests that are only supported through drm_fb_blit(). Signed-off-by: Arthur Grillo --- drivers/gpu/drm/tests/drm_format_helper_test.c | 142 + 1 file changed, 142 insertions(+) diff --git a/drivers/gpu/drm/tests

[PATCH 0/7] Additions to "Reimplement line-per-line pixel conversion for plane reading" series

2024-03-06 Thread Arthur Grillo
.petazz...@bootlin.com Cc: seanp...@google.com Cc: marc...@google.com Cc: nicolejade...@google.com Signed-off-by: Arthur Grillo --- Arthur Grillo (7): drm: Fix drm_fixp2int_round() making it add 0.5 drm/vkms: Add comments drm/vkmm: Use drm_fixed api drm/vkms: Fix compilat

[PATCH 1/7] drm: Fix drm_fixp2int_round() making it add 0.5

2024-03-06 Thread Arthur Grillo
/ Suggested-by: Pekka Paalanen Signed-off-by: Arthur Grillo --- include/drm/drm_fixed.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/drm_fixed.h b/include/drm/drm_fixed.h index 0c9f917a4d4b..de3a79909ac9 100644 --- a/include/drm/drm_fixed.h +++ b/include/drm/drm_fixed.h

[PATCH 2/7] drm/vkms: Add comments

2024-03-06 Thread Arthur Grillo
Signed-off-by: Arthur Grillo --- drivers/gpu/drm/vkms/vkms_formats.c | 47 + 1 file changed, 47 insertions(+) diff --git a/drivers/gpu/drm/vkms/vkms_formats.c b/drivers/gpu/drm/vkms/vkms_formats.c index 44d9b9b3bdc3..55ed3f598bd7 100644 --- a/drivers/gpu/drm

[PATCH 3/7] drm/vkmm: Use drm_fixed api

2024-03-06 Thread Arthur Grillo
With the new 32.32 values it makes more sense to use drm_fixed functions than trying to recreate the wheel. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/vkms/vkms_formats.c | 54 +++-- 1 file changed, 28 insertions(+), 26 deletions(-) diff --git a/drivers

  1   2   >