Re: [PATCH v5 18/36] drm/bridge: analogix_dp: Reset aux channel if an error occurred

2018-03-13 Thread Archit Taneja
EMOTEIO; A couple of ETIMEDOUTs have been replaced with EREMOTEIOs after this change. Maybe we set it the error no in ret and return ret? With those changes, Reviewed-by: Archit Taneja Thanks, Archit } ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v5 19/36] drm/rockchip: Restore psr->state when enable/disable psr failed

2018-03-13 Thread Archit Taneja
On Saturday 10 March 2018 03:53 AM, Enric Balletbo i Serra wrote: From: zain wang If we failed disable psr, it would hang the display until next psr cycle coming. So we should restore psr->state when it failed. For the bridge part, Reviewed-by: Archit Taneja Thanks, Archit Cc: Tom

Re: [PATCH v5 20/36] drm/bridge: analogix_dp: Don't use ANALOGIX_DP_PLL_CTL to control pll

2018-03-13 Thread Archit Taneja
On Saturday 10 March 2018 03:53 AM, Enric Balletbo i Serra wrote: From: zain wang There is no register named ANALOGIX_DP_PLL_CTL in Rockchip edp phy reg list. We should use BIT_4 in ANALOGIX_DP_PD to control the pll power instead of ANALOGIX_DP_PLL_CTL. Reviewed-by: Archit Taneja

Re: [PATCH v5 22/36] drm/bridge: analogix_dp: Fix incorrect operations with register ANALOGIX_DP_FUNC_EN_1

2018-03-13 Thread Archit Taneja
edp phy, BIT 7 reserved BIT 6 RK_VID_CAP_FUNC_EN_N BIT 5 RK_VID_FIFO_FUNC_EN_N So, we should do some private operations to Rockchip. Reviewed-by: Archit Taneja Thanks, Archit Cc: Tomasz Figa Signed-off-by: zain wang Signed-off-by: Sean Paul Signed-off-by

Re: [PATCH v5 26/36] drm/bridge: analogix_dp: Properly disable aux chan retries on rockchip

2018-03-13 Thread Archit Taneja
could adjust the comment, but it seems more likely that we want the same retry behavior across all platforms. Reviewed-by: Archit Taneja Thanks, Archit Cc: Stéphane Marchesin Cc: 征增 王 Signed-off-by: Douglas Anderson Signed-off-by: Sean Paul Signed-off-by: Thierry Escande Signed-off-by:

Re: [PATCH v5 25/36] drm/bridge: analogix_dp: Properly log AUX CH errors

2018-03-13 Thread Archit Taneja
bug. Reviewed-by: Archit Taneja Thanks, Archit Cc: 征增 王 Signed-off-by: Douglas Anderson Signed-off-by: Sean Paul Signed-off-by: Thierry Escande Reviewed-by: Andrzej Hajda Signed-off-by: Enric Balletbo i Serra Tested-by: Marek Szyprowski --- drivers/gpu/drm/bridge/analogix/analogi

Re: [PATCH v5 23/36] drm/bridge: analogix_dp: Move fast link training detect to set_bridge

2018-03-13 Thread Archit Taneja
nd we will do fast link training since we have set fast_link flag to 1. In fact, we should do full link training now, not the fast link training. So we should move the fast link detection at the end of set_bridge. Is it possible to re-write this commit message? It's a bit hard to follow. Than

Re: [PATCH v5 24/36] drm/bridge: analogix_dp: Reorder plat_data->power_off to happen sooner

2018-03-13 Thread Archit Taneja
was finding AUX channel errors and eventually reported "Failed to apply PSR", where I had a kgdb breakpoint. Presumably the device would have eventually given up and shut down anyway, but it seems better to fix the order to be more correct. Reviewed-by: Archit Taneja Thanks, Archit C

Re: [PATCH v5 21/36] drm/bridge: analogix_dp: Fix timeout of video streamclk config

2018-03-14 Thread Archit Taneja
streamclk is ok if we wait enough time, it does no effect on display. Let's change this error to warn. Reviewed-by: Archit Taneja Thanks, Archit Cc: Douglas Anderson Signed-off-by: zain wang Signed-off-by: Sean Paul Signed-off-by: Thierry Escande Reviewed-by: Andrzej Hajda Signe

Re: [PATCH 1/2] dt-bindings: analogix-dp: Add backlight-pwm-passthru

2018-03-16 Thread Archit Taneja
ler or the eDP panel. I don't have any strong opinion about it, though. Reviewed-by: Archit Taneja Thanks, Archit Signed-off-by: Alexandru M Stan --- Documentation/devicetree/bindings/display/bridge/analogix_dp.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documenta

Re: [DPU PATCH v3] drm/msm: Use atomic private_obj instead of subclassing

2018-03-20 Thread Archit Taneja
isn't referred when configuring SMP registers, we see underruns immediately. An easy way to reproduce this is to use modset on db410c. I think it might occur with this patch too. It might be worth trying it out. Thanks, Archit Cc: Jeykumar Sankaran Reviewed-by: Jeykumar Sankaran Si

Re: [PATCH v2 0/3] Cleanup excessive DSI host controller version checks

2018-03-23 Thread Archit Taneja
replaced with the corresponding helper function. Reviewed-by: Archit Taneja V2: Removes command broadcast support for DSI 6G v2.0+ controllers from the patch series and incorporates all the suggested corrections Sibi S (3): drm/msm/dsi: add dsi host helper functions support

Re: [PATCH] drm/msm/dsi: use correct enum in dsi_get_cmd_fmt

2018-03-24 Thread Archit Taneja
Signed-off-by: Stefan Agner Reviewed-by: Archit Taneja Archit --- drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c index 0f7324a686ca..d729b2b4b66d 1006

Re: [PATCH v2 1/6] drm/msm: Use drm_private_obj/state instead of subclassing

2018-04-01 Thread Archit Taneja
in disp duplicate_state callback (Jeykumar) Changes in v3: - Update comment describing msm_kms_state (Jeykumar) Changes in v4: - Rebased on msm-next - Don't always use private state from atomic state (Archit) - Renamed some of the state accessors - Tested on mdp5 db410c Changes in v5:

Re: [PATCH v2 2/6] drm/msm: Refactor complete_commit() to look more the helpers

2018-04-01 Thread Archit Taneja
On Thursday 29 March 2018 12:36 AM, Sean Paul wrote: Factor out the commit_tail() portions of complete_commit() into a separate function to facilitate moving to the atomic helpers in future patches. Reviewed-by: Archit Taneja Changes in v2: - None Cc: Jeykumar Sankaran Signed-off-by

Re: [PATCH v2 3/6] drm/msm: Mark the crtc->state->event consumed

2018-04-01 Thread Archit Taneja
On Thursday 29 March 2018 12:36 AM, Sean Paul wrote: Don't leave the event != NULL once it's consumed, this is used a signal s/used a/used as a ? to the atomic helpers that the event will be handled by the driver. Reviewed-by: Archit Taneja Changes in v2: - None Cc: Jeykuma

Re: [PATCH v2 4/6] drm/msm: Issue queued events when disabling crtc

2018-04-01 Thread Archit Taneja
On Thursday 29 March 2018 12:36 AM, Sean Paul wrote: Ensure that any queued events are issued when disabling the crtc. This avoids timeouts when we come back and wait for dependencies (like the previous frame's flip_done). Reviewed-by: Archit Taneja Changes in v2: - None Signed-o

Re: [PATCH v6 3/5] drm/vc4: Set up the DSI host at pdev probe time, not component bind.

2017-08-16 Thread Archit Taneja
dge lookup/attach into the component bind process. Reviewed-by: Archit Taneja Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/vc4_dsi.c | 97 +-- 1 file changed, 57 insertions(+), 40 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/g

Re: [PATCH 00/14] clean up drm_bridge_add

2017-08-21 Thread Archit Taneja
On 08/08/2017 08:51 AM, Archit Taneja wrote: Hi, On 08/08/2017 04:25 AM, Inki Dae wrote: Daniel, please ping~ 2017년 07월 03일 17:42에 Inki Dae 이(가) 쓴 글: This patch series changes return type of drm_bridge_add function to void one and also removes unnecessary checking of the return type from

Re: [PATCH v3 2/3] drm/bridge/synopsys: dsi: Register list clean up

2017-09-04 Thread Archit Taneja
On 09/01/2017 06:59 PM, Andrzej Hajda wrote: On 01.08.2017 15:23, Philippe CORNU wrote: This patch cleans up the Synopsys mipi dsi register list: - rename registers according to the Synopsys documentation (1.30 & 1.31) - fix typos - re-order registers for a better coherency Signed-off-by:

Re: [PATCH v3 3/3] drm/bridge/synopsys: dsi: explicitly request exclusive reset control

2017-09-04 Thread Archit Taneja
On 09/01/2017 07:15 PM, Andrzej Hajda wrote: On 01.08.2017 15:23, Philippe CORNU wrote: Based on patch "Convert drivers to explicit reset API" from Philipp Zabel Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting reset lines") started to transition the reset control requ

Re: [PATCH] [RESEND] drm/stm: fix warning about multiplication in condition

2017-09-06 Thread Archit Taneja
Hi Benjamin, This should be pushed to drm-misc by you, right? Thanks, Archit On 09/06/2017 06:43 PM, Arnd Bergmann wrote: gcc-7 complains about multiplying within a condition being suspicious: drivers/gpu/drm/stm/dw_mipi_dsi-stm.c: In function 'dsi_pll_get_clkout_khz': drivers/g

Re: [PATCH 1/4] drm/bridge: adv7511: Properly update EDID when no EDID was found

2017-09-06 Thread Archit Taneja
these on my HiKey board ontop of Linus's HEAD, and everything seemed ok. So for the whole patchset: Tested-by: John Stultz The set looks good to me too. I'll queue it to drm-misc-next in a few days. Thanks, Archit thanks -john -- Qualcomm Innovation Center, Inc. is a member of C

Re: [PATCH v3 1/2] drm/bridge: Add Cadence DSI driver

2017-09-07 Thread Archit Taneja
dev->channel); + if (!np) + np = of_node_get(dev->dev.of_node); > + + panel = of_drm_find_panel(np); + if (panel) { + bridge = drm_panel_bridge_add(panel, DRM_MODE_CONNECTOR_DSI); + } else { + bridge = of_drm_find_

Re: [PATCH v5 03/12] drm/bridge/synopsys: dw-hdmi: Enable workaround for v1.32a

2018-02-15 Thread Archit Taneja
On Thursday 15 February 2018 01:38 AM, Jernej Skrabec wrote: Allwinner SoCs have dw hdmi controller v1.32a which exhibits same magenta line issue as i.MX6Q and i.MX6DL. Enable workaround for it. Tests show that one iteration is enough. Acked-by: Laurent Pinchart Reviewed-by: Archit Taneja

Re: [PATCH v5 04/12] drm/bridge/synopsys: dw-hdmi: Export some PHY related functions

2018-02-15 Thread Archit Taneja
reused. Functions exported here are actually not specific to Synopsys PHYs but to DWC HDMI controller PHY interface. This means that even if the PHY is completely custom, i.e. not designed by Synopsys, exported functions can be useful. Reviewed-by: Archit Taneja Reviewed-by: Neil Armstrong

Re: [PATCH v5 05/12] drm/bridge/synopsys: dw-hdmi: don't clobber drvdata

2018-02-15 Thread Archit Taneja
structure when needed. Idea was taken from the following commit: 8242ecbd597d ("drm/bridge/synopsys: stop clobbering drvdata") Reviewed-by: Archit Taneja Cc: p.za...@pengutronix.de Cc: narmstr...@baylibre.com Cc: laurent.pinch...@ideasonboard.com Cc: h...@rock-chips.com Cc: he..

Re: [PATCH] drm/pl111: Remove reverse dependency on DRM_DUMB_VGA_DAC

2018-02-20 Thread Archit Taneja
ndencies". +Linus. I guess this needs to go in drm-misc-fixes once it is updated to 4.16-rc2. Thanks, Archit Fixes: 49f81d80ab84 ("drm/pl111: Support handling bridge timings") Reported-by: Randy Dunlap Cc: Laurent Pinchart Cc: Archit Taneja Cc: Eric Anholt Signed-off-

Re: [PATCH] drm/pl111: Remove reverse dependency on DRM_DUMB_VGA_DAC

2018-02-26 Thread Archit Taneja
On Tuesday 20 February 2018 04:44 PM, Archit Taneja wrote: On Tuesday 20 February 2018 03:59 PM, Thierry Reding wrote: From: Thierry Reding DRM_DUMB_VGA_DAC is a user-visible symbol. Selecting it can cause unmet direct dependencies such as this (on i386, randconfig): warning

Re: [RFC][PATCH 04/11] drm: Split the display info into static and dynamic parts

2018-02-27 Thread Archit Taneja
_format, 1); drm_mode_connector_attach_encoder(&tc->connector, tc->bridge.encoder); The sii902x driver sets the bus_formats in get_modes, but it's a fixed value and we may as well do it in bridge's attach op. For the bridge drivers: Reviewed-by: Archit Taneja Tha

Re: [PATCH v2 2/2] drm/bridge/synopsys: dsi: handle endianness correctly in dw_mipi_dsi_write()

2018-01-15 Thread Archit Taneja
te and use appropriate helper, lets say: u32 le_to_cpup(const u8 *p, int count) {     __le32 r = 0;     memcpy(&r, p, count);     return le32_to_cpu(r); } With or without this change: Reviewed-by: Andrzej Hajda Queued to drm-misc-next as is. Thanks, Archit  -- Regards Andrzej

Re: [PATCH v2 1/2] drm/bridge/synopsys: dsi: use common mipi_dsi_create_packet()

2018-01-15 Thread Archit Taneja
the return value of mipi_dsi_device_transfer is addressed in a different patch. Thanks, Archit Signed-off-by: Brian Norris Reviewed-by: Philippe Cornu Tested-by: Philippe Cornu --- v2: * remove "dcs" naming, since these commands handle generic DSI too, not just DCS (thanks Philip

[PATCH] rnndb: dsi: Add DSI 10nm PLL/PHY registers

2018-01-16 Thread Archit Taneja
Signed-off-by: Archit Taneja --- rnndb/dsi/dsi.xml | 95 +++ 1 file changed, 95 insertions(+) diff --git a/rnndb/dsi/dsi.xml b/rnndb/dsi/dsi.xml index c7052378..fdcc2d3e 100644 --- a/rnndb/dsi/dsi.xml +++ b/rnndb/dsi/dsi.xml @@ -814,4 +814,99

[PATCH 1/4] drm/msm/dsi: Update generated headers for 10nm PLL/PHY

2018-01-16 Thread Archit Taneja
Signed-off-by: Archit Taneja --- drivers/gpu/drm/msm/dsi/dsi.xml.h | 187 +++--- 1 file changed, 174 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi.xml.h b/drivers/gpu/drm/msm/dsi/dsi.xml.h index 479086ccf180..f6a9471b70c8 100644 --- a

[PATCH 4/4] drm/msm/dsi: Populate the 10nm PHY funcs

2018-01-16 Thread Archit Taneja
which use a new representation between physical and logical lane mappings. For now, we've hardcoced them to follow the default mapping (i.e logical 0 -> phy 0, logical 1 -> phy 1 etc). Signed-off-by: Archit Taneja --- drivers/gpu/drm/msm/dsi/phy/dsi_phy_1

[PATCH 2/4] drm/msm/dsi: Add skeleton 10nm PHY/PLL code

2018-01-16 Thread Archit Taneja
Add new 10nm DSI PLL/PHY files that will be used on SDM845. Just populate empty pll/phy funcs for now. These will be filled up later. Signed-off-by: Archit Taneja --- drivers/gpu/drm/msm/Kconfig| 7 ++ drivers/gpu/drm/msm/Makefile | 2 + drivers/gpu/drm/msm

[PATCH 0/4] drm/msm/dsi: Add DSI 10nm PLL/PHY drivers

2018-01-16 Thread Archit Taneja
/drivers/clk/qcom/mdss/mdss-dsi-pll-10nm.c?h=msm-4.9 [2] https://source.codeaurora.org/quic/la/kernel/msm-4.9/tree/drivers/gpu/drm/msm/dsi-staging/dsi_phy_hw_v3_0.c?h=msm-4.9 Archit Taneja (4): drm/msm/dsi: Update generated headers for 10nm PLL/PHY drm/msm/dsi: Add skeleton 10nm PHY/PLL code

[PATCH 3/4] drm/msm/dsi: Populate PLL 10nm clock ops

2018-01-16 Thread Archit Taneja
x27;t need special postdivider clock ops like we did with the 14nm PLL driver. Like the previous PLL drivers, the implementation is slightly different from downstream. We don't use shadow clocks, but have the ability to reparent the RCGs to a different source. Signed-off-by: Archit Taneja --- driv

[PATCH 5/7] dt-bindings: display: msm/dsi: Fix the PHY regulator supply props

2018-01-17 Thread Archit Taneja
The PHY regulator supply names vary across different PHY versions. Mention explicitly which PHYs require which supplies. Cc: Rob Herring Cc: devicet...@vger.kernel.org Signed-off-by: Archit Taneja --- Documentation/devicetree/bindings/display/msm/dsi.txt | 4 1 file changed, 4 insertions

[PATCH 1/7] drm/msm/dsi: Use msm_clk_get in dsi_get_config

2018-01-17 Thread Archit Taneja
We try to get the interface clock in dsi_get_config early during DSI's component bind. Try getting both the "iface" and "iface_clk" clock name variants so that we are compatible with both new and legacy DT. Signed-off-by: Archit Taneja --- drivers/gpu/drm/msm/dsi/dsi_

[PATCH 0/7] drm/msm/dsi: SDM845 DSI host controller and DT updates

2018-01-17 Thread Archit Taneja
This series adds some of the host controller changes needed for SDM845.\ The DT patches in the series do some minor clean ups and add missing bindings for 14nm DSI PHY (8x96) and new bindings for 10nm PHY. Archit Taneja (7): drm/msm/dsi: Use msm_clk_get in dsi_get_config drm/msm/dsi: Add

[PATCH 2/7] drm/msm/dsi: Add SDM845 in dsi_cfg

2018-01-17 Thread Archit Taneja
SDM845 contains 2 DSI6G v2.2.1 host controllers. Add them in dsi_cfg. Cc: Jordan Crouse Signed-off-by: Archit Taneja --- drivers/gpu/drm/msm/dsi/dsi_cfg.c | 19 +++ drivers/gpu/drm/msm/dsi/dsi_cfg.h | 1 + 2 files changed, 20 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi

[PATCH 6/7] dt-bindings: display: msm/dsi: Add compatible for 14nm DSI PHY

2018-01-17 Thread Archit Taneja
er.kernel.org Signed-off-by: Archit Taneja --- Documentation/devicetree/bindings/display/msm/dsi.txt | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/display/msm/dsi.txt b/Documentation/devicetree/bindings/display/msm/dsi.tx

[PATCH 4/7] dt-bindings: display: msm/dsi: Remove unused properties

2018-01-17 Thread Archit Taneja
"qcom,dsi-host-index" and "qcom,dsi-phy-index" DT props aren't acceptable and have never been used in any DT files. Remove them. Cc: Rob Herring Cc: devicet...@vger.kernel.org Signed-off-by: Archit Taneja --- Documentation/devicetree/bindings/display/msm/dsi.txt |

[PATCH 3/7] drm/msm/dsi: Add byte_intf_clk

2018-01-17 Thread Archit Taneja
t its rate only after we configure byte_clk. This is required for the ancestor clocks in the CC to be configured correctly. Signed-off-by: Archit Taneja --- drivers/gpu/drm/msm/dsi/dsi_host.c | 32 1 file changed, 32 insertions(+) diff --git a/drivers/gpu/drm/ms

[PATCH 7/7] dt-bindings: display: msm/dsi: Add updates for SDM845

2018-01-17 Thread Archit Taneja
address/regulator supply needs. Cc: Rob Herring Cc: devicet...@vger.kernel.org Signed-off-by: Archit Taneja --- Documentation/devicetree/bindings/display/msm/dsi.txt | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/msm/dsi.txt b

[RFC v2 0/2] dt-bindings: mipi-dsi: dual-channel DSI bindings

2018-01-18 Thread Archit Taneja
eady started using, but didn't have properly documented anywhere. The second patch proposes bindings for DSI hosts/peripherals that implement dual-channel DSI. Changes in v2: - Incorported Rob's comments. Archit Taneja (2): dt-bindings: mipi-dsi: Add info about peripherals with no

[RFC v2 2/2] dt-bindings: mipi-dsi: Add dual-channel DSI related info

2018-01-18 Thread Archit Taneja
Add binding info for peripherals that support dual-channel DSI. Add corresponding optional bindings for DSI host controllers that may be configured in this mode. Add an example of an I2C controlled device operating in dual-channel DSI mode. Signed-off-by: Archit Taneja --- v2: - Specify that

[RFC v2 1/2] dt-bindings: mipi-dsi: Add info about peripherals with non-DSI control bus

2018-01-18 Thread Archit Taneja
Add a section that describes dt-bindings for peripherals that support MIPI DSI, but have a different bus as the primary control bus, or no control bus at all. Add an example for a peripheral with a non-DSI control bus. Signed-off-by: Archit Taneja --- v2: - Mentioned what to do if peripheral has

Re: [PATCH 08/12] drm: msm: Use drm_atomic_helper_shutdown() to disable planes on removal

2018-01-18 Thread Archit Taneja
On 01/18/2018 03:25 AM, Laurent Pinchart wrote: The plane cleanup handler currently calls drm_plane_helper_disable(), which is a legacy helper function. Replace it with a call to drm_atomic_helper_shutdown() at removal time. Reviewed-by: Archit Taneja Signed-off-by: Laurent Pinchart

Re: [PATCH] drm/bridge/synopsys: dsi: use adjusted_mode in mode_set

2018-01-28 Thread Archit Taneja
use it in dw dsi :) Could you get the patch [1] queued on drm-misc-next? I can queue this patch after it. Thanks, Archit Philippe :-) [1] https://patchwork.freedesktop.org/patch/200720/ "[PATCH] drm/stm: ltdc: use crtc_mode_fixup to update adjusted_mode clock" Tested-by: Brian Nor

Re: [PATCH 2/2] drm: adv7511: Add support for i2c_new_secondary_device

2018-01-28 Thread Archit Taneja
he 2nd chip" Maybe the default macros can be a function of the main address? + adv->i2c_cec = i2c_new_secondary_device(adv->i2c_main, "cec", + ADV7511_REG_CEC_I2C_ADDR_DEFAULT); Also, I'm a bit unclear on the default address values. For example, previously,

Re: [PATCH v2 2/2] drm/bridge/synopsys: dsi: Fix dsi_host_transfer() return value

2018-01-30 Thread Archit Taneja
of bytes is returned for the moment. Signed-off-by: Philippe Cornu Assuming we're going with the current documented semantics (where we return # of TX bytes for writes), then: Reviewed-by: Brian Norris I believe Archit was suggesting maybe changing that sometime, but that's no excu

Re: [PATCH v2 1/2] drm/bridge/synopsys: dsi: Add a warning msg on dsi read requests

2018-01-30 Thread Archit Taneja
Awesome, thanks. Reviewed-by: Brian Norris Queued to drm-misc-next. Thanks, Archit --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c index

Re: [PATCH 6/7] dt-bindings: display: msm/dsi: Add compatible for 14nm DSI PHY

2018-01-30 Thread Archit Taneja
On 01/29/2018 10:45 PM, Rob Herring wrote: On Wed, Jan 17, 2018 at 03:04:47PM +0530, Archit Taneja wrote: Add the compatible string for 14nm DSI PHY (used in MSM8996/APQ8096). From 14nm PHY onwards, the "dsi_phy_regulator" reg-name is not required, but "dsi_phy_lane" reg

Re: [PATCH 6/7] dt-bindings: display: msm/dsi: Add compatible for 14nm DSI PHY

2018-01-31 Thread Archit Taneja
On 01/31/2018 09:50 PM, Rob Clark wrote: On Wed, Jan 31, 2018 at 1:40 AM, Archit Taneja wrote: On 01/29/2018 10:45 PM, Rob Herring wrote: On Wed, Jan 17, 2018 at 03:04:47PM +0530, Archit Taneja wrote: Add the compatible string for 14nm DSI PHY (used in MSM8996/APQ8096). From 14nm PHY

Re: [PATCH 6/8] drm: Allow DSI devices to be registered before the host registers.

2017-07-16 Thread Archit Taneja
On 07/15/2017 04:28 AM, Eric Anholt wrote: Archit Taneja writes: On 06/28/2017 01:28 AM, Eric Anholt wrote: When a mipi_dsi_host is registered, the DT is walked to find any child nodes with compatible strings. Those get registered as DSI devices, and most DSI panel drivers are

Re: [PATCH v5 4/7] drm/bridge/synopsys: Add MIPI DSI host controller bridge

2017-07-17 Thread Archit Taneja
On 07/17/2017 01:24 PM, Philippe CORNU wrote: On 07/12/2017 08:05 AM, Archit Taneja wrote: On 07/03/2017 02:11 PM, Philippe CORNU wrote: Add a Synopsys Designware MIPI DSI host DRM bridge driver, based on the Rockchip version from rockchip/dw-mipi-dsi.c with phy & bridge APIs.

[PATCH] drm/msm/dsi: Calculate link clock rates with updated dsi->lanes

2017-07-17 Thread Archit Taneja
ne expects. Fixes: b62aa70a98c5 ("drm/msm/dsi: Move PHY operations out of host") Signed-off-by: Archit Taneja --- drivers/gpu/drm/msm/dsi/dsi_host.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/

Re: [PATCH 6/8] drm: Allow DSI devices to be registered before the host registers.

2017-07-17 Thread Archit Taneja
On 07/15/2017 04:31 AM, Eric Anholt wrote: Archit Taneja writes: On 06/29/2017 04:09 PM, Andrzej Hajda wrote: On 29.06.2017 07:03, Archit Taneja wrote: On 06/28/2017 01:28 AM, Eric Anholt wrote: When a mipi_dsi_host is registered, the DT is walked to find any child nodes with compatible

Re: [PATCH v6 0/7] STM32 DSI HOST

2017-07-18 Thread Archit Taneja
Hi, On 07/17/2017 01:10 PM, Philippe CORNU wrote: Version 6: - bridge/synopsys/dw-mipi-dsi.c: drm_bridge_add update (Archit Taneja) queued patches #1 to #4 to drm-misc-next. Please let me know when you apply the remainder of the ST patches. Once that's done, we can add CONFIG_DRM_STM_

Re: [PATCH 6/8] drm: Allow DSI devices to be registered before the host registers.

2017-07-18 Thread Archit Taneja
On 07/19/2017 01:43 AM, Eric Anholt wrote: Archit Taneja writes: On 07/15/2017 04:28 AM, Eric Anholt wrote: Archit Taneja writes: On 06/28/2017 01:28 AM, Eric Anholt wrote: When a mipi_dsi_host is registered, the DT is walked to find any child nodes with compatible strings. Those get

Re: [PATCH 14/16] drm/msm: Convert to use new iterator macros, v2.

2017-07-19 Thread Archit Taneja
ive instead of crtc_state->enable when waiting for completion. Tested-by: Archit Taneja Signed-off-by: Maarten Lankhorst Cc: Rob Clark Cc: Archit Taneja Cc: Vincent Abriou Cc: Maarten Lankhorst Cc: Russell King Cc: Rob Herring Cc: Markus Elfring Cc: Sushmita Susheelendra Cc: lin

Re: [PATCH 7/8] drm: Nuke drm_atomic_helper_connector_dpms

2017-07-25 Thread Archit Taneja
02x.c | 1 - drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 - drivers/gpu/drm/bridge/tc358767.c | 1 - drivers/gpu/drm/bridge/ti-tfp410.c | 1 - For bridge changes: Acked-by: Archit Taneja Archit -- Qualcomm Innovation Center, Inc. is a memb

Re: [PATCH 3/8] drm: Handle properties in the core for atomic drivers

2017-07-25 Thread Archit Taneja
v3: Make it actually work ... Reviewed-by: Archit Taneja Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_atomic.c| 60 ++-- drivers/gpu/drm/drm_connector.c | 6 +- drivers/gpu/drm/drm_crtc_helper.c | 3 +- drivers/gpu/drm/drm_crtc_intern

Re: [PATCH 4/8] drm: Nuke drm_atomic_helper_crtc_set_property

2017-07-25 Thread Archit Taneja
On 07/25/2017 01:31 PM, Daniel Vetter wrote: It's dead code because this is now handled in the core. Reviewed-by: Archit Taneja Signed-off-by: Daniel Vetter Cc: Boris Brezillon Cc: Daniel Vetter Cc: Jani Nikula Cc: Sean Paul Cc: David Airlie Cc: Ben Skeggs Cc: Tomi Valkeine

Re: [PATCH 5/8] drm: Nuke drm_atomic_helper_plane_set_property

2017-07-25 Thread Archit Taneja
On 07/25/2017 01:31 PM, Daniel Vetter wrote: It's dead code, the core handles all this directly now. This also allows us to unexport drm_atomic_helper_plane_set_property. Reviewed-by: Archit Taneja Signed-off-by: Daniel Vetter Cc: Liviu Dudau Cc: Brian Starkey Cc: Mali DP Mainta

Re: [PATCH] drm/bridge: tc358767: fix probe without attached output node

2017-07-27 Thread Archit Taneja
ach mailto:l.st...@pengutronix.de>> Acked-by: Andrey Gusakov mailto:andrey.gusa...@cogentembedded.com>> Thanks, queued to drm-misc-fixes. Archit --- drivers/gpu/drm/bridge/tc358767.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/b

[PATCH 02/10] drm/msm/mdp5: Drop clock names with "_clk" suffix

2017-07-28 Thread Archit Taneja
th old and new clock names. Signed-off-by: Archit Taneja --- drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c index 5694344db762..efde2

[PATCH 05/10] drm/msm/dsi: Set up runtime PM for DSI

2017-07-28 Thread Archit Taneja
Call the pm_runtime_get/put API where we need the clocks enabled. The main entry/exit points are 1) enabling/disabling the DSI bridge and 2) Sending commands from the DSI host to the device. Signed-off-by: Archit Taneja --- drivers/gpu/drm/msm/dsi/dsi_host.c| 11 +++ drivers/gpu

[PATCH 01/10] drm/msm/mdp5: Fix typo in encoder_enable path

2017-07-28 Thread Archit Taneja
The mdp5_cmd_encoder_disable is accidentally called in the encoder enable path. We've not seen any problems since we haven't tested with command mode panels in a while. Fix the copy-paste error. Signed-off-by: Archit Taneja --- drivers/gpu/drm/msm/mdp/mdp5/mdp5_encoder.c | 2 +- 1 fi

[PATCH 03/10] drm/msm/mdp5: Use runtime PM get/put API instead of toggling clocks

2017-07-28 Thread Archit Taneja
ter lose state, resulting in a bad HW state. For now, we've replaced each mdp5_enable/disable with runtime_get/put API. We could optimize things later by removing runtime_get/put calls which don't really need to be there. This could prevent unnecessary toggling of the power domain and cl

[PATCH 00/10] drm/msm: Runtime PM for MDP5 based devices

2017-07-28 Thread Archit Taneja
runtime PM. The first 2 patches and the last patch are minor fixes not directly related to runtime PM. Tested on DB410c and DB820c. Archit Taneja (10): drm/msm/mdp5: Fix typo in encoder_enable path drm/msm/mdp5: Drop clock names with "_clk" suffix drm/msm/mdp5: Use runtime PM g

[PATCH 04/10] drm/msm/hdmi: Set up runtime PM for HDMI

2017-07-28 Thread Archit Taneja
the power domain in the HDMI bridge's enable/disable paths, and the HDMI connector's detect() op. Signed-off-by: Archit Taneja --- drivers/gpu/drm/msm/hdmi/hdmi.c | 2 + drivers/gpu/drm/msm/hdmi/hdmi_bridge.c| 4 ++ drivers/gpu/drm/msm/hdmi/h

[PATCH 06/10] drm/msm/dsi: Implement RPM suspend/resume callbacks

2017-07-28 Thread Archit Taneja
The bus clocks are always enabled/disabled along with the power domain, so move it to the runtime suspend/resume ops. This cleans up the clock code a bit. Get rid of the clk_mutex mutex since it isn't needed. Signed-off-by: Archit Taneja --- drivers/gpu/drm/msm/dsi/dsi.c | 5 +++ dr

[PATCH 08/10] drm/msm/mdp5: Write to SMP registers even if allocations don't change

2017-07-28 Thread Archit Taneja
P registers, but the code doesn't program the registers because there isn't any change in mdp5_smp_state. Fix this by writing to the registers irrespective of whether there was a change in SMP state or not. We do this by keeping a cache of the register values, and write them ever

[PATCH 09/10] drm/msm/mdp5: Set up runtime PM for MDSS

2017-07-28 Thread Archit Taneja
vice created in msm_drv.c represents MDP4 itself. It would have been nicer to hide these differences by adding new kms funcs, but runtime PM needs to be enabled before kms is set up (i.e, msm_kms_init is called). Signed-off-by: Archit Taneja --- drivers/gpu/drm/msm/

[PATCH 07/10] drm/msm/mdp5: Don't use mode_set helper funcs for encoders and CRTCs

2017-07-28 Thread Archit Taneja
igned-off-by: Archit Taneja --- drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c| 4 +++- drivers/gpu/drm/msm/mdp/mdp5/mdp5_encoder.c | 5 - 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c

[PATCH 10/10] drm/msm/adreno: Prevent unclocked access when retrieving timestamps

2017-07-28 Thread Archit Taneja
msm_gpu's get_timestamp() op (called by the MSM_GET_PARAM ioctl) can result in register accesses. We need our power domain and clocks to be active for that. Make sure they are enabled here. Signed-off-by: Archit Taneja --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 11 +-- 1 file ch

Re: [PATCH v6 1/7] drm/stm: ltdc: Fix leak of px clk enable in some error paths

2017-07-29 Thread Archit Taneja
n-off. It looks like the Ack and the Sign-off got accidentally mixed up Can you please reply to this mail with your "Signed-off-by" so that we have proof of it on dri-devel? Thanks, Archit Signed-off-by: Eric Anholt Acked-by: Philippe Cornu --- drivers/gpu/drm/stm/ltdc.c | 10

Re: [PATCH 0/6] drm/bridge: tc358767: fixes and improvements

2017-07-31 Thread Archit Taneja
On 07/27/2017 06:17 PM, Andrey Gusakov wrote: This set of patches fixes several issues that was found during testing tc358767 with desktop DisplayPort displays. These changes look good to me. Philipp, can I get your Ack on these? Thanks, Archit Andrey Gusakov (6): drm/bridge

Re: [PATCH 2/3] drm/msm/mdp5: mark runtime_pm functions as __maybe_unused

2017-08-04 Thread Archit Taneja
ns as __maybe_unused so the compiler can drop them silently. Thanks for the fix. Since the commit is still in Rob's -next branch, I'll post a new version which fixes this. Archit Fixes: d68fe15b1878 ("drm/msm/mdp5: Use runtime PM get/put API instead of toggling cl

Re: [PATCH v2 1/4] drm/bridge: dw-hdmi: add cec notifier support

2017-08-04 Thread Archit Taneja
. Thanks, Archit Regards, Hans --- drivers/gpu/drm/bridge/synopsys/Kconfig | 1 + drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 22 +- 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/synopsys/Kconfig b/drivers/gpu/drm/bridge

Re: [PATCH v2 2/4] drm/bridge: dw-hdmi: add better clock disable control

2017-08-04 Thread Archit Taneja
setting/clearing the bits that the video path needs to. Reviewed-by: Jose Abreu Signed-off-by: Russell King Acked-by: Hans Verkuil Queued to drm-misc-next. Thanks, Archit Regards, Hans --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 29 ++--- 1 file

Re: [PATCH][resend] drm: dw-hdmi-i2s: add missing company name on Copyright

2017-08-06 Thread Archit Taneja
On 08/07/2017 07:41 AM, Kuninori Morimoto wrote: From: Kuninori Morimoto This driver's Copyright is under Renesas Solutions Corp Can we update the year to 2017 while we're at it? Archit Signed-off-by: Kuninori Morimoto --- drivers/gpu/drm/bridge/synopsys/dw-hdmi-i2s-a

Re: [PATCH][resend] drm: dw-hdmi-i2s: add missing company name on Copyright

2017-08-06 Thread Archit Taneja
On 08/07/2017 09:25 AM, Kuninori Morimoto wrote: Hi Archit Thank you for your feedback On 08/07/2017 07:41 AM, Kuninori Morimoto wrote: From: Kuninori Morimoto This driver's Copyright is under Renesas Solutions Corp Can we update the year to 2017 while we're at it? Th

Re: [PATCH v2 1/4] drm/bridge: dw-hdmi: add cec notifier support

2017-08-06 Thread Archit Taneja
On 08/05/2017 02:53 PM, Hans Verkuil wrote: Archit, I posted a v3 that added a missing cec_notifier_put to the remove() function. Apparently you missed that. The chunk in question from the v3 patch is this: I did. Sorry, about that. There was an issue with my mailer. @@ -2469,6 +2489,9

Re: [PATCH v2] drm: dw-hdmi-i2s: add missing company name on Copyright

2017-08-06 Thread Archit Taneja
On 08/07/2017 09:39 AM, Kuninori Morimoto wrote: From: Kuninori Morimoto This driver's Copyright is under Renesas Solutions Corp. This patch updates the year, because this driver was moved into synopsys folder in 2017. Thanks. Queued to drm-misc-next. Archit Signed-off-by: Kun

Re: [PATCH] dw-hdmi: add missing cec_notifier_put

2017-08-07 Thread Archit Taneja
On 08/07/2017 12:50 PM, Hans Verkuil wrote: The __dw_hdmi_remove() function was missing a call to cec_notifier_put to balance the cec_notifier_get in the probe function. Queued to drm-misc-next. Thanks, Archit Signed-off-by: Hans Verkuil --- This fix was in the v3 patch but

Re: [PATCHv3 3/4] drm/bridge: dw-hdmi: add cec driver

2017-08-07 Thread Archit Taneja
On 08/03/2017 12:11 AM, Hans Verkuil wrote: From: Russell King Add a CEC driver for the dw-hdmi hardware. Queued to drm-misc-next after fixing up some minor Makefile/Kconfig conflicts. Thanks, Archit Reviewed-by: Neil Armstrong Signed-off-by: Russell King [hans.verkuil: unsigned

Re: [PATCHv3 4/4] drm/bridge: dw-hdmi: remove CEC engine register definitions

2017-08-07 Thread Archit Taneja
On 08/03/2017 12:11 AM, Hans Verkuil wrote: From: Russell King We don't need the CEC engine register definitions, so let's remove them. Queued to drm-misc-next. Thanks, Archit Signed-off-by: Russell King Acked-by: Hans Verkuil Tested-by: Hans Verkuil Tested-by: Lauren

Re: [PATCH 00/14] clean up drm_bridge_add

2017-08-07 Thread Archit Taneja
et anyone's ack. Archit Inki Dae (14): drm/bridge: change return type of drm_bridge_add function drm/bridge: adv7511: clean up drm_bridge_add call drm/bridge: analogix-anx78xx: clean up drm_bridge_add call drm/bridge: vga-dac: clean up drm_bridge_add call drm/bridge: n

Re: [PATCH v2] drm: bridge: synopsys/dw-hdmi: Provide default configuration function for HDMI 2.0 PHY

2017-08-08 Thread Archit Taneja
Hi, On 08/08/2017 12:35 PM, Mark yao wrote: On 2017年07月07日 23:47, Jose Abreu wrote: Hi Archit, Ping, Any update for this patch? Can it be landed? This patch actually needed for rk3399 hdmi support Sorry, missed this one. There was a comment from Laurent mentioning whether we'd wa

Re: [PATCH 0/3] drm: make drm_connector_funcs structures const

2017-08-09 Thread Archit Taneja
xt: https://cgit.freedesktop.org/drm/drm-misc/log/ Thanks, Archit Bhumika Goyal (3): drm/bridge: make drm_connector_funcs structures const drm/sun4i: make drm_connector_funcs structures const drm/rockchip: make drm_connector_funcs structures const drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 2 +-

Re: [PATCH] drm/bridge: make drm_bridge_funcs const

2017-08-09 Thread Archit Taneja
-off-by: Bhumika Goyal Reviewed-by: Laurent Pinchart queued to drm-misc-next Thanks, Archit --- drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 2 +- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm

Re: [PATCH] drm: bridge: dw-hdmi: constify snd_pcm_ops structures

2017-08-09 Thread Archit Taneja
structs as const. Signed-off-by: Arvind Yadav Reviewed-by: Laurent Pinchart queued to drm-misc-next Thanks, Archit --- drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb

Re: [PATCH 0/4] drm/bridge/adv7511: add CEC support

2017-08-09 Thread Archit Taneja
patch: https://patchwork.kernel.org/patch/9824773/ Archit, can you confirm that this patch will go to kernel 4.14? Yes, it's been queued to clk-next. Thanks, Archit And the Koelsch board needs this 4.13 fix: https://patchwork.kernel.org/patch/9836865/ I only have the Koelsch board to

Re: [PATCH 4/4] drm: adv7511/33: add HDMI CEC support

2017-08-10 Thread Archit Taneja
adv7533_uninit_cec(struct adv7511 *adv) +int adv7533_patch_cec_registers(struct adv7511 *adv) { - i2c_unregister_device(adv->i2c_cec); -} - -int adv7533_init_cec(struct adv7511 *adv) -{ - int ret; - - adv->i2c_cec = i2c_new_dummy(adv->i2c_main->adapter, -

Re: [PATCH 0/4] drm/bridge/adv7511: add CEC support

2017-08-10 Thread Archit Taneja
needs this patch: https://patchwork.kernel.org/patch/9824773/ Archit, can you confirm that this patch will go to kernel 4.14? And the Koelsch board needs this 4.13 fix: https://patchwork.kernel.org/patch/9836865/ I only have the Koelsch board to test with, but it looks like other R-Car boards use

Re: [PATCH 0/4] drm/bridge/adv7511: add CEC support

2017-08-10 Thread Archit Taneja
On 08/10/2017 02:26 PM, Hans Verkuil wrote: On 10/08/17 10:49, Archit Taneja wrote: Hi Hans, On 07/30/2017 06:37 PM, Hans Verkuil wrote: From: Hans Verkuil This patch series adds CEC support to the drm adv7511/adv7533 drivers. I have tested this with the Qualcomm Dragonboard C410

<    4   5   6   7   8   9   10   11   12   13   >