Re: [PATCH v1 2/4] acpi/x86: s2idle: handle screen off/on calls outside of suspend sequence

2024-09-20 Thread Antheas Kapenekakis
Hi, as noted in the cover letter, I think the connection to DRM is a red herring. The Display off callback in Windows is always called 5 seconds after the screen turns off due to inactivity or instantly if the user presses the power button. Likewise, Display on is called when the display is about

[RFC 04/13] acpi/x86: s2idle: add support for Turn On Display callback

2024-11-21 Thread Antheas Kapenekakis
to restore PLx while still remaining in the sleep state. Signed-off-by: Antheas Kapenekakis --- include/linux/suspend.h | 1 + kernel/power/suspend.c | 7 +++ 2 files changed, 8 insertions(+) diff --git a/include/linux/suspend.h b/include/linux/suspend.h index 733dffb09b28..01ee64321cda

[RFC 00/13] acpi/x86: s2idle: implement Modern Standby transition states and expose to userspace

2024-11-21 Thread Antheas Kapenekakis
: Documentation/admin-guide/pm/standby-states.rst [8] Changes from previous series (`acpi/x86: s2idle: move Display off/on calls outside suspend (fixes ROG Ally suspend)`): - Separate Display On/Off rename into its own commit (suggested by Hans) - Move delay quirks into s2idle.c (suggested by Ha

[RFC 08/13] acpi/x86: s2idle: rename MS Exit/Entry to Sleep Exit/Entry

2024-11-21 Thread Antheas Kapenekakis
Rename as part of converting it into a transition. Signed-off-by: Antheas Kapenekakis --- drivers/acpi/x86/s2idle.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/acpi/x86/s2idle.c b/drivers/acpi/x86/s2idle.c index 8b39e3b12ec0..49dcbdea903a 100644

Re: [RFC 01/13] Documentation: PM: Add documentation for S0ix Standby States

2024-11-21 Thread Antheas Kapenekakis
On Thu, 21 Nov 2024 at 22:08, Mario Limonciello wrote: > > On 11/21/2024 14:33, Antheas Kapenekakis wrote: > > On Thu, 21 Nov 2024 at 20:40, Mario Limonciello > > wrote: > >> > >> On 11/21/2024 13:11, Antheas Kapenekakis wrote: > >>> On Thu, 21 N

[RFC 02/13] acpi/x86: s2idle: add support for Display Off and Display On callbacks

2024-11-21 Thread Antheas Kapenekakis
outside of the suspend/resume path. Co-developed-by: Mario Limonciello Signed-off-by: Mario Limonciello Signed-off-by: Antheas Kapenekakis --- include/linux/suspend.h | 2 ++ kernel/power/suspend.c | 10 ++ 2 files changed, 12 insertions(+) diff --git a/include/linux/suspend.h b/inc

Re: [RFC 05/13] acpi/x86: s2idle: add modern standby transition function

2024-11-21 Thread Antheas Kapenekakis
On Thu, 21 Nov 2024 at 19:16, Mario Limonciello wrote: > > On 11/21/2024 11:22, Antheas Kapenekakis wrote: > > Add a new function to transition modern standby states and call it > > as part of the suspend sequence to make sure it begins under the > > Modern Standby &quo

Re: [RFC 01/13] Documentation: PM: Add documentation for S0ix Standby States

2024-11-21 Thread Antheas Kapenekakis
On Thu, 21 Nov 2024 at 20:40, Mario Limonciello wrote: > > On 11/21/2024 13:11, Antheas Kapenekakis wrote: > > On Thu, 21 Nov 2024 at 19:58, Mario Limonciello > > wrote: > >> > >> On 11/21/2024 11:22, Antheas Kapenekakis wrote: > >>> Add document

[RFC 03/13] acpi/x86: s2idle: add support for Sleep Entry and Sleep Exit callbacks

2024-11-21 Thread Antheas Kapenekakis
state without suspending the device. Suggested-by: Mario Limonciello Signed-off-by: Antheas Kapenekakis --- include/linux/suspend.h | 2 ++ kernel/power/suspend.c | 10 ++ 2 files changed, 12 insertions(+) diff --git a/include/linux/suspend.h b/include/linux/suspend.h index

[RFC 10/13] acpi/x86: s2idle: add Turn On Display and call as part of callback

2024-11-21 Thread Antheas Kapenekakis
corresponds to Modern Standby Firmware notification (_DSM) 9. Signed-off-by: Antheas Kapenekakis --- drivers/acpi/x86/s2idle.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/drivers/acpi/x86/s2idle.c b/drivers/acpi/x86/s2idle.c index bdc2cc8d4994..d389c57d2963 100644

Re: [RFC 01/13] Documentation: PM: Add documentation for S0ix Standby States

2024-11-21 Thread Antheas Kapenekakis
On Thu, 21 Nov 2024 at 19:58, Mario Limonciello wrote: > > On 11/21/2024 11:22, Antheas Kapenekakis wrote: > > Add documentation about the S0ix Standby States that will be exposed > > to userspace as part of this series. > > > > Signed-off-by: Antheas Kapenekakis &g

[RFC 07/13] acpi/x86: s2idle: call Display On/Off as part of callbacks

2024-11-21 Thread Antheas Kapenekakis
Move the Display On/Off notifications into dedicated callbacks that gate the ACPI mutex, so they can be called outside of the suspend path. Co-developed-by: Mario Limonciello Signed-off-by: Mario Limonciello Signed-off-by: Antheas Kapenekakis --- drivers/acpi/x86/s2idle.c | 67

[RFC 06/13] acpi/x86: s2idle: rename Screen On/Off to Display On/Off

2024-11-21 Thread Antheas Kapenekakis
repare for that, rename the variables to "Display On/Off". Signed-off-by: Antheas Kapenekakis --- drivers/acpi/x86/s2idle.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/acpi/x86/s2idle.c b/drivers/acpi/x86/s2idle.c ind

[RFC 09/13] acpi/x86: s2idle: call Sleep Entry/Exit as part of callbacks

2024-11-21 Thread Antheas Kapenekakis
Move the Sleep Entry/Exit notifications outside the suspend sequence, with their own ACPI lock, as was done for Display On/Off. Suggested-by: Mario Limonciello Signed-off-by: Antheas Kapenekakis --- drivers/acpi/x86/s2idle.c | 57 --- 1 file changed, 47

Re: [RFC 11/13] acpi/x86: s2idle: add quirk table for modern standby delays

2024-11-21 Thread Antheas Kapenekakis
On Thu, 21 Nov 2024 at 19:04, Mario Limonciello wrote: > > On 11/21/2024 11:22, Antheas Kapenekakis wrote: > > Unfortunately, some modern standby systems, including the ROG Ally, rely > > on a delay between modern standby transitions. Add a quirk table for > > introduci

[RFC 12/13] platform/x86: asus-wmi: remove Ally (1st gen) and Ally X suspend quirk

2024-11-21 Thread Antheas Kapenekakis
adding a large amount of delay to the suspend and wake process. Reviewed-by: Mario Limonciello Signed-off-by: Antheas Kapenekakis --- drivers/platform/x86/asus-wmi.c | 54 - 1 file changed, 54 deletions(-) diff --git a/drivers/platform/x86/asus-wmi.c b/drivers

[RFC 11/13] acpi/x86: s2idle: add quirk table for modern standby delays

2024-11-21 Thread Antheas Kapenekakis
lers prior to suspending. Signed-off-by: Antheas Kapenekakis --- drivers/acpi/x86/s2idle.c | 56 +++ 1 file changed, 56 insertions(+) diff --git a/drivers/acpi/x86/s2idle.c b/drivers/acpi/x86/s2idle.c index d389c57d2963..504e6575d7ad 100644 --- a/driver

[RFC 01/13] Documentation: PM: Add documentation for S0ix Standby States

2024-11-21 Thread Antheas Kapenekakis
Add documentation about the S0ix Standby States that will be exposed to userspace as part of this series. Signed-off-by: Antheas Kapenekakis --- .../admin-guide/pm/standby-states.rst | 133 ++ Documentation/admin-guide/pm/system-wide.rst | 1 + 2 files changed, 134

[RFC 13/13] PM: standby: Add sysfs attribute for modern standby transitions

2024-11-21 Thread Antheas Kapenekakis
the kernel suspend process and userspace will never see it. Signed-off-by: Antheas Kapenekakis --- Documentation/ABI/testing/sysfs-power | 34 kernel/power/main.c | 75 +++ 2 files changed, 109 insertions(+) diff --git a/Documentation/ABI/

[RFC 05/13] acpi/x86: s2idle: add modern standby transition function

2024-11-21 Thread Antheas Kapenekakis
Add a new function to transition modern standby states and call it as part of the suspend sequence to make sure it begins under the Modern Standby "Sleep" state. Signed-off-by: Antheas Kapenekakis --- include/linux/suspend.h | 11 kernel/power/power.h| 1 + kernel/power

Re: [RFC 00/13] acpi/x86: s2idle: implement Modern Standby transition states and expose to userspace

2024-11-22 Thread Antheas Kapenekakis
On Fri, 22 Nov 2024 at 20:26, Xaver Hugl wrote: > > Am Do., 21. Nov. 2024 um 18:22 Uhr schrieb Antheas Kapenekakis > : > > > > The following series moves the _DSM 3,4,7,8 firmware notifications outside > > the suspend sequence, and makes them part of a transition fun

Re: [RFC 00/13] acpi/x86: s2idle: implement Modern Standby transition states and expose to userspace

2024-12-06 Thread Antheas Kapenekakis
21 Nov 2024 at 18:41, Rafael J. Wysocki wrote: > > On Thu, Nov 21, 2024 at 6:28 PM Antheas Kapenekakis wrote: > > > > The following series moves the _DSM 3,4,7,8 firmware notifications outside > > the suspend sequence, and makes them part of a transition function, whe

Re: [PATCH 0/5] drm: panel-orientation-quirks: Add 2024 OneXPlayer line & ZOTAC Zone orientation quirks

2025-03-16 Thread Antheas Kapenekakis
On Sat, 22 Feb 2025 at 17:43, Antheas Kapenekakis wrote: > > A number of OneXPlayer handhelds have come out with portrait panels. > Specifically, those are the X1 AMD and Intel variants, X1 Mini, and F1 Pro. > For X1 specifically, they also have spurious battery reporting within their

Re: [PATCH 3/5] drm: panel-orientation-quirks: Add OneXPlayer F1Pro quirk

2025-03-17 Thread Antheas Kapenekakis
On Mon, 17 Mar 2025 at 10:15, Hans de Goede wrote: > > Hi, > > On 22-Feb-25 17:43, Antheas Kapenekakis wrote: > > The OneXPlayer F1Pro has a 144hz 1920x1080 portrait OLED panel. > > Add a quirk to correct the panel portrait orientation. In addition, > > it comes with

Re: [PATCH 5/5] drm: panel-orientation-quirks: Add Zotac Gaming Zone quirk

2025-03-17 Thread Antheas Kapenekakis
On Mon, 17 Mar 2025 at 10:20, Hans de Goede wrote: > > Hi, > > On 22-Feb-25 17:43, Antheas Kapenekakis wrote: > > The Zotac Gaming Zone handheld features a 1080p portrait OLED screen. > > Add the rotation to the panel orientation quirks. > > > >

Re: [PATCH 5/5] drm: panel-orientation-quirks: Add Zotac Gaming Zone quirk

2025-03-17 Thread Antheas Kapenekakis
On Mon, 17 Mar 2025 at 10:23, Antheas Kapenekakis wrote: > > On Mon, 17 Mar 2025 at 10:20, Hans de Goede wrote: > > > > Hi, > > > > On 22-Feb-25 17:43, Antheas Kapenekakis wrote: > > > The Zotac Gaming Zone handheld features a 1080p portrait OLED scre

[PATCH 0/5] drm: panel-orientation-quirks: Add 2024 OneXPlayer line & ZOTAC Zone orientation quirks

2025-02-22 Thread Antheas Kapenekakis
as well. Antheas Kapenekakis (5): drm: panel-orientation-quirks: Add OneXPlayer X1 AMD and Intel quirk drm: panel-orientation-quirks: Add OneXPlayer X1 Mini (AMD) quirk drm: panel-orientation-quirks: Add OneXPlayer F1Pro quirk HID: Add quirk to ignore the touchscreen battery on OneXPlayer

[PATCH 4/5] HID: Add quirk to ignore the touchscreen battery on OneXPlayer X1

2025-02-22 Thread Antheas Kapenekakis
The X1 devices come with a pen-capable touchscreen, in which the HID descriptor reports there is always a battery at 100% charge. Quirk it to not report the battery status. Signed-off-by: Antheas Kapenekakis --- drivers/hid/hid-ids.h | 1 + drivers/hid/hid-input.c | 2 ++ 2 files changed, 3

[PATCH 2/5] drm: panel-orientation-quirks: Add OneXPlayer X1 Mini (AMD) quirk

2025-02-22 Thread Antheas Kapenekakis
The OneXPlayer X1 mini features a 2k 8.8 display with a portrait orientation. Add a quirk to set the panel orientation to portrait mode. There is no Intel variant. Signed-off-by: Antheas Kapenekakis --- drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++ 1 file changed, 6 insertions

[PATCH 3/5] drm: panel-orientation-quirks: Add OneXPlayer F1Pro quirk

2025-02-22 Thread Antheas Kapenekakis
The OneXPlayer F1Pro has a 144hz 1920x1080 portrait OLED panel. Add a quirk to correct the panel portrait orientation. In addition, it comes with a red limited edition variant in the Chinese market, so add that as well. Signed-off-by: Antheas Kapenekakis --- drivers/gpu/drm

[PATCH 5/5] drm: panel-orientation-quirks: Add Zotac Gaming Zone quirk

2025-02-22 Thread Antheas Kapenekakis
The Zotac Gaming Zone handheld features a 1080p portrait OLED screen. Add the rotation to the panel orientation quirks. Signed-off-by: Antheas Kapenekakis --- drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm

[PATCH 1/5] drm: panel-orientation-quirks: Add OneXPlayer X1 AMD and Intel quirk

2025-02-22 Thread Antheas Kapenekakis
The OneXPlayer X1 series features a 2k 10.95 display with a portrait orientation. Add a quirk to set the panel orientation to portrait mode to both the Intel and AMD variants. Signed-off-by: Antheas Kapenekakis --- drivers/gpu/drm/drm_panel_orientation_quirks.c | 18 ++ 1 file