Re: [Freedreno] [PATCH 1/3] drm/msm/mdp5: Configure PP_SYNC_HEIGHT to double the vtotal

2021-04-07 Thread AngeloGioacchino Del Regno
ng in the MDP and the block really needs recovery, this "trick" won't save anyone and the recovery will anyway be triggered, as the PP-done will anyway timeout. Suggested-by: AngeloGioacchino Del Regno Signed-off-by: Marijn Suijten Reviewed-by: AngeloGioacchino Del Regno ---

Re: [Freedreno] [PATCH 1/3] drm/msm/mdp5: Configure PP_SYNC_HEIGHT to double the vtotal

2021-04-08 Thread AngeloGioacchino Del Regno
Il gio 8 apr 2021, 21:05 Rob Clark ha scritto: > On Wed, Apr 7, 2021 at 12:11 PM AngeloGioacchino Del Regno > wrote: > > > > Il 07/04/21 20:19, abhin...@codeaurora.org ha scritto: > > > Hi Marijn > > > > > > On 2021-04-06 14:47, Marijn Suijten wro

[PATCH v3 6/7] drm/msm/a5xx: Disable flat shading optimization

2021-01-14 Thread AngeloGioacchino Del Regno
From: Konrad Dybcio Port over the command from downstream to prevent undefined behaviour. Signed-off-by: Konrad Dybcio Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/msm/adreno

[PATCH v3 3/7] drm/msm/a5xx: Add support for Adreno 508, 509, 512 GPUs

2021-01-14 Thread AngeloGioacchino Del Regno
The Adreno 508/509/512 GPUs are stripped versions of the Adreno 5xx found in the mid-end SoCs such as SDM630, SDM636, SDM660 and SDA variants; these SoCs are usually provided with ZAP firmwares, but they have no available GPMU. Signed-off-by: AngeloGioacchino Del Regno Tested-by: Martin Botka

[PATCH v3 5/7] drm/msm/a5xx: Fix VPC protect value in gpu_write()

2021-01-14 Thread AngeloGioacchino Del Regno
(= 2^4) fixes the issue. Signed-off-by: Konrad Dybcio Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c

[PATCH v3 4/7] drm/msm/a5xx: Reset VBIF before PC only on A510 and A530

2021-01-14 Thread AngeloGioacchino Del Regno
bad slownesses after processing the first frame. Avoiding to execute the RBBM SW Reset before suspend will stop the lockup issue from happening on at least Adreno 508/509/512. Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Jordan Crouse --- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 8

[PATCH v3 7/7] drm/msm/a5xx: Disable UCHE global filter

2021-01-14 Thread AngeloGioacchino Del Regno
From: Konrad Dybcio Port over the command from downstream to prevent undefined behaviour. Signed-off-by: Konrad Dybcio Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/msm/adreno/a5xx.xml.h | 2 ++ drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 3 +++ 2 files changed, 5 insertions

[PATCH v3 0/7] Add support for Adreno 508/509/512

2021-01-14 Thread AngeloGioacchino Del Regno
ged emails to reflect new ones - Tested on F(x)Tec Pro1 and Xperia XZ Premium (MSM8998) Changes in v2: - Define REG_A5XX_UCHE_MODE_CNTL and fix open-coded REG_A5XX_VPC_DBG_ECO_CNTL in the all flat shading optimization disablement commit, as requested by Rob Clark. AngeloGioacchino Del Reg

[PATCH v3 2/7] drm/msm/a5xx: Separate A5XX_PC_DBG_ECO_CNTL write from main branch

2021-01-14 Thread AngeloGioacchino Del Regno
ned-off-by: AngeloGioacchino Del Regno Reviewed-by: Jordan Crouse --- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c index 81506d2539b0..8c96fc0fc1b7 100644 ---

[PATCH v3 1/7] drm/msm/a5xx: Remove overwriting A5XX_PC_DBG_ECO_CNTL register

2021-01-14 Thread AngeloGioacchino Del Regno
configuration (including the GPU-specific quirks) and that is effectively nullifying the efforts. Let's remove the redundant and wrong write to the PC_DBG_ECO_CNTL register in order to retain the wanted configuration for the target GPU. Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Jordan C

[PATCH 2/2] dt-bindings: display: Document BOE BF060Y8M-AJ0 panel compatible

2021-01-15 Thread AngeloGioacchino Del Regno
Document the boe,bf060y8m-aj0 panel. Signed-off-by: AngeloGioacchino Del Regno --- .../display/panel/boe,bf060y8m-aj0.yaml | 67 +++ 1 file changed, 67 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/boe,bf060y8m-aj0.yaml diff --git a

[PATCH 1/2] drm/panel: Add BOE BF060Y8M-AJ0 5.99" AMOLED panel driver

2021-01-15 Thread AngeloGioacchino Del Regno
This adds support for the BOE BF060Y8M-AJ0 5.99" AMOLED module that can be found in some F(x)Tec Pro1 and Elephone U1 devices. Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/panel/Kconfig | 11 + drivers/gpu/drm/panel/Makefile| 1 + .../gp

[PATCH] drm: drm_modes: Fix signed-integer-overflow UBSAN warning

2021-01-22 Thread AngeloGioacchino Del Regno
8/0x68 [2.039337] msm_fbdev_init+0x80/0xe0 [2.039735] msm_drm_bind+0x4d8/0x6d0 Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/drm_modes.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c index 33fb2f

Re: [PATCH 3/5] drm/msm/dsi_pll_10nm: Fix bad VCO rate calculation and prescaler

2021-02-02 Thread AngeloGioacchino Del Regno
Il 31/01/21 20:50, Rob Clark ha scritto: On Sat, Jan 9, 2021 at 5:51 AM AngeloGioacchino Del Regno wrote: The VCO rate was being miscalculated due to a big overlook during the process of porting this driver from downstream to upstream: here we are really recalculating the rate of the VCO by

Re: [PATCH 3/5] drm/msm/dsi_pll_10nm: Fix bad VCO rate calculation and prescaler

2021-02-03 Thread AngeloGioacchino Del Regno
Il 01/02/21 18:31, Rob Clark ha scritto: On Mon, Feb 1, 2021 at 9:18 AM Rob Clark wrote: On Mon, Feb 1, 2021 at 9:05 AM Rob Clark wrote: On Mon, Feb 1, 2021 at 7:47 AM Rob Clark wrote: On Mon, Feb 1, 2021 at 2:11 AM AngeloGioacchino Del Regno wrote: Il 31/01/21 20:50, Rob Clark ha

Re: [PATCH 3/5] drm/msm/dsi_pll_10nm: Fix bad VCO rate calculation and prescaler

2021-02-03 Thread AngeloGioacchino Del Regno
Il 02/02/21 19:45, Rob Clark ha scritto: On Tue, Feb 2, 2021 at 6:32 AM AngeloGioacchino Del Regno wrote: Il 01/02/21 18:31, Rob Clark ha scritto: On Mon, Feb 1, 2021 at 9:18 AM Rob Clark wrote: On Mon, Feb 1, 2021 at 9:05 AM Rob Clark wrote: On Mon, Feb 1, 2021 at 7:47 AM Rob Clark

Re: [RESEND v13 07/22] soc: mediatek: mmsys: specify 64BIT dependency for MTK_MMSYS

2022-03-08 Thread AngeloGioacchino Del Regno
Il 08/03/22 10:30, Nancy.Lin ha scritto: Because mtk-mutex change to use unsigned long mutex module type, it should depend 64BIT. This is a preparation for adding support for mt8195 vdosys1 mutex. Signed-off-by: Nancy.Lin --- drivers/soc/mediatek/Kconfig | 1 + 1 file changed, 1 insertion(+)

Re: [RESEND v13 22/22] arm64: dts: mt8195: add display node for vdosys1

2022-03-08 Thread AngeloGioacchino Del Regno
Il 08/03/22 10:30, Nancy.Lin ha scritto: Add display node for vdosys1. Signed-off-by: Nancy.Lin Reviewed-by: AngeloGioacchino Del Regno --- arch/arm64/boot/dts/mediatek/mt8195.dtsi | 223 +++ 1 file changed, 223 insertions(+)

Re: [RESEND v13 01/22] dt-bindings: mediatek: add vdosys1 RDMA definition for mt8195

2022-03-08 Thread AngeloGioacchino Del Regno
Il 08/03/22 10:29, Nancy.Lin ha scritto: Add vdosys1 RDMA definition. Signed-off-by: Nancy.Lin Reviewed-by: AngeloGioacchino Del Regno --- .../arm/mediatek/mediatek,mdp-rdma.yaml | 86 +++ 1 file changed, 86 insertions(+) create mode 100644 Documentation

Re: [PATCH v14 03/22] dt-bindings: mediatek: add ethdr definition for mt8195

2022-03-10 Thread AngeloGioacchino Del Regno
Il 10/03/22 04:54, Nancy.Lin ha scritto: Add vdosys1 ETHDR definition. Signed-off-by: Nancy.Lin Reviewed-by: Chun-Kuang Hu Reviewed-by: AngeloGioacchino Del Regno --- .../display/mediatek/mediatek,ethdr.yaml | 158 ++ 1 file changed, 158 insertions(+) create

Re: [PATCH v14 08/22] soc: mediatek: change the mutex defines and the mutex_mod type

2022-03-10 Thread AngeloGioacchino Del Regno
Reviewed-by: AngeloGioacchino Del Regno --- drivers/soc/mediatek/mtk-mutex.c | 264 +++ 1 file changed, 132 insertions(+), 132 deletions(-)

Re: [PATCH v14 10/22] drm/mediatek: add display MDP RDMA support for MT8195

2022-03-10 Thread AngeloGioacchino Del Regno
Il 10/03/22 04:55, Nancy.Lin ha scritto: Add MDP_RDMA driver for MT8195. MDP_RDMA is the DMA engine of the ovl_adaptor component. Signed-off-by: Nancy.Lin Reviewed-by: Chun-Kuang Hu Reviewed-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/Makefile | 3 +- drivers

Re: [PATCH v14 11/22] drm/mediatek: add display merge advance config API for MT8195

2022-03-10 Thread AngeloGioacchino Del Regno
-by: Nancy.Lin Reviewed-by: Chun-Kuang Hu Reviewed-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/mtk_disp_drv.h | 3 ++ drivers/gpu/drm/mediatek/mtk_disp_merge.c | 52 --- 2 files changed, 48 insertions(+), 7 deletions(-)

Re: [PATCH v14 12/22] drm/mediatek: add display merge start/stop API for cmdq support

2022-03-10 Thread AngeloGioacchino Del Regno
-Kuang Hu Reviewed-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/mtk_disp_drv.h | 2 ++ drivers/gpu/drm/mediatek/mtk_disp_merge.c | 20 +--- 2 files changed, 19 insertions(+), 3 deletions(-)

Re: [PATCH v14 13/22] drm/mediatek: add display merge mute/unmute support for MT8195

2022-03-10 Thread AngeloGioacchino Del Regno
Il 10/03/22 04:55, Nancy.Lin ha scritto: Add merge mute/unmute setting for MT8195. MT8195 Vdosys1 merge1~merge4 support HW mute function. Signed-off-by: Nancy.Lin Reviewed-by: Chun-Kuang Hu Reviewed-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/mtk_disp_merge.c | 13

Re: [PATCH v14 14/22] drm/mediatek: add display merge async reset control

2022-03-10 Thread AngeloGioacchino Del Regno
ed-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/mtk_disp_merge.c | 4 1 file changed, 4 insertions(+)

Re: [PATCH v14 15/22] drm/mediatek: add ETHDR support for MT8195

2022-03-10 Thread AngeloGioacchino Del Regno
, output the required HDR or SDR signal to the subsequent display path. Signed-off-by: Nancy.Lin Reviewed-by: Chun-Kuang Hu Reviewed-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/Makefile | 1 + drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 + drivers/gpu/drm/mediatek

Re: [PATCH v14 16/22] drm/mediatek: add mediatek-drm plane color encoding info

2022-03-10 Thread AngeloGioacchino Del Regno
Il 10/03/22 04:55, Nancy.Lin ha scritto: Add plane color encoding information for color space conversion. It's a preparation for adding support for mt8195 ovl_adaptor mdp_rdma csc control. Signed-off-by: Nancy.Lin Reviewed-by: Chun-Kuang Hu Reviewed-by: AngeloGioacchino Del

Re: [PATCH v14 17/22] drm/mediatek: add ovl_adaptor support for MT8195

2022-03-10 Thread AngeloGioacchino Del Regno
-by: Nancy.Lin Reviewed-by: Chun-Kuang Hu Reviewed-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/Makefile | 1 + drivers/gpu/drm/mediatek/mtk_disp_drv.h | 17 + .../gpu/drm/mediatek/mtk_disp_ovl_adaptor.c | 443 ++ drivers/gpu/drm

Re: [PATCH v14 22/22] arm64: dts: mt8195: add display node for vdosys1

2022-03-10 Thread AngeloGioacchino Del Regno
<&gce0 SUBSYS_1c11 0xA000 0x1000>, + <&gce0 SUBSYS_1c11 0xB000 0x1000>, + <&gce0 SUBSYS_1c11 0xC000 0x1000>; ...and here too: 0xa000 0xb000 0xc000 Pleas

Re: [PATCH 1/3] drm/msm/gpu: Rename runtime suspend/resume functions

2022-03-11 Thread AngeloGioacchino Del Regno
Il 11/03/22 00:46, Rob Clark ha scritto: From: Rob Clark Hey Rob, looks like you've somehow lost the commit description on this one! Cheers, Angelo Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/adreno_device.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

Re: [PATCH v15 01/22] dt-bindings: mediatek: add vdosys1 RDMA definition for mt8195

2022-03-11 Thread AngeloGioacchino Del Regno
Il 11/03/22 02:54, Nancy.Lin ha scritto: Add vdosys1 RDMA definition. Signed-off-by: Nancy.Lin Reviewed-by: AngeloGioacchino Del Regno --- .../arm/mediatek/mediatek,mdp-rdma.yaml | 86 +++ 1 file changed, 86 insertions(+) create mode 100644 Documentation

Re: [PATCH v15 00/22] Add MediaTek SoC DRM (vdosys1) support for mt8195

2022-03-11 Thread AngeloGioacchino Del Regno
Il 11/03/22 02:54, Nancy.Lin ha scritto: The hardware path of vdosys1 with DPTx output need to go through by several modules, such as, OVL_ADAPTOR and MERGE. Add DRM and these modules support by the patches below: Hello maintainers, I have tested this series (and its dependencies - where [1

Re: [PATCH V7 5/5] drm/mediatek: add display support for MT8186

2022-03-14 Thread AngeloGioacchino Del Regno
Il 14/03/22 10:00, Rex-BC Chen ha scritto: From: Yongqiang Niu Add mmsys driver data and compatible for MT8186 in mtk_drm_drv.c. Signed-off-by: Yongqiang Niu Signed-off-by: Rex-BC Chen Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek

Re: [PATCH V7 4/5] dt-bindings: display: mediatek: add MT8186 SoC binding

2022-03-14 Thread AngeloGioacchino Del Regno
Il 14/03/22 10:00, Rex-BC Chen ha scritto: Add MT8186 SoC binding to AAL, CCORR, COLOR, DITHER, GAMMA, MUTEX, OVL, POSTMASK and RDMA. Signed-off-by: Rex-BC Chen Reviewed-by: Rob Herring Reviewed-by: AngeloGioacchino Del Regno --- .../devicetree/bindings/display/mediatek/mediatek

Re: [PATCH V7 2/5] dt-bindings: display: mediatek: revise enum to const

2022-03-14 Thread AngeloGioacchino Del Regno
Il 14/03/22 10:00, Rex-BC Chen ha scritto: There won't be more than 1 fallback for these bindings, so we modify them to use const instead of enum. Signed-off-by: Rex-BC Chen Reviewed-by: Rob Herring Reviewed-by: AngeloGioacchino Del Regno --- .../devicetree/bindings/display/med

Re: [PATCH V7 3/5] dt-bindings: display: mediatek: change to use enum for mutex

2022-03-14 Thread AngeloGioacchino Del Regno
Il 14/03/22 10:00, Rex-BC Chen ha scritto: All single entry cases in mutex can be merged as a single enum. Signed-off-by: Rex-BC Chen Reviewed-by: Rob Herring Reviewed-by: AngeloGioacchino Del Regno --- .../display/mediatek/mediatek,mutex.yaml | 24 +++ 1 file

Re: [PATCH V7 1/5] dt-bindings: display: mediatek: add aal binding for MT8183

2022-03-14 Thread AngeloGioacchino Del Regno
Il 14/03/22 10:00, Rex-BC Chen ha scritto: Add aal binding for MT8183. Signed-off-by: Rex-BC Chen Acked-by: Rob Herring Reviewed-by: AngeloGioacchino Del Regno --- .../devicetree/bindings/display/mediatek/mediatek,aal.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a

Re: [PATCH 1/2] drm: mediatek: mtk_drm_plane: Use kmalloc in mtk_plane_duplicate_state

2022-03-16 Thread AngeloGioacchino Del Regno
Il 25/01/22 17:36, Chun-Kuang Hu ha scritto: Hi, AngeloGioacchino: AngeloGioacchino Del Regno 於 2022年1月18日 週二 下午9:38寫道: There is no need to zero out the newly allocated memory because we are duplicating all members of struct mtk_plane_state: switch to kmalloc to save some overhead

Re: [PATCH,v2] drm/panel: Fix return value check in nt35950_probe()

2022-03-17 Thread AngeloGioacchino Del Regno
. Fixes: 623a3531e9cf ("drm/panel: Add driver for Novatek NT35950 DSI DriverIC panels") Signed-off-by: Lu Wei Reviewed-by: AngeloGioacchino Del Regno Thanks! --- drivers/gpu/drm/panel/panel-novatek-nt35950.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/d

Re: [PATCH 2/2 RESEND] drm/bridge: Add extra checks in pre_enable and post_enable

2022-03-18 Thread AngeloGioacchino Del Regno
chromebooks with different MediaTek SoC models, and on Qualcomm SC7180 Trogdor, Tested-by: AngeloGioacchino Del Regno

Re: [PATCH 1/2 RESEND] drm/bridge: parade-ps8640: avoid race condition on driver unbinding

2022-03-18 Thread AngeloGioacchino Del Regno
might happen somewhere else. Tested on an Acer Chromebook R13 (Elm, MT8173) with Debian Sid. Signed-off-by: Ricardo Cañuelo Reviewed-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/bridge/parade-ps8640.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

Re: [PATCH v9 04/22] drm/edid: Convert cea_sad helper struct to kernelDoc

2022-03-28 Thread AngeloGioacchino Del Regno
Il 28/03/22 00:39, Guillaume Ranquet ha scritto: Signed-off-by: Guillaume Ranquet --- include/drm/drm_edid.h | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h index 144c495b99c4..5d4d840b9904 100644 --- a/include/dr

Re: [PATCH v9 06/22] video/hdmi: Add audio_infoframe packing for DP

2022-03-28 Thread AngeloGioacchino Del Regno
Il 28/03/22 00:39, Guillaume Ranquet ha scritto: From: Markus Schneider-Pargmann Similar to HDMI, DP uses audio infoframes as well which are structured very similar to the HDMI ones. This patch adds a helper function to pack the HDMI audio infoframe for DP, called hdmi_audio_infoframe_pack_for

Re: [PATCH v9 17/22] phy: phy-mtk-dp: Add driver for DP phy

2022-03-28 Thread AngeloGioacchino Del Regno
Il 28/03/22 00:39, Guillaume Ranquet ha scritto: From: Markus Schneider-Pargmann This is a new driver that supports the integrated DisplayPort phy for mediatek SoCs, especially the mt8195. The phy is integrated into the DisplayPort controller and will be created by the mtk-dp driver. This drive

Re: [PATCH v9 12/22] drm/mediatek: dpi: move swap_shift to SoC config

2022-03-28 Thread AngeloGioacchino Del Regno
Il 28/03/22 00:39, Guillaume Ranquet ha scritto: Add flexibility by moving the swap shift value to SoC specific config Signed-off-by: Guillaume Ranquet Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v9 18/22] drm/mediatek: Add mt8195 Embedded DisplayPort driver

2022-03-28 Thread AngeloGioacchino Del Regno
Il 28/03/22 00:39, Guillaume Ranquet ha scritto: From: Markus Schneider-Pargmann This patch adds a DisplayPort driver for the Mediatek mt8195 SoC. It supports the mt8195, the embedded DisplayPort units. It offers DisplayPort 1.4 with up to 4 lanes. The driver shares its iomap range with the m

[PATCH] phy: mediatek: phy-mtk-hdmi: Simplify with dev_err_probe()

2022-03-28 Thread AngeloGioacchino Del Regno
Use the dev_err_probe() helper to simplify error handling during probe. Signed-off-by: AngeloGioacchino Del Regno --- drivers/phy/mediatek/phy-mtk-hdmi.c | 50 +++-- 1 file changed, 19 insertions(+), 31 deletions(-) diff --git a/drivers/phy/mediatek/phy-mtk-hdmi.c b

[PATCH] phy: mediatek: phy-mtk-mipi-dsi: Simplify with dev_err_probe()

2022-03-28 Thread AngeloGioacchino Del Regno
Use the dev_err_probe() helper to simplify error handling during probe. Signed-off-by: AngeloGioacchino Del Regno --- drivers/phy/mediatek/phy-mtk-mipi-dsi.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/phy/mediatek/phy-mtk-mipi-dsi.c b/drivers/phy

[PATCH v2] phy: mediatek: phy-mtk-mipi-dsi: Simplify with dev_err_probe()

2022-03-28 Thread AngeloGioacchino Del Regno
Use the dev_err_probe() helper to simplify error handling during probe. Signed-off-by: AngeloGioacchino Del Regno --- v2: Sorry, v1 was only partial as I have accidentally sent the wrong patch file. Fixed for v2. drivers/phy/mediatek/phy-mtk-mipi-dsi.c | 29 + 1

Re: [PATCH v8 04/19] video/hdmi: Add audio_infoframe packing for DP

2022-02-21 Thread AngeloGioacchino Del Regno
Il 18/02/22 15:54, Guillaume Ranquet ha scritto: From: Markus Schneider-Pargmann Similar to HDMI, DP uses audio infoframes as well which are structured very similar to the HDMI ones. This patch adds a helper function to pack the HDMI audio infoframe for DP, called hdmi_audio_infoframe_pack_for

Re: [PATCH v8 03/19] drm/edid: Add cea_sad helpers for freq/length

2022-02-21 Thread AngeloGioacchino Del Regno
Il 18/02/22 15:54, Guillaume Ranquet ha scritto: From: Markus Schneider-Pargmann This patch adds two helper functions that extract the frequency and word length from a struct cea_sad. For these helper functions new defines are added that help translate the 'freq' and 'byte2' fields into real n

Re: [PATCH v8 06/19] drm/mediatek: dpi: implement a CK/DE pol toggle in board config

2022-02-21 Thread AngeloGioacchino Del Regno
Il 18/02/22 15:54, Guillaume Ranquet ha scritto: Adds a bit of flexibility to support boards without CK/DE pol support Signed-off-by: Guillaume Ranquet s/board/SoC/g After the change, Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v8 05/19] drm/mediatek: dpi: move dpi limits to board config

2022-02-21 Thread AngeloGioacchino Del Regno
Il 18/02/22 15:54, Guillaume Ranquet ha scritto: Add flexibility by moving the dpi limits to the board config s/board/SoC/g After the change, Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Guillaume Ranquet

Re: [PATCH v8 13/19] drm/mediatek: dpi: Add dpintf support

2022-02-21 Thread AngeloGioacchino Del Regno
Il 18/02/22 15:54, Guillaume Ranquet ha scritto: dpintf is the displayport interface hardware unit. This unit is similar to dpi and can reuse most of the code. This patch adds support for mt8195-dpintf to this dpi driver. Main differences are: - Some features/functional components are not avai

Re: [PATCH v8 08/19] drm/mediatek: dpi: move dimension mask to board config

2022-02-21 Thread AngeloGioacchino Del Regno
is_ck_de_pol; bool swap_input_support; + // Mask used for HWIDTH, HPORCH, VSYNC_WIDTH and VSYNC_PORCH (no shift) Also, C-style comments, please. After the change, Reviewed-by: AngeloGioacchino Del Regno + u32 dimension_mask; const struct mtk_dpi_yc_limit *limit; };

Re: [PATCH v8 09/19] drm/mediatek: dpi: move dimension_mask to board config

2022-02-21 Thread AngeloGioacchino Del Regno
Il 18/02/22 15:54, Guillaume Ranquet ha scritto: Add flexibility by moving the dimension mask to board config You should really fix both title and description for this commit, as this is moving hvsize_mask, not dimension_mask. Also, s/board/SoC/g. Signed-off-by: Guillaume Ranquet --- driv

Re: [PATCH v8 10/19] drm/mediatek: dpi: move swap_shift to board config

2022-02-21 Thread AngeloGioacchino Del Regno
Il 18/02/22 15:54, Guillaume Ranquet ha scritto: Add flexibility by moving the swap shift value to board config Same board->SoC as all the other commits.. Signed-off-by: Guillaume Ranquet --- drivers/gpu/drm/mediatek/mtk_dpi.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-)

Re: [PATCH v8 11/19] drm/mediatek: dpi: move the yuv422_en_bit to board config

2022-02-21 Thread AngeloGioacchino Del Regno
Il 18/02/22 15:54, Guillaume Ranquet ha scritto: Add flexibility by moving the yuv422 en bit to board config s/board/SoC/g After the change, Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Guillaume Ranquet

Re: [PATCH v8 12/19] drm/mediatek: dpi: move the csc_enable bit to board config

2022-02-21 Thread AngeloGioacchino Del Regno
Il 18/02/22 15:54, Guillaume Ranquet ha scritto: Add flexibility by moving the csc_enable bit to board config s/board/SoC/g After the change, Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Guillaume Ranquet ---

Re: [PATCH v8 14/19] phy: phy-mtk-dp: Add driver for DP phy

2022-02-21 Thread AngeloGioacchino Del Regno
Il 18/02/22 15:54, Guillaume Ranquet ha scritto: From: Markus Schneider-Pargmann This is a new driver that supports the integrated DisplayPort phy for mediatek SoCs, especially the mt8195. The phy is integrated into the DisplayPort controller and will be created by the mtk-dp driver. This drive

Re: [PATCH v8 15/19] drm/mediatek: Add mt8195 Embedded DisplayPort driver

2022-02-21 Thread AngeloGioacchino Del Regno
Il 18/02/22 15:54, Guillaume Ranquet ha scritto: From: Markus Schneider-Pargmann This patch adds a DisplayPort driver for the Mediatek mt8195 SoC. It supports the mt8195, the embedded DisplayPort units. It offers hot-plug-detection and DisplayPort 1.4 with up to 4 lanes. The driver creates a

Re: [PATCH v8 04/19] video/hdmi: Add audio_infoframe packing for DP

2022-02-22 Thread AngeloGioacchino Del Regno
Il 18/02/22 15:54, Guillaume Ranquet ha scritto: From: Markus Schneider-Pargmann Similar to HDMI, DP uses audio infoframes as well which are structured very similar to the HDMI ones. This patch adds a helper function to pack the HDMI audio infoframe for DP, called hdmi_audio_infoframe_pack_for

Re: [PATCH v8 15/19] drm/mediatek: Add mt8195 Embedded DisplayPort driver

2022-02-24 Thread AngeloGioacchino Del Regno
Il 18/02/22 15:54, Guillaume Ranquet ha scritto: From: Markus Schneider-Pargmann This patch adds a DisplayPort driver for the Mediatek mt8195 SoC. It supports the mt8195, the embedded DisplayPort units. It offers hot-plug-detection and DisplayPort 1.4 with up to 4 lanes. The driver creates a

Re: [PATCH v7, 01/15] media: mtk-vcodec: Add vdec enable/disable hardware helpers

2022-02-25 Thread AngeloGioacchino Del Regno
Il 23/02/22 04:39, Yunfei Dong ha scritto: Lock, power and clock are highly coupled operations. Adds vdec enable/disable hardware helpers and uses them. Signed-off-by: Yunfei Dong Reviewed-by: Tzung-Bi Shih Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v7, 04/15] media: mtk-vcodec: Read max resolution from dec_capability

2022-02-25 Thread AngeloGioacchino Del Regno
Il 23/02/22 04:39, Yunfei Dong ha scritto: Supported max resolution for different platforms are not the same: 2K or 4K, getting it according to dec_capability. Signed-off-by: Yunfei Dong Reviewed-by: Tzung-Bi Shih Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v7, 07/15] media: mtk-vcodec: Refactor supported vdec formats and framesizes

2022-02-25 Thread AngeloGioacchino Del Regno
Il 23/02/22 04:40, Yunfei Dong ha scritto: Supported output and capture format types for mt8192 are different with mt8183. Needs to get format types according to decoder capability. Signed-off-by: Yunfei Dong Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v7, 08/15] media: mtk-vcodec: Add format to support MT21C

2022-02-25 Thread AngeloGioacchino Del Regno
Il 23/02/22 04:40, Yunfei Dong ha scritto: Needs to use mediatek compressed mode for mt8192 decoder. Signed-off-by: Yunfei Dong Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v7, 11/15] media: mtk-vcodec: record capture queue format type

2022-02-25 Thread AngeloGioacchino Del Regno
r stateless decoding, save the current capture queue type on a per vcodec context basis. After fixing, Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v8 14/19] phy: phy-mtk-dp: Add driver for DP phy

2022-02-25 Thread AngeloGioacchino Del Regno
Il 25/02/22 12:49, Guillaume Ranquet ha scritto: Quoting AngeloGioacchino Del Regno (2022-02-21 15:31:51) Il 18/02/22 15:54, Guillaume Ranquet ha scritto: From: Markus Schneider-Pargmann This is a new driver that supports the integrated DisplayPort phy for mediatek SoCs, especially the

Re: [PATCH v1,2/3] drm/mediatek: Add TOPCKGEN select mux control dpi_clk

2022-03-02 Thread AngeloGioacchino Del Regno
Il 25/02/22 10:53, xinlei@mediatek.com ha scritto: From: Xinlei Lee Dpi_clk is controlled by the mux selected by TOPCKGEN and APMIXEDSYS can support small resolution. Signed-off-by: Xinlei Lee Hello Xinlei, as it was pointed out by reviewers in the MT8195 DisplayPort series, that is ad

Re: [PATCH v12 19/23] drm/mediatek: add dma dev get function

2022-03-02 Thread AngeloGioacchino Del Regno
Il 22/02/22 11:07, Nancy.Lin ha scritto: This is a preparation for adding support for the ovl_adaptor sub driver Ovl_adaptor is a DRM sub driver, which doesn't have dma dev. Add dma_dev_get function for getting representative dma dev in ovl_adaptor. Signed-off-by: Nancy.Lin Reviewed-by: Angel

Re: [PATCH v12 23/23] arm64: dts: mt8195: add display node for vdosys1

2022-03-02 Thread AngeloGioacchino Del Regno
Il 22/02/22 11:07, Nancy.Lin ha scritto: Add display node for vdosys1. Signed-off-by: Nancy.Lin --- arch/arm64/boot/dts/mediatek/mt8195.dtsi | 222 +++ 1 file changed, 222 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek

Re: [PATCH v12 01/23] dt-bindings: mediatek: add vdosys1 RDMA definition for mt8195

2022-03-02 Thread AngeloGioacchino Del Regno
Il 22/02/22 11:07, Nancy.Lin ha scritto: Add vdosys1 RDMA definition. Signed-off-by: Nancy.Lin --- .../arm/mediatek/mediatek,mdp-rdma.yaml | 77 +++ 1 file changed, 77 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/mediatek/mediatek,mdp-rdma.y

Re: [PATCH v12 03/23] dt-bindings: mediatek: add ethdr definition for mt8195

2022-03-02 Thread AngeloGioacchino Del Regno
Il 22/02/22 11:07, Nancy.Lin ha scritto: Add vdosys1 ETHDR definition. Signed-off-by: Nancy.Lin Reviewed-by: Chun-Kuang Hu --- .../display/mediatek/mediatek,ethdr.yaml | 147 ++ 1 file changed, 147 insertions(+) create mode 100644 Documentation/devicetree/bindings/di

Re: [PATCH v12 04/23] dt-bindings: reset: mt8195: add vdosys1 reset control bit

2022-03-02 Thread AngeloGioacchino Del Regno
Il 22/02/22 11:07, Nancy.Lin ha scritto: Add vdosys1 reset control bit for MT8195 platform. Signed-off-by: Nancy.Lin Reviewed-by: Chun-Kuang Hu Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v1 07/10] drm/msm/adreno: Retry on gpu resume failure

2022-03-03 Thread AngeloGioacchino Del Regno
Il 02/03/22 18:27, Akhil P Oommen ha scritto: Retry infinitely on resume failure because there is nothing much we can do if GPU is not ON. Also, this helps us to avoid checking for the return value of pm_runtime_get() to see if GPU is ON. Signed-off-by: Akhil P Oommen --- drivers/gpu/drm/msm

[PATCH 1/3] dt-bindings: display: mediatek, mutex: Fix mediatek, gce-events type

2022-03-04 Thread AngeloGioacchino Del Regno
The mediatek,gce-events property needs as value an array of uint32 corresponding to the CMDQ events to listen to, and not any phandle. Fixes: 4ed545e7d100 ("dt-bindings: display: mediatek: disp: split each block to individual yaml") Signed-off-by: AngeloGioacchino Del Regno --- .../

[PATCH 0/3] Fix MediaTek display dt-bindings issues

2022-03-04 Thread AngeloGioacchino Del Regno
The vdosys0 series carried a nice dt-bindings conversion of the old txt documentation for the entire mediatek-drm driver, but some of the issues in there weren't seen. This series is fixing all of the issues pointed out by a `dt_binding_check` run, followed by `dtbs_check`. AngeloGioacchin

[PATCH 3/3] dt-bindings: display: mediatek: Fix examples on new bindings

2022-03-04 Thread AngeloGioacchino Del Regno
: 4ed545e7d100 ("dt-bindings: display: mediatek: disp: split each block to individual yaml") Signed-off-by: AngeloGioacchino Del Regno --- .../display/mediatek/mediatek,aal.yaml| 24 +++-- .../display/mediatek/mediatek,ccorr.yaml | 23 +++-- .../display/mediatek/mediatek,color.yaml

[PATCH 2/3] dt-bindings: display: mediatek, ovl: Fix 'iommu' required property typo

2022-03-04 Thread AngeloGioacchino Del Regno
The property is called 'iommus' and not 'iommu'. Fix this typo. Fixes: 4ed545e7d100 ("dt-bindings: display: mediatek: disp: split each block to individual yaml") Signed-off-by: AngeloGioacchino Del Regno --- .../devicetree/bindings/display/mediatek/mediate

Re: [PATCH v2, 1/3] dt-bindings: display: mediatek: dsi: Convert dsi_dtbinding to .yaml

2022-03-04 Thread AngeloGioacchino Del Regno
Il 18/02/22 11:07, xinlei@mediatek.com ha scritto: From: Xinlei Lee Convert mediatek,dsi.txt to mediatek,dsi.yaml format Signed-off-by: Xinlei Lee --- .../display/mediatek/mediatek,dsi.txt | 62 -- .../display/mediatek/mediatek,dsi.yaml| 85 +

Re: [PATCH v2, 2/3] dt-bindings: display: mediatek: dsi: Add compatible for MediaTek MT8186

2022-03-04 Thread AngeloGioacchino Del Regno
Il 18/02/22 11:07, xinlei@mediatek.com ha scritto: From: Xinlei Lee Add dt-binding documentation of dsi for MediaTek MT8186 SoC. Signed-off-by: Xinlei Lee Reviewed-by: AngeloGioacchino Del Regno --- .../devicetree/bindings/display/mediatek/mediatek,dsi.yaml | 1 + 1 file

Re: [PATCH v2,3/3] drm/mediatek: Add mt8186 dsi compatible to mtk_dsi.c

2022-03-04 Thread AngeloGioacchino Del Regno
Il 18/02/22 11:07, xinlei@mediatek.com ha scritto: From: Xinlei Lee Add the compatible because use different cmdq addresses in mt8186. Signed-off-by: Xinlei Lee Reviewed-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/mtk_dsi.c | 8 1 file changed, 8

Re: [PATCH v12 03/23] dt-bindings: mediatek: add ethdr definition for mt8195

2022-03-07 Thread AngeloGioacchino Del Regno
Il 07/03/22 03:33, Nancy.Lin ha scritto: Hi Angelo, Thanks for the review. On Wed, 2022-03-02 at 11:13 +0100, AngeloGioacchino Del Regno wrote: Il 22/02/22 11:07, Nancy.Lin ha scritto: Add vdosys1 ETHDR definition. Signed-off-by: Nancy.Lin Reviewed-by: Chun-Kuang Hu --- .../display

[PATCH 2/2] dt-bindings: display: Add bindings for Novatek NT35950

2021-09-01 Thread AngeloGioacchino Del Regno
input image to the panel's native resolution, for example it can upscale a 1920x1080 input to 3840x2160 with either bilinear interpolation or pixel duplication. Signed-off-by: AngeloGioacchino Del Regno --- .../display/panel/novatek,nt35950.yaml| 106 ++ 1 file changed

[PATCH 1/2] drm/panel: Add driver for Novatek NT35950 DSI DriverIC panels

2021-09-01 Thread AngeloGioacchino Del Regno
Add a driver for panels using the Novatek NT35950 Display Driver IC, including support for the Sharp LS055D1SX04, found in some Sony Xperia Z5 Premium and XZ Premium smartphones. Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/panel/Kconfig | 11 + drivers/gpu

[PATCH 2/2] dt-bindings: display: Document BOE BF060Y8M-AJ0 panel compatible

2021-09-01 Thread AngeloGioacchino Del Regno
Document the boe,bf060y8m-aj0 panel. Signed-off-by: AngeloGioacchino Del Regno --- .../display/panel/boe,bf060y8m-aj0.yaml | 81 +++ 1 file changed, 81 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/boe,bf060y8m-aj0.yaml diff --git a

[PATCH 1/2] drm/panel: Add BOE BF060Y8M-AJ0 5.99" AMOLED panel driver

2021-09-01 Thread AngeloGioacchino Del Regno
This adds support for the BOE BF060Y8M-AJ0 5.99" AMOLED module that can be found in some F(x)Tec Pro1 and Elephone U1 devices. Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/panel/Kconfig | 11 + drivers/gpu/drm/panel/Makefile| 1 + .../gp

[PATCH 1/2] drm/msm/dpu: Add a function to retrieve the current CTL status

2021-09-01 Thread AngeloGioacchino Del Regno
Add a function that returns whether the requested CTL is active or not: this will be used in a later commit to fix command mode panel issues. Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 6 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h | 7

[PATCH 2/2] drm/msm/dpu: Fix timeout issues on command mode panels

2021-09-01 Thread AngeloGioacchino Del Regno
_done function is called: in this case, so, if the CTL was already running, we can say that the commit is done if the command transmission is complete (in other terms, if the interface has been flushed). Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_

[PATCH 1/3] drm/msm/dpu1: Add DMA2, DMA3 clock control to enum

2021-09-01 Thread AngeloGioacchino Del Regno
The enum dpu_clk_ctrl_type misses DPU_CLK_CTRL_DMA{2,3} even though this driver does actually handle both, if present: add the two in preparation for adding support for SoCs having them. Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 2 ++ 1 file

[PATCH 2/3] drm/msm/dpu1: Add MSM8998 to hw catalog

2021-09-01 Thread AngeloGioacchino Del Regno
Bringup functionality for MSM8998 in the DPU, driver which is mostly the same as SDM845 (just a few variations). Signed-off-by: AngeloGioacchino Del Regno --- .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 335 +- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 1 + drivers

[PATCH 3/3] dt-bindings: display: msm: Add binding for msm8998 dpu

2021-09-01 Thread AngeloGioacchino Del Regno
Add yaml binding for msm8998 dpu1 support. Signed-off-by: AngeloGioacchino Del Regno --- .../bindings/display/msm/dpu-msm8998.yaml | 220 ++ 1 file changed, 220 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml diff --git a

Re: [PATCH v2 1/2] drm/msm/dsi: Use "ref" fw clock instead of global name for VCO parent

2021-09-02 Thread AngeloGioacchino Del Regno
#x27;bi_tcxo' as ref clock of the DSI PHYs") Signed-off-by: Marijn Suijten Reviewed-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c | 4 +++- drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c | 4 +++- drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm.c

Re: [PATCH v2 2/2] clk: qcom: gcc-sdm660: Remove transient global "xo" clock

2021-09-02 Thread AngeloGioacchino Del Regno
e.org/ and prevented the removal of "xo" at that time. Signed-off-by: Marijn Suijten Reviewed-by: AngeloGioacchino Del Regno --- drivers/clk/qcom/gcc-sdm660.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/drivers/clk/qcom/gcc-sdm660.c b/drivers/clk/qcom/g

Re: [Freedreno] [PATCH 2/3] drm/msm/dpu1: Add MSM8998 to hw catalog

2021-09-09 Thread AngeloGioacchino Del Regno
Il 09/09/21 15:46, Dmitry Baryshkov ha scritto: On 08/09/2021 17:22, Jeffrey Hugo wrote: On Wed, Sep 8, 2021 at 2:26 AM Dmitry Baryshkov wrote: Hi, On Tue, 7 Sept 2021 at 22:13, Jeffrey Hugo wrote: On Wed, Sep 1, 2021 at 12:11 PM AngeloGioacchino Del Regno wrote: Bringup functionality

Re: [PATCH 2/2] drm/msm/dpu: Fix timeout issues on command mode panels

2021-09-11 Thread AngeloGioacchino Del Regno
Il 10/09/21 23:48, Marijn Suijten ha scritto: Hi Angelo! On 2021-09-01 19:43:47, AngeloGioacchino Del Regno wrote: In function dpu_encoder_phys_cmd_wait_for_commit_done we are always checking if the relative CTL is started by waiting for an interrupt to fire: it is fine to do that, but then

[PATCH v2 2/2] drm/msm/dpu: Fix timeout issues on command mode panels

2021-09-11 Thread AngeloGioacchino Del Regno
_done function is called: in this case, so, if the CTL was already running, we can say that the commit is done if the command transmission is complete (in other terms, if the interface has been flushed). Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_

[PATCH v2 1/2] drm/msm/dpu: Add a function to retrieve the current CTL status

2021-09-11 Thread AngeloGioacchino Del Regno
Add a function that returns whether the requested CTL is active or not: this will be used in a later commit to fix command mode panel issues. Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 6 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h | 7

  1   2   3   4   5   6   7   8   9   10   >