From: Andy Yan
formats_win_full_10bit is for cluster window,
formats_win_full_10bit_yuyv is for rk356x esmart, rk3588 esmart window
will support more format.
formats_win_lite is for smart window.
Rename it based the windows type may let meaning is clearer
Signed-off-by: Andy Yan
---
(no
From: Andy Yan
This is a preparation for the upcoming support for rk3588 vop.
Patch 1 make the bpp calculation covery more format
Patch 2 remove formats that are unsupported by cluster windows
Patch 3 add more formats
Patch 4 is a format table rename
And I drop two patches that have applied
From: Andy Yan
We can't rely on cpp for bpp calculation as the cpp of
some formats(DRM_FORMAT_YUV420_8BIT/10BIT, etc) is zero.
Signed-off-by: Andy Yan
---
(no changes since v1)
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 18 --
1 file changed, 16 insertions(
From: Andy Yan
The cluster windows on vop2 doesn't support linear yuv
format(NV12/16/24), it only support afbc based yuv
format(DRM_FORMAT_YUV420_8BIT/10BIT), which will be
added in next patch.
Fixes: 604be85547ce ("drm/rockchip: Add VOP2 driver")
Signed-off-by: Andy Yan
---
From: Andy Yan
Add 10 bit RGB and AFBC based YUV format supported
by vop2.
Signed-off-by: Andy Yan
---
Changes in v3:
- add format check and convert
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 45 +++-
drivers/gpu/drm/rockchip/rockchip_vop2_reg.c | 22 +++---
2 files
From: Andy Yan
formats_win_full_10bit is for cluster window,
formats_win_full_10bit_yuyv is for rk356x esmart, rk3588 esmart window
will support more format.
formats_win_lite is for smart window.
Rename it based the windows type may let meaning is clearer
Signed-off-by: Andy Yan
---
(no
Hi Jonas:
On 10/15/23 02:30, Jonas Karlman wrote:
Hi Andy,
On 2023-10-13 14:21, Andy Yan wrote:
From: Andy Yan
Add the missing 10 bit RGB format for cluster window.
The cluster windows on rk3568/6 only support afbc format,
so change the linear yuv format NV12/16/24 to non-Linear
Hi:
On 10/24/23 16:49, Christopher Obbard wrote:
Hi Jonas,
On Mon, 2023-10-23 at 21:11 +, Jonas Karlman wrote:
Use of DRM_FORMAT_RGB888 and DRM_FORMAT_BGR888 on e.g. RK3288, RK3328
and RK3399 result in wrong colors being displayed.
The issue can be observed using modetest:
modetest -s
Hi Johan,
At 2024-07-03 02:23:24, "Johan Jonker" wrote:
>Add sound support to the RK3066 HDMI driver.
>The HDMI TX audio source is connected to I2S_8CH.
>
>Signed-off-by: Zheng Yang
>Signed-off-by: Johan Jonker
>---
>
>Changed V8:
> return -EPROBE_DEFER as early as possible
> move rk3066_hdmi
Hi Johan，
At 2024-07-03 02:23:24, "Johan Jonker" wrote:
>Add sound support to the RK3066 HDMI driver.
>The HDMI TX audio source is connected to I2S_8CH.
>
>Signed-off-by: Zheng Yang
>Signed-off-by: Johan Jonker
>---
>
>Changed V8:
> return -EPROBE_DEFER as early as possible
> move rk3066_hdm
Hi Dragan，
At 2024-07-04 07:32:02, "Dragan Simic" wrote:
>After the additional firmware-related module information was introduced by
>the commit c0677e41a47f ("drm/rockchip: cdn-dp-core: add MODULE_FIRMWARE
>macro"), there's no longer need for the firmware-loading workarounds whose
>sole purpose
Hi Johan，
Thanks for your patch。
At 2024-07-03 22:20:27, "Johan Jonker" wrote:
>Add sound support to the RK3066 HDMI driver.
>The HDMI TX audio source is connected to I2S_8CH.
>
>Signed-off-by: Zheng Yang
>Signed-off-by: Johan Jonker
>---
>
>Changed V9:
> Use late_register and early_unregi
Hi Johan,
Thanks for your patch.
At 2024-07-04 21:48:13, "Johan Jonker" wrote:
>Add sound support to the RK3066 HDMI driver.
>The HDMI TX audio source is connected to I2S_8CH.
>
>Signed-off-by: Zheng Yang
>Signed-off-by: Johan Jonker
Reviewed-by: Andy Ya
Hi Dragan，
At 2024-07-04 18:35:42, "Dragan Simic" wrote:
>Hello Andy,
>
>On 2024-07-04 04:10, Andy Yan wrote:
>> At 2024-07-04 07:32:02, "Dragan Simic" wrote:
>>> After the additional firmware-related module information was
>>> introduced
From: Andy Yan
Signed-off-by: Andy Yan
---
meson.build | 1 +
tests/modetest/modetest.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/meson.build b/meson.build
index 8fd0a196..fab61e09 100644
--- a/meson.build
+++ b/meson.build
@@ -45,6 +45,7 @@ dep_threads = dependency
Hi Draqan,
At 2024-07-09 16:17:06, "Dragan Simic" wrote:
>Hello Andy,
>
>On 2024-07-08 09:46, Andy Yan wrote:
>> At 2024-07-04 18:35:42, "Dragan Simic" wrote:
>>> On 2024-07-04 04:10, Andy Yan wrote:
>>>> At 2024-07-04 07:32:02, &q
Hi Dragan，
At 2024-07-09 18:10:51, "Dragan Simic" wrote:
>On 2024-07-09 11:10, Andy Yan wrote:
>> At 2024-07-09 16:17:06, "Dragan Simic" wrote:
>>> On 2024-07-08 09:46, Andy Yan wrote:
>>>> At 2024-07-04 18:35:42, "Dragan Simic" wrot
Hi Piotr,
Thanks for your work.
On 7/25/24 06:05, Piotr Zalewski wrote:
Add support for gamma LUT in VOP2 driver. The implementation is based on
the one found in VOP driver and modified to be compatible with VOP2. Blue
and red channels in gamma LUT register write were swapped with respect to
Hi Cristian,
On 6/6/24 19:51, Cristian Ciocaltea wrote:
On 6/6/24 2:22 AM, Rob Herring wrote:
On Sat, Jun 01, 2024 at 04:12:34PM +0300, Cristian Ciocaltea wrote:
Document the Synopsys DesignWare HDMI 2.1 Quad-Pixel (QP) TX controller
found on Rockchip RK3588 SoC family.
Since RK3588 uses diff
Hi Piotr,
On 7/27/24 03:49, Piotr Zalewski wrote:
On Friday, July 26th, 2024 at 10:55 AM, Andy Yan
wrote:
Hi Piotr
Hi Andy!
Thanks for your work.
On 7/25/24 06:05, Piotr Zalewski wrote:
Add support for gamma LUT in VOP2 driver. The implementation is based on
the one found in VOP
Hi Piotr,
On 7/30/24 05:20, Piotr Zalewski wrote:
Hi Andy
On Monday, July 29th, 2024 at 4:35 AM, Andy Yan wrote:
+
+static void vop2_crtc_gamma_set(struct vop2 *vop2, struct drm_crtc *crtc,
+ struct drm_crtc_state *old_state)
+{
+ struct drm_crtc_state *state = crtc->state;
+ str
nces separated
>(or connected) by semicolons, together with some wording improvements.
>
>Signed-off-by: Dragan Simic
Reviewed-by: Andy Yan
>---
> drivers/gpu/drm/rockchip/cdn-dp-core.c | 16 +++-
> 1 file changed, 7 insertions(+), 9 deletions(-)
>
>diff --git a
Hi Cristian,
At 2024-08-08 19:58:02, "Cristian Ciocaltea"
wrote:
>Move rockchip_drm_platform_driver unregistration after its sub-drivers,
>which ensures all drivers are unregistered in the reverse order used
>when they were registered.
Would you please provied some detail information about how
c() with
>iommu_paging_domain_alloc() to retire the former.
>
>Signed-off-by: Lu Baolu
>Reviewed-by: Jason Gunthorpe
>Link:
>https://lore.kernel.org/r/20240610085555.88197-19-baolu...@linux.intel.com
Acked-by: Andy Yan
>---
> drivers/gpu/drm/rockchip/rockchip_drm
nel.org/linux-rockchip/7d998e4c-e1d3-4e8b-af76-c5bc83b43...@rock-chips.com/
>
>Helped-by: Daniel Stone
>Helped-by: Dragan Simic
>Helped-by: Diederik de Haas
>Helped-by: Andy Yan
>Signed-off-by: Piotr Zalewski
>---
>
>Notes:
> WASN'T tested on RK3588.
>
&g
From: Andy Yan
This patch sets aims at enable the VOP2 support on rk3588.
Main feature of VOP2 on rk3588:
Four video ports:
VP0 Max 4096x2160
VP1 Max 4096x2160
VP2 Max 4096x2160
VP3 Max 2048x1080
4 4K Cluster windows with AFBC/line RGB and AFBC-only YUV support
4 4K Esmart windows with line
From: Andy Yan
The output interface related definition can shared between
vop and vop2, move them to rockchip_drm_drv.h can avoid duplicated
definition.
Signed-off-by: Andy Yan
---
drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 1 -
drivers/gpu/drm/rockchip/cdn-dp-core.c | 1
From: Andy Yan
This reverts commit b63a553e8f5aa6574eeb535a551817a93c426d8c.
regcache_sync will try to reload the configuration in regcache to
hardware, but the registers of 4 Cluster windows and Esmart1/2/3 on
the upcoming rk3588 can not be set successfully before internal PD
power on.
Also
From: Andy Yan
At first we thought the half_block_en bit in AFBCD_CTRL register
only work in afbc mode. But the fact is that it control the line
buffer in all mode(afbc/tile/line), so we need configure it in
all case.
Signed-off-by: Andy Yan
---
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
From: Andy Yan
The enable bit and transform offset of cluster windows should be
cleared when it work at linear mode, or we may have a iommu fault
issue.
Signed-off-by: Andy Yan
---
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers
From: Andy Yan
Set overlay mode register according to the
output mode is yuv or rgb.
Signed-off-by: Andy Yan
---
drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 1 +
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 19 ---
2 files changed, 17 insertions(+), 3 deletions(-)
diff
From: Andy Yan
The vop2 need to reference more grf(system grf, vop grf, vo0/1 grf,etc)
in the upcoming rk3588.
So we rename the current system grf to sys_grf.
Signed-off-by: Andy Yan
---
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 8
1 file changed, 4 insertions(+), 4 deletions
From: Andy Yan
Add VOP and VO GRF syscon compatibles for RK3588
Signed-off-by: Andy Yan
---
Documentation/devicetree/bindings/soc/rockchip/grf.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
b/Documentation/devicetree
From: Andy Yan
The vop2 on rk3588 is similar to which on rk356x
but with 4 video outputs and need to reference
more grf modules.
Signed-off-by: Andy Yan
---
.../display/rockchip/rockchip-vop2.yaml | 25 +++
1 file changed, 25 insertions(+)
diff --git
a/Documentation
From: Andy Yan
VOP2 on rk3588:
Four video ports:
VP0 Max 4096x2160
VP1 Max 4096x2160
VP2 Max 4096x2160
VP3 Max 2048x1080
4 4K Cluster windows with AFBC/line RGB and AFBC-only YUV support
4 4K Esmart windows with line RGB/YUV support
Signed-off-by: Andy Yan
---
drivers/gpu/drm/rockchip
From: Andy Yan
/sys/kernel/debug/dri/vop2/summary: dump vop display state
/sys/kernel/debug/dri/vop2/regs: dump whole vop registers
/sys/kernel/debug/dri/vop2/active_regs: only dump the registers of
activated modules
Signed-off-by: Andy Yan
---
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
From: Andy Yan
Add vop dt node for rk3588.
Signed-off-by: Andy Yan
---
arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 96 +++
1 file changed, 96 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
index
Hi Heiko:
On 11/15/23 07:34, Heiko Stübner wrote:
Hi Andy,
Am Dienstag, 14. November 2023, 12:28:55 CET schrieb Andy Yan:
From: Andy Yan
VOP2 on rk3588:
Four video ports:
VP0 Max 4096x2160
VP1 Max 4096x2160
VP2 Max 4096x2160
VP3 Max 2048x1080
4 4K Cluster windows with AFBC/line RGB and
On 11/15/23 05:54, Heiko Stübner wrote:
Am Dienstag, 14. November 2023, 12:28:41 CET schrieb Andy Yan:
From: Andy Yan
The vop2 on rk3588 is similar to which on rk356x
but with 4 video outputs and need to reference
more grf modules.
Signed-off-by: Andy Yan
---
.../display/rockchip
+0800, Andy Yan wrote:
From: Andy Yan
VOP2 on rk3588:
Four video ports:
VP0 Max 4096x2160
VP1 Max 4096x2160
VP2 Max 4096x2160
VP3 Max 2048x1080
4 4K Cluster windows with AFBC/line RGB and AFBC-only YUV support
4 4K Esmart windows with line RGB/YUV support
Signed-off-by: Andy Yan
---
driver
Hi Sascha:
On 11/16/23 15:50, Sascha Hauer wrote:
On Thu, Nov 16, 2023 at 03:24:54PM +0800, Andy Yan wrote:
case ROCKCHIP_VOP2_EP_HDMI0:
case ROCKCHIP_VOP2_EP_HDMI1:
...
}
would look a bit better overall.
+ /*
+* K = 2: dclk_core
Hi Sascha:
Please check my response for the rest comments inline.
On 11/15/23 17:08, Sascha Hauer wrote:
Hi Andy,
Thanks for your patches, some remarks inline.
On Tue, Nov 14, 2023 at 07:28:55PM +0800, Andy Yan wrote:
From: Andy Yan
VOP2 on rk3588:
Four video ports:
VP0 Max 4096x2160
VP1
Hi Ondrej:
On 2/18/24 23:17, Ondřej Jirman wrote:
Hi Andy,
On Sun, Feb 18, 2024 at 07:14:56PM +0800, Andy Yan wrote:
Hi,
On 2/18/24 02:39, Ondřej Jirman wrote:
From: Ondrej Jirman
On RK3399 one MIPI DSI device can be alternatively used with the ISP1,
to provide RX DPHY. When this is the
From: Andy Yan
The Alpha blending for 30 bit RGB/BGR are not
functioning properly for rk3568/rk3588, so remove
it from the format list.
Fixes: bfd8a5c228fa ("drm/rockchip: vop2: Add more supported 10bit formats")
Signed-off-by: Andy Yan
---
drivers/gpu/drm/rockchip/rockchip_vop2
From: Andy Yan
The Alpha blending for 30 bit RGB/BGR are not
functioning properly for rk3568/rk3588, so remove
it from the format list.
Fixes: bfd8a5c228fa ("drm/rockchip: vop2: Add more supported 10bit formats")
Signed-off-by: Andy Yan
---
drivers/gpu/drm/rockchip/rockchip_vop2
Hi Boris：
Thanks for you great work。
One thing please take note：
commit (arm64: dts: rockchip: rk3588: Add GPU nodes) in [1] seems remove the
"disabled" status
of usb_host2_xhci, this may cause a boot issue on some boards that use
combphy2_psu phy for other functions.
https://gitlab.freede
20:47 +0800 (CST)
>"Andy Yan" wrote:
>
>> Hi Boris：
>>
>> Thanks for you great work。
>>
>> One thing please take note：
>> commit (arm64: dts: rockchip: rk3588: Add GPU nodes) in [1] seems remove
>> the "disabled" status
>&g
Hi Boris:
在 2024-02-04 18:07:56，"Boris Brezillon" 写道：
>On Sun, 4 Feb 2024 09:14:44 +0800 (CST)
>"Andy Yan" wrote:
>
>> Hi Boris：
>> I saw this warning sometimes（Run on a armbain based bookworm），not sure is a
>> know issue or something else。
&
Hi Boris：
在 2024-02-05 17:03:21，"Boris Brezillon" 写道：
>+Danilo for the panthor gpuvm-needs update.
>
>On Sun, 4 Feb 2024 09:14:44 +0800 (CST)
>"Andy Yan" wrote:
>
>> Hi Boris：
>> I saw this warning sometimes（Run on a armbain based bookworm）
HI Boris：
在 2024-02-05 17:03:21，"Boris Brezillon" 写道：
>+Danilo for the panthor gpuvm-needs update.
>
>On Sun, 4 Feb 2024 09:14:44 +0800 (CST)
>"Andy Yan" wrote:
>
>> Hi Boris：
>> I saw this warning sometimes（Run on a armbain based bookworm）
Hi,
On 2/18/24 02:39, Ondřej Jirman wrote:
From: Ondrej Jirman
On RK3399 one MIPI DSI device can be alternatively used with the ISP1,
to provide RX DPHY. When this is the case (ISP1 is enabled in device
tree), probe success of DRM is tied to probe success of ISP1 connected
camera sensor. This
Hi Maxime,
At 2024-05-07 21:17:45, "Maxime Ripard" wrote:
>The new HDMI connector infrastructure allows to remove some boilerplate,
>especially to generate infoframes. Let's switch to it.
>
>Reviewed-by: Heiko Stuebner
>Acked-by: Heiko Stuebner
>Signed-off-by: Maxime Ripard
>---
> drivers/gpu
Hi Maxime，
在 2024-05-07 21:17:33，"Maxime Ripard" 写道：
>Now that we have all the infrastructure needed, we can add some code
>that will, for a given connector state and mode, compute the best output
>format and bpc.
>
>The algorithm is equivalent to the one already found in i915 and vc4.
>
>Cc: Vi
Hi Maxime,
On 5/16/24 17:45, Maxime Ripard wrote:
Hi again,
On Sun, May 12, 2024 at 04:18:38PM +0800, Andy Yan wrote:
在 2024-05-07 21:17:33，"Maxime Ripard" 写道：
Now that we have all the infrastructure needed, we can add some code
that will, for a given connector state and mode, c
Hi Maxime，
At 2024-05-21 18:14:00, "Maxime Ripard" wrote:
>The new HDMI connector infrastructure allows to remove some boilerplate,
>especially to generate infoframes. Let's switch to it.
>
>Reviewed-by: Heiko Stuebner
>Acked-by: Heiko Stuebner
>Signed-off-b
Hi Maxime,
At 2024-05-21 18:14:01, "Maxime Ripard" wrote:
>The new HDMI connector infrastructure allows to remove some boilerplate,
>especially to generate infoframes. Let's switch to it.
>
>Reviewed-by: Jernej Skrabec
>Acked-by: Sui Jingfeng
>Signed-off-by:
Hi Detlev，
At 2024-05-23 02:57:48, "Detlev Casanova" wrote:
>At the end of initialization, each VP clock needs to be reset before
>they can be used.
>
>Failing to do so can put the VOP in an undefined state where the
>generated HDMI signal is either lost or not matching the selected mode.
Woul
Hi Heiko,
On 12/14/23 14:46, Andy Yan wrote:
Hi Heiko:
On 12/13/23 22:46, Heiko Stuebner wrote:
On Mon, 11 Dec 2023 19:55:47 +0800, Andy Yan wrote:
From: Andy Yan
This patch sets aims at enable the VOP2 support on rk3588.
Main feature of VOP2 on rk3588:
Four video ports:
VP0 Max 4096x2160
Hi Sebastian:
On 11/16/23 21:47, Sebastian Reichel wrote:
Hi,
On Thu, Nov 16, 2023 at 06:39:40PM +0800, Andy Yan wrote:
vop2->sys_grf = syscon_regmap_lookup_by_phandle(dev->of_node,
"rockchip,grf");
This already lacks an error check, shame on me...
+
Hi Jonas:
On 11/18/23 07:46, Jonas Karlman wrote:
On 2023-11-14 12:28, Andy Yan wrote:
From: Andy Yan
VOP2 on rk3588:
Four video ports:
VP0 Max 4096x2160
VP1 Max 4096x2160
VP2 Max 4096x2160
VP3 Max 2048x1080
4 4K Cluster windows with AFBC/line RGB and AFBC-only YUV support
4 4K Esmart
From: Andy Yan
This patch sets aims at enable the VOP2 support on rk3588.
Main feature of VOP2 on rk3588:
Four video ports:
VP0 Max 4096x2160
VP1 Max 4096x2160
VP2 Max 4096x2160
VP3 Max 2048x1080
4 4K Cluster windows with AFBC/line RGB and AFBC-only YUV support
4 4K Esmart windows with line
From: Andy Yan
The output interface related definition can shared between
vop and vop2, move them to rockchip_drm_drv.h can avoid duplicated
definition.
Signed-off-by: Andy Yan
---
(no changes since v1)
drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 1 -
drivers/gpu/drm/rockchip/cdn-dp
From: Andy Yan
This reverts commit b63a553e8f5aa6574eeb535a551817a93c426d8c.
regcache_sync will try to reload the configuration in regcache to
hardware, but the registers of 4 Cluster windows and Esmart1/2/3 on
the upcoming rk3588 can not be set successfully before internal PD
power on.
Also
From: Andy Yan
At first we thought the half_block_en bit in AFBCD_CTRL register
only work in afbc mode. But the fact is that it control the line
buffer in all mode(afbc/tile/line), so we need configure it in
all case.
Signed-off-by: Andy Yan
---
(no changes since v1)
drivers/gpu/drm
From: Andy Yan
The enable bit and transform offset of cluster windows should be
cleared when it work at linear mode, or we may have a iommu fault
issue.
Signed-off-by: Andy Yan
---
(no changes since v1)
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 5 +
1 file changed, 5 insertions
From: Andy Yan
Set overlay mode register according to the
output mode is yuv or rgb.
Signed-off-by: Andy Yan
---
(no changes since v1)
drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 1 +
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 19 ---
2 files changed, 17 insertions
From: Andy Yan
The vop2 need to reference more grf(system grf, vop grf, vo0/1 grf,etc)
in the upcoming rk3588.
So we rename the current system grf to sys_grf.
Signed-off-by: Andy Yan
---
(no changes since v1)
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 8
1 file changed, 4
From: Andy Yan
Add VOP and VO GRF syscon compatibles for RK3588
Signed-off-by: Andy Yan
Acked-by: Rob Herring
---
(no changes since v1)
Documentation/devicetree/bindings/soc/rockchip/grf.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/soc
From: Andy Yan
The vop2 on rk3588 is similar to which on rk356x
but with 4 video ports and need to reference
more grf modules.
Signed-off-by: Andy Yan
---
Changes in v2:
- fix errors when running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
.../display/rockchip/rockchip-vop2.yaml
From: Andy Yan
There are 2 HDMI, 2 DP, 2 eDP on rk3588, so add
corresponding endpoint definition for it.
Signed-off-by: Andy Yan
---
Changes in v2:
- split form vop driver patch
include/dt-bindings/soc/rockchip,vop2.h | 4
1 file changed, 4 insertions(+)
diff --git a/include/dt
From: Andy Yan
VOP2 on rk3588:
Four video ports:
VP0 Max 4096x2160
VP1 Max 4096x2160
VP2 Max 4096x2160
VP3 Max 2048x1080
4 4K Cluster windows with AFBC/line RGB and AFBC-only YUV support
4 4K Esmart windows with line RGB/YUV support
Signed-off-by: Andy Yan
---
Changes in v2:
- add rk3588_
From: Andy Yan
/sys/kernel/debug/dri/vop2/summary: dump vop display state
/sys/kernel/debug/dri/vop2/regs: dump whole vop registers
/sys/kernel/debug/dri/vop2/active_regs: only dump the registers of
activated modules
Signed-off-by: Andy Yan
---
(no changes since v1)
drivers/gpu/drm
From: Andy Yan
Add vop dt node for rk3588.
Signed-off-by: Andy Yan
---
(no changes since v1)
arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 96 +++
1 file changed, 96 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
b/arch/arm64/boot/dts/rockchip
From: Andy Yan
Hi:
I get a use-after-free KASAN report on a psr enabled system as bellow:
It seems there is a race happens like this:
task 6074: userspace
suspend_devices_and_enter+0xa20/0xba0
Hi Johan:
some information bellow hope can help a bit.
On 11/23/23 20:54, Johan Jonker wrote:
On 11/20/23 18:06, Heiko Stuebner wrote:
Hi Johan,
Am Donnerstag, 2. November 2023, 14:42:19 CET schrieb Johan Jonker:
The Rk3066 hdmi output format is hard coded to RGB. Remove
all useless code re
Hi Sascha:
thanks for you review.
On 11/27/23 18:13, Sascha Hauer wrote:
On Wed, Nov 22, 2023 at 08:56:01PM +0800, Andy Yan wrote:
From: Andy Yan
/sys/kernel/debug/dri/vop2/summary: dump vop display state
/sys/kernel/debug/dri/vop2/regs: dump whole vop registers
/sys/kernel/debug/dri/vop2
Hi Heiko:
On 11/27/23 23:02, Heiko Stübner wrote:
Am Mittwoch, 22. November 2023, 13:54:25 CET schrieb Andy Yan:
From: Andy Yan
The enable bit and transform offset of cluster windows should be
cleared when it work at linear mode, or we may have a iommu fault
issue.
Signed-off-by: Andy Yan
Hi Heiko:
Thanks for you review.
On 11/27/23 23:29, Heiko Stübner wrote:
Hi Andy,
Am Mittwoch, 22. November 2023, 13:55:44 CET schrieb Andy Yan:
From: Andy Yan
VOP2 on rk3588:
Four video ports:
VP0 Max 4096x2160
VP1 Max 4096x2160
VP2 Max 4096x2160
VP3 Max 2048x1080
4 4K Cluster windows
Hi Heiko:
On 11/28/23 16:30, Heiko Stübner wrote:
Am Dienstag, 28. November 2023, 09:03:46 CET schrieb Andy Yan:
Hi Heiko:
On 11/27/23 23:02, Heiko Stübner wrote:
Am Mittwoch, 22. November 2023, 13:54:25 CET schrieb Andy Yan:
From: Andy Yan
The enable bit and transform offset of cluster
Hi Heiko:
On 11/28/23 17:44, Heiko Stübner wrote:
Hi Andy,
Am Dienstag, 28. November 2023, 10:32:55 CET schrieb Andy Yan:
On 11/27/23 23:29, Heiko Stübner wrote:
Am Mittwoch, 22. November 2023, 13:55:44 CET schrieb Andy Yan:
From: Andy Yan
VOP2 on rk3588:
Four video ports:
VP0 Max
Hi Sasha:
On 11/27/23 22:16, Sascha Hauer wrote:
On Wed, Nov 22, 2023 at 08:54:38PM +0800, Andy Yan wrote:
From: Andy Yan
Set overlay mode register according to the
output mode is yuv or rgb.
Signed-off-by: Andy Yan
---
(no changes since v1)
drivers/gpu/drm/rockchip/rockchip_drm_drv.h
Hi Sascha,
On 11/27/23 19:19, Sascha Hauer wrote:
Hi Andy,
Looks good overall, two small things inside.
On Wed, Nov 22, 2023 at 08:55:44PM +0800, Andy Yan wrote:
+#define vop2_output_if_is_hdmi(x) (x == ROCKCHIP_VOP2_EP_HDMI0 || x == ROCKCHIP_VOP2_EP_HDMI1)
+#define vop2_output_if_is_dp(x
Hi Sascha:
On 11/29/23 16:52, Sascha Hauer wrote:
On Mon, Nov 27, 2023 at 06:56:34PM +0800, Andy Yan wrote:
Hi Sascha:
thanks for you review.
On 11/27/23 18:13, Sascha Hauer wrote:
On Wed, Nov 22, 2023 at 08:56:01PM +0800, Andy Yan wrote:
From: Andy Yan [1]
/sys/kernel
Hi Sascha:
On 11/29/23 20:59, Sascha Hauer wrote:
On Wed, Nov 29, 2023 at 07:01:37PM +0800, Andy Yan wrote:
Hi Sascha:
On 11/29/23 16:52, Sascha Hauer wrote:
On Mon, Nov 27, 2023 at 06:56:34PM +0800, Andy Yan wrote:
Hi Sascha:
thanks for you review.
On 11/27/23 18:13
From: Andy Yan
This patch sets aims at enable the VOP2 support on rk3588.
Main feature of VOP2 on rk3588:
Four video ports:
VP0 Max 4096x2160
VP1 Max 4096x2160
VP2 Max 4096x2160
VP3 Max 2048x1080
4 4K Cluster windows with AFBC/line RGB and AFBC-only YUV support
4 4K Esmart windows with line
From: Andy Yan
The output interface related definition can shared between
vop and vop2, move them to rockchip_drm_drv.h can avoid duplicated
definition.
Signed-off-by: Andy Yan
Reviewed-by: Sascha Hauer
---
(no changes since v1)
drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 1
From: Andy Yan
This reverts commit b63a553e8f5aa6574eeb535a551817a93c426d8c.
regcache_sync will try to reload the configuration in regcache to
hardware, but the registers of 4 Cluster windows and Esmart1/2/3 on
the upcoming rk3588 can not be set successfully before internal PD
power on.
Also
From: Andy Yan
At first we thought the half_block_en bit in AFBCD_CTRL register
only work in afbc mode. But the fact is that it control the line
buffer in all mode(afbc/tile/linear), so we need configure it in
all case.
As the cluster windows of rk3568 only supports afbc format
so is therefore
From: Andy Yan
The enable bit and transform offset of cluster windows should be
cleared when it work at linear mode, or we may have a iommu fault
issue on rk3588 which cluster windows switch between afbc and linear
mode.
As the cluster windows of rk3568 only supports afbc format
so is therefore
From: Andy Yan
The write mask bit is used to make sure when writing
config done bit for one VP will not overwrite the other.
Unfortunately, the write mask bit is missing on
rk3566/8, that means when we write to these bits,
it will not take any effect.
We need this to make the vop work properly
From: Andy Yan
Set overlay mode register according to the
output mode is yuv or rgb.
Signed-off-by: Andy Yan
---
Changes in v3:
- put bool variable yuv_overlay next to other bool variable
- define macro for RK3568_OVL_CTRL__YUV_MODE
- just write RK3568_OVL_CTRL register once in function
From: Andy Yan
The vop2 need to reference more grf(system grf, vop grf, vo0/1 grf,etc)
in the upcoming rk3588.
So we rename the current system grf to sys_grf.
Signed-off-by: Andy Yan
Reviewed-by: Sascha Hauer
---
(no changes since v1)
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 8
From: Andy Yan
Add VOP and VO GRF syscon compatibles for RK3588
Signed-off-by: Andy Yan
Acked-by: Rob Herring
---
(no changes since v1)
Documentation/devicetree/bindings/soc/rockchip/grf.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/soc
From: Andy Yan
The vop2 on rk3588 is similar to which on rk356x
but with 4 video ports and need to reference
more grf modules.
Signed-off-by: Andy Yan
---
Changes in v3:
- constrain properties in allOf:if:then
- some description updates
Changes in v2:
- fix errors when running '
From: Andy Yan
There are 2 HDMI, 2 DP, 2 eDP on rk3588, so add
corresponding endpoint definition for it.
Signed-off-by: Andy Yan
Acked-by: Krzysztof Kozlowski
---
Changes in v3:
- change the subject as Krzysztof suggested, and add his ACK
Changes in v2:
- split form vop driver patch
From: Andy Yan
VOP2 on rk3588:
Four video ports:
VP0 Max 4096x2160
VP1 Max 4096x2160
VP2 Max 4096x2160
VP3 Max 2048x1080
4 4K Cluster windows with AFBC/line RGB and AFBC-only YUV support
4 4K Esmart windows with line RGB/YUV support
Signed-off-by: Andy Yan
---
Changes in v3:
- add braces
From: Andy Yan
/sys/kernel/debug/dri/vop2/summary: dump vop display state
/sys/kernel/debug/dri/vop2/regs: dump whole vop registers
/sys/kernel/debug/dri/vop2/active_regs: only dump the registers of
activated modules
Signed-off-by: Andy Yan
---
Changes in v3:
- put regs dump info in
From: Andy Yan
Add a Rockchip RK3588 compatible
Signed-off-by: Andy Yan
---
(no changes since v1)
Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml
b/Documentation
From: Andy Yan
Add vop dt node for rk3588.
Signed-off-by: Andy Yan
---
(no changes since v1)
arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 96 +++
1 file changed, 96 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
b/arch/arm64/boot/dts/rockchip
Hi Krzysztof:
On 11/23/23 03:07, Krzysztof Kozlowski wrote:
On 22/11/2023 13:55, Andy Yan wrote:
From: Andy Yan
The vop2 on rk3588 is similar to which on rk356x
but with 4 video ports and need to reference
more grf modules.
Signed-off-by: Andy Yan
---
Changes in v2:
- fix errors when
201 - 300 of 984 matches
Mail list logo
