Hi Robin:
On 6/28/21 5:54 PM, Robin Murphy wrote:
On 2021-06-27 09:47, Andy Yan wrote:
When iommu itself is disabled in dts, we should
fallback to non-iommu buffer, check iommu parent
is meanless here.
Signed-off-by: Andy Yan
---
drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 2 +-
1 file
Hi Alex:
On 7/13/21 7:40 PM, Alex Bee wrote:
Hi Benjamin,
Am 07.07.21 um 14:03 schrieb Benjamin Gaignard:
Add a new dw_hdmi_plat_data struct and new compatible for rk3568.
This version of the HDMI hardware block need two clocks to provide
phy reference clock: hclk_vio and hclk.
Signed-off-by:
Hi Daniel:
On 3/8/22 22:04, Daniel Stone wrote:
On Tue, 8 Mar 2022 at 08:42, Andy Yan wrote:
On 3/7/22 21:09, Daniel Stone wrote:
On Mon, 7 Mar 2022 at 12:18, Andy Yan wrote:
When run a weston 10.0.0:
# export XDG_RUNTIME_DIR=/tmp
# weston --backend=drm-backend.so --use-pixma
Hi Daniel:
On 3/9/22 10:03, Andy Yan wrote:
Hi Daniel:
On 3/8/22 22:04, Daniel Stone wrote:
On Tue, 8 Mar 2022 at 08:42, Andy Yan wrote:
On 3/7/22 21:09, Daniel Stone wrote:
On Mon, 7 Mar 2022 at 12:18, Andy Yan wrote:
When run a weston 10.0.0:
# export XDG_RUNTIME_DIR=/tmp
Hi Daniel:
Remember you said our downstream vop2 driver is very slow on weston.
Would you please share the case you run ? or how can i test frame rate
on weston?
On 3/9/22 15:37, Andy Yan wrote:
Hi Daniel:
On 3/9/22 10:03, Andy Yan wrote:
Hi Daniel:
On 3/8/22 22:04, Daniel Stone wrote
Hi Sascha:
On 3/11/22 16:33, Sascha Hauer wrote:
From: Andy Yan
The VOP2 unit is found on Rockchip SoCs beginning with rk3566/rk3568.
It replaces the VOP unit found in the older Rockchip SoCs.
This driver has been derived from the downstream Rockchip Kernel and
heavily modified:
- All
Hi Daniel:
On 3/15/22 20:43, Daniel Stone wrote:
Hi Andy,
On Tue, 15 Mar 2022 at 06:46, Andy Yan wrote:
On 3/11/22 16:33, Sascha Hauer wrote:
The driver is tested with HDMI and MIPI-DSI display on a RK3568-EVB
board. Overlay support is tested with the modetest utility. AFBC support
on the
Hi Sascha and Daniel:
On 3/16/22 15:40, Sascha Hauer wrote:
On Tue, Mar 15, 2022 at 02:46:35PM +0800, Andy Yan wrote:
Hi Sascha:
On 3/11/22 16:33, Sascha Hauer wrote:
From: Andy Yan
The VOP2 unit is found on Rockchip SoCs beginning with rk3566/rk3568.
It replaces the VOP unit found in the
Hi Sascha:
On 3/16/22 20:22, Andy Yan wrote:
Hi Sascha and Daniel:
On 3/16/22 15:40, Sascha Hauer wrote:
On Tue, Mar 15, 2022 at 02:46:35PM +0800, Andy Yan wrote:
Hi Sascha:
On 3/11/22 16:33, Sascha Hauer wrote:
From: Andy Yan
The VOP2 unit is found on Rockchip SoCs beginning with rk3566
Hi Sascha:
On 3/28/22 23:11, Sascha Hauer wrote:
With upcoming VOP2 support VOP won't be the only choice anymore, so make
the VOP driver optional.
Signed-off-by: Sascha Hauer
---
drivers/gpu/drm/rockchip/Kconfig| 8
drivers/gpu/drm/rockchip/Makefile | 3 ++-
Hi Sascha:
On 3/30/22 14:39, Sascha Hauer wrote:
Hi Andy,
On Tue, Mar 29, 2022 at 07:56:27PM +0800, Andy Yan wrote:
Hi Sascha:
On 3/28/22 23:11, Sascha Hauer wrote:
With upcoming VOP2 support VOP won't be the only choice anymore, so make
the VOP driver optional.
Signed-off-by: Sascha
Hi Sascha:
On 2/18/22 16:00, Sascha Hauer wrote:
On Fri, Feb 18, 2022 at 11:50:32AM +0800, Andy Yan wrote:
Hi Sascha:
On 2/17/22 22:06, Heiko Stübner wrote:
Am Donnerstag, 17. Februar 2022, 14:58:23 CET schrieb Sascha Hauer:
Hi Andy,
Please trim the context in your answers to the relevant
Hi Sascha:
On 2/17/22 16:29, Sascha Hauer wrote:
From: Andy Yan
The VOP2 unit is found on Rockchip SoCs beginning with rk3566/rk3568.
It replaces the VOP unit found in the older Rockchip SoCs.
This driver has been derived from the downstream Rockchip Kernel and
heavily modified:
- All
Hi Sascha:
On 2/24/22 16:19, Sascha Hauer wrote:
On Sat, Feb 19, 2022 at 03:35:12PM +0800, Andy Yan wrote:
Hi Sascha:
On 2/18/22 16:00, Sascha Hauer wrote:
On Fri, Feb 18, 2022 at 11:50:32AM +0800, Andy Yan wrote:
Hi Sascha:
On 2/17/22 22:06, Heiko Stübner wrote:
Am Donnerstag, 17
Hi:
I have a test with the 24 patches applied on Linux-5.17-rc5 on
rk3568-evb1-v10 board with Sony XR-75z9j HDMI TV,
4K don't work, the tv shows no signal.
1080P can work.
On 2/25/22 15:51, Sascha Hauer wrote:
From: Nickey Yang
add 594Mhz configuration parameters in rockchip_phy_config
Hi Sascha:
On 2/25/22 15:51, Sascha Hauer wrote:
From: Andy Yan
The VOP2 unit is found on Rockchip SoCs beginning with rk3566/rk3568.
It replaces the VOP unit found in the older Rockchip SoCs.
This driver has been derived from the downstream Rockchip Kernel and
heavily modified:
- All
Hi :
On 3/5/22 07:55, Dmitry Osipenko wrote:
On 3/4/22 17:22, Sascha Hauer wrote:
On Wed, Mar 02, 2022 at 12:25:28PM +0100, Sascha Hauer wrote:
On Tue, Mar 01, 2022 at 01:39:31PM +, Robin Murphy wrote:
On 2022-02-28 14:19, Sascha Hauer wrote:
On Fri, Feb 25, 2022 at 02:11:54PM +0100, Sas
Hi Daniel:
On 3/7/22 21:09, Daniel Stone wrote:
Hi Andy,
On Mon, 7 Mar 2022 at 12:18, Andy Yan wrote:
On 2/25/22 15:51, Sascha Hauer wrote:
The VOP2 unit is found on Rockchip SoCs beginning with rk3566/rk3568.
It replaces the VOP unit found in the older Rockchip SoCs.
This driver has been
Hi Daniel:
On 11/18/21 8:07 PM, Daniel Stone wrote:
Hi Kever,
On Thu, 18 Nov 2021 at 10:50, Kever Yang wrote:
On 2021/11/18 下午5:53, Daniel Stone wrote:
Exactly what Heiko said. If you would like to upstream the driver then
that would be fantastic to see, but I'm afraid you do not get to
prev
12/20/21 7:06 PM, Sascha Hauer wrote:
From: Andy Yan
The VOP2 unit is found on Rockchip SoCs beginning with rk3566/rk3568.
It replaces the VOP unit found in the older Rockchip SoCs.
This driver has been derived from the downstream Rockchip Kernel and
heavily modified:
- All nonstandard DRM
Hi Sascha:
On 2/17/22 16:29, Sascha Hauer wrote:
From: Andy Yan
The VOP2 unit is found on Rockchip SoCs beginning with rk3566/rk3568.
It replaces the VOP unit found in the older Rockchip SoCs.
This driver has been derived from the downstream Rockchip Kernel and
heavily modified:
- All
Hi Sascha:
On 2/17/22 22:06, Heiko Stübner wrote:
Am Donnerstag, 17. Februar 2022, 14:58:23 CET schrieb Sascha Hauer:
Hi Andy,
Please trim the context in your answers to the relevant parts, it makes
it easier to find the things you said.
On Thu, Feb 17, 2022 at 08:00:11PM +0800, Andy Yan
Hi Zhijie:
On 5/7/22 09:00, Ren Zhijie wrote:
If CONFIG_ROCKCHIP_ANALOGIX_DP is not set, the rockchip drm driver
will fail to link:
drivers/gpu/drm/rockchip/cdn-dp-core.o: In function
`cdn_dp_connector_mode_valid':
cdn-dp-core.c:(.text+0x1e1): undefined reference to
`drm_dp_bw_code_to_link_ra
0xd5a): undefined reference to `drm_dp_bw_code_to_link_rate'
The DP-helper module has been replaced by the display-helper module.
So the driver have to select it.
Reported-by: Hulk Robot
Fixes: 1e0f66420b13("drm/display: Introduce a DRM display-helper module")
Signed-off-by: Ren Zhijie
Thanks.
Re
Hi Sascha:
On 3/31/22 15:06, Sascha Hauer wrote:
On Wed, Mar 30, 2022 at 08:50:09PM +0800, Andy Yan wrote:
Hi Sascha:
On 3/30/22 14:39, Sascha Hauer wrote:
Hi Andy,
On Tue, Mar 29, 2022 at 07:56:27PM +0800, Andy Yan wrote:
Hi Sascha:
On 3/28/22 23:11, Sascha Hauer wrote:
With upcoming
Hi:
On 3/31/22 16:18, Sascha Hauer wrote:
On Thu, Mar 31, 2022 at 03:20:37PM +0800, Andy Yan wrote:
Hi Sascha:
On 3/31/22 15:06, Sascha Hauer wrote:
On Wed, Mar 30, 2022 at 08:50:09PM +0800, Andy Yan wrote:
Hi Sascha:
On 3/30/22 14:39, Sascha Hauer wrote:
Hi Andy,
On Tue, Mar 29, 2022 at
Hi Piotr:
On 3/31/22 03:20, Sascha Hauer wrote:
On Wed, Mar 30, 2022 at 04:52:22PM +0200, Piotr Oniszczuk wrote:
Wiadomość napisana przez Sascha Hauer w dniu
30.03.2022, o godz. 12:20:
Does it change anything if you do a "modetest -s 69@67:1920x1080" before
starting the app? Or if you run
Hi Piotr:
On 3/31/22 22:53, Piotr Oniszczuk wrote:
Wiadomość napisana przez Andy Yan w dniu 31.03.2022,
o godz. 14:13:
Piotr:
What soc is on you board? rk3566 or rk3568?
it is rk3566 in x96-x6 tvbox
RK3566? Maybe that is the problem.
plane[43]: Esmart1-win0
crtc=(null)
fb=0
crtc
Hi Piotr:
On 4/1/22 09:52, Andy Yan wrote:
Hi Piotr:
On 3/31/22 22:53, Piotr Oniszczuk wrote:
Wiadomość napisana przez Andy Yan w dniu 31.03.2022,
o godz. 14:13:
Piotr:
What soc is on you board? rk3566 or rk3568?
it is rk3566 in x96-x6 tvbox
RK3566? Maybe that is the problem
Hi Sascha:
On 4/1/22 20:55, Sascha Hauer wrote:
On Thu, Mar 31, 2022 at 07:00:34PM +0800, Andy Yan wrote:
Hi:
On 3/31/22 16:18, Sascha Hauer wrote:
On Thu, Mar 31, 2022 at 03:20:37PM +0800, Andy Yan wrote:
Hi Sascha:
On 3/31/22 15:06, Sascha Hauer wrote:
On Wed, Mar 30, 2022 at 08:50:09PM
Hi Sacha:
On 4/1/22 20:52, Sascha Hauer wrote:
--
>From cbc03073623a7180243331ac24c3afaf9dec7522 Mon Sep 17 00:00:00 2001
From: Sascha Hauer
Date: Fri, 1 Apr 2022 14:48:49 +0200
Subject: [PATCH] fixup! drm: rockchip: Add VOP2 driver
---
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 14 ++
Hi Sacha:
On 4/5/22 17:05, Sascha Hauer wrote:
On Sat, Apr 02, 2022 at 09:25:33AM +0800, Andy Yan wrote:
Hi Sascha:
On 4/1/22 20:55, Sascha Hauer wrote:
On Thu, Mar 31, 2022 at 07:00:34PM +0800, Andy Yan wrote:
Hi:
On 3/31/22 16:18, Sascha Hauer wrote:
On Thu, Mar 31, 2022 at 03:20:37PM
Hi:
On 4/5/22 17:37, Sascha Hauer wrote:
On Sat, Apr 02, 2022 at 09:37:17AM +0800, Andy Yan wrote:
Hi Sacha:
On 4/1/22 20:52, Sascha Hauer wrote:
--
>From cbc03073623a7180243331ac24c3afaf9dec7522 Mon Sep 17 00:00:00 2001
From: Sascha Hauer
Date: Fri, 1 Apr 2022 14:48:49 +0200
Subject: [PA
Hi:
On 4/6/22 15:04, Sascha Hauer wrote:
On Wed, Apr 06, 2022 at 09:43:49AM +0800, Andy Yan wrote:
Hi Sacha:
On 4/5/22 17:05, Sascha Hauer wrote:
On Sat, Apr 02, 2022 at 09:25:33AM +0800, Andy Yan wrote:
Hi Sascha:
On 4/1/22 20:55, Sascha Hauer wrote:
On Thu, Mar 31, 2022 at 07:00:34PM
Hi:
On 4/6/22 16:13, Sascha Hauer wrote:
On Wed, Apr 06, 2022 at 10:02:59AM +0800, Andy Yan wrote:
Hi:
On 4/5/22 17:37, Sascha Hauer wrote:
On Sat, Apr 02, 2022 at 09:37:17AM +0800, Andy Yan wrote:
Hi Sacha:
On 4/1/22 20:52, Sascha Hauer wrote:
--
>F
Hi Sascha:
On 8/24/22 15:07, Sascha Hauer wrote:
Hi Andy Et al.,
On Mon, Aug 22, 2022 at 05:20:15PM +0200, Sascha Hauer wrote:
This series adds support for 4k@30 to the rockchip HDMI controller. This
has been tested on a rk3568 rock3a board. It should be possible to add
4k@60 support the same
Hi Rohith:
At 2022-07-26 03:26:39, "Rohith Iyer" wrote:
>Add writeback support to modetest with the below options:
>+ case 'o':
>+ pipe_args->dump = true;
>+ dump_path = optarg;
>+ break;
> case 'P':
>
Hi Miquel:
Thanks for your work here.
A discussion about the grf write macro bellow.
On 12/14/19 2:10 AM, Miquel Raynal wrote:
Introduce PX30 LVDS support. This means adding the relevant helper
functions, a specific probe and also the initialization of a specific
PHY.
Signed-off-by: Miquel Ra
Hi:
I tested it on a rk3399 board, but the eDP was broken after this patch
applied:
[ 0.891873] registered taskstats version 1
[ 0.892243] Loading compiled-in X.509 certificates
[ 0.929147] rockchip-dp ff97.edp: no DP phy configured
[ 0.931676] random: fast init done
[ 0.9
Hi Marek:
On 3/5/20 5:03 PM, Andy Yan wrote:
Hi:
I tested it on a rk3399 board, but the eDP was broken after this patch
applied:
[ 0.891873] registered taskstats version 1
[ 0.892243] Loading compiled-in X.509 certificates
[ 0.929147] rockchip-dp ff97.edp: no DP phy
drm] Initialized exynos 1.1.0 20180330 for exynos-drm on minor 1
...
Signed-off-by: Marek Szyprowski
Acked-by: Andy Yan
---
v2:
- moved plat_data initialization to exynos_dp_probe/rockchip_dp_probe as
pointed by Andy Yan
---
.../drm/bridge/analogix/analogix_dp_core.c|
When iommu itself is disabled in dts, we should
fallback to non-iommu buffer, check iommu parent
is meanless here.
Signed-off-by: Andy Yan
---
drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rockchip
Hi:
On 2016å¹´11æ25æ¥ 07:26, Laurent Pinchart wrote:
> Hello Fabio and Vladimir,
>
> Thank you for your quick responses.
>
> On Friday 25 Nov 2016 00:16:00 Vladimir Zapolskiy wrote:
>> On 11/25/2016 12:07 AM, Fabio Estevam wrote:
>>> On Thu, Nov 24, 2016 at 7:16 PM, Laurent Pinchart wrote:
>>>
Hi:
On 2016å¹´11æ26æ¥ 03:26, Laurent Pinchart wrote:
> Hi Philipp,
>
> On Friday 25 Nov 2016 17:08:13 Philipp Zabel wrote:
>> Am Freitag, den 25.11.2016, 17:45 +0200 schrieb Laurent Pinchart:
>>> On Friday 25 Nov 2016 10:56:55 Philipp Zabel wrote:
Am Donnerstag, den 24.11.2016, 23:16 +020
Hi Alex:
On 7/20/20 10:46 PM, Alex Bee wrote:
Hi Andy,
Am 20.07.20 um 10:22 schrieb Andy Yan:
Hi Alex:
On 7/19/20 4:03 AM, Alex Bee wrote:
This patch adds dither_up, dsp_lut_en, data_blank and dsp_data_swap
registers to enable their respective functionality for RK3188's VOP.
Signed-o
Hi Alex:
On 7/19/20 4:03 AM, Alex Bee wrote:
This patch adds dither_up, dsp_lut_en, data_blank and dsp_data_swap
registers to enable their respective functionality for RK3188's VOP.
Signed-off-by: Alex Bee
---
drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 4
1 file changed, 4 insertion
ping
On 7/3/20 5:45 PM, Andy Yan wrote:
Add a function to look up a connector by
device tree node, like what of_drm_find_bridge/panel
does.
Signed-off-by: Andy Yan
Reported-by: kernel test robot
---
Changes in v2:
- Add function declaration
drivers/gpu/drm/drm_connector.c | 33
Add a function to look up a connector by
device tree node, like what of_drm_find_bridge/panel
does.
Signed-off-by: Andy Yan
---
drivers/gpu/drm/drm_connector.c | 33 +
include/drm/drm_connector.h | 3 +++
2 files changed, 36 insertions(+)
diff --git a
Add a function to look up a connector by
device tree node, like what of_drm_find_bridge/panel
does.
Signed-off-by: Andy Yan
Reported-by: kernel test robot
---
Changes in v2:
- Add function declaration
drivers/gpu/drm/drm_connector.c | 33 +
include/drm
Add our HDMI driver owner Algea to list.
On 9/22/20 2:18 AM, Vicente Bergas wrote:
Under certain conditions vop_crtc_mode_fixup rounds the clock
14850 to 148501000 which leads to the following error:
dwhdmi-rockchip ff94.hdmi: PHY configuration failed (clock 148501000)
The issue was fou
Hi Vladimir,
Thanks for you patch.
On 2015å¹´05æ18æ¥ 20:32, Vladimir Zapolskiy wrote:
> I2CM_ADDRESS became a MESS, fix it, also change guarding define
> to __DW_HDMI_H__ , since the driver is not IMX specific.
>
> Signed-off-by: Vladimir Zapolskiy
Acked-by: Andy Yan
>
From: Andy yan
We found freescale imx6 and rockchip rk3288 and Ingenic JZ4780 (Xburst/MIPS)
use the interface compatible Designware HDMI IP, but they also have some
lightly difference, such as phy pll configuration, register width(imx hdmi
register is one byte, but rk3288 is 4 bytes width and
On 2014å¹´11æ04æ¥ 22:29, Russell King - ARM Linux wrote:
> On Tue, Nov 04, 2014 at 09:33:10PM +0800, Andy Yan wrote:
>> From: Andy yan
>>
>> We found freescale imx6 and rockchip rk3288 and Ingenic JZ4780 (Xburst/MIPS)
>> use the interface compatible Designware HDMI
Hi ZubairLK:
On 2014å¹´11æ04æ¥ 21:50, Zubair Lutfullah Kakakhel wrote:
> Hi,
>
> On 04/11/14 13:39, Andy Yan wrote:
>> From: Andy yan
>>
>> the original imx hdmi driver is under staging/imx-drm,
>> which depends on imx-drm, so move the imx hdmi drvier out
>
er(pdev);
+}
+
+static struct platform_driver imx_hdmi_imx_pltfm_driver = {
+ .probe = imx_hdmi_imx_probe,
+ .remove = imx_hdmi_imx_remove,
+ .driver = {
+ .name = "dwhdmi-imx",
+ .owner = THIS_MODULE,
+ .of_match_table = imx_hdmi_imx
From: Andy yan
the original imx hdmi driver is under staging/imx-drm,
which depends on imx-drm, so move the imx hdmi drvier out
to drm/bridge and rename imx-hdmi to dw-hdmi
Change-Id: I5f417372f256aa26cd00a3cd0160741680afd39d
---
drivers/gpu/drm/bridge/Kconfig|5 +
drivers/gpu/drm
l add rockchip
platform specific code dw_hdmi-rockchip.c later, this is depend
on drm-rockchip.
Changes in V2:
- use git format-patch -M to generate these patch
- remove change-id
- remove from
Andy Yan (2):
imx-drm: imx-hdmi: split imx soc specific code from imx-hdmi
move imx-hdmi to bridge/dw
, but rk3288 does),
clk useage,and the crtc mux configuration is also platform specific.
To reuse the imx hdmi driver, split the platform specific code out
to dw_hdmi-imx.c.
Signed-off-by: Andy Yan
---
drivers/staging/imx-drm/Makefile | 2 +-
drivers/staging/imx-drm/dw_hdmi-imx.c
the original imx hdmi driver is under staging/imx-drm,
which depends on imx-drm, so move the imx hdmi drvier out
to drm/bridge and rename imx-hdmi to dw-hdmi
Signed-off-by: Andy Yan
---
drivers/gpu/drm/bridge/Kconfig | 5 +
drivers/gpu/drm/bridge/Makefile
, but rk3288 does),
clk useage,and the crtc mux configuration is also platform specific.
To reuse the imx hdmi driver, split the platform specific code out
to dw_hdmi-imx.c.
Signed-off-by: Andy Yan
---
drivers/staging/imx-drm/Makefile | 2 +-
drivers/staging/imx-drm/dw_hdmi-imx.c
the original imx hdmi driver is under staging/imx-drm,
which depends on imx-drm, so move the imx hdmi drvier out
to drm/bridge and rename imx-hdmi to dw-hdmi
Signed-off-by: Andy Yan
---
drivers/gpu/drm/bridge/Kconfig | 5 +
drivers/gpu/drm/bridge/Makefile
From: ykk
dw-hdmi is under drm/bridge, so it should be the bridge mode.
hange off the encoder to dw_hdmi-imx.c, keep the connector &
birdge in dw_hdmi.c
Signed-off-by: ykk
Signed-off-by: Andy Yan
---
drivers/gpu/drm/bridge/dw_hdmi.c | 228 +++---
dri
On rockchip rk3288, only word(32-bit) accesses are
permitted for hdmi registers. Byte width access (writeb,
readb) generate an imprecise external abort.
Signed-off-by: Andy Yan
---
drivers/gpu/drm/bridge/dw_hdmi.c | 53
1 file changed, 48 insertions
ormat-patch -M to generate these patch
- remove change-id
- remove from
Andy Yan (3):
imx-drm: imx-hdmi: split imx soc specific code from imx-hdmi
dw-hdmi: move imx-hdmi to bridge/dw-hdmi
dw-hdmi: add support for multi byte register width access
ykk (1):
dw-hdmi: convert dw-hdmi to drm_bridge
hdmi driver, split the platform specific code out
to dw_hdmi-imx.c.
Signed-off-by: Andy Yan
---
drivers/staging/imx-drm/Makefile | 2 +-
drivers/staging/imx-drm/dw_hdmi-imx.c | 214
drivers/staging/imx-drm/imx-hdmi.c| 257
On 2014å¹´11æ05æ¥ 21:41, Philipp Zabel wrote:
> Hi Andy,
>
> I think separating the core from the SoC specific part is a good step
> into the right direction.
>
> Am Mittwoch, den 05.11.2014, 20:55 +0800 schrieb Andy Yan:
>> imx6 and rockchip rk3288 and JZ4780 (Ingenic
eg_shift))
> + dev_warn(hdmi->dev, "No reg-shift\n");
>
> This way the reg-shift property can be defined using DT
rk3288 can only access the register by 32bits(readl/writel), byte access
will causes an
imprecise external abort.
I have refactor the register access in PATCH V3,
hdmi driver, split the platform specific code out
to dw_hdmi-imx.c.
Signed-off-by: Andy Yan
---
drivers/staging/imx-drm/Makefile | 2 +-
drivers/staging/imx-drm/dw_hdmi-imx.c | 214
drivers/staging/imx-drm/imx-hdmi.c| 257
the original imx hdmi driver is under staging/imx-drm,
which depends on imx-drm, so move the imx hdmi drvier out
to drm/bridge and rename imx-hdmi to dw-hdmi
Signed-off-by: Andy Yan
---
drivers/gpu/drm/bridge/Kconfig | 5 +
drivers/gpu/drm/bridge/Makefile
drm driver may probe before the i2c bus, so the driver should
defer probing untill it is avaliable
Signed-off-by: Andy Yan
---
drivers/gpu/drm/bridge/dw_hdmi.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge
On 2014å¹´11æ07æ¥ 19:45, Lucas Stach wrote:
> Am Freitag, den 07.11.2014, 19:35 +0800 schrieb Andy Yan:
>> On rockchip rk3288, only word(32-bit) accesses are
>> permitted for hdmi registers. Byte width access (writeb,
>> readb) generates an imprecise external abort.
>
.]
+ else {
[...]
Signed-off-by: Andy Yan
---
drivers/gpu/drm/bridge/dw_hdmi.c | 97
1 file changed, 48 insertions(+), 49 deletions(-)
diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw_hdmi.c
index 527014b..df52921 100644
--- a/drivers
On 2014å¹´11æ06æ¥ 23:54, Greg Kroah-Hartman wrote:
> On Thu, Nov 06, 2014 at 07:26:16PM +0800, Andy Yan wrote:
>> From: ykk
> We need a "real" name here, sorry.
>
>> dw-hdmi is under drm/bridge, so it should be the bridge mode.
>> hange off the encoder
dge driver
Changes in V2:
- use git format-patch -M to generate these patch
- remove change-id
- remove from
Andy Yan (5):
imx-drm: imx-hdmi: split imx soc specific code from imx-hdmi
dw-hdmi: move imx-hdmi to bridge/dw-hdmi
dw-hdmi: make checkpatch happy
dw-hdmi: return defer if can
.]
+ else {
[...]
Signed-off-by: Andy Yan
---
drivers/gpu/drm/bridge/dw_hdmi.c | 99
1 file changed, 49 insertions(+), 50 deletions(-)
diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw_hdmi.c
index e561286..693a379 100644
--- a/drivers
On rockchip rk3288, only word(32-bit) accesses are
permitted for hdmi registers. Byte width access (writeb,
readb) generates an imprecise external abort.
Signed-off-by: Andy Yan
---
drivers/gpu/drm/bridge/dw_hdmi.c | 49 +---
1 file changed, 46 insertions
From: Yakir Yang
dw-hdmi is under drm/bridge, so it should be the bridge mode.
hange off the encoder to dw_hdmi-imx.c, keep the connector &
birdge in dw_hdmi.c
Signed-off-by: Andy Yan
Signed-off-by: Yakir Yang
---
drivers/gpu/drm/bridge/dw_hdmi.c |
and split it
to one indepent patch
- convert it to a drm_bridge driver
Changes in V2:
- use git format-patch -M to generate these patch
- remove change-id
- remove from
Andy Yan (6):
imx-drm: imx-hdmi: split imx soc specific code from imx-hdmi
dw-hdmi: move imx-hdmi to bridge/dw-hdmi
dw-
hdmi driver, split the platform specific code out
to dw_hdmi-imx.c.
Signed-off-by: Andy Yan
---
drivers/staging/imx-drm/Makefile | 2 +-
drivers/staging/imx-drm/dw_hdmi-imx.c | 214
drivers/staging/imx-drm/imx-hdmi.c| 257
drm driver may probe before the i2c bus, so the driver should
defer probing untill it is avaliable
Signed-off-by: Andy Yan
---
drivers/gpu/drm/bridge/dw_hdmi.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge
On rockchip rk3288, only word(32-bit) accesses are
permitted for hdmi registers. Byte width accesses (writeb,
readb) generate an imprecise external abort.
Signed-off-by: Andy Yan
---
drivers/gpu/drm/bridge/dw_hdmi.c | 57 ++--
1 file changed, 55 insertions
Signed-off-by: Andy Yan
---
.../devicetree/bindings/drm/bridge/dw-hdmi.txt | 38 ++
1 file changed, 38 insertions(+)
create mode 100644 Documentation/devicetree/bindings/drm/bridge/dw-hdmi.txt
diff --git a/Documentation/devicetree/bindings/drm/bridge/dw-hdmi.txt
b
the original imx hdmi driver is under staging/imx-drm,
which depends on imx-drm, so move the imx hdmi drvier out
to drm/bridge and rename imx-hdmi to dw-hdmi
Signed-off-by: Andy Yan
---
drivers/gpu/drm/bridge/Kconfig | 5 +
drivers/gpu/drm/bridge/Makefile
From: Yakir Yang
dw-hdmi is under drm/bridge, so it should be the bridge mode.
hange off the encoder to dw_hdmi-imx.c, keep the connector &
birdge in dw_hdmi.c
Signed-off-by: Andy Yan
Signed-off-by: Yakir Yang
---
drivers/gpu/drm/bridge/dw_hdmi.c |
s
> patches. No patch should add a checkpatch error and then fix it in a later
> patch.
>
> Regards
> ZubairLK
I use checkpatch with --subjective
> On 08/11/14 05:29, Andy Yan wrote:
>> CHECK: Alignment should match open parenthesis
>> + if ((hdmi->vic == 10)
On 2014å¹´11æ10æ¥ 17:53, Zubair Lutfullah Kakakhel wrote:
>
> On 10/11/14 09:44, Andy Yan wrote:
>> Hi ZubairLK
>> On 2014å¹´11æ10æ¥ 17:17, Zubair Lutfullah Kakakhel wrote:
>>> Nice work.
>>>
>>> This patch should move the binding from
>>
On rockchip rk3288, only word(32-bit) accesses are
permitted for hdmi registers. Byte width accesses (writeb,
readb) generate an imprecise external abort.
Signed-off-by: Andy Yan
---
Changes in v6:
- move some modification to patch#6
- refactor register access without reg_shift
Changes in
Hi Zubair:
thanks very much for your comments.
On 2014å¹´11æ10æ¥ 18:51, Zubair Lutfullah Kakakhel wrote:
> Hi Andy,
>
> A few comments inline.
>
> On 08/11/14 05:28, Andy Yan wrote:
>> imx6 and rockchip rk3288 and JZ4780 (Ingenic Xburst/MIPS)
>> use the interface
s
> patches. No patch should add a checkpatch error and then fix it in a later
> patch.
>
> Regards
> ZubairLK
i use checkpatch with --subjective
> On 08/11/14 05:29, Andy Yan wrote:
>> CHECK: Alignment should match open parenthesis
>> + if ((hdmi->vic == 10)
From: Yakir Yang
handle encoder in dw_hdmi-imx.c, keep the connector &
birdge in dw_hdmi.c
Signed-off-by: Andy Yan
Signed-off-by: Yakir Yang
---
Changes in v6:
- move some modification from patch#5
Changes in v5: None
Changes in v4: None
Changes in v3: None
Changes in v2: None
dri
specific , they are handled by the platform code like dw_hdmi-imx.c
and described in platform specific dt binds like /imx-drm/hdmi.txt
> On 08/11/14 05:32, Andy Yan wrote:
>> Signed-off-by: Andy Yan
>> ---
>> .../devicetree/bindings/drm/bridge/dw-hdmi.txt | 38
>
width
Changes in v4:
- fix checkpatch CHECK
- defer probe ddc i2c adapter
Changes in v3:
- split multi register access to one indepent patch
Changes in v2:
- use git format -M to generate these patch
Andy Yan (6):
staging: imx-drm: imx-hdmi: make checkpatch happy
staging: imx-drm: imx-hdmi: return
the original imx hdmi driver is under staging/imx-drm,
which depends on imx-drm, so move the imx hdmi drvier out
to drm/bridge and rename imx-hdmi to dw-hdmi
Signed-off-by: Andy Yan
---
Changes in v6: None
Changes in v5: None
Changes in v4: None
Changes in v3: None
Changes in v2:
- use git
From: Yakir Yang
keep the connector & birdge in dw_hdmi.c, handle encoder in dw_hdmi-imx.c
Signed-off-by: Andy Yan
Signed-off-by: Yakir Yang
---
Changes in v7: None
Changes in v6:
- move some modification from patch#5
Changes in v5: None
Changes in v4: None
Changes in v3: None
Change
es in v2:
- use git format -M to generate these patch
Andy Yan (6):
staging: imx-drm: imx-hdmi: make checkpatch happy
staging: imx-drm: imx-hdmi: return defer if can't get ddc i2c adapter
staging: imx-drm: imx-hdmi: split imx soc specific code from imx-hdmi
staging: imx-drm: imx-hdmi
On rockchip rk3288, only word(32-bit) accesses are
permitted for hdmi registers. Byte width accesses (writeb,
readb) generate an imprecise external abort.
Signed-off-by: Andy Yan
---
Changes in v7: None
Changes in v6:
- move some modification to patch#6
- refactor register access without
es in v2:
- use git format -M to generate these patch
Andy Yan (6):
staging: imx-drm: imx-hdmi: make checkpatch happy
staging: imx-drm: imx-hdmi: return defer if can't get ddc i2c adapter
staging: imx-drm: imx-hdmi: split imx soc specific code from imx-hdmi
staging: imx-drm: imx-hdmi
.]
+ else {
[...]
Signed-off-by: Andy Yan
---
Changes in v7: None
Changes in v6:
- rearrange the patch order
Changes in v5: None
Changes in v4:
- fix checkpatch CHECK
Changes in v3: None
Changes in v2: None
drivers/staging/imx-drm/imx-hdmi.c | 97 +++---
1 f
drm driver may probe before the i2c bus, so the driver should
defer probing until it is available
Signed-off-by: Andy Yan
---
Changes in v7: None
Changes in v6: None
Changes in v5: None
Changes in v4:
- defer probe ddc i2c adapter
Changes in v3: None
Changes in v2: None
drivers/staging/imx
hdmi driver, split the platform specific code out
to dw_hdmi-imx.c.
Signed-off-by: Andy Yan
---
Changes in v7:
- remove unused variables from structure dw_hdmi
- remove a wrong modification
- add copyrights for dw_hdmi-imx.c
Changes in v6: None
Changes in v5: None
Changes in v4: None
Changes
1 - 100 of 843 matches
Mail list logo
