Re: [PATCH][next] drm/amd/display: Remove redundant initialization of variable result

2021-10-07 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Oct 7, 2021 at 8:06 AM Colin King wrote: > > From: Colin Ian King > > The variable result is being initialized with a value that is never > read, it is being updated immediately afterwards in both branches > of an if statement. The assignment is redundant and can

Re: [PATCH] drm/amd/pm: Replace one-element array with flexible-array member

2022-01-14 Thread Alex Deucher
Applied. Thanks! On Fri, Jan 14, 2022 at 4:20 AM wrote: > > From: Changcheng Deng > > There is a regular need in the kernel to provide a way to declare having > a dynamically sized set of trailing elements in a structure. Kernel code > should always use "flexible array members" for these cases.

Re: [PATCH] drm/amd/display: Remove redundant initialization of dpg_width

2022-01-14 Thread Alex Deucher
Applied. Thanks! On Fri, Jan 14, 2022 at 5:44 AM Jiapeng Chong wrote: > > dpg_width is being initialized to width but this is never read > as dpg_width is overwritten later on. Remove the redundant > initialization. > > Cleans up the following clang-analyzer warning: > > drivers/gpu/drm/amd/amdg

Re: [PATCH] drm/amdgpu: Add missing pm_runtime_put_autosuspend

2022-01-18 Thread Alex Deucher
Applied. Strangely I can't seem to find this patch in my inbox or in the dri-devel or amd-gfx archives. Alex On Tue, Jan 18, 2022 at 9:03 AM Lazar, Lijo wrote: > > > > On 1/18/2022 5:31 PM, Yongzhi Liu wrote: > > pm_runtime_get_sync() increments the runtime PM usage counter even > > when it ret

Re: [PATCH] drm/radeon: fix UVD suspend error

2022-01-18 Thread Alex Deucher
Applied. Thanks! On Mon, Jan 17, 2022 at 3:05 PM Leo Liu wrote: > > > On 2022-01-17 2:47 a.m., Qiang Ma wrote: > > I met a bug recently and the kernel log: > > > > [ 330.171875] radeon :03:00.0: couldn't schedule ib > > [ 330.175781] [drm:radeon_uvd_suspend [radeon]] *ERROR* Error destroyi

Re: [PATCH] amdgpu/amdgpu_psp: remove unneeded ret variable

2022-01-18 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Jan 18, 2022 at 2:57 AM wrote: > > From: Minghao Chi > > Return value from amdgpu_bo_create_kernel() directly instead > of taking this in another redundant variable. > > Reported-by: Zeal Robot > Signed-off-by: Minghao Chi > Signed-off-by: CGEL ZTE > --- > dri

[pull] amdgpu, radeon drm-fixes-5.17

2022-01-19 Thread Alex Deucher
SR-IOV fix - VCN harvest fix - Suspend/resume fixes - Tahiti fix - Enable GPU recovery on yellow carp radeon: - Fix error handling regression in radeon_driver_open_kms ---- Alex Deucher (3): drm/amdgpu: invert th

Re: [PATCH] drm/amd/amdgpu/amdgpu_cs: fix refcount leak of a dma_fence obj

2022-01-21 Thread Alex Deucher
On Fri, Jan 21, 2022 at 2:45 AM Christian König wrote: > > Am 21.01.22 um 06:28 schrieb Xin Xiong: > > This issue takes place in an error path in > > amdgpu_cs_fence_to_handle_ioctl(). When `info->in.what` falls into > > default case, the function simply returns -EINVAL, forgetting to > > decremen

Re: [PATCH] drm/amd/pm: remove useless if

2022-01-21 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Jan 21, 2022 at 6:48 AM Jiapeng Chong wrote: > > Clean the following coccicheck warning: > > ./drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c:7035:2-4: WARNING: possible > condition with no effect (if == else). > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Cho

Re: [PATCH] drm/amd/display/dc/calcs/dce_calcs: Fix a memleak in calculate_bandwidth()

2022-01-24 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Jan 24, 2022 at 12:05 PM Zhou Qingyang wrote: > > In calculate_bandwidth(), the tag free_sclk and free_yclk are reversed, > which could lead to a memory leak of yclk. > > Fix this bug by changing the location of free_sclk and free_yclk. > > This bug was found by a

Re: [PATCH] drm/amd/display: Fix a NULL pointer dereference in amdgpu_dm_connector_add_common_modes()

2022-01-24 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Jan 24, 2022 at 12:05 PM Zhou Qingyang wrote: > > In amdgpu_dm_connector_add_common_modes(), amdgpu_dm_create_common_mode() > is assigned to mode and is passed to drm_mode_probed_add() directly after > that. drm_mode_probed_add() passes &mode->head to list_add_tail

Re: [PATCH v2] drm/amd/pm: return -ENOTSUPP if there is no get_dpm_ultimate_freq function

2022-01-24 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Jan 24, 2022 at 3:18 PM wrote: > > From: Tom Rix > > clang static analysis reports this represenative problem > amdgpu_smu.c:144:18: warning: The left operand of '*' is a garbage value > return clk_freq * 100; > ^ > > If there is no

Re: [PATCH] drm/radeon: remove redundant assignment to reg

2022-01-24 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Jan 24, 2022 at 3:21 PM Nick Desaulniers wrote: > > On Wed, Jan 19, 2022 at 2:46 PM Colin Ian King wrote: > > > > The pointer reg is being assigned a value that is not read, the > > exit path via label 'out' never accesses it. The assignment is > > redundant and c

Re: [PATCH -next] drm/amd/display: don't use /** for non-kernel-doc comments

2022-01-24 Thread Alex Deucher
_link_dp.c:4343: warning: > > expecting prototype for Return PCON's post FRL link training supported BW > > if its non(). Prototype was for intersect_frl_link_bw_support() instead > > > > Fixes: c022375ae095 ("drm/amd/display: Add DP-HDMI FRL PCON Support in DC&qu

Re: [PATCH] drm/docs: Document where the C8 color lut is stored

2022-01-24 Thread Alex Deucher
rd > Cc: Thomas Zimmermann > Cc: David Airlie > Cc: Daniel Vetter > Signed-off-by: Daniel Vetter Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/drm_color_mgmt.c | 4 > include/drm/drm_crtc.h | 10 ++ > 2 files changed, 14 inserti

[pull] amdgpu drm-fixes-5.17

2022-01-26 Thread Alex Deucher
- DCN3.01 fixes - Filter out secondary radeon PCI IDs - udelay fixes - Fix a memory leak in an error path Alex Deucher (3): drm/amdgpu: filter out radeon secondary ids as well drm/amdgpu/display: adjust msleep limit in

Re: [PATCH] drm/amdgpu: fix that issue that the number of the crtc of the 3250c is not correct

2022-01-27 Thread Alex Deucher
Please use C style comments /* */. WIth that fixed: Reviewed-by: Alex Deucher On Thu, Jan 27, 2022 at 3:12 AM RyanLin wrote: > > [Why] > External displays take priority over internal display when there are fewer > display controllers than displays. > > [How] > The roo

Re: [PATCH] drm/amd/amdgpu: fix spelling mistake "disbale" -> "disable"

2022-01-27 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Jan 27, 2022 at 3:45 AM tangmeng wrote: > > There is a spelling mistake. Fix it. > > Signed-off-by: tangmeng > --- > drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/mxgpu_vi

Re: [PATCH] drm/amdgpu: Wrong order for config and counter_id parameters

2022-01-27 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Jan 26, 2022 at 4:48 AM wrote: > > From: huangqu > > Wrong order for config and counter_id parameters was passed, when calling > df_v3_6_pmc_set_deferred and df_v3_6_pmc_is_deferred functions. > > Signed-off-by: huangqu > --- > drivers/gpu/drm/amd/amdgpu/df_v3_

Re: [PATCH] drm/amdgpu: remove duplicate include in 'amdgpu_device.c'

2022-01-28 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Jan 28, 2022 at 2:05 AM wrote: > > From: Changcheng Deng > > 'linux/pci.h' included in 'amdgpu_device.c' is duplicated. > > Reported-by: Zeal Robot > Signed-off-by: Changcheng Deng > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 - > 1 file changed, 1 de

Re: [PATCH] drm/amd/pm: remove duplicate include in 'arcturus_ppt.c'

2022-01-28 Thread Alex Deucher
Applied. thanks! Alex On Fri, Jan 28, 2022 at 2:19 AM wrote: > > From: Changcheng Deng > > 'amdgpu_dpm.h' included in 'arcturus_ppt.c' is duplicated. > > Reported-by: Zeal Robot > Signed-off-by: Changcheng Deng > --- > drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c | 1 - > 1 file change

Re: [PATCH][next] drm/amd/display: fix spelling mistake: synatpics -> synaptics

2022-01-28 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Jan 28, 2022 at 12:59 PM Harry Wentland wrote: > > > > On 2022-01-28 12:35, Colin Ian King wrote: > > There are quite a few spelling mistakes in various function names > > and error messages. Fix these. > > > > Signed-off-by: Colin Ian King > > Reviewed-by: Harry

Re: [PATCH] drm/nouveau/acr: Fix undefined behavior in nvkm_acr_hsfw_load_bl()

2022-01-28 Thread Alex Deucher
On Fri, Jan 28, 2022 at 2:20 PM Lyude Paul wrote: > > Sigh-thank you for catching this - I had totally forgot about the umn.edu ban. > I pushed this already but I will go ahead and send a revert for this patch. > Will cc you on it as well. This seems short-sighted. If the patch is valid I see no

Re: [PATCH] drm/nouveau/acr: Fix undefined behavior in nvkm_acr_hsfw_load_bl()

2022-01-28 Thread Alex Deucher
On Fri, Jan 28, 2022 at 2:58 PM Karol Herbst wrote: > > On Fri, Jan 28, 2022 at 8:54 PM Alex Deucher wrote: > > > > On Fri, Jan 28, 2022 at 2:20 PM Lyude Paul wrote: > > > > > > Sigh-thank you for catching this - I had totally forgot about the umn.edu > &

Re: [PATCH -next] drm/amd/display: clean up some inconsistent indenting

2022-01-31 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Jan 31, 2022 at 10:17 AM Harry Wentland wrote: > > On 2022-01-28 20:04, Yang Li wrote: > > Eliminate the follow smatch warning: > > drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c:2246 > > dp_perform_8b_10b_link_training() warn: inconsistent indenting > > > > Repo

[PATCH] drm/amdgpu/display: fix build when CONFIG_DRM_AMD_DC_DCN is not set

2021-10-27 Thread Alex Deucher
Need to guard some things with CONFIG_DRM_AMD_DC_DCN. Fixes: 41724ea273cdda ("drm/amd/display: Add DP 2.0 MST DM Support") Signed-off-by: Alex Deucher Cc: Lyude Paul Cc: Dave Airlie --- Lyude, can you apply this to topic/amdgpu-dp2.0-mst? or Dave, if it's already pulled can yo

[pull] amdgpu drm-fixes-5.15

2021-10-27 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.15. The following changes since commit defbbcd99fa68cb7feed453662048baa87e9a441: Merge tag 'amd-drm-fixes-5.15-2021-10-21' of https://gitlab.freedesktop.org/agd5f/linux into drm-fixes (2021-10-27 10:01:21 +1000) are available in the Git repository at: https:/

Re: linux-next: manual merge of the amdgpu tree with the drm tree

2021-10-27 Thread Alex Deucher
On Wed, Oct 27, 2021 at 11:06 PM Stephen Rothwell wrote: > > Hi all, > > Today's linux-next merge of the amdgpu tree got conflicts in: > > drivers/gpu/drm/amd/display/dc/core/dc_link.c > drivers/gpu/drm/drm_dp_mst_topology.c > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > between com

Re: [PATCH] MAINTAINERS: dri-devel is for all of drivers/gpu

2021-10-28 Thread Alex Deucher
l/ > Signed-off-by: Daniel Vetter > Cc: David Airlie > Cc: Daniel Vetter > Cc: Steven Rostedt Reviewed-by: Alex Deucher > --- > MAINTAINERS | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 98aa1f55ed41.

[pull] amdgpu, amdkfd drm-next-5.16

2021-10-29 Thread Alex Deucher
cleanup UAPI: - Minor header cleanup (no functional change) Ahmad Othman (2): drm/amd/display: Add support for USB4 on C20 PHY for DCN3.1 drm/amd/display: fix a crash on USB4 over C20 PHY Alex Deucher (6): drm/amdgpu

Re: [PATCH 01/13] drm/connector: Add define for HDMI 1.4 Maximum Pixel Rate

2021-11-02 Thread Alex Deucher
display/intel_hdmi.c | 2 +- > drivers/gpu/drm/meson/meson_dw_hdmi.c | 4 ++-- > drivers/gpu/drm/radeon/radeon_encoders.c | 2 +- For radeon: Acked-by: Alex Deucher Note that there are several instances of this in amdgpu as well: drivers/gpu/drm/amd/amdgpu/amdgpu_encoders.c:

Re: [PATCH] drm/amd/display: remove unnecessary conditional operators

2021-11-02 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Nov 2, 2021 at 4:58 AM Simon Ser wrote: > > Reviewed-by: Simon Ser

[pull] amdgpu, amdkfd drm-fixes-5.16

2021-11-03 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.16. The following changes since commit d9bd054177fbd2c4762546aec40fc3071bfe4cc0: Merge tag 'amd-drm-next-5.16-2021-10-29' of https://gitlab.freedesktop.org/agd5f/linux into drm-next (2021-11-02 12:40:58 +1000) are available in the Git repository at: https://g

Re: [PATCH] drm/radeon: correct indentation

2021-11-10 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Nov 10, 2021 at 11:08 AM Xu Wang wrote: > > Correct indentation in radeon_driver_load_kms. > > Signed-off-by: Xu Wang > --- > drivers/gpu/drm/radeon/radeon_kms.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/radeon/radeo

Re: [PATCH] drm/amdgpu: remove unneeded variable

2021-11-10 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Nov 10, 2021 at 12:53 AM wrote: > > From: ran jianping > > Fix the following coccicheck review: > ./drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c:1174:14-18 > :Unneeded variable > > Remove unneeded variable used to store return value. > > Reported-by: Ze

[pull] amdgpu, amdkfd drm-fixes-5.16

2021-11-10 Thread Alex Deucher
from user for DC debugfs - SRIOV fixes - GFX9 CSB pin count fix - Various IP version check fixes - DP 2.0 fixes - Limit DCN1 MPO fix to DCN1 amdkfd: - SVM fixes - Reset fixes Alex Deucher (2): drm/amdgpu/powerplay: fix sysfs

Re: [PATCH] drm/amdgpu: fix set scaling mode Full/Full aspect/Center not works on vga and dvi connectors

2021-11-12 Thread Alex Deucher
Applied. Thanks! On Wed, Nov 10, 2021 at 10:54 PM hongao wrote: > > amdgpu_connector_vga_get_modes missed function amdgpu_get_native_mode > which assign amdgpu_encoder->native_mode with *preferred_mode result in > amdgpu_encoder->native_mode.clock always be 0. That will cause > amdgpu_connector_

Re: [PATCH] drm/amd/display: Clean up some inconsistent indenting

2021-11-12 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Nov 11, 2021 at 5:09 AM Christian König wrote: > > > > Am 11.11.21 um 11:03 schrieb Jiapeng Chong: > > Eliminate the follow smatch warning: > > > > drivers/gpu/drm/amd/amdgpu/../display/dmub/src/dmub_srv.c:622 > > dmub_srv_cmd_execute() warn: inconsistent indenting

Re: [PATCH] drm/amd/display: fix cond_no_effect.cocci warnings

2021-11-12 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Nov 12, 2021 at 1:17 AM wrote: > > From: Ye Guojin > > This was found by coccicheck: > ./drivers/gpu/drm/amd/display/dc/core/dc_resource.c, 2516, 7-9, WARNING > possible condition with no effect (if == else) > > hdmi_info.bits.YQ0_YQ1 is always YYC_QUANTIZATION_LI

Re: Backlight control broken on UM325 (OLED) on 5.15 (bisected)

2021-11-15 Thread Alex Deucher
HEAD, refs/bisect/bad) > Author: Alex Deucher > Date: Thu Jul 8 16:31:10 2021 -0400 > > drm/amdgpu/display: add support for multiple backlights > > On platforms that support multiple backlights, register > each one separately. This lets us manag

Re: Questions about KMS flip

2021-11-16 Thread Alex Deucher
On Tue, Nov 16, 2021 at 3:09 AM Christian König wrote: > > Am 16.11.21 um 09:00 schrieb Lang Yu: > > On Tue, Nov 16, 2021 at 08:14:08AM +0100, Christian KKKnig wrote: > >> Am 16.11.21 um 04:27 schrieb Lang Yu: > >>> On Mon, Nov 15, 2021 at 01:04:15PM +0100, Michel DDDnzer wrote: > [SNIP] > >>

Re: [PATCH] drm/amd/amdgpu: remove useless break after return

2021-11-17 Thread Alex Deucher
Applied thanks. If you want to make the numbering more sequential, please also update the other dce files if you make that change. Alex On Mon, Nov 15, 2021 at 2:14 AM Bernard Zhao wrote: > > This change is to remove useless break after return. > > Signed-off-by: Bernard Zhao > --- > drivers/

Re: [PATCH v2] drm/amd/amdgpu: cleanup the code style a bit

2021-11-17 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Nov 15, 2021 at 7:09 AM Bernard Zhao wrote: > > This change is to cleanup the code style a bit. > > Signed-off-by: Bernard Zhao > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 21 + > 1 file changed, 13 insertions(+), 8 deletions(-) > > dif

Re: [PATCH] drm/amd/amdgpu: fix potential memleak

2021-11-17 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Nov 15, 2021 at 10:56 AM Felix Kuehling wrote: > > Am 2021-11-14 um 9:58 p.m. schrieb Bernard Zhao: > > In function amdgpu_get_xgmi_hive, when kobject_init_and_add failed > > There is a potential memleak if not call kobject_put. > > > > Signed-off-by: Bernard Zhao

Re: [PATCH] drm/amd/display: cleanup the code a bit

2021-11-17 Thread Alex Deucher
Applied. Thanks! On Tue, Nov 16, 2021 at 4:19 AM Christian König wrote: > > Am 16.11.21 um 02:34 schrieb Bernard Zhao: > > In function dc_sink_destruct, kfree will check pointer, no need > > to check again. > > This change is to cleanup the code a bit. > > > > Signed-off-by: Bernard Zhao > > Th

Re: [PATCH] drm/amd/display: remove no need NULL check before kfree

2021-11-17 Thread Alex Deucher
Applied. Thanks! On Mon, Nov 15, 2021 at 8:48 PM Bernard Zhao wrote: > > This change is to cleanup the code a bit. > > Signed-off-by: Bernard Zhao > --- > .../drm/amd/display/dc/dcn10/dcn10_resource.c | 18 ++ > 1 file changed, 6 insertions(+), 12 deletions(-) > > diff --git a

Re: [PATCH -next] drm/amd/display: check top_pipe_to_program pointer

2021-11-17 Thread Alex Deucher
Applied. Thanks! On Mon, Nov 15, 2021 at 3:10 AM Yang Li wrote: > > Clang static analysis reports this error > > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:2870:7: warning: > Dereference of null pointer [clang-analyzer-core.NullDereference] > if > (top_pipe_to_program->st

[pull] amdgpu, amdkfd drm-fixes-5.16

2021-11-17 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.16. The following changes since commit fa55b7dcdc43c1aa1ba12bca9d2dd4318c2a0dbf: Linux 5.16-rc1 (2021-11-14 13:56:52 -0800) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-5.16-2021-11-17 for you to fe

Re: [PATCH] drm/amdgpu/pm: clean up some inconsistent indenting

2021-11-18 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Nov 18, 2021 at 5:57 AM Jiapeng Chong wrote: > > Eliminate the follow smatch warning: > > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/amd_powerplay.c:1554 > pp_asic_reset_mode_2() warn: inconsistent indenting. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng C

Re: [WARN][AMDGPU] Linux 5.15.4 with AMD Bonaire GPU

2021-11-23 Thread Alex Deucher
On Sun, Nov 21, 2021 at 9:47 AM Chris Rankin wrote: > > Hi, > > i have found this warning in my vanilla 5.15.4 kernel's dmesg log: > > [ 87.687139] [ cut here ] > [ 87.710799] WARNING: CPU: 1 PID: 1 at > drivers/gpu/drm/ttm/ttm_bo.c:409 ttm_bo_release+0x1c/0x266 [ttm] >

[pull] amdgpu, amdkfd drm-fixes-5.16

2021-11-24 Thread Alex Deucher
Alex Deucher (4): drm/amdgpu/gfx10: add wraparound gpu counter check for APUs as well drm/amdgpu/gfx9: switch to golden tsc registers for renoir+ drm/amdgpu/pm: fix powerplay OD interface drm/amd/display: update bios

Re: [PATCH v2 0/3] drm: Make DRM hashtable legacy

2021-11-29 Thread Alex Deucher
am) > > Thomas Zimmermann (3): > drm/ttm: Don't include drm_hashtab.h > drm/vmwgfx: Copy DRM hash-table code into driver > drm: Declare hashtable as legacy Series is: Acked-by: Alex Deucher > > Documentation/gpu/todo.rst| 11 + > drivers/g

Re: [PATCH 6/6] Documentation/gpu: Add DC glossary

2021-11-29 Thread Alex Deucher
On Thu, Nov 25, 2021 at 10:40 AM Rodrigo Siqueira wrote: > > In the DC driver, we have multiple acronyms that are not obvious most of > the time. This commit introduces a DC glossary in order to make it > easier to navigate through our driver. > > Signed-off-by: Rodrigo Siqueira > --- > Document

Re: [PATCH 6/6] Documentation/gpu: Add DC glossary

2021-11-30 Thread Alex Deucher
On Mon, Nov 29, 2021 at 3:48 PM wrote: > > Hi Rodrigo, > > That will really be helpful! > > I know drawing the line is a difficult problem (and can even make things > harder when searching), but maybe it would make sense to keep generic > acronyms not specific to amdgpu in a separate list. I bet

Re: [PATCH] fix a NULL pointer dereference in amdgpu_connector_lcd_native_mode()

2021-12-01 Thread Alex Deucher
On Tue, Nov 30, 2021 at 6:24 AM Zhou Qingyang wrote: > > In amdgpu_connector_lcd_native_mode(), the return value of > drm_mode_duplicate() is assigned to mode, and there is a dereference > of it in amdgpu_connector_lcd_native_mode(), which will lead to a NULL > pointer dereference on failure of dr

Re: [PATCH] drm/radeon/radeon_connectors: Fix a NULL pointer dereference in radeon_fp_native_mode()

2021-12-01 Thread Alex Deucher
On Tue, Nov 30, 2021 at 9:49 AM Zhou Qingyang wrote: > > In radeon_fp_native_mode(), the return value of drm_mode_duplicate() is > assigned to mode and there is a dereference of it in > radeon_fp_native_mode(), which could lead to a NULL pointer > dereference on failure of drm_mode_duplicate(). >

[pull] amdgpu, amdkfd drm-fixes-5.16

2021-12-01 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.16. The following changes since commit d58071a8a76d779eedab38033ae4c821c30295a5: Linux 5.16-rc3 (2021-11-28 14:09:19 -0800) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-5.16-2021-12-01 for you to fe

Re: [PATCH v2] drm/amdgpu: Fix a NULL pointer dereference in amdgpu_connector_lcd_native_mode()

2021-12-02 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Dec 2, 2021 at 11:17 AM Zhou Qingyang wrote: > > In amdgpu_connector_lcd_native_mode(), the return value of > drm_mode_duplicate() is assigned to mode, and there is a dereference > of it in amdgpu_connector_lcd_native_mode(), which will lead to a NULL > pointer der

Re: [PATCH v5] drm/radeon/radeon_kms: Fix a NULL pointer dereference in radeon_driver_open_kms()

2021-12-02 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Dec 1, 2021 at 10:16 AM Christian König wrote: > > Am 01.12.21 um 16:13 schrieb Zhou Qingyang: > > In radeon_driver_open_kms(), radeon_vm_bo_add() is assigned to > > vm->ib_bo_va and passes and used in radeon_vm_bo_set_addr(). In > > radeon_vm_bo_set_addr(), there

[pull] amdgpu, amdkfd, radeon drm-next-5.17

2021-12-02 Thread Alex Deucher
bit-fields and enums in user mode are defined in https://github.com/RadeonOpenCompute/ROCT-Thunk-Interface/blob/master/include/hsakmttypes.h Ahmad Othman (1): drm/amd/display: Secondary display goes blank on Non DCN31 Alex

[pull] amdgpu drm-fixes-5.16

2021-12-09 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.16. The following changes since commit a687efed194bdc185fd7cb33920fe8b4e60ecb9e: Merge tag 'drm-intel-fixes-2021-12-02' of git://anongit.freedesktop.org/drm/drm-intel into drm-fixes (2021-12-03 05:59:31 +1000) are available in the Git repository at: https://g

Re: Reuse framebuffer after a kexec (amdgpu / efifb)

2021-12-09 Thread Alex Deucher
On Thu, Dec 9, 2021 at 12:04 PM Guilherme G. Piccoli wrote: > > Hi all, I have a question about the possibility of reusing a framebuffer > after a regular (or panic) kexec - my case is with amdgpu (APU, aka, not > a separate GPU hardware), but I guess the question is kinda generic > hence I've loo

Re: Reuse framebuffer after a kexec (amdgpu / efifb)

2021-12-09 Thread Alex Deucher
On Thu, Dec 9, 2021 at 1:00 PM Guilherme G. Piccoli wrote: > > On 09/12/2021 14:31, Alex Deucher wrote: > > [...] > > Once the driver takes over, none of the pre-driver state is retained. > > You'll need to load the driver in the new kernel to initialize the > >

Re: Reuse framebuffer after a kexec (amdgpu / efifb)

2021-12-09 Thread Alex Deucher
On Thu, Dec 9, 2021 at 1:18 PM Guilherme G. Piccoli wrote: > > Thanks again Alex! Some comments inlined below: > > On 09/12/2021 15:06, Alex Deucher wrote: > > Not really in a generic way. It's asic and platform specific. In > > addition most modern displays requ

Re: Reuse framebuffer after a kexec (amdgpu / efifb)

2021-12-10 Thread Alex Deucher
On Fri, Dec 10, 2021 at 9:09 AM Guilherme G. Piccoli wrote: > > Thanks a lot Alex / Gerd and Thomas, very informative stuff! I'm glad > there are projects to collect/save the data and reuse after a kdump, > this is very useful. > > I'll continue my study on the atombios thing of AMD and QXL, maybe

Re: Reuse framebuffer after a kexec (amdgpu / efifb)

2021-12-10 Thread Alex Deucher
On Fri, Dec 10, 2021 at 9:25 AM Guilherme G. Piccoli wrote: > > On 10/12/2021 11:16, Alex Deucher wrote:> [...] > > Why not just reload the driver after kexec? > > > > Alex > > Because the original issue is the kdump case, and we want a very very > tiny kerne

Re: Reuse framebuffer after a kexec (amdgpu / efifb)

2021-12-10 Thread Alex Deucher
On Fri, Dec 10, 2021 at 10:24 AM Guilherme G. Piccoli wrote: > > On 10/12/2021 12:13, Christian König wrote: > > [...] > > How about issuing a PCIe reset and re-initializing the ASIC with just > > the VBIOS? > > > > That should be pretty straightforward I think. > > > > Christian. > > > Thanks Chr

[pull] amdgpu, amdkfd drm-next-5.17

2021-12-10 Thread Alex Deucher
Alex Deucher (1): drm/amdgpu: handle SRIOV VCN revision parsing Anthony Koo (2): drm/amd/display: [FW Promotion] Release 0.0.95 drm/amd/display: [FW Promotion] Release 0.0.96 Aric Cyr (2): drm/amd/display: 3.2.164

Re: [PATCH] drm:amdgpu:remove unneeded variable

2021-12-13 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Dec 9, 2021 at 11:56 AM wrote: > > From: chiminghao > > return value form directly instead of > taking this in another redundant variable. > > Reported-by: Zeal Robot > Signed-off-by: chiminghao > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ioc32.c | 5 + > dri

Re: [PATCH] drm/radeon: Fix syntax errors in comments

2021-12-14 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Dec 14, 2021 at 9:54 AM Christian König wrote: > > Am 14.12.21 um 14:52 schrieb Xiang wangx: > > Delete the redundant word 'we'. > > > > Signed-off-by: Xiang wangx > > Well not a syntax error in the sense of a coding error, but valid fix > anyway :) > > Reviewed-b

Re: [PATCH v3 0/9] Xilinx AI engine kernel driver

2020-12-11 Thread Alex Deucher
On Mon, Nov 30, 2020 at 3:25 AM Wendy Liang wrote: > > AI engine is the acceleration engine provided by Xilinx. These engines > provide high compute density for vector-based algorithms, and flexible > custom compute and data movement. It has core tiles for compute and > shim tiles to interface the

Re: [PATCH] drm/amdkfd: fix ttm size refactor fallout

2020-12-14 Thread Alex Deucher
ng > Cc: amd-...@lists.freedesktop.org > Signed-off-by: Daniel Vetter Acked-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_g

Re: [PATCH 2/4] drm/amdgpu/ttm: use multihop

2020-12-14 Thread Alex Deucher
p.org/drm/drm-misc/commit/?h=drm-misc-next-fixes&id=aefec40938e4a0e1214f9121520aba4d51697cd9 commit aefec40938e4a0e1214f9121520aba4d51697cd9 Author: Christian König Date: Mon Nov 16 20:12:03 2020 +0100 drm/amdgpu: fix check order in amdgpu_bo_move Reorder the code to fix checking if

Re: [PATCH] drm/amd/display: Fixed kernel test robot warning

2020-12-14 Thread Alex Deucher
On Fri, Dec 11, 2020 at 2:34 PM Souptick Joarder wrote: > > Kernel test robot throws below warning -> > > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5349:5: > warning: no previous prototype for 'amdgpu_dm_crtc_atomic_set_property' > [-Wmissing-prototypes] > drivers/gpu/drm/amd/amd

Re: [PATCH linux-next] drm/amd/display: Adding prototype for dccg21_update_dpp_dto()

2020-12-14 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Dec 14, 2020 at 3:18 AM Souptick Joarder wrote: > > Kernel test robot throws below warning -> > > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn21/dcn21_dccg.c:46:6: > warning: no previous prototype for 'dccg21_update_dpp_dto' > [-Wmissing-prototypes] > > Adding prot

Re: [git pull] drm for 5.11-rc1

2020-12-14 Thread Alex Deucher
On Mon, Dec 14, 2020 at 5:21 PM Linus Torvalds wrote: > > On Thu, Dec 10, 2020 at 7:52 PM Dave Airlie wrote: > > > > This is an early pull request for drm for 5.11 merge window. I'm going > > to be out for most of the first week of the merge window so thought > > I'd just preempt things and send

Re: [git pull] drm for 5.11-rc1

2020-12-14 Thread Alex Deucher
On Mon, Dec 14, 2020 at 5:45 PM Linus Torvalds wrote: > > On Mon, Dec 14, 2020 at 2:29 PM Alex Deucher wrote: > > > > The relevant fixes are: > > Ok, I can confirm that applying those two patches gets my workstation > working properly again. > > Would it b

Re: [PATCH] drm/amdgpu: Fix spelling mistake "Heterogenous" -> "Heterogeneous"

2020-12-15 Thread Alex Deucher
On Tue, Dec 15, 2020 at 5:56 AM Colin King wrote: > > From: Colin Ian King > > There is a spelling mistake in a comment in the Kconfig. Fix it. > > Signed-off-by: Colin Ian King Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/amdkfd/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 del

Re: [PATCH v3 0/9] Xilinx AI engine kernel driver

2020-12-15 Thread Alex Deucher
On Mon, Dec 14, 2020 at 7:24 PM Jiaying Liang wrote: > > > On 12/11/20 11:39 AM, Daniel Vetter wrote: > > Hi all > > > > On Fri, Dec 11, 2020 at 8:03 PM Alex Deucher wrote: > >> On Mon, Nov 30, 2020 at 3:25 AM Wendy Liang wrote: > >>> AI engi

Re: [PATCH] drm/amdgpu: remove h from printk format specifier

2020-12-15 Thread Alex Deucher
On Tue, Dec 15, 2020 at 10:11 AM Christian König wrote: > > Am 15.12.20 um 16:06 schrieb Tom Rix: > > On 12/15/20 6:47 AM, Christian König wrote: > >> Am 15.12.20 um 15:38 schrieb t...@redhat.com: > >>> From: Tom Rix > >>> > >>> See Documentation/core-api/printk-formats.rst. > >>> h should no lon

Re: [PATCH] drm/amd/display: Revert "add DCN support for aarch64"

2020-12-16 Thread Alex Deucher
the use of floating point here is > something that should be reconsidered entirely. > > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Dave Martin > Cc: Rob Herring > Cc: Leo Li > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc:

[pull] amdgpu, amdkfd, radeon drm-fixes-5.11

2020-12-16 Thread Alex Deucher
on warning fixes amdkfd: - Error logging fix - Fix pipe offset calculation radeon: - printk cleanup ---- Alex Deucher (10): drm/amdgpu/display: move link_bandwidth_kbps under CONFIG_DRM_AMD_DC_DCN drm/amdgpu: split BOCO and ATP

Re: [pull] amdgpu, amdkfd, radeon drm-fixes-5.11

2020-12-16 Thread Alex Deucher
On Wed, Dec 16, 2020 at 5:28 PM Daniel Vetter wrote: > > On Wed, Dec 16, 2020 at 02:24:20PM -0500, Alex Deucher wrote: > > Hi Dave, Daniel, > > > > Fixes for 5.11. > > > > The following changes since commit b10733527bfd864605c33ab2e9a886eec317ec39: > >

Re: [PATCH v3 1/3] drm/amd/display: Add module parameter for freesync video mode

2020-12-17 Thread Alex Deucher
On Mon, Dec 14, 2020 at 5:21 PM Aurabindo Pillai wrote: > > [Why&How] > Adds a module parameter to enable experimental freesync video mode modeset > optimization. Enabling this mode allows the driver to skip a full modeset when > freesync compatible modes are requested by the userspace. This param

Re: [PATCH 0/2] drm/amd/display: Adjustments for dc_create()

2020-12-22 Thread Alex Deucher
On Sun, Dec 20, 2020 at 6:10 AM Markus Elfring wrote: > > From: Markus Elfring > Date: Sat, 19 Dec 2020 18:30:56 +0100 > > Two update suggestions were taken into account > from static source code analysis. > Applied. Thanks! Alex > Markus Elfring (2): > Return directly after a failed kzall

[pull] amdgpu, amdkfd drm-fixes-5.11

2020-12-23 Thread Alex Deucher
SMU fixes - Arcturus gfx9 fixes - Misc display fixes - Sienna Cichlid SMU update - Fix S3 display memory leak - Fix regression caused by DP sub-connector support amdkfd: - Properly require pcie atomics for gfx10 Alex Deucher (3

Re: [git pull] drm fixes for 5.11-rc1

2020-12-29 Thread Alex Deucher
On Thu, Dec 24, 2020 at 5:28 PM Linus Torvalds wrote: > > On Wed, Dec 23, 2020 at 6:29 PM Dave Airlie wrote: > > > > Xmas eve pull request present. Just some fixes that trickled in this > > past week. Mostly amdgpu fixes, with a dma-buf/mips build fix and some > > misc komeda fixes. > > Well, I a

Re: [PATCH] drm/amd/display: Revert "add DCN support for aarch64"

2021-01-04 Thread Alex Deucher
On Tue, Dec 29, 2020 at 8:17 AM Ard Biesheuvel wrote: > > On Wed, 16 Dec 2020 at 23:26, Ard Biesheuvel wrote: > > > > On Wed, 16 Dec 2020 at 19:00, Alex Deucher wrote: > > > > > > On Mon, Dec 14, 2020 at 12:53 PM Ard Biesheuvel wrote:

Re: [PATCH] drm/amd/display: remove unused including

2021-01-04 Thread Alex Deucher
On Thu, Dec 31, 2020 at 5:42 AM Tian Tao wrote: > > Remove including that don't need it. > > Signed-off-by: Tian Tao Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 - > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 1 - > driver

Re: [PATCH] drm/amd/display: remove useless else if

2021-01-04 Thread Alex Deucher
On Mon, Dec 21, 2020 at 9:40 AM Tian Tao wrote: > > Fix the following coccinelle report: > drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c:1357:6-8: > WARNING: possible condition with no effect (if == else) > > Signed-off-by: Tian Tao Applied. Thanks! Alex > --- > drivers/gpu/drm/amd

Re: [PATCH] drm/radeon:avoid null pointer dereference when dev is not bound

2021-01-04 Thread Alex Deucher
On Sun, Dec 27, 2020 at 3:56 PM Defang Bo wrote: > > [Why] > Similar to commit<0fa375e6>. If the set_state/can_switch code access the > drm_device when dev is not bound, > a null pointer dereference can happen. > > [How] > Add sanity checks to prevent it. > > Signed-off-by: Defang Bo Are you ac

Re: [PATCH -next] gpu/drm/radeon: use DIV_ROUND_UP macro to do calculation

2021-01-04 Thread Alex Deucher
On Wed, Dec 23, 2020 at 2:06 AM Zheng Yongjun wrote: > > Don't open-code DIV_ROUND_UP() kernel macro. > > Signed-off-by: Zheng Yongjun Applied. Thanks! Alex > --- > drivers/gpu/drm/radeon/r600_cs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/

Re: Enable fp16 display support for DCE8+, next try.

2021-01-04 Thread Alex Deucher
On Mon, Dec 28, 2020 at 1:51 PM Mario Kleiner wrote: > > Hi and happy post-christmas! > > I wrote a patch 1/1 that now checks plane scaling factors against > the pixel-format specific limits in the asic specific dc_plane_cap > structures during atomic check and other appropriate places. > > This s

Re: [PATCH] drm/amd/display: fix comparison pointer to bool warning in dc.c

2021-01-04 Thread Alex Deucher
On Tue, Dec 29, 2020 at 4:42 AM Tian Tao wrote: > > Fixes coccicheck warning: > drivers/gpu/drm/amd/display/dc/core/dc.c:1543:12-19: WARNING: Comparison > to bool > drivers/gpu/drm/amd/display/dc/core/dc.c:1496:14-42: WARNING: Comparison > to bool > drivers/gpu/drm/amd/display/dc/core/dc.c:971:15-

Re: [PATCH] drm: Check actual format for legacy pageflip.

2021-01-04 Thread Alex Deucher
her drivers and it doesn't look like they end up triggering > this case so I think this is safe to relax. > > Signed-off-by: Bas Nieuwenhuizen > Fixes: 816853f9dc40 ("drm/amd/display: Set new format info for converted > metadata.") Acked-by: Alex Deucher >

Re: [PATCH] drm/amd/display: Fix unused variable warning

2021-01-04 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Jan 4, 2021 at 7:58 AM Lin, Wayne wrote: > > [AMD Official Use Only - Internal Distribution Only] > > Thanks Arnd. > > Reviewed-by: Wayne Lin > > -Original Message- > From: Arnd Bergmann > Sent: Sunday, January 3, 2021 10:03 PM > To: Wentland, Harry ; Li,

Re: [PATCH 2/2] drm/amd/display: Enable fp16 also on DCE-8/10/11.

2021-01-04 Thread Alex Deucher
Applied the series. Thanks! Alex On Mon, Jan 4, 2021 at 4:17 PM Kazlauskas, Nicholas wrote: > > On 2020-12-28 1:50 p.m., Mario Kleiner wrote: > > The hw supports fp16, this is not only useful for HDR, > > but also for standard dynamic range displays, because > > it allows to get more precise co

Re: [PATCH] drm/amd/display: Revert "add DCN support for aarch64"

2021-01-05 Thread Alex Deucher
On Tue, Jan 5, 2021 at 8:05 AM Will Deacon wrote: > > On Mon, Jan 04, 2021 at 11:27:24AM -0500, Alex Deucher wrote: > > On Tue, Dec 29, 2020 at 8:17 AM Ard Biesheuvel wrote: > > > > > > On Wed, 16 Dec 2020 at 23:26, Ard Biesheuvel wrote: > > > >

Re: [PATCH v2] drm/amdgpu: Add check to prevenet IH overflow

2021-01-05 Thread Alex Deucher
On Tue, Jan 5, 2021 at 11:49 AM Christian König wrote: > > Am 05.01.21 um 17:06 schrieb Defang Bo: > > Similar to commit ("drm/amdgpu: fix IH overflow on Vega10 > > v2"). > > When an ring buffer overflow happens the appropriate bit is set in the WPTR > > register which is also written back to mem

[PATCH] MAINTAINERS: update radeon/amdgpu/amdkfd git trees

2021-01-05 Thread Alex Deucher
FDO is out of space, so move to gitlab. Signed-off-by: Alex Deucher --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index eb18459c1d16..e2877be6b10d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -907,7 +907,7 @@ AMD KFD M

<    4   5   6   7   8   9   10   11   12   13   >