Re: [PATCH 25/40] drm/amd/amdgpu/amdgpu_debugfs: Demote obvious abuse of kernel-doc formatting

2020-11-13 Thread Alex Deucher
unction parameter > or member 'size' not described in 'amdgpu_debugfs_regs_write' > drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:317: warning: Function parameter > or member 'pos' not described in 'amdgpu_debugfs_regs_write' > > Cc:

Re: [PATCH 26/40] drm/amd/amdgpu/amdgpu_gmc: Demote one and fix another function header

2020-11-13 Thread Alex Deucher
m/amd/amdgpu/amdgpu_gmc.c:121: warning: Function parameter or > member 'bo' not described in 'amdgpu_gmc_agp_addr' > drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c:121: warning: Excess function > parameter 'tbo' description in 'amdgpu_gmc_agp_addr' > >

Re: [PATCH 27/40] drm/amd/amdgpu/amdgpu_ras: Remove unused function 'amdgpu_ras_error_cure'

2020-11-13 Thread Alex Deucher
On Fri, Nov 13, 2020 at 8:50 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:908:5: warning: no previous > prototype for ‘amdgpu_ras_error_cure’ [-Wmissing-prototypes] > > Cc: Alex Deucher > Cc: "

Re: [PATCH 30/40] drm/amd/amdgpu/amdgpu_vm_cpu: Fix 'amdgpu_vm_cpu_prepare()'s doc-rot

2020-11-13 Thread Alex Deucher
repare' > drivers/gpu/drm/amd/amdgpu/amdgpu_vm_cpu.c:50: warning: Excess function > parameter 'exclusive' description in 'amdgpu_vm_cpu_prepare' > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel

Re: [PATCH 31/40] drm/amd/amdgpu/amdgpu_vm_sdma: Fix 'amdgpu_vm_sdma_prepare()'s doc-rot

2020-11-13 Thread Alex Deucher
m_sdma_prepare' > drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c:63: warning: Excess function > parameter 'exclusive' description in 'amdgpu_vm_sdma_prepare' > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter &g

Re: [PATCH 36/40] drm/amd/amdgpu/amdgpu_fw_attestation: Consume our own header containing prototypes

2020-11-13 Thread Alex Deucher
On Fri, Nov 13, 2020 at 8:51 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/amdgpu_fw_attestation.c:130:6: warning: no > previous prototype for ‘amdgpu_fw_attestation_debugfs_init’ > [-Wmissing-prototypes] > >

Re: [PATCH 37/40] drm/amd/amdgpu/smu_v11_0_i2c: Provide descriptions for 'control' and 'data' params

2020-11-13 Thread Alex Deucher
gpu/drm/amd/amdgpu/smu_v11_0_i2c.c:325: warning: Function parameter > or member 'control' not described in 'smu_v11_0_i2c_receive' > drivers/gpu/drm/amd/amdgpu/smu_v11_0_i2c.c:325: warning: Function parameter > or member 'data' not described in 'smu_v1

Re: [PATCH 40/40] drm/amd/amdgpu/gfx_v7_0: Remove unused struct definition

2020-11-13 Thread Alex Deucher
On Fri, Nov 13, 2020 at 8:50 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:5211:45: warning: ‘gfx_v7_0_ip_block’ > defined but not used [-Wunused-const-variable=] > > Cc: Alex Deucher > Cc: "

Re: [PATCH] drm/fourcc: Fix modifier field mask for AMD modifiers.

2020-11-13 Thread Alex Deucher
fd2b49e16f0dc1e1770b9c Fixes: 8ba16d599374 ("drm/fourcc: Add AMD DRM modifiers.") Also missing your signed-off-by. With those things fixed: Reviewed-by: Alex Deucher > --- > > Found while reviewing Simon's drm_info PR: > https://github.com/ascent12/drm_info/

Re: [PATCH v2] drm/fourcc: Fix modifier field mask for AMD modifiers.

2020-11-13 Thread Alex Deucher
;drm/fourcc: Add AMD DRM modifiers.") > Reviewed-by: Alex Deucher > Signed-off-by: Bas Nieuwenhuizen Applied. Thanks! Alex > --- > include/uapi/drm/drm_fourcc.h | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/include/u

Re: [PATCH] drm/fourcc: add table describing AMD modifiers bit layout

2020-11-13 Thread Alex Deucher
so on). > > Signed-off-by: Simon Ser > Cc: Bas Nieuwenhuizen > Cc: Alex Deucher > Cc: Daniel Vetter Applied. Thanks! Alex > --- > > This already contains the fix in [1]. > > [1]: https://lists.freedesktop.org/archives/amd-gfx/2020-November/056073.html > >

Re: [PATCH] drm/fourcc: fix AMD modifiers PACKERS field doc

2020-11-16 Thread Alex Deucher
: PACKERS is bits 26:28 while > > BANK_XOR_BITS is bits 23:25. > > > > Fixes: 8ba16d599374 ("drm/fourcc: Add AMD DRM modifiers.") > > Signed-off-by: Simon Ser > > Cc: Bas Nieuwenhuizen > > Cc: Alex Deucher > > Cc: Daniel Vetter > > --- &g

Re: [PATCH] drm/amdgpu: fix check oder in amdgpu_bo_move

2020-11-16 Thread Alex Deucher
On Mon, Nov 16, 2020 at 2:14 PM Christian König wrote: > > Reorder the code to fix checking if blitting is available. > > Signed-off-by: Christian König > Fixes: f5a89a5cae81 drm/amdgpu/ttm: use multihop Typo in the subject (oder -> order). With that fixes the patch is: Acke

Re: [PATCH 01/43] drm/radeon/atombios_encoders: Move 'radeon_atom_get_tv_timings()'s prototype into shared location

2020-11-16 Thread Alex Deucher
_tv_timings(struct radeon_device *rdev, int index, > | ^~~~~~ > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Le

Re: [PATCH 02/43] drm/radeon/radeon: Move prototype into shared header

2020-11-16 Thread Alex Deucher
ual’ [-Wmissing-prototypes] > 637 | bool radeon_device_is_virtual(void) > | ^~~~~~~~ > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Sumit Semwal > Cc: amd-...@lists.freedesktop.org > Cc: dri-

Re: [PATCH 03/43] drm/radeon/radeon_kms: Move 'radeon_*_kms' prototypes to shared header

2020-11-16 Thread Alex Deucher
~~~ > drivers/gpu/drm/radeon/radeon_kms.c:853:6: warning: no previous prototype > for ‘radeon_disable_vblank_kms’ [-Wmissing-prototypes] > 853 | void radeon_disable_vblank_kms(struct drm_crtc *crtc) > | ^ > > Cc: Alex Deucher > Cc: "Chri

Re: [PATCH 04/43] drm/radeon/radeon_kms: Fix misnaming of 'radeon_info_ioctl's dev param

2020-11-16 Thread Alex Deucher
deon/radeon_kms.c:226: warning: Excess function parameter > 'rdev' description in 'radeon_info_ioctl' > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.fr

Re: [PATCH 05/43] drm/radeon: Move radeon_ttm{init, fini} to shared location

2020-11-16 Thread Alex Deucher
ypes] > 817 | int radeon_ttm_init(struct radeon_device *rdev) > | ^~~ > drivers/gpu/drm/radeon/radeon_ttm.c:878:6: warning: no previous prototype > for ‘radeon_ttm_fini’ [-Wmissing-prototypes] > 878 | void radeon_ttm_fini(struct radeon_device *rdev) > | ^~

Re: [PATCH 06/43] drm/radeon/radeon_legacy_encoders: Move 'radeon_add_legacy_encoder' prototype to shared header

2020-11-16 Thread Alex Deucher
acy_encoder(struct drm_device *dev, uint32_t > encoder_enum, uint32_t supported_device) > | ^~~~~~~~~ > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Sumit Semwal > Cc: amd-...@lists.freedesktop.o

Re: [PATCH 07/43] drm/radeon/radeon_legacy_encoders: Move 'radeon_add_legacy_encoder's prototype to shared location

2020-11-16 Thread Alex Deucher
acy_encoder(struct drm_device *dev, uint32_t > encoder_enum, uint32_t supported_device) > | ^~~~~~~~~ > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Sumit Semwal > Cc: amd-...@lists.freedesktop.o

Re: [PATCH 08/43] drm/radeon/radeon_irq_kms: Demote non-conformant kernel-doc fix another

2020-11-16 Thread Alex Deucher
irq_kms_set_irq_n_enabled' > drivers/gpu/drm/radeon/radeon_irq_kms.c:571: warning: Excess function > parameter 'num' description in 'radeon_irq_kms_set_irq_n_enabled' > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Dan

Re: [PATCH 09/43] drm/radeon/rv770: Move 'rv770_set_clk_bypass_mode' prototype to shared location

2020-11-16 Thread Alex Deucher
ruct radeon_device *rdev) > | ^~~~~ > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones Applied with

Re: [PATCH 10/43] drm/radeon/radeon_pm: Move 'radeon_pm_acpi_event_handler' prototype into shared header

2020-11-16 Thread Alex Deucher
ent_handler(struct radeon_device *rdev) > | ^~~~~~~~ > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Sumit Semwal > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Cc: linux-

Re: [PATCH 11/43] drm/radeon/radeon_audio: Move 'dce3_2_*' prototypes to shared location

2020-11-16 Thread Alex Deucher
t_mute’ [-Wmissing-prototypes] > 223 | void dce3_2_set_mute(struct drm_encoder *encoder, u32 offset, bool > mute) > | ^~~ > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Slava Grigorev > Cc: amd-.

Re: [PATCH 12/43] drm/radeon/evergreen: Move 'evergreen_*' and 'sumo_*' prototypes out to shared location

2020-11-16 Thread Alex Deucher
ng-prototypes] > 4381 | int evergreen_rlc_resume(struct radeon_device *rdev) > | ^ > drivers/gpu/drm/radeon/evergreen.c:4670:6: warning: no previous prototype > for ‘evergreen_irq_suspend’ [-Wmissing-prototypes] > 4670 | void evergreen_irq_suspend(struct radeon_device *rdev)

Re: [PATCH 13/43] drm/radeon/radeon_drv: Move 'radeon_mmap()'s prototype to shared header

2020-11-16 Thread Alex Deucher
m_area_struct *vma) > | ^~~~~~~ > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Gareth Hughes > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones Applied. T

Re: [PATCH 14/43] drm/radeon/radeon_drv: Move 'radeon_driver_irq_handler_kms's prototype into shared header

2020-11-16 Thread Alex Deucher
~~~ > drivers/gpu/drm/radeon/radeon_irq_kms.c:171:6: warning: no previous > prototype for ‘radeon_driver_irq_uninstall_kms’ [-Wmissing-prototypes] > 171 | void radeon_driver_irq_uninstall_kms(struct drm_device *dev) > | ^~~ > > Cc: Alex Deu

Re: [PATCH 15/43] drm/radeon/atom: Move 'radeon_atom_hw_i2c_*()'s prototypes into shared header

2020-11-16 Thread Alex Deucher
struct i2c_adapter *i2c_adap, > | ^~~ > drivers/gpu/drm/radeon/atombios_i2c.c:150:5: warning: no previous prototype > for ‘radeon_atom_hw_i2c_func’ [-Wmissing-prototypes] > 150 | u32 radeon_atom_hw_i2c_func(struct i2c_adapter *adap) > | ^~~~~~~~~

Re: [PATCH 16/43] drm/radeon/radeon_gem: Move 'radeon_gem_prime_*()'s prototypes to shared header

2020-11-16 Thread Alex Deucher
sing-prototypes] > 120 | struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj, > | ^~~ > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed

Re: [PATCH 17/43] drm/radeon/evergreen_hdmi: Move 'evergreen_*()' and 'dce4_*()' HDMI prototypes to shared header

2020-11-16 Thread Alex Deucher
vergreen_hdmi_enable’ [-Wmissing-prototypes] > drivers/gpu/drm/radeon/evergreen_hdmi.c:440:6: warning: no previous > prototype for ‘evergreen_dp_enable’ [-Wmissing-prototypes] > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter >

Re: [PATCH 18/43] drm/radeon/rv770: Move 'rv770_get_*()'s prototypes to shared header

2020-11-16 Thread Alex Deucher
uct radeon_ps *rps) > | ^~~~ > drivers/gpu/drm/radeon/rv770_dpm.c:54:26: warning: no previous prototype for > ‘rv770_get_pi’ [-Wmissing-prototypes] > 54 | struct rv7xx_power_info *rv770_get_pi(struct radeon_device *rdev) > | ^~~~ > > Cc: Evan Quan > Cc: Alex Deu

Re: [PATCH 19/43] drm/radeon/ni_dpm: Move 'ni_get_{pi, ps}()'s into shared header

2020-11-16 Thread Alex Deucher
adeon_device *rdev) > | ^ > drivers/gpu/drm/radeon/ni_dpm.c:734:15: warning: no previous prototype for > ‘ni_get_ps’ [-Wmissing-prototypes] > 734 | struct ni_ps *ni_get_ps(struct radeon_ps *rps) > | ^ > > Cc: Alex Deucher > Cc: "Christian König"

Re: [PATCH 20/43] drm/radeon/evergreen: Move 'cayman_*()'s prototypes to shared header

2020-11-16 Thread Alex Deucher
ruct radeon_device *rdev, > | ^~~~ > drivers/gpu/drm/radeon/ni.c:1732:5: warning: no previous prototype for > ‘cayman_gpu_check_soft_reset’ [-Wmissing-prototypes] > 1732 | u32 cayman_gpu_check_soft_reset(struct radeon_device *rdev) > | ^~~~~~~~~

Re: [PATCH 21/43] drm/radeon/r600_dma: Move 'r600_gpu_check_soft_reset()'s prototype to shared location

2020-11-16 Thread Alex Deucher
ruct radeon_device *rdev) > | ^~~~~ > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Sumit Semwal > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Cc: linux-me...@vge

Re: [PATCH 22/43] drm/radeon/cik: Move 'r600_ih_ring_{alloc, fini}()'s prototypes to shared header

2020-11-16 Thread Alex Deucher
adeon_device *rdev) > | ^~ > drivers/gpu/drm/radeon/r600.c:3516:6: warning: no previous prototype for > ‘r600_ih_ring_fini’ [-Wmissing-prototypes] > 3516 | void r600_ih_ring_fini(struct radeon_device *rdev) > | ^ > > Cc: Alex Deucher > Cc: &

Re: [PATCH 23/43] drm/radeon/evergreen_dma: Move 'evergreen_gpu_check_soft_reset()'s prototype to shared header

2020-11-16 Thread Alex Deucher
_soft_reset(struct radeon_device *rdev) > | ^~~~~~ > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jo

Re: [PATCH 24/43] drm/radeon/r600: Move 'evergreen_rlc_resume()'s prototype to shared header

2020-11-16 Thread Alex Deucher
adeon_device *rdev) > | ^~~~~~~~ > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones Applied. Thanks!

Re: [PATCH 25/43] drm/radeon/ni_dma: Move 'cayman_gpu_check_soft_reset()'s prototype to shared header

2020-11-16 Thread Alex Deucher
ruct radeon_device *rdev) > | ^~~~~~~ > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones Applie

Re: [PATCH 26/43] drm/radeon/radeon_atombios: Move 'radeon_add_atom_encoder()'s prototype to shared header

2020-11-16 Thread Alex Deucher
(struct drm_device *dev, > | ^~~~~~~ > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones A

Re: [PATCH 27/43] drm/radeon/radeon_encoders: Move 'radeon_atom_backlight_init's prototype to shared header

2020-11-16 Thread Alex Deucher
klight_init(struct radeon_encoder *radeon_encoder, > | ^~~~~~ > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Le

Re: [PATCH 28/43] drm/radeon/ci_dpm: Move 'ci_*()'s prototypes to shared header

2020-11-16 Thread Alex Deucher
ik_update_cg’ [-Wmissing-prototypes] > 6286 | void cik_update_cg(struct radeon_device *rdev, > | ^ > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freede

Re: [PATCH 29/43] drm/radeon/si_dpm: Move 'si_mc_load_microcode()'s prototype to shared header

2020-11-16 Thread Alex Deucher
On Mon, Nov 16, 2020 at 12:38 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/radeon/si.c:1570:5: warning: no previous prototype for > ‘si_mc_load_microcode’ [-Wmissing-prototypes] > > Cc: Alex Deucher > Cc: "Christi

Re: [PATCH 30/43] drm/radeon/si_dma: Move 'si_gpu_check_soft_reset()'s prototype to shared header

2020-11-16 Thread Alex Deucher
adeon_device *rdev) > | ^~~~~~~ > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones Applied. Than

Re: [PATCH 31/43] drm/radeon/cik: Move 'si_*()'s prototypes to shared header

2020-11-16 Thread Alex Deucher
/drm/radeon/si.c:5801:6: warning: no previous prototype for > ‘si_rlc_reset’ [-Wmissing-prototypes] > 5801 | void si_rlc_reset(struct radeon_device *rdev) > | ^~~~ > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter &

Re: [PATCH 32/43] drm/radeon/btc_dpm: Move 'evergreen_get_pi's prototype to shared header

2020-11-16 Thread Alex Deucher
reen_get_pi(struct radeon_device > *rdev) > | ^~~~~~~~ > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones Applied.

Re: [PATCH 33/43] drm/radeon/radeon_audio: Move 'dce6_*()'s prototypes to shared header

2020-11-16 Thread Alex Deucher
; | ^~~ > drivers/gpu/drm/radeon/dce6_afmt.c:287:6: warning: no previous prototype for > ‘dce6_dp_audio_set_dto’ [-Wmissing-prototypes] > 287 | void dce6_dp_audio_set_dto(struct radeo_device *rdev, > | ^ > > Cc: Alex Deucher > Cc: &quo

Re: [PATCH 34/43] drm/radeon/evergreen: Move 'si_get_csb_*()'s prototypes to shared header

2020-11-16 Thread Alex Deucher
adeon_device *rdev) > | ^~~ > drivers/gpu/drm/radeon/si.c:5710:6: warning: no previous prototype for > ‘si_get_csb_buffer’ [-Wmissing-prototypes] > 5710 | void si_get_csb_buffer(struct radeon_device *rdev, volatile u32 > *buffer) > | ^~~~~ > > Cc: Alex Deucher &

Re: [PATCH 35/43] drm/radeon/cik_sdma: Move 'amdgpu_cik_gpu_check_soft_reset()'s prototype to shared header

2020-11-16 Thread Alex Deucher
ruct radeon_device *rdev) > | ^~~~~~~~ > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones Applied. Thanks

Re: [PATCH 36/43] drm/radeon/evergreen: Move 'cik_*()'s prototypes to shared header

2020-11-16 Thread Alex Deucher
: warning: no previous prototype for > ‘cik_get_csb_buffer’ [-Wmissing-prototypes] > 6702 | void cik_get_csb_buffer(struct radeon_device *rdev, volatile u32 > *buffer) > | ^~ > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie &g

Re: [PATCH 37/43] drm/radeon/ci_dpm: Move 'si_*()'s prototypes to shared header

2020-11-16 Thread Alex Deucher
memory_clock, bool strobe_mode) > | ^~~ > drivers/gpu/drm/radeon/si_dpm.c:3897:6: warning: no previous prototype for > ‘si_trim_voltage_table_to_fit_state_table’ [-Wmissing-prototypes] > 3897 | void si_trim_voltage_table_to_fit_state_table(struct radeon_device > *rdev, > | ^~~~~~~

Re: [PATCH 38/43] drm/radeon/cik: Move 'Move 'cik_sdma_*()'s prototypes to shared header

2020-11-16 Thread Alex Deucher
57:6: warning: no previous prototype for > ‘cik_sdma_fini’ [-Wmissing-prototypes] > 557 | void cik_sdma_fini(struct radeon_device *rdev) > | ^ > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter &

Re: [PATCH 39/43] drm/radeon/si_dpm: Move 'vce_v1_0_enable_mgcg()'s prototype to shared header

2020-11-16 Thread Alex Deucher
adeon_device *rdev, bool enable) > | ^~~~~~~~ > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones Applied.

Re: [PATCH 40/43] drm/radeon/cik: Move 'vce_v2_0_enable_mgcg()'s prototype to shared header

2020-11-16 Thread Alex Deucher
adeon_device *rdev, bool enable) > | ^~~~~~~~ > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Sumit Semwal > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Cc: linux-me...@vge

Re: [PATCH 41/43] drm/radeon/evergreen_cs: Move 'r600_dma_cs_next_reloc()'s prototype to shared header

2020-11-16 Thread Alex Deucher
t radeon_cs_parser *p, > | ^~~~~~ > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones Applied. Thanks! A

Re: [PATCH 42/43] drm/radeon/radeon_audio: Move 'r600_*' prototypes into shared header

2020-11-16 Thread Alex Deucher
encoder *encoder, u32 offset, bool mute) > | ^ > drivers/gpu/drm/radeon/r600_hdmi.c:469:6: warning: no previous prototype for > ‘r600_hdmi_enable’ [-Wmissing-prototypes] > 469 | void r600_hdmi_enable(struct drm_encoder *encoder, bool enable) > | ^~~~ >

Re: [PATCH 43/43] drm/radeon/radeon_drv: Move 'radeon_gem_prime_import_sg_table()'s prototype to shared header

2020-11-16 Thread Alex Deucher
uct drm_gem_object *radeon_gem_prime_import_sg_table(struct > drm_device *dev, > | ^~~~~~~~ > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Gareth Hughes > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@

Re: [PATCH 01/42] drm/amd/amdgpu/atombios_encoders: Remove set but unused variable 'backlight_level'

2020-11-16 Thread Alex Deucher
On Mon, Nov 16, 2020 at 12:41 PM Lee Jones wrote: > > Also removing the call to > amdgpu_atombios_encoder_get_backlight_level_from_reg() > since, according to Alex Deucher, "We call it again below indirectly". > > Fixes the following W=1 kernel build warning(s): >

Re: [PATCH v4] Add power/gpu_frequency tracepoint.

2020-11-17 Thread Alex Deucher
On Tue, Nov 17, 2020 at 1:00 PM Rafael J. Wysocki wrote: > > On 11/16/2020 10:05 PM, Steven Rostedt wrote: > > On Mon, 16 Nov 2020 12:55:29 -0800 > > Peiyong Lin wrote: > > > >> Hi there, > >> > >> May I ask whether the merge window has passed? If so is it possible to > >> ask for a review? > > T

Re: [PATCH][next] drm/amd/pm: fix spelling mistakes in dev_warn messages

2020-11-17 Thread Alex Deucher
On Tue, Nov 17, 2020 at 8:11 AM Colin King wrote: > > From: Colin Ian King > > There are two spelling mistakes in dev_warn messages. Fix these. > > Signed-off-by: Colin Ian King Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 4 ++-- > 1 file changed, 2 inse

[pull] amdgpu, amdkfd, radeon, scheduler drm-next-5.11

2020-11-17 Thread Alex Deucher
- SR-IOV fixes - Dimgrey Cavefish fixes - W=1 fixes - Vangogh updates - Initial S0ix support - DCN 3.x FP fixes - FB modifier fixes amdkfd: - CRAT table fixes radeon: - W=1 fixes Scheduler: - W=1 fixes Alex Deucher (5): drm

[pull] amdgpu drm-fixes-5.10

2020-11-18 Thread Alex Deucher
-- amd-drm-fixes-5.10-2020-11-18: amdgpu: - Pageflip fix for navi1x with 5 or 6 displays - Remove experimental flag for Arcturus - Fix regression in atomic commit tail rework ---- Alex Deucher (2): drm/amd/display: Add missing pfl

Re: [PATCH] amdgpu/amdgpu_ids: fix kmalloc_array not uses number as first arg

2020-11-19 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Nov 18, 2020 at 3:17 AM Christian König wrote: > > Am 18.11.20 um 03:42 schrieb Bernard Zhao: > > Fix check_patch.pl warning: > > kmalloc_array uses number as first arg, sizeof is generally wrong. > > +fences = kmalloc_array(sizeof(void *), id_mgr->num_ids, > > GFP

Re: [PATCH] amd/amdgpu: use kmalloc_array to replace kmalloc with multiply

2020-11-19 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Nov 18, 2020 at 3:18 AM Christian König wrote: > > Am 18.11.20 um 03:55 schrieb Bernard Zhao: > > Fix check_patch.pl warning: > > WARNING: Prefer kmalloc_array over kmalloc with multiply > > +bps = kmalloc(align_space * sizeof((*data)->bps), GFP_KERNEL); > > WARNIN

Re: [PATCH 004/141] drm/amdgpu: Fix fall-through warnings for Clang

2020-11-20 Thread Alex Deucher
On Fri, Nov 20, 2020 at 1:24 PM Gustavo A. R. Silva wrote: > > In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple > warnings by explicitly adding multiple break statements instead of just > letting the code fall through to the next case. > > Link: https://github.com/KSPP/linux

Re: [PATCH 005/141] drm/radeon: Fix fall-through warnings for Clang

2020-11-20 Thread Alex Deucher
On Fri, Nov 20, 2020 at 1:24 PM Gustavo A. R. Silva wrote: > > In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple > warnings by explicitly adding multiple fallthrough pseudo-keyword macros, > as replacement for /* fall through */ comments. > > Notice that Clang doesn't recogni

Re: [PATCH 028/141] drm/amd/display: Fix fall-through warnings for Clang

2020-11-20 Thread Alex Deucher
On Fri, Nov 20, 2020 at 1:28 PM Gustavo A. R. Silva wrote: > > In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple > warnings by explicitly adding multiple break statements instead of just > letting the code fall through to the next case. > > Link: https://github.com/KSPP/linux

Re: [PATCH 078/141] drm/amd/pm: Fix fall-through warnings for Clang

2020-11-20 Thread Alex Deucher
On Fri, Nov 20, 2020 at 1:35 PM Gustavo A. R. Silva wrote: > > In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple > of warnings by explicitly adding a break statement instead of letting > the code fall through to the next case, and a fallthrough pseudo-keyword > as a replaceme

Re: [RFC v2 1/2] drm/doc/rfc: VM_BIND feature design document

2022-03-09 Thread Alex Deucher
On Mon, Mar 7, 2022 at 3:30 PM Niranjana Vishwanathapura wrote: > > VM_BIND design document with description of intended use cases. > > Signed-off-by: Niranjana Vishwanathapura > --- > Documentation/gpu/rfc/i915_vm_bind.rst | 210 + > Documentation/gpu/rfc/index.rst

Re: [PATCH v2] drm/amdgpu: Add support for drm_privacy_screen

2022-03-09 Thread Alex Deucher
On Wed, Mar 9, 2022 at 12:54 PM Rajat Jain wrote: > > On Wed, Mar 9, 2022 at 7:06 AM Sean Paul wrote: > > > > From: Sean Paul > > > > This patch adds the necessary hooks to make amdgpu aware of privacy > > screens. On devices with privacy screen drivers (such as thinkpad-acpi), > > the amdgpu dr

Re: [PATCH] drm/amdkfd: Set handle to invalid for non GTT/VRAM BOs

2022-03-09 Thread Alex Deucher
On Wed, Mar 9, 2022 at 4:10 PM Felix Kuehling wrote: > > On 2022-03-09 12:41, David Yat Sin wrote: > > Set dmabuf handle to invalid for BOs that cannot be accessed using SDMA > > during checkpoint/restore. > > > > Signed-off-by: David Yat Sin > > --- > > drivers/gpu/drm/amd/amdkfd/kfd_chardev.c

Re: [PATCH] drm/amdkfd: Set handle to invalid for non GTT/VRAM BOs

2022-03-09 Thread Alex Deucher
On Wed, Mar 9, 2022 at 4:21 PM Alex Deucher wrote: > > On Wed, Mar 9, 2022 at 4:10 PM Felix Kuehling wrote: > > > > On 2022-03-09 12:41, David Yat Sin wrote: > > > Set dmabuf handle to invalid for BOs that cannot be accessed using SDMA > > > during checkpoin

Re: [PATCH] fixup! drm/amdkfd: CRIU export dmabuf handles for GTT BOs

2022-03-09 Thread Alex Deucher
No problem. squashed in: https://gitlab.freedesktop.org/agd5f/linux/-/commit/74041e46982cd627e7b52f9c3ed37d23a4973b5f Alex Alex On Wed, Mar 9, 2022 at 4:23 PM Felix Kuehling wrote: > > On 2022-03-09 16:20, David Yat Sin wrote: > > Signed-off-by: David Yat Sin > > Please add the commit descri

Re: [pull] amdgpu, amdkfd drm-next-5.18

2022-03-09 Thread Alex Deucher
On Wed, Mar 9, 2022 at 5:12 PM Dave Airlie wrote: > > On Tue, 8 Mar 2022 at 06:08, Alex Deucher wrote: > > > > Hi Dave, Daniel, > > > > Same PR as last week, just fixed up a bad Fixes tag. > > > > The following changes since commit 38a15ad9488e21cad8f

[pull] amdgpu, amdkfd drm-next-5.18

2022-03-09 Thread Alex Deucher
or gfx10.3 ---- Alex Deucher (4): drm/amdgpu: Use IP versions in convert_tiling_flags_to_modifier() drm/amdgpu: remove unused gpu_info firmwares drm/amdgpu/gfx10: drop unused cyan skillfish firmware drm/amdgpu/sdma5: drop unused cyan skillfish firmwa

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-14 Thread Alex Deucher
On Fri, Mar 11, 2022 at 3:30 AM Pekka Paalanen wrote: > > On Thu, 10 Mar 2022 11:56:41 -0800 > Rob Clark wrote: > > > For something like just notifying a compositor that a gpu crash > > happened, perhaps drm_event is more suitable. See > > virtio_gpu_fence_event_create() for an example of adding

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-15 Thread Alex Deucher
On Mon, Mar 14, 2022 at 11:26 AM Pekka Paalanen wrote: > > On Mon, 14 Mar 2022 10:23:27 -0400 > Alex Deucher wrote: > > > On Fri, Mar 11, 2022 at 3:30 AM Pekka Paalanen wrote: > > > > > > On Thu, 10 Mar 2022 11:56:41 -0800 > > > Rob Clark wrote: &g

Re: [PATCH 01/30] drm/amd/pm: fix typos in comments

2022-03-15 Thread Alex Deucher
Applied. Thanks! On Mon, Mar 14, 2022 at 8:01 AM Julia Lawall wrote: > > Various spelling mistakes in comments. > Detected with the help of Coccinelle. > > Signed-off-by: Julia Lawall > > --- > drivers/gpu/drm/amd/pm/amdgpu_pm.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > di

Re: [PATCH 29/30] drm/amdgpu: fix typos in comments

2022-03-15 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Mar 14, 2022 at 8:01 AM Julia Lawall wrote: > > Various spelling mistakes in comments. > Detected with the help of Coccinelle. > > Signed-off-by: Julia Lawall > > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c |4 ++-- > 1 file changed, 2 insertions(+), 2 delet

Re: [PATCH 23/30] drm/amdgpu/dc: fix typos in comments

2022-03-15 Thread Alex Deucher
Applied. Thanks! On Mon, Mar 14, 2022 at 8:01 AM Julia Lawall wrote: > > Various spelling mistakes in comments. > Detected with the help of Coccinelle. > > Signed-off-by: Julia Lawall > > --- > drivers/gpu/drm/amd/display/dc/bios/command_table.c |6 +++--- > 1 file changed, 3 insertions(+)

Re: [PATCH 02/22] drm/amdgpu: Remove pointless on stack mode copies

2022-03-15 Thread Alex Deucher
. > > > > Cc: Harry Wentland > > Cc: Leo Li > > Cc: Rodrigo Siqueira > > Cc: Alex Deucher > > Cc: amd-...@lists.freedesktop.org > > Cc: Nikola Cornij > > Cc: Aurabindo Pillai > > Signed-off-by: Ville Syrjälä > > Reviewed

Re: [PATCH 05/22] drm/radeon: Use drm_mode_copy()

2022-03-15 Thread Alex Deucher
+ drm_mode_copy(mode, &E) > | > - memcpy(mode, E, S) > + drm_mode_copy(mode, E) > ) > > @depends on !is_mode_copy@ > struct drm_display_mode mode; > expression E; > @@ > ( > - mode = E > + drm_mode_copy(&mode, &E) > | > - memcpy(&mode, E, S)

Re: [PATCH 04/22] drm/amdgpu: Use drm_mode_copy()

2022-03-15 Thread Alex Deucher
, S) > > + drm_mode_copy(mode, E) > > ) > > > > @depends on !is_mode_copy@ > > struct drm_display_mode mode; > > expression E; > > @@ > > ( > > - mode = E > > + drm_mode_copy(&mode, &E) > > | > > - memcpy(&mode

Re: [PATCH 00/22] drm: Review of mode copies

2022-03-15 Thread Alex Deucher
On Mon, Mar 14, 2022 at 6:12 PM Ville Syrjälä wrote: > > On Fri, Feb 18, 2022 at 12:03:41PM +0200, Ville Syrjala wrote: > > drm: Add drm_mode_init() > > drm/bridge: Use drm_mode_copy() > > drm/imx: Use drm_mode_duplicate() > > drm/panel: Use drm_mode_duplicate() > > drm/vc4: Use drm_mode

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-16 Thread Alex Deucher
On Wed, Mar 16, 2022 at 4:48 AM Pekka Paalanen wrote: > > On Tue, 15 Mar 2022 10:54:38 -0400 > Alex Deucher wrote: > > > On Mon, Mar 14, 2022 at 11:26 AM Pekka Paalanen wrote: > > > > > > On Mon, 14 Mar 2022 10:23:27 -0400 > > > Alex Deucher wrote:

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-16 Thread Alex Deucher
On Wed, Mar 16, 2022 at 11:35 AM Rob Clark wrote: > > On Wed, Mar 16, 2022 at 7:12 AM Alex Deucher wrote: > > > > On Wed, Mar 16, 2022 at 4:48 AM Pekka Paalanen wrote: > > > > [snip] > > > With new UAPI comes the demand of userspace proof, not hand-waving

Re: [PATCH v2] nvidia-wmi-ec-backlight: Add workarounds for confused firmware

2022-03-17 Thread Alex Deucher
On Thu, Mar 17, 2022 at 12:42 PM Hans de Goede wrote: > > Hi Daniel, > > On 3/17/22 14:28, Daniel Dadap wrote: > > > >> On Mar 17, 2022, at 07:17, Hans de Goede wrote: > >> > >> Hi, > >> > >>> On 3/16/22 21:33, Daniel Dadap wrote: > >>> Some notebook systems with EC-driven backlight control appe

Re: [PATCH] drm/amdgpu: Fix spelling mistake "regiser" -> "register"

2022-03-17 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Mar 15, 2022 at 4:20 PM Colin Ian King wrote: > > There is a spelling mistake in a dev_error error message. Fix it. > > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [PATCH] drm/amdgpu: fix off by one in amdgpu_gfx_kiq_acquire()

2022-03-17 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Mar 16, 2022 at 4:42 AM Dan Carpenter wrote: > > This post-op should be a pre-op so that we do not pass -1 as the bit > number to test_bit(). The current code will loop downwards from 63 to > -1. After changing to a pre-op, it loops from 63 to 0. > > Fixes: 71c37

[pull] amdgpu, amdkfd drm-next-5.18

2022-03-18 Thread Alex Deucher
fixes and cleanups amdkfd: - CRIU fixes - SVM fixes UAPI: - Properly handle SDMA transfers with CRIU Proposed user mode change: https://github.com/checkpoint-restore/criu/pull/1709 ---- Alex Deucher (2): drm/amdgpu/display: enab

Re: Commit messages (was: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu)

2022-03-23 Thread Alex Deucher
On Wed, Mar 23, 2022 at 10:00 AM Daniel Stone wrote: > > On Wed, 23 Mar 2022 at 08:19, Christian König > wrote: > > Am 23.03.22 um 09:10 schrieb Paul Menzel: > > > Sorry, I disagree. The motivation needs to be part of the commit > > > message. For example see recent discussion on the LWN article

Re: Commit messages (was: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu)

2022-03-23 Thread Alex Deucher
On Wed, Mar 23, 2022 at 11:04 AM Daniel Stone wrote: > > Hi Alex, > > On Wed, 23 Mar 2022 at 14:42, Alex Deucher wrote: > > On Wed, Mar 23, 2022 at 10:00 AM Daniel Stone wrote: > > > On Wed, 23 Mar 2022 at 08:19, Christian König > > > wrote: > > >

Re: [PATCH] drm/amd/display: use NULL instead of using plain integer as pointer

2022-03-23 Thread Alex Deucher
Thanks for the patches. I've already applied fixes from others for these issues. Alex On Tue, Mar 22, 2022 at 9:05 AM Haowen Bai wrote: > > This fixes the following sparse warnings: > drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dsc/rc_calc_fpu.c:71:40: > warning: Using > plain integer as NULL

Re: [PATCH v2 3/25] drm/amdgpu: Disable ABM when AC mode

2022-03-25 Thread Alex Deucher
On Fri, Mar 25, 2022 at 2:27 AM Ryan Lin wrote: > > Disable ABM feature when the system is running on AC mode to get > the more perfect contrast of the display. > > Signed-off-by: Ryan Lin > > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 4 ++ > drivers/gpu/drm/amd/amdgpu/amdgpu_device

Re: [PATCH] drm/amd: Re-classify some log messages in commit path

2022-03-25 Thread Alex Deucher
Thanks. Fixed up the title when I applied it. Alex On Fri, Mar 25, 2022 at 10:55 AM Harry Wentland wrote: > > On 2022-03-24 20:06, Sean Paul wrote: > > From: Sean Paul > > > > ATOMIC and DRIVER log categories do not typically contain per-frame log > > messages. This patch re-classifies some me

[pull] amdgpu, amdkfd drm-next-5.18

2022-03-25 Thread Alex Deucher
r handling fix - xgmi p2p fix - HWS VMIDs fix ---- Alex Deucher (2): drm/amdgpu/gmc: use PCI BARs for APUs in passthrough drm/amdgpu: add more cases to noretry=1 Aurabindo Pillai (1): drm/amd: Add USBC connector ID Charl

Re: [PATCH] drm/amd/display: Fix pointer dereferenced before checking

2022-03-25 Thread Alex Deucher
Applied both patches. Thanks! Alex On Thu, Mar 24, 2022 at 9:46 AM Haowen Bai wrote: > > The value actual_pix_clk_100Hz is dereferencing pointer pix_clk_params > before pix_clk_params is being null checked. Fix this by assigning > pix_clk_params->requested_pix_clk_100hz to actual_pix_clk_100Hz

Re: [PATCH] drm/sched: Fix htmldoc warning.

2022-03-28 Thread Alex Deucher
On Mon, Mar 28, 2022 at 9:25 AM Andrey Grodzovsky wrote: > > Fixes the warning. > > Signed-off-by: Andrey Grodzovsky You may want to add a Reported-by for Stephen, WIth that, Reviewed-by: Alex Deucher > --- > include/drm/gpu_scheduler.h | 1 + > 1 file changed, 1

Re: [PATCH] drm/amd/display: DCN3.1: don't mark as kernel-doc

2022-03-28 Thread Alex Deucher
x27;t a kernel-doc comment. > Refer Documentation/doc-guide/kernel-doc.rst > * Enable CRTC > > Fixes: 110d3968fe95 ("drm/amd/display: Add DCN3.1 OPTC") > Signed-off-by: Randy Dunlap > Cc: Alex Deucher > Cc: Nicholas Kazlauskas > Cc: amd-...@lists.freedesktop.org > Cc:

Re: drm/amdgpu: Disable ABM when AC mode

2022-03-29 Thread Alex Deucher
On Tue, Mar 29, 2022 at 4:56 AM Ryan Lin wrote: > > Disable ABM feature when the system is running on AC mode to get > the more perfect contrast of the display. > > v2: remove "UPSTREAM" from the subject. > > Signed-off-by: Ryan Lin > > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 4 ++

Re: amdgpu link problem (was Re: [git pull] drm for 5.18-rc1)

2022-03-29 Thread Alex Deucher
On Mon, Mar 28, 2022 at 9:54 PM Linus Torvalds wrote: > > I didn't notice this until now, probably because everything still > _works_, but I get a new big warning splat at bootup on my main > workstation these days as of the merge window changes. > > The full warning is attached, but it's basicall

<    2   3   4   5   6   7   8   9   10   11   >