Re: [PATCH v3 1/1] drm/ttm: Fix COW check

2021-07-13 Thread Alex Deucher
AP on BO mappings v3") > > Signed-off-by: Felix Kuehling > > Signed-off-by: Alex Deucher > > Reviewed-by: Christian König Are you planning to push this to drm-misc? Alex > > > --- > > drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 3 ++- > > drivers/

[pull] amdgpu, amdkfd drm-fixes-5.14

2021-07-14 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.14. The big change here is unifying the SMU13 code. This was new code added in 5.14 to support Yellow Carp, but we've since cleaned it up and removed a lot of duplication, so better to merge it now to facilitate any bug fixes in the future that need to go back to thi

Re: [pull] amdgpu, amdkfd drm-fixes-5.14

2021-07-15 Thread Alex Deucher
On Thu, Jul 15, 2021 at 12:52 AM Sam Ravnborg wrote: > > Hi Alex, > > On Wed, Jul 14, 2021 at 06:08:58PM -0400, Alex Deucher wrote: > > Hi Dave, Daniel, > > > > Fixes for 5.14. The big change here is unifying the SMU13 code. This was > > new code added in 5.

Re: [PATCH] drm/amdgpu/display: make a const array common_rates static, makes object smaller

2021-07-15 Thread Alex Deucher
On Thu, Jul 15, 2021 at 10:37 AM Colin King wrote: > > From: Colin Ian King > > Don't populate the const array common_rates on the stack but instead it > static. Makes the object code smaller by 80 bytes: > > Before: >textdata bss dec hex filename > 268019 98322 256 36

Re: [PATCH] drm/amd/display: Fix 10bit 4K display on CIK GPUs

2021-07-15 Thread Alex Deucher
On Wed, Jul 14, 2021 at 4:15 AM Liviu Dudau wrote: > > Commit 72a7cf0aec0c ("drm/amd/display: Keep linebuffer pixel depth at > 30bpp for DCE-11.0.") doesn't seems to have fixed 10bit 4K rendering over > DisplayPort for CIK GPUs. On my machine with a HAWAII GPU I get a broken > image that looks lik

Re: [PATCH] drm/ttm: revert "Fix COW check"

2021-07-16 Thread Alex Deucher
On Fri, Jul 16, 2021 at 3:06 AM Christian König wrote: > > This reverts commit 85fd4a8a84316166640102676a356755ddec80e0. > > Daniel pointed out that even PROT_READ can cause a BUG_ON() with this. > > Signed-off-by: Christian König Acked-by: Alex Deucher > --- > dr

Re: [PATCH] drm/amd/display: Fix 10bit 4K display on CIK GPUs

2021-07-16 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Jul 15, 2021 at 3:40 PM Harry Wentland wrote: > > > > On 2021-07-15 3:19 p.m., Mario Kleiner wrote: > > On Thu, Jul 15, 2021 at 6:10 PM Alex Deucher wrote: > >> > >> On Wed, Jul 14, 2021 at 4:15 AM Liviu Dudau wrote: >

Re: [PATCH] drm/amd: fix typoes

2020-11-02 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Nov 2, 2020 at 8:43 AM Bernard Zhao wrote: > > Fix typoes. > > Signed-off-by: Bernard Zhao > --- > drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/calcs/dce_c

Re: [PATCH][next] drm/amdgpu: fix spelling mistake: "Successed" -> "Succeeded"

2020-11-02 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Nov 2, 2020 at 9:17 AM Colin King wrote: > > From: Colin Ian King > > There is a spelling mistake in a deb_dbg message. Fix it. > > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 2 +- > 1 file changed, 1 insertion(+), 1 del

Re: [PATCH -next] drm/amd/pm: remove unused variable

2020-11-02 Thread Alex Deucher
On Mon, Nov 2, 2020 at 8:44 AM Zou Wei wrote: > > Fix variable set but not used compilation warning: > > ./vangogh_ppt.c:397:6: warning: variable ‘ret’ set but not used > [-Wunused-but-set-variable] > int ret = 0; > ^~~ > Maybe you have an older version of the code? It's currently used.

Re: [PATCH 6/6] drm/amdgpu: improve code indentation and alignment

2020-11-02 Thread Alex Deucher
Applied the series. Thanks! Alex On Mon, Nov 2, 2020 at 12:44 PM Deepak R Varma wrote: > > General code indentation and alignment changes such as replace spaces > by tabs or align function arguments as per the coding style > guidelines. The patch covers various .c files for this driver. > Issue

Re: [PATCH] drm/amdgpu: do not initialise global variables to 0 or NULL

2020-11-02 Thread Alex Deucher
On Mon, Nov 2, 2020 at 1:42 PM Deepak R Varma wrote: > > Initializing global variable to 0 or NULL is not necessary and should > be avoided. Issue reported by checkpatch script as: > ERROR: do not initialise globals to 0 (or NULL). I agree that this is technically correct, but a lot of people don

Re: [PATCH 6/6] drm/amdgpu: use "*" adjacent to data name

2020-11-02 Thread Alex Deucher
Applied the series. Thanks! Alex On Mon, Nov 2, 2020 at 2:41 PM Deepak R Varma wrote: > > When declaring pointer data, the "*" symbol should be used adjacent to > the data name as per the coding standards. This resolves following > issues reported by checkpatch script: > ERROR: "foo *

Re: [PATCH 3/5] drm/amdgpu: Paper over the drm_driver mangling for virt

2020-11-03 Thread Alex Deucher
On Sun, Nov 1, 2020 at 5:01 AM Daniel Vetter wrote: > > On Sat, Oct 31, 2020 at 2:57 PM Daniel Vetter wrote: > > > > On Fri, Oct 30, 2020 at 7:47 PM Alex Deucher wrote: > > > > > > On Fri, Oct 30, 2020 at 6:11 AM Daniel Vetter > > > wrote: > &g

[PATCH] drm/amdgpu/virt: fix handling of the atomic flag

2020-11-03 Thread Alex Deucher
Use the per device drm driver feature flags rather than the global one. This way we can make the drm driver struct const. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu

Re: [PATCH] drm/amdgpu/virt: fix handling of the atomic flag

2020-11-04 Thread Alex Deucher
On Wed, Nov 4, 2020 at 4:39 AM Daniel Vetter wrote: > > On Tue, Nov 03, 2020 at 04:54:50PM -0500, Alex Deucher wrote: > > Use the per device drm driver feature flags rather than the > > global one. This way we can make the drm driver struct const. > > > &g

Re: [bugreport] [5.10-rc1] Oops: 0000 [#1] SMP NOPTI bug which always starts as page allocation failure

2020-11-04 Thread Alex Deucher
On Tue, Nov 3, 2020 at 4:05 PM Mikhail Gavrilov wrote: > > Hi folks. > I observed hard reproductible the set of bugs. > It always started as > 1) kworker/u64:2: page allocation failure: order:5, > mode:0x40dc0(GFP_KERNEL|__GFP_COMP|__GFP_ZERO), > nodemask=(null),cpuset=/,mems_allowed=0 > Continiou

[pull] amdgpu, amdkfd drm-fixes-5.10

2020-11-04 Thread Alex Deucher
hlid fixes - Polaris DPM fix - Add support for Green Sardine amdkfd: - Fix an allocation failure check MAINTAINERS: - Fix path for amdgpu power management Aaron Liu (1): drm/amdgpu: enable green_sardine_asd.bin loading (v2) Alex

[pull] amdgpu, amdkfd, radeon amd-drm-next-5.11

2020-11-05 Thread Alex Deucher
green_sardine_asd.bin loading (v2) Alex Deucher (27): drm/amdgpu/swsmu: add interrupt work function drm/amdgpu/swsmu: add interrupt work handler for smu11 parts drm/amdgpu/gfx10: add updated register offsets for VGH drm/amdgpu: IP discovery table is not ready yet for VG drm/amdgpu

Re: [PATCH] drm/ttm: fix missing NULL check in the new page pool

2020-11-09 Thread Alex Deucher
On Fri, Nov 6, 2020 at 9:10 AM Christian König wrote: > > The pool parameter can be NULL if we free through the shrinker. > > Signed-off-by: Christian König Does this fix: https://gitlab.freedesktop.org/drm/amd/-/issues/1362 Acked-by: Alex Deucher > --- > drivers/gpu/

Re: [PATCH] drivers: amdgpu: amdgpu_display.c: Fix a spelling doens\'t to doesn\'t

2020-11-09 Thread Alex Deucher
On Mon, Nov 9, 2020 at 3:52 AM Bhaskar Chowdhury wrote: > > s/doens't/doesn't/p > > Signed-off-by: Bhaskar Chowdhury > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c > b/drive

Re: [PATCH 17/19] drm/radeon/radeon_kms: Fix misnaming of 'radeon_info_ioctl's dev param

2020-11-09 Thread Alex Deucher
deon/radeon_kms.c:226: warning: Excess function parameter > 'rdev' description in 'radeon_info_ioctl' > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.

Re: [PATCH 14/19] drm/amd/amdgpu/amdgpu_device: Provide documentation for 'reg_addr' params

2020-11-09 Thread Alex Deucher
#x27; > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:624: warning: Function parameter > or member 'reg_addr' not described in 'amdgpu_device_indirect_rreg64' > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Sum

Re: [PATCH 12/19] drm/amd/display/dc/basics/fixpt31_32: Move variables to where they're used

2020-11-09 Thread Alex Deucher
075409LL }; > | ^~~ > drivers/gpu/drm/amd/amdgpu/../display/include/fixed31_32.h:72:32: warning: > ‘dc_fixpt_pi’ defined but not used [-Wunused-const-variable=] > 72 | static const struct fixed31_32 dc_fixpt_pi = { 13493037705LL }; > | ^~~ > > Cc: Harry

Re: [PATCH 16/19] drm/amd/amdgpu/amdgpu_kms: Remove 'struct drm_amdgpu_info_device dev_info' from the stack

2020-11-09 Thread Alex Deucher
ng: the frame size of > 1128 bytes is larger than 1024 bytes [-Wframe-larger-than=] > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee

Re: [PATCH 17/19] drm/radeon/radeon_kms: Fix misnaming of 'radeon_info_ioctl's dev param

2020-11-09 Thread Alex Deucher
On Mon, Nov 9, 2020 at 2:56 PM Sam Ravnborg wrote: > > Hi Alex, > On Mon, Nov 09, 2020 at 02:50:35PM -0500, Alex Deucher wrote: > > On Fri, Nov 6, 2020 at 4:50 PM Lee Jones wrote: > > > > > > Fixes the following W=1 kernel build warning(s): > > > >

Re: [PATCH] drivers: amdgpu: amdgpu_display: Fixed the spelling of falg to flag

2020-11-09 Thread Alex Deucher
On Mon, Nov 9, 2020 at 4:16 PM Bhaskar Chowdhury wrote: > > s/falg/flag/p > > Signed-off-by: Bhaskar Chowdhury Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_

Re: [PATCH 15/20] drm/radeon/r600d: Move 'rc600_*' prototypes into shared header

2020-11-09 Thread Alex Deucher
*encoder, u32 offset, bool mute) > | ^ > drivers/gpu/drm/radeon/r600_hdmi.c:469:6: warning: no previous prototype for > ‘r600_hdmi_enable’ [-Wmissing-prototypes] > 469 | void r600_hdmi_enable(struct drm_encoder *encoder, bool enable) > | ^~~~ >

Re: [PATCH 00/20] [Set 3] Rid W=1 warnings from GPU

2020-11-09 Thread Alex Deucher
c | 2 -- > drivers/gpu/drm/radeon/radeon_ring.c | 3 ++ > drivers/gpu/drm/radeon/radeon_ttm.c| 8 ++--- > drivers/gpu/drm/radeon/si.c| 6 > 22 files changed, 96 insertions(+), 108 deletions(-) Instead of just dumping everything in radeon.h, I

Re: [PATCH] drm/amd/pm: Use kmemdup instead of kmalloc and memcpy

2020-11-10 Thread Alex Deucher
On Tue, Nov 10, 2020 at 11:57 AM Tian Tao wrote: > > Fixes coccicheck warning: > drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c:255: > 36-43: WARNING opportunity for kmemdup > > Signed-off-by: Tian Tao Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega

Re: [PATCH] amd/display/amdgpu_dm: delete same check in if condition

2020-11-10 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Nov 10, 2020 at 9:13 AM Harry Wentland wrote: > > On 2020-11-10 3:03 a.m., Bernard Zhao wrote: > > In function amdgpu_dm_connector_get_modes, drm_edid_is_valid > > will check weather (!edid), no need to check again in the if > > branch. > > > > Signed-off-by: Berna

Re: [PATCH 15/20] drm/radeon/r600d: Move 'rc600_*' prototypes into shared header

2020-11-10 Thread Alex Deucher
On Tue, Nov 10, 2020 at 4:41 AM Lee Jones wrote: > > On Tue, 10 Nov 2020, Sam Ravnborg wrote: > > > Hi Lee, > > > > > > the *d.h headers are supposed to just be hardware definitions. I'd > > > > prefer to keep driver stuff out of them. > > > > > > That's fine (I did wonder if that were the case).

Re: [PATCH 07/19] gpu: drm: scheduler: sched_entity: Demote non-conformant kernel-doc headers

2020-11-10 Thread Alex Deucher
keup' > drivers/gpu/drm/scheduler/sched_entity.c:330: warning: Function parameter or > member 'cb' not described in 'drm_sched_entity_wakeup' > > Cc: David Airlie > Cc: Daniel Vetter > Cc: Sumit Semwal > Cc: "Christian König" > Cc:

Re: [PATCH 15/19] gpu: drm: radeon: radeon_drv: Remove unused variable 'ret'

2020-11-10 Thread Alex Deucher
sed [-Wunused-but-set-variable] > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Gareth Hughes > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones Applied. Thank

Re: [PATCH 06/19] gpu: drm: scheduler: sched_main: Provide missing description for 'sched' paramter

2020-11-10 Thread Alex Deucher
On Thu, Nov 5, 2020 at 9:52 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/scheduler/sched_main.c:74: warning: Function parameter or > member 'sched' not described in 'drm_sched_rq_init' > > Cc: David Airlie > Cc: Daniel Vetter > Cc: Sumit Semwal

Re: [PATCH 18/19] gpu: drm: amd: amdgpu: amdgpu: Mark global variables as __maybe_unused

2020-11-10 Thread Alex Deucher
/amd/amdgpu/amdgpu.h:196:18: warning: ‘sched_policy’ defined > but not used [-Wunused-const-variable=] > > NB: Repeats ~650 times - snipped for brevity. > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Sumit Semwal

Re: [PATCH 17/19] gpu: drm: radeon: radeon_device: Fix a bunch of kernel-doc misdemeanours

2020-11-10 Thread Alex Deucher
uspend_kms' > drivers/gpu/drm/radeon/radeon_device.c:1669: warning: Function parameter or > member 'dev' not described in 'radeon_resume_kms' > drivers/gpu/drm/radeon/radeon_device.c:1669: warning: Function parameter or > member 'resume' not described

Re: [PATCH 06/19] drm/radeon/atom: Move prototype into shared location

2020-11-10 Thread Alex Deucher
warning: no previous > prototype for ‘radeon_atom_get_tv_timings’ [-Wmissing-prototypes] > 1791 | bool radeon_atom_get_tv_timings(struct radeon_device *rdev, int index, > | ^~~~~~ > > Cc: Alex Deucher > Cc: "Christian König" &

Re: [PATCH 07/19] drm/radeon/radeon_kms: Include header containing our own prototypes

2020-11-10 Thread Alex Deucher
type > for ‘radeon_get_vblank_counter_kms’ [-Wmissing-prototypes] > drivers/gpu/drm/radeon/radeon_kms.c:825:5: warning: no previous prototype > for ‘radeon_enable_vblank_kms’ [-Wmissing-prototypes] > drivers/gpu/drm/radeon/radeon_kms.c:852:6: warning: no previous prototype > for ‘radeo

Re: [PATCH 11/19] drm/radeon/radeon_drv: Source file headers are not good candidates for kernel-doc

2020-11-10 Thread Alex Deucher
On Fri, Nov 6, 2020 at 4:50 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/radeon/radeon_drv.c:2: warning: Cannot understand * file > radeon_drv.c > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airl

Re: [PATCH 13/19] drm/radeon/radeon_drv: Move prototypes to a shared headerfile

2020-11-10 Thread Alex Deucher
t drm_device *dev, struct drm_file > *file_priv) > | ^~ > drivers/gpu/drm/radeon/radeon_kms.c:705:6: warning: no previous prototype > for ‘radeon_driver_postclose_kms’ [-Wmissing-prototypes] > 705 | void radeon_driver_postclose_kms(struct drm_device *dev, > |

Re: [PATCH 15/19] drm/radeon: Move prototypes to shared header

2020-11-10 Thread Alex Deucher
~~~ > drivers/gpu/drm/radeon/radeon_kms.c:853:6: warning: no previous prototype > for ‘radeon_disable_vblank_kms’ [-Wmissing-prototypes] > 853 | void radeon_disable_vblank_kms(struct drm_crtc *crtc) > | ^ > > Cc: Alex Deucher > Cc: "Christian K

Re: [PATCH 18/19] drm/radeon/atombios_crtc: Remove description of non-existent function param 'encoder'

2020-11-10 Thread Alex Deucher
On Fri, Nov 6, 2020 at 4:50 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/radeon/atombios_crtc.c:1796: warning: Excess function > parameter 'encoder' description in 'radeon_get_shared_nondp_ppll' > > Cc: Al

Re: [PATCH 01/20] drm/radeon/radeon_ttm: Place declaration of 'rdev' in same clause as its use

2020-11-10 Thread Alex Deucher
d-but-set-variable] > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Jerome Glisse > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones Applied. Thanks!

Re: [PATCH 03/20] drm/radeon/radeon_fence: Demote some non-conformant kernel-doc headers and fix another

2020-11-10 Thread Alex Deucher
> member 'm' not described in 'radeon_debugfs_gpu_reset' > drivers/gpu/drm/radeon/radeon_fence.c:1010: warning: Function parameter or > member 'data' not described in 'radeon_debugfs_gpu_reset' > > Cc: Alex Deucher > Cc: "Christian Kön

Re: [PATCH 06/20] drm/radeon/radeon_connectors: Strip out set but unused variable 'ret'

2020-11-10 Thread Alex Deucher
> set but not used [-Wunused-but-set-variable] > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones Applied. Thanks! Alex

Re: [PATCH 07/20] drm/radeon/radeon_display: Remove unused variable 'mod'

2020-11-10 Thread Alex Deucher
d-but-set-variable] > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Sumit Semwal > Cc: report to > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Cc: linux-me...@vger.kernel.org >

Re: [PATCH 08/20] drm/radeon/radeon_i2c: Remove pointless function header

2020-11-10 Thread Alex Deucher
pu/drm/radeon/radeon_i2c.c:46: warning: Function parameter or > member 'use_aux' not described in 'radeon_ddc_probe' > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-...@lists.freedesktop.org &

Re: [PATCH 09/20] drm/radeon/radeon_irq_kms: Demote non-conformant kernel-doc fix another

2020-11-10 Thread Alex Deucher
set_irq_n_enabled' > drivers/gpu/drm/radeon/radeon_irq_kms.c:571: warning: Excess function > parameter 'num' description in 'radeon_irq_kms_set_irq_n_enabled' > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vet

Re: [PATCH 10/20] drm/radeon/radeon_ring: Add missing function parameters 'rdev' and 'data'

2020-11-10 Thread Alex Deucher
/drm/radeon/radeon_ring.c:240: warning: Function parameter or > member 'rdev' not described in 'radeon_ring_lockup_update' > drivers/gpu/drm/radeon/radeon_ring.c:283: warning: Function parameter or > member 'data' not described in 'radeon_ring_backup'

Re: [PATCH 11/20] drm/radeon/r600: Strip out set but unused 'tmp' variables

2020-11-10 Thread Alex Deucher
d-but-set-variable] > drivers/gpu/drm/radeon/r600.c: At top level: > drivers/gpu/drm/radeon/r600.c: In function ‘r600_mmio_hdp_flush’: > drivers/gpu/drm/radeon/r600.c:4393:7: warning: variable ‘tmp’ set but not > used [-Wunused-but-set-variable] > > Cc: Alex Deucher > Cc: &quo

Re: [PATCH 12/20] drm/radeon/radeon_cs: Fix a bunch of doc-rot issues

2020-11-10 Thread Alex Deucher
#x27; description in 'radeon_cs_packet_next_reloc' > drivers/gpu/drm/radeon/radeon_cs.c:844: warning: Excess function parameter > 'offset_start' description in 'radeon_cs_packet_next_reloc' > drivers/gpu/drm/radeon/radeon_cs.c:844: warning: Excess function

Re: [PATCH 18/20] drm/radeon/radeon_display: Fix function doc formatting and missing param issues

2020-11-10 Thread Alex Deucher
' not described in 'radeon_compute_pll_avivo' > drivers/gpu/drm/radeon/radeon_display.c:956: warning: Function parameter or > member 'ref_div_p' not described in 'radeon_compute_pll_avivo' > drivers/gpu/drm/radeon/radeon_display.c:956: warning: Functio

Re: [PATCH 19/20] drm/radeon/r600: Fix a misnamed parameter description and a formatting issue

2020-11-10 Thread Alex Deucher
/r600.c:2965: warning: Excess function parameter > 'fence' description in 'r600_copy_cpdma' > drivers/gpu/drm/radeon/r600.c:4382: warning: Function parameter or member > 'rdev' not described in 'r600_mmio_hdp_flush' > > Cc: Alex Deucher &g

Re: [PATCH 20/20] drm/radeon/cik: Fix a bunch of function parameter descriptions

2020-11-10 Thread Alex Deucher
> 'ring' not described in 'cik_vm_flush' > drivers/gpu/drm/radeon/cik.c:5690: warning: Function parameter or member > 'vm_id' not described in 'cik_vm_flush' > drivers/gpu/drm/radeon/cik.c:5690: warning: Function parameter or mem

Re: [PATCH 02/30] drm/radeon/evergreen: Remove set but unused variable 'mc_shared_chmap'

2020-11-10 Thread Alex Deucher
[-Wunused-but-set-variable] > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones Applied. Thanks! Alex > --- > driver

Re: [PATCH 01/30] drm/radeon/evergreen: Add comment for 'evergreen_page_flip()'s 'async' param

2020-11-10 Thread Alex Deucher
async' not described in 'evergreen_page_flip' > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones Applied with minor fixups

Re: [PATCH 04/30] drm/radeon/si: Remove set but unused variable 'mc_shared_chmap'

2020-11-10 Thread Alex Deucher
t-variable] > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones Applied. Thanks! Alex > --- > drivers/gpu/drm/radeon/si.

Re: [PATCH 03/30] drm/radeon/ni: Demote vague attempt at function header doc

2020-11-10 Thread Alex Deucher
'cayman_vm_flush' > drivers/gpu/drm/radeon/ni.c:2679: warning: Function parameter or member > 'vm_id' not described in 'cayman_vm_flush' > drivers/gpu/drm/radeon/ni.c:2679: warning: Function parameter or member > 'pd_addr' not described in &#x

Re: [PATCH 05/30] drm/radeon/cik: Remove set but unused variable 'mc_shared_chmap'

2020-11-10 Thread Alex Deucher
t-variable] > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Sumit Semwal > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Cc: linux-me...@vger.kernel.org > Cc: linaro-mm-...@lists.linar

Re: [PATCH 09/30] drm/radeon/radeon_vm: Fix some function parameter documentation

2020-11-10 Thread Alex Deucher
m_bo_update' > drivers/gpu/drm/radeon/radeon_vm.c:915: warning: Excess function parameter > 'vm' description in 'radeon_vm_bo_update' > drivers/gpu/drm/radeon/radeon_vm.c:915: warning: Excess function parameter > 'bo' description in 'radeon_vm_bo_u

Re: [PATCH 07/30] drm/radeon/kv_dpm: Strip out unused functions and their tables

2020-11-10 Thread Alex Deucher
iable=] > drivers/gpu/drm/radeon/kv_dpm.c:80:43: warning: ‘mc0_local_cac_cfg_kv’ > defined but not used [-Wunused-const-variable=] > drivers/gpu/drm/radeon/kv_dpm.c:67:43: warning: ‘sx_local_cac_cfg_kv’ > defined but not used [-Wunused-const-variable=] > > Cc: Alex Deucher > Cc:

Re: [PATCH 06/30] drm/radeon/trinity_dpm: Remove some defined but never used arrays

2020-11-10 Thread Alex Deucher
.c:131:18: warning: > ‘trinity_mgcg_shls_disable’ defined but not used [-Wunused-const-variable=] > drivers/gpu/drm/radeon/trinity_dpm.c:120:18: warning: > ‘trinity_mgcg_shls_enable’ defined but not used [-Wunused-const-variable=] > > Cc: Alex Deucher > Cc: "Christian König&

Re: [PATCH 12/30] drm/radeon/radeon_dp_mst: Remove unused variable 'ret' from radeon_mst_encoder_dpms()

2020-11-10 Thread Alex Deucher
ot used [-Wunused-but-set-variable] > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones Applied. Thanks! Ale

Re: [PATCH 10/30] drm/radeon/radeon_sync: Add description for function param 'rdev'

2020-11-10 Thread Alex Deucher
On Tue, Nov 10, 2020 at 2:31 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/radeon/radeon_sync.c:92: warning: Function parameter or > member 'rdev' not described in 'radeon_sync_resv' > > Cc: Alex Deucher &g

Re: [PATCH 11/30] drm/radeon/radeon_ib: Supply description for 'radeon_ib_get's get param

2020-11-10 Thread Alex Deucher
On Tue, Nov 10, 2020 at 2:31 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/radeon/radeon_ib.c:61: warning: Function parameter or member > 'vm' not described in 'radeon_ib_get' > > Cc: Alex Deucher > Cc:

Re: [PATCH 08/30] drm/radeon/ci_dpm: Remove set but unused variable 'dpm_event_src'

2020-11-10 Thread Alex Deucher
28: warning: variable ‘dpm_event_src’ > set but not used [-Wunused-but-set-variable] > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off

Re: [PATCH 13/30] drm/radeon/radeon_mn: Supply description for 'cur_seq' even if it is unused

2020-11-10 Thread Alex Deucher
On Tue, Nov 10, 2020 at 2:31 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/radeon/radeon_mn.c:51: warning: Function parameter or member > 'cur_seq' not described in 'radeon_mn_invalidate' > > Cc: Alex Deuc

Re: [PATCH 16/30] drm/radeon/r100: Fix some kernel-doc formatting, misnaming and missing issues

2020-11-10 Thread Alex Deucher
/gpu/drm/radeon/r100.c:1425: warning: Function parameter or member > 'p' not described in 'r100_cs_packet_parse_vline' > drivers/gpu/drm/radeon/r100.c:1425: warning: Excess function parameter > 'parser' description in 'r100_cs_packet_parse_vline' > > Cc: Alex D

Re: [PATCH 17/30] drm/radeon/r600_cs: Fix some doc-rot and supply missing function param docs

2020-11-10 Thread Alex Deucher
texture_resource' > drivers/gpu/drm/radeon/r600_cs.c:1473: warning: Function parameter or member > 'mip_offset' not described in 'r600_check_texture_resource' > drivers/gpu/drm/radeon/r600_cs.c:1473: warning: Function parameter or member > 'tiling_flags&#x

Re: [PATCH 15/30] drm/radeon/cik_sdma: Demote vague attempt at kernel-doc

2020-11-10 Thread Alex Deucher
deon/cik_sdma.c:949: warning: Function parameter or member > 'vm_id' not described in 'cik_dma_vm_flush' > drivers/gpu/drm/radeon/cik_sdma.c:949: warning: Function parameter or member > 'pd_addr' not described in 'cik_dma_vm_flush' > > Cc: Alex

Re: [PATCH 18/30] drm/radeon/evergreen_cs: Fix misnaming issues surrounding 'p' param

2020-11-10 Thread Alex Deucher
described in 'evergreen_is_safe_reg' > drivers/gpu/drm/radeon/evergreen_cs.c:1757: warning: Excess function > parameter 'parser' description in 'evergreen_is_safe_reg' > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Dan

Re: [PATCH 14/30] drm/radeon/evergreen_dma: Fix doc-rot of function parameter 'resv'

2020-11-10 Thread Alex Deucher
rm/radeon/evergreen_dma.c:112: warning: Excess function > parameter 'fence' description in 'evergreen_copy_dma' > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Sumit Semwal > Cc: amd-...@lists.freedesktop

Re: [PATCH 27/30] drm/radeon/ni: Remove set but unused variable 'mc_shared_chmap'

2020-11-10 Thread Alex Deucher
t-variable] > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones Applied. Thanks! Alex > --- > drivers/gpu/drm/

Re: [PATCH 25/30] drm/radeon/sumo_dpm: Move 'sumo_get_pi()'s prototype into shared header

2020-11-10 Thread Alex Deucher
adeon_device *rdev) > | ^~~~~~~ > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones Applied. Thanks! Alex > --- >

Re: [PATCH] amdgpu/test: deadlock test for CZ family and RV family

2020-11-12 Thread Alex Deucher
On Thu, Nov 12, 2020 at 10:36 AM wrote: > > From: Rajib Mahapatra > > It enables the test for RV2 and PCO, whole GPU reset is not supported > for others. > > Signed-off-by: Rajib Mahapatra > Change-Id: Id51605d07b334ecea7a88b3c95fdd57008a4458d libdrm uses gltlab merge requests. Please file a g

Re: [PATCH 06/30] drm/amd/amdgpu/amdgpu_kms: Fix misnaming of parameter 'dev'

2020-11-12 Thread Alex Deucher
m/amd/amdgpu/amdgpu_kms.c:487: warning: Excess function > parameter 'adev' description in 'amdgpu_info_ioctl' > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@l

Re: [PATCH 07/30] drm/amd/amdgpu/amdgpu_fence: Fix some issues pertaining to function documentation

2020-11-12 Thread Alex Deucher
ning: Excess function > parameter 'fence' description in 'amdgpu_fence_release' > drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c:749: warning: Function parameter > or member 'm' not described in 'amdgpu_debugfs_gpu_recover' > drivers/gpu/drm/amd/amdgpu/amdgpu

Re: [PATCH 12/30] drm/amd/amdgpu/amdgpu_ttm: Demote non-conformant kernel-doc headers, fix slightly lacking ones

2020-11-12 Thread Alex Deucher
g: Function parameter or > member 'f' not described in 'amdgpu_ttm_gtt_read' > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c:2336: warning: Function parameter or > member 'buf' not described in 'amdgpu_ttm_gtt_read' > drivers/gpu/drm/a

Re: [PATCH 14/30] drm/amd/amdgpu/amdgpu_ring: Fix a bunch of function misdocumentation

2020-11-12 Thread Alex Deucher
cription in 'amdgpu_ring_fini' > drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c:325: warning: Function parameter or > member 'ring' not described in 'amdgpu_ring_emit_reg_write_reg_wait_helper' > drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c:325: warning: Excess fun

Re: [PATCH 15/30] drm/amd/amdgpu/amdgpu_display: Remove pointless header

2020-11-12 Thread Alex Deucher
onnector' not described in 'amdgpu_display_ddc_probe' > drivers/gpu/drm/amd/amdgpu/amdgpu_display.c:450: warning: Function parameter > or member 'use_aux' not described in 'amdgpu_display_ddc_probe' > > Cc: Alex Deucher > Cc: "Christian König" &

Re: [PATCH 19/30] drm/amd/amdgpu/amdgpu_cs: Add a couple of missing function param descriptions

2020-11-12 Thread Alex Deucher
rs/gpu/drm/amd/amdgpu/amdgpu_cs.c:1655: warning: Function parameter or > member 'map' not described in 'amdgpu_cs_find_mapping' > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Sumit Semwal > Cc: Jerome Glis

Re: [PATCH 29/30] drm/amd/amdgpu/atombios_encoders: Remove set but unused variable 'backlight_level'

2020-11-12 Thread Alex Deucher
warning: variable > ‘backlight_level’ set but not used [-Wunused-but-set-variable] > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Luben Tuikov > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org &

[pull] amdgpu drm-fixes-5.10

2020-11-12 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.10. The following changes since commit 4241b0411c60a97f87a25ff4da92dac53beb3039: drm/amdgpu/display: remove DRM_AMD_DC_GREEN_SARDINE (2020-11-04 08:43:50 -0500) are available in the Git repository at: git://people.freedesktop.org/~agd5f/linux tags/amd-drm-fixe

Re: [PATCH 00/19] [Set 2] Rid W=1 warnings from GPU

2020-11-12 Thread Alex Deucher
On Fri, Nov 13, 2020 at 2:19 AM Lee Jones wrote: > > On Fri, 06 Nov 2020, Lee Jones wrote: > > > This set is part of a larger effort attempting to clean-up W=1 > > kernel builds, which are currently overwhelmingly riddled with > > niggly little warnings. > > > > There are 5000 warnings to work thr

Re: [PATCH 01/40] drm/amd/include/vega10_ip_offset: Mark _BASE structs as __maybe_unused

2020-11-13 Thread Alex Deucher
> | ^ > drivers/gpu/drm/amd/amdgpu/../include/navi14_ip_offset.h:144:29: warning: > ‘PCIE0_BASE’ defined but not used [-Wunused-const-variable=] > 144 | static const struct IP_BASE PCIE0_BASE ={ { { { 0x, > 0x0014, 0x0D20, 0x00010400, 0x0241B000 } }, >

Re: [PATCH 02/40] drm/amd/display/dc/core/dc_link_dp: Move DP_VGA_LVDS_CONVERTER_ID_{2, 3} to where they're used

2020-11-13 Thread Alex Deucher
sed > [-Wunused-const-variable=] > 121 | static const uint8_t DP_VGA_LVDS_CONVERTER_ID_2[] = "sivarT"; > > NB: Repeated ~100 times - snipped for brevity > > Cc: Harry Wentland > Cc: Leo Li > Cc: Alex Deucher > Cc: "Christian König&quo

Re: [PATCH 02/40] drm/amd/display/dc/core/dc_link_dp: Move DP_VGA_LVDS_CONVERTER_ID_{2, 3} to where they're used

2020-11-13 Thread Alex Deucher
On Fri, Nov 13, 2020 at 10:23 AM Alex Deucher wrote: > > On Fri, Nov 13, 2020 at 8:49 AM Lee Jones wrote: > > > > This patch fixes >200 warnings. > > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/gpu/drm/amd/amdgpu/

Re: [PATCH 02/40] drm/amd/display/dc/core/dc_link_dp: Move DP_VGA_LVDS_CONVERTER_ID_{2, 3} to where they're used

2020-11-13 Thread Alex Deucher
sed > [-Wunused-const-variable=] > 121 | static const uint8_t DP_VGA_LVDS_CONVERTER_ID_2[] = "sivarT"; > > NB: Repeated ~100 times - snipped for brevity > > Cc: Harry Wentland > Cc: Leo Li > Cc: Alex Deucher > Cc: "Christian König&quo

Re: [PATCH 03/40] drm/amd/display/dc/core/dc_link_ddc: Move DP_DVI_CONVERTER_ID_{4, 5} to where they're used

2020-11-13 Thread Alex Deucher
gt; warning: ‘DP_DVI_CONVERTER_ID_4’ defined but not used > [-Wunused-const-variable=] > 125 | static const uint8_t DP_DVI_CONVERTER_ID_4[] = "m2DVIa"; > | ^~~~~ > > Cc: Harry Wentland > Cc: Leo Li > Cc: Alex Deucher > Cc: "Christian Kön

Re: [PATCH 04/40] drm/amd/amdgpu/amdgpu_drv: Move 'amdgpu_info_ioctl()'s prototype to shared header

2020-11-13 Thread Alex Deucher
_device *dev, void *data, struct > drm_file *filp) > | ^~~~~~~~~ > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jo

Re: [PATCH 05/40] drm/amd/amdgpu/amdgpu_ring: Fix misnaming of param 'max_dw'

2020-11-13 Thread Alex Deucher
/amd/amdgpu/amdgpu_ring.c:168: warning: Excess function > parameter 'max_ndw' description in 'amdgpu_ring_init' > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Sumit Semwal > Cc: amd-...@lists.

Re: [PATCH 08/40] drm/amd/amdgpu/amdgpu_ib: Fix some incorrect/incomplete function documentation

2020-11-13 Thread Alex Deucher
pu/drm/amd/amdgpu/amdgpu_ib.c:125: warning: Function parameter or > member 'job' not described in 'amdgpu_ib_schedule' > drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c:125: warning: Excess function > parameter 'adev' description in 'amdgpu_ib_schedule' &g

Re: [PATCH 11/40] drm/amd/amdgpu/amdgpu_pll: Fix kernel-doc formatting, missing and extra params

2020-11-13 Thread Alex Deucher
described in 'amdgpu_pll_compute' > drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c:317: warning: Excess function > parameter 'encoder' description in 'amdgpu_pll_get_shared_nondp_ppll' > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airli

Re: [PATCH 16/40] drm/amd/amdgpu/amdgpu_sync: Fix misnamed, missing and extra param descriptions

2020-11-13 Thread Alex Deucher
t; drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c:203: warning: Function parameter or > member 'adev' not described in 'amdgpu_sync_resv' > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Sumit Semwal >

Re: [PATCH 19/40] drm/amd/amdgpu/amdgpu_vram_mgr: Add missing descriptions for 'dev' and 'dir'

2020-11-13 Thread Alex Deucher
s/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c:648: warning: Function > parameter or member 'dir' not described in 'amdgpu_vram_mgr_free_sgt' > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-...@lists.f

Re: [PATCH 21/40] drm/amd/amdgpu/amdgpu_virt: Make local function 'amdgpu_virt_update_vf2pf_work_item()' static

2020-11-13 Thread Alex Deucher
On Fri, Nov 13, 2020 at 8:50 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:560:6: warning: no previous > prototype for ‘amdgpu_virt_update_vf2pf_work_item’ [-Wmissing-prototypes] > > Cc: Alex Deucher &

Re: [PATCH 29/40] drm/amd/amdgpu/amdgpu_csa: Remove set but unused variable 'r'

2020-11-13 Thread Alex Deucher
ot used [-Wunused-but-set-variable] > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: monk@amd.com > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones Ap

Re: [PATCH 22/40] drm/amd/amdgpu/amdgpu_sched: Consume our own header containing prototypes

2020-11-13 Thread Alex Deucher
dgpu_sched.c:122:5: warning: no previous > prototype for ‘amdgpu_sched_ioctl’ [-Wmissing-prototypes] > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Luben Tuikov > Cc: Andres Rodriguez > Cc: amd-...@lists.freedesktop

Re: [PATCH 24/40] drm/amd/amdgpu/amdgpu_ids: Supply missing docs for 'id' and 'vmhub'

2020-11-13 Thread Alex Deucher
rs/gpu/drm/amd/amdgpu/amdgpu_ids.c:523: warning: Function parameter or > member 'vmhub' not described in 'amdgpu_vmid_reset' > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Sumit Semwal > Cc: Felix Kuehli

<    1   2   3   4   5   6   7   8   9   10   >