Re: [RFC] Add BPF_PROG_TYPE_CGROUP_IOCTL

2021-05-07 Thread Alex Deucher
On Fri, May 7, 2021 at 12:13 PM Daniel Vetter wrote: > > On Fri, May 07, 2021 at 11:33:46AM -0400, Kenny Ho wrote: > > On Fri, May 7, 2021 at 4:59 AM Daniel Vetter wrote: > > > > > > Hm I missed that. I feel like time-sliced-of-a-whole gpu is the easier gpu > > > cgroups controler to get started,

Re: [RFC] Add BPF_PROG_TYPE_CGROUP_IOCTL

2021-05-07 Thread Alex Deucher
On Fri, May 7, 2021 at 12:26 PM Daniel Vetter wrote: > > On Fri, May 07, 2021 at 12:19:13PM -0400, Alex Deucher wrote: > > On Fri, May 7, 2021 at 12:13 PM Daniel Vetter wrote: > > > > > > On Fri, May 07, 2021 at 11:33:46AM -0400, Kenny Ho wrote: > > >

Re: [RFC] Add BPF_PROG_TYPE_CGROUP_IOCTL

2021-05-07 Thread Alex Deucher
On Fri, May 7, 2021 at 12:31 PM Alex Deucher wrote: > > On Fri, May 7, 2021 at 12:26 PM Daniel Vetter wrote: > > > > On Fri, May 07, 2021 at 12:19:13PM -0400, Alex Deucher wrote: > > > On Fri, May 7, 2021 at 12:13 PM Daniel Vetter wrote: > > > > > >

Re: [PATCH 0/4] drm: Mark DRM's AGP code as legacy

2021-05-07 Thread Alex Deucher
-tested with different config options selected. > > Thomas Zimmermann (4): > drm/radeon: Move AGP helpers into radeon driver > drm/radeon: Move AGP data structures into radeon > drm: Mark PCI AGP helpers as legacy > drm: Mark AGP implementation and ioctls as legacy S

Re: [RFC] Add BPF_PROG_TYPE_CGROUP_IOCTL

2021-05-07 Thread Alex Deucher
On Fri, May 7, 2021 at 3:33 PM Tejun Heo wrote: > > Hello, > > On Fri, May 07, 2021 at 06:54:13PM +0200, Daniel Vetter wrote: > > All I meant is that for the container/cgroups world starting out with > > time-sharing feels like the best fit, least because your SRIOV designers > > also seem to thin

Re: [RFC] Add BPF_PROG_TYPE_CGROUP_IOCTL

2021-05-07 Thread Alex Deucher
On Fri, May 7, 2021 at 4:59 PM Tejun Heo wrote: > > Hello, > > On Fri, May 07, 2021 at 03:55:39PM -0400, Alex Deucher wrote: > > The problem is temporal partitioning on GPUs is much harder to enforce > > unless you have a special case like SR-IOV. Spatial partitioning,

Re: Tested

2021-05-10 Thread Alex Deucher
Sorry, what patch are you referring to? Alex On Mon, May 10, 2021 at 4:04 AM wrote: > > I have tested this on my end and it resolves the 120hz problem. > > Tested-By: Ryan Houdek

Re: [PATCH] drm: Include iff CONFIG_AGP is set

2021-05-10 Thread Alex Deucher
> Cc: Thomas Zimmermann > Cc: Alex Deucher > Cc: Christian König > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: David Airlie > Cc: Daniel Vetter > Cc: "Christian König" > Cc: Christophe JAILLET > Cc: Jason Yan > Cc: Lee Jones > Cc: Sa

Re: [PATCH] drm/amd/display: remove unused function dc_link_perform_link_training

2021-05-10 Thread Alex Deucher
Applied. Thanks! Alex On Sun, May 9, 2021 at 11:42 AM Rouven Czerwinski wrote: > > This function is not used anywhere, remove it. It was added in > 40dd6bd376a4 ("drm/amd/display: Linux Set/Read link rate and lane count > through debugfs") and moved in fe798de53a7a ("drm/amd/display: Move link

Re: [PATCH] drm/amd/amdgpu: Fix errors in function documentation

2021-05-10 Thread Alex Deucher
Applied. Thanks! Alex On Sun, May 9, 2021 at 12:30 PM Christian König wrote: > > Am 09.05.21 um 16:49 schrieb Dwaipayan Ray: > > Fix a couple of syntax errors and removed one excess > > parameter in the function documentations which lead > > to kernel docs build warning. > > > > Signed-off-by:

Re: [PATCH] drm/radeon/ni_dpm: Fix booting bug

2021-05-10 Thread Alex Deucher
On Sun, May 9, 2021 at 6:48 PM Gustavo A. R. Silva wrote: > > Create new structure NISLANDS_SMC_SWSTATE_SINGLE, as initialState.levels > and ACPIState.levels are never actually used as flexible arrays. Those > arrays can be used as simple objects of type > NISLANDS_SMC_HW_PERFORMANCE_LEVEL, instea

Re: [PATCH] drm/radeon/si_dpm: Fix SMU power state load

2021-05-10 Thread Alex Deucher
Applied. Thanks! Alex On Mon, May 10, 2021 at 1:51 AM Kai-Heng Feng wrote: > > On Mon, May 10, 2021 at 6:54 AM Gustavo A. R. Silva > wrote: > > > > Create new structure SISLANDS_SMC_SWSTATE_SINGLE, as initialState.levels > > and ACPIState.levels are never actually used as flexible arrays. Thos

Re: [PATCH] drm/amd/pm: Fix out-of-bounds bug

2021-05-10 Thread Alex Deucher
On Mon, May 10, 2021 at 4:45 PM Gustavo A. R. Silva wrote: > > Create new structure SISLANDS_SMC_SWSTATE_SINGLE, as initialState.levels > and ACPIState.levels are never actually used as flexible arrays. Those > arrays can be used as simple objects of type > SISLANDS_SMC_HW_PERFORMANCE_LEVEL, inste

Re: [PATCH 1/1] drm/amd/display: Delete several unneeded bool conversions

2021-05-10 Thread Alex Deucher
Applied. Thanks! Alex On Mon, May 10, 2021 at 8:16 AM Zhen Lei wrote: > > The result of an expression consisting of a single relational operator is > already of the bool type and does not need to be evaluated explicitly. > > No functional change. > > Signed-off-by: Zhen Lei > --- > drivers/gp

Re: [PATCH 1/1] drm/amdgpu: Delete two unneeded bool conversions

2021-05-10 Thread Alex Deucher
Applied. Thanks! Alex On Mon, May 10, 2021 at 8:24 AM Zhen Lei wrote: > > The result of an expression consisting of a single relational operator is > already of the bool type and does not need to be evaluated explicitly. > > No functional change. > > Signed-off-by: Zhen Lei > --- > drivers/gp

Re: [PATCH] drm/amd/display: Expose active display color configurations to userspace

2021-05-10 Thread Alex Deucher
On Fri, May 7, 2021 at 3:27 PM Werner Sembach wrote: > > xrandr --prop and other userspace info tools have currently no way of > telling which color configuration is used on HDMI and DP ports. > > The ongoing transsition from HDMI 1.4 to 2.0 and the different bandwidth > requirements of YCbCr 4:2:

Re: [RFC] Add BPF_PROG_TYPE_CGROUP_IOCTL

2021-05-11 Thread Alex Deucher
On Fri, May 7, 2021 at 7:45 PM Tejun Heo wrote: > > Hello, > > On Fri, May 07, 2021 at 06:30:56PM -0400, Alex Deucher wrote: > > Maybe we are speaking past each other. I'm not following. We got > > here because a device specific cgroup didn't make sense. W

Re: [PATCH v6 06/16] drm/amdgpu: Handle IOMMU enabled case.

2021-05-11 Thread Alex Deucher
On Mon, May 10, 2021 at 12:37 PM Andrey Grodzovsky wrote: > > Handle all DMA IOMMU gropup related dependencies before the > group is removed. > > v5: Drop IOMMU notifier and switch to lockless call to ttm_tt_unpopulate > v6: Drop the BO unamp list > > Signed-off-by: Andrey Grodzovsky > --- > dri

Re: [PATCH] Documentation: gpu: Mention the requirements for new properties

2021-05-11 Thread Alex Deucher
On Tue, May 11, 2021 at 11:55 AM Maxime Ripard wrote: > > New KMS properties come with a bunch of requirements to avoid each > driver from running their own, inconsistent, set of properties, > eventually leading to issues like property conflicts, inconsistencies > between drivers and semantics, et

Re: [PATCH v2] drm/radeon/dpm: Disable sclk switching on Oland when two 4K 60Hz monitors are connected

2021-05-11 Thread Alex Deucher
On Mon, May 10, 2021 at 11:33 PM Kai-Heng Feng wrote: > > On Fri, Apr 30, 2021 at 12:57 PM Kai-Heng Feng > wrote: > > > > Screen flickers rapidly when two 4K 60Hz monitors are in use. This issue > > doesn't happen when one monitor is 4K 60Hz (pixelclock 594MHz) and > > another one is 4K 30Hz (pix

Re: New uAPI for color management proposal and feedback request

2021-05-12 Thread Alex Deucher
On Wed, May 12, 2021 at 9:04 AM Ville Syrjälä wrote: > > On Wed, May 12, 2021 at 02:06:56PM +0200, Werner Sembach wrote: > > Hello, > > > > In addition to the existing "max bpc", and "Broadcast RGB/output_csc" drm > > properties I propose 4 new properties: > > "preferred pixel encoding", "active

[pull] amdgpu, amdkfd, radeon drm-next-5.14

2021-05-12 Thread Alex Deucher
/fxkamd/hmm-wip -------- Alex Deucher (12): drm/amdgpu/gmc9: remove dummy read workaround for newer chips drm/amdgpu/display: add documentation for dmcub_trace_event_en MAINTAINERS: fix a few more amdgpu tree links drm/amdgpu: Add graphics cache rinse pack

Re: [PATCH v7 09/16] drm/amdgpu: Guard against write accesses after device removal

2021-05-12 Thread Alex Deucher
On Wed, May 12, 2021 at 10:27 AM Andrey Grodzovsky wrote: > > This should prevent writing to memory or IO ranges possibly > already allocated for other uses after our device is removed. > > v5: > Protect more places wher memcopy_to/form_io takes place where > Protect IB submissions > > v6: Switc

Re: [PATCH v7 09/16] drm/amdgpu: Guard against write accesses after device removal

2021-05-12 Thread Alex Deucher
On Wed, May 12, 2021 at 4:30 PM Andrey Grodzovsky wrote: > > > > On 2021-05-12 4:17 p.m., Alex Deucher wrote: > > On Wed, May 12, 2021 at 10:27 AM Andrey Grodzovsky > > wrote: > >> > >> This should prevent writing to memory or IO ranges possibly >

Re: [PATCH v7 09/16] drm/amdgpu: Guard against write accesses after device removal

2021-05-13 Thread Alex Deucher
On Thu, May 13, 2021 at 10:47 AM Andrey Grodzovsky wrote: > > > > On 2021-05-12 4:50 p.m., Alex Deucher wrote: > > On Wed, May 12, 2021 at 4:30 PM Andrey Grodzovsky > > wrote: > >> > >> > >> > >> On 2021-05-12 4:17 p.m., Alex

Re: [PATCH 0/7] Per client engine busyness

2021-05-13 Thread Alex Deucher
On Thu, May 13, 2021 at 7:00 AM Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > Resurrect of the previosuly merged per client engine busyness patches. In a > nutshell it enables intel_gpu_top to be more top(1) like useful and show not > only physical GPU engine usage but per process view as we

[pull] amdgpu, radeon drm-fixes-5.13

2021-05-13 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.13. The following changes since commit 875d598db60ac81e768fdfd2c589f6209038488b: MAINTAINERS: Update address for Emma Anholt (2021-05-11 20:38:08 +0200) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-5

Re: [PATCH 0/7] Per client engine busyness

2021-05-13 Thread Alex Deucher
+ David, Christian On Thu, May 13, 2021 at 12:41 PM Tvrtko Ursulin wrote: > > > Hi, > > On 13/05/2021 16:48, Alex Deucher wrote: > > On Thu, May 13, 2021 at 7:00 AM Tvrtko Ursulin > > wrote: > >> > >> From: Tvrtko Ursulin > >> > >>

Re: [PATCH] drm/amdgpu: Fix GPU TLB update error when PAGE_SIZE > AMDGPU_PAGE_SIZE

2021-05-14 Thread Alex Deucher
Applied. Thanks! Alex On Fri, May 14, 2021 at 3:18 AM Christian König wrote: > > Am 14.05.21 um 08:40 schrieb Huacai Chen: > > From: Yi Li > > > > When PAGE_SIZE is larger than AMDGPU_PAGE_SIZE, the number of GPU TLB > > entries which need to update in amdgpu_map_buffer() should be multiplied

Re: dual RX460 result in logspam about P2P DMA

2021-05-17 Thread Alex Deucher
On Sat, May 15, 2021 at 10:12 AM Richard Dietrich Wachler wrote: > > Excuse my novicesness, > > i use 2 RX460 on a KGPE-D16 server board to drive 4 displays. > > 02:00.0 VGA compatible controller: Advanced Micro Devices, Inc. > [AMD/ATI] Baffin [Radeon RX 460/560D / Pro > 450/455/460/555/555X/560/

Re: [PATCH] dma-buf: fix unintended pin/unpin warnings

2021-05-17 Thread Alex Deucher
ntel/-/issues/3481 > Fixes: c545781e1c55 ("dma-buf: doc polish for pin/unpin") > CC: sta...@kernel.org Reviewed-by: Alex Deucher > --- > drivers/dma-buf/dma-buf.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/dma-

Re: [trivial PATCH] drm/amd/display: Fix typo of format termination newline

2021-05-17 Thread Alex Deucher
On Sat, May 15, 2021 at 1:01 PM Joe Perches wrote: > > /n should be \n > > Signed-off-by: Joe Perches Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/display/dc/dcn30/dcn30_resource.c | 2 +- > drivers/gpu/drm/amd/display/dc/dcn301/dcn301_resource.c | 2 +- > drivers/gpu/drm/amd/display/

Re: [PATCH v7 12/16] drm/amdgpu: Fix hang on device removal.

2021-05-17 Thread Alex Deucher
Reviewed-by: Alex Deucher On Mon, May 17, 2021 at 10:40 AM Andrey Grodzovsky wrote: > > Ping > > Andrey > > On 2021-05-14 10:42 a.m., Andrey Grodzovsky wrote: > > Ping > > > > Andrey > > > > On 2021-05-12 10:26 a.m., Andrey Grodzovsky wrote: >

Re: [PATCH v7 16/16] drm/amdgpu: Unmap all MMIO mappings

2021-05-17 Thread Alex Deucher
On Wed, May 12, 2021 at 10:27 AM Andrey Grodzovsky wrote: > > Access to those must be prevented post pci_remove > > v6: Drop BOs list, unampping VRAM BAR is enough. > > Signed-off-by: Andrey Grodzovsky > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 24 +++--- > drivers/gpu/

Re: [PATCH v7 16/16] drm/amdgpu: Unmap all MMIO mappings

2021-05-17 Thread Alex Deucher
On Mon, May 17, 2021 at 2:46 PM Andrey Grodzovsky wrote: > > > > On 2021-05-17 1:43 p.m., Alex Deucher wrote: > > On Wed, May 12, 2021 at 10:27 AM Andrey Grodzovsky > > wrote: > >> > >> Access to those must be prevented post pci_remove > >> &

Re: [PATCH v3 00/14] Driver of Intel(R) Gaussian & Neural Accelerator

2021-05-17 Thread Alex Deucher
On Mon, May 17, 2021 at 3:12 PM Thomas Zimmermann wrote: > > Hi > > Am 17.05.21 um 09:40 schrieb Daniel Vetter: > > On Fri, May 14, 2021 at 11:00:38AM +0200, Arnd Bergmann wrote: > >> On Fri, May 14, 2021 at 10:34 AM Greg Kroah-Hartman > >> wrote: > >>> On Thu, May 13, 2021 at 01:00:26PM +0200, M

Re: [PATCH 1/3] gpu: drm: replace occurrences of invalid character

2021-05-19 Thread Alex Deucher
Pushed out to drm-misc-next. Also fixed up Michel's name. Alex On Wed, May 19, 2021 at 11:56 AM Randy Dunlap wrote: > > On 5/19/21 1:15 AM, Mauro Carvalho Chehab wrote: > > There are some places at drm that ended receiving a > > REPLACEMENT CHARACTER U+fffd ('�'), probably because of > > some b

Re: [PATCH] vgaarb: Use ACPI HID name to find integrated GPU

2021-05-19 Thread Alex Deucher
> Integrated GPU on ACPI platform generally has _DOD and _DOS method, so > use that as predicate to find integrated GPU. If the new strategy > doesn't work, fallback to use the first device as boot VGA. > > Signed-off-by: Kai-Heng Feng Reviewed-by: Alex Deucher Unles

[pull] radeon, amdgpu drm-fixes-5.13

2021-05-19 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.13. The following changes since commit d07f6ca923ea0927a1024dfccafc5b53b61cfecc: Linux 5.13-rc2 (2021-05-16 15:27:44 -0700) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-5.13-2021-05-19 for you to fe

[pull] amdgpu, amdkfd, radeon drm-next-5.14

2021-05-19 Thread Alex Deucher
/fxkamd/hmm-wip -------- Alex Deucher (12): drm/amdgpu/gmc9: remove dummy read workaround for newer chips drm/amdgpu/display: add documentation for dmcub_trace_event_en MAINTAINERS: fix a few more amdgpu tree links drm/amdgpu: Add

Re: [PATCH] vgaarb: Use ACPI HID name to find integrated GPU

2021-05-20 Thread Alex Deucher
Pushed to drm-misc-next. Thanks! Alex On Wed, May 19, 2021 at 12:45 PM Alex Deucher wrote: > > On Wed, May 19, 2021 at 9:57 AM Kai-Heng Feng > wrote: > > > > Commit 3d42f1ddc47a ("vgaarb: Keep adding VGA device in queue") assumes > > the first device

Re: [PATCH 03/38] drm/radeon/radeon_cs: Fix incorrectly documented function 'radeon_cs_parser_fini'

2021-05-20 Thread Alex Deucher
s_parser_fini(). Prototype was for radeon_cs_parser_fini() instead > > > > Cc: Alex Deucher > > Cc: "Christian König" > > Cc: David Airlie > > Cc: Daniel Vetter > > Cc: Sumit Semwal > > Cc: Jerome Glisse > > Cc: amd-...@lists.freedeskto

Re: [PATCH 10/38] drm/amd/amdgpu/amdgpu_ids: Correct some function name disparity

2021-05-20 Thread Alex Deucher
/amdgpu/amdgpu_ids.c:337: warning: expecting prototype > > for amdgpu_vm_grab_used(). Prototype was for amdgpu_vmid_grab_used() instead > > drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c:410: warning: expecting prototype > > for amdgpu_vm_grab_id(). Prototype was for amdgpu_vmid_gr

Re: [PATCH 11/38] drm/amd/amdgpu/amdgpu_debugfs: Fix a couple of misnamed functions

2021-05-20 Thread Alex Deucher
ototype was for > amdgpu_debugfs_gfxoff_write() instead > drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:1053: warning: expecting > prototype for amdgpu_debugfs_regs_gfxoff_status(). Prototype was for > amdgpu_debugfs_gfxoff_read() instead > > Cc: Alex Deucher > Cc: "Christian König" > C

Re: [PATCH 12/38] drm/amd/amdgpu/amdgpu_gmc: Fix a little naming related doc-rot

2021-05-20 Thread Alex Deucher
; drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c:533: warning: expecting prototype > for amdgpu_noretry_set(). Prototype was for amdgpu_gmc_noretry_set() instead > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-...@lists.free

Re: [PATCH 13/38] drm/amd/amdgpu/cik_sdma: Fix a few incorrectly named functions

2021-05-20 Thread Alex Deucher
for cik_sdma_vm_set_pte_pde() instead > drivers/gpu/drm/amd/amdgpu/cik_sdma.c:814: warning: expecting prototype for > cik_sdma_vm_pad_ib(). Prototype was for cik_sdma_ring_pad_ib() instead > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Dan

Re: [PATCH 14/38] drm/amd/amdgpu/gfx_v7_0: Repair function names in the documentation

2021-05-20 Thread Alex Deucher
_vm_flush(). Prototype was for > gfx_v7_0_ring_emit_pipeline_sync() instead > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Sumit Semwal > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org >

Re: [PATCH 16/38] drm/amd/amdgpu/si_dma: Fix some function name disparity

2021-05-20 Thread Alex Deucher
si_dma_ring_emit_pipeline_sync() instead > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Sumit Semwal > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Cc: linux-me...@vger.kernel.

Re: [PATCH 17/38] drm/amd/amdgpu/dce_v6_0: Repair function name of 'si_get_number_of_dram_channels()'

2021-05-20 Thread Alex Deucher
r_of_dram_channels() instead > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Luben Tuikov > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones > --- > driv

Re: [PATCH 19/38] drm/radeon/cik: Fix incorrectly named function 'cik_irq_suspend()'

2021-05-20 Thread Alex Deucher
Applied. Thanks! On Thu, May 20, 2021 at 8:03 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/radeon/cik.c:7450: warning: expecting prototype for > cik_irq_disable(). Prototype was for cik_irq_suspend() instead > > C

Re: [PATCH 20/38] drm/radeon/radeon_vm: Fix function naming disparities

2021-05-20 Thread Alex Deucher
m_num_pde(). Prototype was for radeon_vm_num_pdes() instead > > drivers/gpu/drm/radeon/radeon_vm.c:642: warning: expecting prototype for > > radeon_vm_update_pdes(). Prototype was for > > radeon_vm_update_page_directory() instead > > > > Cc: Alex Deucher > >

Re: [PATCH 21/38] drm/amd/include/aldebaran_ip_offset: Mark top-level IP_BASE as __maybe_unused

2021-05-20 Thread Alex Deucher
ariable=] > drivers/gpu/drm/amd/amdgpu/../include/aldebaran_ip_offset.h:49:29: warning: > ‘DBGU_IO0_BASE’ defined but not used [-Wunused-const-variable=] > drivers/gpu/drm/amd/amdgpu/../include/aldebaran_ip_offset.h:42:29: warning: > ‘CLK_BASE’ defined but not used [-Wunused-const-vari

Re: [PATCH 23/38] drm/amd/amdgpu/gmc_v7_0: Fix potential copy/paste issue

2021-05-20 Thread Alex Deucher
ult_enable_default() instead > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones > --- > drivers/gpu/drm/amd/amdgpu/gmc_v

Re: [PATCH 24/38] drm/amd/amdgpu/mmhub_v9_4: Fix naming disparity with 'mmhub_v9_4_set_fault_enable_default()'

2021-05-20 Thread Alex Deucher
ototype was for > mmhub_v9_4_set_fault_enable_default() instead > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones > --- > drivers/gpu/drm/amd/amdgp

Re: [PATCH 26/38] drm/amd/amdgpu/gmc_v10_0: Fix potential copy/paste issue

2021-05-20 Thread Alex Deucher
Applied. Thanks! Alex On Thu, May 20, 2021 at 8:03 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c:955: warning: expecting prototype for > gmc_v8_0_gart_fini(). Prototype was for gmc_v10_0_gart_fini() inste

Re: [PATCH 29/38] drm/radeon/r100: Realign doc header with function 'r100_cs_packet_parse_vline()'

2021-05-20 Thread Alex Deucher
Applied. Thanks! On Thu, May 20, 2021 at 8:03 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/radeon/r100.c:1423: warning: expecting prototype for > r100_cs_packet_next_vline(). Prototype was for r100_cs_packet_parse_vline() > in

Re: [PATCH 30/38] drm/amd/amdgpu/gfx_v9_4_2: Mark functions called by reference as static

2021-05-20 Thread Alex Deucher
; drivers/gpu/drm/amd/amdgpu/gfx_v9_4_2.c:1153:6: warning: no previous > prototype for ‘gfx_v9_4_2_enable_watchdog_timer’ [-Wmissing-prototypes] > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-...@lists.freedes

Re: [PATCH 31/38] drm/amd/amdgpu/sdma_v2_4: Correct misnamed function 'sdma_v2_4_ring_emit_hdp_flush()'

2021-05-20 Thread Alex Deucher
ing_emit_hdp_flush() instead > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Sumit Semwal > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Cc: linux-me...@vger.kernel.org > Cc: linaro-mm-...@lis

Re: [PATCH 32/38] drm/amd/amdgpu/sdma_v4_0: Realign functions with their headers

2021-05-20 Thread Alex Deucher
tr() > instead > drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c:830: warning: expecting prototype for > sdma_v4_0_ring_set_wptr(). Prototype was for sdma_v4_0_page_ring_set_wptr() > instead > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie &

Re: [PATCH 33/38] drm/amd/amdgpu/sdma_v5_0: Fix typo in function name

2021-05-20 Thread Alex Deucher
le() > instead > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Sumit Semwal > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Cc: linux-me...@vger.kernel.org > Cc: linaro-mm-...@lists.l

Re: [PATCH 35/38] drm/amd/amdgpu/sdma_v5_2: Repair typo in function name

2021-05-20 Thread Alex Deucher
le() > instead > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Sumit Semwal > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Cc: linux-me...@vger.kernel.org > Cc: linaro-mm-...@lists.l

Re: [PATCH 36/38] drm/amd/amdgpu/vcn_v1_0: Fix some function naming disparity

2021-05-20 Thread Alex Deucher
rivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:: warning: expecting prototype for > vcn_v1_0_stop(). Prototype was for vcn_v1_0_stop_spg_mode() instead > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-...@lists.freedesktop.o

Re: [PATCH 37/38] drm/amd/amdgpu/gfx_v10_0: Demote kernel-doc abuse

2021-05-20 Thread Alex Deucher
entation/doc-guide/kernel-doc.rst > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Sumit Semwal > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Cc: linux-me...@vger.kernel.org > Cc: linaro

Re: [PATCH 38/38] drm/amd/amdgpu/smuio_v13_0: Realign 'smuio_v13_0_is_host_gpu_xgmi_supported()' header

2021-05-20 Thread Alex Deucher
ototype was for > smuio_v13_0_is_host_gpu_xgmi_supported() instead > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Hawking Zhang > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones > --- &g

Re: [PATCH 34/38] drm/amd/amdgpu/amdgpu_vce: Fix a few incorrectly named functions

2021-05-20 Thread Alex Deucher
r amdgpu_vce_cs_parse_vm(). Prototype was for amdgpu_vce_ring_parse_cs_vm() > instead > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Sumit Semwal > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Cc:

Re: [PATCH -next] drm/amdgpu: fix unused-but-set-variable warnings

2021-05-20 Thread Alex Deucher
Applied. Thanks! On Thu, May 20, 2021 at 9:32 AM Wei Yongjun wrote: > > GCC reports the following warnings with W=1: > > drivers/gpu/drm/amd/amdgpu/jpeg_v2_5.c:190:22: warning: > variable 'ring' set but not used [-Wunused-but-set-variable] > 190 | struct amdgpu_ring *ring; > |

[pull] amdgpu, amdkfd drm-next-5.14

2021-05-20 Thread Alex Deucher
fixes Aaron Liu (1): drm/amdgpu: modify system reference clock source for navi+ (V2) Alex Deucher (3): drm/amdgpu: add mmhub client support for beige goby drm/amdgpu/display: add helper functions to get/set backlight (v2) drm/amdgpu/di

Re: [PATCH 02/40] drm/amd/amdgpu/amdgpu_ttm: Add description for 'page_flags'

2020-11-24 Thread Alex Deucher
On Mon, Nov 23, 2020 at 6:19 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c:1214: warning: Function parameter or > member 'page_flags' not described in 'amdgpu_ttm_tt_create' > >

Re: [PATCH 03/40] drm/amd/amdgpu/amdgpu_ib: Provide docs for 'amdgpu_ib_schedule()'s 'job' param

2020-11-24 Thread Alex Deucher
On Mon, Nov 23, 2020 at 6:19 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c:127: warning: Function parameter or > member 'job' not described in 'amdgpu_ib_schedule' > > Cc: Alex Deuc

Re: [PATCH 05/40] drm/amd/amdgpu/cik_ih: Supply description for 'ih' in 'cik_ih_{get, set}_wptr()'

2020-11-24 Thread Alex Deucher
amdgpu/cik_ih.c:274: warning: Function parameter or > member 'ih' not described in 'cik_ih_set_rptr' > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Qinglang Miao > Cc: amd-...@lists.freedesktop.or

Re: [PATCH 01/40] drm/radeon/radeon_device: Consume our own header where the prototypes are located

2020-11-24 Thread Alex Deucher
On Mon, Nov 23, 2020 at 6:19 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/radeon/radeon_device.c:637:6: warning: no previous prototype > for ‘radeon_device_is_virtual’ [-Wmissing-prototypes] > > Cc: Alex Deucher > Cc:

Re: [PATCH 04/40] drm/amd/amdgpu/amdgpu_virt: Correct possible copy/paste or doc-rot misnaming issue

2020-11-24 Thread Alex Deucher
drm/amd/amdgpu/amdgpu_virt.c:239: warning: Function parameter or > member 'adev' not described in 'amdgpu_virt_free_mm_table' > drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:239: warning: Excess function > parameter 'amdgpu' description in 'amdgpu_virt_fre

Re: [PATCH 06/40] drm/amd/amdgpu/uvd_v4_2: Fix some kernel-doc misdemeanours

2020-11-24 Thread Alex Deucher
_v4_2_ring_emit_fence' > drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c:446: warning: Excess function > parameter 'fence' description in 'uvd_v4_2_ring_emit_fence' > drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c:513: warning: Function parameter or > member 'job' no

Re: [PATCH 07/40] drm/amd/amdgpu/dce_v8_0: Supply description for 'async'

2020-11-24 Thread Alex Deucher
On Mon, Nov 23, 2020 at 6:19 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/dce_v8_0.c:185: warning: Function parameter or > member 'async' not described in 'dce_v8_0_page_flip' > > Cc: Alex Deuc

Re: [PATCH 08/40] drm/amd/amdgpu/cik_sdma: Supply some missing function param descriptions

2020-11-24 Thread Alex Deucher
/drm/amd/amdgpu/cik_sdma.c:1315: warning: Function parameter or > member 'tmz' not described in 'cik_sdma_emit_copy_buffer' > drivers/gpu/drm/amd/amdgpu/cik_sdma.c:1315: warning: Excess function > parameter 'ring' description in 'cik_sdma_emit_copy_buffer'

Re: [PATCH 09/40] drm/amd/amdgpu/gfx_v7_0: Clean-up a bunch of kernel-doc related issues

2020-11-24 Thread Alex Deucher
ribed in 'gfx_v7_0_ring_test_ib' > drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:3244: warning: Function parameter or > member 'ring' not described in 'gfx_v7_0_ring_emit_vm_flush' > drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:3244: warning: Function parameter or > me

Re: [PATCH 16/40] drm/amd/amdgpu/si_dma: Fix a bunch of function documentation issues

2020-11-24 Thread Alex Deucher
er 'tmz' not described in 'si_dma_emit_copy_buffer' > drivers/gpu/drm/amd/amdgpu/si_dma.c:781: warning: Excess function parameter > 'ring' description in 'si_dma_emit_copy_buffer' > drivers/gpu/drm/amd/amdgpu/si_dma.c:804: warning: Fun

Re: [PATCH 17/40] drm/amd/amdgpu/gfx_v6_0: Supply description for 'gfx_v6_0_ring_test_ib()'s 'timeout' param

2020-11-24 Thread Alex Deucher
On Mon, Nov 23, 2020 at 6:19 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c:1903: warning: Function parameter or > member 'timeout' not described in 'gfx_v6_0_ring_test_ib' > > Cc: Al

Re: [PATCH 21/40] drm/amd/amdgpu/uvd_v3_1: Fix-up some documentation issues

2020-11-24 Thread Alex Deucher
; not described in 'uvd_v3_1_hw_init' > drivers/gpu/drm/amd/amdgpu/uvd_v3_1.c:625: warning: Excess function > parameter 'adev' description in 'uvd_v3_1_hw_init' > drivers/gpu/drm/amd/amdgpu/uvd_v3_1.c:692: warning: Function parameter or > member '

Re: [PATCH 22/40] drm/amd/amdgpu/dce_v6_0: Fix formatting and missing parameter description issues

2020-11-24 Thread Alex Deucher
rm/amd/amdgpu/dce_v6_0.c:1050: warning: Cannot understand * > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Luben Tuikov > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jone

Re: [PATCH 23/40] drm/amd/include/vega20_ip_offset: Mark top-level IP_BASE definition as __maybe_unused

2020-11-24 Thread Alex Deucher
{ 0x00017400, 0, 0, 0, 0, > 0 } }, > | ^ > > Fixes the following W=1 kernel build warning(s): > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.o

Re: [PATCH 24/40] drm/amd/include/navi10_ip_offset: Mark top-level IP_BASE as __maybe_unused

2020-11-24 Thread Alex Deucher
ASE FUSE_BASE ={ { { { 0x00017400, 0, 0, 0, 0, > 0 } }, > | ^ > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones Applie

Re: [PATCH 25/40] drm/amd/include/arct_ip_offset: Mark top-level IP_BASE definition as __maybe_unused

2020-11-24 Thread Alex Deucher
29: warning: > ‘FUSE_BASE’ defined but not used [-Wunused-const-variable=] > 63 | static const struct IP_BASE FUSE_BASE ={ { { { 0x000120A0, 0x00017400, > 0x00401400, 0, 0, 0 } }, > | ^ > > Cc: Alex Deucher > Cc: "Christian König" > Cc: Davi

Re: [PATCH 26/40] drm/amd/include/navi14_ip_offset: Mark top-level IP_BASE as __maybe_unused

2020-11-24 Thread Alex Deucher
t IP_BASE SDMA_BASE ={ { { { 0x1260, 0xA000, > 0x02402C00, 0, 0 } }, > | ^~~~~ > > NB: Snipped a few of these > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-...@lists.freedesktop.org

Re: [PATCH 27/40] drm/amd/include/navi12_ip_offset: Mark top-level IP_BASE as __maybe_unused

2020-11-24 Thread Alex Deucher
t IP_BASE SDMA_BASE ={ { { { 0x1260, 0xA000, > 0x02402C00, 0, 0 } }, > | ^~~~~ > > NB: Snipped a few of these > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-...@lists.freedesktop.org

Re: [PATCH 28/40] drm/amd/include/sienna_cichlid_ip_offset: Mark top-level IP_BASE as __maybe_unused

2020-11-24 Thread Alex Deucher
nst-variable=] > 158 | static const struct IP_BASE SDMA1_BASE = { { { { 0x1260, > 0xA000, 0x0001C000, 0x02402C00, 0 } }, > | ^~ > > NB: Snipped lots of these > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter

Re: [PATCH 29/40] drm/amd/include/vangogh_ip_offset: Mark top-level IP_BASE as __maybe_unused

2020-11-24 Thread Alex Deucher
; 154 | static const struct IP_BASE MP2_BASE = { { { { 0x00016400, 0x02400800, > 0x00F4, 0x00F8, 0x00FC0000, 0 } }, > | ^~~~ > > NB: Snipped lots of these > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Huang

Re: [PATCH 30/40] drm/amd/include/dimgrey_cavefish_ip_offset: Mark top-level IP_BASE as __maybe_unused

2020-11-24 Thread Alex Deucher
const-variable=] > 74 | static const struct IP_BASE DPCS_BASE = { { { { 0x0012, 0x00C0, > 0x34C0, 0x9000, 0x02403C00, 0 } }, > | ^ > > NB: Snipped lots of these > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie

Re: [PATCH 33/40] drm/amd/amdgpu/cik_sdma: Add one and remove another function param description

2020-11-24 Thread Alex Deucher
drm/amd/amdgpu/cik_sdma.c:282: warning: Excess function > parameter 'fence' description in 'cik_sdma_ring_emit_fence' > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Sumit Semwal > Cc: amd-...@lists.

Re: [PATCH 34/40] drm/amd/amdgpu/uvd_v4_2: Add one and remove another function param description

2020-11-24 Thread Alex Deucher
drm/amd/amdgpu/uvd_v4_2.c:448: warning: Excess function > parameter 'fence' description in 'uvd_v4_2_ring_emit_fence' > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-...@lists.freedesktop.org &

Re: [PATCH 36/40] drm/amd/amdgpu/gmc_v7_0: Add some missing kernel-doc descriptions

2020-11-24 Thread Alex Deucher
7_0_flush_gpu_tlb' > drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c:471: warning: Function parameter or > member 'flush_type' not described in 'gmc_v7_0_flush_gpu_tlb' > drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c:771: warning: Function parameter or > member 'pasid&

Re: [PATCH 37/40] drm/amd/amdgpu/gmc_v8_0: Fix more issues attributed to copy/paste

2020-11-24 Thread Alex Deucher
8_0_flush_gpu_tlb' > drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c:657: warning: Function parameter or > member 'flush_type' not described in 'gmc_v8_0_flush_gpu_tlb' > drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c:998: warning: Function parameter or > member 'pasid&

Re: [PATCH 39/40] drm/amd/amdgpu/gmc_v9_0: Remove unused table 'ecc_umc_mcumc_status_addrs'

2020-11-24 Thread Alex Deucher
On Mon, Nov 23, 2020 at 6:20 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c:382:23: warning: > ‘ecc_umc_mcumc_status_addrs’ defined but not used [-Wunused-const-variable=] > > Cc: Alex Deucher > Cc:

Re: [PATCH 40/40] drm/amd/amdgpu/gmc_v9_0: Suppy some missing function doc descriptions

2020-11-24 Thread Alex Deucher
27; > drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c:836: warning: Function parameter or > member 'all_hub' not described in 'gmc_v9_0_flush_gpu_tlb_pasid' > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: am

Re: [PATCH] drm/amd/powerplay: fix spelling mistake "smu_state_memroy_block" -> "smu_state_memory_block"

2020-11-24 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Nov 23, 2020 at 7:42 PM Quan, Evan wrote: > > [AMD Official Use Only - Internal Distribution Only] > > Reviewed-by: Evan Quan > > -Original Message- > From: Colin King > Sent: Monday, November 23, 2020 6:54 PM > To: Deucher, Alexander ; Koenig, Christian

Re: [PATCH 01/15] drm/amdgpu: Remove references to struct drm_device.pdev

2020-11-25 Thread Alex Deucher
On Tue, Nov 24, 2020 at 6:38 AM Thomas Zimmermann wrote: > > Using struct drm_device.pdev is deprecated. Convert amdgpu to struct > drm_device.dev. No functional changes. > > Signed-off-by: Thomas Zimmermann > Cc: Alex Deucher > Cc: Christian König There are a few unrelat

Re: [PATCH 11/15] drm/radeon: Remove references to struct drm_device.pdev

2020-11-25 Thread Alex Deucher
On Tue, Nov 24, 2020 at 6:39 AM Thomas Zimmermann wrote: > > Using struct drm_device.pdev is deprecated. Convert radeon to struct > drm_device.dev. No functional changes. > > Signed-off-by: Thomas Zimmermann > Cc: Alex Deucher > Cc: Christian König There are a few unrelat

[pull] amdgpu drm-fixes-5.10

2020-11-25 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.10. The following changes since commit 6600f9d52213b5c3455481b5c9e61cf5e305c0e6: Merge tag 'drm-intel-fixes-2020-11-19' of git://anongit.freedesktop.org/drm/drm-intel into drm-fixes (2020-11-20 11:21:54 +1000) are available in the Git repository at: git://peo

[pull] amdgpu, radeon drm-next-5.11

2020-11-25 Thread Alex Deucher
r validation - More W=1 fixes radeon: - More W=1 fixes -------- Alex Deucher (1): drm/amdgpu: only register VGA devices with the VGA arbiter Aric Cyr (1): drm/amd/display: 3.2.113 Ashley Thomas (1): drm/amd/display: Source

Re: [PATCH 02/40] drm/amd/amdgpu/gmc_v10_0: Suppy some missing function doc descriptions

2020-11-30 Thread Alex Deucher
_v10_0_flush_gpu_tlb_pasid' > drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c:371: warning: Function parameter or > member 'all_hub' not described in 'gmc_v10_0_flush_gpu_tlb_pasid' > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Ai

<    1   2   3   4   5   6   7   8   9   10   >