Re: [PATCH v4 07/14] drm/amdgpu: Register IOMMU topology notifier per device.

2021-01-18 Thread Alex Deucher
On Mon, Jan 18, 2021 at 4:02 PM Andrey Grodzovsky wrote: > > Handle all DMA IOMMU gropup related dependencies before the gropup -> group Alex > group is removed. > > Signed-off-by: Andrey Grodzovsky > --- > drivers/gpu/drm/amd/amdgpu/amdgpu.h| 5 > drivers/gpu/drm/amd/amdgpu/amd

Re: [PATCH v4 10/14] dmr/amdgpu: Move some sysfs attrs creation to default_attr

2021-01-19 Thread Alex Deucher
On Tue, Jan 19, 2021 at 1:26 PM Greg KH wrote: > > On Tue, Jan 19, 2021 at 11:36:01AM -0500, Andrey Grodzovsky wrote: > > > > On 1/19/21 2:34 AM, Greg KH wrote: > > > On Mon, Jan 18, 2021 at 04:01:19PM -0500, Andrey Grodzovsky wrote: > > > > static struct pci_driver amdgpu_kms_pci_driver = { > >

[pull] amdgpu drm-next-5.12

2021-01-19 Thread Alex Deucher
- Misc cleanups Alex Deucher (5): MAINTAINERS: update radeon/amdgpu/amdkfd git trees drm/amdgpu: add mode2 reset support for vangogh drm/amdgpu/nv: add mode2 reset handling drm/amdgpu: fix mode2 reset sequence

Re: [pull] amdgpu drm-next-5.12

2021-01-20 Thread Alex Deucher
On Wed, Jan 20, 2021 at 7:10 AM Daniel Vetter wrote: > > On Wed, Jan 20, 2021 at 01:09:51AM -0500, Alex Deucher wrote: > > Hi Dave, Daniel, > > > > More new stuff for 5.12. Now with non-x86 fixed. > > > > The following changes since commit 044a48f420b9d3c19a1

Re: [PATCH][next] drm/amd/display: Fix spelling mistake of function name

2021-01-20 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Jan 20, 2021 at 9:46 AM Harry Wentland wrote: > > On 2021-01-20 4:26 a.m., Colin King wrote: > > From: Colin Ian King > > > > Reviewed-by: Harry Wentland > > Harry > > > There are two spelling mistakes of the function name, fix this > > by using __func__ instead

Re: [PATCH] drm/amdgpu: Assign boolean values to a bool variable

2021-01-20 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Jan 20, 2021 at 10:05 AM Harry Wentland wrote: > > On 2021-01-20 2:16 a.m., Jiapeng Zhong wrote: > > Fix the following coccicheck warnings: > > > > ./drivers/gpu/drm/amd/display/dc/dml/dcn30/display_rq_dlg_calc_30.c: > > 1009:6-16: WARNING: Assignment of 0/1 to boo

Re: [PATCH] drm/amd/display: Revert "add DCN support for aarch64"

2021-01-20 Thread Alex Deucher
On Wed, Jan 20, 2021 at 3:20 AM Ard Biesheuvel wrote: > > On Tue, 5 Jan 2021 at 17:23, Alex Deucher wrote: > > > > On Tue, Jan 5, 2021 at 8:05 AM Will Deacon wrote: > > > > > > On Mon, Jan 04, 2021 at 11:27:24AM -0500, Alex Deucher wrote: > > > >

Re: linux-next: build warning after merge of the amdgpu tree

2021-01-20 Thread Alex Deucher
On Wed, Jan 20, 2021 at 7:53 PM Stephen Rothwell wrote: > > Hi all, > > On Wed, 20 Jan 2021 17:15:01 +1100 Stephen Rothwell > wrote: > > > > On Fri, 15 Jan 2021 12:00:14 +1100 Stephen Rothwell > > wrote: > > > > > > After merging the amdgpu tree, today's linux-next build (x86_64 > > > allmodco

[pull] amdgpu drm-fixes-5.11

2021-01-21 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.11. The following changes since commit c8f6364f35f32786dd40336cfa35b9166d91b8ab: Merge branch '04.00-ampere-lite-fixes' of git://github.com/skeggsb/linux into drm-fixes (2021-01-15 13:26:44 +1000) are available in the Git repository at: https://gitlab.freedesk

Re: [PATCH 0/3] Experimental freesync video mode optimization

2021-01-22 Thread Alex Deucher
On Fri, Jan 22, 2021 at 4:43 AM Daniel Vetter wrote: > > On Fri, Jan 22, 2021 at 10:32:48AM +0200, Pekka Paalanen wrote: > > On Tue, 19 Jan 2021 10:50:26 -0500 > > Aurabindo Pillai wrote: > > > > > Changes in V5 > > > = > > > > > > * More info in commit messages on the rationale of ch

Re: [PATCH][next] drm/amdgpu: Fix masking binary not operator on two mask operations

2021-01-25 Thread Alex Deucher
Applied. Thanks! Alex On Sun, Jan 24, 2021 at 11:36 PM Huang Rui wrote: > > On Fri, Jan 22, 2021 at 11:00:22PM +0800, Colin King wrote: > > From: Colin Ian King > > > > Currently the ! operator is incorrectly being used to flip bits on > > mask values. Fix this by using the bit-wise ~ operator

Re: [PATCH] drm/amd/display: change license of color_table.c

2021-01-25 Thread Alex Deucher
On Mon, Jan 25, 2021 at 7:07 AM Jonathan Gray wrote: > > This still needs to be corrected. Applied. Thanks! Alex > > On Thu, Nov 19, 2020 at 01:30:41PM +1100, Jonathan Gray wrote: > > Change the license of color_table.c to match color_table.h granting > > permission to modify and distribute. >

Re: [PATCH] amdgpu: fix clang build warning

2021-01-25 Thread Alex Deucher
On Mon, Jan 25, 2021 at 7:24 AM Arnd Bergmann wrote: > > From: Arnd Bergmann > > clang warns about the -mhard-float command line arguments > on architectures that do not support this: > > clang: error: argument unused during compilation: '-mhard-float' > [-Werror,-Wunused-command-line-argument]

Re: [PATCH 2/2] drm/amd/display: Fix HDMI deep color output for DCE 6-11.

2021-01-25 Thread Alex Deucher
On Thu, Jan 21, 2021 at 1:17 AM Mario Kleiner wrote: > > This fixes corrupted display output in HDMI deep color > 10/12 bpc mode at least as observed on AMD Mullins, DCE-8.3. > > It will hopefully also provide fixes for other DCE's up to > DCE-11, assuming those will need similar fixes, but i coul

[pull] amdgpu drm-fixes-5.11

2021-01-28 Thread Alex Deucher
-- amd-drm-fixes-5.11-2021-01-28: amdgpu: - Fix a fan control regression on some boards - Fix clang warning ---- Alex Deucher (1): Revert "drm/amdgpu/swsmu: drop set_fan_speed_percent (v2)" Arnd Bergmann (1): amd

Re: [PATCH] drm/amd/display: Simplify bool conversion

2021-01-29 Thread Alex Deucher
On Thu, Jan 28, 2021 at 2:45 PM Abaci Team wrote: > > Fix the following coccicheck warning: > ./drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c:3137:35-40: > WARNING: conversion to bool not needed here > > Reported-by: Abaci Robot > Suggested-by: Yang Li > Signed-off-by: Abaci Team A

Re: [PATCH][next] drm/amdgpu: Fix memory leak of object caps on error return paths

2021-01-29 Thread Alex Deucher
On Fri, Jan 29, 2021 at 7:08 AM Colin King wrote: > > From: Colin Ian King > > Currently there are three error return paths that don't kfree object > caps. Fix this by performing the allocation of caps after the checks > and error return paths to avoid the premature allocation and memory > leaki

[pull] amdgpu, amdkfd drm-next-5.12

2021-01-29 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.12. The following changes since commit a6b8720c2f85143561c3453e1cf928a2f8586ac0: Merge tag 'amd-drm-next-5.12-2021-01-20' of https://gitlab.freedesktop.org/agd5f/linux into drm-next (2021-01-20 13:08:18 +0100) are available in the Git repository at: https://g

Re: [PATCH] efifb: Ensure graphics device for efifb stays at PCI D0

2021-02-01 Thread Alex Deucher
untime suspend kicks in, makes efifb stop working. > > So ensure the graphics device won't be runtime suspended, to keep efifb > work all the time. > > Signed-off-by: Kai-Heng Feng Reviewed-by: Alex Deucher > --- > drivers/video/fbdev/efifb.c | 3 +++ > 1 file change

Re: [PATCH] amd/display: remove unneeded variable: "pattern"

2021-02-02 Thread Alex Deucher
On Tue, Feb 2, 2021 at 8:31 AM Bernard Zhao wrote: > > Remove unneeded variable: "pattern". > > Signed-off-by: Bernard Zhao Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/d

Re: [amdgpu] deadlock

2021-02-03 Thread Alex Deucher
On Wed, Feb 3, 2021 at 7:30 AM Christian König wrote: > > Am 03.02.21 um 13:24 schrieb Daniel Vetter: > > On Wed, Feb 03, 2021 at 01:21:20PM +0100, Christian König wrote: > >> Am 03.02.21 um 12:45 schrieb Daniel Gomez: > >>> On Wed, 3 Feb 2021 at 10:47, Daniel Gomez wrote: > On Wed, 3 Feb 20

Re: [amdgpu] deadlock

2021-02-03 Thread Alex Deucher
entially affect long running Vulkan or OpenGL compute kernels. Not sure we have a good solution for them. People are starting to build ML stuff on vulkan. Alex > -Daniel > > > Thanks, > > John > > Original Message > > From: Daniel Vetter > > Sent: Wednesda

[pull] amdgpu, amdkfd drm-fixes-5.11

2021-02-03 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.11. The following changes since commit e0ecafede87eb1a3d1e708f0365fad0d59489285: Merge tag 'amd-drm-fixes-5.11-2021-01-28' of https://gitlab.freedesktop.org/agd5f/linux into drm-fixes (2021-01-29 11:36:38 +1000) are available in the Git repository at: https:/

[pull] amdgpu, amdkfd drm-next-5.12

2021-02-03 Thread Alex Deucher
g handling - Fix regression in buffer free Aaron Liu (1): drm/amdgpu: update mmhub mgcg&ls for mmhub_v2_3 Abaci Team (1): drm/amd/display: Simplify bool conversion Alex Deucher (3): drm/amdgpu: disable gpu reset

Re: [PATCH v16 0/4] RDMA: Add dma-buf support

2021-02-04 Thread Alex Deucher
On Thu, Feb 4, 2021 at 2:48 AM John Hubbard wrote: > > On 12/15/20 1:27 PM, Jianxin Xiong wrote: > > This patch series adds dma-buf importer role to the RDMA driver in > > attempt to support RDMA using device memory such as GPU VRAM. Dma-buf is > > chosen for a few reasons: first, the API is relat

Re: [Linaro-mm-sig] [PATCH 1/2] mm: replace BUG_ON in vm_insert_page with a return of an error

2021-02-04 Thread Alex Deucher
On Thu, Feb 4, 2021 at 3:16 AM Christian König wrote: > > Am 03.02.21 um 22:41 schrieb Suren Baghdasaryan: > > [SNIP] > >>> How many semi-unrelated buffer accounting schemes does google come up > >>> with? > >>> > >>> We're at three with this one. > >>> > >>> And also we _cannot_ required that al

Re: [PATCH v16 0/4] RDMA: Add dma-buf support

2021-02-04 Thread Alex Deucher
On Thu, Feb 4, 2021 at 1:29 PM Jason Gunthorpe wrote: > > On Thu, Feb 04, 2021 at 08:50:38AM -0500, Alex Deucher wrote: > > On Thu, Feb 4, 2021 at 2:48 AM John Hubbard wrote: > > > > > > On 12/15/20 1:27 PM, Jianxin Xiong wrote: > > > > This patch ser

Re: [pull] amdgpu, amdkfd drm-next-5.12

2021-02-04 Thread Alex Deucher
On Thu, Feb 4, 2021 at 6:52 PM Dave Airlie wrote: > > On Thu, 4 Feb 2021 at 14:57, Alex Deucher wrote: > > > > Hi Dave, Daniel, > > > > More fixes for 5.12. Same PR from last week with the issue Felix reported > > fixed and a few more additional fixes on top.

Re: [PATCH 2/2] drm/amd/display: Add aux_backlight module option

2021-02-05 Thread Alex Deucher
On Wed, Feb 3, 2021 at 7:42 AM Takashi Iwai wrote: > > There seem devices that don't work with the aux channel backlight > control. For allowing such users to test with the other backlight > control method, provide a new module option, aux_backlight, to specify > enabling or disabling the aux bac

Re: [PATCH 1/2] drm/amd/display: Fix the brightness read via aux

2021-02-05 Thread Alex Deucher
On Wed, Feb 3, 2021 at 7:42 AM Takashi Iwai wrote: > > The current code tries to read the brightness value via > dc_link_get_backlight_level() no matter whether it's controlled via > aux or not, and this results in a bogus value returned. > Fix it to read the current value via > dc_link_get_backli

Re: [PATCH] radeon: added support for 2560x1080 resolution

2021-02-09 Thread Alex Deucher
On Sun, Feb 7, 2021 at 1:13 PM Marcin Raszka wrote: > > I was wondering why I can't set the resolution to 2560x1080, > while in windows 7 I can without a problem. I looked at the radeon driver > code and found it doesn't support this resolution. So I made some changes. I > added the hdmi_mhz pa

Re: [PATCH] drm/amdgpu: fix unnecessary NULL check warnings

2021-02-09 Thread Alex Deucher
On Tue, Feb 9, 2021 at 3:44 AM Tian Tao wrote: > > Remove NULL checks before vfree() to fix these warnings: > drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:102:2-8: WARNING: NULL > check before some freeing functions is not needed. > > Signed-off-by: Tian Tao Applied. Thanks! Alex > --- > drivers/

Re: [PATCH] drm/amd/display: Simplify bool comparison

2021-02-09 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Feb 8, 2021 at 5:29 AM Jiapeng Chong wrote: > > Fix the following coccicheck warning: > > ./drivers/gpu/drm/amd/display/dc/inc/hw/clk_mgr_internal.h:319:11-23: > WARNING: Comparison to bool. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > --- > dri

Re: [PATCH] drm/radeon: Simplify bool comparison

2021-02-09 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Feb 8, 2021 at 5:17 AM Jiapeng Chong wrote: > > Fix the following coccicheck warning: > > ./drivers/gpu/drm/radeon/rs690.c:190:6-35: WARNING: Comparison to bool. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > --- > drivers/gpu/drm/radeon/rs690.c |

[pull] amdgpu drm-fixes-5.11

2021-02-10 Thread Alex Deucher
ank screen fix ---- Alex Deucher (1): Revert "drm/amd/display: Update NV1x SR latency values" drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c | 4 ++-- 1 file changed, 2 insert

Re: [PATCH 4/4] drm/vmwgfx: clean up vmw_move_notify

2021-02-11 Thread Alex Deucher
On Thu, Feb 11, 2021 at 8:17 AM Christian König wrote: > > Instead of swapping bo->mem just give old and new as parameters. > > Also drop unused parameters and code. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/vmwgfx/vmwgfx_drv.h| 3 ++- > drivers/gpu/drm/vmwgfx/vmwgfx_re

Re: [PATCH][next] drm/amd/pm: fix spelling mistake in various messages "power_dpm_force_perfomance_level"

2021-02-15 Thread Alex Deucher
On Wed, Feb 10, 2021 at 7:03 AM Colin King wrote: > > From: Colin Ian King > > There are spelling mistakes in error and warning messages, the text > power_dpm_force_perfomance_level is missing a letter r and should be > power_dpm_force_performance_level. Fix them. > > Signed-off-by: Colin Ian Ki

Re: [PATCH][next] drm/amd/display: Fix potential integer overflow

2021-02-15 Thread Alex Deucher
On Wed, Feb 10, 2021 at 4:23 PM Gustavo A. R. Silva wrote: > > Fix potential integer overflow by casting actual_calculated_clock_100hz > to u64, in order to give the compiler complete information about the > proper arithmetic to use. > > Notice that such variable is used in a context that expects

Re: [PATCH][next] drm/amd/pm: Replace one-element array with flexible-array in struct SISLANDS_SMC_SWSTATE

2021-02-15 Thread Alex Deucher
On Wed, Feb 10, 2021 at 5:40 PM Gustavo A. R. Silva wrote: > > There is a regular need in the kernel to provide a way to declare having > a dynamically sized set of trailing elements in a structure. Kernel code > should always use “flexible array members”[1] for these cases. The older > style of o

Re: [PATCH][next] drm/amd/pm: Replace one-element array with flexible-array in struct _ATOM_Vega10_GFXCLK_Dependency_Table

2021-02-15 Thread Alex Deucher
On Wed, Feb 10, 2021 at 6:36 PM Gustavo A. R. Silva wrote: > > There is a regular need in the kernel to provide a way to declare having > a dynamically sized set of trailing elements in a structure. Kernel code > should always use “flexible array members”[1] for these cases. The older > style of o

Re: [PATCH][next] drm/radeon/nislands_smc.h: Replace one-element array with flexible-array member in struct NISLANDS_SMC_SWSTATE

2021-02-15 Thread Alex Deucher
On Wed, Feb 10, 2021 at 6:49 PM Gustavo A. R. Silva wrote: > > There is a regular need in the kernel to provide a way to declare having > a dynamically sized set of trailing elements in a structure. Kernel code > should always use “flexible array members”[1] for these cases. The older > style of o

Re: [PATCH] drm/amd/display: Allow spatial dither to 10 bpc on all != DCE-11.0.

2021-02-15 Thread Alex Deucher
e precision improvement (via colorimeter) > when displaying a fp16 framebuffer to a 10 bpc DP or HDMI connected > HDR-10 monitor. > > Alex suggests this may have been a workaround for some DCE-11.0 > Carrizo and Stoney Asics, so lets try to restrict this to DCE 11.0. > >

Re: [PATCH] drm/radeon: Remove unused function pointer typedef radeon_packet3_check_t

2021-02-15 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Feb 15, 2021 at 5:43 AM Christian König wrote: > > > > Am 15.02.21 um 11:21 schrieb Chen Lin: > > From: Chen Lin > > > > Remove the 'radeon_packet3_check_t' typedef as it is not used. > > > > Signed-off-by: Chen Lin > > Reviewed-by: Christian König > > > --- > >

Re: [PATCH] drm/amd/display: Simplify bool conversion

2021-02-18 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Feb 18, 2021 at 9:23 AM Yang Li wrote: > > Fix the following coccicheck warning: > ./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:8142:16-21: WARNING: > conversion to bool not needed here > > Reported-by: Abaci Robot > Signed-off-by: Yang Li > --- > drivers

[pull] amdgpu, amdkfd, radeon drm-next-5.12

2021-02-18 Thread Alex Deucher
- Fix reference clock on Renoir - Misc fixes and cleanups amdkfd: - Fix for unique id query - Fix recursive lock warnings radeon: - Remove confusing VCE messages on Oland Alex Deucher (16): Revert "drm/amd/display: fix unuse

Re: [git pull] drm for 5.12-rc1

2021-02-22 Thread Alex Deucher
On Sun, Feb 21, 2021 at 6:45 PM Nathan Chancellor wrote: > > On Sun, Feb 21, 2021 at 03:07:17PM -0800, Linus Torvalds wrote: > > On Thu, Feb 18, 2021 at 10:06 PM Dave Airlie wrote: > > > > > > Let me know if there are any issues, > > > > gcc was happy, and I obviously already pushed out my merge,

Re: [PATCH] drm/amd/pm/swsmu: Avoid using structure_size uninitialized in smu_cmn_init_soft_gpu_metrics

2021-02-22 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Feb 18, 2021 at 6:12 PM Wang, Kevin(Yang) wrote: > > thanks, > > Reviewed-by: Kevin Wang > > Regards, > Kevin > > > 在 2021年2月19日,06:49,Nathan Chancellor 写道: > > > > Clang warns: > > > > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu_cmn.c:764:2: warning: > > variabl

Re: [PATCH v2] drm/amdgpu/swsmu/navi1x: Remove unnecessary conversion to bool

2021-02-22 Thread Alex Deucher
Applied. Thanks! Alex On Sun, Feb 21, 2021 at 10:15 PM Quan, Evan wrote: > > [AMD Official Use Only - Internal Distribution Only] > > Reviewed-by: Evan Quan > > -Original Message- > From: amd-gfx On Behalf Of Jiapeng > Chong > Sent: Saturday, February 20, 2021 10:55 AM > To: Deucher,

Re: [PATCH] drm/amd/display/dc/core/dc_link_ddc: Remove unnecessary conversion to bool

2021-02-22 Thread Alex Deucher
Applied. Thanks! Alex On Sat, Feb 20, 2021 at 2:16 AM Jiapeng Chong wrote: > > Fix the following coccicheck warnings: > > ./drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c:544:34-39: WARNING: > conversion to bool not needed here. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong >

Re: [PATCH] drm/amdgpu/sdma5.2: Remove unnecessary conversion to bool

2021-02-22 Thread Alex Deucher
Applied. Thanks! Alex On Sat, Feb 20, 2021 at 3:35 AM Jiapeng Chong wrote: > > Fix the following coccicheck warnings: > > ./drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c:1621:40-45: WARNING: conversion > to bool not needed here. > > ./drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c:1619:40-45: WARNING: convers

Re: [PATCH] drm/amd/display: Remove unnecessary conversion to bool

2021-02-23 Thread Alex Deucher
This was already fixed by a patch from Yang Li . Alex On Tue, Feb 23, 2021 at 1:13 AM Jiapeng Chong wrote: > > Fix the following coccicheck warnings: > > ./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:8260:16-21: WARNING: > conversion to bool not needed here. > > Reported-by: Abaci Robot >

Re: [PATCH 0/3] drm/ttm: constify static vm_operations_structs

2021-02-23 Thread Alex Deucher
On Wed, Feb 10, 2021 at 8:14 AM Daniel Vetter wrote: > > On Wed, Feb 10, 2021 at 08:45:56AM +0100, Christian König wrote: > > Reviewed-by: Christian König for the series. > > Smash it into -misc? @Christian Koenig did these ever land? I don't see them in drm-misc. Alex > -Daniel > > > > > Am

Re: [PATCH] drm/amdgpu/display: initialize the variable 'i'

2021-02-23 Thread Alex Deucher
yeah, fdo ran out of disk space so I moved to gitlab: https://gitlab.freedesktop.org/agd5f/linux/-/commits/drm-next Alex On Mon, Feb 22, 2021 at 7:26 PM Bas Nieuwenhuizen wrote: > > I think Alex moved to gitlab for his branches > > On Tue, Feb 23, 2021, 12:50 AM Simon Ser wrote: >> >> On Tuesda

Re: [PATCH] drm/amdgpu/display: initialize the variable 'i'

2021-02-23 Thread Alex Deucher
On Mon, Feb 22, 2021 at 3:13 PM Souptick Joarder wrote: > > >> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:9804:38: > >> warning: variable 'i' is uninitialized when used here > >> [-Wuninitialized] >timing = &edid->detailed_timings[i]; >

Re: [PATCH] drm/amdgpu: Remove unnecessary conversion to bool

2021-02-23 Thread Alex Deucher
On Mon, Feb 22, 2021 at 10:44 PM Jiapeng Chong wrote: > > Fix the following coccicheck warnings: > > ./drivers/gpu/drm/amd/amdgpu/athub_v2_1.c:79:40-45: WARNING: conversion > to bool not needed here. > > ./drivers/gpu/drm/amd/amdgpu/athub_v2_1.c:81:40-45: WARNING: conversion > to bool not needed h

Re: [PATCH] drm/ttm: Do not add non-system domain BO into swap list

2021-02-23 Thread Alex Deucher
On Tue, Feb 23, 2021 at 10:28 PM xinhui pan wrote: > > BO would be added into swap list if it is validated into system domain. > If BO is validated again into non-system domain, say, VRAM domain. It > actually should not be in the swap list. > > Signed-off-by: xinhui pan Acke

[pull] amdgpu drm-fixes-5.12

2021-02-24 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.12. The following changes since commit f730f39eb981af249d57336b47cfe3925632a7fd: Merge tag 'drm-intel-next-fixes-2021-02-18' of git://anongit.freedesktop.org/drm/drm-intel into drm-next (2021-02-19 13:55:07 +1000) are available in the Git repository at: https

Re: [PATCH] drm/amdgpu: Replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE

2021-02-25 Thread Alex Deucher
On Thu, Feb 25, 2021 at 4:02 AM Yang Li wrote: > > Fix the following coccicheck warning: > ./drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:1589:0-23: WARNING: > fops_ib_preempt should be defined with DEFINE_DEBUGFS_ATTRIBUTE > ./drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:1592:0-23: WARNING: > fops_

Re: [PATCH] drm/amd/display: remove unnecessary conversion to bool

2021-02-25 Thread Alex Deucher
On Thu, Feb 25, 2021 at 4:19 AM Jiapeng Chong wrote: > > Fix the following coccicheck warnings: > > ./drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dpp_cm.c:243:67-72: > WARNING: conversion to bool not needed here. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong Applied. Thanks! Alex

Re: [PATCH] drm/amd/display: Fix an uninitialized index variable

2021-02-25 Thread Alex Deucher
On Thu, Feb 25, 2021 at 10:01 AM Arnd Bergmann wrote: > > From: Arnd Bergmann > > clang points out that the new logic uses an always-uninitialized > array index: > > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:9810:38: warning: > variable 'i' is uninitialized when used here [-Wun

Re: [PATCH] drm/amd/pm/swsmu: Remove unnecessary conversion to bool

2021-02-26 Thread Alex Deucher
On Fri, Feb 26, 2021 at 4:17 AM Jiapeng Chong wrote: > > Fix the following coccicheck warnings: > > ./drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c:924:47-52: > WARNING: conversion to bool not needed here. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong Applied. Thanks!

Re: [PATCH] drm/amd/display/dc/dce/dmub_psr: Remove unnecessary conversion to bool

2021-02-26 Thread Alex Deucher
On Fri, Feb 26, 2021 at 4:42 AM Jiapeng Chong wrote: > > Fix the following coccicheck warnings: > > ./drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c:273:16-21: WARNING: > conversion to bool not needed here. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong Applied. Thanks! Alex > --

Re: [PATCH] drm/gem: add checks of drm_gem_object->funcs

2021-03-01 Thread Alex Deucher
def4fd1c ("drm: Remove obsolete GEM and PRIME callbacks from struct drm_driver") v2: Use use amdgpu_gem_object_create() directly v3: fix warning Reviewed-by: Christian König Signed-off-by: Andrey Grodzovsky Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher >

Re: [PATCH][next] drm/amd/display: fix the return of the uninitialized value in ret

2021-03-02 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Mar 2, 2021 at 10:03 AM Harry Wentland wrote: > > On 2021-03-02 9:05 a.m., Colin King wrote: > > From: Colin Ian King > > > > Currently if stream->signal is neither SIGNAL_TYPE_DISPLAY_PORT_MST or > > SIGNAL_TYPE_DISPLAY_PORT then variable ret is uninitialized and

Re: [PATCH] drm/amd/display: Fix an uninitialized index variable

2021-03-02 Thread Alex Deucher
On Thu, Feb 25, 2021 at 10:01 AM Arnd Bergmann wrote: > > From: Arnd Bergmann > > clang points out that the new logic uses an always-uninitialized > array index: > > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:9810:38: warning: > variable 'i' is uninitialized when used here [-Wun

Re: [PATCH] drm/amdgpu: Verify bo size can fit framebuffer size

2021-03-02 Thread Alex Deucher
s this function to > initialize its fb as it performs the required checks. > > The bug was caught using igt-gpu-tools test: kms_addfb_basic.too-high > and kms_addfb_basic.bo-too-small > > Suggested-by: Sean Paul > Cc: Alex Deucher > Cc: amd-...@lists.freedesktop.org > Cc

Re: [PATCH] drm/amd/display: Remove unnecessary conversion to bool

2021-03-02 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Mar 1, 2021 at 1:50 AM Jiapeng Chong wrote: > > Fix the following coccicheck warnings: > > ./drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dpp_cm.c:298:33-38: > WARNING: conversion to bool not needed here. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong

Re: [PATCH] drm/amdgpu: Remove unnecessary conversion to bool

2021-03-03 Thread Alex Deucher
On Wed, Mar 3, 2021 at 4:18 AM Jiapeng Chong wrote: > > Fix the following coccicheck warnings: > > ./drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c:2252:40-45: WARNING: conversion > to bool not needed here. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong Applied. Thanks! Alex > --- > dr

Re: [PATCH] drm/radeon: fix copy of uninitialized variable back to userspace

2021-03-03 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Mar 3, 2021 at 2:42 AM Christian König wrote: > > Am 03.03.21 um 01:27 schrieb Colin King: > > From: Colin Ian King > > > > Currently the ioctl command RADEON_INFO_SI_BACKEND_ENABLED_MASK can > > copy back uninitialised data in value_tmp that pointer *value points

Re: [PATCH] drm/amd/display: Fix off by one in hdmi_14_process_transaction()

2021-03-03 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Mar 2, 2021 at 2:26 PM Lakha, Bhawanpreet wrote: > > [AMD Official Use Only - Internal Distribution Only] > > > Thanks > > Reviewed-by: Bhawanpreet Lakha > > From: Dan Carpenter > Sent: March 2, 2021 6:15 AM > To: Wentland, Harry

Re: [PATCH 04/53] drm/amd/display/dc/bios/command_table: Remove unused variable

2021-03-03 Thread Alex Deucher
_table.c: In function > ‘adjust_display_pll_v2’: > drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table.c:1459:35: > warning: variable ‘params’ set but not used [-Wunused-but-set-variable] > > Cc: Harry Wentland > Cc: Leo Li > Cc: Alex Deucher > Cc: "Christian Kön

Re: [PATCH 07/53] drm/amd/display/dc/bios/command_table: Remove unused variable and associated comment

2021-03-03 Thread Alex Deucher
462:11: > warning: unused variable ‘pixel_clock_10KHz_in’ [-Wunused-variable] > > Cc: Harry Wentland > Cc: Leo Li > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Lee Jones > Cc: amd-...@lists.freedesktop.org > C

Re: [PATCH 10/53] drm/amd/display/dc/dce/dce_aux: Remove duplicate line causing 'field overwritten' issue

2021-03-03 Thread Alex Deucher
ISABLE’) > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_aux.h:214:16: note: in > expansion of macro ‘AUX_SW_DATA__AUX_SW_AUTOINCREMENT_DISABLE_MASK’ > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_aux.h:127:2: note: in > expansion of macro ‘AUX_SF’ > > Cc: Harry Wentland > Cc: Leo Li > Cc: Al

[pull] amdgpu drm-fixes-5.12

2021-03-03 Thread Alex Deucher
-03-03: amdgpu: - S0ix fix - Handle new NV12 SKU - Misc power fixes - Display uninitialized value fix - PCIE debugfs register access fix Alex Deucher (4): drm/amdgpu: Only check for S0ix if AMD_PMC is configured drm/amdgpu

Re: [PATCH] drm/amdgpu/display: Remove unnecessary conversion to bool

2021-03-05 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Mar 4, 2021 at 3:02 AM Jiapeng Chong wrote: > > Fix the following coccicheck warnings: > > ./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:956:52-57: WARNING: > conversion to bool not needed here. > > ./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:8311:16-

Re: [PATCH][next] drm/amd/display: remove redundant initialization of variable status

2021-03-05 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Mar 3, 2021 at 9:07 AM Colin King wrote: > > From: Colin Ian King > > The variable status is being initialized with a value that is never read > and it is being updated later with a new value. The initialization is > redundant and can be removed. > > Addresses-Co

Re: [PATCH][next] drm/amdgpu/display: remove redundant continue statement

2021-03-05 Thread Alex Deucher
Applied. thanks. Alex On Wed, Mar 3, 2021 at 8:25 AM Colin King wrote: > > From: Colin Ian King > > The continue statement in a for-loop is redudant and can be removed. > Clean up the code to address this. > > Addresses-Coverity: ("Continue as no effect") > Fixes: b6f91fc183f7 ("drm/amdgpu/dis

Re: [PATCH][next] drm/radeon/si_dpm: Replace one-element array with flexible-array in struct SISLANDS_SMC_SWSTATE

2021-03-05 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Mar 3, 2021 at 2:05 PM Gustavo A. R. Silva wrote: > > There is a regular need in the kernel to provide a way to declare having > a dynamically sized set of trailing elements in a structure. Kernel code > should always use “flexible array members”[1] for these cases

Re: [PATCH] drm/amd/display: Remove unnecessary conversion to bool

2021-03-05 Thread Alex Deucher
The same patch was already applied a while ago. Thanks, Alex On Fri, Mar 5, 2021 at 1:41 AM Jiapeng Chong wrote: > > Fix the following coccicheck warnings: > > ./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:8257:16-21: WARNING: > conversion to bool not needed here. > > Reported-by: Abaci R

Re: [PATCH] drm/gem: add checks of drm_gem_object->funcs

2021-03-08 Thread Alex Deucher
On Mon, Mar 1, 2021 at 5:25 AM Christian König wrote: > > > > Am 01.03.21 um 11:04 schrieb Daniel Vetter: > > On Mon, Mar 1, 2021 at 10:56 AM Thomas Zimmermann > > wrote: > >> (cc'ing amd devs) > >> > >> Hi > >> > >> Am 28.02.21 um 17:10 schrieb Pavel Turinský: > >>> The checks were removed in c

Re: [PATCH] gpu: drm: swsmu: fix error return code of smu_v11_0_set_allowed_mask()

2021-03-08 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Mar 4, 2021 at 11:02 PM Quan, Evan wrote: > > [AMD Public Use] > > Thanks. Reviewed-by: Evan Quan > > -Original Message- > From: Jia-Ju Bai > Sent: Friday, March 5, 2021 11:54 AM > To: Deucher, Alexander ; Koenig, Christian > ; airl...@linux.ie; dan...@f

Re: [PATCH] drm/amdgpu: Verify bo size can fit framebuffer size on init.

2021-03-08 Thread Alex Deucher
ught using igt-gpu-tools test: kms_addfb_basic.too-high > and kms_addfb_basic.bo-too-small > > Tested on ChromeOS Zork by turning on the display and running a YT > video. > > Cc: Alex Deucher > Cc: "Christian König" > Cc: Sean Paul > Signed-off-by: Mark Yacoub

Re: [PATCH] drm/amd/display: remove duplicate include in amdgpu_dm.c

2021-03-08 Thread Alex Deucher
Applied. Thanks! Alex On Sat, Mar 6, 2021 at 5:48 AM wrote: > > From: Zhang Yunkai > > 'drm/drm_hdcp.h' included in 'amdgpu_dm.c' is duplicated. > It is also included in the 79th line. > > Signed-off-by: Zhang Yunkai > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 - > 1 file c

Re: [PATCH] drm/amd/display: remove duplicate include in dcn21 and gpio

2021-03-08 Thread Alex Deucher
Applied. Thanks! Alex On Sat, Mar 6, 2021 at 6:05 AM wrote: > > From: Zhang Yunkai > > 'dce110_resource.h' included in 'dcn21_resource.c' is duplicated. > 'hw_gpio.h' included in 'hw_factory_dce110.c' is duplicated. > > Signed-off-by: Zhang Yunkai > --- > drivers/gpu/drm/amd/display/dc/dcn21

Re: [PATCH] drm/amd/display: Remove unnecessary conversion to bool

2021-03-08 Thread Alex Deucher
On Sun, Mar 7, 2021 at 10:00 PM Jiapeng Chong wrote: > > Fix the following coccicheck warnings: > > ./drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c:561:34-39: WARNING: > conversion to bool not needed here. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong This patch was already ap

Re: [PATCH] drm/amdgpu: Remove unnecessary conversion to bool

2021-03-08 Thread Alex Deucher
On Sun, Mar 7, 2021 at 10:14 PM Jiapeng Chong wrote: > > Fix the following coccicheck warnings: > > ./drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c:1600:40-45: WARNING: conversion > to bool not needed here. > > ./drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c:1598:40-45: WARNING: conversion > to bool not needed

Re: [PATCH v2] drm/amdgpu: Verify bo size can fit framebuffer size on init.

2021-03-08 Thread Alex Deucher
ught using igt-gpu-tools test: kms_addfb_basic.too-high > and kms_addfb_basic.bo-too-small > > Tested on ChromeOS Zork by turning on the display and running a YT > video. > > === Changes from v1 === > 1. Added new line under declarations. > 2. Use C style comment. > > Cc:

Re: [PATCH 1/1] drm/amdkfd: fix build error with AMD_IOMMU_V2=m

2021-03-09 Thread Alex Deucher
On Tue, Mar 9, 2021 at 12:55 PM Jean-Philippe Brucker wrote: > > Hi Felix, > > On Tue, Mar 09, 2021 at 11:30:19AM -0500, Felix Kuehling wrote: > > > I think the proper fix would be to not rely on custom hooks into a > > > particular > > > IOMMU driver, but to instead ensure that the amdgpu driver

Re: [PATCH]] drm/amdgpu/gfx9: add gfxoff quirk

2021-03-10 Thread Alex Deucher
On Wed, Mar 10, 2021 at 11:37 AM Daniel Gomez wrote: > > Disabling GFXOFF via the quirk list fixes a hardware lockup in > Ryzen V1605B, RAVEN 0x1002:0x15DD rev 0x83. > > Signed-off-by: Daniel Gomez > --- > > This patch is a continuation of the work here: > https://lkml.org/lkml/2021/2/3/122 where

[pull] amdgpu, radeon drm-fixes-5.12

2021-03-10 Thread Alex Deucher
Alex Deucher (4): drm/amdgpu/display: simplify backlight setting drm/amdgpu/display: don't assert in set backlight function drm/amdgpu/display: handle aux backlight in backlight_get_brightness drm/amdgpu: fix S0ix handling when the CONFIG_AMD_PMC=m Christian Kön

Re: [PATCH][next] drm/amdgpu: Fix spelling mistake "disabed" -> "disabled"

2021-03-11 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Mar 11, 2021 at 4:28 AM Colin King wrote: > > From: Colin Ian King > > There is a spelling mistake in a drm debug message. Fix it. > > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- > 1 file changed, 1 insertion(+), 1 de

Re: [PATCH v2 0/3] drm/amdgpu: Remove in_interrupt() usage.

2021-03-11 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Feb 9, 2021 at 7:50 AM Christian König wrote: > > Reviewed-by: Christian König for the series. > > Am 09.02.21 um 13:44 schrieb Sebastian Andrzej Siewior: > > Folks, > > > > in the discussion about preempt count consistency across kernel > > configurations: > > >

Re: [PATCH]] drm/amdgpu/gfx9: add gfxoff quirk

2021-03-11 Thread Alex Deucher
On Thu, Mar 11, 2021 at 10:02 AM Alexandre Desnoyers wrote: > > On Thu, Mar 11, 2021 at 2:49 PM Daniel Gomez wrote: > > > > On Thu, 11 Mar 2021 at 10:09, Daniel Gomez wrote: > > > > > > On Wed, 10 Mar 2021 at 18:06, Alex Deucher wrote: > > > >

Re: [PATCH] drm/scheduler re-insert Bailing job to avoid memleak

2021-03-11 Thread Alex Deucher
+dri-devel Please be sure to cc dri-devel when you send out gpu scheduler patches. On Thu, Mar 11, 2021 at 10:57 PM Jack Zhang wrote: > > re-insert Bailing jobs to avoid memory leak. > > Signed-off-by: Jack Zhang > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 +++- > drivers/gpu/drm/am

Re: [Mesa-dev] [RFC] Linux Graphics Next: Explicit fences everywhere and no BO fences - initial proposal

2021-05-03 Thread Alex Deucher
On Sat, May 1, 2021 at 6:27 PM Marek Olšák wrote: > > On Wed, Apr 28, 2021 at 5:07 AM Michel Dänzer wrote: >> >> On 2021-04-28 8:59 a.m., Christian König wrote: >> > Hi Dave, >> > >> > Am 27.04.21 um 21:23 schrieb Marek Olšák: >> >> Supporting interop with any device is always possible. It depend

Re: [PATCH 0/2] drm/radeon: Fix off-by-one power_state index heap overwrite

2021-05-04 Thread Alex Deucher
On Mon, May 3, 2021 at 1:06 AM Kees Cook wrote: > > Hi, > > This is an attempt at fixing a bug[1] uncovered by the relocation of > the slab freelist pointer offset, as well as some related clean-ups. > > I don't have hardware to do runtime testing, but it builds. ;) > > -Kees > > [1] https://bugzi

Re: [PATCH] drm/amd/pm: initialize variable

2021-05-04 Thread Alex Deucher
On Fri, Apr 30, 2021 at 2:05 PM wrote: > > From: Tom Rix > > Static analysis reports this problem > > amdgpu_pm.c:478:16: warning: The right operand of '<' is a garbage value > for (i = 0; i < data.nums; i++) { > ^ ~ > > In some cases data is not set. Initialize to 0 an

Re: [PATCH v4] drm/amd/amdgpu/amdgpu_drv.c: Replace drm_modeset_lock_all with drm_modeset_lock

2021-05-04 Thread Alex Deucher
On Tue, Apr 27, 2021 at 5:45 AM Fabio M. De Francesco wrote: > > drm_modeset_lock_all() is not needed here, so it is replaced with > drm_modeset_lock(). The crtc list around which we are looping never > changes, therefore the only lock we need is to protect access to > crtc->state. > > Suggested-b

Re: 16 bpc fixed point (RGBA16) framebuffer support for core and AMD.

2021-05-04 Thread Alex Deucher
On Wed, Apr 28, 2021 at 5:21 PM Alex Deucher wrote: > > On Tue, Apr 20, 2021 at 5:25 PM Alex Deucher wrote: > > > > On Fri, Apr 16, 2021 at 12:29 PM Mario Kleiner > > wrote: > > > > > > Friendly ping to the AMD people. Nicholas, Harry, Alex, any fee

[pull] radeon, amdgpu drm-fixes-5.13

2021-05-05 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.13. The following changes since commit a1a1ca70deb3ec600eeabb21de7f3f48aaae5695: Merge tag 'drm-misc-next-fixes-2021-04-22' of git://anongit.freedesktop.org/drm/drm-misc into drm-next (2021-04-23 13:53:07 +1000) are available in the Git repository at: https:/

<    1   2   3   4   5   6   7   8   9   10   >