Re: [PATCH] drm/amd/pm: And destination bounds checking to struct copy

2021-08-20 Thread Alex Deucher
; Cc: Jiawei Gu > Cc: Evan Quan > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Kees Cook > Link: > https://lore.kernel.org/lkml/cadnq5_npb8uyvd+r4uhgf-w8-cqj3joodjvijr_y9w9wqj7...@mail.gmail.com > --- > Alex, I dropped your p

[pull] amdgpu, amdkfd, radeon drm-next-5.15

2021-08-20 Thread Alex Deucher
Hi Dave, Daniel, Updates for 5.15. Mainly bug fixes and cleanups. The following changes since commit 554594567b1fa3da74f88ec7b2dc83d000c58e98: drm/display: fix possible null-pointer dereference in dcn10_set_clock() (2021-08-11 17:19:54 -0400) are available in the Git repository at: https

Re: [PATCH] gpu: drm: amd: amdgpu: Fixed a few warnings

2021-08-23 Thread Alex Deucher
On Sat, Aug 21, 2021 at 4:46 AM Liviu Cheru wrote: > > Fixed warnings regarding SPDX license, using "unsigned" instead > of "unsigned int", wrong function parameter name for the > documentation and a space between the function name and "(". > In general, please split these up by the type of chang

Re: [PATCH] drm/amdgpu: switch from 'pci_' to 'dma_' API

2021-08-23 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Aug 23, 2021 at 2:16 AM Christian König wrote: > > Am 22.08.21 um 23:21 schrieb Christophe JAILLET: > > The wrappers in include/linux/pci-dma-compat.h should go away. > > > > The patch has been generated with the coccinelle script below. > > > > It has been compile

Re: [PATCH] drm/radeon: switch from 'pci_' to 'dma_' API

2021-08-23 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Aug 23, 2021 at 2:17 AM Christian König wrote: > > Am 22.08.21 um 23:23 schrieb Christophe JAILLET: > > The wrappers in include/linux/pci-dma-compat.h should go away. > > > > The patch has been generated with the coccinelle script below. > > > > It has been compile

Re: [PATCH] drm/r128: switch from 'pci_' to 'dma_' API

2021-08-23 Thread Alex Deucher
> > @@ > expression e1, e2, e3, e4; > @@ > -pci_dma_sync_sg_for_device(e1, e2, e3, e4) > +dma_sync_sg_for_device(&e1->dev, e2, e3, e4) > > @@ > expression e1, e2; > @@ > -pci_dma_mapping_error(e1, e2) > +dma_mapping_error(&e1->dev, e2)

Re: [RFC] Make use of non-dynamic dmabuf in RDMA

2021-08-24 Thread Alex Deucher
On Tue, Aug 24, 2021 at 3:16 PM Dave Airlie wrote: > > On Wed, 25 Aug 2021 at 03:36, John Hubbard wrote: > > > > On 8/24/21 10:32 AM, Jason Gunthorpe wrote: > > ... > > >>> And yes at least for the amdgpu driver we migrate the memory to host > > >>> memory as soon as it is pinned and I would expe

Re: [PATCH][next] drm/amd/display: fix spelling mistake "alidation" -> "validation"

2021-08-25 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Aug 25, 2021 at 10:09 AM Harry Wentland wrote: > > On 2021-08-25 7:36 a.m., Colin King wrote: > > From: Colin Ian King > > > > There is a spelling mistake in a DC_LOG_WARNING message. Fix it. > > > > Signed-off-by: Colin Ian King > > Reviewed-by: Harry Wentland

[pull] amdgpu drm-fixes-5.14

2021-08-25 Thread Alex Deucher
Hi Dave, Daniel, A few last fixes for 5.14. The following changes since commit daa7772d477ec658dc1fd9127549a7996d8e0c2b: Merge tag 'amd-drm-fixes-5.14-2021-08-18' of https://gitlab.freedesktop.org/agd5f/linux into drm-fixes (2021-08-20 15:13:56 +1000) are available in the Git repository at:

Re: [PATCH v2] drm/amd/pm: And destination bounds checking to struct copy

2021-08-26 Thread Alex Deucher
; Cc: Jiawei Gu > Cc: Evan Quan > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Reviewed-by: Lijo Lazar > Acked-by: Alex Deucher > Signed-off-by: Kees Cook > --- > v2: > - rename and move helper to drivers/gpu/drm/amd/pm/inc/amdgpu_smu

Re: [PATCH linux-next] drm:dcn31: fix boolreturn.cocci warnings

2021-08-26 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Aug 24, 2021 at 1:52 AM CGEL wrote: > > From: Jing Yangyang > > ./drivers/gpu/drm/amd/display/dc/dcn31/dcn31_panel_cntl.c:112:9-10:WARNING: > return of 0/1 in function 'dcn31_is_panel_backlight_on' > with return type bool > > ./drivers/gpu/drm/amd/display/dc/dcn31

Re: [PATCH][next] drm/amd/pm: Fix spelling mistake "disble" -> "disable"

2021-03-15 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Mar 12, 2021 at 5:08 AM Colin King wrote: > > From: Colin Ian King > > There is a spelling mistake in an assert message. Fix it. > > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c | 2 +- > 1 file changed, 1 insertion(+

Re: [PATCH] drm/amd/display: remove redundant initialization of variable result

2021-03-15 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Mar 11, 2021 at 11:34 AM Colin King wrote: > > From: Colin Ian King > > The variable result is being initialized with a value that is > never read and it is being updated later with a new value. The > initialization is redundant and can be removed. > > Addresses-

Re: [PATCH V2] drm: amd: pm: Mundane typo fixes in the file amdgpu_pm.c

2021-03-15 Thread Alex Deucher
On Sun, Mar 14, 2021 at 11:22 PM Bhaskar Chowdhury wrote: > > > s/"an minimum"/"a minimum"/ > s/"an maxmum"/"a maximum"/ > > Signed-off-by: Bhaskar Chowdhury Applied. Thanks! Alex > --- > Changes from V1: > Randy's suggestion to adjust the subject line text > And missed out a spell too,w

Re: [PATCH] drm/amd/display: Remove unnecessary conversion to bool

2021-03-15 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Mar 15, 2021 at 4:22 AM Jiapeng Chong wrote: > > Fix the following coccicheck warnings: > > ./drivers/gpu/drm/amd/display/dc/dcn30/dcn30_mpc.c:358:69-74: WARNING: > conversion to bool not needed here. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong >

Re: [PATCH] drm/amd/display: Remove unnecessary conversion to bool

2021-03-17 Thread Alex Deucher
On Tue, Mar 16, 2021 at 4:09 AM Jiapeng Chong wrote: > > Fix the following coccicheck warnings: > > ./drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dpp.c:721:65-70: WARNING: > conversion to bool not needed here. > > ./drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dpp.c:1139:67-72: WARNING: > conversion

Re: [PATCH] drm/amd/display: Remove unnecessary conversion to bool

2021-03-17 Thread Alex Deucher
On Wed, Mar 17, 2021 at 10:37 PM Jiapeng Chong wrote: > > Fix the following coccicheck warnings: > > ./drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dwb_cm.c:220:65-70: > WARNING: conversion to bool not needed here. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong Applied. Thanks. In

[pull] amdgpu drm-fixes-5.12

2021-03-17 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.12. The following changes since commit 4042160c2e5433e0759782c402292a90b5bf458d: drm/nouveau: fix dma syncing for loops (v2) (2021-03-12 11:21:47 +1000) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-5

Re: [PATCH] drm/amdgpu: Fix a typo

2021-03-18 Thread Alex Deucher
On Thu, Mar 18, 2021 at 2:08 PM Randy Dunlap wrote: > > On 3/18/21 4:33 AM, Bhaskar Chowdhury wrote: > > > > s/traing/training/ > > > > Signed-off-by: Bhaskar Chowdhury > > --- > > drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git

Re: [PATCH] drm/amdgpu/ttm: Fix memory leak userptr pages

2021-03-18 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Mar 17, 2021 at 12:09 PM Daniel Gomez wrote: > > If userptr pages have been pinned but not bounded, > they remain uncleared. > > Signed-off-by: Daniel Gomez > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions

Re: [PATCH] drm/radeon/ttm: Fix memory leak userptr pages

2021-03-18 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Mar 18, 2021 at 5:00 AM Koenig, Christian wrote: > > Reviewed-by: Christian König > > Von: Daniel Gomez > Gesendet: Donnerstag, 18. März 2021 09:32 > Cc: dag...@gmail.com ; Daniel Gomez ; > Deucher, Alexander ; Koenig, Christian

Re: [PATCH] drm/amdgpu: Fix a typo

2021-03-18 Thread Alex Deucher
Applied both patches. Thanks! Alex On Thu, Mar 18, 2021 at 7:20 PM Bhaskar Chowdhury wrote: > > > s/proces/process/ > > Signed-off-by: Bhaskar Chowdhury > --- > drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/

Re: [PATCH] drm/amd/display: Set AMDGPU_DM_DEFAULT_MIN_BACKLIGHT to 0

2021-03-19 Thread Alex Deucher
On Fri, Mar 19, 2021 at 3:23 AM Evan Benn wrote: > > AMDGPU_DM_DEFAULT_MIN_BACKLIGHT was set to the value of 12 > to ensure no display backlight will flicker at low user brightness > settings. However this value is quite bright, so for devices that do not > implement the ACPI ATIF > ATIF_FUNCTION_

Re: [PATCH 06/19] drm/amd/display/dc/calcs/dce_calcs: Move some large variables from the stack to the heap

2021-03-19 Thread Alex Deucher
.c:2016:1: warning: > the frame size of 1216 bytes is larger than 1024 bytes [-Wframe-larger-than=] > > Cc: Harry Wentland > Cc: Leo Li > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Colin Ian Ki

Re: [PATCH 08/19] drm/amd/display/dc/dce80/dce80_resource: Make local functions static

2021-03-19 Thread Alex Deucher
./display/dc/dce80/dce80_resource.c:868:6: > warning: no previous prototype for ‘dce80_validate_bandwidth’ > [-Wmissing-prototypes] > drivers/gpu/drm/amd/amdgpu/../display/dc/dce80/dce80_resource.c:913:16: > warning: no previous prototype for ‘dce80_validate_global’ > [-Wmissing-proto

Re: [PATCH 06/19] drm/amd/display/dc/calcs/dce_calcs: Move some large variables from the stack to the heap

2021-03-19 Thread Alex Deucher
On Fri, Mar 19, 2021 at 2:26 PM Harry Wentland wrote: > > On 2021-03-19 2:13 p.m., Alex Deucher wrote: > > + Harry, Nick > > > > On Fri, Mar 19, 2021 at 4:24 AM Lee Jones wrote: > >> > >> Fixes the following W=1 kernel build warning(s): > >> &g

Re: [PATCH 06/19] drm/amd/display/dc/calcs/dce_calcs: Move some large variables from the stack to the heap

2021-03-19 Thread Alex Deucher
On Fri, Mar 19, 2021 at 2:47 PM Christian König wrote: > > > > Am 19.03.21 um 19:26 schrieb Harry Wentland: > > On 2021-03-19 2:13 p.m., Alex Deucher wrote: > >> + Harry, Nick > >> > >> On Fri, Mar 19, 2021 at 4:24 AM Lee Jones wrote: > >>

[pull] amdgpu, amdkfd, radeon drm-next-5.13

2021-03-19 Thread Alex Deucher
. Proposed userspace: https://github.com/RadeonOpenCompute/ROCT-Thunk-Interface/commit/7cdd63475c36bb9f49bb960f90f9a8cdb7e80a21 Alex Deucher (21): drm/amdgpu: add asic callback for querying video codec info (v3) drm/amdgpu

Re: [PATCH] drm/amd/display: Set AMDGPU_DM_DEFAULT_MIN_BACKLIGHT to 0

2021-03-19 Thread Alex Deucher
On Fri, Mar 19, 2021 at 5:31 PM Evan Benn wrote: > > On Sat, 20 Mar 2021 at 02:10, Harry Wentland wrote: > > On 2021-03-19 10:22 a.m., Alex Deucher wrote: > > > On Fri, Mar 19, 2021 at 3:23 AM Evan Benn wrote: > > >> > > >> AMDGPU_DM_DEFAULT_MIN_B

Re: [PATCH V2] drm/amdgpu: Fix a typo

2021-03-22 Thread Alex Deucher
On Sat, Mar 20, 2021 at 3:52 AM Randy Dunlap wrote: > > > > On Fri, 19 Mar 2021, Bhaskar Chowdhury wrote: > > > s/traing/training/ > > > > ...Plus the entire sentence construction for better readability. > > > > Signed-off-by: Bhaskar Chowdhury > > --- > > Changes from V1: > > Alex and Randy's s

Re: [PATCH] drm/amd/display: Set AMDGPU_DM_DEFAULT_MIN_BACKLIGHT to 0

2021-03-22 Thread Alex Deucher
On Sun, Mar 21, 2021 at 8:12 PM Evan Benn wrote: > > On Sat, Mar 20, 2021 at 8:36 AM Alex Deucher wrote: > > > > On Fri, Mar 19, 2021 at 5:31 PM Evan Benn wrote: > > > > > > On Sat, 20 Mar 2021 at 02:10, Harry Wentland > > > wrote: > &g

Re: [PATCH v2] drm/radeon: don't evict if not initialized

2021-03-23 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Mar 22, 2021 at 3:40 AM Christian König wrote: > > Am 21.03.21 um 16:19 schrieb Tong Zhang: > > TTM_PL_VRAM may not initialized at all when calling > > radeon_bo_evict_vram(). We need to check before doing eviction. > > > > [2.160837] BUG: kernel NULL pointer d

Re: [PATCH] drm/atomic: Couple of typo fixes

2021-03-23 Thread Alex Deucher
Applied. Thanks! Alex On Sat, Mar 20, 2021 at 3:10 PM Randy Dunlap wrote: > > > > On Sun, 21 Mar 2021, Bhaskar Chowdhury wrote: > > > > > s/seralization/serialization/ > > s/parallism/parallelism/ > > > > Signed-off-by: Bhaskar Chowdhury > > Acked-by: Randy Dunlap > > > > --- > > drivers/gpu/

Re: [PATCH] drm/amdkfd: Fix cat debugfs hang_hws file causes system crash bug

2021-03-23 Thread Alex Deucher
Applied. Thanks! Alex On Sun, Mar 21, 2021 at 5:33 AM Qu Huang wrote: > > Here is the system crash log: > [ 1272.884438] BUG: unable to handle kernel NULL pointer dereference at > (null) > [ 1272.88] IP: [< (null)>] (null) > [ 1272.884447] PGD 825b09067 PUD 8267c8067 PMD

Re: [PATCH] drivers: gpu: Remove duplicate include of amdgpu_hdp.h

2021-03-23 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Mar 22, 2021 at 8:10 AM Christian König wrote: > > > > Am 22.03.21 um 13:02 schrieb Wan Jiabing: > > amdgpu_hdp.h has been included at line 91, so remove > > the duplicate include. > > > > Signed-off-by: Wan Jiabing > > Acked-by: Christian König > > > --- > > d

Re: [PATCH] amdgpu: avoid incorrect %hu format string

2021-03-23 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Mar 22, 2021 at 7:55 AM Arnd Bergmann wrote: > > From: Arnd Bergmann > > clang points out that the %hu format string does not match the type > of the variables here: > > drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c:263:7: warning: format specifies type > 'unsigned sho

Re: [PATCH] drm/amdgpu: Ensure that the modifier requested is supported by plane.

2021-03-23 Thread Alex Deucher
validate that the > modifier is on the list of the plane's supported modifiers. > > The bug was caught using igt-gpu-tools test: > kms_addfb_basic.addfb25-bad-modifier > > Tested on ChromeOS Zork by turning on the display, running an overlay > test, and running a YT video. &

Re: [PATCH] gpu: drm: amd: Remove duplicate include of dce110_resource.h

2021-03-23 Thread Alex Deucher
The same patch was already applied recently. Thanks! Alex On Mon, Mar 22, 2021 at 9:10 PM Wan Jiabing wrote: > > dce110/dce110_resource.h has been included at line 58, so remove > the duplicate include at line 64. > > Signed-off-by: Wan Jiabing > --- > drivers/gpu/drm/amd/display/dc/dcn21/dcn

Re: [PATCH] gpu: drm: amd: Remove duplicate includes

2021-03-23 Thread Alex Deucher
Same patch was already applied recently. Thanks, Alex On Mon, Mar 22, 2021 at 9:19 PM Wan Jiabing wrote: > > ../hw_ddc.h, ../hw_gpio.h and ../hw_hpd.h have been included > at line 32, so remove them. > > Signed-off-by: Wan Jiabing > --- > .../gpu/drm/amd/display/dc/gpio/dce110/hw_factory_dce1

Re: [PATCH] amdgpu: fix gcc -Wrestrict warning

2021-03-23 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Mar 23, 2021 at 9:04 AM Arnd Bergmann wrote: > > From: Arnd Bergmann > > gcc warns about an sprintf() that uses the same buffer as source > and destination, which is undefined behavior in C99: > > drivers/gpu/drm/amd/amdgpu/amdgpu_securedisplay.c: In function > '

[pull] amdgpu, amdkfd, radeon drm-next-5.13

2021-03-23 Thread Alex Deucher
RAS features on older versions of the driver. Proposed userspace: https://github.com/RadeonOpenCompute/ROCT-Thunk-Interface/commit/7cdd63475c36bb9f49bb960f90f9a8cdb7e80a21 Alex Deucher (21): drm/amdgpu: add asic callback for

Re: [PATCH] drm/amd/display: Try YCbCr420 color when YCbCr444 fails

2021-03-24 Thread Alex Deucher
On Wed, Mar 17, 2021 at 11:25 AM Werner Sembach wrote: > > When encoder validation of a display mode fails, retry with less bandwidth > heavy YCbCr420 color mode, if available. This enables some HDMI 1.4 setups > to support 4k60Hz output, which previously failed silently. > > On some setups, whil

[pull] amdgpu drm-fixes-5.12

2021-03-24 Thread Alex Deucher
-drm-fixes-5.12-2021-03-24: amdgpu: - S0ix fixes - Add PCI ID - Polaris PCIe DPM fix - Display fix for high refresh rate monitors ---- Alex Deucher (11): drm/amdgpu: rework S3/S4/S0ix state handling drm/amdgpu: don't evi

Re: [PATCH] drm/radeon/radeon_pm: Convert sysfs sprintf/snprintf family to sysfs_emit

2021-03-25 Thread Alex Deucher
On Wed, Mar 24, 2021 at 2:47 AM Tian Tao wrote: > > Fix the following coccicheck warning: > drivers/gpu//drm/radeon/radeon_pm.c:521:9-17: WARNING: use scnprintf or > sprintf > drivers/gpu//drm/radeon/radeon_pm.c:475:8-16: WARNING: use scnprintf or > sprintf > drivers/gpu//drm/radeon/radeon_pm.c:41

Re: Color mode exposed to user space?

2021-03-25 Thread Alex Deucher
+ dri-devel I don't think it's currently exposed anywhere. Alex On Wed, Mar 24, 2021 at 5:11 AM Werner Sembach wrote: > > Hello, > > is the information which color mode is currently in used for a display (RGB, > YCbCr444, or YCbCr420) exposed to user space somewhere? > > If no: Where would be

Re: [PATCH drm/amdgpu 0/2] Convert sysfs sprintf/snprintf family to sysfs_emit

2021-03-25 Thread Alex Deucher
Applied the series. Thanks! Alex On Wed, Mar 24, 2021 at 5:17 AM Tian Tao wrote: > > Use the generic sysfs_emit() function to take place of > snprintf/scnprintf, to avoid buffer overrun. > > Tian Tao (2): > drm/amdgpu: Convert sysfs sprintf/snprintf family to sysfs_emit > drm/amd/pm: Conver

Re: [PATCH v2] drm/amdgpu: Ensure that the modifier requested is supported by plane.

2021-03-25 Thread Alex Deucher
; > === Changes from v1 === > Explicitly handle DRM_FORMAT_MOD_INVALID modifier. > > Cc: Alex Deucher > Cc: Bas Nieuwenhuizen > Signed-off-by: default avatarMark Yacoub Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_display.c| 13 + > .

Re: [PATCH] amdgpu: securedisplay: simplify i2c hexdump output

2021-03-25 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Mar 24, 2021 at 9:37 AM Arnd Bergmann wrote: > > From: Arnd Bergmann > > A previous fix I did left a rather complicated loop in > amdgpu_securedisplay_debugfs_write() for what could be expressed in a > simple sprintf, as Rasmus pointed out. > > This drops the lead

Re: [PATCH V2] drm/radeon/r600_cs: Few typo fixes

2021-03-25 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Mar 24, 2021 at 7:46 PM Randy Dunlap wrote: > > On 3/24/21 4:29 PM, Bhaskar Chowdhury wrote: > > s/miror/mirror/ > > s/needind/needing/ > > s/informations/information/ > > > > Signed-off-by: Bhaskar Chowdhury > > Acked-by: Randy Dunlap > > Thanks. > > > --- > >

Re: [PATCH] drm/amd/amdgpu/gfx_v7_0: Trivial typo fixes

2021-03-25 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Mar 25, 2021 at 5:26 AM Nirmoy wrote: > > > Reviewed-by: Nirmoy Das > > On 3/25/21 9:53 AM, Bhaskar Chowdhury wrote: > > s/acccess/access/ > > s/inferface/interface/ > > s/sequnce/sequence/ .two different places. > > s/retrive/retrieve/ > > s/sheduling/schedul

Re: [PATCH] drm/amd: Fix a typo in two different sentences

2021-03-25 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Mar 22, 2021 at 6:45 PM Randy Dunlap wrote: > > On 3/22/21 2:06 PM, Bhaskar Chowdhury wrote: > > > > s/defintion/definition/ .two different places. > > > > Signed-off-by: Bhaskar Chowdhury > > Acked-by: Randy Dunlap > > > --- > > drivers/gpu/drm/amd/include/

[PATCH] drm/amdgpu/display: fix merge breakage

2021-03-26 Thread Alex Deucher
Looks like this got accidently dropped. Fixes: 2cbcb78c9ee5 ("Merge tag 'amd-drm-next-5.13-2021-03-23' of https://gitlab.freedesktop.org/agd5f/linux into drm-next") Signed-off-by: Alex Deucher Cc: daniel.vet...@ffwll.ch --- drivers/gpu/drm/amd/display/dc/irq/dcn21/irq

Re: [PATCH] drm/amdgpu/display: fix merge breakage

2021-03-26 Thread Alex Deucher
Nevermind, I think I screwed this up locally. Alex On Fri, Mar 26, 2021 at 4:07 PM Alex Deucher wrote: > > Looks like this got accidently dropped. > > Fixes: 2cbcb78c9ee5 ("Merge tag 'amd-drm-next-5.13-2021-03-23' of > https://gitlab.freedesktop.org/agd5f/linux i

Re: [PATCH] drm/amd/display: Try YCbCr420 color when YCbCr444 fails

2021-03-29 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Mar 26, 2021 at 10:59 AM Harry Wentland wrote: > > > > On 2021-03-24 4:23 p.m., Alex Deucher wrote: > > On Wed, Mar 17, 2021 at 11:25 AM Werner Sembach > > wrote: > >> > >> When encoder validation of a display mode f

Re: [TRIVIAL] drm/amd/display: fix typo: liason -> liaison

2021-03-29 Thread Alex Deucher
Applied. Thanks! Alex On Sun, Mar 28, 2021 at 1:35 AM Diego Viola wrote: > > Signed-off-by: Diego Viola > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > b/dri

Re: [PATCH] amd: display: dc: struct dc_state is declared twice

2021-03-29 Thread Alex Deucher
On Sat, Mar 27, 2021 at 3:28 AM Wan Jiabing wrote: > > struct dc_state has been declared at 273rd line. > Remove the duplicate. > Delete duplicate blank lines. Can you split these into separate patches? Alex > > Signed-off-by: Wan Jiabing > --- > drivers/gpu/drm/amd/display/dc/dc.h | 10 -

Re: Re: [PATCH] amd: display: dc: struct dc_state is declared twice

2021-03-30 Thread Alex Deucher
On Mon, Mar 29, 2021 at 9:36 PM 万家兵 wrote: > > > >On Sat, Mar 27, 2021 at 3:28 AM Wan Jiabing wrote: > >> > >> struct dc_state has been declared at 273rd line. > >> Remove the duplicate. > >> Delete duplicate blank lines. > > > >Can you split these into separate patches? > > > >Alex > > OK. But i

Re: [PATCH 0/2] ensure alignment on CPU page for bo mapping

2021-03-30 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Mar 30, 2021 at 12:21 PM Christian König wrote: > > Reviewed-by: Christian König for the entire > series. > > Alex will probably pick them up for the next feature pull request. > > Regards, > Christian. > > Am 30.03.21 um 17:33 schrieb Xℹ Ruoyao: > > In AMDGPU dri

[pull] amdgpu, amdkfd drm-fixes-5.12

2021-03-31 Thread Alex Deucher
-- amd-drm-fixes-5.12-2021-03-31: amdgpu: - Polaris idle power fix - VM fix - Vangogh S3 fix - Fixes for non-4K page sizes amdkfd: - dqm fence memory corruption fix ---- Alex Deucher (1): drm/amdgpu/vangogh: don't c

Re: [PATCH] drm/sched: add missing member documentation

2021-04-01 Thread Alex Deucher
On Thu, Apr 1, 2021 at 8:52 AM Christian König wrote: > > Just fix a warning. > > Signed-off-by: Christian König > Reported-by: Stephen Rothwell > Fixes: f2f12eb9c32b ("drm/scheduler: provide scheduler score externally") Reviewed-by: Alex Deucher > --- >

Re: [PATCH] drm/amd: use kmalloc_array over kmalloc with multiply

2021-04-01 Thread Alex Deucher
Applied. Thanks! On Wed, Mar 31, 2021 at 9:36 AM Bernard Zhao wrote: > > Fix patch check warning: > WARNING: Prefer kmalloc_array over kmalloc with multiply > + buf = kmalloc(MAX_KFIFO_SIZE * sizeof(*buf), GFP_KERNEL); > > Signed-off-by: Bernard Zhao > --- > drivers/gpu/drm/amd/amdkfd/kf

Re: [PATCH] drm/amd: cleanup coding style a bit

2021-04-01 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Mar 31, 2021 at 9:36 AM Bernard Zhao wrote: > > Fix patch check warning: > WARNING: suspect code indent for conditional statements (8, 17) > + if (obj && obj->use < 0) { > +DRM_ERROR("RAS ERROR: Unbalance obj(%s) use\n", > obj->head.name); >

Re: [PATCH] amd/amdgpu: code refactoring to clean code style a bit

2021-04-01 Thread Alex Deucher
This code has been dropped. Alex On Wed, Mar 31, 2021 at 9:36 AM Bernard Zhao wrote: > > Fix checkpatch.pl warning: > Too many leading tabs - consider code refactoring > WARNING: Too many leading tabs - consider code refactoring > + for (j = 0; j <

Re: [PATCH] drm/ttm: add __user annotation in radeon_ttm_vram_read

2021-04-01 Thread Alex Deucher
Current code already contains the fix. Alex On Thu, Apr 1, 2021 at 9:09 AM Christian König wrote: > > Am 24.10.20 um 02:47 schrieb Rasmus Villemoes: > > Keep sparse happy by preserving the __user annotation when casting. > > > > Reported-by: kernel test robot > > Signed-off-by: Rasmus Villemoe

[pull] amdgpu, radeon, ttm, sched drm-next-5.13

2021-04-01 Thread Alex Deucher
s - SR-IOV fixes - Misc cleanups and fixes radeon: - Typo fixes ttm: - Handle cached requests (required for Aldebaran) scheduler: - Fix runqueue selection when changing priorities (required to fix VCN load balancing) ---- Alex D

Re: [PATCH 4/8] drm/radeon: Implement mmap as GEM object function

2021-04-06 Thread Alex Deucher
On Tue, Apr 6, 2021 at 5:09 AM Thomas Zimmermann wrote: > > Moving the driver-specific mmap code into a GEM object function allows > for using DRM helpers for various mmap callbacks. > > This change also allows to support prime-based mmap via DRM's helper > drm_gem_prime_mmap(). > > Permission che

Re: [PATCH 21/40] drm/amd/display/dc/calcs/dce_calcs: Remove unused variables 'v_filter_init_mode' and 'sclk_lvl'

2021-01-14 Thread Alex Deucher
iable ‘sclk_lvl’ set but not used [-Wunused-but-set-variable] > > Cc: Harry Wentland > Cc: Leo Li > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org >

Re: [PATCH 28/40] drm/amd/display/dc/calcs/dce_calcs: Demote non-conformant kernel-doc function headers

2021-01-14 Thread Alex Deucher
alcs' > drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c:3030: warning: > Function parameter or member 'pipe_count' not described in 'bw_calcs' > drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c:3030: warning: > Function parameter

Re: [PATCH 01/30] drm/amd/display/dc/dc_helper: Include our own header, containing prototypes

2021-01-14 Thread Alex Deucher
> drivers/gpu/drm/amd/amdgpu/../display/dc/dc_helper.c:560:10: warning: no > previous prototype for ‘generic_indirect_reg_update_ex’ [-Wmissing-prototypes] > > Cc: Harry Wentland > Cc: Leo Li > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc:

Re: [PATCH 02/30] drm/amd/include/renoir_ip_offset: Mark top-level IP_BASE as __maybe_unused

2021-01-14 Thread Alex Deucher
able=] > drivers/gpu/drm/amd/amdgpu/../include/renoir_ip_offset.h:46:29: warning: > ‘ATHUB_BASE’ defined but not used [-Wunused-const-variable=] > drivers/gpu/drm/amd/amdgpu/../include/renoir_ip_offset.h:39:29: warning: > ‘ACP_BASE’ defined but not used [-Wunused-const-variable=] >

Re: [PATCH 03/30] drm/amd/display/dmub/src/dmub_dcn30: Include our own header containing prototypes

2021-01-14 Thread Alex Deucher
gpu/drm/amd/amdgpu/../display/dmub/src/dmub_dcn30.c:118:6: warning: > no previous prototype for ‘dmub_dcn30_setup_windows’ [-Wmissing-prototypes] > > Cc: Harry Wentland > Cc: Leo Li > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > C

Re: [PATCH 04/30] drm/amd/display/modules/power/power_helpers: Staticify local functions

2021-01-14 Thread Alex Deucher
pes] > > Cc: Harry Wentland > Cc: Leo Li > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Rodrigo Siqueira > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones

Re: [PATCH 05/30] drm/amd/display/modules/info_packet/info_packet: Correct kernel-doc formatting

2021-01-14 Thread Alex Deucher
nnot understand > * > > Cc: Harry Wentland > Cc: Leo Li > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones Applied. T

Re: [PATCH 06/30] drm/amd/display/dc/core/dc_resource: Staticify local functions

2021-01-14 Thread Alex Deucher
gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:1131:6: warning: > no previous prototype for ‘restore_border_left_from_dst’ > [-Wmissing-prototypes] > > Cc: Harry Wentland > Cc: Leo Li > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc:

Re: [PATCH 07/30] drm/amd/display/dc/core/dc_link: Remove unused variable 'status'

2021-01-14 Thread Alex Deucher
rning: > variable ‘status’ set but not used [-Wunused-but-set-variable] > > Cc: Harry Wentland > Cc: Leo Li > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedeskto

Re: [PATCH 08/30] drm/amd/display/dc/core/dc_link_dp: Staticify local function 'linkRateInKHzToLinkRateMultiplier'

2021-01-14 Thread Alex Deucher
Cc: Harry Wentland > Cc: Leo Li > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones Applied. Thanks! Alex > --- >

Re: [PATCH 09/30] drm/amd/display/dc/dce112/dce112_resource: Include our own header file containing prototypes

2021-01-14 Thread Alex Deucher
for ‘dce112_create_resource_pool’ > [-Wmissing-prototypes] > > Cc: Harry Wentland > Cc: Leo Li > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Anthony Koo > Cc: amd-...@lists.freedesktop.org > Cc: dri-deve

Re: [PATCH 10/30] drm/amd/display/dc/core/dc: Staticise local function 'apply_ctx_interdependent_lock'

2021-01-14 Thread Alex Deucher
entland > Cc: Leo Li > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones Applied. Thanks! Alex > --- > drivers/

Re: [PATCH 11/30] drm/amd/display/dc/dce100/Makefile: Ignore -Woverride-init warning

2021-01-14 Thread Alex Deucher
drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_mem_input.h:291:2: note: in > expansion of macro ‘MI_GFX8_TILE_MASK_SH_LIST’ > drivers/gpu/drm/amd/amdgpu/../display/dc/dce100/dce100_resource.c:542:3: > note: in expansion of macro ‘MI_DCE8_MASK_SH_LIST’ > > Cc: Harry Wentland

Re: [PATCH 12/30] drm/amd/display/dc/dce100/dce100_resource: Include our own header containing prototypes

2021-01-14 Thread Alex Deucher
0_find_first_free_match_stream_enc_for_link’ [-Wmissing-prototypes] > drivers/gpu/drm/amd/amdgpu/../display/dc/dce100/dce100_resource.c:1156:23: > warning: no previous prototype for ‘dce100_create_resource_pool’ > [-Wmissing-prototypes] > > Cc: Harry Wentland > Cc: Leo Li &

Re: [PATCH 13/30] drm/amd/display/dc/dce60/Makefile: Ignore -Woverride-init warning

2021-01-14 Thread Alex Deucher
_REG_LIST_DCE60’ > > NB: Snipped lots for the sake of brevity > > Cc: Harry Wentland > Cc: Leo Li > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Mauro Rossi > Cc: amd-...@lists.freedesktop.org > Cc: dri-dev

Re: [PATCH 14/30] drm/amd/display/dc/dce80/Makefile: Ignore -Woverride-init warning

2021-01-14 Thread Alex Deucher
it] > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_aux.h:213:16: note: in > expansion of macro ‘AUX_SW_DATA__AUX_SW_AUTOINCREMENT_DISABLE_MASK’ > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_aux.h:102:2: note: in > expansion of macro ‘AUX_SF’ > > NB: Snipped lots for the sake of

Re: [PATCH 15/30] drm/amd/display/dc/dce80/dce80_resource: Include our own header containing prototypes

2021-01-14 Thread Alex Deucher
e for ‘dce83_create_resource_pool’ > [-Wmissing-prototypes] > > Cc: Harry Wentland > Cc: Leo Li > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Anthony Koo > Cc: amd-...@lists.freedesktop.org > Cc: dri-deve

Re: [PATCH 17/30] drm/amd/display/dc/dce60/dce60_resource: Include our own header containing prototypes

2021-01-14 Thread Alex Deucher
e for ‘dce64_create_resource_pool’ > [-Wmissing-prototypes] > > Cc: Harry Wentland > Cc: Leo Li > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Mauro Rossi > Cc: amd-...@lists.freedesktop.org > Cc: dri-deve

Re: [PATCH 18/30] drm/amd/display/dc/core/dc_link: Move some local data from the stack to the heap

2021-01-14 Thread Alex Deucher
e > frame size of 1176 bytes is larger than 1024 bytes [-Wframe-larger-than=] > > Cc: Harry Wentland > Cc: Leo Li > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@

Re: [PATCH 19/30] drm/amd/display/dc/core/dc_link_dp: Mark 'result_write_min_hblank' as __maybe_unused

2021-01-14 Thread Alex Deucher
_source_specific_data’: > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:4403:18: warning: > variable ‘result_write_min_hblank’ set but not used > [-Wunused-but-set-variable] > > Cc: Harry Wentland > Cc: Leo Li > Cc: Alex Deucher > Cc: "Christian König&qu

Re: [PATCH 20/30] drm/amd/display/dc/core/dc: Fix a bunch of documentation misdemeanours

2021-01-14 Thread Alex Deucher
'dc_link_add_remote_sink' > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:2962: warning: Function > parameter or member 'init_data' not described in 'dc_link_add_remote_sink' > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3022: warning: Function &

Re: [PATCH 21/30] drm/amd/display/dc/core/dc_resource: Demote some kernel-doc abuses

2021-01-14 Thread Alex Deucher
d in > 'dc_remove_stream_from_ctx' > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:1870: warning: > Function parameter or member 'stream' not described in > 'dc_remove_stream_from_ctx' > > Cc: Harry Wentland > Cc: Leo Li > Cc: A

Re: [PATCH 22/30] drm/amd/display/dc/core/dc_link: Fix a couple of function documentation issues

2021-01-14 Thread Alex Deucher
k_detect_helper' > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link.c:3403: warning: > Cannot understand > ***** > > Cc: Harry Wentland > Cc: Leo Li > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-...

Re: [PATCH 06/10] drm: amd: amdgpu_dm.h: fix a wrong kernel-doc markup

2021-01-14 Thread Alex Deucher
On Thu, Jan 14, 2021 at 2:53 AM Mauro Carvalho Chehab wrote: > > There's a missing colon, causing the markup to be ignored, > solving those warnings: > > ../drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:340: warning: > Incorrect use of kernel-doc format: * @active_vblank_irq_

Re: [PATCH] drm/amdgpu: Repeat assignment to max_slave_planes

2021-01-14 Thread Alex Deucher
On Thu, Jan 14, 2021 at 4:29 AM ZhiJie.Zhang wrote: > > Signed-off-by: ZhiJie.Zhang Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c > b/drive

Re: [PATCH] drm/amd/display: Simplify bool comparison

2021-01-14 Thread Alex Deucher
On Wed, Jan 13, 2021 at 8:51 AM Yang Li wrote: > > Fix the following coccicheck warning: > ./drivers/gpu/drm/amd/display/dc/dml/dcn20/display_mode_vba_20.c:3141:30-39: > WARNING: Comparison to bool > > Reported-by: Abaci Robot > Signed-off-by: Yang Li Applied all 4 patches. Thanks! Alex > --

[pull] amdgpu, amdkfd drm-fixes-5.11

2021-01-14 Thread Alex Deucher
Alex Deucher (1): MAINTAINERS: update radeon/amdgpu/amdkfd git trees Alexandre Demers (1): drm/amdgpu: fix DRM_INFO flood if display core is not supported (bug 210921) Huang Rui (1): drm/amdgpu: fix vram type and bandwidth

[pull] amdgpu drm-next-5.12

2021-01-14 Thread Alex Deucher
Alex Deucher (5): MAINTAINERS: update radeon/amdgpu/amdkfd git trees drm/amdgpu: add mode2 reset support for vangogh drm/amdgpu/nv: add mode2 reset handling drm/amdgpu: fix mode2 reset sequence for vangogh drm/amdgpu: Enable GPU reset for vangogh

Re: [pull] amdgpu drm-next-5.12

2021-01-15 Thread Alex Deucher
On Fri, Jan 15, 2021 at 2:28 AM Dave Airlie wrote: > > On Fri, 15 Jan 2021 at 07:22, Alex Deucher wrote: > > > > Hi Dave, Daniel, > > > > More new stuff for 5.12. > > > > The following changes since commit 044a48f420b9d3c19a135b821c34de5b2bee4075: &

Re: [PATCH] drm/amdgpu: Remove unused variable

2021-01-15 Thread Alex Deucher
On Fri, Jan 15, 2021 at 10:02 AM Nirmoy Das wrote: > > Remove unused adev variable > > Fixes: 8f66090b7bb7 ("drm/amdgpu: Remove references to struct > drm_device.pdev") > Reported-by: Stephen Rothwell > Signed-off-by: Nirmoy Das Reviewed-by: Alex Deucher

Re: [pull] amdgpu drm-next-5.12

2021-01-15 Thread Alex Deucher
On Fri, Jan 15, 2021 at 9:51 AM Alex Deucher wrote: > > On Fri, Jan 15, 2021 at 2:28 AM Dave Airlie wrote: > > > > On Fri, 15 Jan 2021 at 07:22, Alex Deucher wrote: > > > > > > Hi Dave, Daniel, > > > > > > More new stuff fo

Re: [PATCH] drm/amdgpu:this forword declear maybe not used

2021-01-15 Thread Alex Deucher
On Fri, Jan 15, 2021 at 3:55 AM ZhiJie.Zhang wrote: > > Signed-off-by: ZhiJie.Zhang Applied with a cleaned up commit message. Thanks! Alex > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/

Re: [PATCH v4 01/14] drm/ttm: Remap all page faults to per process dummy page.

2021-01-18 Thread Alex Deucher
On Mon, Jan 18, 2021 at 4:02 PM Andrey Grodzovsky wrote: > > On device removal reroute all CPU mappings to dummy page. > > v3: > Remove loop to find DRM file and instead access it > by vma->vm_file->private_data. Move dummy page installation > into a separate function. > > v4: > Map the entire BOs

Re: [PATCH v4 04/14] drm/sched: Cancel and flush all oustatdning jobs before finish.

2021-01-18 Thread Alex Deucher
On Mon, Jan 18, 2021 at 4:02 PM Andrey Grodzovsky wrote: > > To avoid any possible use after free. > > Signed-off-by: Andrey Grodzovsky > Reviewed-by: Christian König In the subject: oustatdning -> outstanding Alex > --- > drivers/gpu/drm/scheduler/sched_main.c | 3 +++ > 1 file changed, 3

<    1   2   3   4   5   6   7   8   9   10   >