[PATCH v3 0/1] Fix i915 error_state_read ptr use

2022-03-10 Thread Alan Previn
. v2: - Fix build issue: uninitialized var Reported-by: kernel test robot Alan Previn (1): drm/i915/reset: Fix error_state_read ptr + offset use drivers/gpu/drm/i915/i915_sysfs.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) -- 2.25.1

[PATCH v4 0/1] Fix i915 error_state_read ptr use

2022-03-10 Thread Alan Previn
inconsistent sysfs reads as per review comment from John Harrison. - Add the "fixes" tag referencing the previous patch of the same function. v2: - Fix build issue: uninitialized var Reported-by: kernel test robot Alan Previn (1): drm/i915/reset: Fix error_stat

[PATCH v8 00/13] Add GuC Error Capture Support

2022-03-11 Thread Alan Previn
mp that is being printed before we print out the corresponding VMA dumps such as the batch buffer. v2: - Ignore - failed CI retest. Alan Previn (13): drm/i915/guc: Update GuC ADS size for error capture lists drm/i915/guc: Add XE_LP static registers for GuC error cap

[PATCH v9 00/13] Add GuC Error Capture Support

2022-03-14 Thread Alan Previn
ed error capture information matches the i915_gpu_coredump that is being printed before we print out the corresponding VMA dumps such as the batch buffer. v2: - Ignore - failed CI retest. Alan Previn (13): drm/i915/guc: Update GuC ADS size for error capture list

[PATCH v10 00/13] Add GuC Error Capture Support

2022-03-15 Thread Alan Previn
batch buffer. v2: - Ignore - failed CI retest. Alan Previn (13): drm/i915/guc: Update GuC ADS size for error capture lists drm/i915/guc: Add XE_LP static registers for GuC error capture. drm/i915/guc: Add XE_LP steered register lists support drm/i915/guc: Add DG2 registers for G

[PATCH v11 00/13] Add GuC Error Capture Support

2022-03-17 Thread Alan Previn
int out the corresponding VMA dumps such as the batch buffer. v2: - Ignore - failed CI retest. Alan Previn (13): drm/i915/guc: Update GuC ADS size for error capture lists drm/i915/guc: Add XE_LP static registers for GuC error capture. drm/i915/guc: Add XE_LP steered register

[PATCH v12 12/13] drm/i915/guc: Plumb GuC-capture into gpu_coredump

2022-03-17 Thread Alan Previn
triggered the reset. For now, introduce an empty printing function that can filled in on a subsequent patch just to handle formatting. Signed-off-by: Alan Previn Reviewed-by: Umesh Nerlige Ramappa --- .../drm/i915/gt/intel_execlists_submission.c | 4 +- drivers/gpu/drm/i915/gt/intel_reset.c

[PATCH v12 11/13] drm/i915/guc: Pre-allocate output nodes for extraction

2022-03-17 Thread Alan Previn
in the midst of a reset. That said, we can never dynamically allocate the output nodes in this handler. Thus, we shall pre-allocate a fixed number of empty nodes up front (at the time of ADS registration) that we can consume from or return to an internal cached list of nodes. Signed-off-by: Alan Pr

[PATCH v12 13/13] drm/i915/guc: Print the GuC error capture output register list.

2022-03-17 Thread Alan Previn
e 'engine-capture-group-output' vs a copy of that same info taken during i915_gpu_coredump. If they match, then print those vma's as well (such as the batch buffers). NOTE: the output format was verified using the gem_exec_capture IGT test. Signed-off-by: Alan Previn Reviewed-by

[PATCH v12 10/13] drm/i915/guc: Extract GuC error capture lists on G2H notification.

2022-03-17 Thread Alan Previn
as independent ring buffers. Each guc-log subregion (general-logs, crash-dump and error- capture) has it's own guc_log_buffer_state that contain independent read and write pointers. Signed-off-by: Alan Previn Reviewed-by: Umesh Nerlige Ramappa --- .../gpu/drm/i915/gt/uc/abi/guc_

[PATCH v12 02/13] drm/i915/guc: Add XE_LP static registers for GuC error capture.

2022-03-17 Thread Alan Previn
Add device specific tables and register lists to cover different engines class types for GuC error state capture for XE_LP products. Signed-off-by: Alan Previn Reviewed-by: Umesh Nerlige Ramappa --- .../gpu/drm/i915/gt/uc/intel_guc_capture.c| 116 ++ drivers/gpu/drm/i915/gt

[PATCH v12 03/13] drm/i915/guc: Add XE_LP steered register lists support

2022-03-17 Thread Alan Previn
Add the ability for runtime allocation and freeing of steered register list extentions that depend on the detected HW config fuses. Signed-off-by: Alan Previn Reviewed-by: Umesh Nerlige Ramappa --- drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h | 9 + .../gpu/drm/i915/gt/uc

[PATCH v12 07/13] drm/i915/guc: Update GuC-log relay function names

2022-03-17 Thread Alan Previn
For the sake of better code readibility, change previous relay logging function names with "capture_logs" to "copy_debug_logs" to differentiate from error capture functions that will use a different region of the same buffer. Signed-off-by: Alan Previn Reviewed-by: Matthew

[PATCH v12 09/13] drm/i915/guc: Check sizing of guc_capture output

2022-03-17 Thread Alan Previn
Add intel_guc_capture_output_min_size_est function to provide a reasonable minimum size for error-capture region before allocating the shared buffer. Signed-off-by: Alan Previn Reviewed-by: Matthew Brost --- .../gpu/drm/i915/gt/uc/intel_guc_capture.c| 48 +++ .../gpu/drm

[PATCH v12 00/13] Add GuC Error Capture Support

2022-03-17 Thread Alan Previn
ered registers. - Add additional checks to ensure that the GuC reported error capture information matches the i915_gpu_coredump that is being printed before we print out the corresponding VMA dumps such as the batch buffer. v2: - Ignore - failed CI retest. Alan

[PATCH v12 05/13] drm/i915/guc: Add Gen9 registers for GuC error state capture.

2022-03-17 Thread Alan Previn
Abstract out a Gen9 register list as the default for all other platforms we don't yet formally support GuC submission on. Signed-off-by: Alan Previn Reviewed-by: Umesh Nerlige Ramappa --- .../gpu/drm/i915/gt/uc/intel_guc_capture.c| 82 +-- 1 file changed, 59 inser

[PATCH v12 08/13] drm/i915/guc: Add capture region into intel_guc_log

2022-03-17 Thread Alan Previn
e the io_sys_map wrapper functions to access the various GuC log buffer regions. Signed-off-by: Alan Previn Reviewed-by: Matthew Brost --- drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 59 +- drivers/gpu/drm/i915/gt/uc/intel_guc_log.h | 3 +- 2 files changed, 37 insertions(+

[PATCH v12 06/13] drm/i915/guc: Add GuC's error state capture output structures.

2022-03-17 Thread Alan Previn
Add GuC's error capture output structures and definitions as how they would appear in GuC log buffer's error capture subregion after an error state capture G2H event notification. Signed-off-by: Alan Previn Reviewed-by: Matthew Brost --- drivers/gpu/drm/i915/gt/uc/guc_capture_f

[PATCH v12 04/13] drm/i915/guc: Add DG2 registers for GuC error state capture.

2022-03-17 Thread Alan Previn
Add additional DG2 registers for GuC error state capture. Signed-off-by: Alan Previn Reviewed-by: Umesh Nerlige Ramappa --- .../gpu/drm/i915/gt/uc/intel_guc_capture.c| 80 ++- 1 file changed, 77 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/uc

[PATCH v12 01/13] drm/i915/guc: Update GuC ADS size for error capture lists

2022-03-17 Thread Alan Previn
le of register lists to layout the framework before adding real registers in subsequent patch. This static register tables are a different format from the ADS populated list. Signed-off-by: Alan Previn Reviewed-by: Matthew Brost --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gp

[PATCH v13 00/13] Add GuC Error Capture Support

2022-03-21 Thread Alan Previn
hen reporting extended steered registers. - Add additional checks to ensure that the GuC reported error capture information matches the i915_gpu_coredump that is being printed before we print out the corresponding VMA dumps such as the batch buffer. v2: - Ignore

[PATCH v13 05/13] drm/i915/guc: Add Gen9 registers for GuC error state capture.

2022-03-21 Thread Alan Previn
Abstract out a Gen9 register list as the default for all other platforms we don't yet formally support GuC submission on. Signed-off-by: Alan Previn Reviewed-by: Umesh Nerlige Ramappa --- .../gpu/drm/i915/gt/uc/intel_guc_capture.c| 82 +-- 1 file changed, 59 inser

[PATCH v13 11/13] drm/i915/guc: Pre-allocate output nodes for extraction

2022-03-21 Thread Alan Previn
in the midst of a reset. That said, we can never dynamically allocate the output nodes in this handler. Thus, we shall pre-allocate a fixed number of empty nodes up front (at the time of ADS registration) that we can consume from or return to an internal cached list of nodes. Signed-off-by: Alan Pr

[PATCH v13 02/13] drm/i915/guc: Add XE_LP static registers for GuC error capture.

2022-03-21 Thread Alan Previn
Add device specific tables and register lists to cover different engines class types for GuC error state capture for XE_LP products. Signed-off-by: Alan Previn Reviewed-by: Umesh Nerlige Ramappa --- .../gpu/drm/i915/gt/uc/intel_guc_capture.c| 112 ++ drivers/gpu/drm/i915/gt

[PATCH v13 04/13] drm/i915/guc: Add DG2 registers for GuC error state capture.

2022-03-21 Thread Alan Previn
Add additional DG2 registers for GuC error state capture. Signed-off-by: Alan Previn Reviewed-by: Umesh Nerlige Ramappa --- .../gpu/drm/i915/gt/uc/intel_guc_capture.c| 80 ++- 1 file changed, 77 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/uc

[PATCH v13 03/13] drm/i915/guc: Add XE_LP steered register lists support

2022-03-21 Thread Alan Previn
Add the ability for runtime allocation and freeing of steered register list extentions that depend on the detected HW config fuses. Signed-off-by: Alan Previn Reviewed-by: Umesh Nerlige Ramappa --- drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h | 9 + .../gpu/drm/i915/gt/uc

[PATCH v13 07/13] drm/i915/guc: Update GuC-log relay function names

2022-03-21 Thread Alan Previn
For the sake of better code readibility, change previous relay logging function names with "capture_logs" to "copy_debug_logs" to differentiate from error capture functions that will use a different region of the same buffer. Signed-off-by: Alan Previn Reviewed-by: Matthew

[PATCH v13 06/13] drm/i915/guc: Add GuC's error state capture output structures.

2022-03-21 Thread Alan Previn
Add GuC's error capture output structures and definitions as how they would appear in GuC log buffer's error capture subregion after an error state capture G2H event notification. Signed-off-by: Alan Previn Reviewed-by: Matthew Brost --- drivers/gpu/drm/i915/gt/uc/guc_capture_f

[PATCH v13 01/13] drm/i915/guc: Update GuC ADS size for error capture lists

2022-03-21 Thread Alan Previn
le of register lists to layout the framework before adding real registers in subsequent patch. This static register tables are a different format from the ADS populated list. Signed-off-by: Alan Previn Reviewed-by: Matthew Brost --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gp

[PATCH v13 09/13] drm/i915/guc: Check sizing of guc_capture output

2022-03-21 Thread Alan Previn
Add intel_guc_capture_output_min_size_est function to provide a reasonable minimum size for error-capture region before allocating the shared buffer. Signed-off-by: Alan Previn Reviewed-by: Matthew Brost --- .../gpu/drm/i915/gt/uc/intel_guc_capture.c| 48 +++ .../gpu/drm

[PATCH v13 13/13] drm/i915/guc: Print the GuC error capture output register list.

2022-03-21 Thread Alan Previn
e 'engine-capture-group-output' vs a copy of that same info taken during i915_gpu_coredump. If they match, then print those vma's as well (such as the batch buffers). NOTE: the output format was verified using the gem_exec_capture IGT test. Signed-off-by: Alan Previn Reviewed-by

[PATCH v13 08/13] drm/i915/guc: Add capture region into intel_guc_log

2022-03-21 Thread Alan Previn
e the io_sys_map wrapper functions to access the various GuC log buffer regions. Signed-off-by: Alan Previn Reviewed-by: Matthew Brost --- drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 59 +- drivers/gpu/drm/i915/gt/uc/intel_guc_log.h | 3 +- 2 files changed, 37 insertions(+

[PATCH v13 12/13] drm/i915/guc: Plumb GuC-capture into gpu_coredump

2022-03-21 Thread Alan Previn
triggered the reset. For now, introduce an empty printing function that can filled in on a subsequent patch just to handle formatting. Signed-off-by: Alan Previn Reviewed-by: Umesh Nerlige Ramappa --- .../drm/i915/gt/intel_execlists_submission.c | 4 +- drivers/gpu/drm/i915/gt/intel_reset.c

[PATCH v13 10/13] drm/i915/guc: Extract GuC error capture lists on G2H notification.

2022-03-21 Thread Alan Previn
as independent ring buffers. Each guc-log subregion (general-logs, crash-dump and error- capture) has it's own guc_log_buffer_state that contain independent read and write pointers. Signed-off-by: Alan Previn Reviewed-by: Umesh Nerlige Ramappa --- .../gpu/drm/i915/gt/uc/abi/guc_

[PATCH 0/1] Fix i915 error_state_read ptr use

2022-02-25 Thread Alan Previn
Fix pointer offset usage in error_state_read when there is no i915_gpu_coredump but buf offset is non-zero. Alan Previn (1): drm/i915/reset: Fix error_state_read ptr + offset use drivers/gpu/drm/i915/i915_sysfs.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) -- 2.25.1

[PATCH v6 00/13] Add GuC Error Capture Support

2022-02-25 Thread Alan Previn
out the corresponding VMA dumps such as the batch buffer. v2: - Ignore - failed CI retest. Alan Previn (13): drm/i915/guc: Update GuC ADS size for error capture lists drm/i915/guc: Add XE_LP static registers for GuC error capture. drm/i915/guc: Add XE_LP steered register

[PATCH v2 0/1] Fix i915 error_state_read ptr use

2022-02-25 Thread Alan Previn
Fix pointer offset usage in error_state_read when there is no i915_gpu_coredump but buf offset is non-zero. This is the 2nd rev of this series. Changes from prior revs: v2: - Fix build issue: uninitialized var Reported-by: kernel test robot Alan Previn (1): drm/i915/reset: Fix

[PATCH v7 00/13] Add GuC Error Capture Support

2022-02-26 Thread Alan Previn
such as the batch buffer. v2: - Ignore - failed CI retest. Alan Previn (13): drm/i915/guc: Update GuC ADS size for error capture lists drm/i915/guc: Add XE_LP static registers for GuC error capture. drm/i915/guc: Add XE_LP steered register lists support drm/i915/guc: Add DG2 registers

[PATCH v10 00/17] drm/i915: Introduce Intel PXP

2021-09-17 Thread Alan Previn
_PXP off - Patch #11 - increase timeout when waiting in intel_pxp_start as firmware session startup is slower right after boot. Tested with: https://patchwork.freedesktop.org/series/87570/ Cc: Gaurav Kumar Cc: Chris Wilson Cc: Rodrigo Vivi Cc: Joonas Lahtinen Cc: Juston Li Cc: Alan Previn Cc: L

[PATCH i-g-t v11 00/15] Introduce PXP Test

2021-09-17 Thread Alan Previn
1. verify that buffer sharing works across testing pxp context. 2. verify teardown bans contexts via DRM_IOCTL_I915_GET_RESET_STAT. 3. verify display plane decryption of protected buffers. Alan Previn (14): Add PXP UAPI support in i915_drm.h Add basic PXP testin

[PATCH v11 00/17] drm/i915: Introduce Intel PXP

2021-09-21 Thread Alan Previn
v10 - Fixed checkpatch errors. Tested with: https://patchwork.freedesktop.org/series/87570/ Cc: Gaurav Kumar Cc: Chris Wilson Cc: Rodrigo Vivi Cc: Joonas Lahtinen Cc: Juston Li Cc: Alan Previn Cc: Lionel Landwerlin Cc: Jason Ekstrand Cc: Daniel Vetter Anshuman Gupta (2): drm/i915/pxp

[PATCH v12 00/17] drm/i915: Introduce Intel PXP

2021-09-23 Thread Alan Previn
: Needed a rebase to latest drm-tip for merging. Tested with: https://patchwork.freedesktop.org/series/87570/ Cc: Gaurav Kumar Cc: Chris Wilson Cc: Rodrigo Vivi Cc: Joonas Lahtinen Cc: Juston Li Cc: Alan Previn Cc: Lionel Landwerlin Cc: Jason Ekstrand Cc: Daniel Vetter Anshuman Gupta (2): drm

[PATCH v13 00/17] drm/i915: Introduce Intel PXP

2021-09-24 Thread Alan Previn
Kumar Cc: Chris Wilson Cc: Rodrigo Vivi Cc: Joonas Lahtinen Cc: Juston Li Cc: Alan Previn Cc: Lionel Landwerlin Cc: Jason Ekstrand Cc: Daniel Vetter Anshuman Gupta (2): drm/i915/pxp: Add plane decryption support drm/i915/pxp: black pixels on pxp disabled Daniele Ceraolo Spurio (9): drm

[PATCH i-g-t v12 00/15] Introduce PXP Test

2021-10-04 Thread Alan Previn
3d state offsets that batchbuffer has no visibility. - Added these additional subtests: 1. verify that buffer sharing works across testing pxp context. 2. verify teardown bans contexts via DRM_IOCTL_I915_GET_RESET_STAT. 3. verify display p

[PATCH i-g-t v13 00/16] Introduce PXP Test

2021-10-05 Thread Alan Previn
ontexts via DRM_IOCTL_I915_GET_RESET_STAT. 3. verify display plane decryption of protected buffers. Alan Previn (15): i915_drm.h sync PXP default session i915_drm.h sync PXP object creation Add basic PXP testing of buffer and context alloc Perform a regular 3d copy as a

[PATCH i-g-t v15 00/15] Introduce PXP Test

2021-10-05 Thread Alan Previn
2. verify teardown bans contexts via DRM_IOCTL_I915_GET_RESET_STAT. 3. verify display plane decryption of protected buffers. Alan Previn (14): i915_drm.h sync Add basic PXP testing of buffer and context alloc Perform a regular 3d copy as a control checkpoint Add PXP att

[PATCH i-g-t 1/1] tests/i915_pxp: Use ioctl_wrapper for DRM_IOCTL_PRIME_HANDLE_TO_FD

2021-10-06 Thread Alan Previn
Replace private helper with call to ioctl_wrapper for DRM_IOCTL_PRIME_HANDLE_TO_FD. Signed-off-by: Alan Previn --- tests/i915/gem_pxp.c | 20 +--- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/tests/i915/gem_pxp.c b/tests/i915/gem_pxp.c index 79040165..0430f4b8

[PATCH 0/7] Add GuC Error Capture Support

2022-01-18 Thread Alan Previn
ing extended steered registers. - Add additional checks to ensure that the GuC reported error capture information matches the i915_gpu_coredump that is being printed before we print out the corresponding VMA dumps such as the batch buffer. v2: - Ignore - failed CI ret

[PATCH v5 00/10] Add GuC Error Capture Support

2022-01-26 Thread Alan Previn
registers. - Add additional checks to ensure that the GuC reported error capture information matches the i915_gpu_coredump that is being printed before we print out the corresponding VMA dumps such as the batch buffer. v2: - Ignore - failed CI retest. Alan Previn

[RFC 0/7] Add GuC Error Capture Support

2021-11-22 Thread Alan Previn
circular buffer store to copy snapshots of new GuC reported error-state-capture dumps in response to the G2H notification. 6. Connects the i915_gpu_coredump reporting function to the GuC error capture module to print all GuC error state capture dumps that is reported. Alan Previn

[RFC v3 0/7] Add GuC Error Capture Support

2022-01-11 Thread Alan Previn
additional checks to ensure that the GuC reported error capture information matches the i915_gpu_coredump that is being printed before we print out the corresponding VMA dumps such as the batch buffer. v2: - Ignore - failed CI retest. Alan Previn (6): drm/i915/guc:

[PATCH 0/1] Remove unnecessary GuC err capture noise

2022-05-06 Thread Alan Previn
This series remove unnecessary GuC err capture noise. Alan Previn (1): drm/i915/guc: Remove unnecessary GuC err capture noise .../gpu/drm/i915/gt/uc/intel_guc_capture.c| 77 +-- 1 file changed, 2 insertions(+), 75 deletions(-) -- 2.25.1

[PATCH 1/1] drm/i915/guc: Remove unnecessary GuC err capture noise

2022-05-06 Thread Alan Previn
GuC error capture blurts some debug messages about empty register lists for certain register types on engines during firmware initialization. These are not errors or warnings, so get rid of them. Signed-off-by: Alan Previn --- .../gpu/drm/i915/gt/uc/intel_guc_capture.c| 77

[PATCH] drm/i915/pxp: limit drm-errors or warnings on firmware API failures

2023-02-02 Thread Alan Previn
debugging. Signed-off-by: Alan Previn --- .../i915/pxp/intel_pxp_cmd_interface_cmn.h| 3 ++ drivers/gpu/drm/i915/pxp/intel_pxp_session.c | 2 +- drivers/gpu/drm/i915/pxp/intel_pxp_tee.c | 52 ++- 3 files changed, 44 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/dr

[PATCH] drm/i915/pxp: limit drm-errors or warning on firmware API failures

2023-02-03 Thread Alan Previn
a drm_debug) or else cusomer apps that really needs to know that content protection failed won't be aware of it. Fixes: b762787bf767 ("drm/i915/pxp: Use drm_dbg if arb session failed due to fw version") Signed-off-by: Alan Previn --- .../i915/pxp/intel_pxp_cmd_interface_cmn.h

[PATCH v4 0/8] drm/i915/pxp: Add MTL PXP Support

2023-02-09 Thread Alan Previn
urces during gsccs-fini - on Patch#5: add dispatching of arb session termination firmware cmd during session teardown (as per latest upstream flows) Alan Previn (8): drm/i915/pxp: Add GSC-CS back-end resource init and cleanup drm/i915/pxp: Add MTL hw-plumbing enabling

[PATCH v4 1/8] drm/i915/pxp: Add GSC-CS back-end resource init and cleanup

2023-02-09 Thread Alan Previn
#x27; send-message function. Do this one time allocation of gsccs specific resources in a new gsccs source file with intel_pxp_gsccs_init / fini functions and hook them up from the PXP front-end. Signed-off-by: Alan Previn Reviewed-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/Makefile

[PATCH v4 2/8] drm/i915/pxp: Add MTL hw-plumbing enabling for KCR operation

2023-02-09 Thread Alan Previn
header file for PXP to be consistent with other i915 global subsystems. Signed-off-by: Alan Previn Reviewed-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/gt/intel_gt_irq.c | 3 +- drivers/gpu/drm/i915/pxp/intel_pxp.c | 32 drivers/gpu/drm/i915/pxp/intel_pxp

[PATCH v4 8/8] drm/i915/pxp: Enable PXP with MTL-GSC-CS

2023-02-09 Thread Alan Previn
Enable PXP with MTL-GSC-CS: add the has_pxp into device info and increase the timeouts for new GSC-CS + firmware specs. Signed-off-by: Alan Previn --- drivers/gpu/drm/i915/i915_pci.c | 1 + drivers/gpu/drm/i915/pxp/intel_pxp_session.c | 2 +- 2 files changed, 2 insertions(+), 1

[PATCH v4 4/8] drm/i915/pxp: Add GSC-CS backend to send GSC fw messages

2023-02-09 Thread Alan Previn
freeing of these buffers in gsccs init and fini. Signed-off-by: Alan Previn --- .../drm/i915/pxp/intel_pxp_cmd_interface_43.h | 4 + drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.c| 223 +- drivers/gpu/drm/i915/pxp/intel_pxp_types.h| 7 + 3 files changed, 232 insertions(+), 2

[PATCH v4 6/8] drm/i915/pxp: MTL-KCR interrupt ctrl's are in GT-0

2023-02-09 Thread Alan Previn
e for uncore when touching IRQ registers despite the pxp->ctrl_gt being the media-tile. No difference for legacy of course. Signed-off-by: Alan Previn --- drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c | 2 +- drivers/gpu/drm/i915/pxp/intel_pxp_irq.c | 24 +--- drivers/gpu/

[PATCH v4 7/8] drm/i915/pxp: On MTL, KCR enabling doesn't wait on tee component

2023-02-09 Thread Alan Previn
27;s init, fini and resume. Signed-off-by: Alan Previn --- drivers/gpu/drm/i915/pxp/intel_pxp.c| 19 +++ drivers/gpu/drm/i915/pxp/intel_pxp_pm.c | 3 ++- 2 files changed, 17 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp.c b/drivers/g

[PATCH v4 3/8] drm/i915/pxp: Add MTL helpers to submit Heci-Cmd-Packet to GSC

2023-02-09 Thread Alan Previn
example, requiring a retry). Signed-off-by: Alan Previn --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/gt/intel_gpu_commands.h | 2 + .../i915/gt/uc/intel_gsc_uc_heci_cmd_submit.c | 110 ++ .../i915/gt/uc/intel_gsc_uc_heci_cmd_submit.h | 76 +

[PATCH v4 5/8] drm/i915/pxp: Add ARB session creation and cleanup

2023-02-09 Thread Alan Previn
7;s pending-bit which means the GSC firmware is busy and we should resubmit. Signed-off-by: Alan Previn --- drivers/gpu/drm/i915/pxp/intel_pxp.c | 9 +- .../drm/i915/pxp/intel_pxp_cmd_interface_43.h | 21 + drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.c| 92 +++ drivers/g

[PATCH v5 0/8] drm/i915/pxp: Add MTL PXP Support

2023-02-14 Thread Alan Previn
urces during gsccs-fini - on Patch#5: add dispatching of arb session termination firmware cmd during session teardown (as per latest upstream flows) v4 : - Added proper initialization and cleanup of host-session-handle that the gsc firmware expects.

[PATCH v5 2/8] drm/i915/pxp: Add MTL hw-plumbing enabling for KCR operation

2023-02-14 Thread Alan Previn
header file for PXP to be consistent with other i915 global subsystems. Signed-off-by: Alan Previn Reviewed-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/gt/intel_gt_irq.c | 3 +- drivers/gpu/drm/i915/pxp/intel_pxp.c | 32 drivers/gpu/drm/i915/pxp/intel_pxp

[PATCH v5 7/8] drm/i915/pxp: On MTL, KCR enabling doesn't wait on tee component

2023-02-14 Thread Alan Previn
27;s init, fini and resume. Signed-off-by: Alan Previn --- drivers/gpu/drm/i915/pxp/intel_pxp.c| 19 +++ drivers/gpu/drm/i915/pxp/intel_pxp_pm.c | 3 ++- 2 files changed, 17 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp.c b/drivers/g

[PATCH v5 5/8] drm/i915/pxp: Add ARB session creation and cleanup

2023-02-14 Thread Alan Previn
7;s pending-bit which means the GSC firmware is busy and we should resubmit. Signed-off-by: Alan Previn --- drivers/gpu/drm/i915/pxp/intel_pxp.c | 9 +- .../drm/i915/pxp/intel_pxp_cmd_interface_43.h | 21 + drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.c| 92 +++ drivers/g

[PATCH v5 4/8] drm/i915/pxp: Add GSC-CS backend to send GSC fw messages

2023-02-14 Thread Alan Previn
freeing of these buffers in gsccs init and fini. Signed-off-by: Alan Previn --- .../drm/i915/pxp/intel_pxp_cmd_interface_43.h | 4 + drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.c| 224 +- drivers/gpu/drm/i915/pxp/intel_pxp_types.h| 6 + 3 files changed, 232 insertions(+), 2

[PATCH v5 6/8] drm/i915/pxp: MTL-KCR interrupt ctrl's are in GT-0

2023-02-14 Thread Alan Previn
e for uncore when touching IRQ registers despite the pxp->ctrl_gt being the media-tile. No difference for legacy of course. Signed-off-by: Alan Previn --- drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c | 2 +- drivers/gpu/drm/i915/pxp/intel_pxp_irq.c | 24 +--- drivers/gpu/

[PATCH v5 3/8] drm/i915/pxp: Add MTL helpers to submit Heci-Cmd-Packet to GSC

2023-02-14 Thread Alan Previn
example, requiring a retry). Signed-off-by: Alan Previn --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/gt/intel_gpu_commands.h | 2 + .../i915/gt/uc/intel_gsc_uc_heci_cmd_submit.c | 108 ++ .../i915/gt/uc/intel_gsc_uc_heci_cmd_submit.h | 76 +

[PATCH v5 8/8] drm/i915/pxp: Enable PXP with MTL-GSC-CS

2023-02-14 Thread Alan Previn
Enable PXP with MTL-GSC-CS: add the has_pxp into device info and increase the timeouts for new GSC-CS + firmware specs. Signed-off-by: Alan Previn --- drivers/gpu/drm/i915/i915_pci.c | 1 + drivers/gpu/drm/i915/pxp/intel_pxp_session.c | 2 +- 2 files changed, 2 insertions(+), 1

[PATCH v5 1/8] drm/i915/pxp: Add GSC-CS back-end resource init and cleanup

2023-02-14 Thread Alan Previn
#x27; send-message function. Do this one time allocation of gsccs specific resources in a new gsccs source file with intel_pxp_gsccs_init / fini functions and hook them up from the PXP front-end. Signed-off-by: Alan Previn Reviewed-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/Makefile

[PATCH] drm/i915/gsc: Fix the Driver-FLR completion

2023-02-22 Thread Alan Previn
and new code comments for detail. This is new direction from HW architecture folks. v2: - Add error message for the teardown timeout (Anshuman) - Don't duplicate code in comments (Jani) Signed-off-by: Alan Previn Fixes: 5a44fcd73498 ("drm/i915/gsc: Do a driver-FLR on unload if GS

[PATCH] drm/i915/gsc: Fix the Driver-FLR completion

2023-02-23 Thread Alan Previn
g unload, its so the uncore doesn't complain. Signed-off-by: Alan Previn Fixes: 5a44fcd73498 ("drm/i915/gsc: Do a driver-FLR on unload if GSC was loaded") --- drivers/gpu/drm/i915/intel_uncore.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-

[PATCH] drm/i915/gsc: Fix the Driver-FLR completion

2023-02-23 Thread Alan Previn
- Bit 31 of GU_CNTL should be DRIVERFLR instead of DRIVERFLR_STATUS (Daniele). Signed-off-by: Alan Previn Tested-by: Vinay Belgaumkar Reviewed-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/intel_uncore.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-)

[PATCH v6 1/8] drm/i915/pxp: Add GSC-CS back-end resource init and cleanup

2023-02-27 Thread Alan Previn
#x27; send-message function. Do this one time allocation of gsccs specific resources in a new gsccs source file with intel_pxp_gsccs_init / fini functions and hook them up from the PXP front-end. Signed-off-by: Alan Previn Reviewed-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/Makefile

[PATCH v6 0/8] drm/i915/pxp: Add MTL PXP Support

2023-02-27 Thread Alan Previn
we need a single handle that is already initialized during execution_resource init in Patch #4. - In Patch #8, increase the wait timeout for termination to align with the same SLA. Alan Previn (8): drm/i915/pxp: Add GSC-CS back-end resource init and cleanup drm/i915/pxp: Ad

[PATCH v6 6/8] drm/i915/pxp: MTL-KCR interrupt ctrl's are in GT-0

2023-02-27 Thread Alan Previn
e for uncore when touching IRQ registers despite the pxp->ctrl_gt being the media-tile. No difference for legacy of course. Signed-off-by: Alan Previn --- drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c | 2 +- drivers/gpu/drm/i915/pxp/intel_pxp_irq.c | 24 +--- drivers/gpu/

[PATCH v6 5/8] drm/i915/pxp: Add ARB session creation and cleanup

2023-02-27 Thread Alan Previn
7;s pending-bit which means the GSC firmware is busy and we should resubmit. Signed-off-by: Alan Previn --- drivers/gpu/drm/i915/pxp/intel_pxp.c | 34 -- .../drm/i915/pxp/intel_pxp_cmd_interface_43.h | 21 +++ drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.c| 62 +

[PATCH v6 2/8] drm/i915/pxp: Add MTL hw-plumbing enabling for KCR operation

2023-02-27 Thread Alan Previn
header file for PXP to be consistent with other i915 global subsystems. Signed-off-by: Alan Previn Reviewed-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/gt/intel_gt_irq.c | 3 +- drivers/gpu/drm/i915/pxp/intel_pxp.c | 32 drivers/gpu/drm/i915/pxp/intel_pxp

[PATCH v6 3/8] drm/i915/pxp: Add MTL helpers to submit Heci-Cmd-Packet to GSC

2023-02-27 Thread Alan Previn
example, requiring a retry). Signed-off-by: Alan Previn --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/gt/intel_gpu_commands.h | 2 + .../i915/gt/uc/intel_gsc_uc_heci_cmd_submit.c | 108 ++ .../i915/gt/uc/intel_gsc_uc_heci_cmd_submit.h | 76 +

[PATCH v6 8/8] drm/i915/pxp: Enable PXP with MTL-GSC-CS

2023-02-27 Thread Alan Previn
Enable PXP with MTL-GSC-CS: add the has_pxp into device info and increase the debugfs teardown timeouts to align with new GSC-CS + firmware specs. Signed-off-by: Alan Previn --- drivers/gpu/drm/i915/i915_pci.c | 1 + drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c | 9

[PATCH v6 7/8] drm/i915/pxp: On MTL, KCR enabling doesn't wait on tee component

2023-02-27 Thread Alan Previn
27;s init, fini and resume. Signed-off-by: Alan Previn --- drivers/gpu/drm/i915/pxp/intel_pxp.c| 19 +++ drivers/gpu/drm/i915/pxp/intel_pxp_pm.c | 3 ++- 2 files changed, 17 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp.c b/drivers/g

[PATCH v6 4/8] drm/i915/pxp: Add GSC-CS backend to send GSC fw messages

2023-02-27 Thread Alan Previn
-off-by: Alan Previn --- .../drm/i915/pxp/intel_pxp_cmd_interface_43.h | 4 + drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.c| 239 +- drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.h| 4 + drivers/gpu/drm/i915/pxp/intel_pxp_types.h| 6 + 4 files changed, 251 insertions(+), 2

[PATCH v2 1/9] drm/i915/pxp: Add MTL PXP GSC-CS back-end skeleton

2023-01-11 Thread Alan Previn
Add MTL PXP GSC-CS back-end stub functions hook them up from PXP front-end and PXP session management functions. Signed-off-by: Alan Previn --- drivers/gpu/drm/i915/Makefile| 1 + drivers/gpu/drm/i915/pxp/intel_pxp.c | 19 +++-- drivers/gpu/drm/i915/pxp

[PATCH v2 2/9] drm/i915/pxp: Add GSC-CS back-end resource init and cleanup

2023-01-11 Thread Alan Previn
time allocation of resources in GSC-CS init and clean them up in fini. Signed-off-by: Alan Previn --- .../drm/i915/pxp/intel_pxp_cmd_interface_43.h | 6 +- drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.c| 216 +- drivers/gpu/drm/i915/pxp/intel_pxp_types.h| 5 + 3 files changed

[PATCH v2 0/9] drm/i915/pxp: Add MTL PXP Support

2023-01-11 Thread Alan Previn
when building with CONFIG_PXP disabled. - more alignment with gsc_mtl_header structure from the HDCP Alan Previn (9): drm/i915/pxp: Add MTL PXP GSC-CS back-end skeleton drm/i915/pxp: Add GSC-CS back-end resource init and cleanup drm/i915/pxp: Add MTL hw-plumbing enabling for KCR operation

[PATCH v2 7/9] drm/i915/pxp: MTL-KCR interrupt ctrl's are in GT-0

2023-01-11 Thread Alan Previn
e for uncore when touching IRQ registers despite the pxp->ctrl_gt being the media-tile. No difference for legacy of course. Signed-off-by: Alan Previn --- drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c | 2 +- drivers/gpu/drm/i915/pxp/intel_pxp_irq.c | 23 +--- drivers/gpu/

[PATCH v2 5/9] drm/i915/pxp: Add GSC-CS backend to send GSC fw messages

2023-01-11 Thread Alan Previn
: Alan Previn --- drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.c | 93 ++ 1 file changed, 93 insertions(+) diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.c b/drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.c index 97ca187e6fde..ff235822743e 100644 --- a/drivers/gpu/drm/i915/pxp

[PATCH v2 8/9] drm/i915/pxp: On MTL, KCR enabling doesn't wait on tee component

2023-01-11 Thread Alan Previn
W on PXP's init, fini and resume. Signed-off-by: Alan Previn --- drivers/gpu/drm/i915/pxp/intel_pxp.c | 52 ++-- drivers/gpu/drm/i915/pxp/intel_pxp.h | 4 +- drivers/gpu/drm/i915/pxp/intel_pxp_pm.c | 10 ++--- drivers/gpu/drm/i915/pxp/intel_pxp_tee.c | 13

[PATCH v2 6/9] drm/i915/pxp: Add ARB session creation with new PXP API Ver4.3

2023-01-11 Thread Alan Previn
Add MTL's function for ARB session creation using PXP firmware version 4.3 ABI structure format. Before checking the return status, look at the GSC-CS-Mem-Header's pending-bit which means the GSC firmware is busy and we should resubmit. Signed-off-by: Alan Previn --- .../dr

[PATCH v2 4/9] drm/i915/pxp: Add MTL helpers to submit Heci-Cmd-Packet to GSC

2023-01-11 Thread Alan Previn
to handle everything else from input/output packet size verification to handling the responses from security firmware (such as requiring a retry). Signed-off-by: Alan Previn --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/gt/intel_gpu_comma

[PATCH v2 9/9] drm/i915/pxp: Enable PXP with MTL-GSC-CS

2023-01-11 Thread Alan Previn
Enable PXP with MTL-GSC-CS: add the has_pxp into device info and increase the timeouts for new GSC-CS + firmware specs. Signed-off-by: Alan Previn --- drivers/gpu/drm/i915/i915_pci.c | 1 + drivers/gpu/drm/i915/pxp/intel_pxp_session.c | 2 +- 2 files changed, 2 insertions(+), 1

[PATCH v2 3/9] drm/i915/pxp: Add MTL hw-plumbing enabling for KCR operation

2023-01-11 Thread Alan Previn
header file for PXP to be consistent with other i915 global subsystems. Signed-off-by: Alan Previn --- drivers/gpu/drm/i915/gt/intel_gt_irq.c | 3 +- drivers/gpu/drm/i915/pxp/intel_pxp.c | 35 drivers/gpu/drm/i915/pxp/intel_pxp_regs.h| 26 +++

[PATCH v4 0/6] drm/i915/pxp: Add missing cleanup steps for PXP global-teardown

2023-01-11 Thread Alan Previn
series to successfully pass testing when PXP config is enabled. v3: - Added fix for mei patch when CONFIG_PM_SLEEP is off (reported by kernel test robot ). Alan Previn (3): drm/i915/pxp: Invalidate all PXP fw sessions during teardown drm/i915/pxp: Trigger the global teard

[PATCH v4 1/6] mei: mei-me: resume device in prepare

2023-01-11 Thread Alan Previn
callbacks. Signed-off-by: Alexander Usyskin Signed-off-by: Alan Previn --- drivers/misc/mei/pci-me.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/drivers/misc/mei/pci-me.c b/drivers/misc/mei/pci-me.c index 704cd0caa172..4280759739f0 100644 --- a/drivers

[PATCH v4 2/6] drm/i915/pxp: add device link between i915 and mei_pxp

2023-01-11 Thread Alan Previn
From: Alexander Usyskin Add device link with i915 as consumer and mei_pxp as supplier to ensure proper ordering of power flows. V2: condition on absence of heci_pxp to filter out DG Signed-off-by: Alexander Usyskin Signed-off-by: Alan Previn --- drivers/gpu/drm/i915/pxp/intel_pxp_tee.c | 7

[PATCH v4 3/6] mei: clean pending read with vtag on bus

2023-01-11 Thread Alan Previn
: Alan Previn --- drivers/misc/mei/client.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/misc/mei/client.c b/drivers/misc/mei/client.c index 9ddb854b8155..5c19097266fe 100644 --- a/drivers/misc/mei/client.c +++ b/drivers/misc/mei/client.c @@ -1343,7 +1343,9 @@ static

[PATCH v4 4/6] drm/i915/pxp: Invalidate all PXP fw sessions during teardown

2023-01-11 Thread Alan Previn
or each of them. However, for the upstream i915 driver we only support the arbitration session that can be created so that will be the only session we will cleanup. Signed-off-by: Alan Previn Reviewed-by: Juston Li --- drivers/gpu/drm/i915/pxp/intel_pxp.h | 1 + .../dr

  1   2   3   4   5   6   >