Re: [PATCH v5 0/10] Touch Bar support for T2 Macs

2024-08-31 Thread Aditya Garg
Hi Maintainers It has been 2 weeks but I still haven't received a single reply on this version of the patch series. Consider this email as a friendly reminder. > On 17 Aug 2024, at 5:15 PM, Aditya Garg wrote: > > Hi Maintainers > > The Touch Bars found on x86

[PATCH] drm/format-helper: Add conversion from XRGB8888 to BGR888

2024-07-07 Thread Aditya Garg
From: Kerem Karabay Add XRGB emulation helper for devices that only support BGR888. Signed-off-by: Kerem Karabay Signed-off-by: Aditya Garg --- drivers/gpu/drm/drm_format_helper.c | 54 + .../gpu/drm/tests/drm_format_helper_test.c| 81

Re: [PATCH] drm/format-helper: Add conversion from XRGB8888 to BGR888

2024-07-08 Thread Aditya Garg
rds > Thomas > >> >> >>> Best regards >>> Thomas >>> >>>> Signed-off-by: Kerem Karabay >>>> Signed-off-by: Aditya Garg >>>> --- >>>> drivers/gpu/drm/drm_format_helper.c | 54 +++

Re: [PATCH] drm/format-helper: Add conversion from XRGB8888 to BGR888

2024-07-08 Thread Aditya Garg
> On 8 Jul 2024, at 1:59 PM, Thomas Zimmermann wrote: > > Hi > >> Am 08.07.24 um 10:10 schrieb Aditya Garg: >> Hi >>> I see. Best would be to submit this patch together with the driver for >>> review. >>> >> Although it’s your

Re: [PATCH] drm/format-helper: Add conversion from XRGB8888 to BGR888

2024-07-08 Thread Aditya Garg
> On 8 Jul 2024, at 1:00 PM, Thomas Zimmermann wrote: > > Hi > > Am 05.07.24 um 13:38 schrieb Aditya Garg: >> From: Kerem Karabay >> >> Add XRGB emulation helper for devices that only support BGR888. > > Nothing wrong with that, but it needs a ca

Re: [PATCH] drm/format-helper: Add conversion from XRGB8888 to BGR888

2024-07-09 Thread Aditya Garg
inux.git/commit/drivers/gpu/drm/drm_format_helper.c?h=v6.10-rc7&id=175073d694cd9db4c4ca97c978a447acc6b5cb33 My apologies if I am wrong somewhere. From: Thomas Zimmermann Sent: 08 July 2024 13:00 To: Aditya Garg; maarten.lankho...@linux.intel.com; mrip..

[PATCH 9/9] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2024-08-06 Thread Aditya Garg
Karabay Signed-off-by: Aditya Garg --- MAINTAINERS | 6 + drivers/gpu/drm/tiny/Kconfig | 12 + drivers/gpu/drm/tiny/Makefile | 1 + drivers/gpu/drm/tiny/appletbdrm.c | 624 ++ 4 files changed, 643 insertions(+) create mode 100644

[PATCH 4/9] HID: multitouch: support getting the tip state from HID_DG_TOUCH fields

2024-08-06 Thread Aditya Garg
ned-off-by: Kerem Karabay Signed-off-by: Aditya Garg --- drivers/hid/hid-multitouch.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index 3e92789ed..571435da5 100644 --- a/drivers/hid/hid-multitou

[PATCH 5/9] HID: multitouch: take cls->maxcontacts into account for devices without a HID_DG_CONTACTMAX field too

2024-08-06 Thread Aditya Garg
From: Kerem Karabay This is needed for Apple Touch Bars, where no HID_DG_CONTACTMAX field is present and the maximum contact count is greater than the default. Signed-off-by: Kerem Karabay Signed-off-by: Aditya Garg --- drivers/hid/hid-multitouch.c | 7 --- 1 file changed, 4 insertions

[PATCH 3/9] HID: multitouch: support getting the contact ID from HID_DG_TRANSDUCER_INDEX fields

2024-08-06 Thread Aditya Garg
From: Kerem Karabay This is needed to support Apple Touch Bars, where the contact ID is contained in fields with the HID_DG_TRANSDUCER_INDEX usage. Signed-off-by: Kerem Karabay Co-developed-by: Aditya Garg Signed-off-by: Aditya Garg --- drivers/hid/hid-multitouch.c | 5 - 1 file changed

[PATCH 0/9] Touch Bar support for T2 Macs

2024-08-06 Thread Aditya Garg
Hi Maintainers The Touch Bars found on x86 Macs support two USB configurations: one where the device presents itself as a HID keyboard and can display predefined sets of keys, and one where the operating system has full control over what is displayed. This patch series adds support for both the c

[PATCH 6/9] HID: multitouch: allow specifying if a device is direct in a class

2024-08-06 Thread Aditya Garg
-by: Aditya Garg --- drivers/hid/hid-multitouch.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index 60b675cd1..2948fbcbc 100644 --- a/drivers/hid/hid-multitouch.c +++ b/drivers/hid/hid-multitouch.c

[PATCH 1/9] HID: hid-appletb-bl: add driver for the backlight of Apple Touch Bars

2024-08-06 Thread Aditya Garg
From: Kerem Karabay This commit adds a driver for the backlight of Apple Touch Bars on x86 Macs. Note that currently only T2 Macs are supported. This driver is based on previous work done by Ronald Tschalär . Signed-off-by: Kerem Karabay Signed-off-by: Aditya Garg --- MAINTAINERS

[PATCH 8/9] drm/format-helper: add helper for BGR888 to XRGB8888 conversion

2024-08-06 Thread Aditya Garg
From: Kerem Karabay Add XRGB emulation helper for devices that only support BGR888. Signed-off-by: Kerem Karabay Signed-off-by: Aditya Garg --- drivers/gpu/drm/drm_format_helper.c | 54 + .../gpu/drm/tests/drm_format_helper_test.c| 81

[PATCH 7/9] HID: multitouch: add device ID for Apple Touch Bars

2024-08-06 Thread Aditya Garg
From: Kerem Karabay Note that this is device ID is for T2 Macs. Testing on T1 Macs would be appreciated. Signed-off-by: Kerem Karabay Signed-off-by: Aditya Garg --- drivers/hid/Kconfig | 1 + drivers/hid/hid-multitouch.c | 26 ++ 2 files changed, 23

[PATCH 2/9] HID: hid-appletb-kbd: add driver for the keyboard mode of Apple Touch Bars

2024-08-06 Thread Aditya Garg
display functionality of the first configuration. Note that currently only T2 Macs are supported. This driver is based on previous work done by Ronald Tschalär . Signed-off-by: Kerem Karabay Co-developed-by: Aditya Garg Signed-off-by: Aditya Garg --- .../ABI/testing/sysfs-driver-hid-appletb-kbd

[PATCH v2 0/9] Touch Bar support for T2 Macs

2024-08-08 Thread Aditya Garg
Hi Maintainers The Touch Bars found on x86 Macs support two USB configurations: one where the device presents itself as a HID keyboard and can display predefined sets of keys, and one where the operating system has full control over what is displayed. This patch series adds support for both the c

[PATCH v2 1/9] HID: hid-appletb-bl: add driver for the backlight of Apple Touch Bars

2024-08-08 Thread Aditya Garg
From: Kerem Karabay This commit adds a driver for the backlight of Apple Touch Bars on x86 Macs. Note that currently only T2 Macs are supported. This driver is based on previous work done by Ronald Tschalär . Signed-off-by: Kerem Karabay Co-developed-by: Aditya Garg Signed-off-by: Aditya

[PATCH v2 2/9] HID: hid-appletb-kbd: add driver for the keyboard mode of Apple Touch Bars

2024-08-08 Thread Aditya Garg
display functionality of the first configuration. Note that currently only T2 Macs are supported. This driver is based on previous work done by Ronald Tschalär . Signed-off-by: Kerem Karabay Co-developed-by: Aditya Garg Signed-off-by: Aditya Garg --- .../ABI/testing/sysfs-driver-hid-appletb-kbd

[PATCH v3 3/9] HID: multitouch: support getting the contact ID from HID_DG_TRANSDUCER_INDEX fields

2024-08-08 Thread Aditya Garg
From: Kerem Karabay This is needed to support Apple Touch Bars, where the contact ID is contained in fields with the HID_DG_TRANSDUCER_INDEX usage. Signed-off-by: Kerem Karabay Signed-off-by: Aditya Garg --- drivers/hid/hid-multitouch.c | 5 - 1 file changed, 4 insertions(+), 1 deletion

[PATCH v2 4/9] HID: multitouch: support getting the tip state from HID_DG_TOUCH fields

2024-08-08 Thread Aditya Garg
ned-off-by: Kerem Karabay Signed-off-by: Aditya Garg --- drivers/hid/hid-multitouch.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index 3e92789ed..571435da5 100644 --- a/drivers/hid/hid-multitou

[PATCH v2 5/9] HID: multitouch: take cls->maxcontacts into account for devices without a HID_DG_CONTACTMAX field too

2024-08-08 Thread Aditya Garg
From: Kerem Karabay This is needed for Apple Touch Bars, where no HID_DG_CONTACTMAX field is present and the maximum contact count is greater than the default. Signed-off-by: Kerem Karabay Signed-off-by: Aditya Garg --- drivers/hid/hid-multitouch.c | 7 --- 1 file changed, 4 insertions

[PATCH v2 6/9] HID: multitouch: allow specifying if a device is direct in a class

2024-08-08 Thread Aditya Garg
-by: Aditya Garg --- drivers/hid/hid-multitouch.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index 60b675cd1..2948fbcbc 100644 --- a/drivers/hid/hid-multitouch.c +++ b/drivers/hid/hid-multitouch.c

[PATCH v2 7/9] HID: multitouch: add device ID for Apple Touch Bars

2024-08-08 Thread Aditya Garg
From: Kerem Karabay Note that this is device ID is for T2 Macs. Testing on T1 Macs would be appreciated. Signed-off-by: Kerem Karabay Signed-off-by: Aditya Garg --- drivers/hid/Kconfig | 1 + drivers/hid/hid-multitouch.c | 26 ++ 2 files changed, 23

[PATCH v2 8/9] drm/format-helper: Add conversion from XRGB8888 to BGR888

2024-08-08 Thread Aditya Garg
From: Kerem Karabay Add XRGB emulation helper for devices that only support BGR888. Signed-off-by: Kerem Karabay Signed-off-by: Aditya Garg --- drivers/gpu/drm/drm_format_helper.c | 54 + .../gpu/drm/tests/drm_format_helper_test.c| 81

Re: [PATCH v2 0/9] Touch Bar support for T2 Macs

2024-08-08 Thread Aditya Garg
Looks like I messed up the email series, Resending. Sorry for the trouble > On 8 Aug 2024, at 5:23 PM, Aditya Garg wrote: > > Hi Maintainers > > The Touch Bars found on x86 Macs support two USB configurations: one > where the device presents itself as a HID keyboa

[PATCH RESEND v2 0/9] Touch Bar support for T2 Macs

2024-08-08 Thread Aditya Garg
Hi Maintainers The Touch Bars found on x86 Macs support two USB configurations: one where the device presents itself as a HID keyboard and can display predefined sets of keys, and one where the operating system has full control over what is displayed. This patch series adds support for both the c

[PATCH RESEND v2 1/9] HID: hid-appletb-bl: add driver for the backlight of Apple Touch Bars

2024-08-08 Thread Aditya Garg
From: Kerem Karabay This commit adds a driver for the backlight of Apple Touch Bars on x86 Macs. Note that currently only T2 Macs are supported. This driver is based on previous work done by Ronald Tschalär . Signed-off-by: Kerem Karabay Co-developed-by: Aditya Garg Signed-off-by: Aditya

[PATCH RESEND v2 2/9] HID: hid-appletb-kbd: add driver for the keyboard mode of Apple Touch Bars

2024-08-08 Thread Aditya Garg
display functionality of the first configuration. Note that currently only T2 Macs are supported. This driver is based on previous work done by Ronald Tschalär . Signed-off-by: Kerem Karabay Co-developed-by: Aditya Garg Signed-off-by: Aditya Garg --- .../ABI/testing/sysfs-driver-hid-appletb-kbd

[PATCH RESEND v2 3/9] HID: multitouch: support getting the contact ID from HID_DG_TRANSDUCER_INDEX fields

2024-08-08 Thread Aditya Garg
From: Kerem Karabay This is needed to support Apple Touch Bars, where the contact ID is contained in fields with the HID_DG_TRANSDUCER_INDEX usage. Signed-off-by: Kerem Karabay Signed-off-by: Aditya Garg --- drivers/hid/hid-multitouch.c | 5 - 1 file changed, 4 insertions(+), 1 deletion

[PATCH RESEND v2 4/9] HID: multitouch: support getting the tip state from HID_DG_TOUCH fields

2024-08-08 Thread Aditya Garg
ned-off-by: Kerem Karabay Signed-off-by: Aditya Garg --- drivers/hid/hid-multitouch.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index 3e92789ed..571435da5 100644 --- a/drivers/hid/hid-multitou

[PATCH RESEND v2 5/9] HID: multitouch: take cls->maxcontacts into account for devices without a HID_DG_CONTACTMAX field too

2024-08-08 Thread Aditya Garg
From: Kerem Karabay This is needed for Apple Touch Bars, where no HID_DG_CONTACTMAX field is present and the maximum contact count is greater than the default. Signed-off-by: Kerem Karabay Signed-off-by: Aditya Garg --- drivers/hid/hid-multitouch.c | 7 --- 1 file changed, 4 insertions

[PATCH RESEND v2 6/9] HID: multitouch: allow specifying if a device is direct in a class

2024-08-08 Thread Aditya Garg
-by: Aditya Garg --- drivers/hid/hid-multitouch.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index 60b675cd1..2948fbcbc 100644 --- a/drivers/hid/hid-multitouch.c +++ b/drivers/hid/hid-multitouch.c

[PATCH RESEND v2 7/9] HID: multitouch: add device ID for Apple Touch Bars

2024-08-08 Thread Aditya Garg
From: Kerem Karabay Note that this is device ID is for T2 Macs. Testing on T1 Macs would be appreciated. Signed-off-by: Kerem Karabay Signed-off-by: Aditya Garg --- drivers/hid/Kconfig | 1 + drivers/hid/hid-multitouch.c | 26 ++ 2 files changed, 23

[PATCH RESEND v2 8/9] drm/format-helper: Add conversion from XRGB8888 to BGR888

2024-08-08 Thread Aditya Garg
From: Kerem Karabay Add XRGB emulation helper for devices that only support BGR888. Signed-off-by: Kerem Karabay Signed-off-by: Aditya Garg --- drivers/gpu/drm/drm_format_helper.c | 54 + .../gpu/drm/tests/drm_format_helper_test.c| 81

[PATCH RESEND v2 9/9] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2024-08-08 Thread Aditya Garg
Karabay Signed-off-by: Aditya Garg --- MAINTAINERS | 6 + drivers/gpu/drm/tiny/Kconfig | 12 + drivers/gpu/drm/tiny/Makefile | 1 + drivers/gpu/drm/tiny/appletbdrm.c | 624 ++ 4 files changed, 643 insertions(+) create mode 100644

Re: [PATCH 0/9] Touch Bar support for T2 Macs

2024-08-08 Thread Aditya Garg
v2 of the patches sent here: https://lore.kernel.org/all/752d8eea-ee3b-4854-9b5e-f412afa20...@live.com/

[PATCH v3 0/9] Touch Bar support for T2 Macs

2024-08-08 Thread Aditya Garg
Hi Maintainers The Touch Bars found on x86 Macs support two USB configurations: one where the device presents itself as a HID keyboard and can display predefined sets of keys, and one where the operating system has full control over what is displayed. This patch series adds support for both the c

[PATCH v3 1/9] HID: hid-appletb-bl: add driver for the backlight of Apple Touch Bars

2024-08-08 Thread Aditya Garg
From: Kerem Karabay This commit adds a driver for the backlight of Apple Touch Bars on x86 Macs. Note that currently only T2 Macs are supported. This driver is based on previous work done by Ronald Tschalär . Signed-off-by: Kerem Karabay Co-developed-by: Aditya Garg Signed-off-by: Aditya

[PATCH v3 2/9] HID: hid-appletb-kbd: add driver for the keyboard mode

2024-08-08 Thread Aditya Garg
display functionality of the first configuration. Note that currently only T2 Macs are supported. This driver is based on previous work done by Ronald Tschalär . Signed-off-by: Kerem Karabay Co-developed-by: Aditya Garg Signed-off-by: Aditya Garg --- .../ABI/testing/sysfs-driver-hid-appletb-kbd

[PATCH v3 3/9] HID: multitouch: support getting the contact ID from HID_DG_TRANSDUCER_INDEX fields

2024-08-08 Thread Aditya Garg
From: Kerem Karabay This is needed to support Apple Touch Bars, where the contact ID is contained in fields with the HID_DG_TRANSDUCER_INDEX usage. Signed-off-by: Kerem Karabay Signed-off-by: Aditya Garg --- drivers/hid/hid-multitouch.c | 5 - 1 file changed, 4 insertions(+), 1 deletion

[PATCH v3 4/9] HID: multitouch: support getting the tip state from HID_DG_TOUCH fields

2024-08-08 Thread Aditya Garg
ned-off-by: Kerem Karabay Signed-off-by: Aditya Garg --- drivers/hid/hid-multitouch.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index 3e92789ed..571435da5 100644 --- a/drivers/hid/hid-multitou

[PATCH v3 5/9] HID: multitouch: take cls->maxcontacts into account for devices without a HID_DG_CONTACTMAX field too

2024-08-08 Thread Aditya Garg
From: Kerem Karabay This is needed for Apple Touch Bars, where no HID_DG_CONTACTMAX field is present and the maximum contact count is greater than the default. Signed-off-by: Kerem Karabay Signed-off-by: Aditya Garg --- drivers/hid/hid-multitouch.c | 7 --- 1 file changed, 4 insertions

[PATCH v3 6/9] HID: multitouch: allow specifying if a device is direct in a class

2024-08-08 Thread Aditya Garg
-by: Aditya Garg --- drivers/hid/hid-multitouch.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index 60b675cd1..2948fbcbc 100644 --- a/drivers/hid/hid-multitouch.c +++ b/drivers/hid/hid-multitouch.c

[PATCH v3 7/9] HID: multitouch: add device ID for Apple Touch Bars

2024-08-08 Thread Aditya Garg
From: Kerem Karabay Note that this is device ID is for T2 Macs. Testing on T1 Macs would be appreciated. Signed-off-by: Kerem Karabay Signed-off-by: Aditya Garg --- drivers/hid/Kconfig | 1 + drivers/hid/hid-multitouch.c | 26 ++ 2 files changed, 23

[PATCH v3 8/9] drm/format-helper: Add conversion from XRGB8888 to BGR888

2024-08-08 Thread Aditya Garg
From: Kerem Karabay Add XRGB emulation helper for devices that only support BGR888. Signed-off-by: Kerem Karabay Signed-off-by: Aditya Garg --- drivers/gpu/drm/drm_format_helper.c | 54 + .../gpu/drm/tests/drm_format_helper_test.c| 81

[PATCH v3 9/9] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2024-08-08 Thread Aditya Garg
Karabay Signed-off-by: Aditya Garg --- MAINTAINERS | 6 + drivers/gpu/drm/tiny/Kconfig | 12 + drivers/gpu/drm/tiny/Makefile | 1 + drivers/gpu/drm/tiny/appletbdrm.c | 624 ++ 4 files changed, 643 insertions(+) create mode 100644

Re: [PATCH RESEND v2 0/9] Touch Bar support for T2 Macs

2024-08-08 Thread Aditya Garg
The keyboard driver encountered a bug due to changes in v2, so fixed them in v3 here: https://lore.kernel.org/linux-input/1368fee8-58bb-41c9-b9ad-7f2f68ff1...@live.com/T/#t

[PATCH v4 0/10] Touch Bar support for T2 Macs

2024-08-10 Thread Aditya Garg
1. Added support for fn key toggle in the hid-appletb-kbd driver. Aditya Garg (1): HID: hid-appletb-kbd: add support for fn toggle between media and function mode Kerem Karabay (9): HID: hid-appletb-bl: add driver for the backlight of Apple Touch Bars HID: hid-appletb-kbd: add driv

[PATCH v4 1/10] HID: hid-appletb-bl: add driver for the backlight of Apple Touch Bars

2024-08-10 Thread Aditya Garg
From: Kerem Karabay This commit adds a driver for the backlight of Apple Touch Bars on x86 Macs. Note that currently only T2 Macs are supported. This driver is based on previous work done by Ronald Tschalär . Signed-off-by: Kerem Karabay Co-developed-by: Aditya Garg Signed-off-by: Aditya

[PATCH v4 2/10] HID: hid-appletb-kbd: add driver for the keyboard mode

2024-08-10 Thread Aditya Garg
display functionality of the first configuration. Note that currently only T2 Macs are supported. This driver is based on previous work done by Ronald Tschalär . Signed-off-by: Kerem Karabay Co-developed-by: Aditya Garg Signed-off-by: Aditya Garg --- .../ABI/testing/sysfs-driver-hid-appletb-kbd

[PATCH v4 3/10] HID: hid-appletb-kbd: add support for fn toggle between media and function mode

2024-08-10 Thread Aditya Garg
From: Aditya Garg This patch adds support for the switching between the Media and Function keys on the touchbar by pressing the Fn key on Apple Internal Keyboard. Signed-off-by: Aditya Garg --- drivers/hid/hid-appletb-kbd.c | 128 ++ 1 file changed, 128

[PATCH v4 4/10] HID: multitouch: support getting the contact ID from HID_DG_TRANSDUCER_INDEX fields

2024-08-10 Thread Aditya Garg
From: Kerem Karabay This is needed to support Apple Touch Bars, where the contact ID is contained in fields with the HID_DG_TRANSDUCER_INDEX usage. Signed-off-by: Kerem Karabay Signed-off-by: Aditya Garg --- drivers/hid/hid-multitouch.c | 5 - 1 file changed, 4 insertions(+), 1 deletion

[PATCH v4 5/10] HID: multitouch: support getting the tip state from HID_DG_TOUCH fields

2024-08-10 Thread Aditya Garg
ned-off-by: Kerem Karabay Signed-off-by: Aditya Garg --- drivers/hid/hid-multitouch.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index 3e92789ed..571435da5 100644 --- a/drivers/hid/hid-multitou

Re: [PATCH v3 0/9] Touch Bar support for T2 Macs

2024-08-10 Thread Aditya Garg
V4 with an additional patch sent here: https://lore.kernel.org/linux-input/20190cd7-46ce-400d-9c58-297984796...@live.com/T/#t

[PATCH v4 6/10] HID: multitouch: take cls->maxcontacts into account for devices without a HID_DG_CONTACTMAX field too

2024-08-10 Thread Aditya Garg
From: Kerem Karabay This is needed for Apple Touch Bars, where no HID_DG_CONTACTMAX field is present and the maximum contact count is greater than the default. Signed-off-by: Kerem Karabay Signed-off-by: Aditya Garg --- drivers/hid/hid-multitouch.c | 7 --- 1 file changed, 4 insertions

[PATCH v4 7/10] HID: multitouch: allow specifying if a device is direct in a class

2024-08-10 Thread Aditya Garg
-by: Aditya Garg --- drivers/hid/hid-multitouch.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index 60b675cd1..2948fbcbc 100644 --- a/drivers/hid/hid-multitouch.c +++ b/drivers/hid/hid-multitouch.c

[PATCH v4 8/10] HID: multitouch: add device ID for Apple Touch Bars

2024-08-10 Thread Aditya Garg
From: Kerem Karabay Note that this is device ID is for T2 Macs. Testing on T1 Macs would be appreciated. Signed-off-by: Kerem Karabay Signed-off-by: Aditya Garg --- drivers/hid/Kconfig | 1 + drivers/hid/hid-multitouch.c | 26 ++ 2 files changed, 23

[PATCH v4 9/10] drm/format-helper: Add conversion from XRGB8888 to BGR888

2024-08-10 Thread Aditya Garg
From: Kerem Karabay Add XRGB emulation helper for devices that only support BGR888. Signed-off-by: Kerem Karabay Signed-off-by: Aditya Garg --- drivers/gpu/drm/drm_format_helper.c | 54 + .../gpu/drm/tests/drm_format_helper_test.c| 81

[PATCH v4 10/10] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2024-08-10 Thread Aditya Garg
Karabay Signed-off-by: Aditya Garg --- MAINTAINERS | 6 + drivers/gpu/drm/tiny/Kconfig | 12 + drivers/gpu/drm/tiny/Makefile | 1 + drivers/gpu/drm/tiny/appletbdrm.c | 624 ++ 4 files changed, 643 insertions(+) create mode 100644

Re: [PATCH v3 1/9] HID: hid-appletb-bl: add driver for the backlight of Apple Touch Bars

2024-08-10 Thread Aditya Garg
Hi Thomas > >> diff --git a/drivers/hid/Makefile b/drivers/hid/Makefile >> index e40f1ddeb..1d825a474 100644 >> --- a/drivers/hid/Makefile >> +++ b/drivers/hid/Makefile >> @@ -29,6 +29,7 @@ obj-$(CONFIG_HID_ALPS) += hid-alps.o >> obj-$(CONFIG_HID_ACRUX) += hid-axff.o >> obj-$(CONFIG_HID_APPLE) +=

Re: [PATCH v3 1/9] HID: hid-appletb-bl: add driver for the backlight of Apple Touch Bars

2024-08-10 Thread Aditya Garg
> > Also include linux/device.h as you are using functions from there. > Like devm_kcalloc(). Alright, I’ll add that > >>> +#include +#include + +#include "hid-ids.h" + +#define APPLETB_BL_ON 1 +#define APPLETB_BL_DIM 3 +#define APPLETB_BL_OFF 4 +

Re: [PATCH v3 1/9] HID: hid-appletb-bl: add driver for the backlight of Apple Touch Bars

2024-08-10 Thread Aditya Garg
> > Sounds good. > > FYI I'll also review the other patches soonish. > So sending a v5 right away is not necessary. Alright, fair enough. You’d want to review the v4 of this patchset then, although the only difference is presence of 1 extra patch in v4. https://lore.kernel.org/linux-input/201

[PATCH v5 0/10] Touch Bar support for T2 Macs

2024-08-17 Thread Aditya Garg
1. Added support for fn key toggle in the hid-appletb-kbd driver. v5: 1. Do required changes to hid-appletb-bl as requested by upstream. Aditya Garg (1): HID: hid-appletb-kbd: add support for fn toggle between media and function mode Kerem Karabay (9): HID: hid-appletb-bl: add driv

[PATCH v5 0/10] Touch Bar support for T2 Macs

2024-08-17 Thread Aditya Garg
1. Added support for fn key toggle in the hid-appletb-kbd driver. v5: 1. Do required changes to hid-appletb-bl as requested by upstream. Aditya Garg (1): HID: hid-appletb-kbd: add support for fn toggle between media and function mode Kerem Karabay (9): HID: hid-appletb-bl: add driver for the ba

[PATCH v5 0/10] Touch Bar support for T2 Macs

2024-08-17 Thread Aditya Garg
upport for fn key toggle in the hid-appletb-kbd driver. v5: 1. Do required changes to hid-appletb-bl as requested by upstream. Aditya Garg (1): HID: hid-appletb-kbd: add support for fn toggle between media and function mode Kerem Karabay (9): HID: hid-appletb-bl: add driver for the backligh

[PATCH v5 1/10] HID: hid-appletb-bl: add driver for the backlight of Apple Touch Bars

2024-08-17 Thread Aditya Garg
From: Kerem Karabay This commit adds a driver for the backlight of Apple Touch Bars on x86 Macs. Note that currently only T2 Macs are supported. This driver is based on previous work done by Ronald Tschalär . Signed-off-by: Kerem Karabay Co-developed-by: Aditya Garg Signed-off-by: Aditya

[PATCH v5 2/10] HID: hid-appletb-kbd: add driver for the keyboard mode

2024-08-17 Thread Aditya Garg
display functionality of the first configuration. Note that currently only T2 Macs are supported. This driver is based on previous work done by Ronald Tschalär . Signed-off-by: Kerem Karabay Co-developed-by: Aditya Garg Signed-off-by: Aditya Garg --- .../ABI/testing/sysfs-driver-hid-appletb-kbd

[PATCH v5 3/10] HID: hid-appletb-kbd: add support for fn toggle between media and function mode

2024-08-17 Thread Aditya Garg
From: Aditya Garg This patch adds support for the switching between the Media and Function keys on the touchbar by pressing the Fn key on Apple Internal Keyboard. Signed-off-by: Aditya Garg --- drivers/hid/hid-appletb-kbd.c | 128 ++ 1 file changed, 128

[PATCH v5 4/10] HID: multitouch: support getting the contact ID from HID_DG_TRANSDUCER_INDEX fields

2024-08-17 Thread Aditya Garg
From: Kerem Karabay This is needed to support Apple Touch Bars, where the contact ID is contained in fields with the HID_DG_TRANSDUCER_INDEX usage. Signed-off-by: Kerem Karabay Signed-off-by: Aditya Garg --- drivers/hid/hid-multitouch.c | 5 - 1 file changed, 4 insertions(+), 1 deletion

[PATCH v5 5/10] HID: multitouch: support getting the tip state from HID_DG_TOUCH fields

2024-08-17 Thread Aditya Garg
ned-off-by: Kerem Karabay Signed-off-by: Aditya Garg --- drivers/hid/hid-multitouch.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index 3e92789ed..571435da5 100644 --- a/drivers/hid/hid-multitou

[PATCH v5 6/10] HID: multitouch: take cls->maxcontacts into account for devices without a HID_DG_CONTACTMAX field too

2024-08-17 Thread Aditya Garg
From: Kerem Karabay This is needed for Apple Touch Bars, where no HID_DG_CONTACTMAX field is present and the maximum contact count is greater than the default. Signed-off-by: Kerem Karabay Signed-off-by: Aditya Garg --- drivers/hid/hid-multitouch.c | 7 --- 1 file changed, 4 insertions

[PATCH v5 7/10] HID: multitouch: allow specifying if a device is direct in a class

2024-08-17 Thread Aditya Garg
-by: Aditya Garg --- drivers/hid/hid-multitouch.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index 60b675cd1..2948fbcbc 100644 --- a/drivers/hid/hid-multitouch.c +++ b/drivers/hid/hid-multitouch.c

[PATCH v5 8/10] HID: multitouch: add device ID for Apple Touch Bars

2024-08-17 Thread Aditya Garg
From: Kerem Karabay Note that this is device ID is for T2 Macs. Testing on T1 Macs would be appreciated. Signed-off-by: Kerem Karabay Signed-off-by: Aditya Garg --- drivers/hid/Kconfig | 1 + drivers/hid/hid-multitouch.c | 26 ++ 2 files changed, 23

[PATCH v5 9/10] drm/format-helper: Add conversion from XRGB8888 to BGR888

2024-08-17 Thread Aditya Garg
From: Kerem Karabay Add XRGB emulation helper for devices that only support BGR888. Signed-off-by: Kerem Karabay Signed-off-by: Aditya Garg --- drivers/gpu/drm/drm_format_helper.c | 54 + .../gpu/drm/tests/drm_format_helper_test.c| 81

[PATCH v5 10/10] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2024-08-17 Thread Aditya Garg
Karabay Signed-off-by: Aditya Garg --- MAINTAINERS | 6 + drivers/gpu/drm/tiny/Kconfig | 12 + drivers/gpu/drm/tiny/Makefile | 1 + drivers/gpu/drm/tiny/appletbdrm.c | 624 ++ 4 files changed, 643 insertions(+) create mode 100644

Re: [PATCH v5 0/10] [DRM REVIEW NEEDED] Touch Bar support for T2 Macs

2024-09-17 Thread Aditya Garg
Hi Jiri Do I have to send the drm patches again to get their Acked-by/Reviewed-by? Although I have already cced the DRM maintainers in this patchset. > On 11 Sep 2024, at 5:51 PM, Jiri Kosina wrote: > > On Sat, 31 Aug 2024, Aditya Garg wrote: > >> Hi Maintainers >> &g

Re: [WHY SUCH DELAY!] Touch Bar support for T2 Macs

2024-09-26 Thread Aditya Garg
> On 26 Sep 2024, at 11:33 PM, Jiri Kosina wrote: > > On Thu, 26 Sep 2024, Aditya Garg wrote: > >> It has been more than a month since I've sent this patch set and I >> haven't got a clear yes or not for the same. I understand maintainers >> are bus

[WHY SUCH DELAY!] Touch Bar support for T2 Macs

2024-09-26 Thread Aditya Garg
ya > On 11 Sep 2024, at 5:51 PM, Jiri Kosina wrote: > > On Sat, 31 Aug 2024, Aditya Garg wrote: > >> Hi Maintainers >> >> It has been 2 weeks but I still haven't received a single reply on this >> version of the patch series. Consider this email as a fri

Re: [WHY SUCH DELAY!] Touch Bar support for T2 Macs

2024-09-27 Thread Aditya Garg
then. > On 27 Sep 2024, at 8:52 PM, Benjamin Tissoires wrote: > > On Sep 26 2024, Aditya Garg wrote: >> It has been more than a month since I've sent this patch set and I haven't >> got a clear yes or not for the same. I understand maintainers are busy >> p

Re: [PATCH v5 10/10] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2024-09-27 Thread Aditya Garg
Hi Thomas Thanks for the review, I’ll soon get to work. > On 27 Sep 2024, at 1:18 PM, Thomas Zimmermann wrote: > > Hi > > Am 17.08.24 um 13:52 schrieb Aditya Garg: >> From: Kerem Karabay >> >> The Touch Bars found on x86 Macs support two USB configurations:

Re: [PATCH v5 10/10] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2024-09-27 Thread Aditya Garg
> On 27 Sep 2024, at 1:12 PM, mrip...@kernel.org wrote: > > On Sat, Aug 17, 2024 at 11:52:22AM GMT, Aditya Garg wrote: >> From: Kerem Karabay >> >> The Touch Bars found on x86 Macs support two USB configurations: one >> where the device presents itself

Re: [PATCH v5 2/10] HID: hid-appletb-kbd: add driver for the keyboard mode

2024-09-27 Thread Aditya Garg
> On 27 Sep 2024, at 9:09 PM, Benjamin Tissoires wrote: > > On Aug 17 2024, Aditya Garg wrote: >> From: Kerem Karabay >> >> The Touch Bars found on x86 Macs support two USB configurations: one >> where the device presents itself as a HID keyboard and can d

Re: [RFC PATCH v5 10/10] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-15 Thread Aditya Garg
appreciated. >> >> Credit goes to @imbushuo on GitHub for reverse engineering most of the >> protocol. >> >> Signed-off-by: Kerem Karabay >> Signed-off-by: Aditya Garg >> --- >> MAINTAINERS | 6 + >> drivers/g

Re: [PATCH v2 0/2] Use proper printk format in appletbdrm

2025-03-21 Thread Aditya Garg
Hi > On 13 Mar 2025, at 4:48 PM, Aditya Garg wrote: > > The vsprint patch was originally being sent as a seperate patch [1], and > I was waiting it to be taken up. But since 6.15 merge window is near, a > potential delay between the drm and vsprintf patch might make the vsprin

Re: [PATCH v2 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-13 Thread Aditya Garg
> On 13 Mar 2025, at 4:49 PM, Aditya Garg wrote: > > From: Hector Martin > > %p4cc is designed for DRM/V4L2 FourCCs with their specific quirks, but > it's useful to be able to print generic 4-character codes formatted as > an integer. Extend it to add format speci

Re: [PATCH v4 0/3] Use proper printk format in appletbdrm

2025-04-08 Thread Aditya Garg
> On 8 Apr 2025, at 2:11 PM, Andy Shevchenko > wrote: > > On Tue, Apr 08, 2025 at 12:17:13PM +0530, Aditya Garg wrote: >> The vsprint patch was originally being sent as a seperate patch [1], and >> I was waiting it to be taken up. But as suggested by Petr, I&#

[PATCH v4 0/3] Use proper printk format in appletbdrm

2025-04-08 Thread Aditya Garg
merged now. v4: Do changes requested by Andy and add Petr's review to printf patch. Link: https://lore.kernel.org/lkml/1a03a5b4-93ac-4307-ae6a-4a4c4b7e9...@live.com/ [1] Aditya Garg (2): printf: add tests for generic FourCCs drm/appletbdrm: use %p4cl instead of %p4cc Hector Martin (1):

[PATCH v4 2/3] printf: add tests for generic FourCCs

2025-04-08 Thread Aditya Garg
From: Aditya Garg This patch adds support for kunit tests of generic 32-bit FourCCs added to vsprintf. Acked-by: Tamir Duberstein Reviewed-by: Andy Shevchenko Reviewed-by: Petr Mladek Tested-by: Petr Mladek Signed-off-by: Aditya Garg --- lib/tests/printf_kunit.c | 39

[PATCH v4 1/3] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-04-07 Thread Aditya Garg
nting LSByte-first FourCCs stored in host endian order (other than the hex form being in character order, not the integer value). Acked-by: Rasmus Villemoes Reviewed-by: Andy Shevchenko Reviewed-by: Petr Mladek Tested-by: Petr Mladek Signed-off-by: Hector Martin Signed-off-by: Aditya

[PATCH] drm/appletbdrm: Make appletbdrm depend on X86

2025-04-10 Thread Aditya Garg
From: Aditya Garg The appletbdrm driver is exclusively for Touch Bars on x86 Intel Macs. The M1 Macs have a separate driver. So, lets avoid compiling it for other architectures. Signed-off-by: Aditya Garg --- drivers/gpu/drm/tiny/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a

Re: [PATCH v3 0/3] Use proper printk format in appletbdrm

2025-04-07 Thread Aditya Garg
> On 7 Apr 2025, at 7:26 PM, Andy Shevchenko > wrote: > > On Mon, Apr 07, 2025 at 07:05:13PM +0530, Aditya Garg wrote: >> The vsprint patch was originally being sent as a seperate patch [1], and >> I was waiting it to be taken up. But as suggested by Petr, I&#

[PATCH v3 0/3] Use proper printk format in appletbdrm

2025-04-07 Thread Aditya Garg
merged now. [1]: https://lore.kernel.org/lkml/1a03a5b4-93ac-4307-ae6a-4a4c4b7e9...@live.com/ Aditya Garg (2): printf: add tests for generic FourCCs drm/appletbdrm: use %p4cl instead of %p4cc Hector Martin (1): lib/vsprintf: Add support for generic FourCCs by extending %p4cc Documentatio

[PATCH v3 3/3] drm/appletbdrm: use %p4cl instead of %p4cc

2025-04-07 Thread Aditya Garg
From: Aditya Garg Due to lack of a proper printk format, %p4cc was being used instead of %p4cl for the purpose of printing FourCCs. But the disadvange was that they were being printed in a reverse order. %p4cl should correct this issue. Signed-off-by: Aditya Garg --- drivers/gpu/drm/tiny

Re: [PATCH v3 2/3] printf: add tests for generic FourCCs

2025-04-07 Thread Aditya Garg
On 07/04/25 7:07 pm, Aditya Garg wrote: > From: Aditya Garg > > This patch adds support for kunit tests of generic 32-bit FourCCs added to > vsprintf. > > Acked-by: Tamir Duberstein > Reviewed-by: Andy Shevchenko > Signed-off-by: Aditya Garg > --- Petr are you fine with this here?

[PATCH v3 2/3] printf: add tests for generic FourCCs

2025-04-07 Thread Aditya Garg
From: Aditya Garg This patch adds support for kunit tests of generic 32-bit FourCCs added to vsprintf. Acked-by: Tamir Duberstein Reviewed-by: Andy Shevchenko Signed-off-by: Aditya Garg --- lib/tests/printf_kunit.c | 39 --- 1 file changed, 32 insertions

Re: [PATCH v3 0/3] Use proper printk format in appletbdrm

2025-04-07 Thread Aditya Garg
On 07-04-2025 07:52 pm, Andy Shevchenko wrote: > On Mon, Apr 07, 2025 at 02:17:00PM +0000, Aditya Garg wrote: >>> On 7 Apr 2025, at 7:26 PM, Andy Shevchenko >>> wrote: >>> On Mon, Apr 07, 2025 at 07:05:13PM +0530, Aditya Garg wrote: >>>> The vs

Re: [PATCH v4 0/3] Use proper printk format in appletbdrm

2025-04-17 Thread Aditya Garg
Hi On 08-04-2025 12:17 pm, Aditya Garg wrote: > The vsprint patch was originally being sent as a seperate patch [1], and > I was waiting it to be taken up. But as suggested by Petr, I'm sending > them via DRM. > > v2: > Remove printf tests, will merge later through Kees&

Re: [PATCH v4 1/3] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-04-22 Thread Aditya Garg
On 22-04-2025 02:13 pm, Geert Uytterhoeven wrote: > Hi Aditya, > > CC netdev > > On Tue, 22 Apr 2025 at 10:30, Aditya Garg wrote: >> On 22-04-2025 01:37 pm, Geert Uytterhoeven wrote: >>> On Tue, 8 Apr 2025 at 08:48, Aditya Garg wrote: >>>> From:

Re: [PATCH v4 1/3] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-04-22 Thread Aditya Garg
On 22-04-2025 01:37 pm, Geert Uytterhoeven wrote: > Hi Aditya, Hector, > > On Tue, 8 Apr 2025 at 08:48, Aditya Garg wrote: >> From: Hector Martin >> >> %p4cc is designed for DRM/V4L2 FourCCs with their specific quirks, but >> it's useful to be a

  1   2   3   >