Re: [PATCH 3/3] [RFC] drm/exynos: Add basic i.MX8MM support code

2021-05-10 Thread Adam Ford
On Mon, Oct 5, 2020 at 8:48 AM Marek Vasut wrote: > > This adds basic i.MX8MM glue code for the Samsung DSIM PHY. > There are still a couple of items which need to be sorted out > in drivers/gpu/drm/bridge/samsung-dsim.c before this can even > be merged, specifically: > > - The dsi->out_bridge is

Re: [PATCH V4 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

2021-05-12 Thread Adam Ford
xel format is implemented, the > LVDS666 is not supported, but could be added if needed. > Tested-by: Adam Ford > Reviewed-by: Linus Walleij > Reviewed-by: Frieder Schrempf > Tested-by: Frieder Schrempf > Signed-off-by: Marek Vasut > Cc: Douglas Anderson > Cc: Jagan Teki &

Re: [PATCH v2 01/16] drm/encoder: remove obsolete documentation of bridge

2020-11-07 Thread Adam Ford
On Fri, Sep 11, 2020 at 8:54 AM Michael Tretter wrote: > > In commit 05193dc38197 ("drm/bridge: Make the bridge chain a > double-linked list") the bridge has been removed and replaced by a > private field. Remove the leftover documentation of the removed field. > > Signed-off-by: Michael Tretter

Re: DSI Bridge switching

2022-03-09 Thread Adam Ford
On Wed, Mar 9, 2022 at 1:11 PM Jagan Teki wrote: > > or a Hi All, > > On Thu, Oct 14, 2021 at 6:45 PM Jagan Teki wrote: > > > > Hi Laurent, > > > > On Fri, Oct 8, 2021 at 7:07 PM Laurent Pinchart > > wrote: > > > > > > Hello, > > > > > > On Fri, Oct 08, 2021 at 03:27:43PM +0200, Andrzej Hajda w

Re: [PATCH v6 0/6] drm: exynos: dsi: Convert drm bridge

2022-03-25 Thread Adam Ford
On Fri, Mar 25, 2022 at 10:00 AM Marek Szyprowski wrote: > > Hi Jagan, > > On 03.03.2022 17:36, Jagan Teki wrote: > > Updated series about drm bridge conversion of exynos dsi. > > > > Previous version can be accessible, here [1]. > > > > Patch 1: tc358764 panel_bridge API > > > > Patch 2: connecto

Re: [PATCH 1/9] dt-bindings: mxsfb: Add compatible for i.MX8MP

2022-03-01 Thread Adam Ford
On Tue, Mar 1, 2022 at 5:05 AM Lucas Stach wrote: > > Am Dienstag, dem 01.03.2022 um 11:19 +0100 schrieb Marek Vasut: > > On 3/1/22 11:04, Lucas Stach wrote: > > > > Hi, > > > > [...] > > > > > > Given the two totally different IPs, I don't see bugs of IP control > > > > logics should be fixed for

Re: Renesas rcar-du and DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE

2022-01-21 Thread Adam Ford
On Wed, Dec 29, 2021 at 10:19 PM Charles Stevens wrote: > >  > Hi All, > I am working on a platform based on the Renesas RZ/G2 SoC family. This > chip uses the rcar-du driver for the display. I would like to submit a patch > to address the fact that the driver does not check/honor the flag

Re: [RFC] arm64: dts: imx8mm: Add MIPI and LCDIF nodes

2021-11-09 Thread Adam Ford
On Tue, Nov 9, 2021 at 11:38 AM Jagan Teki wrote: > > On Tue, Nov 9, 2021 at 11:04 PM Tim Harvey wrote: > > > > Add nodes for MIPI DSI and LCDIF on IMX8MM > > > > I'm currently working with a set of patches to convert drm/exynos > > to a bridge [1] and add IMX8MM support [2] in order to get IMX8M

Re: [RFC] arm64: dts: imx8mm: Add MIPI and LCDIF nodes

2021-11-09 Thread Adam Ford
On Tue, Nov 9, 2021 at 11:34 AM Tim Harvey wrote: > > Add nodes for MIPI DSI and LCDIF on IMX8MM > > I'm currently working with a set of patches to convert drm/exynos > to a bridge [1] and add IMX8MM support [2] in order to get IMX8MM DSI > working for display with a Raspberry Pi DSI touchscreen c

Re: [RFC] arm64: dts: imx8mm: Add MIPI and LCDIF nodes

2021-11-09 Thread Adam Ford
On Tue, Nov 9, 2021 at 11:34 AM Tim Harvey wrote: > > Add nodes for MIPI DSI and LCDIF on IMX8MM > > I'm currently working with a set of patches to convert drm/exynos > to a bridge [1] and add IMX8MM support [2] in order to get IMX8MM DSI > working for display with a Raspberry Pi DSI touchscreen c

Re: [RFC] arm64: dts: imx8mm: Add MIPI and LCDIF nodes

2021-11-09 Thread Adam Ford
On Tue, Nov 9, 2021 at 6:24 PM Adam Ford wrote: > > On Tue, Nov 9, 2021 at 11:34 AM Tim Harvey wrote: > > > > Add nodes for MIPI DSI and LCDIF on IMX8MM > > > > I'm currently working with a set of patches to convert drm/exynos > > to a bridge [1] and add

Re: [RFC PATCH 00/17] drm: bridge: Samsung MIPI DSIM bridge

2021-12-15 Thread Adam Ford
On Thu, Dec 9, 2021 at 3:24 PM Michael Nazzareno Trimarchi wrote: > > Hi > > On Thu, Dec 9, 2021 at 9:24 PM Lucas Stach wrote: > > > > Am Donnerstag, dem 09.12.2021 um 18:09 +0100 schrieb Michael Nazzareno > > Trimarchi: > > > Hi Tim > > > > > > On Thu, Dec 9, 2021 at 5:40 PM Tim Harvey wrote: >

[PATCH] drm/omap: Migrate minimum FCK/PCK ratio from Kconfig to dts

2019-05-11 Thread Adam Ford
Currently the source code is compiled using hard-coded values from CONFIG_OMAP2_DSS_MIN_FCK_PER_PCK. This patch allows this clock divider value to be moved to the device tree and be changed without having to recompile the kernel. Signed-off-by: Adam Ford diff --git a/Documentation/devicetree

Re: [PATCH] drm/omap: Migrate minimum FCK/PCK ratio from Kconfig to dts

2019-05-28 Thread Adam Ford
On Tue, May 28, 2019 at 4:11 AM Tomi Valkeinen wrote: > > Hi, > > On 10/05/2019 22:42, Adam Ford wrote: > > Currently the source code is compiled using hard-coded values > > from CONFIG_OMAP2_DSS_MIN_FCK_PER_PCK. This patch allows this > > clock divider value to b

Re: [PATCH] drm/omap: Migrate minimum FCK/PCK ratio from Kconfig to dts

2019-05-31 Thread Adam Ford
On Tue, May 28, 2019 at 10:53 AM Tomi Valkeinen wrote: > > Hi, > > On 28/05/2019 18:09, Adam Ford wrote: > > On Tue, May 28, 2019 at 4:11 AM Tomi Valkeinen > > wrote: > >> > >> Hi, > >> > >> On 10/05/2019 22:42, Adam Ford wrote:

imx8mm lcdif->dsi->adv7535 no video, no errors

2022-07-30 Thread Adam Ford
Hey all, I am trying to test Jagan's patch series [1] to add support for the samsung dsim bridge which is used on the imx8mm to output DSI video. The DSIM gets the video from the mxsfb, and in my case, the DSI is sent to the adv7535 for connecting to HDMI. I have been able to get the device tree

Re: imx8mm lcdif->dsi->adv7535 no video, no errors

2022-08-01 Thread Adam Ford
On Mon, Aug 1, 2022 at 1:20 AM Marco Felsch wrote: > > Hi Adam, > > On 22-07-30, Adam Ford wrote: > > Hey all, > > > > I am trying to test Jagan's patch series [1] to add support for the > > samsung dsim bridge which is used on the imx8mm to output DSI vi

Re: imx8mm lcdif->dsi->adv7535 no video, no errors

2022-08-01 Thread Adam Ford
On Mon, Aug 1, 2022 at 5:54 AM Adam Ford wrote: > > On Mon, Aug 1, 2022 at 1:20 AM Marco Felsch wrote: > > > > Hi Adam, > > > > On 22-07-30, Adam Ford wrote: > > > Hey all, > > > > > > I am trying to test Jagan's patch series [1] to

Re: [PATCH] drm/bridge: ti-sn65dsi83: Add and use hs_rate and lp_rate

2022-08-01 Thread Adam Ford
On Mon, Aug 1, 2022 at 11:05 AM Marek Vasut wrote: > > On 8/1/22 16:55, Dave Stevenson wrote: > > Hi Marek > > Hi, > > > On Mon, 1 Aug 2022 at 14:12, Marek Vasut wrote: > >> > >> Fill in hs_rate and lp_rate to struct mipi_dsi_device for this bridge and > >> adjust DSI input frequency calculations

Re: imx8mm lcdif->dsi->adv7535 no video, no errors

2022-08-01 Thread Adam Ford
On Mon, Aug 1, 2022 at 2:33 PM Fabio Estevam wrote: > > Hi Adam, > > On Sat, Jul 30, 2022 at 12:16 PM Adam Ford wrote: > > > > Hey all, > > > > I am trying to test Jagan's patch series [1] to add support for the > > samsung dsim bridge which is

Re: imx8mm lcdif->dsi->adv7535 no video, no errors

2022-08-01 Thread Adam Ford
On Mon, Aug 1, 2022 at 3:07 PM Adam Ford wrote: > > On Mon, Aug 1, 2022 at 2:33 PM Fabio Estevam wrote: > > > > Hi Adam, > > > > On Sat, Jul 30, 2022 at 12:16 PM Adam Ford wrote: > > > > > > Hey all, > > > > > > I am trying to

Re: imx8mm lcdif->dsi->adv7535 no video, no errors

2022-08-01 Thread Adam Ford
On Mon, Aug 1, 2022 at 6:12 PM Fabio Estevam wrote: > > Hi Marco, > > On Mon, Aug 1, 2022 at 7:55 PM Marco Felsch wrote: > > > Question is, does your setup work for all modes after applying your > > patches and without using the NXP-downstream porches settings? We also > > Without Frieder's patch

Re: imx8mm lcdif->dsi->adv7535 no video, no errors

2022-08-01 Thread Adam Ford
On Mon, Aug 1, 2022 at 8:53 PM Fabio Estevam wrote: > > On Mon, Aug 1, 2022 at 10:39 PM Adam Ford wrote: > > > I managed to get my HDMI output working. I had the lanes set to 2 > > instead of 4. Once I switched to 4-lanes, the monitor came up in > > 1080p. I haven&#

Re: imx8mm lcdif->dsi->adv7535 no video, no errors

2022-08-02 Thread Adam Ford
On Tue, Aug 2, 2022 at 3:08 AM Marco Felsch wrote: > > Hi Adam, Fabio, > > On 22-08-01, Adam Ford wrote: > > On Mon, Aug 1, 2022 at 8:53 PM Fabio Estevam wrote: > > > > > > On Mon, Aug 1, 2022 at 10:39 PM Adam Ford wrote: > > > > > > >

Re: imx8mm lcdif->dsi->adv7535 no video, no errors

2022-08-02 Thread Adam Ford
On Tue, Aug 2, 2022 at 7:13 AM Adam Ford wrote: > > On Tue, Aug 2, 2022 at 3:08 AM Marco Felsch wrote: > > > > Hi Adam, Fabio, > > > > On 22-08-01, Adam Ford wrote: > > > On Mon, Aug 1, 2022 at 8:53 PM Fabio Estevam wrote: > > > > >

Re: imx8mm lcdif->dsi->adv7535 no video, no errors

2022-08-02 Thread Adam Ford
On Tue, Aug 2, 2022 at 8:51 AM Adam Ford wrote: > > On Tue, Aug 2, 2022 at 7:13 AM Adam Ford wrote: > > > > On Tue, Aug 2, 2022 at 3:08 AM Marco Felsch wrote: > > > > > > Hi Adam, Fabio, > > > > > > On 22-08-01, Adam Ford wrote: >

Re: imx8mm lcdif->dsi->adv7535 no video, no errors

2022-08-03 Thread Adam Ford
On Wed, Aug 3, 2022 at 1:20 AM Marco Felsch wrote: > > On 22-08-02, Adam Ford wrote: > > ... > > > > I did some reading about the internal timing generator. It appears > > > that it's required when video formats use fractional bytes, and it's > &g

Re: imx8mm lcdif->dsi->adv7535 no video, no errors

2022-08-03 Thread Adam Ford
On Wed, Aug 3, 2022 at 7:17 AM Dave Stevenson wrote: > > Hi Adam > > On Wed, 3 Aug 2022 at 12:03, Adam Ford wrote: > > > > On Wed, Aug 3, 2022 at 1:20 AM Marco Felsch wrote: > > > > > > On 22-08-02, Adam Ford wrote: > > > > > > ...

Re: imx8mm lcdif->dsi->adv7535 no video, no errors

2022-08-04 Thread Adam Ford
ave Stevenson wrote: > > > > Hi Adam > > > > > > > > On Wed, 3 Aug 2022 at 12:03, Adam Ford wrote: > > > > > > ... > > > > > > > > > Did managed to get access to the ADV7535 programming guide? This is > > > >

Re: imx8mm lcdif->dsi->adv7535 no video, no errors

2022-08-04 Thread Adam Ford
ote: > > > > > > > > Hi Dave, Adam, > > > > > > > > On 22-08-03, Dave Stevenson wrote: > > > > > Hi Adam > > > > > > > > > > On Wed, 3 Aug 2022 at 12:03, Adam Ford wrote: > > > > > >

Re: imx8mm lcdif->dsi->adv7535 no video, no errors

2022-08-05 Thread Adam Ford
> > > > > > > > > > > > Hi Dave, Adam, > > > > > > > > > > > > On 22-08-03, Dave Stevenson wrote: > > > > > > > Hi Adam > > > > > > > > > > > > > > On Wed, 3

Re: imx8mm lcdif->dsi->adv7535 no video, no errors

2022-08-05 Thread Adam Ford
On Fri, Aug 5, 2022 at 5:55 AM Adam Ford wrote: > > On Fri, Aug 5, 2022 at 3:44 AM Biju Das wrote: > > > > Hi Adam and all, > > > > > Subject: Re: imx8mm lcdif->dsi->adv7535 no video, no errors > > > > > > On Thu, Aug 4, 2022 at 9:52 AM D

Re: imx8mm lcdif->dsi->adv7535 no video, no errors

2022-08-05 Thread Adam Ford
On Fri, Aug 5, 2022 at 7:56 AM Adam Ford wrote: > > On Fri, Aug 5, 2022 at 5:55 AM Adam Ford wrote: > > > > On Fri, Aug 5, 2022 at 3:44 AM Biju Das wrote: > > > > > > Hi Adam and all, > > > > > > > Subject: Re: imx8mm lcdif->dsi->

Re: imx8mm lcdif->dsi->adv7535 no video, no errors

2022-08-07 Thread Adam Ford
On Fri, Aug 5, 2022 at 4:05 PM Adam Ford wrote: > > On Fri, Aug 5, 2022 at 7:56 AM Adam Ford wrote: > > > > On Fri, Aug 5, 2022 at 5:55 AM Adam Ford wrote: > > > > > > On Fri, Aug 5, 2022 at 3:44 AM Biju Das > > > wrote: > > > > >

Re: imx8mm lcdif->dsi->adv7535 no video, no errors

2022-08-08 Thread Adam Ford
On Mon, Aug 8, 2022 at 3:54 AM Marco Felsch wrote: > > On 22-08-07, Adam Ford wrote: > > On Fri, Aug 5, 2022 at 4:05 PM Adam Ford wrote: > > > > > > On Fri, Aug 5, 2022 at 7:56 AM Adam Ford wrote: > > > > > > > > On Fri, Aug 5, 2022 at 5:55

Re: imx8mm lcdif->dsi->adv7535 no video, no errors

2022-08-08 Thread Adam Ford
On Mon, Aug 8, 2022 at 5:13 AM Adam Ford wrote: > > On Mon, Aug 8, 2022 at 3:54 AM Marco Felsch wrote: > > > > On 22-08-07, Adam Ford wrote: > > > On Fri, Aug 5, 2022 at 4:05 PM Adam Ford wrote: > > > > > > > > On Fri, Aug 5, 2022 at 7:56 AM

Re: [PATCH 04/11] drm: bridge: samsung-dsim: Add DSI init in bridge pre_enable()

2022-04-11 Thread Adam Ford
On Fri, Apr 8, 2022 at 11:22 AM Jagan Teki wrote: > > Host transfer() in DSI master will invoke only when the DSI commands > are sent from DSI devices like DSI Panel or DSI bridges and this > host transfer wouldn't invoke for I2C-based-DSI bridge drivers. > > Handling DSI host initialization in tr

Re: [PATCH 00/11] drm: bridge: Add Samsung MIPI DSIM bridge

2022-04-11 Thread Adam Ford
On Mon, Apr 11, 2022 at 8:56 AM Marek Szyprowski wrote: > > On 08.04.2022 18:20, Jagan Teki wrote: > > This series supports common bridge support for Samsung MIPI DSIM > > which is used in Exynos and i.MX8MM SoC's. > > > > Previous RFC can be available here [1]. > > > > The final bridge supports b

Re: [PATCH 00/11] drm: bridge: Add Samsung MIPI DSIM bridge

2022-04-11 Thread Adam Ford
On Mon, Apr 11, 2022 at 9:39 AM Adam Ford wrote: > > On Mon, Apr 11, 2022 at 8:56 AM Marek Szyprowski > wrote: > > > > On 08.04.2022 18:20, Jagan Teki wrote: > > > This series supports common bridge support for Samsung MIPI DSIM > > > wh

Re: [PATCH 00/11] drm: bridge: Add Samsung MIPI DSIM bridge

2022-04-11 Thread Adam Ford
On Mon, Apr 11, 2022 at 11:25 AM Marek Szyprowski wrote: > > On 11.04.2022 16:39, Adam Ford wrote: > > On Mon, Apr 11, 2022 at 8:56 AM Marek Szyprowski > > wrote: > >> On 08.04.2022 18:20, Jagan Teki wrote: > >>> This series supports common bridge suppo

Re: [PATCH 1/2] drm/etnaviv: add HWDB entry for GC7000 r6203

2022-08-27 Thread Adam Ford
ng GPU! With mesa-22.2.0-rc3, I am able to run 3D demos. Tested-by: Adam Ford #imx8mn-beacon-kit > Signed-off-by: Marco Felsch > Signed-off-by: Lucas Stach > --- > drivers/gpu/drm/etnaviv/etnaviv_hwdb.c | 31 ++ > 1 file changed, 31 insertions(+) > &g

Re: [PATCH v4 07/12] drm: bridge: samsung-dsim: Fix PLL_P (PMS_P) offset

2022-08-29 Thread Adam Ford
On Mon, Aug 29, 2022 at 1:41 PM Jagan Teki wrote: > > The i.MX 8M Mini Applications Processor Reference Manual, Rev. 3, 11/2020 > with 13.7.10.1 Master PLL PMS Value setting Register mentioned PMS_P offset > range from BIT[18-13] and the upstream driver is using the same offset. > > However, offse

Re: [PATCH v3 02/13] drm: bridge: Add Samsung DSIM bridge driver

2022-07-28 Thread Adam Ford
On Wed, Jul 20, 2022 at 10:52 AM Jagan Teki wrote: > > Samsung MIPI DSIM controller is common DSI IP that can be used in various > SoCs like Exynos, i.MX8M Mini/Nano. > > In order to access this DSI controller between various platform SoCs, > the ideal way to incorporate this in the drm stack is v

Re: [PATCH V5 1/3] drm/panel: simple: Add Logic PD Type 28 display support

2019-10-30 Thread Adam Ford
On Wed, Oct 16, 2019 at 8:52 AM Adam Ford wrote: > > Previously, there was an omap panel-dpi driver that would > read generic timings from the device tree and set the display > timing accordingly. This driver was removed so the screen > no longer functions. This patch modifies t

Re: [PATCH V5 1/3] drm/panel: simple: Add Logic PD Type 28 display support

2019-11-11 Thread Adam Ford
On Fri, Nov 1, 2019 at 2:57 AM Laurent Pinchart wrote: > > On Wed, Oct 30, 2019 at 09:44:20AM -0500, Adam Ford wrote: > > On Wed, Oct 16, 2019 at 8:52 AM Adam Ford wrote: > > > > > > Previously, there was an omap panel-dpi driver that would > > > read gener

Re: [PATCH] drm/omap: fix max fclk divider for omap36xx

2019-10-13 Thread Adam Ford
if I submit a patch to stable for those two LTS branches? thanks, adam > Signed-off-by: Tomi Valkeinen > Cc: Adam Ford > Cc: sta...@vger.kernel.org > --- > drivers/gpu/drm/omapdrm/dss/dss.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drive

Re: [PATCH V4 2/3] dt-bindings: Add Logic PD Type 28 display panel

2019-10-15 Thread Adam Ford
On Wed, Oct 9, 2019 at 6:31 PM Rob Herring wrote: > > On Tue, Oct 01, 2019 at 06:39:22PM -0500, Adam Ford wrote: > > This patch adds documentation of device tree bindings for the WVGA panel > > Logic PD Type 28 display. > > > > Signed-off-by: Adam Ford >

[PATCH V5 3/3] ARM: logicpd-torpedo-37xx-devkit-28: Reference new DRM panel

2019-10-16 Thread Adam Ford
With the removal of the panel-dpi from the omap drivers, the LCD no longer works. This patch points the device tree to a newly created panel named "logicpd,type28" Fixes: 8bf4b1621178 ("drm/omap: Remove panel-dpi driver") Signed-off-by: Adam Ford Acked-by: Sam Ravnborg -

[PATCH V5 1/3] drm/panel: simple: Add Logic PD Type 28 display support

2019-10-16 Thread Adam Ford
. Fixes: 8bf4b1621178 ("drm/omap: Remove panel-dpi driver") Signed-off-by: Adam Ford Reviewed-by: Sam Ravnborg --- V5: No Change V4: No Change V3: No Change V2: No Change diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 5d

[PATCH V5 2/3] dt-bindings: Add Logic PD Type 28 display panel

2019-10-16 Thread Adam Ford
This patch adds documentation of device tree bindings for the WVGA panel Logic PD Type 28 display. Signed-off-by: Adam Ford --- V5: Replace GPIO_ACTIVE_HIGH with 0 to fix make dt_binding_check -k V4: Update per Rob H's suggestions and copy other panel yaml example from 5.4-rc1 V3: Co

Re: [PATCH V4 2/3] dt-bindings: Add Logic PD Type 28 display panel

2019-10-16 Thread Adam Ford
On Wed, Oct 16, 2019 at 8:15 AM Rob Herring wrote: > > On Tue, Oct 15, 2019 at 6:04 PM Adam Ford wrote: > > > > On Wed, Oct 9, 2019 at 6:31 PM Rob Herring wrote: > > > > > > On Tue, Oct 01, 2019 at 06:39:22PM -0500, Adam Ford wrote: > > > > This

Re: [PATCH V5 2/3] dt-bindings: Add Logic PD Type 28 display panel

2019-10-16 Thread Adam Ford
On Wed, Oct 16, 2019 at 9:40 AM Laurent Pinchart wrote: > > Hi Adam, > > Thank you for the patch. > > On Wed, Oct 16, 2019 at 08:51:46AM -0500, Adam Ford wrote: > > This patch adds documentation of device tree bindings for the WVGA panel > > Logic PD Type 28 displa

Re: [PATCH] backlight: pwm_bl: configure pwm only once per backlight toggle

2019-10-17 Thread Adam Ford
On Thu, Oct 17, 2019 at 7:19 AM Uwe Kleine-König wrote: > > On Thu, Oct 17, 2019 at 12:47:27PM +0100, Daniel Thompson wrote: > > On Thu, Oct 17, 2019 at 10:10:59AM +0200, Uwe Kleine-König wrote: > > > A previous change in the pwm core (namely 01ccf903edd6 ("pwm: Let > > > pwm_get_state() return th

Re: [PATCH] backlight: pwm_bl: configure pwm only once per backlight toggle

2019-10-17 Thread Adam Ford
On Thu, Oct 17, 2019 at 7:34 AM Adam Ford wrote: > > On Thu, Oct 17, 2019 at 7:19 AM Uwe Kleine-König > wrote: > > > > On Thu, Oct 17, 2019 at 12:47:27PM +0100, Daniel Thompson wrote: > > > On Thu, Oct 17, 2019 at 10:10:59AM +0200, Uwe Kleine-König wrote: > &

Re: [PATCH] backlight: pwm_bl: configure pwm only once per backlight toggle

2019-10-17 Thread Adam Ford
On Thu, Oct 17, 2019 at 3:11 AM Uwe Kleine-König wrote: > > A previous change in the pwm core (namely 01ccf903edd6 ("pwm: Let > pwm_get_state() return the last implemented state")) changed the > semantic of pwm_get_state() and disclosed an (as it seems) common > problem in lowlevel PWM drivers. By

Re: [PATCH] backlight: pwm_bl: configure pwm only once per backlight toggle

2019-10-17 Thread Adam Ford
On Thu, Oct 17, 2019 at 8:05 AM Thierry Reding wrote: > > On Thu, Oct 17, 2019 at 07:40:47AM -0500, Adam Ford wrote: > > On Thu, Oct 17, 2019 at 7:34 AM Adam Ford wrote: > > > > > > On Thu, Oct 17, 2019 at 7:19 AM Uwe Kleine-König > > > wrote: > > &

Re: [PATCH] backlight: pwm_bl: configure pwm only once per backlight toggle

2019-10-17 Thread Adam Ford
On Thu, Oct 17, 2019 at 6:11 AM Thierry Reding wrote: > > On Thu, Oct 17, 2019 at 12:11:16PM +0200, Uwe Kleine-König wrote: > > On Thu, Oct 17, 2019 at 11:48:08AM +0200, Michal Vokáč wrote: > > > On 17. 10. 19 10:10, Uwe Kleine-König wrote: > > > > A previous change in the pwm core (namely 01ccf90

Re: [PATCH] backlight: pwm_bl: configure pwm only once per backlight toggle

2019-10-17 Thread Adam Ford
On Thu, Oct 17, 2019 at 8:30 AM Adam Ford wrote: > > On Thu, Oct 17, 2019 at 6:11 AM Thierry Reding > wrote: > > > > On Thu, Oct 17, 2019 at 12:11:16PM +0200, Uwe Kleine-König wrote: > > > On Thu, Oct 17, 2019 at 11:48:08AM +0200, Michal Vokáč wrote: > >

Re: [PATCH V5 2/3] dt-bindings: Add Logic PD Type 28 display panel

2019-10-17 Thread Adam Ford
On Thu, Oct 17, 2019 at 9:37 AM Rob Herring wrote: > > On Wed, Oct 16, 2019 at 09:55:11AM -0500, Adam Ford wrote: > > On Wed, Oct 16, 2019 at 9:40 AM Laurent Pinchart > > wrote: > > > > > > Hi Adam, > > > > > > Thank you for the patch. >

Re: [PATCH] backlight: pwm_bl: configure pwm only once per backlight toggle

2019-10-17 Thread Adam Ford
On Thu, Oct 17, 2019 at 3:11 AM Uwe Kleine-König wrote: > > A previous change in the pwm core (namely 01ccf903edd6 ("pwm: Let > pwm_get_state() return the last implemented state")) changed the > semantic of pwm_get_state() and disclosed an (as it seems) common > problem in lowlevel PWM drivers. By

Re: [PATCH] backlight: pwm_bl: configure pwm only once per backlight toggle

2019-10-17 Thread Adam Ford
is is interesting. If I understand correctly, that first line > here is where the initial hardware readout happens. The second one is > the first time when the backlight is configured, so it sets period and > polarity. But then for some reason when we read out after that to read > what

Re: [PATCH] backlight: pwm_bl: configure pwm only once per backlight toggle

2019-10-17 Thread Adam Ford
On Thu, Oct 17, 2019 at 12:13 PM Thierry Reding wrote: > > On Thu, Oct 17, 2019 at 12:07:21PM -0500, Adam Ford wrote: > > On Thu, Oct 17, 2019 at 10:14 AM Thierry Reding > > wrote: > > > > > > On Thu, Oct 17, 2019 at 03:58:25PM +0200, Michal Vokáč wrote:

Re: [PATCH] drm/omap: fix max fclk divider for omap36xx

2019-10-17 Thread Adam Ford
On Sun, Oct 13, 2019 at 10:56 AM Adam Ford wrote: > > On Wed, Oct 2, 2019 at 7:25 AM Tomi Valkeinen wrote: > > > > The OMAP36xx and AM/DM37x TRMs say that the maximum divider for DSS fclk > > (in CM_CLKSEL_DSS) is 32. Experimentation shows that this is not > > co

Re: [PATCH] backlight: pwm_bl: configure pwm only once per backlight toggle

2019-10-23 Thread Adam Ford
On Fri, Oct 18, 2019 at 4:36 AM Michal Vokáč wrote: > > On 17. 10. 19 19:44, Adam Ford wrote: > > On Thu, Oct 17, 2019 at 12:13 PM Thierry Reding > > wrote: > >> > >> On Thu, Oct 17, 2019 at 12:07:21PM -0500, Adam Ford wrote: > >>> On Thu, Oct

Re: [PATCH 21/33] drm/panel-simple: Fix dotclock for Logic PD Type 28

2020-03-03 Thread Adam Ford
is > correct? > > Cc: Adam Ford > Cc: Sam Ravnborg > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/panel/panel-simple.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c > b/drivers/gpu/drm/panel/pa

[PATCH 1/3] drm/panel: simple: Add Logic PD Type 28 display support

2019-09-17 Thread Adam Ford
. Fixes: 8bf4b1621178 ("drm/omap: Remove panel-dpi driver") Signed-off-by: Adam Ford diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 5a93c4edf1e4..c86c30f3a8a1 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/p

[PATCH 2/3] dt-bindings: Add Logic PD Type 28 display panel

2019-09-17 Thread Adam Ford
This patch adds documentation of device tree bindings for the WVGA panel Logic PD Type 28 display. Signed-off-by: Adam Ford diff --git a/Documentation/devicetree/bindings/display/panel/logicpd,type28.txt b/Documentation/devicetree/bindings/display/panel/logicpd,type28.txt new file mode 100644

[PATCH 3/3] ARM: logicpd-torpedo-37xx-devkit-28: Reference new DRM panel

2019-09-17 Thread Adam Ford
With the removal of the panel-dpi from the omap drivers, the LCD no longer works. This patch points the device tree to a newly created panel named "logicpd,type28" Fixes: 8bf4b1621178 ("drm/omap: Remove panel-dpi driver") Signed-off-by: Adam Ford diff --git a/arch/arm/boot

Re: [PATCH 2/3] dt-bindings: Add Logic PD Type 28 display panel

2019-09-23 Thread Adam Ford
;ll try to piece together a few different examples to come up with something. I should have a V2 today. adam > > Sam > > On Tue, Sep 17, 2019 at 11:12:12AM -0500, Adam Ford wrote: > > This patch adds documentation of device tree bindings for the WVGA panel > > Log

Re: [PATCH 3/3] ARM: logicpd-torpedo-37xx-devkit-28: Reference new DRM panel

2019-09-23 Thread Adam Ford
On Sat, Sep 21, 2019 at 2:09 PM Sam Ravnborg wrote: > > Hi Adam. > > On Tue, Sep 17, 2019 at 11:12:13AM -0500, Adam Ford wrote: > > With the removal of the panel-dpi from the omap drivers, the > > LCD no longer works. This patch points the device tree to > > a newl

[PATCH V2 1/3] drm/panel: simple: Add Logic PD Type 28 display support

2019-09-23 Thread Adam Ford
. Fixes: 8bf4b1621178 ("drm/omap: Remove panel-dpi driver") Signed-off-by: Adam Ford Reviewed-by: Sam Ravnborg --- V2: No change diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 5a93c4edf1e4..c86c30f3a8a1 100644 --- a/drivers/gpu/drm/p

[PATCH V2 2/3] dt-bindings: Add Logic PD Type 28 display panel

2019-09-23 Thread Adam Ford
This patch adds documentation of device tree bindings for the WVGA panel Logic PD Type 28 display. Signed-off-by: Adam Ford --- V2: Use YAML instead of TXT for binding diff --git a/Documentation/devicetree/bindings/display/panel/logicpd,type28.yaml b/Documentation/devicetree/bindings/display

[PATCH V2 3/3] ARM: logicpd-torpedo-37xx-devkit-28: Reference new DRM panel

2019-09-23 Thread Adam Ford
With the removal of the panel-dpi from the omap drivers, the LCD no longer works. This patch points the device tree to a newly created panel named "logicpd,type28" Fixes: 8bf4b1621178 ("drm/omap: Remove panel-dpi driver") Signed-off-by: Adam Ford Acked-by: Sam Ravnborg --

i.MX6Q Etnaviv errors

2019-09-23 Thread Adam Ford
I tired to run some tests on 5.4 and I was getting errors. I went all the way back to 5.0 and I get errors. 4.19 seems to work just fine. I was curious to know if anyone is seeing errors. I'll bisect tomorrow, but I thought I'd ask before I got too far. # LIBGL_DEBUG=verbose glmark2-es2-drm dr

Re: [PATCH V2 2/3] dt-bindings: Add Logic PD Type 28 display panel

2019-09-24 Thread Adam Ford
On Tue, Sep 24, 2019 at 1:56 PM Rob Herring wrote: > > On Mon, Sep 23, 2019 at 8:45 AM Adam Ford wrote: > > > > This patch adds documentation of device tree bindings for the WVGA panel > > Logic PD Type 28 display. > > > > Signed-off-by: Adam Ford > >

[PATCH V3 1/3] drm/panel: simple: Add Logic PD Type 28 display support

2019-09-25 Thread Adam Ford
. Fixes: 8bf4b1621178 ("drm/omap: Remove panel-dpi driver") Signed-off-by: Adam Ford Reviewed-by: Sam Ravnborg --- V3: No change V2: No change diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 28fa6ba7b767..8abb31f83ffc 100644 --- a/d

[PATCH V3 2/3] dt-bindings: Add Logic PD Type 28 display panel

2019-09-25 Thread Adam Ford
This patch adds documentation of device tree bindings for the WVGA panel Logic PD Type 28 display. Signed-off-by: Adam Ford --- V3: Correct build errors from 'make dt_binding_check' V2: Use YAML instead of TXT for binding diff --git a/Documentation/devicetree/bindings/display/pan

[PATCH V3 3/3] ARM: logicpd-torpedo-37xx-devkit-28: Reference new DRM panel

2019-09-25 Thread Adam Ford
With the removal of the panel-dpi from the omap drivers, the LCD no longer works. This patch points the device tree to a newly created panel named "logicpd,type28" Fixes: 8bf4b1621178 ("drm/omap: Remove panel-dpi driver") Signed-off-by: Adam Ford Acked-by: Sam Ravnborg -

Re: [PATCH] drm/omap: Migrate minimum FCK/PCK ratio from Kconfig to dts

2019-09-25 Thread Adam Ford
On Tue, May 28, 2019 at 10:53 AM Tomi Valkeinen wrote: > > Hi, > > On 28/05/2019 18:09, Adam Ford wrote: > > On Tue, May 28, 2019 at 4:11 AM Tomi Valkeinen > > wrote: > >> > >> Hi, > >> > >> On 10/05/2019 22:42, Adam Ford wrote:

Re: [PATCH] drm/omap: Migrate minimum FCK/PCK ratio from Kconfig to dts

2019-09-26 Thread Adam Ford
On Thu, Sep 26, 2019 at 1:55 AM Tomi Valkeinen wrote: > > On 25/09/2019 23:51, Adam Ford wrote: > > >> Has anyone debugged why the hang is happening? > > I started to debug this, but I got distracted when I noticed the LCD > > did't work at all on modern kernel

Re: [PATCH] drm/omap: Migrate minimum FCK/PCK ratio from Kconfig to dts

2019-09-27 Thread Adam Ford
On Fri, Sep 27, 2019 at 1:22 AM Tomi Valkeinen wrote: > > On 26/09/2019 17:12, Adam Ford wrote: > > >> And what is the hdmi5_configure there? I don't see anything in the > >> driver that would print hdmi5_configure. And, of course, there's no > >>

Re: [PATCH] drm/omap: Migrate minimum FCK/PCK ratio from Kconfig to dts

2019-09-27 Thread Adam Ford
On Fri, Sep 27, 2019 at 2:55 AM Tomi Valkeinen wrote: > > (dropping folks who're probably not interested...) > > On 26/09/2019 17:12, Adam Ford wrote: > > On Thu, Sep 26, 2019 at 1:55 AM Tomi Valkeinen > > wrote: > >> > >> On 25/09/2019 23:51, A

Re: [PATCH V3 2/3] dt-bindings: Add Logic PD Type 28 display panel

2019-09-27 Thread Adam Ford
On Fri, Sep 27, 2019 at 1:51 PM Rob Herring wrote: > > On Wed, Sep 25, 2019 at 01:42:37PM -0500, Adam Ford wrote: > > This patch adds documentation of device tree bindings for the WVGA panel > > Logic PD Type 28 display. > > > > Signed-off-by: Adam Ford > > --

Re: [PATCH] drm/omap: Migrate minimum FCK/PCK ratio from Kconfig to dts

2019-09-30 Thread Adam Ford
On Mon, Sep 30, 2019 at 3:53 AM Tero Kristo wrote: > > On 30/09/2019 09:45, Tomi Valkeinen wrote: > > Hi, > > > > On 27/09/2019 18:47, Tomi Valkeinen wrote: > >> On 27/09/2019 18:37, Tero Kristo wrote: > >> > >>> If you can provide details about what clock framework / driver does > >>> wrong (samp

Re: [PATCH] drm/omap: Migrate minimum FCK/PCK ratio from Kconfig to dts

2019-09-30 Thread Adam Ford
On Mon, Sep 30, 2019 at 7:48 AM Tero Kristo wrote: > > On 30/09/2019 15:41, Adam Ford wrote: > > On Mon, Sep 30, 2019 at 3:53 AM Tero Kristo wrote: > >> > >> On 30/09/2019 09:45, Tomi Valkeinen wrote: > >>> Hi, > >>> > >>> On

Re: [PATCH] drm/omap: Migrate minimum FCK/PCK ratio from Kconfig to dts

2019-09-30 Thread Adam Ford
On Mon, Sep 30, 2019 at 8:39 AM H. Nikolaus Schaller wrote: > > > > Am 30.09.2019 um 10:53 schrieb Tero Kristo : > > > > The best action here is probably to drop the max-div value for this clock > > to 16. Can someone check this with their display setup and see what > > happens? Attached patch s

Re: [PATCH] drm/omap: Migrate minimum FCK/PCK ratio from Kconfig to dts

2019-09-30 Thread Adam Ford
On Mon, Sep 30, 2019 at 8:54 AM Adam Ford wrote: > > On Mon, Sep 30, 2019 at 8:39 AM H. Nikolaus Schaller > wrote: > > > > > > > Am 30.09.2019 um 10:53 schrieb Tero Kristo : > > > > > > The best action here is probably to drop the max-div valu

Re: [PATCH] drm/omap: Migrate minimum FCK/PCK ratio from Kconfig to dts

2019-09-30 Thread Adam Ford
On Mon, Sep 30, 2019 at 9:04 AM Adam Ford wrote: > > On Mon, Sep 30, 2019 at 8:54 AM Adam Ford wrote: > > > > On Mon, Sep 30, 2019 at 8:39 AM H. Nikolaus Schaller > > wrote: > > > > > > > > > > Am 30.09.2019 um 10:53 schrieb Tero Kristo

Re: [PATCH] drm/omap: Migrate minimum FCK/PCK ratio from Kconfig to dts

2019-09-30 Thread Adam Ford
On Mon, Sep 30, 2019 at 9:27 AM Tomi Valkeinen wrote: > > On 30/09/2019 17:20, Tomi Valkeinen wrote: > > > Let's see what Tero says, but yeah, something is odd here. I expected > > the max divider to be 16 with Tero's patch, but I don't see it having > > that effect. I can get the div to 31. > > >

Re: [PATCH] drm/omap: Migrate minimum FCK/PCK ratio from Kconfig to dts

2019-10-01 Thread Adam Ford
On Tue, Oct 1, 2019 at 4:31 AM Tomi Valkeinen wrote: > > On 01/10/2019 11:12, Tero Kristo wrote: > > On 01/10/2019 08:07, Tomi Valkeinen wrote: > >> On 30/09/2019 20:48, Tero Kristo wrote: > >> > >>> Hmmh, after some testing, it seems there is bad stuff happening with > >>> the divider clock imple

[PATCH V4 1/3] drm/panel: simple: Add Logic PD Type 28 display support

2019-10-01 Thread Adam Ford
. Fixes: 8bf4b1621178 ("drm/omap: Remove panel-dpi driver") Signed-off-by: Adam Ford Reviewed-by: Sam Ravnborg --- V4: No Change V3: No Change V2: No Change diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 28fa6ba7b767..8abb31f83ffc 10

[PATCH V4 2/3] dt-bindings: Add Logic PD Type 28 display panel

2019-10-01 Thread Adam Ford
This patch adds documentation of device tree bindings for the WVGA panel Logic PD Type 28 display. Signed-off-by: Adam Ford --- V4: Update per Rob H's suggestions and copy other panel yaml example from 5.4-rc1 V3: Correct build errors from 'make dt_binding_check' V2: Use YAML

[PATCH V4 3/3] ARM: logicpd-torpedo-37xx-devkit-28: Reference new DRM panel

2019-10-01 Thread Adam Ford
With the removal of the panel-dpi from the omap drivers, the LCD no longer works. This patch points the device tree to a newly created panel named "logicpd,type28" Fixes: 8bf4b1621178 ("drm/omap: Remove panel-dpi driver") Signed-off-by: Adam Ford Acked-by: Sam Ravnborg -

[PATCH V4 1/3] drm/panel: simple: Add Logic PD Type 28 display support

2019-10-01 Thread Adam Ford
. Fixes: 8bf4b1621178 ("drm/omap: Remove panel-dpi driver") Signed-off-by: Adam Ford Reviewed-by: Sam Ravnborg --- V4: No Change V3: No Change V2: No Change diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 28fa6ba7b767..8abb31f83ffc 10

[PATCH V4 2/3] dt-bindings: Add Logic PD Type 28 display panel

2019-10-01 Thread Adam Ford
This patch adds documentation of device tree bindings for the WVGA panel Logic PD Type 28 display. Signed-off-by: Adam Ford --- V4: Update per Rob H's suggestions and copy other panel yaml example from 5.4-rc1 V3: Correct build errors from 'make dt_binding_check' V2: Use YAML

[PATCH V4 3/3] ARM: logicpd-torpedo-37xx-devkit-28: Reference new DRM panel

2019-10-01 Thread Adam Ford
With the removal of the panel-dpi from the omap drivers, the LCD no longer works. This patch points the device tree to a newly created panel named "logicpd,type28" Fixes: 8bf4b1621178 ("drm/omap: Remove panel-dpi driver") Signed-off-by: Adam Ford Acked-by: Sam Ravnborg -

Re: [PATCH] drm/omap: fix max fclk divider for omap36xx

2019-10-02 Thread Adam Ford
this applied to 5.4 branch since it will be an LTS kernel. [1] - https://patchwork.kernel.org/cover/11170951/ Tested-by: Adam Ford > Signed-off-by: Tomi Valkeinen > Cc: Adam Ford > Cc: sta...@vger.kernel.org > --- > drivers/gpu/drm/omapdrm/dss/dss.c | 2 +- > 1 file chan

Re: [PATCH V5 1/3] drm/panel: simple: Add Logic PD Type 28 display support

2019-11-24 Thread Adam Ford
On Mon, Nov 11, 2019 at 7:19 AM Adam Ford wrote: > > On Fri, Nov 1, 2019 at 2:57 AM Laurent Pinchart > wrote: > > > > On Wed, Oct 30, 2019 at 09:44:20AM -0500, Adam Ford wrote: > > > On Wed, Oct 16, 2019 at 8:52 AM Adam Ford wrote: > > > > > > &g

Re: [PATCH 0/3] drm/omap: fix am4 evm lcd

2019-12-02 Thread Adam Ford
On Mon, Dec 2, 2019 at 7:13 AM Laurent Pinchart wrote: > > Hi Tomi, > > On Thu, Nov 14, 2019 at 11:39:47AM +0200, Tomi Valkeinen wrote: > > Hi Tony, Thierry, Laurent, > > > > After the recent change of moving from omapdrm specific panel-dpi driver > > to the DRM simple panel, AM4 EVM/ePOS's panel

Re: [RFC PATCH 8/9] arm64: dts: imx8mm: Add MIPI DSI pipeline

2021-06-21 Thread Adam Ford
On Mon, Jun 21, 2021 at 2:25 AM Jagan Teki wrote: > > Add MIPI DSI pipeline for i.MX8MM. > > Video pipeline start from eLCDIF to MIPI DSI and respective > Panel or Bridge on the backend side. > > Add support for it. > > Cc: Rob Herring > Signed-off-by: Jagan Teki > --- > arch/arm64/boot/dts/fre

  1   2   3   4   >