[PATCH v2 2/2] drm/msm/dsi: add support for dsi test pattern generator

, it shall be applied on top of this change. Changes in v2: - generate the new dsi.xml.h and update the bitfield names Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/dsi/dsi.h | 3 ++ drivers/gpu/drm/msm/dsi/dsi_host.c| 61 +++ drivers/gpu/drm

[PATCH v2 1/2] drm/msm/dsi: update dsi register header file for tpg

Update the DSI controller header XML file to add registers and bitfields to support rectangular checkered pattern generator. Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/dsi/dsi.xml.h | 94 +++ 1 file changed, 75 insertions(+), 19 deletions(-) diff

[PATCH v3 0/3] Add devcoredump support for DPU

the resp drivers - refactor and remove the linked list logic and simplify it to have just an array Abhinav Kumar (3): drm: allow drm_atomic_print_state() to accept any drm_printer drm/msm/dpu: add support to dump dpu registers drm/msm/dpu: add dpu_dbg points across dpu driver drivers/gpu

[PATCH v3 2/3] drm/msm/dpu: add support to dump dpu registers

it in dpu_kms - delegate the power management of the sub-modules to the resp drivers - refactor and remove the linked list logic and simplify it to have just an array Change-Id: Ide975ecf5d7952ae44daaa6eb611e27d09630be5 Reported-by: kernel test robot Signed-off-by: Abhinav Kumar

[PATCH v3 1/3] drm: allow drm_atomic_print_state() to accept any drm_printer

better. changes in v3: - Remove empty line in the kernel doc Change-Id: Ie425b15b9d5e84f7bad2514f9990181d05019cbf Reported-by: kernel test robot Signed-off-by: Abhinav Kumar Reviewed-by: Daniel Vetter --- drivers/gpu/drm/drm_atomic.c | 28 +++- drivers/gpu

[PATCH v3 3/3] drm/msm/dpu: add dpu_dbg points across dpu driver

Add dpu_dbg points across dpu driver to trigger dumps when critical errors are hit. changes in v3: - change the callers to also pass the drm device while triggering the dump Change-Id: I351514afe2f1c85232a1562253e5671588075197 Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1

[PATCH v4 0/3] Add devcoredump support for DPU

the snapshot of the drm atomic state and triggers a devcoredump. changes in v4: - rename dpu_dbg to msm_disp_snapshot and move it to msm/disp - start using a list of blocks to store the hardware block information - cleanup block allocation and freeing logic to simplify it Abhinav Kumar (3

[PATCH v4 1/3] drm: allow drm_atomic_print_state() to accept any drm_printer

better. changes in v4: - none Reported-by: kernel test robot Signed-off-by: Abhinav Kumar Reviewed-by: Daniel Vetter --- drivers/gpu/drm/drm_atomic.c | 28 +++- drivers/gpu/drm/drm_atomic_uapi.c| 4 +++- drivers/gpu/drm/drm_crtc_internal.h

[PATCH v4 2/3] drm/msm: add support to take dpu snapshot

information - cleanup block allocation and freeing logic to simplify it Reported-by: kernel test robot Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/Makefile | 2 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h| 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c

[PATCH v4 3/3] drm/msm: add disp snapshot points across dpu driver

Add snapshot points across dpu driver to trigger dumps when critical errors are hit. changes in v4: - change the callers to use the new snapshot macro Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 18 +++--- drivers/gpu/drm/msm/disp/dpu1

[PATCH v5 1/7] drm: allow drm_atomic_print_state() to accept any drm_printer

better. changes in v5: - none Reported-by: kernel test robot Signed-off-by: Abhinav Kumar Reviewed-by: Daniel Vetter --- drivers/gpu/drm/drm_atomic.c | 28 +++- drivers/gpu/drm/drm_atomic_uapi.c| 4 +++- drivers/gpu/drm/drm_crtc_internal.h

[PATCH v5 0/7] Add devcoredump support for DPU

and dp pieces for easier review - get rid of MSM_DISP_SNAPSHOT_IN_* macros by simplifying function Abhinav Kumar (7): drm: allow drm_atomic_print_state() to accept any drm_printer drm/msm: add support to take dpu snapshot drm/msm/dsi: add API to take DSI register snapshot drm/msm/dp: add

[PATCH v5 5/7] drm/msm/disp/dpu1: add API to take DPU register snapshot

Add an API to take a snapshot of DPU controller registers. This API will be used by the msm_disp_snapshot module to capture the DPU snapshot. Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 50 + drivers/gpu/drm/msm/msm_kms.h

[PATCH v5 4/7] drm/msm/dp: add API to take DP register snapshot

Add an API to take a snapshot of DP controller registers. This API will be used by the msm_disp_snapshot module to capture the DP snapshot. Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/dp/dp_catalog.c | 9 + drivers/gpu/drm/msm/dp/dp_catalog.h | 4 drivers/gpu/drm/msm/dp

[PATCH v5 6/7] drm/msm: add support to take dsi, dp and dpu snapshot

Add support to take the register snapshot of dsi, dp and dpu modules. Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/msm_disp_snapshot.h | 1 + drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c | 16 2 files changed, 17 insertions(+) diff --git a/drivers/gpu

[PATCH v5 2/7] drm/msm: add support to take dpu snapshot

functions - move snprintf inside the snapshot core by using varargs - get rid of some stale code comments - allow snapshot module for non-DPU targets Reported-by: kernel test robot Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/Makefile | 2 + drivers/gpu/drm/msm/disp

[PATCH v5 7/7] drm/msm: add disp snapshot points across dpu driver

Add snapshot points across dpu driver to trigger dumps when critical errors are hit. changes in v5: - change the callers to use the snapshot function directly Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 16 +--- drivers/gpu/drm/msm/disp

[PATCH v5 3/7] drm/msm/dsi: add API to take DSI register snapshot

Add an API to take a snapshot of DSI controller registers. This API will be used by the msm_disp_snapshot module to capture the DSI snapshot. Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/dsi/dsi.c | 4 drivers/gpu/drm/msm/dsi/dsi.h | 5 - drivers/gpu/drm/msm/dsi

[PATCH] drm/msm/dp: Fix warnings reported by kbot in DP driver

Fix the warnings reported by kbot across MSM DP driver. Reported-by: kernel test robot Reported-by: Dan Carpenter Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/dp/dp_debug.c | 33 + drivers/gpu/drm/msm/dp/dp_hpd.c | 4 ++-- drivers/gpu/drm/msm/dp

[PATCH 2/3] drm/msm/dp: Fix incorrect NULL check kbot warnings in DP driver

Fix an incorrect NULL check reported by kbot in the MSM DP driver smatch warnings: drivers/gpu/drm/msm/dp/dp_hpd.c:37 dp_hpd_connect() error: we previously assumed 'hpd_priv->dp_cb' could be null (see line 37) Reported-by: kernel test robot Reported-by: Dan Carpenter Signed-of

[PATCH 1/3] drm/msm/dp: Fix indentation kbot warnings in DP driver

test robot Reported-by: Dan Carpenter Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/dp/dp_debug.c | 2 +- drivers/gpu/drm/msm/dp/dp_power.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_debug.c b/drivers/gpu/drm/msm/dp/dp_debug.c index

[PATCH 3/3] drm/msm/dp: delete unnecessary debugfs error handling

code. Also it silences the above Smatch warnings that we're checking for NULL when these functions only return error pointers. Reported-by: kernel test robot Reported-by: Dan Carpenter Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/dp/dp_debug.c | 31 ---

[PATCH v2] drm/msm/dpu: update the qos remap only if the client type changes

-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 17 +++-- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.h | 2 ++ 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c

[PATCH] drm/msm/dsi: add support for dsi test pattern generator

, it shall be applied on top of this change. Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/dsi/dsi.h | 3 ++ drivers/gpu/drm/msm/dsi/dsi.xml.h | 9 ++ drivers/gpu/drm/msm/dsi/dsi_host.c| 53 +++ drivers/gpu/drm/msm/dsi/dsi_manager.c | 13

[PATCH v2] drm/msm/dp: do not notify audio subsystem if sink doesn't support audio

pointer Fixes: d13e36d7d222 ("drm/msm/dp: add audio support for Display Port on MSM") Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/dp/dp_display.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/

[PATCH] drm/msm/dpu: update the qos remap only if the client type changes

Update the qos remap only if the client type changes for the plane. This will avoid unnecessary register programming and also avoid log spam from the dpu_vbif_set_qos_remap() function. Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 17 + drivers

Re: [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

Hi Suraj On 3/8/2022 6:30 AM, Kandpal, Suraj wrote: Hi Abhinav, Hi, Hi, Hi Abhinav, Hi Laurent Ok sure, I can take this up but I need to understand the proposal a little bit more before proceeding on this. So we will discuss this in another email where we specifically talk about the connec

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

On 3/10/2022 9:40 AM, Rob Clark wrote: On Thu, Mar 10, 2022 at 9:19 AM Sharma, Shashank wrote: On 3/10/2022 6:10 PM, Rob Clark wrote: On Thu, Mar 10, 2022 at 8:21 AM Sharma, Shashank wrote: On 3/10/2022 4:24 PM, Rob Clark wrote: On Thu, Mar 10, 2022 at 1:55 AM Christian König wrot

[PATCH 0/6] Allow drm_writeback_connector to accept pointer to drm_encoder

://patchwork.freedesktop.org/series/99724/ Abhinav Kumar (6): drm: allow real encoder to be passed for drm_writeback_connector drm/komeda: use drm_encoder pointer for drm_writeback_connector drm/vkms: use drm_encoder pointer for drm_writeback_connector drm/vc4: use drm_encoder pointer for

[PATCH 1/6] drm: allow real encoder to be passed for drm_writeback_connector

, allow real encoder to be passed for drm_writeback_connector. Co-developed-by: Kandpal Suraj Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/drm_writeback.c | 8 include/drm/drm_writeback.h | 13 +++-- 2 files changed, 15 insertions(+), 6 deletions(-) diff --git a/drivers

[PATCH 2/6] drm/komeda: use drm_encoder pointer for drm_writeback_connector

Make changes to komeda driver to start using drm_encoder pointer for drm_writeback_connector. Co-developed-by: Kandpal Suraj Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH 4/6] drm/vc4: use drm_encoder pointer for drm_writeback_connector

Make changes to vc4 driver to start using drm_encoder pointer for drm_writeback_connector. Co-developed-by: Kandpal Suraj Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/vc4/vc4_txp.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/vc4

[PATCH 5/6] drm/rcar_du: use drm_encoder pointer for drm_writeback_connector

Make changes to rcar_du driver to start using drm_encoder pointer for drm_writeback_connector. Co-developed-by: Kandpal Suraj Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/rcar-du/rcar_du_writeback.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rcar

[PATCH 3/6] drm/vkms: use drm_encoder pointer for drm_writeback_connector

Make changes to vkms driver to start using drm_encoder pointer for drm_writeback_connector. Co-developed-by: Kandpal Suraj Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/vkms/vkms_writeback.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vkms

[PATCH 6/6] drm/malidp: use drm_encoder pointer for drm_writeback_connector

Make changes to malidp driver to start using drm_encoder pointer for drm_writeback_connector. Co-developed-by: Kandpal Suraj Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/arm/malidp_mw.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/arm/malidp_mw.c b

Re: [PATCH 1/6] drm: allow real encoder to be passed for drm_writeback_connector

Hi Dmitry and Laurent On 3/11/2022 12:05 AM, Laurent Pinchart wrote: On Fri, Mar 11, 2022 at 10:46:13AM +0300, Dmitry Baryshkov wrote: On Fri, 11 Mar 2022 at 04:50, Abhinav Kumar wrote: For some vendor driver implementations, display hardware can be shared between the encoder used for

Re: [PATCH 5/6] drm/rcar_du: use drm_encoder pointer for drm_writeback_connector

Hi Laurent On 3/10/2022 11:28 PM, Laurent Pinchart wrote: Hi Abhinav Thank you for the patch. On Thu, Mar 10, 2022 at 05:49:59PM -0800, Abhinav Kumar wrote: Make changes to rcar_du driver to start using drm_encoder pointer for drm_writeback_connector. Co-developed-by: Kandpal Suraj Signed

[PATCH v2 0/6] Allow drm_writeback_connector to accept pointer to drm_encoder

://patchwork.freedesktop.org/series/99724/ changes in v2: - introduce a new API drm_writeback_connector_init_with_encoder() - allow passing possible_crtcs for existing users of drm_writeback_connector_init() Abhinav Kumar (6): drm: allow real encoder to be passed for drm_writeback_connector

[PATCH v2 2/6] drm/komeda: pass possible_crtcs as parameter for drm_writeback_connector

for drm_writeback_connector_init() Co-developed-by: Kandpal Suraj Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c b/drivers/gpu

[PATCH v2 1/6] drm: allow real encoder to be passed for drm_writeback_connector

initialized with it. changes in v2: - introduce a new API drm_writeback_connector_init_with_encoder() - allow passing possible_crtcs for existing users of drm_writeback_connector_init() Co-developed-by: Kandpal Suraj Signed-off-by: Abhinav Kumar --- drivers/gpu/drm

[PATCH v2 3/6] drm/vkms: pass possible_crtcs as parameter for drm_writeback_connector

drm_writeback_connector_init() Co-developed-by: Kandpal Suraj Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/vkms/vkms_writeback.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vkms/vkms_writeback.c b/drivers/gpu/drm/vkms/vkms_writeback.c index 8694227

[PATCH v2 6/6] drm/malidp: pass possible_crtcs as parameter for drm_writeback_connector

possible_crtcs parameter for drm_writeback_connector_init() Co-developed-by: Kandpal Suraj Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/arm/malidp_mw.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/arm/malidp_mw.c b/drivers/gpu/drm/arm/malidp_mw.c index f5847a7

[PATCH v2 5/6] drm/rcar_du: pass possible_crtcs as parameter for drm_writeback_connector

parameter for drm_writeback_connector_init() Co-developed-by: Kandpal Suraj Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/rcar-du/rcar_du_writeback.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rcar-du/rcar_du_writeback.c b/drivers/gpu/drm/rcar-du

[PATCH v2 4/6] drm/vc4: change vc4 driver to use drm_writeback_connector_init_with_encoder()

retained in the driver and there is no change in functionality. changes in v2: - make vc4 driver use drm_writeback_connector_init_with_encoder() Co-developed-by: Kandpal Suraj Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/vc4/vc4_txp.c | 30 -- 1 file changed, 24

Re: [PATCH 5/6] drm/rcar_du: use drm_encoder pointer for drm_writeback_connector

Hi Laurent Thank you for your inputs. I liked all the suggestions, hence I have incorporated those and pushed a v2. Thanks Abhinav On 3/13/2022 7:50 AM, Laurent Pinchart wrote: Hi Abhinav On Fri, Mar 11, 2022 at 09:47:17AM -0800, Abhinav Kumar wrote: On 3/10/2022 11:28 PM, Laurent

Re: [PATCH v3 4/5] drm/msm: stop using device's match data pointer

tead. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 10 --- drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 14 + drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 11 --- drivers/gpu/drm/msm/msm_d

Re: [PATCH v3 5/5] drm/msm: allow compile time selection of driver components

On 3/3/2022 7:21 PM, Dmitry Baryshkov wrote: MSM DRM driver already allows one to compile out the DP or DSI support. Add support for disabling other features like MDP4/MDP5/DPU drivers or direct HDMI output support. Suggested-by: Stephen Boyd Signed-off-by: Dmitry Baryshkov --- drivers/gp

Re: [PATCH v2 0/6] Allow drm_writeback_connector to accept pointer to drm_encoder

Hi Dmitry On 3/16/2022 12:40 AM, Dmitry Baryshkov wrote: Hi Abhinav, On 16/03/2022 02:11, Abhinav Kumar wrote: There are some vendor drivers for which the writeback encoder shares hardware resources such as clocks and interrupts with the rest of the display pipeline. In addition, there can be

Re: [Freedreno] [PATCH v3 5/5] drm/msm: allow compile time selection of driver components

On 3/16/2022 12:31 AM, Dmitry Baryshkov wrote: On 16/03/2022 03:28, Abhinav Kumar wrote: On 3/3/2022 7:21 PM, Dmitry Baryshkov wrote: MSM DRM driver already allows one to compile out the DP or DSI support. Add support for disabling other features like MDP4/MDP5/DPU drivers or direct HDMI

[PATCH v3 0/3] Allow drm_writeback_connector to accept pointer to drm_encoder

://patchwork.freedesktop.org/series/99724/ changes in v3: - squash the vendor changes into the same commit so that each patch in the series can compile individually Abhinav Kumar (3): drm: allow real encoder to be passed for drm_writeback_connector drm: introduce

[PATCH v3 1/3] drm: allow real encoder to be passed for drm_writeback_connector

-off-by: Abhinav Kumar --- .../drm/arm/display/komeda/komeda_wb_connector.c | 3 +- drivers/gpu/drm/arm/malidp_mw.c| 5 +- drivers/gpu/drm/drm_writeback.c| 103 + drivers/gpu/drm/rcar-du/rcar_du_writeback.c| 5 +- drivers

[PATCH v3 3/3] drm/vc4: change vc4 driver to use drm_writeback_connector_init_with_encoder()

retained in the driver and there is no change in functionality. changes in v3: - none Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/vc4/vc4_txp.c | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_txp.c b/drivers/gpu/drm/vc4

[PATCH v3 2/3] drm: introduce drm_writeback_connector_init_with_encoder API

an initialized encoder as a parameter and only sets up the writeback connector. Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/drm_writeback.c | 42 + include/drm/drm_writeback.h | 5 + 2 files changed, 47 insertions(+) diff --git a/drivers/gpu

Re: [PATCH 00/25] drm/msm/dpu: wide planes support

Hi Dmitry I have reviewed the series , some patches completely , some of them especially the plane to sspp mapping is something i still need to check. But I had one question on the design. I thought we were going to have a boot param to control whether driver will internally use both rectang

Re: [PATCH v3 1/3] drm: allow real encoder to be passed for drm_writeback_connector

Hi Laurent Thanks for the review. On 3/17/2022 1:51 AM, Laurent Pinchart wrote: Hi Abhinav, Thank you for the patch. On Wed, Mar 16, 2022 at 11:48:16AM -0700, Abhinav Kumar wrote: For some vendor driver implementations, display hardware can be shared between the encoder used for writeback

Re: [PATCH 1/6] drm: allow real encoder to be passed for drm_writeback_connector

Hi Daniel On 3/17/2022 3:01 AM, Daniel Vetter wrote: On Fri, Mar 11, 2022 at 10:05:53AM +0200, Laurent Pinchart wrote: On Fri, Mar 11, 2022 at 10:46:13AM +0300, Dmitry Baryshkov wrote: On Fri, 11 Mar 2022 at 04:50, Abhinav Kumar wrote: For some vendor driver implementations, display

[PATCH v4 0/4] Allow drm_writeback_connector to accept pointer to drm_encoder

://patchwork.freedesktop.org/series/99724/ changes in v4: - split the changes more according to functionality Abhinav Kumar (4): drm: allow passing possible_crtcs to drm_writeback_connector_init() drm: allow real encoder to be passed for drm_writeback_connector drm: introduce

[PATCH v4 3/4] drm: introduce drm_writeback_connector_init_with_encoder() API

an initialized encoder as a parameter and only sets up the writeback connector. changes in v4: - removed the possible_crtcs part Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/drm_writeback.c | 147 include/drm/drm_writeback.h | 5 ++ 2

[PATCH v4 1/4] drm: allow passing possible_crtcs to drm_writeback_connector_init()

. changes in v4: - keep only changes related to possible_crtcs - add line breaks after ARRAY_SIZE - stop using temporary variables for possible_crtcs Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c | 3 +-- drivers/gpu/drm/arm/malidp_mw.c

[PATCH v4 4/4] drm/vc4: change vc4 driver to use drm_writeback_connector_init_with_encoder()

retained in the driver and there is no change in functionality. changes in v4: - none Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/vc4/vc4_txp.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_txp.c b/drivers/gpu/drm/vc4

[PATCH v4 2/4] drm: allow real encoder to be passed for drm_writeback_connector

, allow real encoder to be passed for drm_writeback_connector. changes in v4: - split the possible_crtcs change and the parts which should belong to the addition of new API to the next change Co-developed-by: Kandpal Suraj Signed-off-by: Abhinav Kumar --- drivers/gpu/drm

Re: [PATCH v4 2/4] drm: allow real encoder to be passed for drm_writeback_connector

Hi Livid Thanks for your review. All your comments are valid. I think I should re-order the patches like you have suggested. That should address all comments. Thanks Abhinav On 3/21/2022 10:24 AM, Liviu Dudau wrote: On Thu, Mar 17, 2022 at 06:45:34PM -0700, Abhinav Kumar wrote: For some

Re: [PATCH v3 1/3] drm: allow real encoder to be passed for drm_writeback_connector

Hi Liviu On 3/21/2022 11:07 AM, Liviu Dudau wrote: On Thu, Mar 17, 2022 at 10:26:38AM -0700, Abhinav Kumar wrote: Hi Laurent Thanks for the review. On 3/17/2022 1:51 AM, Laurent Pinchart wrote: Hi Abhinav, Thank you for the patch. On Wed, Mar 16, 2022 at 11:48:16AM -0700, Abhinav Kumar

[PATCH v5 0/4] Allow drm_writeback_connector to accept pointer to drm_encoder

://patchwork.freedesktop.org/series/99724/ changes in v5: - re-order the series to make sure the encoder initialization is not broken due to incorrect order of changes Abhinav Kumar (4): drm: allow passing possible_crtcs to drm_writeback_connector_init() drm: introduce

[PATCH v5 1/4] drm: allow passing possible_crtcs to drm_writeback_connector_init()

. changes in v5: - None Signed-off-by: Abhinav Kumar Acked-by: Liviu Dudau --- drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c | 3 +-- drivers/gpu/drm/arm/malidp_mw.c | 4 ++-- drivers/gpu/drm/drm_writeback.c | 6 +- drivers/gpu/drm

[PATCH v5 2/4] drm: introduce drm_writeback_connector_init_with_encoder() API

drm_encoder * and switch it in next change Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/drm_writeback.c | 143 include/drm/drm_writeback.h | 5 ++ 2 files changed, 106 insertions(+), 42 deletions(-) diff --git a/drivers/gpu/drm/drm_writeback.c b/drivers

[PATCH v5 4/4] drm: allow real encoder to be passed for drm_writeback_connector

, allow real encoder to be passed for drm_writeback_connector. changes in v5: - re-order the change to come last in the series - rework necessary changes as part of the re-order Co-developed-by: Kandpal Suraj Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/drm_writeback.c | 12

[PATCH v5 3/4] drm/vc4: change vc4 driver to use drm_writeback_connector_init_with_encoder()

: - reorder this change to come before in the series to avoid incorrect sequence in subsequent changes - continue using struct drm_encoder instead of struct drm_encoder * and switch it in next change Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/vc4/vc4_txp.c | 30

Re: [PATCH v5 2/4] drm: introduce drm_writeback_connector_init_with_encoder() API

Hi Liviu Thanks for the review. On 3/23/2022 9:46 AM, Liviu Dudau wrote: On Mon, Mar 21, 2022 at 04:56:43PM -0700, Abhinav Kumar wrote: For vendors drivers which pass an already allocated and initialized encoder especially for cases where the encoder hardware is shared OR the writeback

Re: [PATCH 11/22] drm/msm: Use drm_mode_init() for on-stack modes

identifier M; expression E; @@ - struct drm_display_mode M = E; + struct drm_display_mode M; @@ identifier decl.M; expression decl.E; statement S, S1; @@ struct drm_display_mode M; ... when != S + drm_mode_init(&M, &E); + S1 @@ expression decl.E; @@ - &*E + E Cc: Rob Clark Cc: Sean P

Re: [PATCH 12/22] drm/msm: Use drm_mode_copy()

emcpy(&mode, E, S) + drm_mode_copy(&mode, E) ) @@ struct drm_display_mode *mode; @@ - &*mode + mode Cc: Rob Clark Cc: Sean Paul Cc: Abhinav Kumar Cc: linux-arm-...@vger.kernel.org Cc: freedr...@lists.freedesktop.org Signed-off-by: Ville Syrjälä Reviewed-by: Abhinav Kumar ---

Re: [PATCH 0/3] drm/msm/dp: simplify dp_connector_get_modes()

can be removed. This series removes dead weird code leaving dp_connector_get_modes() simple enough. [1] https://lore.kernel.org/linux-arm-msm/20220218100403.7028-11-ville.syrj...@linux.intel.com/ For the series, Reviewed-by: Abhinav Kumar *** BLURB HERE *** Dmitry Baryshkov (3): drm/msm

Re: [PATCH 00/22] drm: Review of mode copies

On 3/23/2022 3:39 AM, Dmitry Baryshkov wrote: On 22/03/2022 01:37, Ville Syrjälä wrote: On Tue, Mar 15, 2022 at 02:52:38PM -0400, Alex Deucher wrote: On Mon, Mar 14, 2022 at 6:12 PM Ville Syrjälä wrote: On Fri, Feb 18, 2022 at 12:03:41PM +0200, Ville Syrjala wrote:    drm: Add drm_mode_i

Re: [PATCH v5 2/4] drm: introduce drm_writeback_connector_init_with_encoder() API

Hi Liviu Thanks for the response. On 3/24/2022 3:12 AM, Liviu Dudau wrote: On Wed, Mar 23, 2022 at 11:28:56AM -0700, Abhinav Kumar wrote: Hi Liviu Hello, Thanks for the review. On 3/23/2022 9:46 AM, Liviu Dudau wrote: On Mon, Mar 21, 2022 at 04:56:43PM -0700, Abhinav Kumar wrote: For

Re: [PATCH] drm/msm/disp: check the return value of kzalloc()

: Abhinav Kumar --- drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c b/drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c index cabe151..369e57f 100644 --- a/drivers/gpu/drm/msm/disp

Re: [PATCH] drm/msm/mdp5: check the return of kzalloc()

: Abhinav Kumar --- drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c index c6b69af..5f914cc 100644 --- a/drivers/gpu/drm/msm

Re: [PATCH v5 2/4] drm: introduce drm_writeback_connector_init_with_encoder() API

Hi Liviu On 3/25/2022 3:19 AM, Liviu Dudau wrote: On Thu, Mar 24, 2022 at 09:36:50AM -0700, Abhinav Kumar wrote: Hi Liviu Hello, Thanks for the response. On 3/24/2022 3:12 AM, Liviu Dudau wrote: On Wed, Mar 23, 2022 at 11:28:56AM -0700, Abhinav Kumar wrote: Hi Liviu Hello, Thanks

Re: [PATCH v5 2/4] drm: introduce drm_writeback_connector_init_with_encoder() API

Hi Liviu Gentle reminder ... Can you please help to clarify the last set of questions so that I can work on the next version? Thanks Abhinav On 3/25/2022 9:31 AM, Abhinav Kumar wrote: Hi Liviu On 3/25/2022 3:19 AM, Liviu Dudau wrote: On Thu, Mar 24, 2022 at 09:36:50AM -0700, Abhinav

Re: [PATCH] drm: msm: add null pointer check

Seems to be a duplicate of https://patchwork.freedesktop.org/patch/479378/ Thanks Abhinav On 3/29/2022 3:34 AM, cgel@gmail.com wrote: From: Lv Ruyi kzalloc is a memory allocation function which can return NULL when some internal memory errors happen. Add null pointer check to avoid dere

Re: [PATCH 1/3] drm/msm/dpu: index dpu_kms->hw_vbif using vbif_idx

Assuming this series is newer and supersedes https://patchwork.freedesktop.org/patch/464353/?series=97307&rev=2, please check below. On 2/16/2022 7:45 PM, Dmitry Baryshkov wrote: Remove loops over hw_vbif. Instead always VBIF's idx as an index in the array. This fixes an error in dpu_kms_hw_in

Re: [PATCH 2/3] drm/msm/dpu: fix error handling around dpu_hw_vbif_init

IS_ERR_OR_NULL() call with IS_ERR(). Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c index

Re: [PATCH 3/3] drm/msm/dpu: drop VBIF indices

On 2/16/2022 7:45 PM, Dmitry Baryshkov wrote: We do not expect to have other VBIFs. Drop VBIF_n indices and always use VBIF_RT and VBIF_NRT. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 4 +-- drivers/gpu/drm/msm/disp

Re: [REPOST PATCH v4 08/13] drm/msm/disp/dpu1: Don't use DSC with mode_3d

On 2/16/2022 11:12 PM, Dmitry Baryshkov wrote: On 17/02/2022 09:33, Abhinav Kumar wrote: On 2/16/2022 10:10 PM, Vinod Koul wrote: On 16-02-22, 19:11, Abhinav Kumar wrote: On 2/10/2022 2:34 AM, Vinod Koul wrote: We cannot enable mode_3d when we are using the DSC. So pass configuration

Re: [Freedreno] [REPOST PATCH v4 08/13] drm/msm/disp/dpu1: Don't use DSC with mode_3d

On 2/18/2022 1:21 PM, Dmitry Baryshkov wrote: On 18/02/2022 23:46, Abhinav Kumar wrote: On 2/16/2022 11:12 PM, Dmitry Baryshkov wrote: On 17/02/2022 09:33, Abhinav Kumar wrote: On 2/16/2022 10:10 PM, Vinod Koul wrote: On 16-02-22, 19:11, Abhinav Kumar wrote: On 2/10/2022 2:34 AM

Re: [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

Hi Laurent Thanks for responding. On 2/21/2022 11:34 PM, Laurent Pinchart wrote: Hi Dmitry, On Tue, Feb 22, 2022 at 06:32:50AM +0300, Dmitry Baryshkov wrote: On Thu, 10 Feb 2022 at 07:59, Laurent Pinchart wrote: On Wed, Feb 09, 2022 at 05:40:29PM -0800, Abhinav Kumar wrote: Hi Laurent

Re: [Freedreno] [RFC PATCH v2 1/5] drm/msm/dp: fix panel bridge attachment

On 2/18/2022 6:26 PM, Dmitry Baryshkov wrote: On 19/02/2022 02:56, Stephen Boyd wrote: Quoting Dmitry Baryshkov (2022-02-11 14:40:02) In commit 8a3b4c17f863 ("drm/msm/dp: employ bridge mechanism for display enable and disable") the DP driver received a drm_bridge instance, which is always at

Re: [RFC PATCH v2 2/5] drm/msm/dp: support attaching bridges to the DP encoder

⇒ ptn3460 ⇒ THC63LVD1024 ⇒ DPI panel. - eDP encoder ⇒ LT8912 ⇒ DSI panel Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/dp/dp_display.c | 2 +- drivers/gpu/drm/msm/dp/dp_display.h | 2 +- drivers/gpu/drm/msm/dp/dp_drm.c | 4 ++-- drivers/gpu/drm/msm/dp

Re: [RFC PATCH v2 3/5] drm/msm/dp: support finding next bridge even for DP interfaces

On 2/11/2022 2:40 PM, Dmitry Baryshkov wrote: It is possible to supply display-connector (bridge) to the DP interface, add support for parsing it too. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_parser.c | 19 --- 1 file changed, 12 insertions(+), 7 delet

Re: [RFC PATCH v2 3/5] drm/msm/dp: support finding next bridge even for DP interfaces

On 2/24/2022 12:49 PM, Dmitry Baryshkov wrote: On Thu, 24 Feb 2022 at 23:13, Abhinav Kumar wrote: On 2/11/2022 2:40 PM, Dmitry Baryshkov wrote: It is possible to supply display-connector (bridge) to the DP interface, add support for parsing it too. Signed-off-by: Dmitry Baryshkov

Re: [Freedreno] [RFC PATCH v2 1/5] drm/msm/dp: fix panel bridge attachment

On 2/24/2022 12:41 PM, Dmitry Baryshkov wrote: On Thu, 24 Feb 2022 at 21:25, Abhinav Kumar wrote: On 2/18/2022 6:26 PM, Dmitry Baryshkov wrote: On 19/02/2022 02:56, Stephen Boyd wrote: Quoting Dmitry Baryshkov (2022-02-11 14:40:02) In commit 8a3b4c17f863 ("drm/msm/dp: employ b

Re: [Freedreno] [RFC PATCH v2 1/5] drm/msm/dp: fix panel bridge attachment

On 2/24/2022 8:22 PM, Dmitry Baryshkov wrote: On Fri, 25 Feb 2022 at 05:01, Abhinav Kumar wrote: On 2/24/2022 12:41 PM, Dmitry Baryshkov wrote: On Thu, 24 Feb 2022 at 21:25, Abhinav Kumar wrote: On 2/18/2022 6:26 PM, Dmitry Baryshkov wrote: On 19/02/2022 02:56, Stephen Boyd wrote

Re: [Freedreno] [RFC PATCH v2 1/5] drm/msm/dp: fix panel bridge attachment

On 2/25/2022 1:04 AM, Dmitry Baryshkov wrote: On Fri, 25 Feb 2022 at 07:45, Abhinav Kumar wrote: On 2/24/2022 8:22 PM, Dmitry Baryshkov wrote: On Fri, 25 Feb 2022 at 05:01, Abhinav Kumar wrote: On 2/24/2022 12:41 PM, Dmitry Baryshkov wrote: On Thu, 24 Feb 2022 at 21:25, Abhinav

Re: [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

Hi Suraj On 2/22/2022 10:17 PM, Kandpal, Suraj wrote: Hey, The connector/encoder funcs you do have to pass to drm_writeback_connector_init() can't use any of the shared driver infrastructure that assume a certain inheritance. See also my reply to Laurent [1]. It well might be that we all mi

Re: [PATCH] devcoredump: increase the device delete timeout to 10 mins

Hi Johannes and Greg On 2/12/2022 12:35 AM, Abhinav Kumar wrote: Hi Johannes On 2/12/2022 12:24 AM, Johannes Berg wrote: On Fri, 2022-02-11 at 23:52 -0800, Abhinav Kumar wrote: The thread is writing the data to a file in local storage. From our profiling, the read is the one taking the time

Re: [Freedreno] [RESEND PATCH] dt-bindings: display/msm: add missing brace in dpu-qcm2290.yaml

Reviewed-by: Abhinav Kumar --- Didn't include freedreno@ in the first email, so resending. --- Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.ya

Re: [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

On 2/28/2022 5:42 AM, Laurent Pinchart wrote: Hello, On Mon, Feb 28, 2022 at 02:28:27PM +0200, Laurent Pinchart wrote: On Mon, Feb 28, 2022 at 02:09:15PM +0200, Jani Nikula wrote: On Mon, 28 Feb 2022, Laurent Pinchart wrote: On Sat, Feb 26, 2022 at 10:27:59AM -0800, Rob Clark wrote: On We

Re: [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

On 3/2/2022 10:31 AM, Laurent Pinchart wrote: Hi Abhinav, On Wed, Mar 02, 2022 at 10:28:03AM -0800, Abhinav Kumar wrote: On 2/28/2022 5:42 AM, Laurent Pinchart wrote: On Mon, Feb 28, 2022 at 02:28:27PM +0200, Laurent Pinchart wrote: On Mon, Feb 28, 2022 at 02:09:15PM +0200, Jani Nikula

Re: [REPOST PATCH v4 02/13] drm/msm/dsi: Pass DSC params to drm_panel

On 2/21/2022 4:37 AM, Dmitry Baryshkov wrote: On 10/02/2022 13:34, Vinod Koul wrote: When DSC is enabled, we need to pass the DSC parameters to panel driver as well, so add a dsc parameter in panel and set it when DSC is enabled Also, fetch and pass DSC configuration for DSI panels to DPU en

Re: [PATCH 1/4] drm/msm: Update generated headers

On 3/3/2022 1:11 PM, Rob Clark wrote: On Thu, Mar 3, 2022 at 12:42 PM Abhinav Kumar wrote: Hi Rob On 3/3/2022 11:46 AM, Rob Clark wrote: From: Rob Clark Update headers from mesa commit: commit 7e63fa2bb13cf14b765ad06d046789ee1879b5ef Author: Rob Clark AuthorDate: Wed

Re: [PATCH 0/4] drm/msm/dpu: clearly document INTF_DP vs INTF_EDP difference

ns of this with both upstream and downstream drivers in mind. Overall, even though some members wanted to retain INTF_eDP for clarity, some members were fine removing its usage. Going with the majority and I have checked all the changes in this series, Hence: Reviewed-by: Abhinav Kumar Fo

  1   2   3   4   5   6   7   8   9   10   >