On 2012? 11? 20? 19:26, Maarten Lankhorst wrote:
> Op 20-11-12 02:03, ??? schreef:
>> Hi Maarten,
>>
>> On 2012? 11? 19? 19:27, Maarten Lankhorst wrote:
>>> Op 15-11-12 04:52, Seung-Woo Kim schreef:
Increasing ref counts of both dma-buf and gem for imported dma-buf
come from gem makes mem
Hi Rahul,
Control part seems good, and my comment is below.
On 2012? 11? 10? 01:21, Rahul Sharma wrote:
> This patch adds code for composing AVI and AUI info frames
> and send them every VSYNC.
>
> This patch is important for hdmi certification.
>
> Signed-off-by: Fahad Kunnathadi
> Signed-off
Hi Eunchul,
IMHO, each function for source and destination has quite similar routine
and it seems that there are some redundant code. I'm not sure these
duplicated code can be removed with mergeing similar part.
Some comments are below.
On 2012? 10? 29? 22:10, Eunchul Kim wrote:
> FIMC is stand
On 2012? 11? 21? 20:36, Rahul Sharma wrote:
> Hi Seung Woo,
>
> Thanks for your inputs. Please find my response below.
>
> On Wed, Nov 21, 2012 at 2:12 PM, ??? wrote:
>> Hi Rahul,
>>
>> Control part seems good, and my comment is below.
>>
>> On 2012? 11? 10? 01:21, Rahul Sharma wrote:
>>> This p
Hi Rahul,
I think this patch is almost ready just except few trivial check.
On 2012? 11? 22? 23:12, Rahul Sharma wrote:
> This patch adds code for composing AVI and AUI info frames
> and send them every VSYNC.
>
> This patch is important for hdmi certification.
>
> Based on exynos-drm-fixes bra
On 2012? 11? 23? 18:17, Rahul Sharma wrote:
> This patch adds code for composing AVI and AUI info frames
> and send them every VSYNC.
>
> This patch is important for hdmi certification.
>
> Signed-off-by: Rahul Sharma
> Signed-off-by: Fahad Kunnathadi
> Signed-off-by: Shirish S
Acked-by : Seu
Hi Mandeep,
On 2012? 09? 06? 06:47, Mandeep Singh Baines wrote:
> The double invocations are incorrect but seem to be safe so I don't
> think this will fix any bugs.
>
> Before:
>
> [7.639366] drm_prime_init_file ee3675d0
> [7.639377] drm_prime_init_file ee3675d0
> [7.639507] drm_pri
Hi Maarten,
On 2012년 11월 19일 19:27, Maarten Lankhorst wrote:
> Op 15-11-12 04:52, Seung-Woo Kim schreef:
>> Increasing ref counts of both dma-buf and gem for imported dma-buf
>> come from gem makes memory leak. release function of dma-buf cannot
>> be called because f_count of dma-buf increased by
On 2012년 11월 20일 19:26, Maarten Lankhorst wrote:
> Op 20-11-12 02:03, 김승우 schreef:
>> Hi Maarten,
>>
>> On 2012년 11월 19일 19:27, Maarten Lankhorst wrote:
>>> Op 15-11-12 04:52, Seung-Woo Kim schreef:
>>>> Increasing ref counts of both dma-buf and gem for
Hi Rahul,
Control part seems good, and my comment is below.
On 2012년 11월 10일 01:21, Rahul Sharma wrote:
> This patch adds code for composing AVI and AUI info frames
> and send them every VSYNC.
>
> This patch is important for hdmi certification.
>
> Signed-off-by: Fahad Kunnathadi
> Signed-off
On 2012년 11월 21일 20:36, Rahul Sharma wrote:
> Hi Seung Woo,
>
> Thanks for your inputs. Please find my response below.
>
> On Wed, Nov 21, 2012 at 2:12 PM, 김승우 wrote:
>> Hi Rahul,
>>
>> Control part seems good, and my comment is below.
>>
>> On 2012
Hi Rahul,
I think this patch is almost ready just except few trivial check.
On 2012년 11월 22일 23:12, Rahul Sharma wrote:
> This patch adds code for composing AVI and AUI info frames
> and send them every VSYNC.
>
> This patch is important for hdmi certification.
>
> Based on exynos-drm-fixes bra
On 2012년 11월 23일 18:17, Rahul Sharma wrote:
> This patch adds code for composing AVI and AUI info frames
> and send them every VSYNC.
>
> This patch is important for hdmi certification.
>
> Signed-off-by: Rahul Sharma
> Signed-off-by: Fahad Kunnathadi
> Signed-off-by: Shirish S
Acked-by : Seu
On 2012년 12월 07일 21:50, Wei Yongjun wrote:
> From: Wei Yongjun
>
> In case of error, function arm_iommu_create_mapping() returns
> ERR_PTR() and never returns NULL. The NULL test in the return
> value check should be replaced with IS_ERR().
>
> Signed-off-by: Wei Yongjun
> ---
> drivers/gpu/
Hi Dave,
On 2012년 12월 18일 15:30, Dave Airlie wrote:
> On Thu, Sep 27, 2012 at 4:30 PM, Seung-Woo Kim wrote:
>> Increasing ref counts of both dma-buf and gem for imported dma-buf come from
>> gem
>> makes memory leak. release function of dma-buf cannot be called because
>> f_count
>> of dma-buf
Hi Rahul,
On 2012년 12월 28일 16:01, Rahul Sharma wrote:
> There's no need to allocate edid twice and do a memcpy when drm helpers
> exist to do just that. This patch cleans that interaction up, and
> doesn't keep the edid hanging around in the connector.
Basically, I agree about this idea. But exyn
Hi Daniel,
On 2012년 08월 23일 17:50, Daniel Vetter wrote:
> On Wed, Aug 22, 2012 at 06:53:33PM +0530, Shirish S wrote:
>> From: Shirish Shankarappa
>>
>> The value of MAX_EDID is now valid only for 2
>> block EDID data which is 256, but to support
>> 4 block EDID (E-DDC) this needs to be 512.
>>
>
Hi Mandeep,
On 2012년 09월 06일 06:47, Mandeep Singh Baines wrote:
> The double invocations are incorrect but seem to be safe so I don't
> think this will fix any bugs.
>
> Before:
>
> [7.639366] drm_prime_init_file ee3675d0
> [7.639377] drm_prime_init_file ee3675d0
> [7.639507] drm_pri
Hi Rob,
On 2012년 09월 27일 15:52, Rob Clark wrote:
> fwiw, I had a similar patch:
>
> https://patchwork.kernel.org/patch/1229161/
Yes, I already check your patch and even my patch's title is a bit from
your patch.
I thought locking issue blocks your patch, so I sent simple fixes on
current state.
Hi Jani,
Sorry for late reply.
On 2012년 09월 27일 22:43, Jani Nikula wrote:
> On Thu, 27 Sep 2012, Seung-Woo Kim wrote:
>> Increasing ref counts of both dma-buf and gem for imported dma-buf come from
>> gem
>> makes memory leak. release function of dma-buf cannot be called because
>> f_count
>>
Hi Ville,
I skipped explanation about NV12M and other two formats because these
formats are already in kernel drm_fourcc.h.
I think it is better to add a difference between NV12 and NV12M here.
NV12M has Y plane and CbCr plane and these are in non contiguous memory
region. Compared with NV12, N
Hi Inki,
On 2013년 02월 05일 12:03, Inki Dae wrote:
> 2013/2/4 Sachin Kamat :
>> On 1 February 2013 18:28, Inki Dae wrote:
>>>
>>>
>>>
>>>
>>> 2013. 2. 1. 오후 8:52 Inki Dae 작성:
>>>
> -Original Message-
> From: linux-media-ow...@vger.kernel.org [mailto:linux-media-
> ow.
On 2013년 02월 06일 09:56, Sean Paul wrote:
> On Tue, Feb 5, 2013 at 4:42 PM, Stephen Warren wrote:
>> On 02/05/2013 05:37 PM, Sean Paul wrote:
>>> On Tue, Feb 5, 2013 at 4:22 PM, Stephen Warren
>>> wrote:
n 02/05/2013 04:42 PM, Sean Paul wrote:
> Use the compatible string in the device
On 2013년 02월 06일 17:51, Inki Dae wrote:
>
>
>> -Original Message-
>> From: Sachin Kamat [mailto:sachin.ka...@linaro.org]
>> Sent: Wednesday, February 06, 2013 5:03 PM
>> To: Inki Dae
>> Cc: linux-me...@vger.kernel.org; dri-devel@lists.freedesktop.org;
>> devicetree-disc...@lists.ozlabs.
On 2013년 03월 04일 23:05, Rahul Sharma wrote:
> Thanks Sean,
>
> On Wed, Feb 27, 2013 at 9:47 PM, Sean Paul wrote:
>> On Wed, Feb 27, 2013 at 8:22 AM, Rahul Sharma
>> wrote:
>>> Right now hdmiphy operations and configs are kept inside hdmi driver.
>>> hdmiphy related
>>> code is tightly couple
On 2013년 03월 07일 15:45, Rahul Sharma wrote:
> Thanks Seung Woo, Mr. Dae,
>
> On Thu, Mar 7, 2013 at 10:13 AM, Inki Dae wrote:
>> 2013/3/7 김승우 :
>>>
>>>
>>> On 2013년 03월 04일 23:05, Rahul Sharma wrote:
>>>> Thanks Sean,
>>>>
&g
Good point.
Acked-by: Seung-Woo Kim
On 2013년 03월 12일 04:25, Alexandru Gheorghiu wrote:
> Replaced calls to kzalloc followed by memcpy with call to kmemdup.
> Patch found using coccinelle.
>
> Signed-off-by: Alexandru Gheorghiu
> ---
> drivers/gpu/drm/exynos/exynos_drm_vidi.c |6 ++
>
Hello Rahul,
Thanks for notifying.
As your comment, it is same patch with yours, so just ignore my patch.
Besg Regards,
- Seung-Woo Kim
On 2013년 04월 26일 18:14, Rahul Sharma wrote:
> Hi Seung Woo,
>
> I had posted the same solution at
> http://lists.freedesktop.org/archives/dri-devel/2013-Janua
Hello Rahul,
I agree with basic idea of this patch.
However, to avoid confusion, how do you think about fixing all
check_timing as check_mode and its second parameter as mode including
struct exynos_drm_display_ops?
Regards,
- Seung-Woo Kim
On 2013년 04월 26일 23:03, Rahul Sharma wrote:
> Exynos h
Hello Rahul,
I looks good to me.
On 2013년 04월 29일 20:14, Rahul Sharma wrote:
> Exynos hdmi driver is using drm_display_mode for setting timing values
> for a supported resolution. Conversion to fb_videomode and then comparing
> with the mixer/hdmi/phy limits is not required. Instead, drm_display_
Good point,
On 2013년 05월 21일 02:32, Lars-Peter Clausen wrote:
> free_irq() expects the same pointer that was passed to request_threaded_irq(),
> otherwise the IRQ is not freed.
>
> The issue was found using the following coccinelle script:
>
>
> @r1@
> type T;
> T devid;
> @@
> request_threaded
Hello Daniel,
Thanks for your comment.
On 2013년 05월 31일 18:14, Daniel Vetter wrote:
> On Fri, May 31, 2013 at 10:54 AM, Seung-Woo Kim
> wrote:
>> importer private data in dma-buf attachment can be used by importer to
>> reimport same dma-buf.
>>
>> Seung-Woo Kim (2):
>> dma-buf: add importer
On 2013년 06월 01일 00:29, Daniel Vetter wrote:
> On Fri, May 31, 2013 at 07:22:24PM +0900, 김승우 wrote:
>> Hello Daniel,
>>
>> Thanks for your comment.
>>
>> On 2013년 05월 31일 18:14, Daniel Vetter wrote:
>>> On Fri, May 31, 2013 at 10:54 AM, Seung-Woo Kim
On 2013년 06월 04일 21:55, Daniel Vetter wrote:
> On Tue, Jun 04, 2013 at 07:42:22PM +0900, 김승우 wrote:
>>
>>
>> On 2013년 06월 01일 00:29, Daniel Vetter wrote:
>>> On Fri, May 31, 2013 at 07:22:24PM +0900, 김승우 wrote:
>>>> Hello Daniel,
>>>>
>&
Hello Maarten,
On 2013년 06월 05일 22:23, Maarten Lankhorst wrote:
> Op 31-05-13 10:54, Seung-Woo Kim schreef:
>> dma-buf attachment has only exporter private data, but importer private data
>> can be useful for importer especially to re-import the same dma-buf.
>> To use importer private data in att
On 2013년 06월 07일 20:24, Maarten Lankhorst wrote:
> Op 07-06-13 04:32, 김승우 schreef:
>> Hello Maarten,
>>
>> On 2013년 06월 05일 22:23, Maarten Lankhorst wrote:
>>> Op 31-05-13 10:54, Seung-Woo Kim schreef:
>>>> dma-buf attachment has only exporter pri
Hello Kishon,
On 2013년 06월 13일 21:54, Kishon Vijay Abraham I wrote:
> Hi,
>
> On Thursday 13 June 2013 04:51 PM, Inki Dae wrote:
>>
>>
>>> -Original Message-
>>> From: Sylwester Nawrocki [mailto:s.nawro...@samsung.com]
>>> Sent: Thursday, June 13, 2013 5:56 PM
>>> To: Rahul Sharma
>>> Cc:
Hello Rahul,
On 2013년 06월 11일 23:11, Rahul Sharma wrote:
> Exynos hdmi IP version is named after hdmi specification version i.e.
> 1.3 and 1.4. This versioning mechanism is not sufficient to handle
> the diversity in the hdmi/phy IPs which are present across the exynos
> SoC family.
>
> This patc
Hello Rahul,
This patch looks good to me just with mixer part of 2nd patch because
there is no hdmiphy related things.
On 2013년 06월 11일 23:11, Rahul Sharma wrote:
> Add support for exynos5420 mixer IP in the drm mixer driver.
>
> Signed-off-by: Rahul Sharma
> ---
> drivers/gpu/drm/exynos/exyno
Hello Rahul,
this patch is not related with others and it looks good to me.
On 2013년 06월 11일 23:11, Rahul Sharma wrote:
> Cleanup by removing flags variable from drm_hdmi_dt_parse_pdata
> which is not used anywhere. Swtiching to of_get_named_gpio instead
> of of_get_named_gpio_flags solved this.
Hi Rahul,
Code part looks good to me but IMHO, binding document for exynos_mixer
is also fixed like following because compitable string
samsung,exynos5420-mixer is added with this patch.
Required properties:
- compatible: value should be:
1) "samsung,exynos4210-mixer"
2) "samsun
Hi Rahul,
This patch looks good to me.
On 2013년 06월 18일 21:49, Rahul Sharma wrote:
> Modified code for calculating hdmi IP register values from drm timing
> values. The modification is based on the inputs from hw team and specifically
> proposed for 1440x576i and 1440x480i. But same changes holds
Hi Rahul,
It looks good, at least, to me.
Best Regards,
- Seung-Woo Kim
On 2013년 06월 18일 21:49, Rahul Sharma wrote:
> This patch renames the combatible strings for hdmi, mixer, ddc
> and hdmiphy. It follows the convention of using compatible string
> which represent the SoC in which the IP was a
On 2013년 06월 19일 15:50, Rahul Sharma wrote:
> Add support for exynos5420 mixer IP in the drm mixer driver.
>
> Signed-off-by: Rahul Sharma
Acked-by: Seung-Woo Kim
This patch can be merged after merging "[PATCH 1/4] drm/exynos: rename
compatible strings for hdmi subsystem".
Best Regards,
- Seu
Hello Rahul,
This patch is exactly same with v2 2/4 and only rebased on v3 1/3, so my
ack is valid for this patch.
On 2013년 06월 19일 21:51, Rahul Sharma wrote:
> Add support for exynos5420 mixer IP in the drm mixer driver.
>
> Signed-off-by: Rahul Sharma
Acked-by: Seung-Woo Kim
Anyway, this p
Hello, Chris,
On 2013년 06월 27일 17:31, Chris Wilson wrote:
> On Thu, Jun 27, 2013 at 08:58:33AM +0900, Seung-Woo Kim wrote:
>> From: YoungJun Cho
>>
>> If idr_alloc() is failed, obj->name can be error value. Also
>> it cleans up duplicated flink processing code.
>>
>> This regression has been intr
Hi Daniel,
On 2012? 08? 23? 17:50, Daniel Vetter wrote:
> On Wed, Aug 22, 2012 at 06:53:33PM +0530, Shirish S wrote:
>> From: Shirish Shankarappa
>>
>> The value of MAX_EDID is now valid only for 2
>> block EDID data which is 256, but to support
>> 4 block EDID (E-DDC) this needs to be 512.
>>
>
On 2012? 12? 07? 21:50, Wei Yongjun wrote:
> From: Wei Yongjun
>
> In case of error, function arm_iommu_create_mapping() returns
> ERR_PTR() and never returns NULL. The NULL test in the return
> value check should be replaced with IS_ERR().
>
> Signed-off-by: Wei Yongjun
> ---
> drivers/gpu/
Hi Dave,
On 2012? 12? 18? 15:30, Dave Airlie wrote:
> On Thu, Sep 27, 2012 at 4:30 PM, Seung-Woo Kim
> wrote:
>> Increasing ref counts of both dma-buf and gem for imported dma-buf come from
>> gem
>> makes memory leak. release function of dma-buf cannot be called because
>> f_count
>> of dma-b
Hi Rob,
On 2012? 09? 27? 15:52, Rob Clark wrote:
> fwiw, I had a similar patch:
>
> https://patchwork.kernel.org/patch/1229161/
Yes, I already check your patch and even my patch's title is a bit from
your patch.
I thought locking issue blocks your patch, so I sent simple fixes on
current state.
Hello Rahul,
Thanks for notifying.
As your comment, it is same patch with yours, so just ignore my patch.
Besg Regards,
- Seung-Woo Kim
On 2013? 04? 26? 18:14, Rahul Sharma wrote:
> Hi Seung Woo,
>
> I had posted the same solution at
> http://lists.freedesktop.org/archives/dri-devel/2013-Janua
Hello Rahul,
I agree with basic idea of this patch.
However, to avoid confusion, how do you think about fixing all
check_timing as check_mode and its second parameter as mode including
struct exynos_drm_display_ops?
Regards,
- Seung-Woo Kim
On 2013? 04? 26? 23:03, Rahul Sharma wrote:
> Exynos h
Hello Rahul,
I looks good to me.
On 2013? 04? 29? 20:14, Rahul Sharma wrote:
> Exynos hdmi driver is using drm_display_mode for setting timing values
> for a supported resolution. Conversion to fb_videomode and then comparing
> with the mixer/hdmi/phy limits is not required. Instead, drm_display_
Hi Inki,
On 2013? 02? 05? 12:03, Inki Dae wrote:
> 2013/2/4 Sachin Kamat :
>> On 1 February 2013 18:28, Inki Dae wrote:
>>>
>>>
>>>
>>>
>>> 2013. 2. 1. ?? 8:52 Inki Dae ??:
>>>
> -Original Message-
> From: linux-media-owner at vger.kernel.org [mailto:linux-media-
>
On 2013? 02? 06? 09:56, Sean Paul wrote:
> On Tue, Feb 5, 2013 at 4:42 PM, Stephen Warren
> wrote:
>> On 02/05/2013 05:37 PM, Sean Paul wrote:
>>> On Tue, Feb 5, 2013 at 4:22 PM, Stephen Warren
>>> wrote:
n 02/05/2013 04:42 PM, Sean Paul wrote:
> Use the compatible string in the devi
On 2013? 02? 06? 17:51, Inki Dae wrote:
>
>
>> -Original Message-
>> From: Sachin Kamat [mailto:sachin.kamat at linaro.org]
>> Sent: Wednesday, February 06, 2013 5:03 PM
>> To: Inki Dae
>> Cc: linux-media at vger.kernel.org; dri-devel at lists.freedesktop.org;
>> devicetree-discuss at l
Hi Rahul,
On 2012? 12? 28? 16:01, Rahul Sharma wrote:
> There's no need to allocate edid twice and do a memcpy when drm helpers
> exist to do just that. This patch cleans that interaction up, and
> doesn't keep the edid hanging around in the connector.
Basically, I agree about this idea. But exyn
Hi Ville,
I skipped explanation about NV12M and other two formats because these
formats are already in kernel drm_fourcc.h.
I think it is better to add a difference between NV12 and NV12M here.
NV12M has Y plane and CbCr plane and these are in non contiguous memory
region. Compared with NV12, NV
Hi Jani,
Sorry for late reply.
On 2012? 09? 27? 22:43, Jani Nikula wrote:
> On Thu, 27 Sep 2012, Seung-Woo Kim wrote:
>> Increasing ref counts of both dma-buf and gem for imported dma-buf come from
>> gem
>> makes memory leak. release function of dma-buf cannot be called because
>> f_count
>>
Hi Maarten,
On 2012? 11? 19? 19:27, Maarten Lankhorst wrote:
> Op 15-11-12 04:52, Seung-Woo Kim schreef:
>> Increasing ref counts of both dma-buf and gem for imported dma-buf
>> come from gem makes memory leak. release function of dma-buf cannot
>> be called because f_count of dma-buf increased by
Good point,
On 2013? 05? 21? 02:32, Lars-Peter Clausen wrote:
> free_irq() expects the same pointer that was passed to request_threaded_irq(),
> otherwise the IRQ is not freed.
>
> The issue was found using the following coccinelle script:
>
>
> @r1@
> type T;
> T devid;
> @@
> request_threaded
Hello Daniel,
Thanks for your comment.
On 2013? 05? 31? 18:14, Daniel Vetter wrote:
> On Fri, May 31, 2013 at 10:54 AM, Seung-Woo Kim
> wrote:
>> importer private data in dma-buf attachment can be used by importer to
>> reimport same dma-buf.
>>
>> Seung-Woo Kim (2):
>> dma-buf: add importer
On 2013? 06? 01? 00:29, Daniel Vetter wrote:
> On Fri, May 31, 2013 at 07:22:24PM +0900, ??? wrote:
>> Hello Daniel,
>>
>> Thanks for your comment.
>>
>> On 2013? 05? 31? 18:14, Daniel Vetter wrote:
>>> On Fri, May 31, 2013 at 10:54 AM, Seung-Woo Kim
>>> wrote:
importer private data in dma
On 2013? 06? 04? 21:55, Daniel Vetter wrote:
> On Tue, Jun 04, 2013 at 07:42:22PM +0900, ??? wrote:
>>
>>
>> On 2013? 06? 01? 00:29, Daniel Vetter wrote:
>>> On Fri, May 31, 2013 at 07:22:24PM +0900, ??? wrote:
Hello Daniel,
Thanks for your comment.
On 2013? 05? 31? 18:14
Hello Maarten,
On 2013? 06? 05? 22:23, Maarten Lankhorst wrote:
> Op 31-05-13 10:54, Seung-Woo Kim schreef:
>> dma-buf attachment has only exporter private data, but importer private data
>> can be useful for importer especially to re-import the same dma-buf.
>> To use importer private data in att
On 2013? 06? 07? 20:24, Maarten Lankhorst wrote:
> Op 07-06-13 04:32, ??? schreef:
>> Hello Maarten,
>>
>> On 2013? 06? 05? 22:23, Maarten Lankhorst wrote:
>>> Op 31-05-13 10:54, Seung-Woo Kim schreef:
dma-buf attachment has only exporter private data, but importer private
data
ca
Hello Kishon,
On 2013? 06? 13? 21:54, Kishon Vijay Abraham I wrote:
> Hi,
>
> On Thursday 13 June 2013 04:51 PM, Inki Dae wrote:
>>
>>
>>> -Original Message-
>>> From: Sylwester Nawrocki [mailto:s.nawrocki at samsung.com]
>>> Sent: Thursday, June 13, 2013 5:56 PM
>>> To: Rahul Sharma
>>>
Hello Rahul,
On 2013? 06? 11? 23:11, Rahul Sharma wrote:
> Exynos hdmi IP version is named after hdmi specification version i.e.
> 1.3 and 1.4. This versioning mechanism is not sufficient to handle
> the diversity in the hdmi/phy IPs which are present across the exynos
> SoC family.
>
> This patc
Hello Rahul,
This patch looks good to me just with mixer part of 2nd patch because
there is no hdmiphy related things.
On 2013? 06? 11? 23:11, Rahul Sharma wrote:
> Add support for exynos5420 mixer IP in the drm mixer driver.
>
> Signed-off-by: Rahul Sharma
> ---
> drivers/gpu/drm/exynos/exyno
Hello Rahul,
this patch is not related with others and it looks good to me.
On 2013? 06? 11? 23:11, Rahul Sharma wrote:
> Cleanup by removing flags variable from drm_hdmi_dt_parse_pdata
> which is not used anywhere. Swtiching to of_get_named_gpio instead
> of of_get_named_gpio_flags solved this.
Hi Rahul,
Code part looks good to me but IMHO, binding document for exynos_mixer
is also fixed like following because compitable string
samsung,exynos5420-mixer is added with this patch.
Required properties:
- compatible: value should be:
1) "samsung,exynos4210-mixer"
2) "samsun
Hi Rahul,
This patch looks good to me.
On 2013? 06? 18? 21:49, Rahul Sharma wrote:
> Modified code for calculating hdmi IP register values from drm timing
> values. The modification is based on the inputs from hw team and specifically
> proposed for 1440x576i and 1440x480i. But same changes holds
Hi Rahul,
It looks good, at least, to me.
Best Regards,
- Seung-Woo Kim
On 2013? 06? 18? 21:49, Rahul Sharma wrote:
> This patch renames the combatible strings for hdmi, mixer, ddc
> and hdmiphy. It follows the convention of using compatible string
> which represent the SoC in which the IP was a
On 2013? 06? 19? 15:50, Rahul Sharma wrote:
> Add support for exynos5420 mixer IP in the drm mixer driver.
>
> Signed-off-by: Rahul Sharma
Acked-by: Seung-Woo Kim
This patch can be merged after merging "[PATCH 1/4] drm/exynos: rename
compatible strings for hdmi subsystem".
Best Regards,
- Seu
Hello Rahul,
This patch is exactly same with v2 2/4 and only rebased on v3 1/3, so my
ack is valid for this patch.
On 2013? 06? 19? 21:51, Rahul Sharma wrote:
> Add support for exynos5420 mixer IP in the drm mixer driver.
>
> Signed-off-by: Rahul Sharma
Acked-by: Seung-Woo Kim
Anyway, this p
Hello, Chris,
On 2013? 06? 27? 17:31, Chris Wilson wrote:
> On Thu, Jun 27, 2013 at 08:58:33AM +0900, Seung-Woo Kim wrote:
>> From: YoungJun Cho
>>
>> If idr_alloc() is failed, obj->name can be error value. Also
>> it cleans up duplicated flink processing code.
>>
>> This regression has been intr
On 2013? 03? 04? 23:05, Rahul Sharma wrote:
> Thanks Sean,
>
> On Wed, Feb 27, 2013 at 9:47 PM, Sean Paul wrote:
>> On Wed, Feb 27, 2013 at 8:22 AM, Rahul Sharma
>> wrote:
>>> Right now hdmiphy operations and configs are kept inside hdmi driver.
>>> hdmiphy related
>>> code is tightly couple
On 2013? 03? 07? 15:45, Rahul Sharma wrote:
> Thanks Seung Woo, Mr. Dae,
>
> On Thu, Mar 7, 2013 at 10:13 AM, Inki Dae wrote:
>> 2013/3/7 ??? :
>>>
>>>
>>> On 2013? 03? 04? 23:05, Rahul Sharma wrote:
Thanks Sean,
On Wed, Feb 27, 2013 at 9:47 PM, Sean Paul wrote:
> On Wed, Fe
Good point.
Acked-by: Seung-Woo Kim
On 2013? 03? 12? 04:25, Alexandru Gheorghiu wrote:
> Replaced calls to kzalloc followed by memcpy with call to kmemdup.
> Patch found using coccinelle.
>
> Signed-off-by: Alexandru Gheorghiu
> ---
> drivers/gpu/drm/exynos/exynos_drm_vidi.c |6 ++
>
79 matches
Mail list logo
