Hi,
I have bisected a commit in v4.6 that fixes a freeze of the screen on
DPMS sleep:
777e3cbc791f131806d9bf24b3325637c7fc228d drm/radeon: Switch to drm_vblank_on/off
When running 'xset dpms force off' in a GNOME session (I tested this on
openSUSE Leap 42.2), sometimes the screen will freeze, s
Up until now, the bochsdrm driver didn't handle the nomodeset option
at boot, and didn't provide a "modeset" module option either.
This patch implements both.
The new parameter can be used by specifying bochs-drm.modeset=0
at boot time.
Signed-off-by: Max Staudt
Cc: Gerd
enough to ship the bochsdrm driver, and with the fbdev
emulation active.
In other words: Any modern distro's default setup will do.
Max Staudt
[PATCH 1/3] Add missing "goto out" after fbops->fb_open()
[PATCH 2/3] Define fb_open_adj_file()
[PATCH 3/3] Add fb_open_adj_file() to bochsdrmfb to avoid
From: Max Staudt
It doesn't make sense to execute any further actions after a failed
call to fbops->fb_open().
Signed-off-by: Max Staudt
---
drivers/video/fbdev/core/fbmem.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/core/fbmem.c b/drive
From: Max Staudt
This callback from fb_open() allows a fbdev driver to adjust things such
as file->f_mapping to better represent the internal structures.
This is needed to allow TTM drivers using ttm_fbdev_mmap() to properly
set file->f_mapping to TTM's address_space from bo->bde
From: Max Staudt
Currently, when using bochsdrm(fb), opening /dev/drm/card0 will adjust
file->f_mapping, but opening /dev/fb0 will not.
This may result in dangling pointers from user space when memory is
evicted, and therefore in use-after-free crashes when using the emulated
framebuffer dev
Hi Daniel,
Thanks for the feedback! Comments below:
On 05/23/2016 03:44 PM, Daniel Vetter wrote:
> Do we _really_ care about fbdev mmap support so much that we want to add
> more hacks all over the place (in each driver) to make it work? Given that
> fbdev is officially in the "no more drivers"
On 05/24/2016 06:51 PM, Daniel Vetter wrote:
> On Tue, May 24, 2016 at 6:28 PM, Max Staudt wrote:
>> Hi Daniel,
>>
>> Thanks for the feedback! Comments below:
>>
>>
>> On 05/23/2016 03:44 PM, Daniel Vetter wrote:
>>> Do we _really_ care abou
Thanks for CCing!
I like the idea of this patchset. As far as I understand, this multiplexing is
exactly what I would have had to write in order to port the bootsplash to DRM.
And we finally get rid of the driver-specific FB emulation hacks, too. Good
riddance.
Thanks for the initiative, Noral
Signed-off-by: Max Staudt
---
MAINTAINERS | 1 +
tools/bootsplash/.gitignore | 1 +
tools/bootsplash/Makefile| 9 +
tools/bootsplash/bootsplash-packer.c | 471 +++
4 files changed, 482 insertions(+)
create mode
Signed-off-by: Max Staudt
Reviewed-by: Oliver Neukum
---
drivers/video/fbdev/core/fbcon.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
index 9a39a6fcfe98..8a9c67e1c5d8 100644
--- a/drivers/video/fbdev/core
Let's disable the splash if the user presses ESC or F1-F12 on a VT.
The F1-F12 check is to disable the splash on VT switches.
Signed-off-by: Max Staudt
---
drivers/tty/vt/keyboard.c | 24
1 file changed, 24 insertions(+)
diff --git a/drivers/tty/vt/keyboar
. Enable splash
3. Start X (or any other KD_GRAPHICS program)
4. Exit X
5. Splash is not seen, apart from animations
Signed-off-by: Max Staudt
Reviewed-by: Oliver Neukum
---
drivers/tty/vt/vt.c | 2 ++
drivers/video/fbdev/core/bootsplash.c | 15 +--
include/linux
When the user requests a clean TTY via the SAK SysRq, that means he
really wants to use the console.
Let's disable the bootsplash, even if the request is not on a VT, as
the user probably knows what he's doing and it's more helpful to get
out of his way.
Signed-off-by: Max Stau
f_bonding.h
+BOOTSPLASH
+M: Max Staudt
+L: linux-fb...@vger.kernel.org
+S: Maintained
+F: drivers/video/fbdev/core/bootsplash*.*
+F: drivers/video/fbdev/core/dummycon.c
+F: include/linux/bootsplash.h
+
BPF (Safe dynamic programs and tools)
M: Alexei Starovoitov
M: D
Signed-off-by: Max Staudt
---
.../ABI/testing/sysfs-platform-bootsplash | 11 +
Documentation/bootsplash.rst | 285 +
MAINTAINERS| 2 +
3 files changed, 298 insertions(+)
create mode 100644
Dear fbdev/fbcon/dri developers,
Thanks for all the valuable feedback.
I've looked into the suggestions you made, and found that it doesn't
currently make sense to continue working on the splash code, given the
low practical interest I've received on LKML. The code is, and always
has been, intend
*
and tell the kernel to use it as follows:
bootsplash.bootfile=mypath/myfile
Since the splash code is using request_firmware() to load the file,
the path has to be beneath /lib/firmware.
Signed-off-by: Max Staudt
---
MAINTAINERS| 1 +
drivers/video/
Also, mention this in the bootsplash documentation.
Signed-off-by: Max Staudt
---
Documentation/bootsplash.rst | 10 ++
tools/bootsplash/.gitignore| 3 ++
tools/bootsplash/ajax-loader.gif | Bin 0 -> 3208 bytes
tools/bootsplash/bootsplash-tux.sh |
ame rate. It doesn't really make sense to animate
more than one object at a time anyway.
Furthermore, this patch introduces a check for reusing a framebuffer
where the splash has recently been painted on - in this case, we only
redraw the objects that are animated.
Signed-off-by: Max S
h is shown whenever fbcon would show a text console
(i.e. no graphical application is running), and a splash
file is loaded.
+
+What: /sys/devices/platform/bootsplash.0/drop_splash
+Date: Oct 2017
+KernelVersion: 4.14
+Contact:
This allows showing multiple logos, each in its own position,
relative to the eight screen corners.
Signed-off-by: Max Staudt
---
drivers/video/fbdev/core/bootsplash_render.c | 136 ++-
include/uapi/linux/bootsplash_file.h | 45 -
2 files changed, 178
interface - we also match some known ones,
currently:
- ast
- cirrus
- mgag200
Signed-off-by: Max Staudt
Reviewed-by: Oliver Neukum
---
drivers/video/fbdev/core/bootsplash.c | 2 ++
drivers/video/fbdev/core/bootsplash_internal.h | 1 +
drivers/video/fbdev/core/bootsplash_render.c | 33
This allows showing multiple logos, each in its own position,
relative to the eight screen corners.
Signed-off-by: Max Staudt
---
drivers/video/fbdev/core/bootsplash_render.c | 136 ++-
include/uapi/linux/bootsplash_file.h | 45 -
2 files changed, 178
. Enable splash
3. Start X (or any other KD_GRAPHICS program)
4. Exit X
5. Splash is not seen, apart from animations
Signed-off-by: Max Staudt
Reviewed-by: Oliver Neukum
---
drivers/tty/vt/vt.c | 2 ++
drivers/video/fbdev/core/bootsplash.c | 15 +--
include/linux
driver
cannot reserve its VRAM.
- Simplification of userspace integration:
Right now, hooking up a splash screen in userspace is quite complex.
Having it in the kernel makes this a breeze, as hooks for
switch_root, remounting r/w, etc. become obsolete.
Signed-off-by: Max
Signed-off-by: Max Staudt
Reviewed-by: Oliver Neukum
---
drivers/video/fbdev/core/fbcon.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
index 9a39a6fcfe98..8a9c67e1c5d8 100644
--- a/drivers/video/fbdev/core
Dear fbdev and fbcon developers,
Thank you very much for your input for the first patch series.
I've included your feedback into this second roll, and kindly ask for
your opinion on the new patch series.
Changes from v1 to v2:
+ Added a user space tool to create splash theme files
+ Bumped t
Signed-off-by: Max Staudt
---
.../ABI/testing/sysfs-platform-bootsplash | 11 ++
Documentation/bootsplash.rst | 177 +
MAINTAINERS| 2 +
3 files changed, 190 insertions(+)
create mode 100644
Also, mention this in the bootsplash documentation.
Signed-off-by: Max Staudt
---
Documentation/bootsplash.rst | 10 ++
tools/bootsplash/.gitignore| 3 ++
tools/bootsplash/ajax-loader.gif | Bin 0 -> 3208 bytes
tools/bootsplash/bootsplash-tux.sh |
ame rate. It doesn't really make sense to animate
more than one object at a time anyway.
Furthermore, this patch introduces a check for reusing a framebuffer
where the splash has recently been painted on - in this case, we only
redraw the objects that are animated.
Signed-off-by: Max S
interface - we also match some known ones,
currently:
- ast
- cirrus
- mgag200
Signed-off-by: Max Staudt
Reviewed-by: Oliver Neukum
---
drivers/video/fbdev/core/bootsplash.c | 2 ++
drivers/video/fbdev/core/bootsplash_internal.h | 1 +
drivers/video/fbdev/core/bootsplash_render.c | 33
Load logo(s) from a file and render them in the center of the screen.
This removes the "black screen" functionality, which can now be emulated
by providing a splash file with no pictures and a black background.
Signed-off-by: Max Staudt
---
MAINTAINERS
Let's disable the splash if the user presses ESC or F1-F12 on a VT.
The F1-F12 check is to disable the splash on VT switches.
Signed-off-by: Max Staudt
---
drivers/tty/vt/keyboard.c | 24
1 file changed, 24 insertions(+)
diff --git a/drivers/tty/vt/keyboar
Signed-off-by: Max Staudt
---
MAINTAINERS | 1 +
tools/bootsplash/.gitignore | 1 +
tools/bootsplash/Makefile| 9 +
tools/bootsplash/bootsplash-packer.c | 471 +++
4 files changed, 482 insertions(+)
create mode
When the user requests a clean TTY via the SAK SysRq, that means he
really wants to use the console.
Let's disable the bootsplash, even if the request is not on a VT, as
the user probably knows what he's doing and it's more helpful to get
out of his way.
Signed-off-by: Max Stau
h is shown whenever fbcon would show a text console
(i.e. no graphical application is running), and a splash
file is loaded.
+
+What: /sys/devices/platform/bootsplash.0/drop_splash
+Date: Oct 2017
+KernelVersion: 4.14
+Contact:
Unfortunately I've forgotten to rebase this patchset to 4.15, so it still
builds on top of 4.14.
I'll rebase it for the next roll.
Max
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
On 12/13/2017 10:35 PM, Daniel Vetter wrote:
> Using drm directly would allow you to flush the contents without the fake
> (and tbh, really expensive on most drivers) copy op. If you insist on
> using fbdev for this stuff, then at least add a new hook to flush cpu
> rendering.
My reasoning is as f
On 12/14/2017 12:55 AM, Randy Dunlap wrote:
> On 12/13/2017 11:47 AM, Max Staudt wrote:
>> This is the initial prototype for a lean Linux kernel bootsplash.
>>
>> As it is now, it will show a black screen rather than a logo, and
>> only if manually ena
On 12/19/2017 01:23 PM, Daniel Vetter wrote:
> On Thu, Dec 14, 2017 at 04:36:49PM +0100, Max Staudt wrote:
>> 2) We need to go out of the way when a graphical application starts, and
>> come back when it's done. fbcon already has the logic for this, and
>> fbcon is also
On 12/19/2017 02:57 PM, Daniel Vetter wrote:
> Where do drivers deal with struct file deep down?
As an example, I remembered this to be the case in nouveau's code for
allocating a framebuffer. So I checked, and it's much better now.
So I was mistaken about this - sorry.
Thanks a lot for cleanin
On 12/19/2017 05:02 PM, Daniel Vetter wrote:
> On Tue, Dec 19, 2017 at 4:41 PM, Max Staudt wrote:
>> On 12/19/2017 02:57 PM, Daniel Vetter wrote:
>>> The problem is that defio is totally not how a real driver works.
>>
>> But they do exist and I can't ig
On 12/19/2017 05:09 PM, Daniel Vetter wrote:
> btw the reason drmcon didn't move is that David Herrmann moved on from
> hacking on graphics stuff, and no one needs it. There's nothing
> fundamentally wrong with his patches for a basic emergency console on
> plain drm, or the simpledrm driver to get
On 12/19/2017 05:16 PM, Daniel Vetter wrote:
> On Wed, Dec 13, 2017 at 08:47:42PM +0100, Max Staudt wrote:
>> Dear fbdev and fbcon developers,
>>
>> Thank you very much for your input for the first patch series.
>>
>> I've included your feedback into this s
On 12/19/2017 06:26 PM, Daniel Vetter wrote:
> On Tue, Dec 19, 2017 at 6:04 PM, Max Staudt wrote:
>> Well, those could enable fbcon if they want the bootsplash. Shouldn't make a
>> difference anyway if they're powerful enough to run Linux. As long as the
>> bootsp
On 12/19/2017 09:30 PM, Ray Strode wrote:
> Hi,
>
>> For example, having a userspace splash that starts as early as it can
>> (thus on vesafb/efifb on a PC) will cause the KMS driver to fail
>> reserving the entirety of video RAM, and thus fail loading. This cannot be
>> fixed.
> well the fix the
On 12/19/2017 10:01 PM, Ray Strode wrote:
> Hi,
>
> On Tue, Dec 19, 2017 at 10:41 AM, Max Staudt wrote:
>> I'm hooking into the in-kernel terminal emulator, because the bootsplash is a
>> functional extension of that. It just happens that fbcon sits on top of FB,
>&
On 12/20/2017 10:43 AM, Daniel Vetter wrote:
> On Tue, Dec 19, 2017 at 07:40:12PM +0100, Max Staudt wrote:
>> On 12/19/2017 06:26 PM, Daniel Vetter wrote:
>>> So essentially you're telling me that on a current general purpose
>>> distro the gfx driver loading is a
On 12/20/2017 11:06 AM, Neil Armstrong wrote:
> My 2cents about this patchset:
> You did a good job about all the animation and splash logic, but for me all
> this fbcon
> stuff is a huge hack, please use a standard and modern display subsystem en
> leave fbcon
> die alone
Thanks for the com
On 12/20/2017 11:14 AM, Daniel Vetter wrote:
> btw since I'm probably sounding a bit too grumpy here: I'd very much
> support this. I think bootsplash in kernel has a bunch of uses, and it
> shouldn't be hard to get non-suse people to cheer for it (makes merging
> easier if it's not just a one-off
On 12/20/2017 04:11 PM, Daniel Vetter wrote:
> So fundamentally I don't think an in-kernel bootsplash is a bad idea.
> But most likely you want this on a highly embedded system, which
> probably is compiled for your exact hw, with pretty much everything
> built in. Also, no fbcon, maybe even no vt
On 12/20/2017 04:19 PM, Daniel Vetter wrote:
> On Wed, Dec 20, 2017 at 4:11 PM, Daniel Vetter wrote:
>> On Wed, Dec 20, 2017 at 3:55 PM, Max Staudt wrote:
>>> On 12/20/2017 11:14 AM, Daniel Vetter wrote:
>>>> btw since I'm probably sounding a bit too grumpy he
On 12/20/2017 04:21 PM, Ray Strode wrote:
> If we've reached the scenario you're discussing above, the real
> failure is that the KMS
> driver took too long to load. DRM is the platform graphics api. If
> it's not loading
> timely enough to show graphics then that's the problem! It sounds
> like
On 12/20/2017 04:35 PM, Ray Strode wrote:
> Hi,
>
>> Actually, I don't want that :)
>>
>> This was a design decision that I've made to keep the code small and simple
>> to audit.
>> As it is, the simple bootsplash code will make 99% of people happy.
> You think only 1% of linux users have more th
On 12/21/2017 03:51 PM, Ray Strode wrote:
> Hi,
>
> On Wed, Dec 20, 2017 at 11:44 AM Max Staudt wrote:
>> It'd be nice to see this bug fixed, as it happens only occasionally (as is
>> the nature of a
>> race condition), and was thus really hard to debug. I'
On 12/21/2017 10:48 AM, Daniel Vetter wrote:
> Ok, here's my expectation:
>
> - fix plymouth and driver loading
>
> If the plymouth maintainer tells me that's impossible, I'll look at this
> again. And no, this does not require killing drivers with SIGBUS, at least
> not with drm. Meanwhile I don
On 12/29/2017 06:13 PM, Jani Nikula wrote:
> I think the first issue is the boot manager (e.g. grub) messing up
> whatever the BIOS or GOP or whatever drew. If I don't touch any buttons,
> I'd prefer the Lenovo or VAIO or NUC or whatever logo stay there. IIRC
> some BIOSes let you set up your own s
On 12/31/2017 01:35 PM, Alan Cox wrote:
> For embedded every KB counts. That is likely to remain the same for some
> time because at the end of the day small devices are constrained about the
> amount of SRAM you can put on die and the amount of power you can afford
> for DRAM.
Fascinating, thank
On 12/31/2017 01:44 PM, Alan Cox wrote:
>> So fundamentally I don't think an in-kernel bootsplash is a bad idea.
>> But most likely you want this on a highly embedded system, which
>
> It wouldn't be in kernel on such a device, it'll be in the bootstrap
> before (or on a dual core device quite pos
On 12/31/2017 01:53 PM, Alan Cox wrote:
> On Tue, 19 Dec 2017 15:07:53 +0100
> Oliver Neukum wrote:
>
>> Am Dienstag, den 19.12.2017, 14:57 +0100 schrieb Daniel Vetter:
Would you like me to extend the FB API or not?
>>>
>>> Yes. Well for real I'd like you to do kms, so maybe you need to ex
61 matches
Mail list logo
