Re: [PATCH v2] Documentation: dma-buf: heaps: Add naming guidelines

2025-07-10 Thread Maxime Ripard
On Wed, Jul 09, 2025 at 12:39:15PM -0500, Andrew Davis wrote: > On 6/16/25 10:21 AM, Maxime Ripard wrote: > > We've discussed a number of times of how some heap names are bad, but > > not really what makes a good heap name. > > > > Let's document what we expect the heap names to look like. > > >

Re: [PATCH 2/9] drm/bridge: add drm_bridge_chain_get_last_bridge()

2025-07-10 Thread Maxime Ripard
On Wed, 9 Jul 2025 18:48:01 +0200, Luca Ceresoli wrote: > Add an equivalent of drm_bridge_chain_get_first_bridge() to get the last > bridge. > > Signed-off-by: Luca Ceresoli Reviewed-by: Maxime Ripard Thanks! Maxime

Re: [PATCH 3/9] drm/bridge: imx93-mipi-dsi: use drm_bridge_chain_get_last_bridge()

2025-07-10 Thread Maxime Ripard
On Wed, 9 Jul 2025 18:48:02 +0200, Luca Ceresoli wrote: > Use drm_bridge_chain_get_last_bridge() instead of open coding a loop with > two invocations of drm_bridge_get_next_bridge() per iteration. > > Besides being cleaner and more efficient, this change is necessary in > preparation for drm_bridg

Re: [PATCH 4/9] drm/omapdrm: use drm_bridge_chain_get_last_bridge()

2025-07-10 Thread Maxime Ripard
On Wed, Jul 09, 2025 at 06:48:03PM +0200, Luca Ceresoli wrote: > Use drm_bridge_chain_get_last_bridge() instead of open coding a loop with > two invocations of drm_bridge_get_next_bridge() per iteration. > > Besides being cleaner and more efficient, this change is necessary in > preparation for dr

Re: [PATCH 7/9] drm/bridge: get the bridge returned by drm_bridge_get_next_bridge()

2025-07-10 Thread Maxime Ripard
On Wed, 9 Jul 2025 18:48:06 +0200, Luca Ceresoli wrote: > drm_bridge_get_next_bridge() returns a bridge pointer that the > caller could hold for a long time. Increment the refcount of the returned > bridge and document it must be put by the caller. > > Signed-off-by: Luca Ceresoli > > [ ... ] R

Re: [PATCH 6/9] drm/display: bridge_connector: use drm_bridge_is_last()

2025-07-10 Thread Maxime Ripard
On Wed, 9 Jul 2025 18:48:05 +0200, Luca Ceresoli wrote: > Simplify code to know whether a bridge is the last in the chain by using > drm_bridge_is_last(). > > Signed-off-by: Luca Ceresoli Reviewed-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v3 2/3] drm/amdgpu: Reset the clear flag in buddy during resume

2025-07-10 Thread Arunpravin Paneer Selvam
On 7/8/2025 2:30 PM, Matthew Auld wrote: On 08/07/2025 07:54, Arunpravin Paneer Selvam wrote: - Added a handler in DRM buddy manager to reset the cleared    flag for the blocks in the freelist. - This is necessary because, upon resuming, the VRAM becomes    cluttered with BIOS data, yet the V

Re: [PATCH 5/9] drm/bridge: add drm_bridge_is_last()

2025-07-10 Thread Maxime Ripard
On Wed, 9 Jul 2025 18:48:04 +0200, Luca Ceresoli wrote: > Some code needing to know whether a bridge is the last in a chain currently > call drm_bridge_get_next_bridge(). However drm_bridge_get_next_bridge() > will soon increment the refcount of the returned bridge, which would make > such code mor

Re: [PATCH 3/3] drm/bridge: display-connector: put the bridge obtained by drm_bridge_get_prev_bridge()

2025-07-10 Thread Maxime Ripard
On Wed, 9 Jul 2025 17:59:39 +0200, Luca Ceresoli wrote: > The bridge returned by drm_bridge_get_prev_bridge() is refcounted. Put it > when done. > > To keep the code clean and future-proof use a scope-based free. > > > [ ... ] Reviewed-by: Maxime Ripard Thanks! Maxime

Re: [PATCH 2/3] drm/bridge: select_bus_fmt_recursive(): put the bridge obtained by drm_bridge_get_prev_bridge()

2025-07-10 Thread Maxime Ripard
On Wed, 9 Jul 2025 17:59:38 +0200, Luca Ceresoli wrote: > The bridge returned by drm_bridge_get_prev_bridge() is refcounted. Put it > when done. > > select_bus_fmt_recursive() has several return points, and ensuring > drm_bridge_put() is always called in the right place would be error-prone > > [

RE: [PATCH 1/2] clk: renesas: rzg2l: Remove DSI clock rate restrictions

2025-07-10 Thread Biju Das
Hi Chris Brandt, Thanks for the patch. > -Original Message- > From: Chris Brandt > Sent: 09 July 2025 21:56 > Subject: [PATCH 1/2] clk: renesas: rzg2l: Remove DSI clock rate restrictions > > Convert the limited MIPI clock calculations to a full range of settings based > on math includi

Re: [PATCH 2/3] drm/sitronix/st7571-i2c: Make the reset GPIO to be optional

2025-07-10 Thread Marcus Folkesson
On Thu, Jul 10, 2025 at 12:24:34PM +0200, Javier Martinez Canillas wrote: > Some Sitronix LCD controllers (such as the ST7567) don't have a reset pin, > so lets relax this in the driver and make the reset GPIO to be optional. > > The devm_gpiod_get_optional() helper is similar to devm_gpiod_get(),

Re: [PATCH v4 1/9] drm: Add a vendor-specific recovery method to device wedged uevent

2025-07-10 Thread Raag Jadav
On Thu, Jul 10, 2025 at 11:37:14AM +0200, Christian König wrote: > On 10.07.25 11:01, Simona Vetter wrote: > > On Wed, Jul 09, 2025 at 12:52:05PM -0400, Rodrigo Vivi wrote: > >> On Wed, Jul 09, 2025 at 05:18:54PM +0300, Raag Jadav wrote: > >>> On Wed, Jul 09, 2025 at 04:09:20PM +0200, Christian Kön

[PATCH 0/3] drm/sitronix/st7571-i2c: Add support for the ST7567 Controller

2025-07-10 Thread Javier Martinez Canillas
This patch-series adds support for the Sitronix ST7567 Controller, which is is a monochrome Dot Matrix LCD Controller that has SPI, I2C and parallel interfaces. The st7571-i2c driver only has support for I2C so displays using other transport interfaces are currently not supported. The DRM_FORMAT_

[PATCH 1/3] dt-bindings: display: Add Sitronix ST7567 LCD Controller

2025-07-10 Thread Javier Martinez Canillas
Sitronix ST7567 is a monochrome Dot Matrix LCD Controller. Signed-off-by: Javier Martinez Canillas --- .../bindings/display/sitronix,st7567.yaml | 63 +++ MAINTAINERS | 1 + 2 files changed, 64 insertions(+) create mode 100644 Documentati

[PATCH 2/3] drm/sitronix/st7571-i2c: Make the reset GPIO to be optional

2025-07-10 Thread Javier Martinez Canillas
Some Sitronix LCD controllers (such as the ST7567) don't have a reset pin, so lets relax this in the driver and make the reset GPIO to be optional. The devm_gpiod_get_optional() helper is similar to devm_gpiod_get(), but returns NULL when there isn't a reset-gpios property defined in a DT node. T

[PATCH 3/3] drm/sitronix/st7571-i2c: Add support for the ST7567 Controller

2025-07-10 Thread Javier Martinez Canillas
The Sitronix ST7567 is a monochrome Dot Matrix LCD Controller that has SPI, I2C and parallel interfaces. The st7571-i2c driver only has support for I2C so displays using other transport interfaces are currently not supported. The DRM_FORMAT_R1 pixel format and data commands are the same than what

Re: [PATCH] drm/dp: Change AUX DPCD probe address from LANE0_1_STATUS to TRAINING_PATTERN_SET

2025-07-10 Thread Imre Deak
Hi Thomas, Maxime, Maarten, the patch this change fixes (commit a40c5d727b81) was merged via drm-intel and is also part of v6.16-rc4 (there cherry-picked in commit a3ef3c2da675). Are you ok with merging this fix via drm-intel as well, so that it could be still merged to v6.16 before that's releas

Re: [PATCH v3 3/8] x86, lib: Add WBNOINVD helper functions

2025-07-10 Thread Borislav Petkov
On Thu, May 22, 2025 at 04:37:27PM -0700, Sean Christopherson wrote: > diff --git a/arch/x86/lib/cache-smp.c b/arch/x86/lib/cache-smp.c > index 079c3f3cd32c..1789db5d8825 100644 > --- a/arch/x86/lib/cache-smp.c > +++ b/arch/x86/lib/cache-smp.c > @@ -19,3 +19,14 @@ void wbinvd_on_all_cpus(void) >

Re: [PATCH v3 2/3] drm/amdgpu: Reset the clear flag in buddy during resume

2025-07-10 Thread Matthew Auld
On 10/07/2025 08:14, Arunpravin Paneer Selvam wrote: On 7/8/2025 2:30 PM, Matthew Auld wrote: On 08/07/2025 07:54, Arunpravin Paneer Selvam wrote: - Added a handler in DRM buddy manager to reset the cleared    flag for the blocks in the freelist. - This is necessary because, upon resuming, th

Re: [PATCH v2] Documentation: dma-buf: heaps: Add naming guidelines

2025-07-10 Thread Andrew Davis
On 7/10/25 2:06 AM, Maxime Ripard wrote: On Wed, Jul 09, 2025 at 12:39:15PM -0500, Andrew Davis wrote: On 6/16/25 10:21 AM, Maxime Ripard wrote: We've discussed a number of times of how some heap names are bad, but not really what makes a good heap name. Let's document what we expect the heap

Re: [PATCH v3 3/8] x86, lib: Add WBNOINVD helper functions

2025-07-10 Thread Borislav Petkov
On Thu, Jul 10, 2025 at 06:56:38AM -0700, Sean Christopherson wrote: > Yeah, AFAIK, no reason other than consistency. GPL it. Done. Tag x86_core_for_kvm on tip. It should appear on the mirrors soon, I hope. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette

Re: [PATCH v3 3/8] x86, lib: Add WBNOINVD helper functions

2025-07-10 Thread Peter Zijlstra
On Thu, Jul 10, 2025 at 01:29:02PM +0200, Borislav Petkov wrote: > On Thu, May 22, 2025 at 04:37:27PM -0700, Sean Christopherson wrote: > > diff --git a/arch/x86/lib/cache-smp.c b/arch/x86/lib/cache-smp.c > > index 079c3f3cd32c..1789db5d8825 100644 > > --- a/arch/x86/lib/cache-smp.c > > +++ b/arch/

[PATCH 5/7] drm/msm/dsi_phy_7nm: convert from round_rate() to determine_rate()

2025-07-10 Thread Brian Masney
The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c | 18 +- 1 file changed, 9 insert

[PATCH 2/7] drm/msm/dsi_phy_14nm: convert from round_rate() to determine_rate()

2025-07-10 Thread Brian Masney
The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c | 36 -- 1 file chan

[PATCH 0/7] drm/msm/dsi/phy: convert from clk round_rate() to determine_rate()

2025-07-10 Thread Brian Masney
d, 84 insertions(+), 82 deletions(-) --- base-commit: b551c4e2a98a177a06148cf16505643cd2108386 change-id: 20250710-drm-msm-phy-clk-round-rate-ccb10d54e804 Best regards, -- Brian Masney

[PATCH 3/7] drm/msm/dsi_phy_28nm_8960: convert from round_rate() to determine_rate()

2025-07-10 Thread Brian Masney
The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c | 34 + 1 file chan

[PATCH 4/7] drm/msm/dsi_phy_28nm: convert from round_rate() to determine_rate()

2025-07-10 Thread Brian Masney
The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm.c | 22 +++--- 1 file changed, 11

[PATCH 1/7] drm/msm/dsi_phy_10nm: convert from round_rate() to determine_rate()

2025-07-10 Thread Brian Masney
The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c | 18 +- 1 file changed, 9 inser

[PATCH 6/7] drm/msm/hdmi_phy_8996: convert from round_rate() to determine_rate()

2025-07-10 Thread Brian Masney
The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/gpu/drm/msm/hdmi/hdmi_phy_8996.c | 19 +-- 1 file changed, 9 insert

[PATCH 7/7] drm/msm/hdmi_phy_8998: convert from round_rate() to determine_rate()

2025-07-10 Thread Brian Masney
The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c | 19 +-- 1 file changed, 9 insert

Re: [PATCH 6/8] drm/imx: Add support for i.MX94 DCIF

2025-07-10 Thread Frank Li
On Wed, Jul 09, 2025 at 03:23:25PM +0300, Laurentiu Palcu wrote: > From: Sandor Yu > > This patch adds support for the i.MX94 Display Control Interface. Needn't word "this patch" Can you list feature here? > > Signed-off-by: Sandor Yu > Signed-off-by: Laurentiu Palcu > --- ... > +static int >

Re: [PATCH 3/8] drm/bridge: fsl-ldb: Get the next non-panel bridge

2025-07-10 Thread Liu Ying
On 07/11/2025, Frank Li wrote: > On Wed, Jul 09, 2025 at 03:23:22PM +0300, Laurentiu Palcu wrote: >> From: Liu Ying >> >> The next bridge in bridge chain could be a panel bridge or a non-panel >> bridge. Use devm_drm_of_get_bridge() to replace the combination > ^ extra space. It's inten

Re: [PATCH 8/9] drm/bridge: put the bridge returned by drm_bridge_get_next_bridge()

2025-07-10 Thread Maxime Ripard
Hi, On Wed, Jul 09, 2025 at 06:48:07PM +0200, Luca Ceresoli wrote: > The bridge returned by drm_bridge_get_next_bridge() is refcounted. Put it > when done. > > Signed-off-by: Luca Ceresoli You should really expand a bit more your commit logs, and provide the context of why you think putting drm

Re: [PATCH 9/9] drm/imx: parallel-display: put the bridge returned by drm_bridge_get_next_bridge()

2025-07-10 Thread Maxime Ripard
On Wed, Jul 09, 2025 at 06:48:08PM +0200, Luca Ceresoli wrote: > The bridge returned by drm_bridge_get_next_bridge() is refcounted. Put it > when done. > > Signed-off-by: Luca Ceresoli Same comments than on the previous patch here. Maxime signature.asc Description: PGP signature

Re: [PATCH v6 1/2] dma/contiguous: Add helper to test reserved memory type

2025-07-10 Thread Maxime Ripard
Hi Andrew, On Wed, Jul 09, 2025 at 10:55:40AM -0500, Andrew Davis wrote: > On 7/9/25 7:44 AM, Maxime Ripard wrote: > > A given reserved-memory region can be of multiple types. > > > > We have currently four types defined in the tree: contiguous, backed by > > CMA, coherent and swiotlb, backed by

Re: [PATCH v6 2/2] dma-buf: heaps: cma: Create CMA heap for each CMA reserved region

2025-07-10 Thread Maxime Ripard
On Wed, Jul 09, 2025 at 11:14:37AM -0500, Andrew Davis wrote: > On 7/9/25 7:44 AM, Maxime Ripard wrote: > > Aside from the main CMA region, it can be useful to allow userspace to > > allocate from the other CMA reserved regions. > > > > Indeed, those regions can have specific properties that can b

Re: [PATCH v2 08/13] media: platform: mediatek: add isp_7x camsys unit

2025-07-10 Thread 胡俊光

Re: [PATCH] drm/scheduler: Fix sched hang when killing app with dependent jobs

2025-07-10 Thread Christian König
First of all you need to CC the scheduler maintainers, try to use the get_maintainer.pl script. Adding them on CC. On 10.07.25 08:36, Lin.Cao wrote: > When Application A submits jobs (a1, a2, a3) and application B submits > job b1 with a dependency on a2's scheduler fence, killing application A >

Re: [PATCH 1/3] drm/bridge: get the bridge returned by drm_bridge_get_prev_bridge()

2025-07-10 Thread Maxime Ripard
On Wed, 9 Jul 2025 17:59:37 +0200, Luca Ceresoli wrote: > drm_bridge_get_prev_bridge() returns a bridge pointer that the > caller could hold for a long time. Increment the refcount of the returned > bridge and document it must be put by the caller. > > Signed-off-by: Luca Ceresoli > > [ ... ] R

drm-ci: mt8173-elm-hana: kms_flip@absolute-wf_vblank flake

2025-07-10 Thread Vignesh Raman
Hi Maintainers, There is a flake test reported for the mediatek driver in drm-ci. # Board Name: mt8173-elm-hana # Failure Rate: 40 # IGT Version: 2.1-g26ddb59c1 # Linux Version: 6.16.0-rc2 kms_flip@absolute-wf_vblank 07:39:19.323: DEBUG - Begin test kms_flip@absolute-wf_vblank 07:39:19.323: ERR

Re: drm-ci: mt8173-elm-hana: kms_atomic_transition@plane-all-modeset-transition-internal-panels flake

2025-07-10 Thread Thomas Zimmermann
Hi, spamming the mailing lists with copy-paste mails is not going to help with these problems. Best regards Thomas Am 10.07.25 um 15:16 schrieb Vignesh Raman: Hi Maintainers, There is a flake test reported for the mediatek driver in drm-ci. # Board Name: mt8173-elm-hana # Failure Rate: 60

Re: drm-ci: mt8173-elm-hana: kms_atomic_transition@plane-all-modeset-transition-internal-panels flake

2025-07-10 Thread Vignesh Raman
Hi Thomas, On 10/07/25 18:56, Thomas Zimmermann wrote: Hi, spamming the mailing lists with copy-paste mails is not going to help with these problems. Sorry, the intention was not to spam, but to ensure flake reports are tracked. The link to the email will be added to drivers/gpu/drm/ci/xf

Re: [PATCH v3 3/8] x86, lib: Add WBNOINVD helper functions

2025-07-10 Thread Sean Christopherson
On Thu, Jul 10, 2025, Borislav Petkov wrote: > On Thu, May 22, 2025 at 04:37:27PM -0700, Sean Christopherson wrote: > > diff --git a/arch/x86/lib/cache-smp.c b/arch/x86/lib/cache-smp.c > > index 079c3f3cd32c..1789db5d8825 100644 > > --- a/arch/x86/lib/cache-smp.c > > +++ b/arch/x86/lib/cache-smp.c

[PATCH] drm/panfrost: Fix leak when free gem object

2025-07-10 Thread lihongtao
obj->mappings.lock should be destroyed when free panfrost gem object in panfrost_gem_free_object. Signed-off-by: lihongtao --- drivers/gpu/drm/panfrost/panfrost_gem.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/panfrost/panfrost_gem.c b/drivers/gpu/drm/panfrost/panfrost_

[PATCH 0/9] Introducing firmware late binding

2025-07-10 Thread Rodrigo Vivi
Introducing firmware late binding feature to enable firmware loading for the devices, such as the fan controller and voltage regulator, during the driver probe. Typically, firmware for these devices are part of IFWI flash image but can be replaced at probe after OEM tuning. This version (v8?): I'm

[PATCH 8/9] drm/xe/xe_late_bind_fw: Introduce debug fs node to disable late binding

2025-07-10 Thread Rodrigo Vivi
From: Badal Nilawar Introduce a debug filesystem node to disable late binding fw reload during the system or runtime resume. This is intended for situations where the late binding fw needs to be loaded from user mode, perticularly for validation purpose. Note that xe kmd doesn't participate in la

[PATCH 5/9] drm/xe/xe_late_bind_fw: Load late binding firmware

2025-07-10 Thread Rodrigo Vivi
From: Badal Nilawar Load late binding firmware v2: - s/EAGAIN/EBUSY/ - Flush worker in suspend and driver unload (Daniele) v3: - Use retry interval of 6s, in steps of 200ms, to allow other OS components release MEI CL handle (Sasha) v4: - return -ENODEV if component not added (Daniele) -

[PATCH 7/9] drm/xe/xe_late_bind_fw: Reload late binding fw during system resume

2025-07-10 Thread Rodrigo Vivi
From: Badal Nilawar Reload late binding fw during resume from system suspend v2: - Unconditionally reload late binding fw (Rodrigo) - Flush worker during system suspend Cc: Rodrigo Vivi Signed-off-by: Badal Nilawar Reviewed-by: Rodrigo Vivi Signed-off-by: Rodrigo Vivi --- drivers/gpu/d

[PATCH 4/9] drm/xe/xe_late_bind_fw: Initialize late binding firmware

2025-07-10 Thread Rodrigo Vivi
From: Badal Nilawar Search for late binding firmware binaries and populate the meta data of firmware structures. v2 (Daniele): - drm_err if firmware size is more than max pay load size - s/request_firmware/firmware_request_nowarn/ as firmware will not be available for all possible cards v3

[PATCH 6/9] drm/xe/xe_late_bind_fw: Reload late binding fw in rpm resume

2025-07-10 Thread Rodrigo Vivi
From: Badal Nilawar Reload late binding fw during runtime resume. Signed-off-by: Badal Nilawar Reviewed-by: Rodrigo Vivi Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/xe/xe_late_bind_fw.c | 2 +- drivers/gpu/drm/xe/xe_late_bind_fw.h | 1 + drivers/gpu/drm/xe/xe_pm.c | 4 3 f

[PATCH 3/9] drm/xe/xe_late_bind_fw: Introducing xe_late_bind_fw

2025-07-10 Thread Rodrigo Vivi
From: Badal Nilawar Introducing xe_late_bind_fw to enable firmware loading for the devices, such as the fan controller, during the driver probe. Typically, firmware for such devices are part of IFWI flash image but can be replaced at probe after OEM tuning. This patch binds mei late binding compo

[PATCH 1/9] mei: bus: add mei_cldev_mtu interface

2025-07-10 Thread Rodrigo Vivi
From: Alexander Usyskin Add a new helper function that allows MEI client drivers to query the maximum transmission unit (MTU) for a connected MEI client. This is useful for clients that need to transmit large payloads, such as firmware blobs, allowing them to determine the maximum message size t

[PATCH 9/9] drm/xe/xe_late_bind_fw: Extract and print version info

2025-07-10 Thread Rodrigo Vivi
From: Badal Nilawar Extract and print version info of the late binding binary. v2: Some refinements (Daniele) Signed-off-by: Badal Nilawar Reviewed-by: Daniele Ceraolo Spurio Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/xe/xe_late_bind_fw.c | 124 + drivers/gpu/

[PATCH 2/9] mei: late_bind: add late binding component driver

2025-07-10 Thread Rodrigo Vivi
From: Alexander Usyskin Introduce a new MEI client driver to support Late Binding firmware upload/update for Intel discrete graphics platforms. Late Binding is a runtime firmware upload/update mechanism that allows payloads, such as fan control and voltage regulator, to be securely delivered and

Re: [PATCH v2] Documentation: dma-buf: heaps: Add naming guidelines

2025-07-10 Thread Maxime Ripard
On Thu, Jul 10, 2025 at 09:34:12AM -0500, Andrew Davis wrote: > On 7/10/25 2:06 AM, Maxime Ripard wrote: > > On Wed, Jul 09, 2025 at 12:39:15PM -0500, Andrew Davis wrote: > > > On 6/16/25 10:21 AM, Maxime Ripard wrote: > > > > We've discussed a number of times of how some heap names are bad, but >

Re: [PATCH v4 0/8] drm/sched: Fix memory leaks with cancel_job() callback

2025-07-10 Thread Philipp Stanner
On Thu, 2025-07-10 at 14:54 +0200, Philipp Stanner wrote: > Changes in v4: >   - Change dev_err() to dev_warn() in pending_list emptyness check. > > Changes in v3: >   - Remove forgotten copy-past artifacts. (Tvrtko) >   - Remove forgotten done_list struct member. (Tvrtko) >   - Slightly adjust co

Re: [PATCH v6 2/2] dma-buf: heaps: cma: Create CMA heap for each CMA reserved region

2025-07-10 Thread Maxime Ripard
On Thu, Jul 10, 2025 at 09:46:56AM -0500, Andrew Davis wrote: > > > On 7/10/25 2:44 AM, Maxime Ripard wrote: > > On Wed, Jul 09, 2025 at 11:14:37AM -0500, Andrew Davis wrote: > > > On 7/9/25 7:44 AM, Maxime Ripard wrote: > > > > Aside from the main CMA region, it can be useful to allow userspace

Re: [PATCH 1/3] drm/tests: edid: Fix monitor range limits

2025-07-10 Thread Javier Martinez Canillas
Maxime Ripard writes: > For some reason, some EDIDs used by kunit had Monitor Range Limits > making no sense, and not matching the edid-decode output in the comment. > > While they were in the comments as: > Display Range Limits: > Monitor ranges (GTF): 50-70 Hz V, 30-70 kHz H, max dotc

Re: [PATCH 3/3] drm/tests: edid: Add edid-decode --check output

2025-07-10 Thread Javier Martinez Canillas
Maxime Ripard writes: > Some of our EDIDs are (rightfully) invalid, but most of them should be > valid. > > Let's add the edid-decode --check of these EDIDs when they were > generated, so we know what to expect going forward, and a comment to > explicitly mention when we expect them to be broken.

drm-ci: rk3288-veyron-jaq: kms_flip@flip-vs-absolute-wf_vblank flake

2025-07-10 Thread Vignesh Raman
Hi Maintainers, There are some flake test reported for rockchip driver testing in drm-ci. # Board Name: rk3288-veyron-jaq # Failure Rate: 40 # IGT Version: 2.1-g26ddb59c1 # Linux Version: 6.16.0-rc2 kms_flip@flip-vs-absolute-wf_vblank command: cd "/igt/libexec/igt-gpu-tools" && "/igt/libexec/i

[PATCH v1 1/1] rculist: move list_for_each_rcu() to where it belongs

2025-07-10 Thread Andy Shevchenko
The list_for_each_rcu() relies on the rcu_dereference() API which is not provided by the list.h. At the same time list.h is a low-level basic header that must not have dependencies like RCU, besides the fact of the potential circular dependencies in some cases. With all that said, move RCU related

Re: [PATCH v6 5/5] drm/amdgpu: do not resume device in thaw for normal hibernation

2025-07-10 Thread Mario Limonciello
On 7/10/2025 2:23 AM, Samuel Zhang wrote: For normal hibernation, GPU do not need to be resumed in thaw since it is not involved in writing the hibernation image. Skip resume in this case can reduce the hibernation time. On VM with 8 * 192GB VRAM dGPUs, 98% VRAM usage and 1.7TB system memory, th

Re: [PATCH 2/3] drm/tests: edid: Update CTA-861 HDMI Vendor Specific Data Block

2025-07-10 Thread Javier Martinez Canillas
Maxime Ripard writes: > For some reason, the HDMI VSDBs in our kunit EDIDs had a length longer > than expected. > > While this was harmless, we should get rid of it to make it somewhat > predictable. > > Signed-off-by: Maxime Ripard > --- Reviewed-by: Javier Martinez Canillas -- Best regards

Re: [PATCH v6 5/5] drm/amdgpu: do not resume device in thaw for normal hibernation

2025-07-10 Thread Christian König
On 10.07.25 14:13, Mario Limonciello wrote: > On 7/10/2025 2:23 AM, Samuel Zhang wrote: >> For normal hibernation, GPU do not need to be resumed in thaw since it is >> not involved in writing the hibernation image. Skip resume in this case >> can reduce the hibernation time. >> >> On VM with 8 * 19

Re: [PATCH v6 5/5] drm/amdgpu: do not resume device in thaw for normal hibernation

2025-07-10 Thread Mario Limonciello
On 7/10/2025 8:20 AM, Christian König wrote: On 10.07.25 14:13, Mario Limonciello wrote: On 7/10/2025 2:23 AM, Samuel Zhang wrote: For normal hibernation, GPU do not need to be resumed in thaw since it is not involved in writing the hibernation image. Skip resume in this case can reduce the hib

drm-ci: rk3288-veyron-jaq: kms_flip@flip-vs-dpms-on-nop-interruptible flake

2025-07-10 Thread Vignesh Raman
Hi Maintainers, There are some flake test reported for rockchip driver testing in drm-ci. # Board Name: rk3288-veyron-jaq # Failure Rate: 40 # IGT Version: 2.1-g26ddb59c1 # Linux Version: 6.16.0-rc2 kms_flip@flip-vs-dpms-on-nop-interruptible 02:09:26.564: DEBUG - Begin test kms_flip@flip-vs-dpm

Re: [PATCH v5 0/8] drm/sched: Allow drivers to skip the reset with DRM_GPU_SCHED_STAT_NO_HANG

2025-07-10 Thread Maíra Canal
+cc Maxime, Thomas Hi Philipp, On 09/07/25 10:14, Philipp Stanner wrote: On Tue, 2025-07-08 at 10:25 -0300, Maíra Canal wrote: TL;DR: The only two patches that are lacking R-b's are: [PATCH 2/8] drm/sched: Allow drivers to skip the reset and keep on running [PATCH 7/8] drm/xe: Use DRM_GPU_SCH

Re: [PATCH v3 3/8] x86, lib: Add WBNOINVD helper functions

2025-07-10 Thread Peter Zijlstra
On Thu, Jul 10, 2025 at 04:37:29PM +0200, Peter Zijlstra wrote: > On Thu, Jul 10, 2025 at 01:29:02PM +0200, Borislav Petkov wrote: > > On Thu, May 22, 2025 at 04:37:27PM -0700, Sean Christopherson wrote: > > > diff --git a/arch/x86/lib/cache-smp.c b/arch/x86/lib/cache-smp.c > > > index 079c3f3cd32c

Re: [PATCH resend] drm/i915/bios: Apply vlv_fixup_mipi_sequences() to v2 mipi-sequences too

2025-07-10 Thread Hans de Goede
Hi Rodrigo, On 10-Jul-25 5:34 PM, Rodrigo Vivi wrote: > On Mon, Jul 07, 2025 at 11:10:59PM +0200, Hans de Goede wrote: >> Hi Ville, >> >> On 4-Jul-25 12:31 PM, Ville Syrjälä wrote: >>> On Thu, Jul 03, 2025 at 04:38:24PM +0200, Hans de Goede wrote: From: Hans de Goede It turns out t

Re: [PATCH v3 3/8] x86, lib: Add WBNOINVD helper functions

2025-07-10 Thread Sean Christopherson
On Thu, Jul 10, 2025, Peter Zijlstra wrote: > On Thu, Jul 10, 2025 at 04:37:29PM +0200, Peter Zijlstra wrote: > > On Thu, Jul 10, 2025 at 01:29:02PM +0200, Borislav Petkov wrote: > > > On Thu, May 22, 2025 at 04:37:27PM -0700, Sean Christopherson wrote: > > > > diff --git a/arch/x86/lib/cache-smp.c

Re: [PATCH v6 0/5] reduce system memory requirement for hibernation

2025-07-10 Thread Mario Limonciello
On 7/10/2025 2:23 AM, Samuel Zhang wrote: Modern data center dGPUs are usually equipped with very large VRAM. On server with such dGPUs(192GB VRAM * 8) and 2TB system memory, hibernate will fail due to no enough free memory. The root cause is that during hibernation all VRAM memory get evicted

Re: [PATCH v3 3/8] x86, lib: Add WBNOINVD helper functions

2025-07-10 Thread Peter Zijlstra
On Thu, Jul 10, 2025 at 08:55:02AM -0700, Sean Christopherson wrote: > > So kvm-amd is the SEV stuff, AGPGART is the ancient crap nobody cares > > about, CCP is more SEV stuff, DRM actually does CLFLUSH loops, but has a > > WBINVD fallback. i915 is rude and actually does WBINVD. Could they > > pre

Re: DMA-BUFs always uncached on arm64, causing poor camera performance on Librem 5

2025-07-10 Thread Nicolas Dufresne
Hi Pavel, Le jeudi 10 juillet 2025 à 10:24 +0200, Pavel Machek a écrit : > Hi! > > It seems that DMA-BUFs are always uncached on arm64... which is a > problem. > > I'm trying to get useful camera support on Librem 5, and that includes > recording vidos (and taking photos). > > memcpy() from nor

RE: [PATCH 1/2] clk: renesas: rzg2l: Remove DSI clock rate restrictions

2025-07-10 Thread Chris Brandt
Hi Biju, Thank you for your review! > > +/* Required division ratio for the MIPI clock */ > > +int dsi_div_ab; > > static int dsi_div_ab; Good catch. > for the DPI, DIV_DSI_B = 1 and DIV_DSI_A ={2, 4, 8} > > So, you need to adjust the below calculation for DPI as well?? You bring up a good

[PATCH 8/9] drm/sun4i/sun4i_hdmi_ddc_clk: convert from round_rate() to determine_rate()

2025-07-10 Thread Brian Masney
The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/gpu/drm/sun4i/sun4i_hdmi_ddc_clk.c | 12 +++- 1 file changed, 7 insertions(

[PATCH 9/9] drm/sun4i/sun4i_tcon_dclk: convert from round_rate() to determine_rate()

2025-07-10 Thread Brian Masney
The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/gpu/drm/sun4i/sun4i_tcon_dclk.c | 18 ++ 1 file changed, 10 inserti

[PATCH 1/9] drm/imx/ipuv3/imx-tve: convert from round_rate() to determine_rate()

2025-07-10 Thread Brian Masney
The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/gpu/drm/imx/ipuv3/imx-tve.c | 17 ++--- 1 file changed, 10 insertions(+

[PATCH 2/9] drm/mcde/mcde_clk_div: convert from round_rate() to determine_rate()

2025-07-10 Thread Brian Masney
The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/gpu/drm/mcde/mcde_clk_div.c | 13 - 1 file changed, 8 insertions(+), 5

[PATCH 0/9] drm: convert from clk round_rate() to determine_rate()

2025-07-10 Thread Brian Masney
| 14 -- drivers/gpu/drm/stm/lvds.c| 12 +++- drivers/gpu/drm/sun4i/sun4i_hdmi_ddc_clk.c| 12 +++- drivers/gpu/drm/sun4i/sun4i_tcon_dclk.c | 18 ++ 9 files changed, 73 insertions(+), 51 deletions(-) --- base-commit: b5

[PATCH 4/9] drm/msm/hdmi_pll_8960: convert from round_rate() to determine_rate()

2025-07-10 Thread Brian Masney
The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/gpu/drm/msm/hdmi/hdmi_pll_8960.c | 12 +++- 1 file changed, 7 insertions(+)

[PATCH 6/9] drm/stm/dw_mipi_dsi-stm: convert from round_rate() to determine_rate()

2025-07-10 Thread Brian Masney
The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 14 -- 1 file changed, 8 insertions(+),

[PATCH 5/9] drm/pl111: convert from round_rate() to determine_rate()

2025-07-10 Thread Brian Masney
The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/gpu/drm/pl111/pl111_display.c | 13 - 1 file changed, 8 insertions(+),

[PATCH 7/9] drm/stm/lvds: convert from round_rate() to determine_rate()

2025-07-10 Thread Brian Masney
The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/gpu/drm/stm/lvds.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(

[PATCH 3/9] drm/msm/disp/mdp4/mdp4_lvds_pll: convert from round_rate() to determine_rate()

2025-07-10 Thread Brian Masney
The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/gpu/drm/msm/disp/mdp4/mdp4_lvds_pll.c | 13 - 1 file changed, 8 inserti

drm-ci: rk3399-gru-kevin: flake in kms_color@gamma

2025-07-10 Thread Vignesh Raman
Hi Maintainers, There are some flake test reported for rockchip driver testing in drm-ci. # Board Name: rk3399-gru-kevin # Failure Rate: 60 # IGT Version: 2.1-g26ddb59c1 # Linux Version: 6.16.0-rc2 kms_color@gamma (kms_color:915) igt_pipe_crc-WARNING: Warning on condition all_zero in function

Re: [PATCH 2/3] drm/sitronix/st7571-i2c: Make the reset GPIO to be optional

2025-07-10 Thread Marcus Folkesson
Hello Javier, On Thu, Jul 10, 2025 at 01:00:41PM +0200, Javier Martinez Canillas wrote: > > > > devm_gpiod_get_optional() returns -ENOENT when the GPIO is not found, > > and that is no error we want to propagage upwards. > > > > Maybe something like this instead: > > if (IS_ERR(st7571->reset) && I

drm-ci: mt8173-elm-hana: kms_flip@blocking-wf_vblank flake

2025-07-10 Thread Vignesh Raman
Hi Maintainers, There is a flake test reported for the mediatek driver in drm-ci. # Board Name: mt8173-elm-hana # Failure Rate: 20 # IGT Version: 2.1-g26ddb59c1 # Linux Version: 6.16.0-rc2 kms_flip@blocking-wf_vblank 02:13:44.625: DEBUG - Begin test kms_flip@blocking-wf_vblank 02:13:44.625: ERR

[PATCH v4 3/8] drm/sched/tests: Implement cancel_job() callback

2025-07-10 Thread Philipp Stanner
The GPU Scheduler now supports a new callback, cancel_job(), which lets the scheduler cancel all jobs which might not yet be freed when drm_sched_fini() runs. Using this callback allows for significantly simplifying the mock scheduler teardown code. Implement the cancel_job() callback and adjust t

[PATCH v4 2/8] drm/sched: Avoid memory leaks with cancel_job() callback

2025-07-10 Thread Philipp Stanner
Since its inception, the GPU scheduler can leak memory if the driver calls drm_sched_fini() while there are still jobs in flight. The simplest way to solve this in a backwards compatible manner is by adding a new callback, drm_sched_backend_ops.cancel_job(), which instructs the driver to signal th

[PATCH v4 0/8] drm/sched: Fix memory leaks with cancel_job() callback

2025-07-10 Thread Philipp Stanner
Changes in v4: - Change dev_err() to dev_warn() in pending_list emptyness check. Changes in v3: - Remove forgotten copy-past artifacts. (Tvrtko) - Remove forgotten done_list struct member. (Tvrtko) - Slightly adjust commit message of patch 7. - Add RBs. (Maira, Danilo, Tvrtko) Changes i

[PATCH v4 1/8] drm/panfrost: Fix scheduler workqueue bug

2025-07-10 Thread Philipp Stanner
When the GPU scheduler was ported to using a struct for its initialization parameters, it was overlooked that panfrost creates a distinct workqueue for timeout handling. The pointer to this new workqueue is not initialized to the struct, resulting in NULL being passed to the scheduler, which then

[PATCH v4 6/8] drm/nouveau: Make fence container helper usable driver-wide

2025-07-10 Thread Philipp Stanner
In order to implement a new DRM GPU scheduler callback in Nouveau, a helper for obtaining a nouveau_fence from a dma_fence is necessary. Such a helper exists already inside nouveau_fence.c, called from_fence(). Make that helper available to other C files with a more precise name. Signed-off-by: P

[PATCH v4 7/8] drm/nouveau: Add new callback for scheduler teardown

2025-07-10 Thread Philipp Stanner
There is a new callback for always tearing the scheduler down in a leak-free, deadlock-free manner. Port Nouveau as its first user by providing the scheduler with a callback that ensures the fence context gets killed in drm_sched_fini(). Signed-off-by: Philipp Stanner Acked-by: Danilo Krummrich

[PATCH v4 8/8] drm/nouveau: Remove waitque for sched teardown

2025-07-10 Thread Philipp Stanner
struct nouveau_sched contains a waitque needed to prevent drm_sched_fini() from being called while there are still jobs pending. Doing so so far would have caused memory leaks. With the new memleak-free mode of operation switched on in drm_sched_fini() by providing the callback nouveau_sched_cance

[PATCH v4 4/8] drm/sched/tests: Add unit test for cancel_job()

2025-07-10 Thread Philipp Stanner
The scheduler unit tests now provide a new callback, cancel_job(). This callback gets used by drm_sched_fini() for all still pending jobs to cancel them. Implement a new unit test to test this. Signed-off-by: Philipp Stanner Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/scheduler/tests/tests

[PATCH v4 5/8] drm/sched: Warn if pending_list is not empty

2025-07-10 Thread Philipp Stanner
drm_sched_fini() can leak jobs under certain circumstances. Warn if that happens. Signed-off-by: Philipp Stanner --- drivers/gpu/drm/scheduler/sched_main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c ind

drm-ci: mt8173-elm-hana: kms_flip@busy-flip flake

2025-07-10 Thread Vignesh Raman
Hi Maintainers, There is a flake test reported for the mediatek driver in drm-ci. # Board Name: mt8173-elm-hana # Failure Rate: 40 # IGT Version: 2.1-g26ddb59c1 # Linux Version: 6.16.0-rc2 kms_flip@busy-flip 02:13:29.480: DEBUG - Begin test kms_flip@busy-flip 02:13:29.480: ERROR - Igt error: (k

Re: [PATCH v4 1/8] drm/panfrost: Fix scheduler workqueue bug

2025-07-10 Thread Philipp Stanner
On Thu, 2025-07-10 at 14:54 +0200, Philipp Stanner wrote: > When the GPU scheduler was ported to using a struct for its > initialization parameters, it was overlooked that panfrost creates a > distinct workqueue for timeout handling. > > The pointer to this new workqueue is not initialized to the

Re: [PATCH v6 0/2] dma-buf: heaps: Create a CMA heap for each CMA reserved region

2025-07-10 Thread Nicolas Dufresne
Hi, Le mercredi 09 juillet 2025 à 15:38 +0200, Maxime Ripard a écrit : > > Will there be a generic way to find out which driver/device this carveout > > belongs to ? In V4L2, only complex cameras have userspace drivers, > > everything > > else is generic code. > > I believe it's a separate discus

  1   2   3   >