Re: [PATCH 1/4] drm/sched: optimize drm_sched_job_add_dependency

2025-05-23 Thread Danilo Krummrich
On Fri, May 23, 2025 at 02:56:40PM +0200, Christian König wrote: > It turned out that we can actually massively optimize here. > > The previous code was horrible inefficient since it constantly released > and re-acquired the lock of the xarray and started each iteration from the > base of the arra

Re: (subset) [PATCH v6 00/10] drm/display: generic HDMI CEC helpers

2025-05-23 Thread Tommaso Merciai
Hi Biju, Dmitry, On Fri, May 23, 2025 at 03:47:24PM +0200, Tommaso Merciai wrote: > Hi Biju, Dmitry, > Thanks for your comments. > > On Fri, May 23, 2025 at 09:37:19AM +0300, Dmitry Baryshkov wrote: > > Hi Biju > > > > On Fri, 23 May 2025 at 09:17, Biju Das wrote: > > > > > > Hi Dmitry Baryshko

Re: [PATCH 1/4] drm/sched: optimize drm_sched_job_add_dependency

2025-05-23 Thread Danilo Krummrich
On Fri, May 23, 2025 at 04:11:39PM +0200, Danilo Krummrich wrote: > On Fri, May 23, 2025 at 02:56:40PM +0200, Christian König wrote: > > It turned out that we can actually massively optimize here. > > > > The previous code was horrible inefficient since it constantly released > > and re-acquired t

Re: [PATCH 1/2] dma-buf: Add __dma_fence_is_signaled()

2025-05-23 Thread Tvrtko Ursulin
On 22/05/2025 12:25, Philipp Stanner wrote: Some parties want to check whether a function is already signaled without actually signaling the fence, which is what dma_fence_is_signaled() might due if the fence ops 'signaled' callback s/due/do/ is implemented. Add __dma_fence_is_signaled(),

Re: [PATCH] drm/sched/tests: Use one lock for fence context

2025-05-23 Thread Tvrtko Ursulin
On 22/05/2025 15:06, Philipp Stanner wrote: On Wed, 2025-05-21 at 11:24 +0100, Tvrtko Ursulin wrote: On 21/05/2025 11:04, Philipp Stanner wrote: When the unit tests were implemented, each scheduler job got its own, distinct lock. This is not how dma_fence context locking rules are to be impl

Re: [PATCH v5 3/4] dt-bindings: display: bridge: renesas,dsi: Add support for RZ/V2H(P) SoC

2025-05-23 Thread Geert Uytterhoeven
Hi Prabhakar, On Mon, 12 May 2025 at 20:43, Prabhakar wrote: > From: Lad Prabhakar > > The MIPI DSI interface on the RZ/V2H(P) SoC is nearly identical to that of > the RZ/G2L SoC. While the LINK registers are the same for both SoCs, the > D-PHY registers differ. Additionally, the number of reset

[PATCH v4] drm/panthor: Make the timeout per-queue instead of per-job

2025-05-23 Thread Ashley Smith
The timeout logic provided by drm_sched leads to races when we try to suspend it while the drm_sched workqueue queues more jobs. Let's overhaul the timeout handling in panthor to have our own delayed work that's resumed/suspended when a group is resumed/suspended. When an actual timeout occurs, we

Re: [PATCH v5 4/4] drm: renesas: rz-du: mipi_dsi: Add support for RZ/V2H(P) SoC

2025-05-23 Thread Geert Uytterhoeven
Hi Prabhakar, Fabrizio, On Mon, 12 May 2025 at 20:43, Prabhakar wrote: > From: Lad Prabhakar > > Add DSI support for Renesas RZ/V2H(P) SoC. > > Co-developed-by: Fabrizio Castro > Signed-off-by: Fabrizio Castro > Signed-off-by: Lad Prabhakar Thanks for your patch! > --- a/drivers/gpu/drm/ren

Re: [PATCH v9 5/9] tee: new ioctl to a register tee_shm from a dmabuf file descriptor

2025-05-23 Thread Sumit Garg
On Tue, May 20, 2025 at 05:16:48PM +0200, Jens Wiklander wrote: > From: Etienne Carriere > > Add a userspace API to create a tee_shm object that refers to a dmabuf > reference. > > Userspace registers the dmabuf file descriptor as in a tee_shm object. > The registration is completed with a tee_s

Re: (subset) [PATCH v6 00/10] drm/display: generic HDMI CEC helpers

2025-05-23 Thread Tommaso Merciai
Hi Biju, Dmitry, Thanks for your comments. On Fri, May 23, 2025 at 09:37:19AM +0300, Dmitry Baryshkov wrote: > Hi Biju > > On Fri, 23 May 2025 at 09:17, Biju Das wrote: > > > > Hi Dmitry Baryshkov, > > > > Thanks for the series. > > > > Looks like, After this patch, when I change resolution usin

Re: [PATCH 1/4] drm/sched: optimize drm_sched_job_add_dependency

2025-05-23 Thread Tvrtko Ursulin
On 23/05/2025 13:56, Christian König wrote: It turned out that we can actually massively optimize here. The previous code was horrible inefficient since it constantly released and re-acquired the lock of the xarray and started each iteration from the base of the array to avoid concurrent modif

Re: [PATCH v5 1/4] clk: renesas: rzv2h-cpg: Add support for DSI clocks

2025-05-23 Thread Geert Uytterhoeven
Hi Prabhakar, Fabrizio, On Mon, 12 May 2025 at 20:43, Prabhakar wrote: > From: Lad Prabhakar > > Add support for PLLDSI and PLLDSI divider clocks. > > Introduce the `renesas-rzv2h-dsi.h` header to centralize and share > PLLDSI-related data structures, limits, and algorithms between the RZ/V2H >

Re: [PATCH v5 2/4] clk: renesas: r9a09g057: Add clock and reset entries for DSI and LCDC

2025-05-23 Thread Geert Uytterhoeven
Hi Prabhakar, Fabrizio, On Mon, 12 May 2025 at 20:43, Prabhakar wrote: > From: Lad Prabhakar > > Add clock and reset entries for the DSI and LCDC peripherals. > > Co-developed-by: Fabrizio Castro > Signed-off-by: Fabrizio Castro > Signed-off-by: Lad Prabhakar Thanks for your patch! > --- a/

Re: [PATCH 5/8] drm/i915: Associate ACPI connector nodes with connector entries (v2)

2025-05-23 Thread Heikki Krogerus
Hi Jani, On Fri, May 23, 2025 at 12:28:11PM +0300, Jani Nikula wrote: > > Resurrecting an old thread because I am clueless and I have > questions. :) > > On Tue, 17 Aug 2021, Hans de Goede wrote: > > From: Heikki Krogerus > > > > On Intel platforms we know that the ACPI connector device > > no

[PATCH 2/4] drm/sched: add drm_sched_prealloc_dependency_slots

2025-05-23 Thread Christian König
Sometimes drivers need to be able to submit multiple jobs which depend on each other to different schedulers at the same time, but using drm_sched_job_add_dependency() can't fail any more after the first job is initialized. This function preallocate memory for dependency slots so that no ENOMEM ca

[PATCH 3/4] drm/sched: Add a test for prealloced fence slots

2025-05-23 Thread Christian König
Just to exercise the functionality. Signed-off-by: Christian König --- drivers/gpu/drm/scheduler/tests/tests_basic.c | 56 ++- 1 file changed, 55 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/scheduler/tests/tests_basic.c b/drivers/gpu/drm/scheduler/tests/tests_basi

Fixing AMDGPUs gang submit error handling

2025-05-23 Thread Christian König
Hi guys, fives try to those patches. I think I finally manage to understand how xarray works. There are the high level and lower level API and we can actually save tons of CPU cycles when we switch to the lower level API for adding the fences to the xarray. Looks like this is working now, but I

[PATCH 1/4] drm/sched: optimize drm_sched_job_add_dependency

2025-05-23 Thread Christian König
It turned out that we can actually massively optimize here. The previous code was horrible inefficient since it constantly released and re-acquired the lock of the xarray and started each iteration from the base of the array to avoid concurrent modification which in our case doesn't exist. Additi

Re: [PATCH v9 3/9] tee: implement protected DMA-heap

2025-05-23 Thread Sumit Garg
+ Robin Jens, I suppose you missed to add Robin who has earlier reviewed this patch. On Tue, May 20, 2025 at 05:16:46PM +0200, Jens Wiklander wrote: > Implement DMA heap for protected DMA-buf allocation in the TEE > subsystem. > > Restricted memory refers to memory buffers behind a hardware enf

Re: [PATCH v3 00/22] drm: convert all bridges to devm_drm_bridge_alloc()

2025-05-23 Thread Luca Ceresoli
Hello Inki, On Fri, 23 May 2025 00:11:24 +0900 Inki Dae wrote: > Hello Luca Ceresoli, > > 2025년 5월 21일 (수) 오후 11:23, Luca Ceresoli 님이 작성: > > > > Hello Maxime, Shawn, Liu, all, > > > > On Fri, 09 May 2025 15:53:26 +0200 > > Luca Ceresoli wrote: > > > > > devm_drm_bridge_alloc() [0] is the ne

[PATCH 4/4] drm/amdgpu: fix gang submission error handling

2025-05-23 Thread Christian König
For the unlikely case that we ran into an ENOMEM while fixing up the gang submission dependencies we can't clean up any more since the gang members are already armed. Fix this by using pre-allocated dependency slots and re-ordering the code, also fix a double unref since the fence reference is als

[PATCH] drivers: gpu: drm: msm: registers: improve reproducibility

2025-05-23 Thread Viswanath Kraleti
;) if p.copyright_year: current_year = str(datetime.date.today().year) print() --- base-commit: fc5c669c902c3039aa41731b6c58c0960d0b1bbf change-id: 20250523-binrep-f8c81fa0d31d Best regards, -- Viswanath Kraleti

Re: [PATCH v3 1/5] drm/sched: Fix teardown leaks with waitqueue

2025-05-23 Thread Tvrtko Ursulin
On 22/05/2025 16:32, Philipp Stanner wrote: On Thu, 2025-05-22 at 14:37 +0100, Tvrtko Ursulin wrote: On 22/05/2025 09:27, Philipp Stanner wrote: From: Philipp Stanner The GPU scheduler currently does not ensure that its pending_list is empty before performing various other teardown tasks i

[PATCH] drm/amdgpu: Fix integer overflow in amdgpu_gem_add_input_fence()

2025-05-23 Thread Dan Carpenter
The "num_syncobj_handles" is a u32 value that comes from the user via the ioctl. On 32bit systems the "sizeof(uint32_t) * num_syncobj_handles" multiplication can have an integer overflow. Use size_mul() to fix that. Fixes: 38c67ec9aa4b ("drm/amdgpu: Add input fence to sync bo map/unmap") Cc: sta

Re: [PATCH v3 2/5] drm/sched/tests: Port tests to new cleanup method

2025-05-23 Thread Tvrtko Ursulin
On 22/05/2025 15:59, Philipp Stanner wrote: On Thu, 2025-05-22 at 15:06 +0100, Tvrtko Ursulin wrote: On 22/05/2025 09:27, Philipp Stanner wrote: The drm_gpu_scheduler now supports a callback to help drm_sched_fini() avoid memory leaks. This callback instructs the driver to signal all pending

[PATCH next] drm/plane: Fix error pointer vs NULL bug in create_in_format_blob()

2025-05-23 Thread Dan Carpenter
The callers expect to receive error pointers on error but create_in_format_blob() returns NULL. Change it to return error pointers. Fixes: 0d6dcd741c26 ("drm/plane: modify create_in_formats to acommodate async") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/drm_plane.c | 4 ++-- 1 file chang

[PATCH next] drm/panel: nt37801: Fix IS_ERR() vs NULL check in probe()

2025-05-23 Thread Dan Carpenter
The devm_drm_panel_alloc() function returns error pointers, it doesn't return NULL. Update the check to match. Fixes: 4fca6849864d ("drm/panel: Add Novatek NT37801 panel driver") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/panel/panel-novatek-nt37801.c | 4 ++-- 1 file changed, 2 insertion

[PATCH] drm/amdgpu: Fix integer overflow issues in amdgpu_userq_fence.c

2025-05-23 Thread Dan Carpenter
This patch only affects 32bit systems. There are several integer overflows bugs here but only the "sizeof(u32) * num_syncobj" multiplication is a problem at runtime. (The last lines of this patch). These variables are u32 variables that come from the user. The issue is the multiplications can o

[PATCH next] drm/nouveau/tegra: Fix error pointer vs NULL return in nvkm_device_tegra_resource_addr()

2025-05-23 Thread Dan Carpenter
The nvkm_device_tegra_resource() function returns a mix of error pointers and NULL. The callers only expect it to return NULL on error. Change it to only return NULL. Fixes: 76b8f81a5b92 ("drm/nouveau: improve handling of 64-bit BARs") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/nouveau/n

[PATCH v3 3/4] fbdev/deferred-io: Support contiguous kernel memory framebuffers

2025-05-23 Thread mhkelley58
From: Michael Kelley Current defio code works only for framebuffer memory that is allocated with vmalloc(). The code assumes that the underlying page refcount can be used by the mm subsystem to manage each framebuffer page's lifecycle, including freeing the page if the refcount goes to 0. This ap

[PATCH v3 1/4] mm: Export vmf_insert_mixed_mkwrite()

2025-05-23 Thread mhkelley58
From: Michael Kelley Export vmf_insert_mixed_mkwrite() for use by fbdev deferred I/O code, which can be built as a module. Commit cd1e0dac3a3e ("mm: unexport vmf_insert_mixed_mkwrite") is effectively reverted. Signed-off-by: Michael Kelley --- Changes in v2: * Exported as GPL symbol [Christoph

[PATCH v3 2/4] fbdev: Add flag indicating framebuffer is allocated from kernel memory

2025-05-23 Thread mhkelley58
From: Michael Kelley Add a flag that fbdev drivers can set to indicate that the framebuffer memory comes from alloc_pages() or similar as opposed to vmalloc() memory. The flag is to be used by fbdev deferred I/O. Signed-off-by: Michael Kelley --- Changes in v3: * This patch is new in v3. The de

[PATCH v3 0/4] fbdev: Add deferred I/O support for contiguous kernel memory framebuffers

2025-05-23 Thread mhkelley58
From: Michael Kelley Current deferred I/O code works only for framebuffer memory that is allocated with vmalloc(). The code assumes that the underlying page refcount can be used by the mm subsystem to manage each framebuffer page's lifecycle, which is consistent with vmalloc'ed memory, but not wi

[PATCH v3 4/4] fbdev: hyperv_fb: Fix mmap of framebuffers allocated using alloc_pages()

2025-05-23 Thread mhkelley58
From: Michael Kelley Framebuffer memory allocated using alloc_pages() was added to hyperv_fb in commit 3a6fb6c4255c ("video: hyperv: hyperv_fb: Use physical memory for fb on HyperV Gen 1 VMs.") in kernel version 5.6. But mmap'ing such framebuffers into user space has never worked due to limitatio

Re: [PATCH next] drm/panel: nt37801: Fix IS_ERR() vs NULL check in probe()

2025-05-23 Thread Jessica Zhang
On 5/23/2025 9:09 AM, Dan Carpenter wrote: The devm_drm_panel_alloc() function returns error pointers, it doesn't return NULL. Update the check to match. Fixes: 4fca6849864d ("drm/panel: Add Novatek NT37801 panel driver") Signed-off-by: Dan Carpenter Reviewed-by: Jessica Zhang --- dr

Re: [PATCH] drivers: gpu: drm: msm: registers: improve reproducibility

2025-05-23 Thread Dmitry Baryshkov
On Fri, May 23, 2025 at 06:36:16PM +0530, Viswanath Kraleti wrote: > The files generated by gen_header.py capture the source path to the > input files and the date. While that can be informative, it varies You are not the author of this patch. Why did you drop authorshop information when picking

Re: [rfc] drm/ttm/memcg: simplest initial memcg/ttm integration (v2)

2025-05-23 Thread Tejun Heo
Hello, Christian. On Fri, May 23, 2025 at 09:58:58AM +0200, Christian König wrote: ... > > - There's a GPU workload which uses a sizable amount of system memory for > > the pool being discussed in this thread. This GPU workload is very > > important, so we want to make sure that other activiti

Re: [PATCH next] drm/panel: nt37801: Fix IS_ERR() vs NULL check in probe()

2025-05-23 Thread Krzysztof Kozlowski
On 23/05/2025 18:09, Dan Carpenter wrote: > The devm_drm_panel_alloc() function returns error pointers, it doesn't > return NULL. Update the check to match. > > Fixes: 4fca6849864d ("drm/panel: Add Novatek NT37801 panel driver") > Signed-off-by: Dan Carpenter Reviewed-by: Krzysztof Kozlowski

[PATCH 0/2] MAINTAINERS: update my email address and drop myself as maintainer

2025-05-23 Thread Abhinav Kumar
MAINTAINERS | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) --- base-commit: 176e917e010cb7dcc605f11d2bc33f304292482b change-id: 20250523-maintainers_update-83ddc685d3e4 Best regards, -- Abhinav Kumar

[PATCH 1/2] MAINTAINERS: drop myself as maintainer

2025-05-23 Thread Abhinav Kumar
I will no longer regularly work on this platform. Hence will step down from maintainer duties. Also, add Jessica as a reviewer to the MSM DRM subsystem to help out with the reviews. Signed-off-by: Abhinav Kumar --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH 2/2] MAINTAINERS: update my email address

2025-05-23 Thread Abhinav Kumar
My current email address will stop working soon. Use linux.dev email instead. Signed-off-by: Abhinav Kumar --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 3bc0da6f9033be0d5da35210a84ba189be4e5c0c..c2244004b966368fd4084d579d

Re: [PATCH 1/2] MAINTAINERS: drop myself as maintainer

2025-05-23 Thread Rob Clark
On Fri, May 23, 2025 at 11:27 AM Abhinav Kumar wrote: > > I will no longer regularly work on this platform. Hence will > step down from maintainer duties. > > Also, add Jessica as a reviewer to the MSM DRM subsystem to help > out with the reviews. > > Signed-off-by: Abhinav Kumar Acked-by: Rob C

Re: [PATCH 2/2] MAINTAINERS: update my email address

2025-05-23 Thread Rob Clark
On Fri, May 23, 2025 at 11:27 AM Abhinav Kumar wrote: > > My current email address will stop working soon. Use > linux.dev email instead. > > Signed-off-by: Abhinav Kumar Acked-by: Rob Clark > --- > MAINTAINERS | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/MAINT

Re: [rfc] drm/ttm/memcg: simplest initial memcg/ttm integration (v2)

2025-05-23 Thread Christian König
Hi Tejun, first of all thanks to Johannes and you for the input, it took me quite some time to actually get a grip on your concern here. On 5/22/25 21:51, Tejun Heo wrote: > Hello, > > On Sat, May 17, 2025 at 06:25:02AM +1000, Dave Airlie wrote: >> I think this is where we have 2 options: >> (a

Re: [PATCH 2/3] drm/amdgpu: Adding amdgpu CRIU ioctl

2025-05-23 Thread Dan Carpenter
/drm drm-next patch link: https://lore.kernel.org/r/20250521140649.4058526-3-David.Francis%40amd.com patch subject: [PATCH 2/3] drm/amdgpu: Adding amdgpu CRIU ioctl config: loongarch-randconfig-r073-20250522 (https://download.01.org/0day-ci/archive/20250523/202505230705.6eooxlbq-...@intel.com

Re: [PATCH 5/8] drm/i915: Associate ACPI connector nodes with connector entries (v2)

2025-05-23 Thread Jani Nikula
Resurrecting an old thread because I am clueless and I have questions. :) On Tue, 17 Aug 2021, Hans de Goede wrote: > From: Heikki Krogerus > > On Intel platforms we know that the ACPI connector device > node order will follow the order the driver (i915) decides. > The decision is made using t

Re:Re: [PATCH] drm/rockchip: Use dev_err_probe() to simplify code

2025-05-23 Thread Andy Yan
Hi, 在 2025-05-22 16:45:08,"Krzysztof Kozlowski" 写道: >On 16/05/2025 11:58, Heiko Stübner wrote: >> Am Donnerstag, 15. Mai 2025, 17:54:20 Mitteleuropäische Sommerzeit schrieb >> Krzysztof Kozlowski: >>> On 15/05/2025 14:35, long.yunj...@zte.com.cn wrote: From: Yumeng Fang In the pr

[PATCH] drm: add overview diagram for drm stack

2025-05-23 Thread Abdulrasaq Lawani
Add an overview diagram of Linux DRM architecture for graphics and compute to introduction.rst --- Signed-off-by: Abdulrasaq Lawani --- Documentation/gpu/introduction.rst | 38 +- 1 file changed, 37 insertions(+), 1 deletion(-) diff --git a/Documentation/gpu/

Re: [PATCH v5 21/24] drm/msm/dpu: Implement 10-bit color alpha for v12.0 DPU

2025-05-23 Thread Abel Vesa
On 25-05-23 09:55:00, Abel Vesa wrote: > On 25-04-30 15:00:51, Krzysztof Kozlowski wrote: > > v12.0 DPU on SM8750 comes with 10-bit color alpha. Add register > > differences and new implementations of setup_alpha_out(), > > setup_border_color() and setup_blend_config(). > > > > Reviewed-by: Dmitr

RE: (subset) [PATCH v6 00/10] drm/display: generic HDMI CEC helpers

2025-05-23 Thread Biju Das
Hi Dmitry Baryshkov, > -Original Message- > From: Dmitry Baryshkov > Sent: 23 May 2025 07:37 > Subject: Re: (subset) [PATCH v6 00/10] drm/display: generic HDMI CEC helpers > > Hi Biju > > On Fri, 23 May 2025 at 09:17, Biju Das wrote: > > > > Hi Dmitry Baryshkov, > > > > Thanks for the

Re: [PATCH v9 1/9] optee: sync secure world ABI headers

2025-05-23 Thread Sumit Garg
On Tue, May 20, 2025 at 05:16:44PM +0200, Jens Wiklander wrote: > Update the header files describing the secure world ABI, both with and > without FF-A. The ABI is extended to deal with protected memory, but as > usual backward compatible. > > Signed-off-by: Jens Wiklander > --- > drivers/tee/op

Re: [PATCH 1/4] drm/sched: optimize drm_sched_job_add_dependency a bit

2025-05-23 Thread Tvrtko Ursulin
On 22/05/2025 17:19, Christian König wrote: On 5/22/25 16:27, Tvrtko Ursulin wrote: On 22/05/2025 14:41, Christian König wrote: Since we already iterated over the xarray we know at which index the new entry should be stored. So instead of using xa_alloc use xa_store and write into the index

[PULL] drm-xe-next-fixes

2025-05-23 Thread Thomas Hellstrom
Hi Dave, Simona This week's drm-xe-next-fixes PR. Two small fixes. Thanks Thomas drm-xe-next-fixes-2025-05-23: Driver Changes: - Fix a SLPC debugfs NULL pointer dereference (Aradhya) - Fix an arbitrary value sysfs read return (Aradhya) The following changes since commit 1faeeb315fdbd005bbc1bc742

Re: [PATCH v5 21/24] drm/msm/dpu: Implement 10-bit color alpha for v12.0 DPU

2025-05-23 Thread Dmitry Baryshkov
On Fri, May 23, 2025 at 10:02:03AM +0300, Abel Vesa wrote: > On 25-05-23 09:55:00, Abel Vesa wrote: > > On 25-04-30 15:00:51, Krzysztof Kozlowski wrote: > > > v12.0 DPU on SM8750 comes with 10-bit color alpha. Add register > > > differences and new implementations of setup_alpha_out(), > > > setup

Re: linux-next: manual merge of the rust tree with the drm tree

2025-05-23 Thread Miguel Ojeda
On Fri, May 23, 2025 at 8:14 AM Stephen Rothwell wrote: > > I fixed it up (see below) and can carry the fix as necessary. This > is now fixed as far as linux-next is concerned, but any non trivial > conflicts should be mentioned to your upstream maintainer when your tree > is submitted for merging

Re: [PATCH v5 21/24] drm/msm/dpu: Implement 10-bit color alpha for v12.0 DPU

2025-05-23 Thread Krzysztof Kozlowski
On 23/05/2025 09:02, Abel Vesa wrote: >>> static void _dpu_crtc_setup_blend_cfg(struct dpu_crtc_mixer *mixer, >>> - struct dpu_plane_state *pstate, const struct msm_format *format) >>> + struct dpu_plane_state *pstate, >>> +

Re: [PATCH v9 13/14] drm/msm/dpu: support plane splitting in quad-pipe case

2025-05-23 Thread Jun Nie
Jessica Zhang 于2025年5月9日周五 05:24写道: > > > > On 5/6/2025 8:47 AM, Jun Nie wrote: > > The content of every half of screen is sent out via one interface in > > dual-DSI case. The content for every interface is blended by a LM > > pair in quad-pipe case, thus a LM pair should not blend any content > >

Re: [PATCH] drm/i915/display: Use str_true_false() helper

2025-05-23 Thread Jani Nikula
On Fri, 23 May 2025, wrote: > From: Yumeng Fang > > Remove hard-coded strings by using the str_true_false() helper. > > Signed-off-by: Yumeng Fang > Signed-off-by: Yunjian Long Pushed to drm-intel-next, thanks for the patch. BR, Jani. > --- > drivers/gpu/drm/i915/display/intel_display_debu

Re: [PATCH v9 09/14] drm/msm/dpu: split PIPES_PER_STAGE definition per plane and mixer

2025-05-23 Thread Jun Nie
Jessica Zhang 于2025年5月9日周五 04:55写道: > > > > On 5/8/2025 1:42 PM, Jessica Zhang wrote: > > > > > > On 5/6/2025 8:47 AM, Jun Nie wrote: > >> The stage contains configuration for a mixer pair. Currently the plane > >> supports just one stage and 2 pipes. Quad-pipe support will require > >> handling 2

Re: [PATCH] drm: add overview diagram for drm stack

2025-05-23 Thread Jonathan Corbet
Abdulrasaq Lawani writes: > Add an overview diagram of Linux DRM architecture for > graphics and compute to introduction.rst > > --- > Signed-off-by: Abdulrasaq Lawani > --- > Documentation/gpu/introduction.rst | 38 > +- > 1 file changed, 37 insertions(+),

Re: [PATCH v4 2/4] drm/panel: Add refcount support

2025-05-23 Thread Jani Nikula
On Tue, 20 May 2025, Jani Nikula wrote: > Maxime - > > I'm cutting a lot of context here. Not because I don't think it deserves > an answer, but because I seem to be failing at communication. > > On Mon, 19 May 2025, Maxime Ripard wrote: >> You still haven't explained why it would take anything m

[PATCH] drm/panel: nt37801: select CONFIG_DRM_DISPLAY_DSC_HELPER

2025-05-23 Thread Arnd Bergmann
From: Arnd Bergmann The newly added driver uses the DSC helper module, but does not select its Kconfig symbol, so configurations are possible that cause a link failure: ERROR: modpost: "drm_dsc_pps_payload_pack" [drivers/gpu/drm/panel/panel-novatek-nt37801.ko] undefined! Fixes: 4fca6849864d ("

[PATCH] drm/xe/vsec: fix CONFIG_INTEL_VSEC dependency

2025-05-23 Thread Arnd Bergmann
From: Arnd Bergmann The XE driver can be built with or without VSEC support, but fails to link as built-in if vsec is in a loadable module: x86_64-linux-ld: vmlinux.o: in function `xe_vsec_init': (.text+0x1e83e16): undefined reference to `intel_vsec_register' The normal fix for this is to add a

Re: [PATCH] drm/panel: nt37801: select CONFIG_DRM_DISPLAY_DSC_HELPER

2025-05-23 Thread Krzysztof Kozlowski
On 23/05/2025 14:11, Arnd Bergmann wrote: > From: Arnd Bergmann > > The newly added driver uses the DSC helper module, but does not > select its Kconfig symbol, so configurations are possible that > cause a link failure: > > ERROR: modpost: "drm_dsc_pps_payload_pack" > [drivers/gpu/drm/panel/pa

Re: [PATCH v5 00/16] drm/vkms: Add configfs support

2025-05-23 Thread Louis Chauvet
Hi everyone, I have reviewed all the series, but I would appreciate an additional review for two important reasons: - This series introduces a new uAPI, and I believe it is crucial to have at least a third perspective before merging. - I was heavily involved in the creation of these patches, so

Re: [PATCH 9/9] iosys_map: embed the is_iomem bit into the pointer.

2025-05-23 Thread Jocelyn Falempe
On 22/05/2025 23:05, Lucas De Marchi wrote: On Fri, May 23, 2025 at 06:32:43AM +1000, Dave Airlie wrote: On Fri, 23 May 2025 at 01:10, Lucas De Marchi wrote: On Thu, May 22, 2025 at 04:52:18PM +1000, Dave Airlie wrote: >From: Dave Airlie > >This reduces this struct from 16 to 8 bytes, and it

Re: [PATCH next] drm/nouveau/tegra: Fix error pointer vs NULL return in nvkm_device_tegra_resource_addr()

2025-05-23 Thread Timur Tabi
On Fri, 2025-05-23 at 19:07 +0300, Dan Carpenter wrote: > The nvkm_device_tegra_resource() function returns a mix of error pointers > and NULL.  The callers only expect it to return NULL on error.  Change it > to only return NULL. > > Fixes: 76b8f81a5b92 ("drm/nouveau: improve handling of 64-bit B

Re: [PATCH] drm/panel: nt37801: select CONFIG_DRM_DISPLAY_DSC_HELPER

2025-05-23 Thread Dmitry Baryshkov
On Fri, 23 May 2025 14:11:22 +0200, Arnd Bergmann wrote: > The newly added driver uses the DSC helper module, but does not > select its Kconfig symbol, so configurations are possible that > cause a link failure: > > ERROR: modpost: "drm_dsc_pps_payload_pack" > [drivers/gpu/drm/panel/panel-novatek

Re: [PATCH] drm/panel: nt37801: select CONFIG_DRM_DISPLAY_DSC_HELPER

2025-05-23 Thread Dmitry Baryshkov
On Fri, May 23, 2025 at 02:11:22PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > The newly added driver uses the DSC helper module, but does not > select its Kconfig symbol, so configurations are possible that > cause a link failure: > > ERROR: modpost: "drm_dsc_pps_payload_pack" > [dri

[PATCH] DRM: Fix rbtree search issue of find_hole_addr

2025-05-23 Thread junan
I'm not sure if it is a bug or just for some special purposes in the function "find_hole_addr", the original implementation is as follows: static struct drm_mm_node *find_hole_addr(struct drm_mm *mm, u64 addr, u64 size) { struct rb_node *rb = mm->holes_addr.rb_node; struct drm_mm_n

[PATCH v2 2/2] drm: add overview diagram for drm stack

2025-05-23 Thread Abdulrasaq Lawani
Put overview diagram into a literal block and set its section title to a higher order --- Documentation/gpu/introduction.rst | 72 -- 1 file changed, 37 insertions(+), 35 deletions(-) diff --git a/Documentation/gpu/introduction.rst b/Documentation/gpu/introduc

[PATCH] drm/nouveau/mmu: fix potential overflow in PFN size calculation

2025-05-23 Thread Alexey Nepomnyashih
On most Linux-supported platforms, `int` is 32-bit, making (1 << 47) undefined and potentially dangerous. To ensure defined behavior and correct 64-bit arithmetic, replace `1` with `1ULL`. Found by Linux Verification Center (linuxtesting.org) with SVACE. Cc: sta...@vger.kernel.org # v5.1+ Fixes:

[PATCH v2 0/2] drm: add overview diagram for drm stack

2025-05-23 Thread Abdulrasaq Lawani
Signed-off-by: Abdulrasaq Lawani --- Changes in v2: - Update the overview diagram to display correctly by putting in a literal block. - Also update the overview section diagram to a higher order. - Ensured docs are successfully rendering by building for htmldocs and pdfdocs. - Rendered pages are

Re: (subset) [PATCH v6 00/10] drm/display: generic HDMI CEC helpers

2025-05-23 Thread Dmitry Baryshkov
On Fri, 23 May 2025 at 17:16, Tommaso Merciai wrote: > > Hi Biju, Dmitry, > > On Fri, May 23, 2025 at 03:47:24PM +0200, Tommaso Merciai wrote: > > Hi Biju, Dmitry, > > Thanks for your comments. > > > > On Fri, May 23, 2025 at 09:37:19AM +0300, Dmitry Baryshkov wrote: > > > Hi Biju > > > > > > On F

Re: 6.15-rc6/regression/bisected - after commit f1c6be3999d2 error appeared: *ERROR* dc_dmub_srv_log_diagnostic_data: DMCUB error

2025-05-23 Thread Mikhail Gavrilov
On Wed, May 21, 2025 at 10:13 PM Pillai, Aurabindo wrote: > > [AMD Official Use Only - AMD Internal Distribution Only] > > > Hi Mike, > > Thanks for the details. We tried to repro the issue at our end on 9000 and > 7000 series dgpu, but we're not seeing the dmub errors. We were on Ubunti, so > w

[RFC PATCH v2 0/2] Virtio-GPU suspend and resume

2025-05-23 Thread dongwon . kim
From: Dongwon Kim This patch series introduces a freeze and restore mechanism for the virtio-gpu driver: First patch adds `virtgpu_freeze` and `virtgpu_restore` functions. These functions handle the deletion of virtio queues before suspension and their recreation during the restoration process.

[RFC PATCH v2 1/2] drm/virtio: Freeze and restore hooks to support suspend and resume

2025-05-23 Thread dongwon . kim
From: Dongwon Kim virtio device needs to delete before VM suspend happens then reinitialize all virtqueues again upon resume v2: 10ms sleep was added in virtgpu_freeze to avoid the situation the driver is locked up during resumption. Cc: Dmitry Osipenko Cc: Vivek Kasireddy Signed-off-by:

[RFC PATCH v2 2/2] drm/virtio: Implement save and restore for virtio_gpu_objects

2025-05-23 Thread dongwon . kim
From: Dongwon Kim Host KVM/QEMU loses all graphics resources submitted by the guest OS upon resumption from sleep or hibernation. This results in invalid resource errors when the guest OS attempts to interact with the host regarding those resources. To address this issue, the virtio-gpu driver n

[PATCH v2 1/2] drm: add overview diagram for drm stack

2025-05-23 Thread Abdulrasaq Lawani
Add an overview diagram of Linux DRM architecture for graphics and compute to introduction.rst --- Documentation/gpu/introduction.rst | 38 +- 1 file changed, 37 insertions(+), 1 deletion(-) diff --git a/Documentation/gpu/introduction.rst b/Documentation/gpu/i

Re: [PATCH] drm/connector: move HDR sink metadata to display info

2025-05-23 Thread Dmitry Baryshkov
On Mon, May 19, 2025 at 02:29:00PM +0300, Jani Nikula wrote: > Information parsed from the display EDID should be stored in display > info. Move HDR sink metadata there. > > Signed-off-by: Jani Nikula > > --- > > This depends on commit 6692dbc15e5e ("drm/edid: fixed the bug that hdr > metadata

Re: [PATCH] drm: sysfs: Replace magic number with DRM_FORCE_UNSPECIFIED macro

2025-05-23 Thread Dmitry Baryshkov
On Fri, May 16, 2025 at 04:18:13PM +0800, hongao wrote: > Replace the direct use of magic number '0' with the DRM_FORCE_UNSPECIFIED > macro to improve code readability. > > Signed-off-by: hongao > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v2] drm/rockchip: cdn-dp: Convert to drm bridge

2025-05-23 Thread Dmitry Baryshkov
On Fri, May 23, 2025 at 09:13:10AM +0800, Chaoyi Chen wrote: > From: Chaoyi Chen > > Convert it to drm bridge driver, it will be convenient for us to > migrate the connector part to the display driver later. > > Considering that some code depend on the connector, the following > changes have bee

[git pull] drm fixes for 6.15-rc8/final

2025-05-23 Thread Dave Airlie
Hi Linus, Weekly drm fixes pull, on target to be quiet, just one amdgpu, one edid and a few minor xe fixes. Regards, Dave. drm-fixes-2025-05-24: drm fixes for 6.15-rc8/final edid: - fix HDR metadata reset amdgpu: - Hibernate fix xe: - Make sure to check all forcewakes when dumping mocs - Fix

Re: [git pull] drm fixes for 6.15-rc8/final

2025-05-23 Thread pr-tracker-bot
The pull request you sent on Sat, 24 May 2025 08:15:22 +1000: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-fixes-2025-05-24 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/4856ebd997159f198e3177e515bda01143727463 Thank you! -- Deet-doot-dot, I am a bot. h

Re: [PATCH next] drm/plane: Fix error pointer vs NULL bug in create_in_format_blob()

2025-05-23 Thread Dmitry Baryshkov
On Fri, May 23, 2025 at 07:07:32PM +0300, Dan Carpenter wrote: > The callers expect to receive error pointers on error but > create_in_format_blob() returns NULL. Change it to return error > pointers. > > Fixes: 0d6dcd741c26 ("drm/plane: modify create_in_formats to acommodate > async") > Signed-

Re: [PATCH next] drm/panel: nt37801: Fix IS_ERR() vs NULL check in probe()

2025-05-23 Thread Dmitry Baryshkov
On Fri, 23 May 2025 19:09:03 +0300, Dan Carpenter wrote: > The devm_drm_panel_alloc() function returns error pointers, it doesn't > return NULL. Update the check to match. > > Applied to drm-misc-next-fixes, thanks! [1/1] drm/panel: nt37801: Fix IS_ERR() vs NULL check in probe() commit:

Re: [PATCH 1/3] drm/bridge: fsl-ldb: make use of driver_private

2025-05-23 Thread Dmitry Baryshkov
On Thu, May 15, 2025 at 01:04:52AM +0200, Marco Felsch wrote: > Hi Laurent, > > On 25-05-15, Laurent Pinchart wrote: > > Hi Marco, > > > > Thank you for the patch. > > > > On Thu, May 15, 2025 at 12:24:51AM +0200, Marco Felsch wrote: > > > Make use of the drm_bridge::driver_private data instead

Re: [RFC PATCH 00/12] Private MMIO support for private assigned dev

2025-05-23 Thread Xu Yilun
On Thu, May 22, 2025 at 01:45:57PM +1000, Alexey Kardashevskiy wrote: > > > On 16/5/25 02:04, Xu Yilun wrote: > > On Wed, May 14, 2025 at 01:33:39PM -0300, Jason Gunthorpe wrote: > > > On Wed, May 14, 2025 at 03:02:53PM +0800, Xu Yilun wrote: > > > > > We have an awkward fit for what CCA people a

Re: [RFC PATCH 00/12] Private MMIO support for private assigned dev

2025-05-23 Thread Xu Yilun
On Tue, May 20, 2025 at 08:57:42PM +1000, Alexey Kardashevskiy wrote: > > > On 16/5/25 04:02, Xu Yilun wrote: > > > IMHO, I think it might be helpful that you can picture out what are the > > > minimum requirements (function/life cycle) to the current IOMMUFD TSM > > > bind architecture: > > > >

Re: [PATCH] drm: add overview diagram for drm stack

2025-05-23 Thread Abdulrasaq Lawani
Thanks for the feedback. I have added the fixes and sent another version (v2) of the patch. https://lore.kernel.org/all/20250523-drm-doc-updates-v2-0-e517df152...@gmail.com/ best regards, Abdulrasaq On Fri, May 23, 2025 at 7:58 AM Jonathan Corbet wrote: > Abdulrasaq Lawani writes: > &

[PATCH] drm/amdgpu: fix NULL dereference in gfx_v9_0_kcq() and kiq_init_queue()

2025-05-23 Thread Alexey Nepomnyashih
A potential NULL pointer dereference may occur when accessing tmp_mqd->cp_hqd_pq_control without verifying that tmp_mqd is non-NULL. This may happen if mqd_backup[mqd_idx] is unexpectedly NULL. Although a NULL check for mqd_backup[mqd_idx] existed previously, it was moved to a position after the