Re: [RFC PATCH 00/12] Private MMIO support for private assigned dev

2025-05-15 Thread Zhi Wang
On Thu, 15 May 2025 16:44:47 + Zhi Wang wrote: > On 15.5.2025 13.29, Alexey Kardashevskiy wrote: > > > > > > On 13/5/25 20:03, Zhi Wang wrote: > >> On Mon, 12 May 2025 11:06:17 -0300 > >> Jason Gunthorpe wrote: > >> > >>> On Mon, May 12, 2025 at 07:30:21PM +1000, Alexey Kardashevskiy > >>>

Re: [PATCH v4 04/40] drm/sched: Add enqueue credit limit

2025-05-15 Thread Connor Abbott
On Thu, May 15, 2025 at 12:15 PM Rob Clark wrote: > > On Thu, May 15, 2025 at 2:28 AM Philipp Stanner wrote: > > > > Hello, > > > > On Wed, 2025-05-14 at 09:59 -0700, Rob Clark wrote: > > > From: Rob Clark > > > > > > Similar to the existing credit limit mechanism, but applying to jobs > > > enq

Re: [PATCH V9 00/43] Color Pipeline API w/ VKMS

2025-05-15 Thread Daniel Stone
Hi, On Thu, 15 May 2025 at 15:11, Harry Wentland wrote: > On 2025-05-15 05:45, Simon Ser wrote: > > I've reviewed all of the core DRM patches :) > > > > Have there been updates from user-space implementations? > > I know Leandro has been working on Weston to make use of > this and last year Xaver

Re: [PATCH RFT v2 13/15] soc: qcom: ubwc: Fix SM6125's ubwc_swizzle value

2025-05-15 Thread Konrad Dybcio
On 5/15/25 6:21 PM, Dmitry Baryshkov wrote: > On 15/05/2025 19:18, Konrad Dybcio wrote: >> On 5/14/25 10:33 PM, Dmitry Baryshkov wrote: >>> On 14/05/2025 23:05, Konrad Dybcio wrote: On 5/14/25 9:23 PM, Dmitry Baryshkov wrote: > On Wed, May 14, 2025 at 05:10:33PM +0200, Konrad Dybcio wrote:

Re: [RFC PATCH 00/12] Private MMIO support for private assigned dev

2025-05-15 Thread Zhi Wang
On 15.5.2025 13.29, Alexey Kardashevskiy wrote: > > > On 13/5/25 20:03, Zhi Wang wrote: >> On Mon, 12 May 2025 11:06:17 -0300 >> Jason Gunthorpe wrote: >> >>> On Mon, May 12, 2025 at 07:30:21PM +1000, Alexey Kardashevskiy wrote: >>> >> I'm surprised by this.. iommufd shouldn't be doing PCI s

Re: [PATCH 2/5] drm/msm/dpu: Add max pingpong and dsc width to HW catalog

2025-05-15 Thread Jessica Zhang
On 5/14/2025 5:21 PM, Dmitry Baryshkov wrote: On Wed, May 14, 2025 at 04:52:30PM -0700, Jessica Zhang wrote: Add max_dsc_encoder_width to dpu_caps struct and max_linewidth to dpu_pingpong_cfg for all chipsets within the HW catalog. Note: The max supported PINGPONG width was 4096 but increase

Re: [PATCH v4 04/40] drm/sched: Add enqueue credit limit

2025-05-15 Thread Danilo Krummrich
On Thu, May 15, 2025 at 09:15:08AM -0700, Rob Clark wrote: > Basically it is a way to throttle userspace to prevent it from OoM'ing > itself. (I suppose userspace could throttle itself, but it doesn't > really know how much pre-allocation will need to be done for pgtable > updates.) I assume you

Re: [PATCH v4 02/40] drm/gpuvm: Allow VAs to hold soft reference to BOs

2025-05-15 Thread Rob Clark
On Thu, May 15, 2025 at 8:30 AM Danilo Krummrich wrote: > > On Thu, May 15, 2025 at 07:59:16AM -0700, Rob Clark wrote: > > Thanks for the detailed explanation! > > > On Thu, May 15, 2025 at 2:00 AM Danilo Krummrich wrote: > > > > > > On Wed, May 14, 2025 at 10:53:16AM -0700, Rob Clark wrote: > >

[PATCH v2 2/2] drm/bridge: fsl-ldb: simplify device_node error handling

2025-05-15 Thread Marco Felsch
Make use of __free(device_node) to simplify the of_node_put() error handling paths. No functional changes. Signed-off-by: Marco Felsch --- Changelog: v2: - drop __free() from panel_node drivers/gpu/drm/bridge/fsl-ldb.c | 22 -- 1 file changed, 8 insertions(+), 14 deletions(

[PATCH v2 1/2] drm/bridge: fsl-ldb: make use of dev_err_probe

2025-05-15 Thread Marco Felsch
Make use of dev_err_probe() to easily spot issues via the debugfs or kernel log. No functional changes. Signed-off-by: Marco Felsch Reviewed-by: Laurent Pinchart Reviewed-by: Alexander Stein --- Changelog: v2: - add Laurent's r-b - add Alexander's r-b drivers/gpu/drm/bridge/fsl-ldb.c | 19 +

Re: [PATCH v4 04/40] drm/sched: Add enqueue credit limit

2025-05-15 Thread Rob Clark
On Thu, May 15, 2025 at 10:23 AM Danilo Krummrich wrote: > > On Thu, May 15, 2025 at 09:15:08AM -0700, Rob Clark wrote: > > Basically it is a way to throttle userspace to prevent it from OoM'ing > > itself. (I suppose userspace could throttle itself, but it doesn't > > really know how much pre-al

[PATCH v2 0/2] i.MX fsl-ldb cleanups

2025-05-15 Thread Marco Felsch
Hi, just a small series to cleanup the fsl-ldb lvds bridge driver a bit. Regards, Marco Marco Felsch (2): drm/bridge: fsl-ldb: make use of dev_err_probe drm/bridge: fsl-ldb: simplify device_node error handling drivers/gpu/drm/bridge/fsl-ldb.c | 41 ++-- 1 file c

Re: [PATCH v4 04/40] drm/sched: Add enqueue credit limit

2025-05-15 Thread Danilo Krummrich
(Cc: Boris) On Thu, May 15, 2025 at 12:22:18PM -0400, Connor Abbott wrote: > For some context, other drivers have the concept of a "synchronous" > VM_BIND ioctl which completes immediately, and drivers implement it by > waiting for the whole thing to finish before returning. Nouveau implements sy

Re: [PATCH v4 01/40] drm/gpuvm: Don't require obj lock in destructor path

2025-05-15 Thread Rob Clark
On Thu, May 15, 2025 at 2:06 AM Danilo Krummrich wrote: > > On Thu, May 15, 2025 at 10:54:27AM +0200, Danilo Krummrich wrote: > > Hi Rob, > > > > Can you please CC me on patches for GPUVM? > > > > On Wed, May 14, 2025 at 10:53:15AM -0700, Rob Clark wrote: > > > From: Rob Clark > > > > > > See com

Re: [PATCH v4 04/40] drm/sched: Add enqueue credit limit

2025-05-15 Thread Rob Clark
On Thu, May 15, 2025 at 10:30 AM Danilo Krummrich wrote: > > (Cc: Boris) > > On Thu, May 15, 2025 at 12:22:18PM -0400, Connor Abbott wrote: > > For some context, other drivers have the concept of a "synchronous" > > VM_BIND ioctl which completes immediately, and drivers implement it by > > waiting

Re: [PATCH v4 02/40] drm/gpuvm: Allow VAs to hold soft reference to BOs

2025-05-15 Thread Danilo Krummrich
On Thu, May 15, 2025 at 10:34:07AM -0700, Rob Clark wrote: > On Thu, May 15, 2025 at 8:30 AM Danilo Krummrich wrote: > > > > On Thu, May 15, 2025 at 07:59:16AM -0700, Rob Clark wrote: > > > > Thanks for the detailed explanation! > > > > > On Thu, May 15, 2025 at 2:00 AM Danilo Krummrich wrote: >

Re: [PATCH v4 01/40] drm/gpuvm: Don't require obj lock in destructor path

2025-05-15 Thread Danilo Krummrich
On Thu, May 15, 2025 at 10:35:21AM -0700, Rob Clark wrote: > On Thu, May 15, 2025 at 2:06 AM Danilo Krummrich wrote: > > > > On Thu, May 15, 2025 at 10:54:27AM +0200, Danilo Krummrich wrote: > > > Hi Rob, > > > > > > Can you please CC me on patches for GPUVM? > > > > > > On Wed, May 14, 2025 at 10

Re: [PATCH RFT v2 13/15] soc: qcom: ubwc: Fix SM6125's ubwc_swizzle value

2025-05-15 Thread Konrad Dybcio
On 5/15/25 7:15 PM, Dmitry Baryshkov wrote: > On Thu, 15 May 2025 at 19:36, Konrad Dybcio > wrote: >> >> On 5/15/25 6:21 PM, Dmitry Baryshkov wrote: >>> On 15/05/2025 19:18, Konrad Dybcio wrote: On 5/14/25 10:33 PM, Dmitry Baryshkov wrote: > On 14/05/2025 23:05, Konrad Dybcio wrote: >

Re: [RFC PATCH 00/12] Private MMIO support for private assigned dev

2025-05-15 Thread Jason Gunthorpe
On Fri, May 16, 2025 at 12:04:04AM +0800, Xu Yilun wrote: > > arches this was mostly invisible to the hypervisor? > > Attest & Accept can be invisible to hypervisor, or host just help pass > data blobs between guest, firmware & device. > > Bind cannot be host agnostic, host should be aware not to

Re: [PATCH RFT v2 13/15] soc: qcom: ubwc: Fix SM6125's ubwc_swizzle value

2025-05-15 Thread Dmitry Baryshkov
On 15/05/2025 20:56, Konrad Dybcio wrote: On 5/15/25 7:15 PM, Dmitry Baryshkov wrote: On Thu, 15 May 2025 at 19:36, Konrad Dybcio wrote: On 5/15/25 6:21 PM, Dmitry Baryshkov wrote: On 15/05/2025 19:18, Konrad Dybcio wrote: On 5/14/25 10:33 PM, Dmitry Baryshkov wrote: On 14/05/2025 23:05, K

Re: Kernels >= 6.3 disable video output

2025-05-15 Thread Harry Wentland
Hi Steven, thanks for the bisect. In order to avoid display artifacts (especially for HDR) we had to allow higher bit depth color output on the wire. The driver should fallback to a lower resolution as needed but looks like there's a bug with this particular TV. Are you able to share the specific

Re: [PATCH v2 3/3] drm/panfrost: show device-wide list of DRM GEM objects over DebugFS

2025-05-15 Thread Daniel Stone
Hi Steven, On Thu, 8 May 2025 at 11:42, Steven Price wrote: > I'm also seeing a splat when running this, see below. I haven't got my > head around how this is happening, but I see it when glmark quits at the > end of the test. > > [ 399.505066] Unable to handle kernel NULL pointer dereference at

Re: [RFC PATCH 00/12] Private MMIO support for private assigned dev

2025-05-15 Thread Xu Yilun
> IMHO, I think it might be helpful that you can picture out what are the > minimum requirements (function/life cycle) to the current IOMMUFD TSM > bind architecture: > > 1.host tsm_bind (preparation) is in IOMMUFD, triggered by QEMU handling > the TVM-HOST call. > 2. TDI acceptance is handled in

Re: [PATCH 1/3] samples: rust: select AUXILIARY_BUS instead of depending on it

2025-05-15 Thread Greg KH
On Thu, May 15, 2025 at 03:26:13PM +0900, Alexandre Courbot wrote: > CONFIG_AUXILIARY_BUS cannot be enabled explicitly, and unless we select > it we have no way to include it (and thus to enable the auxiliary driver > sample) unless a driver happens to do it for us. > > Signed-off-by: Alexandre Co

Re: [PATCH v4 05/40] iommu/io-pgtable-arm: Add quirk to quiet WARN_ON()

2025-05-15 Thread Will Deacon
On Wed, May 14, 2025 at 10:53:19AM -0700, Rob Clark wrote: > From: Rob Clark > > In situations where mapping/unmapping sequence can be controlled by > userspace, attempting to map over a region that has not yet been > unmapped is an error. But not something that should spam dmesg. > > Now that

Re: [PATCH RFT v2 13/15] soc: qcom: ubwc: Fix SM6125's ubwc_swizzle value

2025-05-15 Thread Dmitry Baryshkov
On Thu, 15 May 2025 at 19:36, Konrad Dybcio wrote: > > On 5/15/25 6:21 PM, Dmitry Baryshkov wrote: > > On 15/05/2025 19:18, Konrad Dybcio wrote: > >> On 5/14/25 10:33 PM, Dmitry Baryshkov wrote: > >>> On 14/05/2025 23:05, Konrad Dybcio wrote: > On 5/14/25 9:23 PM, Dmitry Baryshkov wrote: > >>

Re: [PATCH v10 05/11] dt-bindings: allwinner: add H616 DE33 bus binding

2025-05-15 Thread Chen-Yu Tsai
On Sun, May 11, 2025 at 6:42 PM Ryan Walklin wrote: > > The Allwinner H616 and variants have a new display engine revision > (DE33). > > Add a display engine bus binding for the DE33. > > Signed-off-by: Ryan Walklin > Acked-by: Conor Dooley > Reviewed-by: Chen-Yu Tsai > Signed-off-by: Chris Mor

Re: [PATCH 0/3] rust: select AUXILIARY_BUS instead of depending on it

2025-05-15 Thread Alexandre Courbot
On Thu May 15, 2025 at 3:26 PM JST, Alexandre Courbot wrote: > I noticed this after trying to understand why my minimal Nova defconfig > was not selecting NOVA_CORE anymore and why I couldn't even find it in > menuconfig. > > CONFIG_AUXILIARY_BUS cannot be enabled directly and must be selected by >

[PATCH v2 2/3] gpu: nova-core: select AUXILIARY_BUS instead of depending on it

2025-05-15 Thread Alexandre Courbot
CONFIG_AUXILIARY_BUS cannot be enabled explicitly, and unless we select it we have no way to include it (and thus to enable NOVA_CORE) unless another driver happens to do it for us. Fixes: e041d81a0377 ("gpu: nova-core: register auxiliary device for nova-drm") Signed-off-by: Alexandre Courbot ---

[PATCH v2 3/3] gpu: drm: nova: select AUXILIARY_BUS instead of depending on it

2025-05-15 Thread Alexandre Courbot
CONFIG_AUXILIARY_BUS cannot be enabled explicitly, and unless we select it we have no way to include it (and thus to enable NOVA_DRM) unless another driver happens to do it for us. Fixes: cdeaeb9dd762 ("drm: nova-drm: add initial driver skeleton") Signed-off-by: Alexandre Courbot --- drivers/gpu

[PATCH v2 0/3] rust: select AUXILIARY_BUS instead of depending on it

2025-05-15 Thread Alexandre Courbot
fixes into the original patches if you think it makes more sense. Signed-off-by: Alexandre Courbot --- Changes in v2: - Added missing Fixes: tags. - Collected Reviewed-by: tag. - Link to v1: https://lore.kernel.org/r/20250515-aux_bus-v1-0-1781b5442...@nvidia.com --- Alexandre Courbot (3): sa

[PATCH v2 1/3] samples: rust: select AUXILIARY_BUS instead of depending on it

2025-05-15 Thread Alexandre Courbot
CONFIG_AUXILIARY_BUS cannot be enabled explicitly, and unless we select it we have no way to include it (and thus to enable the auxiliary driver sample) unless a driver happens to do it for us. Fixes: 96609a1969f4 ("samples: rust: add Rust auxiliary driver sample") Reviewed-by: Greg Kroah-Hartman

[PULL] drm-intel-next-fixes

2025-05-15 Thread Joonas Lahtinen
Hi Dave & Sima, Here goes the drm-intel-next-fixes PR for this week. Just one MST fix and one PSR fix this round. The CI results for drm-intel-next-fixes are bit all over the place after -rc1, before further rc backmerges. Regards, Joonas *** drm-intel-next-fixes-2025-05-15: - Stop writing A

Re: [PATCH v2 1/7] dt-bindings: npu: rockchip,rknn: Add bindings

2025-05-15 Thread Tomeu Vizoso
On Wed, May 14, 2025 at 7:50 PM Nicolas Frattaroli wrote: > > On Wednesday, 14 May 2025 17:18:22 Central European Summer Time Tomeu Vizoso > wrote: > > Hi Nicolas, > > > > Thanks for looking at this. Some thoughts below: > > > > On Fri, Apr 25, 2025 at 8:50 PM Nicolas Frattaroli > > wrote: > > >

Re: [PATCH v7 2/2] drm/tests: bridge: add a KUnit test for devm_drm_bridge_alloc()

2025-05-15 Thread Maxime Ripard
On Tue, Apr 15, 2025 at 01:22:14PM +0200, Luca Ceresoli wrote: > > > +/* > > > + * Mimick the typical struct defined by a bridge driver, which embeds a > > > + * bridge plus other fields. > > > + */ > > > +struct dummy_drm_bridge { > > > + int dummy; // ensure we test non-zero @bridge offset > > >

Re: [5/7] ttm: add initial memcg integration. (v4)

2025-05-15 Thread Christian König
On 5/14/25 19:07, Maarten Lankhorst wrote: > Hey, > > On 2025-05-14 13:55, Christian König wrote: >> On 5/14/25 13:41, Maarten Lankhorst wrote: >>> Hi Dave, >>> >>> We've had a small discussion on irc, so I wanted to summarize it here: >>> >>> All memory allocated should be accounted, even memory

Re: [PATCH v4 01/40] drm/gpuvm: Don't require obj lock in destructor path

2025-05-15 Thread Danilo Krummrich
Hi Rob, Can you please CC me on patches for GPUVM? On Wed, May 14, 2025 at 10:53:15AM -0700, Rob Clark wrote: > From: Rob Clark > > See commit a414fe3a2129 ("drm/msm/gem: Drop obj lock in > msm_gem_free_object()") for justification. Please write a proper commit message that explains the proble

Re: [rfc] drm/ttm/memcg: simplest initial memcg/ttm integration (v2)

2025-05-15 Thread Christian König
On 5/15/25 05:02, Dave Airlie wrote: >> I have to admit I'm pretty clueless about the gpu driver internals and >> can't really judge how feasible this is. But from a cgroup POV, if you >> want proper memory isolation between groups, it seems to me that's the >> direction you'd have to take this in.

Re: [PATCH] drm/scheduler: signal scheduled fence when kill job

2025-05-15 Thread Christian König
Explicitly adding the scheduler maintainers. On 5/15/25 04:07, Lin.Cao wrote: > Previously we only signaled finished fence which may cause some > submission's dependency cannot be cleared the cause benchmark hang. > Signal both scheduled fence and finished fence could fix this issue. > > Signed-o

Re: [PATCH v4 02/40] drm/gpuvm: Allow VAs to hold soft reference to BOs

2025-05-15 Thread Danilo Krummrich
On Wed, May 14, 2025 at 10:53:16AM -0700, Rob Clark wrote: > From: Rob Clark > > Eases migration for drivers where VAs don't hold hard references to > their associated BO, avoiding reference loops. > > In particular, msm uses soft references to optimistically keep around > mappings until the BO

Re: [PATCH] drm/scheduler: signal scheduled fence when kill job

2025-05-15 Thread Philipp Stanner
On Thu, 2025-05-15 at 10:48 +0200, Christian König wrote: > Explicitly adding the scheduler maintainers. > > On 5/15/25 04:07, Lin.Cao wrote: > > Previously we only signaled finished fence which may cause some > > submission's dependency cannot be cleared the cause benchmark hang. > > Signal both

Re: [PATCH v4 08/11] tee: add Qualcomm TEE driver

2025-05-15 Thread Kuldeep Singh
On 5/14/2025 6:55 PM, Sumit Garg wrote: > Hi Amir, > > Apologies for getting to this patch review a bit late, mostly due to > it's enormous size. > > On Mon, Apr 28, 2025 at 11:06:29PM -0700, Amirreza Zarrabi wrote: >> Introduce qcomtee_object, which represents an object in both QTEE and >> th

Re: [PATCH v4 01/40] drm/gpuvm: Don't require obj lock in destructor path

2025-05-15 Thread Danilo Krummrich
On Thu, May 15, 2025 at 10:54:27AM +0200, Danilo Krummrich wrote: > Hi Rob, > > Can you please CC me on patches for GPUVM? > > On Wed, May 14, 2025 at 10:53:15AM -0700, Rob Clark wrote: > > From: Rob Clark > > > > See commit a414fe3a2129 ("drm/msm/gem: Drop obj lock in > > msm_gem_free_object()

Re: [PATCH v9 02/10] drm/sched: store the drm client_id in drm_sched_fence

2025-05-15 Thread Pierre-Eric Pelloux-Prayer
Hi, Le 14/05/2025 à 14:44, Philipp Stanner a écrit : On Thu, 2025-04-24 at 10:38 +0200, Pierre-Eric Pelloux-Prayer wrote: This will be used in a later commit to trace the drm client_id in some of the gpu_scheduler trace events. This requires changing all the users of drm_sched_job_init to add

Re: [PATCH v4 04/40] drm/sched: Add enqueue credit limit

2025-05-15 Thread Philipp Stanner
Hello, On Wed, 2025-05-14 at 09:59 -0700, Rob Clark wrote: > From: Rob Clark > > Similar to the existing credit limit mechanism, but applying to jobs > enqueued to the scheduler but not yet run. > > The use case is to put an upper bound on preallocated, and > potentially > unneeded, pgtable pag

Re: [5/7] ttm: add initial memcg integration. (v4)

2025-05-15 Thread Maarten Lankhorst
Hey, On 2025-05-15 10:40, Christian König wrote: > On 5/14/25 19:07, Maarten Lankhorst wrote: >> Hey, >> >> On 2025-05-14 13:55, Christian König wrote: >>> On 5/14/25 13:41, Maarten Lankhorst wrote: Hi Dave, We've had a small discussion on irc, so I wanted to summarize it here:

Re: [PATCH V9 03/43] drm/doc/rfc: Describe why prescriptive color pipeline is needed

2025-05-15 Thread Simon Ser
Reviewed-by: Simon Ser

[PATCH] accel/ivpu: Add inference_timeout_ms module parameter

2025-05-15 Thread Jacek Lawrynowicz
From: Karol Wachowski Add new inference_timeout_ms parameter that allows specifying maximum allowed duration in milliseconds that inference can take before triggering a recovery. Calculate maximum number of heartbeat retries based on ratio between inference timeout and tdr timeout. Signed-off-b

[PATCH v3 01/17] dt-bindings: soc: mediatek: add mutex yaml for MT8196

2025-05-15 Thread paul-pl . chen
From: Nancy Lin Add compatible string to support mutex for MT8196. Acked-by: Krzysztof Kozlowski Signed-off-by: Nancy Lin Signed-off-by: Paul-pl Chen --- .../devicetree/bindings/soc/mediatek/mediatek,mutex.yaml| 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/device

[PATCH v3 05/17] soc: mediatek: Add runtime PM and top clocks and async controls for MMSYS

2025-05-15 Thread paul-pl . chen
From: Nancy Lin - Add initialization of top clocks and async clocks for each MMSYS. - Add PM runtime control and new functions to manage these clocks. - Add functions to set these clocks according to the default configuration of the corresponding MMSYS. Signed-off-by: Nancy Lin Signed-off-by:

[PATCH v3 02/17] dt-bindings: display: mediatek: add EXDMA yaml for MT8196

2025-05-15 Thread paul-pl . chen
From: Paul-pl Chen Add mediatek,exdma.yaml to support EXDMA for MT8196. The MediaTek display overlap extended DMA engine, namely OVL_EXDMA or EXDMA, primarily functions as a DMA engine for reading data from DRAM with various DRAM footprints and data formats. Signed-off-by: Nancy Lin Signed-off-

[PATCH v3 15/17] drm/mediatek: add ovlsys_adaptor support for MT8196

2025-05-15 Thread paul-pl . chen
From: Nancy Lin Ovlsys_adaptor is an encapsulated module designed to simplify the DRM control flow. This module is composed of 20 EXDMAs, 20 BLENDERs, and 12 OUTPROCs. Two EXDMAs merge into one layer, allowing the module to support 20 layers for 3 display paths. Ovlsys_adaptor driver is integrate

[PATCH v3 08/17] soc: mediatek: mutex: refactor SOF settings for output components

2025-05-15 Thread paul-pl . chen
From: Paul-pl Chen Refactor SOF settings by adding mtk_mutex_get_output_comp_sof() and extracting SOF logic from mtk_mutex_add_comp() and mtk_mutex_remove_comp(). Signed-off-by: Nancy Lin Signed-off-by: Paul-pl Chen --- drivers/soc/mediatek/mtk-mutex.c | 60 +- i

[PATCH v3 14/17] drm/mediatek: add OUTPROC support for MT8196

2025-05-15 Thread paul-pl . chen
From: Nancy Lin OUTPROC handles the post-stage of pixel processing in the overlapping procedure.OUTPROC manages pixels for gamma correction and ensures that pixel values are within the correct range. Signed-off-by: Nancy Lin Signed-off-by: Paul-pl Chen --- drivers/gpu/drm/mediatek/Makefile

[PATCH v3 10/17] drm/mediatek: Export OVL formats definitions and format conversion API

2025-05-15 Thread paul-pl . chen
From: Nancy Lin In upcoming SoCs, the OVL component will be divided into multiple smaller hardware units to enhance flexibility. To facilitate this transition, the OVL format definitions and format conversion API should be exported for reuse across these units. Signed-off-by: Nancy Lin Signed-o

[PATCH v3 00/17] Add MediaTek SoC DRM support for MT8196

2025-05-15 Thread paul-pl . chen
From: Paul-pl Chen This patch series adds support for the MediaTek MT8196 SoC's display subsystem in the DRM driver. Changes in v3: - [PATCH v3 06/17] Refine runtime PM, top clocks and async controls for MMSYS - [PATCH v3 08/17] Refactor SOF settings by adding mtk_mutex_get_output_comp_so

Re: [PATCH V9 31/43] drm/colorop: add BT2020/BT709 OETF and Inverse OETF

2025-05-15 Thread Simon Ser
Reviewed-by: Simon Ser

[PATCH v3 12/17] drm/mediatek: add EXDMA support for MT8196

2025-05-15 Thread paul-pl . chen
From: Nancy Lin EXDMA is a DMA engine for reading data from DRAM with various DRAM footprints and data formats. For input sources in certain color formats and color domains, EXDMA also includes a color transfer function to process pixels into a consistent color domain. New Add: 6320385 Fix RG16 a

[PATCH v3 17/17] drm/mediatek: Add support for MT8196 multiple mmsys

2025-05-15 Thread paul-pl . chen
From: Nancy Lin Add code to support MT8196 SOC Multi MMSYS Driver Signed-off-by: Nancy Lin Signed-off-by: Paul-pl Chen --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 119 - 1 file changed, 115 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_d

[PATCH v3 13/17] drm/mediatek: add BLENDER support for MT8196

2025-05-15 Thread paul-pl . chen
From: Paul-pl Chen BLENDER executes the alpha blending function for overlapping layers from different sources, which is the primary function of the overlapping system. Signed-off-by: Nancy Lin Signed-off-by: Paul-pl Chen --- drivers/gpu/drm/mediatek/Makefile | 1 + drivers/gpu/drm

[PATCH v3 07/17] soc: mediatek: mutex: Reused the switch case for SOF ID

2025-05-15 Thread paul-pl . chen
From: Paul-pl Chen Reused the switch case for SOF IDs. Signed-off-by: Nancy Lin Signed-off-by: Paul-pl Chen --- drivers/soc/mediatek/mtk-mutex.c | 81 ++-- 1 file changed, 36 insertions(+), 45 deletions(-) diff --git a/drivers/soc/mediatek/mtk-mutex.c b/drivers/so

[PATCH v3 16/17] drm/mediatek: Add support for multiple mmsys in the one mediatek-drm driver

2025-05-15 Thread paul-pl . chen
From: Paul-pl Chen To support multiple mmsys instances in the one mediatek-drm instance, providing improved flexibility and scalability by the following changes: 1. Add DDP_COMPONENT_DRM_OVLSYS_ADAPTOR* to probe the ovlsys_adaptor drivers and support different mmsys composition. 2. Added new c

RE: [PATCH 2/2] dmabuf/heaps: implement DMA_BUF_IOCTL_RW_FILE for system_heap

2025-05-15 Thread wangtao
> -Original Message- > From: Christian König > Sent: Tuesday, May 13, 2025 9:18 PM > To: wangtao ; sumit.sem...@linaro.org; > benjamin.gaign...@collabora.com; brian.star...@arm.com; > jstu...@google.com; tjmerc...@google.com > Cc: linux-me...@vger.kernel.org; dri-devel@lists.freedesktop.

Re: [PATCH V9 40/43] drm/colorop: allow non-bypass colorops

2025-05-15 Thread Simon Ser
Reviewed-by: Simon Ser

[PATCH v3 03/17] dt-bindings: display: mediatek: add BLENDER yaml for MT8196

2025-05-15 Thread paul-pl . chen
From: Paul-pl Chen Add mediatek,blender.yaml to support BLENDER for MT8196. MediaTek display overlap blender, namely OVL_BLENDER or BLENDER, executes the alpha blending function for overlapping layers from different sources. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Nancy Lin Signed-off

[PATCH v3 06/17] soc: mediatek: add mmsys support for MT8196

2025-05-15 Thread paul-pl . chen
From: Nancy Lin Add driver data for MT8196 and add the routing table for each mmsys. Signed-off-by: Nancy Lin Signed-off-by: Paul-pl Chen --- drivers/soc/mediatek/mt8196-mmsys.h| 396 + drivers/soc/mediatek/mtk-mmsys.c | 54 include/linux/soc/mediatek/m

Re: [PATCH V9 13/43] drm/colorop: Add destroy functions for color pipeline

2025-05-15 Thread Simon Ser
Reviewed-by: Simon Ser

[PATCH] accel/ivpu: Reorder Doorbell Unregister and Command Queue Destruction

2025-05-15 Thread Jacek Lawrynowicz
From: Karol Wachowski Refactor ivpu_cmdq_unregister() to ensure the doorbell is unregistered before destroying the command queue. The NPU firmware requires doorbells to be unregistered prior to command queue destruction. If doorbell remains registered when command queue destroy command is sent f

[PATCH v3 11/17] drm/mediatek: drm/mediatek: Export OVL ignore pixel alpha function

2025-05-15 Thread paul-pl . chen
From: Nancy Lin For the new BLENDER component, the OVL ignore pixel alpha logic should be exported as a function and reused it. Signed-off-by: Nancy Lin Signed-off-by: Paul-pl Chen --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 24 ++-- drivers/gpu/drm/mediatek/mtk_disp_ovl

Re: [PATCH V9 00/43] Color Pipeline API w/ VKMS

2025-05-15 Thread Simon Ser
I've reviewed all of the core DRM patches :) Have there been updates from user-space implementations?

[PATCH v4 4/9] sync_file: Use dma-fence driver and timeline name helpers

2025-05-15 Thread Tvrtko Ursulin
Access the dma-fence internals via the previously added helpers. Signed-off-by: Tvrtko Ursulin Reviewed-by: Christian König --- drivers/dma-buf/sync_file.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/dma-buf/sync_file.c b/drivers/dma-buf/sync_file.c index

[PATCH v4 3/9] dma-fence: Add helpers for accessing driver and timeline name

2025-05-15 Thread Tvrtko Ursulin
Add some helpers in order to enable preventing dma-fence users accessing the implementation details directly and make the implementation itself use them. This will also enable later adding some asserts to a consolidated location. Signed-off-by: Tvrtko Ursulin Reviewed-by: Christian König --- d

[PATCH v4 0/9] Some (drm_sched_|dma_)fence lifetime issues

2025-05-15 Thread Tvrtko Ursulin
Hi all, tl;dr; Xe and probably some other drivers can tear down the internal state referenced by an exported sync_file fence which then causes a null pointer derefences on accessing said fence. IGT that exploits the problem: https://patchwork.freedesktop.org/patch/642709/?series=146211&rev=2 It

[PATCH v4 7/9] sync_file: Protect access to driver and timeline name

2025-05-15 Thread Tvrtko Ursulin
Protect the access to driver and timeline name which otherwise could be freed as dma-fence exported is signalling fences. Signed-off-by: Tvrtko Ursulin --- drivers/dma-buf/sync_file.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/dma-buf/sync_file.c b/drivers/dma-buf/sync_fil

[PATCH v4 6/9] dma-fence: Add safe access helpers and document the rules

2025-05-15 Thread Tvrtko Ursulin
Dma-fence objects currently suffer from a potential use after free problem where fences exported to userspace and other drivers can outlive the exporting driver, or the associated data structures. The discussion on how to address this concluded that adding reference counting to all the involved ob

[PATCH v4 2/9] dma-fence: Use a flag for 64-bit seqnos

2025-05-15 Thread Tvrtko Ursulin
With the goal of reducing the need for drivers to touch (and dereference) fence->ops, we move the 64-bit seqnos flag from struct dma_fence_ops to the fence->flags. Drivers which were setting this flag are changed to use new dma_fence_init64() instead of dma_fence_init(). v2: * Streamlined init a

[PATCH v4 9/9] drm/xe: Make dma-fences compliant with the safe access rules

2025-05-15 Thread Tvrtko Ursulin
Xe can free some of the data pointed to by the dma-fences it exports. Most notably the timeline name can get freed if userspace closes the associated submit queue. At the same time the fence could have been exported to a third party (for example a sync_fence fd) which will then cause an use- after-

[PATCH v4 1/9] dma-fence: Change signature of __dma_fence_is_later

2025-05-15 Thread Tvrtko Ursulin
With the goal of reducing the need for drivers to touch (and dereference) fence->ops, we change the prototype of __dma_fence_is_later() to take fence instead of fence->ops. Signed-off-by: Tvrtko Ursulin Reviewed-by: Christian König --- drivers/dma-buf/dma-fence-chain.c | 2 +- drivers/dma-buf/

[PATCH v3 04/17] dt-bindings: display: mediatek: add OUTPROC yaml for MT8196

2025-05-15 Thread paul-pl . chen
From: Paul-pl Chen Add mediate,outproc.yaml to support OUTPROC for MT8196. MediaTek display overlap output processor, namely OVL_OUTPROC or OUTPROC,handles the post-stage of pixel processing in the overlapping procedure. Signed-off-by: Nancy Lin Signed-off-by: Paul-pl Chen --- .../display/med

[PATCH v4 5/9] drm/i915: Use dma-fence driver and timeline name helpers

2025-05-15 Thread Tvrtko Ursulin
Access the dma-fence internals via the previously added helpers. Signed-off-by: Tvrtko Ursulin Reviewed-by: Christian König --- drivers/gpu/drm/i915/gt/intel_gt_requests.c | 4 ++-- drivers/gpu/drm/i915/i915_request.c | 2 +- drivers/gpu/drm/i915/i915_sw_fence.c| 4 ++-- 3 files

[PATCH v4 8/9] drm/i915: Protect access to driver and timeline name

2025-05-15 Thread Tvrtko Ursulin
Protect the access to driver and timeline name which otherwise could be freed as dma-fence exported is signalling fences. Now that the safe access is handled in the dma-fence API, the external callers such as sync_file, and our internal code paths, we can drop the similar protection from i915_fenc

Re: [PATCH v4 08/11] tee: add Qualcomm TEE driver

2025-05-15 Thread Sumit Garg
On Thu, May 15, 2025 at 02:35:34PM +0530, Kuldeep Singh wrote: > > > On 5/14/2025 6:55 PM, Sumit Garg wrote: > > Hi Amir, > > > > Apologies for getting to this patch review a bit late, mostly due to > > it's enormous size. > > > > On Mon, Apr 28, 2025 at 11:06:29PM -0700, Amirreza Zarrabi wrote

[PATCH v3 09/17] soc: mediatek: mutex: add mutex support for MT8196

2025-05-15 Thread paul-pl . chen
From: Nancy Lin Add mutex support for the main and external displays in MT8196: - Introduce a new DVO0 output component for the new mutex settings of MT8196. - Add a need_sof_mof flag to configure both SOF and MOD settings for the output component. Signed-off-by: Nancy Lin Signed-off-by: Pa

RE: [PATCH v9 02/12] mtd: add driver for intel graphics non-volatile memory device

2025-05-15 Thread Usyskin, Alexander
> Subject: Re: [PATCH v9 02/12] mtd: add driver for intel graphics non-volatile > memory device > > On Thu, Apr 24, 2025 at 04:25:26PM +0300, Alexander Usyskin wrote: > > Add auxiliary driver for intel discrete graphics > > non-volatile memory device. > > ... > > > +static int intel_dg_mtd_probe

Re: [PATCH] drm/scheduler: signal scheduled fence when kill job

2025-05-15 Thread Tvrtko Ursulin
On 15/05/2025 10:05, Philipp Stanner wrote: On Thu, 2025-05-15 at 10:48 +0200, Christian König wrote: Explicitly adding the scheduler maintainers. On 5/15/25 04:07, Lin.Cao wrote: Previously we only signaled finished fence which may cause some submission's dependency cannot be cleared the ca

Re: [RFC PATCH 00/12] Private MMIO support for private assigned dev

2025-05-15 Thread Alexey Kardashevskiy
On 13/5/25 20:03, Zhi Wang wrote: On Mon, 12 May 2025 11:06:17 -0300 Jason Gunthorpe wrote: On Mon, May 12, 2025 at 07:30:21PM +1000, Alexey Kardashevskiy wrote: I'm surprised by this.. iommufd shouldn't be doing PCI stuff, it is just about managing the translation control of the device.

Re: [PATCH RFT v2 03/15] drm/msm: Use the central UBWC config database

2025-05-15 Thread kernel test robot
: edef457004774e598fc4c1b7d1d4f0bcd9d0bb30 patch link: https://lore.kernel.org/r/20250514-topic-ubwc_central-v2-3-09ecbc0a05ce%40oss.qualcomm.com patch subject: [PATCH RFT v2 03/15] drm/msm: Use the central UBWC config database config: arm64-randconfig-002-20250515 (https://download.01.org/0day-ci/archive/20250515/202505151822

[PATCH] drm/panthor: Reset queue slots if termination fails

2025-05-15 Thread Ashley Smith
This fixes a bug where if we timeout after a suspend and the termination fails, due to waiting on a fence that will never be signalled for example, we do not resume the group correctly. The fix forces a reset for groups that are not terminated correctly. Signed-off-by: Ashley Smith --- drivers/g

Re: [PATCH v3 02/17] dt-bindings: display: mediatek: add EXDMA yaml for MT8196

2025-05-15 Thread Rob Herring (Arm)
On Thu, 15 May 2025 17:34:14 +0800, paul-pl.chen wrote: > From: Paul-pl Chen > > Add mediatek,exdma.yaml to support EXDMA for MT8196. > The MediaTek display overlap extended DMA engine, namely > OVL_EXDMA or EXDMA, primarily functions as a DMA engine > for reading data from DRAM with various DR

Re: [PATCH] drm/panthor: Reset queue slots if termination fails

2025-05-15 Thread Boris Brezillon
On Thu, 15 May 2025 11:33:05 +0100 Ashley Smith wrote: > This fixes a bug where if we timeout after a suspend and the termination > fails, due to waiting on a fence that will never be signalled for > example, we do not resume the group correctly. The fix forces a reset > for groups that are not t

Re: [PATCH V9 26/43] drm/amd/display: Add support for sRGB EOTF in DEGAM block

2025-05-15 Thread Pekka Paalanen
On Tue, 13 May 2025 16:39:51 -0400 Harry Wentland wrote: > On 2025-05-13 11:36, Melissa Wen wrote: > > On 05/13, Pekka Paalanen wrote: > >> On Mon, 12 May 2025 15:50:17 -0300 > >> Melissa Wen wrote: > >> > >>> On 04/29, Alex Hung wrote: > Expose one 1D curve colorop with support for >

RE: [PATCH v9 03/12] mtd: intel-dg: implement region enumeration

2025-05-15 Thread Usyskin, Alexander
> Subject: Re: [PATCH v9 03/12] mtd: intel-dg: implement region enumeration > > On Thu, Apr 24, 2025 at 04:25:27PM +0300, Alexander Usyskin wrote: > > In intel-dg, there is no access to the spi controller, > > the information is extracted from the descriptor region. > > ... > > > @@ -22,9 +24,19

Re: [PATCH v9 02/12] mtd: add driver for intel graphics non-volatile memory device

2025-05-15 Thread Raag Jadav
On Thu, May 15, 2025 at 03:41:08PM +0530, Usyskin, Alexander wrote: > > On Thu, Apr 24, 2025 at 04:25:26PM +0300, Alexander Usyskin wrote: > > > Add auxiliary driver for intel discrete graphics > > > non-volatile memory device. ... > > > + for (n = 0, i = 0; i < INTEL_DG_NVM_REGIONS; i++) { > > >

Re: [PATCH v9 03/12] mtd: intel-dg: implement region enumeration

2025-05-15 Thread Raag Jadav
On Thu, May 15, 2025 at 04:53:38PM +0530, Usyskin, Alexander wrote: > > On Thu, Apr 24, 2025 at 04:25:27PM +0300, Alexander Usyskin wrote: > > > In intel-dg, there is no access to the spi controller, > > > the information is extracted from the descriptor region. > > > > ... > > > > > @@ -22,9 +24

Re: [PATCH] drm/scheduler: signal scheduled fence when kill job

2025-05-15 Thread Christian König
On 5/15/25 11:05, Philipp Stanner wrote: > On Thu, 2025-05-15 at 10:48 +0200, Christian König wrote: >> Explicitly adding the scheduler maintainers. >> >> On 5/15/25 04:07, Lin.Cao wrote: >>> Previously we only signaled finished fence which may cause some >>> submission's dependency cannot be clear

Re: [PATCH v4 06/23] drm/connector: hdmi: Use YUV420 output format as an RGB fallback

2025-05-15 Thread Cristian Ciocaltea
Hi Maxime, On 5/13/25 4:35 PM, Maxime Ripard wrote: > Hi, > > On Fri, Apr 25, 2025 at 01:26:57PM +0300, Cristian Ciocaltea wrote: >> Try to make use of YUV420 when computing the best output format and >> RGB cannot be supported for any of the available color depths. >> >> Signed-off-by: Cristian

Re: [PATCH drm-next v3] drm/hyperv: Replace simple-KMS with regular atomic helpers

2025-05-15 Thread Jocelyn Falempe
On 27/04/2025 12:18, Ryosuke Yasuoka wrote: Drop simple-KMS in favor of regular atomic helpers to make the code more modular. The simple-KMS helper mix up plane and CRTC state, so it is obsolete and should go away [1]. Since it just split the simple-pipe functions into per-plane and per-CRTC, no

Re: [PATCH v3 2/2] dt-bindings: display: rockchip: Convert cdn-dp-rockchip.txt to yaml

2025-05-15 Thread Heiko Stübner
Hi, Am Dienstag, 13. Mai 2025, 03:19:04 Mitteleuropäische Sommerzeit schrieb Chaoyi Chen: > From: Chaoyi Chen > + ports: > +$ref: /schemas/graph.yaml#/properties/ports > + > +properties: > + port@0: > +$ref: /schemas/graph.yaml#/properties/port > +description: Input

[PULL] drm-misc-fixes

2025-05-15 Thread Thomas Zimmermann
Hi Dave, Sima, here's the weekly PR for drm-misc-fixes. The dma-buf fix affects multiple subsystems. Best regards Thomas drm-misc-fixes-2025-05-15: Short summary of fixes pull: dma-buf: - Avoid memory reordering in fence handling ivpu: - Fix buffer size in debugfs code meson: - Avoid integer

RE: [PATCH v9 03/12] mtd: intel-dg: implement region enumeration

2025-05-15 Thread Usyskin, Alexander
> Subject: Re: [PATCH v9 03/12] mtd: intel-dg: implement region enumeration > > On Thu, May 15, 2025 at 04:53:38PM +0530, Usyskin, Alexander wrote: > > > On Thu, Apr 24, 2025 at 04:25:27PM +0300, Alexander Usyskin wrote: > > > > In intel-dg, there is no access to the spi controller, > > > > the in

  1   2   >