Re: [PATCH 1/2] Revert "udmabuf: fix vmap_udmabuf error page set"

2025-04-28 Thread Huan Yang
在 2025/4/28 12:16, Kasireddy, Vivek 写道: Hi Huan, Subject: Re: [PATCH 1/2] Revert "udmabuf: fix vmap_udmabuf error page set" From 38aa11d92f209e7529736f3e11e08dfc804bdfae Mon Sep 17 00:00:00 2001 From: Huan Yang Date: Tue, 15 Apr 2025 10:04:18 +0800 Subject: [PATCH 1/2] Revert "udmabuf: fi

Re: [PATCH v6 2/3] drm/st7571-i2c: add support for Sitronix ST7571 LCD controller

2025-04-28 Thread Marcus Folkesson
Hi Geert, On Thu, Apr 24, 2025 at 10:38:33AM +0200, Geert Uytterhoeven wrote: > Hi Marcus, > [...] > > + /* > > +* As the display supports grayscale, all pixels > > must be written as two bits > > +* even if the format is mon

Re: [PATCH] drm/xe/tests: fix the bo evict build break

2025-04-28 Thread kernel test robot
ux/commits/Dave-Airlie/drm-xe-tests-fix-the-bo-evict-build-break/20250428-114114 base: https://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git exynos-drm-next patch link: https://lore.kernel.org/r/20250428034043.407486-1-airlied%40gmail.com patch subject: [PATCH] drm/xe/tests:

Re: [PATCH] drm/sitronix: move tiny Sitronix drivers to their own subdir

2025-04-28 Thread Javier Martinez Canillas
Marcus Folkesson writes: Hello Marcus, > We start to have support many Sitronix displays in the tiny directory, > and we expect more to come. > > Move them to their own subdirectory. > > Signed-off-by: Marcus Folkesson > --- Reviewed-by: Javier Martinez Canillas You can also include the foll

Re: [PATCH RFC v2 2/5] dt-bindings: display: panel: ili9881c: Add data-lanes property

2025-04-28 Thread Krzysztof Kozlowski
On Thu, Apr 24, 2025 at 05:07:40PM GMT, Kory Maincent wrote: > Add the data-lanes property to specify the number of DSI lanes used by the > panel. This allows configuring the panel for either two, three or four > lanes. That's the property of DSI controller, not the panel. I do not understand why

Re: [PATCH RFC v2 1/5] dt-bindings: display: panel: Fix port binding

2025-04-28 Thread Krzysztof Kozlowski
On Thu, Apr 24, 2025 at 05:07:39PM GMT, Kory Maincent wrote: > Faced a binding error check while adding the data-lanes property in the > ilitek,ili9881c binding. See the next patch for the binding changes. > Here is the error: > Documentation/devicetree/bindings/display/panel/ilitek,ili9881c.exampl

Re: [PATCH v4 0/4] Don't create Python bytecode when building the kernel

2025-04-28 Thread Andy Shevchenko
On Sat, Apr 26, 2025 at 08:57:08PM +0800, Mauro Carvalho Chehab wrote: > Em Sat, 26 Apr 2025 11:39:05 +0900 > Akira Yokosawa escreveu: > > > Bothering with might-become-incompatilbe-in-the-future python environment > > variables in kernel Makefiles looks over-engineering to me. > > Also, as Mauro

[PATCH v2 1/2] Revert "udmabuf: fix vmap_udmabuf error page set"

2025-04-28 Thread Huan Yang
This reverts commit 18d7de823b7150344d242c3677e65d68c5271b04. We cannot use vmap_pfn() in vmap_udmabuf() as it would fail the pfn_valid() check in vmap_pfn_apply(). This is because vmap_pfn() is intended to be used for mapping non-struct-page memory such as PCIe BARs. Since, udmabuf mostly works w

[PATCH v2 0/2] Fix udmabuf vmap error

2025-04-28 Thread Huan Yang
V2 version just change commit message, no functional change. In [1] Bingbu report an error that vmap_udmabuf invoke failed due to use vmap_pfn and blocked by !pfn_valid. Due to misunderstand it, I change vmap_pfn check of !pfn_valid to pfn_valid, then send [2], then Christoph point that: vmap_p

[PATCH v2 2/2] udmabuf: fix vmap missed offset page

2025-04-28 Thread Huan Yang
Before invoke vmap, we need offer a pages pointer array which each page need to map in vmalloc area. But currently vmap_udmabuf only set each folio's head page into pages, missed each offset pages when iter. This patch set the correctly offset page in each folio into array. Signed-off-by: Huan Y

[PATCH v2 1/4] drm: adp: Use spin_lock_irqsave for drm device event_lock

2025-04-28 Thread Janne Grunau via B4 Relay
From: Janne Grunau The lock is used in the interrupt handler so use spin_lock_irqsave to disable interrupts and avoid deadlocks with the irq handler. Fixes: 332122eba628 ("drm: adp: Add Apple Display Pipe driver") Reviewed-by: Alyssa Rosenzweig Signed-off-by: Janne Grunau --- drivers/gpu/drm/

[PATCH v2 3/4] drm: adp: Enable vblank interrupts in crtc's .atomic_enable

2025-04-28 Thread Janne Grunau via B4 Relay
From: Janne Grunau Calling drm_crtc_vblank_on() drm_crtc_helper_funcs' atomic_enable is expected to enable vblank interrupts. It may have been avoided here to due to drm_crtc_vblank_get()'s error behavior after drm_crtc_vblank_reset(). With that fixed in the preceding change the driver can call d

[PATCH v2 0/4] Apple Display Pipe driver fixes

2025-04-28 Thread Janne Grunau via B4 Relay
While looking at a suspend issue in the Asahi downstream kernel I noticed several issues in the the ADP driver. This series fixes those issue. The root cause of the issue was that the device is unexpectedly powered down on suspend. The driver relies on initialization done by the boot loader and ca

[PATCH v2 4/4] drm: adp: Remove pointless irq_lock spin lock

2025-04-28 Thread Janne Grunau via B4 Relay
From: Janne Grunau Interrupt handlers run with interrupts disabled so it is not necessary to protect them against reentrancy. Reviewed-by: Alyssa Rosenzweig Signed-off-by: Janne Grunau --- drivers/gpu/drm/adp/adp_drv.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/gpu/drm/a

[PATCH v2 2/4] drm: adp: Handle drm_crtc_vblank_get() errors

2025-04-28 Thread Janne Grunau via B4 Relay
From: Janne Grunau drm_crtc_vblank_get() may fail when it's called before drm_crtc_vblank_on() on a resetted CRTC. This occurs in drm_crtc_helper_funcs' atomic_flush() calls after drm_atomic_helper_crtc_reset() for example directly after probe. Send the vblank event directly in such cases. Avoids

Re: [PATCH v2 34/34] drm/bridge: panel: convert to devm_drm_bridge_alloc() API

2025-04-28 Thread Maxime Ripard
On Thu, Apr 24, 2025 at 10:05:49PM +0200, Luca Ceresoli wrote: > This is the new API for allocating DRM bridges. > > The devm lifetime management of this driver is peculiar. The underlying > device for the panel_bridge is the panel, and the devm lifetime is tied the > panel device (panel->dev). Ho

Re: [PATCH V8 1/5] drm: add drm_file_err function to add process info

2025-04-28 Thread Khatri, Sunil
On 4/22/2025 2:33 PM, Christian König wrote: Am 17.04.25 um 18:10 schrieb Sunil Khatri: Add a drm helper function which appends the process information for the drm_file over drm_err formatted output. v5: change to macro from function (Christian Koenig) add helper functions for lock/unloc

Re: [PATCH] drm/i915/gt: Remove const from struct i915_wa list allocation

2025-04-28 Thread Jani Nikula
On Fri, 25 Apr 2025, Kees Cook wrote: > In preparation for making the kmalloc family of allocators type aware, > we need to make sure that the returned type from the allocation matches > the type of the variable being assigned. (Before, the allocator would > always return "void *", which can be im

Re: [PATCH v2 34/34] drm/bridge: panel: convert to devm_drm_bridge_alloc() API

2025-04-28 Thread Luca Ceresoli
Hi Maxime, On Mon, 28 Apr 2025 13:39:23 +0200 Maxime Ripard wrote: > On Thu, Apr 24, 2025 at 10:05:49PM +0200, Luca Ceresoli wrote: > > This is the new API for allocating DRM bridges. > > > > The devm lifetime management of this driver is peculiar. The underlying > > device for the panel_bridge

[PATCH] drm/tegra: Remove unneeded include

2025-04-28 Thread Jon Hunter
The header file 'tegra_drm.h' is included in gem.c, but this file is already include 'drm.h'. Although there is no harm in including this file again, it is also not necessary. Furthermore, the header file is located under 'include/uapi/drm' so ideally the full path would be used to be explicit. For

Re: [rfc] drm/ttm/memcg: simplest initial memcg/ttm integration

2025-04-28 Thread Simona Vetter
On Mon, Apr 28, 2025 at 12:43:30PM +0200, Christian König wrote: > On 4/23/25 23:37, Dave Airlie wrote: > > Hey, > > > > I've been tasked to look into this, and I'm going start from hopeless > > naivety and see how far I can get. This is an initial attempt to hook > > TTM system memory allocations

[PULL] drm-xe-next

2025-04-28 Thread Thomas Hellstrom
Hi Dave, Simona An additional drm-xe-next PR as requested on IRC. Take 2, This time with a normal-looking diffstat. A lot of fixes but some new stuff as detailed below. Please note that the top commit, "Drop force_alloc from xe_bo_evict in selftests" carries a Fixes tag that is not an ancestor

Re: [PATCH v4 2/4] drm/panel: Add refcount support

2025-04-28 Thread Jani Nikula
On Mon, 31 Mar 2025, Anusha Srivatsa wrote: > Allocate panel via reference counting. Add _get() and _put() helper > functions to ensure panel allocations are refcounted. Avoid use after > free by ensuring panel pointer is valid and can be usable till the last > reference is put. > > Reviewed-by: L

Re: [PATCH v5 03/11] drm/connector: add CEC-related fields

2025-04-28 Thread Dmitry Baryshkov
On Tue, Apr 15, 2025 at 12:10:06PM +0300, Dmitry Baryshkov wrote: > On 14/04/2025 17:52, Maxime Ripard wrote: > > Hi, > > > > On Mon, Apr 07, 2025 at 06:11:00PM +0300, Dmitry Baryshkov wrote: > > > +/** > > > + * struct drm_connector_cec - DRM Connector CEC-related structure > > > + */ > > > +stru

Re: [PATCH] drm/amdgpu/userq: fix user_queue parameters list

2025-04-28 Thread Alex Deucher
Applied. Thanks. Alex On Sat, Apr 26, 2025 at 10:37 PM Bagas Sanjaya wrote: > > Sphinx reports htmldocs warning: > > Documentation/gpu/amdgpu/module-parameters:7: > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c:1119: ERROR: Unexpected indentation. > [docutils] > > Fix the warning by using reST bull

Re: [PATCH 1/1] drm/amd: Fix malformed kerneldoc comment

2025-04-28 Thread Alex Deucher
Thanks for the patch. This was already fixed. Alex On Mon, Apr 28, 2025 at 8:53 AM Brahmajit Das wrote: > > One kerneldoc commets in amd_shared.h failed to adhere to required > format, resulting in these doc-build warnings: > > ./drivers/gpu/drm/amd/include/amd_shared.h:369: warning: Incorrect

[PATCH 2/2] fbdev: Fix fb_ser_var to prevent null-ptr-deref in fb_videomode_to_var

2025-04-28 Thread Murad Masimov
If fb_add_videomode() in fb_set_var() fails to allocate memory for fb_videomode, later it may lead to a null-ptr dereference in fb_videomode_to_var(), as the fb_info is registered while not having the mode in modelist that is expected to be there, i.e. the one that is described in fb_info->var. ==

[PATCH 1/2] fbdev: Fix do_register_framebuffer to prevent null-ptr-deref in fb_videomode_to_var

2025-04-28 Thread Murad Masimov
If fb_add_videomode() in do_register_framebuffer() fails to allocate memory for fb_videomode, it will later lead to a null-ptr dereference in fb_videomode_to_var(), as the fb_info is registered while not having the mode in modelist that is expected to be there, i.e. the one that is described in fb_

[PATCH 0/2] fbdev: Prevent null-ptr-deref in fb_videomode_to_var

2025-04-28 Thread Murad Masimov
These patches fix the bug that leads to a null-ptr-deref if fb_videomode_to_var() fails to allocate memory. This bug is present in do_register_framebuffer() and fb_ser_var(). Found by Linux Verification Center (linuxtesting.org) with Syzkaller. Murad Masimov (2): fbdev: Fix do_register_framebuf

Re: [PATCH 11/33] dt-bindings: mmc: sdhci-msm: Add the SM7150 compatible

2025-04-28 Thread Ulf Hansson
On Tue, 22 Apr 2025 at 22:24, Danila Tikhonov wrote: > > Add compatible for the SDHCI block found in SM7150. > > Signed-off-by: Danila Tikhonov Applied for next, thanks! Kind regards Uffe > --- > Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 1 + > 1 file changed, 1 insertion(+) > >

Re: [PATCH v1 01/11] x86/mm/pat: factor out setting cachemode into pgprot_set_cachemode()

2025-04-28 Thread David Hildenbrand
n 0; } @@ -1073,10 +1072,8 @@ void track_pfn_insert(struct vm_area_struct *vma, pgprot_t *prot, pfn_t pfn) if (!pat_enabled()) return; - /* Set prot based on lookup */ We're losing a comment here but who cares, it's obvious what's happening. Yeah, it's now

Re: [PATCH v1 02/11] mm: convert track_pfn_insert() to pfnmap_sanitize_pgprot()

2025-04-28 Thread Peter Xu
On Mon, Apr 28, 2025 at 04:58:46PM +0200, David Hildenbrand wrote: > > > > What it does on PAT (only implementation so far ...) is looking up the > > > memory type to select the caching mode that can be use. > > > > > > "sanitize" was IMHO a good fit, because we must make sure that we don't > >

Re: [PATCH v1 05/11] mm: convert VM_PFNMAP tracking to pfnmap_track() + pfnmap_untrack()

2025-04-28 Thread Peter Xu
On Mon, Apr 28, 2025 at 06:16:21PM +0200, David Hildenbrand wrote: > > Probably due to what config you have. E.g., when I'm looking mine it's > > much bigger and already consuming 256B, but it's because I enabled more > > things (userfaultfd, lockdep, etc.). > > Note that I enabled everything tha

Re: [PATCH] drm/st7571-i2c: select CONFIG_DRM_CLIENT_SELECTION

2025-04-28 Thread Marcus Folkesson
On Mon, Apr 28, 2025 at 05:07:45PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > The newly added driver calls drm_client_setup(), but that is not > always built in: > > x86_64-linux-ld: vmlinux.o: in function `st7571_probe': > st7571-i2c.c:(.text+0x7b7119): undefined reference to `drm_cl

Re: [PATCH v1 04/11] mm/memremap: convert to pfnmap_track() + pfnmap_untrack()

2025-04-28 Thread Lorenzo Stoakes
On Fri, Apr 25, 2025 at 04:00:42PM -0400, Peter Xu wrote: > On Fri, Apr 25, 2025 at 10:17:08AM +0200, David Hildenbrand wrote: > > Let's use the new, cleaner interface. > > > > Signed-off-by: David Hildenbrand LGTM, albeit though, as discussed elsewhere in thread, this should be merged with prior

Re: [PATCH] vsprintf: Use %p4chR instead of %p4cn for reading data in reversed host ordering

2025-04-28 Thread Aditya Garg
On 28-04-2025 10:30 pm, Alyssa Rosenzweig wrote: > Acked-by: Alyssa Rosenzweig > > Since the other patches went thru drm-misc-next, I guess this should > too? I think yes. > > > Le Mon , Apr 28, 2025 at 02:31:32PM +0200, Petr Mladek a écrit : >> The generic FourCC format always prints the d

Re: [PATCH v1 03/11] x86/mm/pat: introduce pfnmap_track() and pfnmap_untrack()

2025-04-28 Thread David Hildenbrand
+int pfnmap_track(unsigned long pfn, unsigned long size, pgprot_t *prot) +{ + const resource_size_t paddr = (resource_size_t)pfn << PAGE_SHIFT; + + return reserve_pfn_range(paddr, size, prot, 0); Nitty, but a pattern established by Liam which we've followed consistently in VMA co

Re: [PATCH v1 05/11] mm: convert VM_PFNMAP tracking to pfnmap_track() + pfnmap_untrack()

2025-04-28 Thread David Hildenbrand
On 28.04.25 18:24, Peter Xu wrote: On Mon, Apr 28, 2025 at 06:16:21PM +0200, David Hildenbrand wrote: Probably due to what config you have. E.g., when I'm looking mine it's much bigger and already consuming 256B, but it's because I enabled more things (userfaultfd, lockdep, etc.). Note that I

Re: [PATCH linux-next] drm/amdgpu: use string choice helpers

2025-04-28 Thread Alex Deucher
On Sun, Apr 27, 2025 at 5:46 AM R Sundar wrote: > > Use string choice helpers for better readability. > > Reported-by: kernel test robot > Reported-by: Julia Lawall > Closes: https://lore.kernel.org/r/202503222049.suxl3q6w-...@intel.com/ > Signed-off-by: R Sundar > --- > > Reported in linux rep

Re: [PATCH v2 27/34] drm/vc4: convert to devm_drm_bridge_alloc() API

2025-04-28 Thread Dave Stevenson
On Thu, 24 Apr 2025 at 20:01, Luca Ceresoli wrote: > > This is the new API for allocating DRM bridges. > > This driver already implements refcounting of the struct vc4_dsi, which > embeds struct drm_bridge. Now this is a duplicate of the refcounting > implemented by the DRM bridge core, so convert

Re: [PATCH v1 11/11] mm/io-mapping: track_pfn() -> "pfnmap tracking"

2025-04-28 Thread Lorenzo Stoakes
On Fri, Apr 25, 2025 at 10:17:15AM +0200, David Hildenbrand wrote: > track_pfn() does not exist, let's simply refer to it as "pfnmap > tracking". > > Signed-off-by: David Hildenbrand LGTM, so: Reviewed-by: Lorenzo Stoakes > --- > mm/io-mapping.c | 2 +- > 1 file changed, 1 insertion(+), 1 del

Re: [PULL] drm-xe-next

2025-04-28 Thread Thomas Hellström
On Mon, 2025-04-28 at 16:27 +0200, Thomas Hellstrom wrote: > Hi Dave, Simona > > An additional drm-xe-next PR as requested on IRC. > A lot of fixes but some new stuff as detailed below. > > Please note that the top commit, > > "Drop force_alloc from xe_bo_evict in selftests" > > carries a Fixes

Re: [PATCH v2] drm/amdgpu: check a user-provided number of BOs in list

2025-04-28 Thread Marek Olšák
USHRT_MAX seems too low. Traces for workstation apps create 20-30k BOs, which is not very far from the limit. RADV doesn't suballocate BOs. Neither GL nor VK has a ilmit on the number of BOs that can be created. The hypothetical maximum number of BOs that can be allocated on a GPU with 32GB of addr

Re: [PATCH v1 11/11] mm/io-mapping: track_pfn() -> "pfnmap tracking"

2025-04-28 Thread David Hildenbrand
On 28.04.25 18:06, Lorenzo Stoakes wrote: On Fri, Apr 25, 2025 at 10:17:15AM +0200, David Hildenbrand wrote: track_pfn() does not exist, let's simply refer to it as "pfnmap tracking". Signed-off-by: David Hildenbrand LGTM, so: Reviewed-by: Lorenzo Stoakes --- mm/io-mapping.c | 2 +- 1

Re: [PATCH v1 05/11] mm: convert VM_PFNMAP tracking to pfnmap_track() + pfnmap_untrack()

2025-04-28 Thread David Hildenbrand
On 28.04.25 18:08, Peter Xu wrote: On Fri, Apr 25, 2025 at 10:36:55PM +0200, David Hildenbrand wrote: On 25.04.25 22:23, Peter Xu wrote: On Fri, Apr 25, 2025 at 10:17:09AM +0200, David Hildenbrand wrote: Let's use our new interface. In remap_pfn_range(), we'll now decide whether we have to tra

Re: [PATCH v1 01/11] x86/mm/pat: factor out setting cachemode into pgprot_set_cachemode()

2025-04-28 Thread Lorenzo Stoakes
On Fri, Apr 25, 2025 at 10:17:05AM +0200, David Hildenbrand wrote: > Let's factor it out to make the code easier to grasp. > > Use it also in pgprot_writecombine()/pgprot_writethrough() where > clearing the old cachemode might not be required, but given that we are > already doing a function call,

Re: [PATCH] drm/vc4: fix infinite EPROBE_DEFER loop

2025-04-28 Thread Dave Stevenson
Hi Gabriel On Sat, 26 Apr 2025 at 07:23, Gabriel Dalimonte wrote: > > `vc4_hdmi_audio_init` calls `devm_snd_dmaengine_pcm_register` which may > return EPROBE_DEFER. Calling `drm_connector_hdmi_audio_init` adds a > child device. The driver model docs[1] state that adding a child device > prior to

Re: clang and drm issue: objtool warnings from clang build

2025-04-28 Thread Bill Wendling
On Sat, Apr 26, 2025 at 1:57 PM Linus Torvalds wrote: > > On Sat, 26 Apr 2025 at 13:05, Nathan Chancellor wrote: > > > > KBUILD_CFLAGS += -mllvm -trap-unreachable > > Hmm. That certainly builds for me, but yeah, it generates new objtool > warnings, notably > >panic() missing __noreturn in

[PATCH v5 00/10] ref_tracker: add ability to register a debugfs file for a ref_tracker_dir

2025-04-28 Thread Jeff Layton
This one is quite a bit of a change from the last set. I've gone back to auto-registering the debugfs files for every ref_tracker_dir. With this, the callers should pass in a static string as a classname instead of an individual name string that gets copied. The debugfs file is given a name "class@

[PATCH v5 05/10] ref_tracker: add a static classname string to each ref_tracker_dir

2025-04-28 Thread Jeff Layton
A later patch in the series will be adding debugfs files for each ref_tracker that get created in ref_tracker_dir_init(). The format will be "class@%px". The current "name" string can vary between ref_tracker_dir objects of the same type, so it's not suitable for this purpose. Add a new "class" st

[PATCH v5 09/10] i915: add ref_tracker_dir symlinks for each tracker

2025-04-28 Thread Jeff Layton
Now that there is the ability to create a symlink for each tracker, do so for the i915 entries. Signed-off-by: Jeff Layton --- drivers/gpu/drm/i915/intel_runtime_pm.c | 1 + drivers/gpu/drm/i915/intel_wakeref.c| 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_r

[PATCH v5 06/10] ref_tracker: automatically register a file in debugfs for a ref_tracker_dir

2025-04-28 Thread Jeff Layton
Currently, there is no convenient way to see the info that the ref_tracking infrastructure collects. Attempt to create a file in debugfs when called from ref_tracker_dir_init(). The file is given the name "class@%px", as having the unmodified address is helpful for debugging. This should be safe s

[PATCH v5 08/10] net: add symlinks to ref_tracker_dir for netns

2025-04-28 Thread Jeff Layton
After assigning the inode number to the namespace, use it to create a unique name for each netns refcount tracker with the ns.inum value in it, and register a symlink to the debugfs file for it. init_net is registered before the ref_tracker dir is created, so add a late_initcall() to register its

[PATCH v5 10/10] ref_tracker: eliminate the ref_tracker_dir name field

2025-04-28 Thread Jeff Layton
Now that we have dentries and the ability to create meaningful symlinks to them, don't keep a name string in each tracker. Switch the output format to print "class@address", and drop the name field. Also, add a kerneldoc header for ref_tracker_dir_init(). Signed-off-by: Jeff Layton --- drivers/

[PATCH v5 04/10] ref_tracker: allow pr_ostream() to print directly to a seq_file

2025-04-28 Thread Jeff Layton
Allow pr_ostream to also output directly to a seq_file without an intermediate buffer. Reviewed-by: Andrew Lunn Signed-off-by: Jeff Layton --- lib/ref_tracker.c | 25 + 1 file changed, 25 insertions(+) diff --git a/lib/ref_tracker.c b/lib/ref_tracker.c index b6e0a87dd7

[PATCH v5 07/10] ref_tracker: add a way to create a symlink to the ref_tracker_dir debugfs file

2025-04-28 Thread Jeff Layton
Add the ability for a subsystem to add a user-friendly symlink that points to a ref_tracker_dir's debugfs file. Signed-off-by: Jeff Layton --- include/linux/ref_tracker.h | 7 +++ lib/ref_tracker.c | 28 2 files changed, 35 insertions(+) diff --git a/

[PATCH v5 02/10] ref_tracker: add a top level debugfs directory for ref_tracker

2025-04-28 Thread Jeff Layton
Add a new "ref_tracker" directory in debugfs. Each individual refcount tracker can register files under there to display info about currently-held references. Reviewed-by: Andrew Lunn Signed-off-by: Jeff Layton --- lib/ref_tracker.c | 16 1 file changed, 16 insertions(+) diff

[PATCH v5 03/10] ref_tracker: have callers pass output function to pr_ostream()

2025-04-28 Thread Jeff Layton
In a later patch, we'll be adding a 3rd mechanism for outputting ref_tracker info via seq_file. Instead of a conditional, have the caller set a pointer to an output function in struct ostream. As part of this, the log prefix must be explicitly passed in, as it's too late for the pr_fmt macro. Revi

[PATCH v5 01/10] ref_tracker: don't use %pK in pr_ostream() output

2025-04-28 Thread Jeff Layton
As Thomas Weißschuh points out [1], it is now preferable to use %p instead of hashed pointers with printk(), since raw pointers should no longer be leaked into the kernel log. Change the ref_tracker infrastructure to use %p instead of %pK in its formats. [1]: https://lore.kernel.org/netdev/202504

[PATCH v2] drm/i915/slpc: Balance the inc/dec for num_waiters

2025-04-28 Thread Vinay Belgaumkar
As seen in some recent failures, SLPC num_waiters value is < 0. This happens because the inc/dec are not balanced. We should skip decrement for the same conditions as the increment. Currently, we do that for power saving profile mode. This patch also ensures that num_waiters is incremented in the c

RE: [PATCH v7 1/2] drm/display/dp: Export fn to calculate link symbol cycles

2025-04-28 Thread Murthy, Arun R
> -Original Message- > From: Jani Nikula > Sent: Monday, April 28, 2025 2:27 PM > To: Murthy, Arun R ; intel-...@lists.freedesktop.org; > intel...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Cc: Deak, Imre ; Govindapillai, Vinod > ; Murthy, Arun R > Subject: Re: [PATCH v7 1/2

Re: drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-04-28 Thread Aleksandrs Vinarskis
On Mon, 28 Apr 2025 at 09:45, Johan Hovold wrote: > > On Thu, Apr 17, 2025 at 04:10:31AM +0200, Aleksandrs Vinarskis wrote: > > Recently added Initial LTTPR support in msm/dp has configured LTTPR(s) > > to non-transparent mode to enable video output on X1E-based devices > > that come with LTTPR on

Re: [PATCH 1/2] dt-bindings: display: panel: Add BOE TD4320

2025-04-28 Thread Krzysztof Kozlowski
On Sun, Apr 27, 2025 at 11:11:11AM GMT, Barnabás Czémán wrote: > Document BOE TD4320 6.3" 2340x1080 panel > found in Xiaomi Redmi Note 7 smartphone. > > Signed-off-by: Barnabás Czémán > --- > .../bindings/display/panel/boe,td4320.yaml | 55 > ++ > 1 file changed, 55

Re: [PATCH] Revert "drm/amd/display: Hardware cursor changes color when switched to software cursor"

2025-04-28 Thread Shengyu Qu
Hi, Personally I prefer we always disable cursor HW degamma, and this is what color pipeline patch series have done for cursor plane(actually all colorops are disabled on cursor plane and its background plane). Since cursor plane shares colorops with cursor's background plane. Also, degamma

Re: [PATCH v7 1/2] drm/display/dp: Export fn to calculate link symbol cycles

2025-04-28 Thread Jani Nikula
On Thu, 24 Apr 2025, Arun R Murthy wrote: > Unify the function to calculate the link symbol cycles for both dsc and > non-dsc case and export the function so that it can be used in the > respective platform display drivers for other calculations. > > v2: unify the fn for both dsc and non-dsc case

Re: [PATCH v7 1/2] drm/display/dp: Export fn to calculate link symbol cycles

2025-04-28 Thread Jani Nikula
On Thu, 24 Apr 2025, Arun R Murthy wrote: > Unify the function to calculate the link symbol cycles for both dsc and > non-dsc case and export the function so that it can be used in the > respective platform display drivers for other calculations. > > v2: unify the fn for both dsc and non-dsc case

Re: [PATCH] drm/panthor: Fix build warning when DEBUG_FS is disabled

2025-04-28 Thread Steven Price
On 24/04/2025 19:40, Adrián Larumbe wrote: > Commit a3707f53eb3f ("drm/panthor: show device-wide list of DRM GEM > objects over DebugFS") causes a build warning and linking error when > built without support for DebugFS, because of a non-inline non-static > function declaration in a header file. >

Re: [PATCH RESEND] drm/appletbdrm: Make appletbdrm depend on X86

2025-04-28 Thread Aditya Garg
Ccing the mailing lists> From: Aditya Garg > > The appletbdrm driver is exclusively for Touch Bars on x86 Intel Macs. > The M1 Macs have a separate driver. So, lets avoid compiling it for > other architectures. > > Reviewed-by: Alyssa Rosenzweig > Signed-off-by: Aditya Garg > --- > drivers/gp

Re: [PATCH] vsprintf: Use %p4chR instead of %p4cn for reading data in reversed host ordering

2025-04-28 Thread Geert Uytterhoeven
On Mon, 28 Apr 2025 at 14:31, Petr Mladek wrote: > The generic FourCC format always prints the data using the big endian > order. It is generic because it allows to read the data using a custom > ordering. > > The current code uses "n" for reading data in the reverse host ordering. > It makes the

Re: [PATCH] drm/doc: Start documenting aspects specific to tile-based renderers

2025-04-28 Thread Alyssa Rosenzweig
> BTW, is there a piece of doc explaining the rational behind this > dma_fence contract, or is it just the usual informal knowledge shared > among DRM devs over IRC/email threads :-) ? > > To be honest, I'm a bit unhappy with this "it's part of the dma_fence > contract" explanation, because I have

Re: [PATCH v2 0/3] drm/panfrost: enable G31 on H616

2025-04-28 Thread Steven Price
On 28/04/2025 07:10, Philippe Simons wrote: > Hi, is there any issue with this serie Hi, Sorry, no nothing wrong - it's just slipped through. Thanks for the reminder. I've applied it to drm-misc-next. Thanks, Steve > Thanks, > > Philippe > > On 4/3/25 07:52, Philippe Simons wrote: >> Allwinne

Re: [PATCH v4 08/23] drm/tests: hdmi: Add macro to simplify EDID setup

2025-04-28 Thread Jani Nikula
On Fri, 25 Apr 2025, Cristian Ciocaltea wrote: > Factor out the HDMI connector initialization from > drm_kunit_helper_connector_hdmi_init_funcs() into a common > __connector_hdmi_init() function, while extending its functionality to > allow setting custom (i.e. non-default) EDID data. > > Introdu

[PATCH] drm/amd/display: Don't check for NULL divisor in fixpt code

2025-04-28 Thread Harry Wentland
[Why] We check for a NULL divisor but don't act on it. This check does nothing other than throw a warning. It does confuse static checkers though: See https://lkml.org/lkml/2025/4/26/371 [How] Drop the ASSERTs in both DC and SPL variants. Signed-off-by: Harry Wentland Cc: Linus Torvalds Cc: Leo

Re: [PATCH v2 00/34] drm: convert all bridges to devm_drm_bridge_alloc()

2025-04-28 Thread Luca Ceresoli
Hi Maxime, other DRM maintainers, On Thu, 24 Apr 2025 20:59:07 +0200 Luca Ceresoli wrote: > devm_drm_bridge_alloc() [0] is the new API to allocate and initialize a DRM > bridge, and the only one supported from now on. It is also necessary for > implementing reference counting and thus needed to

Re: [PATCH v2 00/34] drm: convert all bridges to devm_drm_bridge_alloc()

2025-04-28 Thread Maxime Ripard
On Mon, Apr 28, 2025 at 05:24:57PM +0200, Luca Ceresoli wrote: > Hi Maxime, other DRM maintainers, > > On Thu, 24 Apr 2025 20:59:07 +0200 > Luca Ceresoli wrote: > > > devm_drm_bridge_alloc() [0] is the new API to allocate and initialize a DRM > > bridge, and the only one supported from now on. I

[PATCH 1/1] drm/amd: Fix malformed kerneldoc comment

2025-04-28 Thread Brahmajit Das
One kerneldoc commets in amd_shared.h failed to adhere to required format, resulting in these doc-build warnings: ./drivers/gpu/drm/amd/include/amd_shared.h:369: warning: Incorrect use of kernel-doc format: * @DC_HDCP_LC_ENABLE_SW_FALLBACK If set, upon HDCP Locality Check FW ./drivers/g

[PATCH] drm/panel: simple: Update timings for AUO G101EVN010

2025-04-28 Thread Kevin Baker
Switch to panel timings based on datasheet for the AUO G101EVN01.0 LVDS panel. Default timings were tested on the panel. Previous mode-based timings resulted in horizontal display shift. Signed-off-by: Kevin Baker --- drivers/gpu/drm/panel/panel-simple.c | 25 + 1 file c

Re: [PATCH v2 00/34] drm: convert all bridges to devm_drm_bridge_alloc()

2025-04-28 Thread Luca Ceresoli
Hi Maxime, On Mon, 28 Apr 2025 17:42:46 +0200 Maxime Ripard wrote: > On Mon, Apr 28, 2025 at 05:24:57PM +0200, Luca Ceresoli wrote: > > Hi Maxime, other DRM maintainers, > > > > On Thu, 24 Apr 2025 20:59:07 +0200 > > Luca Ceresoli wrote: > > > > > devm_drm_bridge_alloc() [0] is the new API

[PATCH v1] drm/bridge: cdns-dsi: Replace deprecated UNIVERSAL_DEV_PM_OPS()

2025-04-28 Thread Vitor Soares
From: Vitor Soares The deprecated UNIVERSAL_DEV_PM_OPS() macro uses the provided callbacks for both runtime PM and system sleep. This causes the DSI clocks to be disabled twice: once during runtime suspend and again during system suspend, resulting in a WARN message from the clock framework when

Re: [PATCH v3 2/8] drm/msm/dpu: program master INTF value

2025-04-28 Thread Jessica Zhang
On 3/6/2025 10:24 PM, Dmitry Baryshkov wrote: From: Dmitry Baryshkov If several interfaces are being handled through a single CTL, a main ('master') INTF needs to be programmed into a separate register. Write corresponding value into that register. Co-developed-by: Marijn Suijten Signed-of

Re: [PATCH v3 4/8] drm/msm/dpu: use single CTL if it is the only CTL returned by RM

2025-04-28 Thread Jessica Zhang
On 3/6/2025 10:24 PM, Dmitry Baryshkov wrote: From: Dmitry Baryshkov On DPU >= 5.0 CTL blocks were reworked in order to support using a single CTL for all outputs. In preparation of reworking the RM code to return single CTL make sure that dpu_encoder can cope with that. Reviewed-by: Marijn

Re: [PATCH v5 06/10] drm/msm/mdss: add SAR2130P device configuration

2025-04-28 Thread Jessica Zhang
On 4/18/2025 12:50 AM, Dmitry Baryshkov wrote: From: Dmitry Baryshkov Add compatible and device configuration for the Qualcomm SAR2130P platform. Signed-off-by: Dmitry Baryshkov Reviewed-by: Jessica Zhang --- drivers/gpu/drm/msm/msm_mdss.c | 11 +++ 1 file changed, 11 inser

Re: [PATCH v2 1/5] drm/msm/dpu: remove DSC feature bit for PINGPONG on MSM8937

2025-04-28 Thread Abhinav Kumar
On 3/1/2025 1:24 AM, Dmitry Baryshkov wrote: The MSM8937 platform doesn't have DSC blocks nor does have it DSC registers in the PINGPONG block. Drop the DPU_PINGPONG_DSC feature bit from the PINGPONG's feature mask and, as it is the only remaining bit, drop the .features assignment completely.

Re: [PATCH v2 2/5] drm/msm/dpu: remove DSC feature bit for PINGPONG on MSM8917

2025-04-28 Thread Abhinav Kumar
On 3/1/2025 1:24 AM, Dmitry Baryshkov wrote: The MSM8917 platform doesn't have DSC blocks nor does have it DSC registers in the PINGPONG block. Drop the DPU_PINGPONG_DSC feature bit from the PINGPONG's feature mask and, as it is the only remaining bit, drop the .features assignment completely.

Re: [PATCH] drm: writeback: Fix drm_writeback_connector_cleanup signature

2025-04-28 Thread kernel test robot
Hi Louis, kernel test robot noticed the following build warnings: [auto build test WARNING on b848cd418aebdb313364b4843f41fae82281a823] url: https://github.com/intel-lab-lkp/linux/commits/Louis-Chauvet/drm-writeback-Fix-drm_writeback_connector_cleanup-signature/20250428-163254 base

Re: [PATCH v2 3/5] drm/msm/dpu: remove DSC feature bit for PINGPONG on MSM8953

2025-04-28 Thread Abhinav Kumar
On 3/1/2025 1:24 AM, Dmitry Baryshkov wrote: The MSM8953 platform doesn't have DSC blocks nor does have it DSC registers in the PINGPONG block. Drop the DPU_PINGPONG_DSC feature bit from the PINGPONG's feature mask and, as it is the only remaining bit, drop the .features assignment completely.

Re: [PATCH v2 4/5] drm/msm/dpu: drop TE2 definitions

2025-04-28 Thread Abhinav Kumar
On 3/1/2025 1:24 AM, Dmitry Baryshkov wrote: Neither DPU driver nor vendor SDE driver do not use TE2 definitions (and, in case of SDE driver, never did). Semantics of the TE2 feature bit and .te2 sblk are not completely clear. Drop these bits from the catalog with the possibility of reintroduc

Re: [PATCH] drm/doc: Start documenting aspects specific to tile-based renderers

2025-04-28 Thread Boris Brezillon
Hi Iago, On Mon, 28 Apr 2025 08:55:07 +0200 Iago Toral wrote: > Hi, > > Pitching in to describe the situation for v3d: Thanks for chiming in. > > El vie, 18-04-2025 a las 14:25 +0200, Boris Brezillon escribió: > > (...) > > +For all these reasons, the tiler usually allocates memory > > dyna

Re: [PATCH] drm/doc: Start documenting aspects specific to tile-based renderers

2025-04-28 Thread Boris Brezillon
Hi Steve, On Wed, 23 Apr 2025 10:41:53 +0100 Steven Price wrote: > On 18/04/2025 13:25, Boris Brezillon wrote: > > Tile-based GPUs come with a set of constraints that are not present > > when immediate rendering is used. This new document tries to explain > > the differences between tile/immedia

Re: [PATCH v7 04/11] optee: sync secure world ABI headers

2025-04-28 Thread Jens Wiklander
Hi Rouven, On Fri, Apr 25, 2025 at 3:36 PM Rouven Czerwinski wrote: > > Hi, > > On Fri, 4 Apr 2025 at 16:31, Jens Wiklander wrote: > > > > Update the header files describing the secure world ABI, both with and > > without FF-A. The ABI is extended to deal with protected memory, but as > > usual

Re: [PATCH] drm/vkms: Adjust vkms_state->active_planes allocation type

2025-04-28 Thread Louis Chauvet
Le 26/04/2025 à 08:14, Kees Cook a écrit : In preparation for making the kmalloc family of allocators type aware, we need to make sure that the returned type from the allocation matches the type of the variable being assigned. (Before, the allocator would always return "void *", which can be i

Re: [PATCH] drm/doc: Start documenting aspects specific to tile-based renderers

2025-04-28 Thread Iago Toral
El lun, 28-04-2025 a las 10:13 +0200, Boris Brezillon escribió: > Hi Iago, > > On Mon, 28 Apr 2025 08:55:07 +0200 > Iago Toral wrote: (...) > > As I described above, v3d is not quite an allocation-on-fault > > mechanism > > but rather, we get a dedicated interrupt from the hw when it needs > > mo

[PATCH] drm: writeback: Fix drm_writeback_connector_cleanup signature

2025-04-28 Thread Louis Chauvet
- base-commit: b848cd418aebdb313364b4843f41fae82281a823 change-id: 20250428-drm-fix-writeback-cleanup-a1179f3b9691 Best regards, -- Louis Chauvet

Re: drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-04-28 Thread Johan Hovold
On Thu, Apr 17, 2025 at 04:10:31AM +0200, Aleksandrs Vinarskis wrote: > Recently added Initial LTTPR support in msm/dp has configured LTTPR(s) > to non-transparent mode to enable video output on X1E-based devices > that come with LTTPR on the motherboards. However, video would not work > if additio

Re: [PATCH] drm/doc: Start documenting aspects specific to tile-based renderers

2025-04-28 Thread Boris Brezillon
Hi Alyssa, On Wed, 23 Apr 2025 10:47:21 -0400 Alyssa Rosenzweig wrote: > Steven wanted non-Mali eyes, so with my Imaginapple hat on... > > > +All lot of embedded GPUs are using tile-based rendering instead of > > immediate > > s/All lot of/Many/ Will change that. > > > +- Complex geometr

Re: [PATCH] drm/sitronix: move tiny Sitronix drivers to their own subdir

2025-04-28 Thread Marcus Folkesson
Hello Javier, On Mon, Apr 28, 2025 at 09:16:32AM +0200, Javier Martinez Canillas wrote: > Marcus Folkesson writes: > > Hello Marcus, > > > We start to have support many Sitronix displays in the tiny directory, > > and we expect more to come. > > > > Move them to their own subdirectory. > > > > S

Re: [PATCH] drm/ttm/xe: drop unused force_alloc flag

2025-04-28 Thread Christian König
On 4/23/25 04:29, Dave Airlie wrote: > From: Dave Airlie > > This flag used to be used in the old memory tracking code, that > code got migrated into the vmwgfx driver[1], and then got removed > from the tree[2], but this piece got left behind. > > [1] f07069da6b4c ("drm/ttm: move memory account

Re: [PATCH V8 1/5] drm: add drm_file_err function to add process info

2025-04-28 Thread Jani Nikula
On Mon, 28 Apr 2025, "Khatri, Sunil" wrote: > On 4/22/2025 2:33 PM, Christian König wrote: >> Am 17.04.25 um 18:10 schrieb Sunil Khatri: >>> Add a drm helper function which appends the process information for >>> the drm_file over drm_err formatted output. >>> >>> v5: change to macro from function

Re: [PATCH] drm/i915/gt: Remove const from struct i915_wa list allocation

2025-04-28 Thread Tvrtko Ursulin
On 26/04/2025 07:13, Kees Cook wrote: In preparation for making the kmalloc family of allocators type aware, we need to make sure that the returned type from the allocation matches the type of the variable being assigned. (Before, the allocator would always return "void *", which can be implici

Re: [PATCH] vsprintf: Use %p4chR instead of %p4cn for reading data in reversed host ordering

2025-04-28 Thread Aditya Garg
On 28-04-2025 06:01 pm, Petr Mladek wrote: > The generic FourCC format always prints the data using the big endian > order. It is generic because it allows to read the data using a custom > ordering. > > The current code uses "n" for reading data in the reverse host ordering. > It makes the 4 v

  1   2   3   >