[PATCH v4 10/14] s390: Add support for suppressing warning backtraces

2025-03-13 Thread Alessandro Carminati
From: Guenter Roeck Add name of functions triggering warning backtraces to the __bug_table object section to enable support for suppressing WARNING backtraces. To limit image size impact, the pointer to the function name is only added to the __bug_table section if both CONFIG_KUNIT_SUPPRESS_BACK

[PATCH v4 14/14] powerpc: Add support for suppressing warning backtraces

2025-03-13 Thread Alessandro Carminati
From: Guenter Roeck Add name of functions triggering warning backtraces to the __bug_table object section to enable support for suppressing WARNING backtraces. To limit image size impact, the pointer to the function name is only added to the __bug_table section if both CONFIG_KUNIT_SUPPRESS_BACK

[PATCH v4 13/14] riscv: Add support for suppressing warning backtraces

2025-03-13 Thread Alessandro Carminati
From: Guenter Roeck Add name of functions triggering warning backtraces to the __bug_table object section to enable support for suppressing WARNING backtraces. To limit image size impact, the pointer to the function name is only added to the __bug_table section if both CONFIG_KUNIT_SUPPRESS_BACK

[PATCH v4 09/14] parisc: Add support for suppressing warning backtraces

2025-03-13 Thread Alessandro Carminati
From: Guenter Roeck Add name of functions triggering warning backtraces to the __bug_table object section to enable support for suppressing WARNING backtraces. To limit image size impact, the pointer to the function name is only added to the __bug_table section if both CONFIG_KUNIT_SUPPRESS_BACK

[PATCH v4 07/14] arm64: Add support for suppressing warning backtraces

2025-03-13 Thread Alessandro Carminati
From: Guenter Roeck Add name of functions triggering warning backtraces to the __bug_table object section to enable support for suppressing WARNING backtraces. To limit image size impact, the pointer to the function name is only added to the __bug_table section if both CONFIG_KUNIT_SUPPRESS_BACK

[PATCH v4 05/14] drm: Suppress intentional warning backtraces in scaling unit tests

2025-03-13 Thread Alessandro Carminati
From: Guenter Roeck The drm_test_rect_calc_hscale and drm_test_rect_calc_vscale unit tests intentionally trigger warning backtraces by providing bad parameters to the tested functions. What is tested is the return value, not the existence of a warning backtrace. Suppress the backtraces to avoid c

[PATCH v4 04/14] kunit: Add documentation for warning backtrace suppression API

2025-03-13 Thread Alessandro Carminati
From: Guenter Roeck Document API functions for suppressing warning backtraces. Tested-by: Linux Kernel Functional Testing Acked-by: Dan Carpenter Reviewed-by: Kees Cook Signed-off-by: Guenter Roeck Reviewed-by: David Gow Signed-off-by: Alessandro Carminati --- Documentation/dev-tools/kuni

Re: [PATCH v4 07/14] arm64: Add support for suppressing warning backtraces

2025-03-13 Thread Will Deacon
On Thu, Mar 13, 2025 at 11:43:22AM +, Alessandro Carminati wrote: > diff --git a/arch/arm64/include/asm/bug.h b/arch/arm64/include/asm/bug.h > index 28be048db3f6..044c5e24a17d 100644 > --- a/arch/arm64/include/asm/bug.h > +++ b/arch/arm64/include/asm/bug.h > @@ -11,8 +11,14 @@ > > #include

Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-13 Thread Andy Shevchenko
On Thu, Mar 13, 2025 at 08:53:28AM +, Aditya Garg wrote: > > On 13 Mar 2025, at 2:19 PM, Andy Shevchenko > > wrote: > > On Thu, Mar 13, 2025 at 07:26:05AM +, Aditya Garg wrote: > On 13 Mar 2025, at 12:58 AM, Andy Shevchenko > wrote: > >>> On Wed, Mar 12, 2025 at 07:14:36PM +00

[PATCH v4 03/14] kunit: Add test cases for backtrace warning suppression

2025-03-13 Thread Alessandro Carminati
From: Guenter Roeck Add unit tests to verify that warning backtrace suppression works. If backtrace suppression does _not_ work, the unit tests will likely trigger unsuppressed backtraces, which should actually help to get the affected architectures / platforms fixed. Tested-by: Linux Kernel Fu

[PATCH v4 08/14] loongarch: Add support for suppressing warning backtraces

2025-03-13 Thread Alessandro Carminati
From: Guenter Roeck Add name of functions triggering warning backtraces to the __bug_table object section to enable support for suppressing WARNING backtraces. To limit image size impact, the pointer to the function name is only added to the __bug_table section if both CONFIG_KUNIT_SUPPRESS_BACK

[PATCH v4 12/14] sh: Move defines needed for suppressing warning backtraces

2025-03-13 Thread Alessandro Carminati
From: Guenter Roeck Declaring the defines needed for suppressing warning inside '#ifdef CONFIG_DEBUG_BUGVERBOSE' results in a kerneldoc warning. .../bug.h:29: warning: expecting prototype for _EMIT_BUG_ENTRY(). Prototype was for HAVE_BUG_FUNCTION() instead Move the defines above the ker

[PATCH v6 02/16] drm/bridge: Provide a helper to retrieve current bridge state

2025-03-13 Thread Maxime Ripard
The current bridge state is accessible from the drm_bridge structure, but since it's fairly indirect it's not easy to figure out. Provide a helper to retrieve it. Reviewed-by: Dmitry Baryshkov Signed-off-by: Maxime Ripard --- include/drm/drm_bridge.h | 32 1 fi

[PATCH v6 01/16] drm/bridge: Add encoder parameter to drm_bridge_funcs.attach

2025-03-13 Thread Maxime Ripard
The drm_bridge structure contains an encoder pointer that is widely used by bridge drivers. This pattern is largely documented as deprecated in other KMS entities for atomic drivers. However, one of the main use of that pointer is done in attach to just call drm_bridge_attach on the next bridge to

[PATCH v6 03/16] drm/tests: Add kunit tests for bridges

2025-03-13 Thread Maxime Ripard
None of the drm_bridge function have kunit tests so far. Let's change that, starting with drm_bridge_get_current_state(). Reviewed-by: Dmitry Baryshkov Signed-off-by: Maxime Ripard --- drivers/gpu/drm/Kconfig | 1 + drivers/gpu/drm/tests/Makefile | 1 + drivers/gpu/

[PATCH v6 00/16] drm/bridge: Various quality of life improvements

2025-03-13 Thread Maxime Ripard
Hi, Here's a series of changes after to the KMS helpers and bridge API following a bunch of reviews I did. It's mostly centered across providing an easier time to deal with bridge states, and a somewhat consistent with the other entities API. It's build tested only, with arm64 allmodconfig. Max

drm-ci: mediatek: kms_atomic_transition@plane-all-modeset-transition-internal-panels flake

2025-03-13 Thread Vignesh Raman
Hi Maintainers, There are some flake test reported for mediatek driver testing in drm-ci. # Board Name: mt8183-kukui-jacuzzi-juniper-sku16 # Failure Rate: 20 # IGT Version: 1.30-g04bedb923 # Linux Version: 6.14.0-rc4 kms_atomic_transition@plane-all-modeset-transition-internal-panels 11:34:51.89

Re: drm-ci: vkms: kms_flip@modeset-vs-vblank-race flake

2025-03-13 Thread Louis Chauvet
Le 13/03/2025 à 11:45, Vignesh Raman a écrit : Hi Maintainers, Hi Vignesh, Thanks for the report. On my setup, this test passed, and the others are skipped. I think the issue on this specific test may be due to performance (seems to be a timing issue, I will try to slow down my VM). The

Re: [PATCH] drm/amd/display: avoid NPD when ASIC does not support DMUB

2025-03-13 Thread Leo Li
On 2025-03-13 07:29, Thadeu Lima de Souza Cascardo wrote: On Wed, Feb 05, 2025 at 10:06:38AM -0300, Thadeu Lima de Souza Cascardo wrote: ctx->dmub_srv will de NULL if the ASIC does not support DMUB, which is tested in dm_dmub_sw_init. However, it will be dereferenced in dmub_hw_lock_mgr_cmd

Re: [PATCH v4 4/7] dt-bindings: gpu: v3d: Add per-compatible register restrictions

2025-03-13 Thread Krzysztof Kozlowski
On 13/03/2025 15:43, Maíra Canal wrote: > In order to enforce per-SoC register rules, add per-compatible > restrictions. V3D 3.3 (represented by brcm,7268-v3d) has a cache > controller (GCA), which is not present in other V3D generations. > Declaring these differences helps ensure the DTB accuratel

[PATCH v8 6/6] drm/sched: Add a basic test for checking credit limit

2025-03-13 Thread Tvrtko Ursulin
Add a basic test for checking whether scheduler respects the configured credit limit. Signed-off-by: Tvrtko Ursulin Cc: Christian König Cc: Danilo Krummrich Cc: Matthew Brost Cc: Philipp Stanner Acked-by: Christian König --- drivers/gpu/drm/scheduler/tests/tests_basic.c | 60 +++

[PATCH v2] drm/mxsfb: fix missing rollback on failure in mxsfb_probe()

2025-03-13 Thread Luca Ceresoli
ret) + goto err_free; + ret = drm_dev_register(drm, 0); if (ret) goto err_unload; --- base-commit: f9f087d946266bc5da7c3a17bd8fd9d01969e3cf change-id: 20250313-mxsfb_probe-fix-rollback-on-error-3074b9080f34 Best regards, -- Luca Ceresoli

Re: [PATCH] drm/amd/display: avoid NPD when ASIC does not support DMUB

2025-03-13 Thread Alex Deucher
Applied. Thanks. Alex On Thu, Mar 13, 2025 at 11:17 AM Leo Li wrote: > > > > On 2025-03-13 07:29, Thadeu Lima de Souza Cascardo wrote: > > On Wed, Feb 05, 2025 at 10:06:38AM -0300, Thadeu Lima de Souza Cascardo > > wrote: > >> ctx->dmub_srv will de NULL if the ASIC does not support DMUB, which

Re: [PATCH] drm/amdgpu/gfx12: correct cleanup of 'me' field with gfx_v12_0_me_fini()

2025-03-13 Thread Markus Elfring
… > can only release 'pfp' field of 'gfx'. The release function of 'me' field > should be gfx_v12_0_me_fini(). Do you care for an imperative wording in such a change description? https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rs

Re: [PATCH] drm/komeda: Remove unnecessary NULL check before clk_prepare_enable()

2025-03-13 Thread Liviu Dudau
On Thu, Mar 13, 2025 at 04:29:07PM +0800, Chen Ni wrote: > clk_prepare_enable() already checked NULL clock parameter. > Remove unneeded NULL check for clk here. You're not saving anything here. If mdev->aclk is NULL you still end up calling clk_prepare() and clk_enable() even if they return zero i

[PATCH v4 11/14] sh: Add support for suppressing warning backtraces

2025-03-13 Thread Alessandro Carminati
From: Guenter Roeck Add name of functions triggering warning backtraces to the __bug_table object section to enable support for suppressing WARNING backtraces. To limit image size impact, the pointer to the function name is only added to the __bug_table section if both CONFIG_KUNIT_SUPPRESS_BACK

[PATCH v8 2/6] drm/sched: Add scheduler unit testing infrastructure and some basic tests

2025-03-13 Thread Tvrtko Ursulin
Implement a mock scheduler backend and add some basic test to exercise the core scheduler code paths. Mock backend (kind of like a very simple mock GPU) can either process jobs by tests manually advancing the "timeline" job at a time, or alternatively jobs can be configured with a time duration in

[PATCH v8 4/6] drm/sched: Add basic priority tests

2025-03-13 Thread Tvrtko Ursulin
Add some basic tests for exercising entity priority handling. Signed-off-by: Tvrtko Ursulin Cc: Christian König Cc: Danilo Krummrich Cc: Matthew Brost Cc: Philipp Stanner Acked-by: Christian König --- drivers/gpu/drm/scheduler/tests/tests_basic.c | 95 ++- 1 file changed, 94

Re: [PATCH] drm/amdgpu/gfx12: correct cleanup of 'me' field with gfx_v12_0_me_fini()

2025-03-13 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Mar 12, 2025 at 6:09 AM Wentao Liang wrote: > > In gfx_v12_0_cp_gfx_load_me_microcode_rs64(), gfx_v12_0_pfp_fini() is > incorrectly used to free 'me' field of 'gfx', since gfx_v12_0_pfp_fini() > can only release 'pfp' field of 'gfx'. The release function of 'me' fi

Re: [RFC PATCH 00/19] drm, drm/xe: Multi-device GPUSVM

2025-03-13 Thread Thomas Hellström
On Thu, 2025-03-13 at 13:57 +0100, Christian König wrote: > Am 13.03.25 um 13:50 schrieb Thomas Hellström: > > Hi, Christian > > > > On Thu, 2025-03-13 at 11:19 +0100, Christian König wrote: > > > Am 12.03.25 um 22:03 schrieb Thomas Hellström: > > > > This RFC implements and requests comments for

[PATCH RFC 0/3] Initial work for Rust abstraction for HID device driver development

2025-03-13 Thread Rahul Rameshbabu
Hello, I am a hobbyist developer who has been working on a project to create a new Rust HID device driver and the needed core abstractions for writing more HID device drivers in Rust. My goal is to support the USB Monitor Control Class needed for functionality such as backlight control for monitor

[PATCH RFC 3/3] rust: hid: demo the core abstractions for probe and remove

2025-03-13 Thread Rahul Rameshbabu
This is a very basic "hello, world!" implementation to illustrate that the probe and remove callbacks are working as expected. I chose an arbitrary device I had on hand for populating in the HID device id table. [ +0.012968] monitor_control: Probing HID device vendor: 2389 product: 29204 using

[PATCH v8 1/6] drm: Move some options to separate new Kconfig

2025-03-13 Thread Tvrtko Ursulin
Move some options out into a new debug specific kconfig file in order to make things a bit cleaner. Signed-off-by: Tvrtko Ursulin Cc: Christian König Cc: Danilo Krummrich Cc: Matthew Brost Cc: Philipp Stanner Acked-by: Christian König --- drivers/gpu/drm/Kconfig | 109 ++--

Re: [PATCH v2 2/7] drm/bridge: synopsys: Add DW DPTX Controller support library

2025-03-13 Thread Piotr Oniszczuk
> Wiadomość napisana przez Andy Yan w dniu 13 mar 2025, o > godz. 01:23: > > > Hi Piotr, > 在 2025-03-12 22:23:15,"Piotr Oniszczuk" 写道: > > This series still based on Linux 6.14 rc4. > > Did you apply the three dependency patch mentioned in my cover letter? Thx! I noticed https://lore.k

Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-13 Thread Andy Shevchenko
On Thu, Mar 13, 2025 at 11:06:54AM +, Aditya Garg wrote: > > On 13 Mar 2025, at 4:18 PM, Petr Mladek wrote: > > On Thu 2025-03-13 09:13:23, Aditya Garg wrote: > >>> On 13 Mar 2025, at 2:27 PM, Andy Shevchenko > >>> wrote: > >>> On Thu, Mar 13, 2025 at 08:53:28AM +, Aditya Garg wrote: > >

[PATCH v4 6/7] drm/v3d: Use V3D_SMS registers for power on/off and reset on V3D 7.x

2025-03-13 Thread Maíra Canal
In addition to the standard reset controller, V3D 7.x requires configuring the V3D_SMS registers for proper power on/off and reset. Add the new registers to `v3d_regs.h` and ensure they are properly configured during device probing, removal, and reset. This change fixes GPU reset issues on the Ras

[PATCH v4 3/7] drm/v3d: Associate a V3D tech revision to all supported devices

2025-03-13 Thread Maíra Canal
The V3D driver currently determines the GPU tech version (33, 41...) by reading a register. This approach has worked so far since this information wasn’t needed before powering on the GPU. V3D 7.1 introduces new registers that must be written to power on the GPU, requiring us to know the V3D versi

[PATCH v4 1/7] drm/v3d: Don't run jobs that have errors flagged in its fence

2025-03-13 Thread Maíra Canal
The V3D driver still relies on `drm_sched_increase_karma()` and `drm_sched_resubmit_jobs()` for resubmissions when a timeout occurs. The function `drm_sched_increase_karma()` marks the job as guilty, while `drm_sched_resubmit_jobs()` sets an error (-ECANCELED) in the DMA fence of that guilty job.

[PATCH v4 4/7] dt-bindings: gpu: v3d: Add per-compatible register restrictions

2025-03-13 Thread Maíra Canal
In order to enforce per-SoC register rules, add per-compatible restrictions. V3D 3.3 (represented by brcm,7268-v3d) has a cache controller (GCA), which is not present in other V3D generations. Declaring these differences helps ensure the DTB accurately reflect the hardware design. While not ideal,

[PATCH v4 2/7] drm/v3d: Set job pointer to NULL when the job's fence has an error

2025-03-13 Thread Maíra Canal
Similar to commit e4b5ccd392b9 ("drm/v3d: Ensure job pointer is set to NULL after job completion"), ensure the job pointer is set to `NULL` when a job's fence has an error. Failing to do so can trigger kernel warnings in specific scenarios, such as: 1. v3d_csd_job_run() assigns `v3d->csd_job = job

Re: [PATCH RFC 1/2] drm/panel: Add new helpers for refcounted panel allocatons

2025-03-13 Thread Maxime Ripard
Hi Anusha, In addition to the feedback Luca already provided, I have a few comments On Wed, Mar 12, 2025 at 08:54:42PM -0400, Anusha Srivatsa wrote: > Introduce reference counted allocations for panels to avoid > use-after-free. The patch adds the macro devm_drm_bridge_alloc() > to allocate a new

[PATCH] drm/mxsfb: fix missing rollback on failure in mxsfb_probe()

2025-03-13 Thread Luca Ceresoli
ev_register(drm, 0); if (ret) --- base-commit: f9f087d946266bc5da7c3a17bd8fd9d01969e3cf change-id: 20250313-mxsfb_probe-fix-rollback-on-error-3074b9080f34 Best regards, -- Luca Ceresoli

Re: [PATCH RFC 1/2] drm/panel: Add new helpers for refcounted panel allocatons

2025-03-13 Thread Maxime Ripard
On Thu, Mar 13, 2025 at 11:09:44AM +0100, Luca Ceresoli wrote: > Hello Anusha, > > On Wed, 12 Mar 2025 20:54:42 -0400 > Anusha Srivatsa wrote: > > > Introduce reference counted allocations for panels to avoid > > use-after-free. The patch adds the macro devm_drm_bridge_alloc() > > to allocate a

Re: [PATCH v16 5/7] drm/vkms: Create KUnit tests for YUV conversions

2025-03-13 Thread Maxime Ripard
Hi, On Mon, Mar 10, 2025 at 11:12:59AM +0200, Pekka Paalanen wrote: > On Fri, 7 Mar 2025 15:50:41 +0100 > Louis Chauvet wrote: > > > Le 07/03/2025 à 11:20, Maxime Ripard a écrit : > > > On Wed, Feb 19, 2025 at 02:35:14PM +0100, Louis Chauvet wrote: > > >> > > >> > > >> Le 19/02/2025 à 11:15, M

Re: [PATCH v2 0/2] Use proper printk format in appletbdrm

2025-03-13 Thread Alyssa Rosenzweig
series looks ok to me. Who is pushing this to drm-misc-next? (I can if nobody else does)

Re: [RFC PATCH 0/3] gpu: nova-core: add basic timer subdevice implementation

2025-03-13 Thread Simona Vetter
On Fri, Mar 07, 2025 at 10:55:57AM -0400, Jason Gunthorpe wrote: > On Fri, Mar 07, 2025 at 02:09:12PM +0100, Simona Vetter wrote: > > > > A driver can do a health check immediately in remove() and make a > > > decision if the device is alive or not to speed up removal in the > > > hostile hot unpl

Re: [PATCH] drm/mxsfb: fix missing rollback on failure in mxsfb_probe()

2025-03-13 Thread Thomas Zimmermann
e call to the top? No extra cleanup would be required then. Best regards Thomas ret = drm_dev_register(drm, 0); if (ret) --- base-commit: f9f087d946266bc5da7c3a17bd8fd9d01969e3cf change-id: 20250313-mxsfb_probe-fix-rollback-on-error-3074b9080f34 Best regards, -- -- Thomas Zimmer

Re: [PATCH] drm/amd/display: avoid NPD when ASIC does not support DMUB

2025-03-13 Thread Thadeu Lima de Souza Cascardo
On Wed, Feb 05, 2025 at 10:06:38AM -0300, Thadeu Lima de Souza Cascardo wrote: > ctx->dmub_srv will de NULL if the ASIC does not support DMUB, which is > tested in dm_dmub_sw_init. > > However, it will be dereferenced in dmub_hw_lock_mgr_cmd if > should_use_dmub_lock returns true. > > This has be

[PATCH v4 02/14] kunit: bug: Count suppressed warning backtraces

2025-03-13 Thread Alessandro Carminati
From: Guenter Roeck Count suppressed warning backtraces to enable code which suppresses warning backtraces to check if the expected backtrace(s) have been observed. Using atomics for the backtrace count resulted in build errors on some architectures due to include file recursion, so use a plain

Re: [PATCH v5 RESEND 1/2] dmaengine: qcom: gpi: Add GPI Block event interrupt support

2025-03-13 Thread Jyothi Kumar Seerapu
Hi Vinod, Thanks for the review comments. On 3/11/2025 2:30 AM, Vinod Koul wrote: On 12-02-25, 17:35, Jyothi Kumar Seerapu wrote: GSI hardware generates an interrupt for each transfer completion. For multiple messages within a single transfer, this results in N interrupts for N messages, leadin

Re: [PATCH 1/2] fbcon: Register sysfs groups through device_add_group

2025-03-13 Thread Shixiong Ou
在 2025/3/13 00:47, Thomas Weißschuh 写道: Hi, On Tue, Mar 11, 2025 at 07:28:55PM +0800, oushixiong1...@163.com wrote: From: Shixiong Ou Use device_add_group() to simplify creation and removal. Signed-off-by: Shixiong Ou --- drivers/video/fbdev/core/fbcon.c | 48 +++

Re: [PATCH v2 07/10] arm64: dts: qcom: sa8775p-ride: add anx7625 DSI to DP bridge nodes

2025-03-13 Thread Ayushi Makhija
On 3/12/2025 5:18 PM, Krzysztof Kozlowski wrote: > On Tue, Mar 11, 2025 at 05:54:42PM +0530, Ayushi Makhija wrote: >> Add anx7625 DSI to DP bridge device nodes. >> >> Signed-off-by: Ayushi Makhija >> --- >> arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 208 - >> 1 file changed,

Re: [RFC PATCH 00/19] drm, drm/xe: Multi-device GPUSVM

2025-03-13 Thread Christian König
Am 13.03.25 um 13:50 schrieb Thomas Hellström: > Hi, Christian > > On Thu, 2025-03-13 at 11:19 +0100, Christian König wrote: >> Am 12.03.25 um 22:03 schrieb Thomas Hellström: >>> This RFC implements and requests comments for a way to handle SVM >>> with multi-device, >>> typically with fast interco

[PATCH v4 00/14] Add support for suppressing warning backtraces

2025-03-13 Thread Alessandro Carminati
Some unit tests intentionally trigger warning backtraces by passing bad parameters to kernel API functions. Such unit tests typically check the return value from such calls, not the existence of the warning backtrace. Such intentionally generated warning backtraces are neither desirable nor useful

[PATCH v4 01/14] bug/kunit: Core support for suppressing warning backtraces

2025-03-13 Thread Alessandro Carminati
From: Guenter Roeck Some unit tests intentionally trigger warning backtraces by passing bad parameters to API functions. Such unit tests typically check the return value from those calls, not the existence of the warning backtrace. Such intentionally generated warning backtraces are neither desi

[PATCH v4 06/14] x86: Add support for suppressing warning backtraces

2025-03-13 Thread Alessandro Carminati
From: Guenter Roeck Add name of functions triggering warning backtraces to the __bug_table object section to enable support for suppressing WARNING backtraces. To limit image size impact, the pointer to the function name is only added to the __bug_table section if both CONFIG_KUNIT_SUPPRESS_BACK

Re: [PATCH v5 04/16] drm/atomic: Introduce helper to lookup connector by encoder

2025-03-13 Thread Maxime Ripard
Hi, On Thu, Mar 13, 2025 at 04:09:54PM +0800, Andy Yan wrote: > At 2025-03-05 19:55:19, "Andy Yan" wrote: > >At 2025-03-04 19:10:47, "Maxime Ripard" wrote: > >>With the bridges switching over to drm_bridge_connector, the direct > >>association between a bridge driver and its connector was lost.

[PATCH] fbcon: Use static attribute groups for sysfs entries

2025-03-13 Thread oushixiong1025
From: Shixiong Ou Using device_create_with_groups() to simplify creation and removal. Same as commit 1083a7be4504 ("tty: Use static attribute groups for sysfs entries"). Signed-off-by: Shixiong Ou --- drivers/video/fbdev/core/fbcon.c | 67 +--- 1 file changed, 19 in

Re: [PATCH v4 5/7] dt-bindings: gpu: v3d: Add SMS register to BCM2712 compatible

2025-03-13 Thread Krzysztof Kozlowski
On 13/03/2025 15:43, Maíra Canal wrote: > V3D 7.1 exposes a new register block, called V3D_SMS. As BCM2712 has a > V3D 7.1 core, add a new register item to its compatible. Similar to the > GCA, which is specific for V3D 3.3, SMS should only be added for V3D 7.1 > variants (such as brcm,2712-v3d). >

[PATCH v4 7/7] dt-bindings: gpu: Add V3D driver maintainer as DT maintainer

2025-03-13 Thread Maíra Canal
As established in commit 89d04995f76c ("MAINTAINERS: Drop Emma Anholt from all M lines."), Emma is no longer active in the Linux kernel and dropped the V3D maintainership. Therefore, remove Emma as one of the DT maintainers and add the current V3D driver maintainer. Acked-by: Emma Anholt Acked-by

Re: [PATCH] drm/amd/display: avoid NPD when ASIC does not support DMUB

2025-03-13 Thread Rodrigo Siqueira
On 03/13, Thadeu Lima de Souza Cascardo wrote: > On Wed, Feb 05, 2025 at 10:06:38AM -0300, Thadeu Lima de Souza Cascardo wrote: > > ctx->dmub_srv will de NULL if the ASIC does not support DMUB, which is > > tested in dm_dmub_sw_init. > > > > However, it will be dereferenced in dmub_hw_lock_mgr_cmd

Re: [PATCH] drm/mxsfb: fix missing rollback on failure in mxsfb_probe()

2025-03-13 Thread Luca Ceresoli
Hello Thomas, On Thu, 13 Mar 2025 15:40:43 +0100 Thomas Zimmermann wrote: > > @@ -365,9 +365,10 @@ static int mxsfb_probe(struct platform_device *pdev) > > * located anywhere in RAM > > */ > > ret = aperture_remove_all_conflicting_devices(mxsfb_driver.name); > > - if (ret) > > -

Re: [PATCH RFC 0/3] Initial work for Rust abstraction for HID device driver development

2025-03-13 Thread Benjamin Tissoires
Hi, [quick reply because I am completely under the water for the next 2 weeks] On Mar 13 2025, Rahul Rameshbabu wrote: > Hello, > > I am a hobbyist developer who has been working on a project to create a new > Rust > HID device driver and the needed core abstractions for writing more HID device

[PATCH] drm/komeda: Remove unnecessary NULL check before clk_prepare_enable()

2025-03-13 Thread Chen Ni
clk_prepare_enable() already checked NULL clock parameter. Remove unneeded NULL check for clk here. Signed-off-by: Chen Ni --- drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/

[PATCH v7 5/6] drm/xe/xe_gt_pagefault: Add address_type field to pagefaults

2025-03-13 Thread Jonathan Cavitt
Add a new field to the xe_pagefault struct, address_type, that tracks the type of fault the pagefault incurred. Signed-off-by: Jonathan Cavitt --- drivers/gpu/drm/xe/xe_gt_pagefault.c | 3 +++ drivers/gpu/drm/xe/xe_gt_pagefault.h | 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/gpu/

[RFC PATCH 06/19] drm/pagemap, drm/xe: Add refcounting to struct drm_pagemap and manage lifetime

2025-03-13 Thread Thomas Hellström
Remove the xe embedded drm_pagemap, and instead allocate and reference count. This is a step towards adding drm_pagemaps on demand. Signed-off-by: Thomas Hellström --- drivers/gpu/drm/drm_pagemap.c| 58 +++- drivers/gpu/drm/xe/xe_device_types.h | 2 +- drivers/gp

[PULL] drm-xe-fixes

2025-03-13 Thread Rodrigo Vivi
Hi Dave and Sima, Here goes xe fixes for this week. It is worth mention that we are disabling D3Cold on BMG because we found some bugs where depending on the combination of BMG card and the host, the PCI upstream port link port re-training might fail on D3Cold -> D0 blowing things up. But while w

Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-13 Thread Aditya Garg
> On 13 Mar 2025, at 2:19 PM, Andy Shevchenko > wrote: > > On Thu, Mar 13, 2025 at 07:26:05AM +, Aditya Garg wrote: On 13 Mar 2025, at 12:58 AM, Andy Shevchenko wrote: >>> On Wed, Mar 12, 2025 at 07:14:36PM +, Aditya Garg wrote: > On 12 Mar 2025, at 9:05 PM, Sven Peter

Re: [PATCH v4 07/14] arm64: Add support for suppressing warning backtraces

2025-03-13 Thread Alessandro Carminati
Hello Will, On Thu, Mar 13, 2025 at 1:25 PM Will Deacon wrote: > > On Thu, Mar 13, 2025 at 11:43:22AM +, Alessandro Carminati wrote: > > diff --git a/arch/arm64/include/asm/bug.h b/arch/arm64/include/asm/bug.h > > index 28be048db3f6..044c5e24a17d 100644 > > --- a/arch/arm64/include/asm/bug.h

Re: [PATCH RFC 0/3] Initial work for Rust abstraction for HID device driver development

2025-03-13 Thread Benno Lossin
On Thu Mar 13, 2025 at 5:02 PM CET, Rahul Rameshbabu wrote: > Hello, > > I am a hobbyist developer who has been working on a project to create a new > Rust > HID device driver and the needed core abstractions for writing more HID device > drivers in Rust. My goal is to support the USB Monitor Cont

drm-ci: mediatek: kms_atomic_transition@plane-toggle-modeset-transition flake

2025-03-13 Thread Vignesh Raman
Hi Maintainers, There are some flake test reported for mediatek driver testing in drm-ci. # Board Name: mt8183-kukui-jacuzzi-juniper-sku16 # Failure Rate: 20 # IGT Version: 1.30-g04bedb923 # Linux Version: 6.14.0-rc4 kms_atomic_transition@plane-toggle-modeset-transition 11:13:54.607: DEBUG - Be

Re: [PATCH v4 1/7] drm/v3d: Don't run jobs that have errors flagged in its fence

2025-03-13 Thread Maíra Canal
On 13/03/25 11:43, Maíra Canal wrote: The V3D driver still relies on `drm_sched_increase_karma()` and `drm_sched_resubmit_jobs()` for resubmissions when a timeout occurs. The function `drm_sched_increase_karma()` marks the job as guilty, while `drm_sched_resubmit_jobs()` sets an error (-ECANCELED

Re: [PATCH RFC 1/2] drm/panel: Add new helpers for refcounted panel allocatons

2025-03-13 Thread Anusha Srivatsa
On Thu, Mar 13, 2025 at 10:42 AM Maxime Ripard wrote: > Hi Anusha, > > In addition to the feedback Luca already provided, I have a few comments > > On Wed, Mar 12, 2025 at 08:54:42PM -0400, Anusha Srivatsa wrote: > > Introduce reference counted allocations for panels to avoid > > use-after-free.

[PATCH v8 3/6] drm/xe/uapi: Define drm_xe_vm_get_property

2025-03-13 Thread Jonathan Cavitt
Add initial declarations for the drm_xe_vm_get_property ioctl. Signed-off-by: Jonathan Cavitt --- include/uapi/drm/xe_drm.h | 69 +++ 1 file changed, 69 insertions(+) diff --git a/include/uapi/drm/xe_drm.h b/include/uapi/drm/xe_drm.h index 616916985e3f..0ed52

Re: [PATCH v4 00/14] Add support for suppressing warning backtraces

2025-03-13 Thread Andrew Morton
On Thu, 13 Mar 2025 11:31:12 -0700 Guenter Roeck wrote: > On Thu, Mar 13, 2025 at 06:24:25PM +0100, Maxime Ripard wrote: > > > > > > Yeah, as with my prior review, I'm a fan of this. It makes a bunch of my > > > very noisy tests much easier to deal with. > > > > And for the record, we're also a

Re: [PATCH v8 3/6] drm/xe/uapi: Define drm_xe_vm_get_property

2025-03-13 Thread Jianxun Zhang
On 3/13/25 11:34, Jonathan Cavitt wrote: Add initial declarations for the drm_xe_vm_get_property ioctl. Signed-off-by: Jonathan Cavitt --- include/uapi/drm/xe_drm.h | 69 +++ 1 file changed, 69 insertions(+) diff --git a/include/uapi/drm/xe_drm.h b/inc

[PATCH v8 5/6] drm/sched: Add a basic test for modifying entities scheduler list

2025-03-13 Thread Tvrtko Ursulin
Add a basic test for exercising modifying the entities scheduler list at runtime. Signed-off-by: Tvrtko Ursulin Cc: Christian König Cc: Danilo Krummrich Cc: Matthew Brost Cc: Philipp Stanner Acked-by: Christian König --- drivers/gpu/drm/scheduler/tests/tests_basic.c | 69 ++-

[PATCH v8 3/6] drm/sched: Add a simple timeout test

2025-03-13 Thread Tvrtko Ursulin
Add a very simple timeout test which submits a single job and verifies that the timeout handling will run if the backend failed to complete the job in time. Signed-off-by: Tvrtko Ursulin Cc: Christian König Cc: Danilo Krummrich Cc: Matthew Brost Cc: Philipp Stanner Acked-by: Christian König

Re: [PATCH v4] drm/i915: Fix harmful driver register/unregister asymmetry

2025-03-13 Thread Janusz Krzysztofik
On Thursday, 13 March 2025 14:11:35 CET Krzysztof Niemiec wrote: > Hi Janusz, > > On 2025-03-12 at 17:58:13 GMT, Janusz Krzysztofik wrote: > > Hi Krzysztof, > > > > Thanks for looking at this. > > > > On Wednesday, 12 March 2025 16:06:15 CET Krzysztof Niemiec wrote: > > > On 2025-03-11 at 21:04:

[PATCH v8 0/6] DRM scheduler kunit tests

2025-03-13 Thread Tvrtko Ursulin
There has repeatedly been quite a bit of apprehension when any change to the DRM scheduler is proposed, with two main reasons being code base is considered fragile, not well understood and not very well documented, and secondly the lack of systematic testing outside the vendor specific tests suites

Re: [PATCH v4] drm/i915: Fix harmful driver register/unregister asymmetry

2025-03-13 Thread Krzysztof Niemiec
Hi Janusz, On 2025-03-12 at 17:58:13 GMT, Janusz Krzysztofik wrote: > Hi Krzysztof, > > Thanks for looking at this. > > On Wednesday, 12 March 2025 16:06:15 CET Krzysztof Niemiec wrote: > > On 2025-03-11 at 21:04:56 GMT, Janusz Krzysztofik wrote: > > > Starting with commit ec3e00b4ee27 ("drm/i91

[PATCH v6 04/16] drm/atomic: Introduce helper to lookup connector by encoder

2025-03-13 Thread Maxime Ripard
With the bridges switching over to drm_bridge_connector, the direct association between a bridge driver and its connector was lost. This is mitigated for atomic bridge drivers by the fact you can access the encoder, and then call drm_atomic_get_old_connector_for_encoder() or drm_atomic_get_new_con

Re: [Upstream] [PATCH v7 3/3] arm64: dts: imx8mm-phyboard-polis-peb-av-10: Set lvds-vod-swing

2025-03-13 Thread Andrej Picej
Hi, is there anything else I need to do, or can this patch now be applied? The initial two patches that introduce property support have already been merged, and the patch series that this patch depends on [1] has also been applied. [1] https://lore.kernel.org/all/Z7rZjdXwN2W+Y2Bd@dragon/ Be

[PATCH v6 05/16] drm/tests: helpers: Create new helper to enable output

2025-03-13 Thread Maxime Ripard
We'll need the HDMI state tests light_up_connector() function in more tests, so let's promote it to a helper. Reviewed-by: Dmitry Baryshkov Signed-off-by: Maxime Ripard --- drivers/gpu/drm/tests/drm_kunit_helpers.c | 61 +++ include/drm/drm_kunit_helpers.h

[PATCH v6 08/16] drm/bridge: Add helper to reset bridge pipeline

2025-03-13 Thread Maxime Ripard
Let's provide an helper to make it easier for bridge drivers to power-cycle their bridge. In order to avoid a circular dependency between that new helper and drm_atomic_helper_reset_crtc(), this new helper will be in a drm_bridge_helper.c file to follow the pattern we have for other objects. Revi

[PATCH v6 06/16] drm/tests: hdmi_state_helpers: Switch to new helper

2025-03-13 Thread Maxime Ripard
We introduced a new helper that supersedes the light_up_connector() function in drm_hdmi_state_helper_test, so let's convert all our tests to it. Reviewed-by: Dmitry Baryshkov Signed-off-by: Maxime Ripard --- drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c | 158 - 1 file

[PATCH v6 16/16] drm/bridge: ti-sn65dsi86: Remove drm_encoder->crtc use

2025-03-13 Thread Maxime Ripard
The TI sn65dsi86 driver follows the drm_encoder->crtc pointer that is deprecated and shouldn't be used by atomic drivers. Fortunately, the atomic hooks provide the drm_atomic_state and we can access our current CRTC from that, going from the bridge to its encoder, to its connector, and to its CRTC

[PATCH v6 12/16] drm/bridge: cdns-csi: Switch to atomic helpers

2025-03-13 Thread Maxime Ripard
The Cadence DSI driver follows the drm_encoder->crtc pointer that is deprecated and shouldn't be used by atomic drivers. Fortunately, the atomic hooks provide the drm_atomic_state and we can access our current CRTC from that, going from the bridge to its encoder, to its connector, and to its CRTC.

[PATCH v6 11/16] drm/bridge: Introduce drm_bridge_is_atomic() helper

2025-03-13 Thread Maxime Ripard
We test for whether the bridge is atomic in several places in the source code, so let's consolidate them. Suggested-by: Dmitry Baryshkov Reviewed-by: Dmitry Baryshkov Signed-off-by: Maxime Ripard --- drivers/gpu/drm/drm_bridge.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) d

[PATCH v6 13/16] drm/bridge: tc358775: Switch to atomic commit

2025-03-13 Thread Maxime Ripard
The tc358775 driver follows the drm_encoder->crtc pointer that is deprecated and shouldn't be used by atomic drivers. Fortunately, the atomic hooks provide the drm_atomic_state and we can access our current CRTC from that, going from the bridge to its encoder, to its connector, and to its CRTC. L

[PATCH v6 10/16] drm/bridge: ti-sn65dsi83: Switch to drm_bridge_helper_reset_crtc

2025-03-13 Thread Maxime Ripard
Now that we have a helper for bridge drivers to call to reset the output pipeline, let's use it. Reviewed-by: Dmitry Baryshkov Reviewed-by: Herve Codina Tested-by: Herve Codina Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/ti-sn65dsi83.c | 28 +++- 1 file cha

[PATCH v6 09/16] drm/tests: bridge: Provide tests for drm_bridge_helper_reset_crtc

2025-03-13 Thread Maxime Ripard
Let's provide a bunch of kunit tests to make sure drm_bridge_helper_reset_crtc() works as expected. Reviewed-by: Dmitry Baryshkov Signed-off-by: Maxime Ripard --- drivers/gpu/drm/tests/drm_bridge_test.c | 209 +++- 1 file changed, 208 insertions(+), 1 deletion(-) di

[PATCH v6 15/16] drm/bridge: tc358768: Convert to atomic helpers

2025-03-13 Thread Maxime Ripard
The tc358768 driver follows the drm_encoder->crtc pointer that is deprecated and shouldn't be used by atomic drivers. Fortunately, the atomic hooks provide the drm_atomic_state and we can access our current CRTC from that, going from the bridge to its encoder, to its connector, and to its CRTC. L

[PATCH v6 14/16] drm/bridge: tc358768: Stop disabling when failing to enable

2025-03-13 Thread Maxime Ripard
The tc358768 bridge driver, if enabling it fails, tries to disable it. This is pretty uncommon in bridge drivers, and also stands in the way for further reworks. Worse, since pre_enable and enable aren't expected to fail, disable and post_disable might be called twice: once to handle the failure,

Re: [PATCH v6 14/26] drm/bridge: add support for refcounted DRM bridges

2025-03-13 Thread Luca Ceresoli
Hello Maxime, On Fri, 7 Feb 2025 12:47:51 +0100 Maxime Ripard wrote: > Hi, > > On Thu, Feb 06, 2025 at 07:14:29PM +0100, Luca Ceresoli wrote: > > DRM bridges are currently considered as a fixed element of a DRM card, and > > thus their lifetime is assumed to extend for as long as the card > > e

Re: [RFC PATCH 00/19] drm, drm/xe: Multi-device GPUSVM

2025-03-13 Thread Thomas Hellström
Hi, Christian On Thu, 2025-03-13 at 11:19 +0100, Christian König wrote: > Am 12.03.25 um 22:03 schrieb Thomas Hellström: > > This RFC implements and requests comments for a way to handle SVM > > with multi-device, > > typically with fast interconnects. It adds generic code and helpers > > in drm,

Re: [PATCH v4 9/9] drm/vkms: convert to use faux_device

2025-03-13 Thread Simona Vetter
On Wed, Mar 12, 2025 at 07:22:07AM +0100, Greg KH wrote: > On Tue, Mar 11, 2025 at 06:20:53PM +0100, José Expósito wrote: > > Hi everyone, > > > > > On Tue, Feb 25, 2025 at 02:51:40PM +0100, Louis Chauvet wrote: > > > > > > > > > > > > Le 25/02/2025 à 12:41, Thomas Zimmermann a écrit : > > > > >

[PATCH RFC 1/3] rust: core abstractions for HID drivers

2025-03-13 Thread Rahul Rameshbabu
These abstractions enable the development of HID drivers in Rust by binding with the HID core C API. They provide Rust types that map to the equivalents in C. In this initial draft, only hid_device and hid_device_id are provided direct Rust type equivalents. hid_driver is specially wrapped with a c

[PATCH] drm/ttm/tests: fix incorrect assert in ttm_bo_unreserve_bulk()

2025-03-13 Thread Qasim Ijaz
In the ttm_bo_unreserve_bulk() test function, resv is allocated using kunit_kzalloc(), but the subsequent assertion mistakenly verifies the ttm_dev pointer instead of the resv pointer. Fix the assertion to properly verify the resv pointer. Signed-off-by: Qasim Ijaz --- drivers/gpu/drm/ttm/tests

[PATCH v4 5/7] dt-bindings: gpu: v3d: Add SMS register to BCM2712 compatible

2025-03-13 Thread Maíra Canal
V3D 7.1 exposes a new register block, called V3D_SMS. As BCM2712 has a V3D 7.1 core, add a new register item to its compatible. Similar to the GCA, which is specific for V3D 3.3, SMS should only be added for V3D 7.1 variants (such as brcm,2712-v3d). Signed-off-by: Maíra Canal --- Documentation/d

  1   2   3   >