[PATCH 1/5] drm/dp: Pull drm_dp_link_power_up/down from Tegra to common drm_dp_helper

2025-03-13 Thread Andy Yan
From: Andy Yan The helper functions drm_dp_link_power_up/down were moved to Tegra DRM at 2019[0]. Now since more and more users are duplicating the same code in their own drivers, it's time to make them as DRM DP common helpers again. [0]https://patchwork.freedesktop.org/patch/336850/?series=68

[PATCH 2/5] drm/bridge: cdns-mhdp8546: Switch to common helpers to power up/down dp link

2025-03-13 Thread Andy Yan
From: Andy Yan Use the common dp link power up/down helpers to avoid duplicating code. Signed-off-by: Andy Yan --- .../drm/bridge/cadence/cdns-mhdp8546-core.c | 74 +-- 1 file changed, 2 insertions(+), 72 deletions(-) diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp854

[PATCH 4/5] drm/bridge: anx78xx: Switch to common helpers to power up/down dp link

2025-03-13 Thread Andy Yan
From: Andy Yan Use the common dp link power up/down helpers to avoid duplicating code. Signed-off-by: Andy Yan --- .../drm/bridge/analogix/analogix-anx78xx.c| 30 +-- 1 file changed, 1 insertion(+), 29 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx

[PATCH 5/5] drm/bridge: it6505: Switch to common helpers to power up/down dp link

2025-03-13 Thread Andy Yan
From: Andy Yan Use the common dp link power up/down helpers to avoid duplicating code. Signed-off-by: Andy Yan --- drivers/gpu/drm/bridge/ite-it6505.c | 46 +++-- 1 file changed, 4 insertions(+), 42 deletions(-) diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/driv

[PATCH 3/5] drm/bridge: anx6345: Switch to common helpers to power up/down dp link

2025-03-13 Thread Andy Yan
From: Andy Yan Use the common dp link power up/down helpers to avoid duplicating code. Signed-off-by: Andy Yan --- .../drm/bridge/analogix/analogix-anx6345.c| 30 +-- 1 file changed, 1 insertion(+), 29 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx

Re: [PATCH v2 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-13 Thread Aditya Garg
> On 13 Mar 2025, at 4:49 PM, Aditya Garg wrote: > > From: Hector Martin > > %p4cc is designed for DRM/V4L2 FourCCs with their specific quirks, but > it's useful to be able to print generic 4-character codes formatted as > an integer. Extend it to add format specifiers for printing generic >

Re: [PATCH 4/5] drm/bridge: anx78xx: Switch to common helpers to power up/down dp link

2025-03-13 Thread Dmitry Baryshkov
On Fri, Mar 14, 2025 at 11:38:43AM +0800, Andy Yan wrote: > From: Andy Yan > > Use the common dp link power up/down helpers to avoid duplicating code. > > Signed-off-by: Andy Yan > --- > > .../drm/bridge/analogix/analogix-anx78xx.c| 30 +-- > 1 file changed, 1 insertion(+)

Re: [PATCH 5/5] drm/bridge: it6505: Switch to common helpers to power up/down dp link

2025-03-13 Thread Dmitry Baryshkov
On Fri, Mar 14, 2025 at 11:38:44AM +0800, Andy Yan wrote: > From: Andy Yan > > Use the common dp link power up/down helpers to avoid duplicating code. > > Signed-off-by: Andy Yan > --- > > drivers/gpu/drm/bridge/ite-it6505.c | 46 +++-- > 1 file changed, 4 insertions(+

[PATCH RFC v4 3/6] drm/display: dp: use new DCPD access helpers

2025-03-13 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Switch drm_dp_helper.c to use new set of DPCD read / write helpers. Reviewed-by: Lyude Paul Acked-by: Jani Nikula Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_dp_helper.c | 296 +--- 1 file changed, 116 insertions(+), 180

[PATCH RFC v4 5/6] drm/display: dp-mst-topology: use new DCPD access helpers

2025-03-13 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Switch drm_dp_mst_topology.c to use new set of DPCD read / write helpers. Reviewed-by: Lyude Paul Acked-by: Jani Nikula Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_dp_mst_topology.c | 105 +- 1 file changed, 51 insertions(+),

[PATCH RFC v4 1/6] drm/display: dp: implement new access helpers

2025-03-13 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Existing DPCD access functions return an error code or the number of bytes being read / write in case of partial access. However a lot of drivers either (incorrectly) ignore partial access or mishandle error codes. In other cases this results in a boilerplate code which com

[PATCH RFC v4 4/6] drm/display: dp-cec: use new DCPD access helpers

2025-03-13 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Switch drm_dp_cec.c to use new set of DPCD read / write helpers. Reviewed-by: Lyude Paul Acked-by: Jani Nikula Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_dp_cec.c | 37 ++-- 1 file changed, 18 insertions(+), 19 delet

[PATCH RFC v4 0/6] drm/display: dp: add new DPCD access functions

2025-03-13 Thread Dmitry Baryshkov
Existing DPCD access functions return an error code or the number of bytes being read / write in case of partial access. However a lot of drivers either (incorrectly) ignore partial access or mishandle error codes. In other cases this results in a boilerplate code which compares returned value with

[PATCH v2 10/10] arm64: dts: qcom: sar2130p: add display nodes

2025-03-13 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Add display controller, two DSI hosts, two DSI PHYs and a single DP controller. Link DP to the QMP Combo PHY. Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sar2130p.dtsi | 394 + 1 file changed, 394 insertions(+) diff --git

[PATCH v2 07/10] drm/msm/dsi/phy: add configuration for SAR2130P

2025-03-13 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Qualcomm SAR2130P requires slightly different setup for the DSI PHY. It is a 5nm PHY (like SM8450), so supplies are the same, but the rest of the configuration is the same as SM8550 DSI PHY. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/phy/dsi_phy.c |

[PATCH RFC v4 2/6] drm/display: dp: change drm_dp_dpcd_read_link_status() return value

2025-03-13 Thread Dmitry Baryshkov
From: Dmitry Baryshkov drm_dp_dpcd_read_link_status() follows the "return error code or number of bytes read" protocol, with the code returning less bytes than requested in case of some errors. However most of the drivers interpreted that as "return error code in case of any error". Switch drm_dp

Re: [PATCH v4 4/7] dt-bindings: gpu: v3d: Add per-compatible register restrictions

2025-03-13 Thread Maíra Canal
+Cc Stefan Hi Krzysztof, On 13/03/25 12:03, Krzysztof Kozlowski wrote: On 13/03/2025 15:43, Maíra Canal wrote: In order to enforce per-SoC register rules, add per-compatible restrictions. V3D 3.3 (represented by brcm,7268-v3d) has a cache controller (GCA), which is not present in other V3D gen

Re: [PATCH v5 04/16] drm/atomic: Introduce helper to lookup connector by encoder

2025-03-13 Thread Dmitry Baryshkov
On Fri, Mar 14, 2025 at 08:50:29AM +0800, Andy Yan wrote: > > Hi Maxime and Simona, > > > At 2025-03-13 19:55:33, "Maxime Ripard" wrote: > >Hi, > > > >On Thu, Mar 13, 2025 at 04:09:54PM +0800, Andy Yan wrote: > >> At 2025-03-05 19:55:19, "Andy Yan" wrote: > >> >At 2025-03-04 19:10:47, "Maxime

[PATCH v2 04/10] dt-bindings: display/msm: qcom,sc7280-dpu: describe SAR2130P

2025-03-13 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Describe DPU controller present on Qualcomm SAR2130P platform. Signed-off-by: Dmitry Baryshkov Reviewed-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/display/msm/qcom,sc7280-dpu.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devic

[PATCH v2 05/10] dt-bindings: display/msm: Add Qualcomm SAR2130P

2025-03-13 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Describe the Mobile Display SubSystem (MDSS) device present on the Qualcomm SAR2130P platform. It looks pretty close to SM8550 on the system level. SAR2130P features two DSI hosts and single DisplayPort controller. Signed-off-by: Dmitry Baryshkov Reviewed-by: Krzysztof Ko

[PATCH v2 00/10] drm/msm: add support for SAR2130P

2025-03-13 Thread Dmitry Baryshkov
Add support for the Mobile Display SubSystem (MDSS) device present on the Qualcomm SAR2130P platform. The MDSS device is similar to SM8550, it features two MIPI DSI controllers, two MIPI DSI PHYs and one DisplayPort controller. Note, due to the technical limitations DP controller wasn't completely

[PATCH v2 06/10] drm/msm/mdss: add SAR2130P device configuration

2025-03-13 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Add compatible and device configuration for the Qualcomm SAR2130P platform. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c

[PATCH v2 03/10] dt-bindings: display/msm: dsi-phy-7nm: describe SAR2130P

2025-03-13 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Describe MIPI DSI PHY present on Qualcomm SAR2130P platform. Signed-off-by: Dmitry Baryshkov Reviewed-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/

[PATCH v2 01/10] dt-bindings: display/msm: dp-controller: describe SAR2130P

2025-03-13 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Describe DisplayPort controller present on Qualcomm SAR2130P platform. Signed-off-by: Dmitry Baryshkov Reviewed-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation

[PATCH v2 08/10] drm/msm/dpu: add catalog entry for SAR2130P

2025-03-13 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Add DPU driver support for the Qualcomm SAR2130P platform. It is mostly the same as SM8550, minor differences in the CDP configuration. Signed-off-by: Dmitry Baryshkov --- .../drm/msm/disp/dpu1/catalog/dpu_9_1_sar2130p.h | 434 + drivers/gpu/drm/msm

[PATCH v2] fbcon: Use static attribute groups for sysfs entries

2025-03-13 Thread oushixiong1025
From: Shixiong Ou Using device_create_with_groups() to simplify creation and removal. Same as commit 1083a7be4504 ("tty: Use static attribute groups for sysfs entries"). Signed-off-by: Shixiong Ou --- drivers/video/fbdev/core/fbcon.c | 69 +--- 1 file changed, 19 in

[PATCH v2 09/10] iommu/arm-smmu-qcom: Add SAR2130P MDSS compatible

2025-03-13 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Add the SAR2130P compatible to clients compatible list, the device require identity domain. Signed-off-by: Dmitry Baryshkov --- drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c b/dr

Re: [PATCH] drm/msm/dpu: Fix error pointers in dpu_plane_virtual_atomic_check

2025-03-13 Thread Dmitry Baryshkov
On Thu, Mar 13, 2025 at 08:10:04PM -0500, Chenyuan Yang wrote: > The function dpu_plane_virtual_atomic_check was dereferencing pointers > returned by drm_atomic_get_plane_state without checking for errors. This > could lead to undefined behavior if the function returns an error pointer. > > This c

[PATCH] drm/panel/synaptics-r63353: Use _multi variants

2025-03-13 Thread Anusha Srivatsa
Move away from using deprecated API and use _multi variants if available. Use mipi_dsi_msleep() and mipi_dsi_usleep_range() instead of msleep() and usleep_range() respectively. Used Coccinelle to find the _multi variant APIs, replacing mpi_dsi_msleep() where necessary and for returning dsi_ctx.acc

Re: [PATCH 2/5] drm/bridge: cdns-mhdp8546: Switch to common helpers to power up/down dp link

2025-03-13 Thread Dmitry Baryshkov
On Fri, Mar 14, 2025 at 11:38:41AM +0800, Andy Yan wrote: > From: Andy Yan > > Use the common dp link power up/down helpers to avoid duplicating code. > > Signed-off-by: Andy Yan > --- > > .../drm/bridge/cadence/cdns-mhdp8546-core.c | 74 +-- > 1 file changed, 2 insertions(+

Re: [PATCH 3/5] drm/bridge: anx6345: Switch to common helpers to power up/down dp link

2025-03-13 Thread Dmitry Baryshkov
On Fri, Mar 14, 2025 at 11:38:42AM +0800, Andy Yan wrote: > From: Andy Yan > > Use the common dp link power up/down helpers to avoid duplicating code. > > Signed-off-by: Andy Yan > --- > > .../drm/bridge/analogix/analogix-anx6345.c| 30 +-- > 1 file changed, 1 insertion(+)

[PATCH v4 10/14] s390: Add support for suppressing warning backtraces

2025-03-13 Thread Alessandro Carminati
From: Guenter Roeck Add name of functions triggering warning backtraces to the __bug_table object section to enable support for suppressing WARNING backtraces. To limit image size impact, the pointer to the function name is only added to the __bug_table section if both CONFIG_KUNIT_SUPPRESS_BACK

[PATCH v4 14/14] powerpc: Add support for suppressing warning backtraces

2025-03-13 Thread Alessandro Carminati
From: Guenter Roeck Add name of functions triggering warning backtraces to the __bug_table object section to enable support for suppressing WARNING backtraces. To limit image size impact, the pointer to the function name is only added to the __bug_table section if both CONFIG_KUNIT_SUPPRESS_BACK

[PATCH v4 13/14] riscv: Add support for suppressing warning backtraces

2025-03-13 Thread Alessandro Carminati
From: Guenter Roeck Add name of functions triggering warning backtraces to the __bug_table object section to enable support for suppressing WARNING backtraces. To limit image size impact, the pointer to the function name is only added to the __bug_table section if both CONFIG_KUNIT_SUPPRESS_BACK

[PATCH v4 09/14] parisc: Add support for suppressing warning backtraces

2025-03-13 Thread Alessandro Carminati
From: Guenter Roeck Add name of functions triggering warning backtraces to the __bug_table object section to enable support for suppressing WARNING backtraces. To limit image size impact, the pointer to the function name is only added to the __bug_table section if both CONFIG_KUNIT_SUPPRESS_BACK

[PATCH v4 07/14] arm64: Add support for suppressing warning backtraces

2025-03-13 Thread Alessandro Carminati
From: Guenter Roeck Add name of functions triggering warning backtraces to the __bug_table object section to enable support for suppressing WARNING backtraces. To limit image size impact, the pointer to the function name is only added to the __bug_table section if both CONFIG_KUNIT_SUPPRESS_BACK

[PATCH v4 05/14] drm: Suppress intentional warning backtraces in scaling unit tests

2025-03-13 Thread Alessandro Carminati
From: Guenter Roeck The drm_test_rect_calc_hscale and drm_test_rect_calc_vscale unit tests intentionally trigger warning backtraces by providing bad parameters to the tested functions. What is tested is the return value, not the existence of a warning backtrace. Suppress the backtraces to avoid c

[PATCH v4 04/14] kunit: Add documentation for warning backtrace suppression API

2025-03-13 Thread Alessandro Carminati
From: Guenter Roeck Document API functions for suppressing warning backtraces. Tested-by: Linux Kernel Functional Testing Acked-by: Dan Carpenter Reviewed-by: Kees Cook Signed-off-by: Guenter Roeck Reviewed-by: David Gow Signed-off-by: Alessandro Carminati --- Documentation/dev-tools/kuni

Re: [PATCH v4 07/14] arm64: Add support for suppressing warning backtraces

2025-03-13 Thread Will Deacon
On Thu, Mar 13, 2025 at 11:43:22AM +, Alessandro Carminati wrote: > diff --git a/arch/arm64/include/asm/bug.h b/arch/arm64/include/asm/bug.h > index 28be048db3f6..044c5e24a17d 100644 > --- a/arch/arm64/include/asm/bug.h > +++ b/arch/arm64/include/asm/bug.h > @@ -11,8 +11,14 @@ > > #include

Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-13 Thread Andy Shevchenko
On Thu, Mar 13, 2025 at 08:53:28AM +, Aditya Garg wrote: > > On 13 Mar 2025, at 2:19 PM, Andy Shevchenko > > wrote: > > On Thu, Mar 13, 2025 at 07:26:05AM +, Aditya Garg wrote: > On 13 Mar 2025, at 12:58 AM, Andy Shevchenko > wrote: > >>> On Wed, Mar 12, 2025 at 07:14:36PM +00

[PATCH v4 03/14] kunit: Add test cases for backtrace warning suppression

2025-03-13 Thread Alessandro Carminati
From: Guenter Roeck Add unit tests to verify that warning backtrace suppression works. If backtrace suppression does _not_ work, the unit tests will likely trigger unsuppressed backtraces, which should actually help to get the affected architectures / platforms fixed. Tested-by: Linux Kernel Fu

[PATCH v4 08/14] loongarch: Add support for suppressing warning backtraces

2025-03-13 Thread Alessandro Carminati
From: Guenter Roeck Add name of functions triggering warning backtraces to the __bug_table object section to enable support for suppressing WARNING backtraces. To limit image size impact, the pointer to the function name is only added to the __bug_table section if both CONFIG_KUNIT_SUPPRESS_BACK

[PATCH v4 12/14] sh: Move defines needed for suppressing warning backtraces

2025-03-13 Thread Alessandro Carminati
From: Guenter Roeck Declaring the defines needed for suppressing warning inside '#ifdef CONFIG_DEBUG_BUGVERBOSE' results in a kerneldoc warning. .../bug.h:29: warning: expecting prototype for _EMIT_BUG_ENTRY(). Prototype was for HAVE_BUG_FUNCTION() instead Move the defines above the ker

[PATCH v6 02/16] drm/bridge: Provide a helper to retrieve current bridge state

2025-03-13 Thread Maxime Ripard
The current bridge state is accessible from the drm_bridge structure, but since it's fairly indirect it's not easy to figure out. Provide a helper to retrieve it. Reviewed-by: Dmitry Baryshkov Signed-off-by: Maxime Ripard --- include/drm/drm_bridge.h | 32 1 fi

[PATCH v6 01/16] drm/bridge: Add encoder parameter to drm_bridge_funcs.attach

2025-03-13 Thread Maxime Ripard
The drm_bridge structure contains an encoder pointer that is widely used by bridge drivers. This pattern is largely documented as deprecated in other KMS entities for atomic drivers. However, one of the main use of that pointer is done in attach to just call drm_bridge_attach on the next bridge to

[PATCH v6 03/16] drm/tests: Add kunit tests for bridges

2025-03-13 Thread Maxime Ripard
None of the drm_bridge function have kunit tests so far. Let's change that, starting with drm_bridge_get_current_state(). Reviewed-by: Dmitry Baryshkov Signed-off-by: Maxime Ripard --- drivers/gpu/drm/Kconfig | 1 + drivers/gpu/drm/tests/Makefile | 1 + drivers/gpu/

[PATCH v6 00/16] drm/bridge: Various quality of life improvements

2025-03-13 Thread Maxime Ripard
Hi, Here's a series of changes after to the KMS helpers and bridge API following a bunch of reviews I did. It's mostly centered across providing an easier time to deal with bridge states, and a somewhat consistent with the other entities API. It's build tested only, with arm64 allmodconfig. Max

drm-ci: mediatek: kms_atomic_transition@plane-all-modeset-transition-internal-panels flake

2025-03-13 Thread Vignesh Raman
Hi Maintainers, There are some flake test reported for mediatek driver testing in drm-ci. # Board Name: mt8183-kukui-jacuzzi-juniper-sku16 # Failure Rate: 20 # IGT Version: 1.30-g04bedb923 # Linux Version: 6.14.0-rc4 kms_atomic_transition@plane-all-modeset-transition-internal-panels 11:34:51.89

Re: drm-ci: vkms: kms_flip@modeset-vs-vblank-race flake

2025-03-13 Thread Louis Chauvet
Le 13/03/2025 à 11:45, Vignesh Raman a écrit : Hi Maintainers, Hi Vignesh, Thanks for the report. On my setup, this test passed, and the others are skipped. I think the issue on this specific test may be due to performance (seems to be a timing issue, I will try to slow down my VM). The

Re: [PATCH] drm/amd/display: avoid NPD when ASIC does not support DMUB

2025-03-13 Thread Leo Li
On 2025-03-13 07:29, Thadeu Lima de Souza Cascardo wrote: On Wed, Feb 05, 2025 at 10:06:38AM -0300, Thadeu Lima de Souza Cascardo wrote: ctx->dmub_srv will de NULL if the ASIC does not support DMUB, which is tested in dm_dmub_sw_init. However, it will be dereferenced in dmub_hw_lock_mgr_cmd

Re: [PATCH v4 4/7] dt-bindings: gpu: v3d: Add per-compatible register restrictions

2025-03-13 Thread Krzysztof Kozlowski
On 13/03/2025 15:43, Maíra Canal wrote: > In order to enforce per-SoC register rules, add per-compatible > restrictions. V3D 3.3 (represented by brcm,7268-v3d) has a cache > controller (GCA), which is not present in other V3D generations. > Declaring these differences helps ensure the DTB accuratel

[PATCH v8 6/6] drm/sched: Add a basic test for checking credit limit

2025-03-13 Thread Tvrtko Ursulin
Add a basic test for checking whether scheduler respects the configured credit limit. Signed-off-by: Tvrtko Ursulin Cc: Christian König Cc: Danilo Krummrich Cc: Matthew Brost Cc: Philipp Stanner Acked-by: Christian König --- drivers/gpu/drm/scheduler/tests/tests_basic.c | 60 +++

[PATCH v2] drm/mxsfb: fix missing rollback on failure in mxsfb_probe()

2025-03-13 Thread Luca Ceresoli
ret) + goto err_free; + ret = drm_dev_register(drm, 0); if (ret) goto err_unload; --- base-commit: f9f087d946266bc5da7c3a17bd8fd9d01969e3cf change-id: 20250313-mxsfb_probe-fix-rollback-on-error-3074b9080f34 Best regards, -- Luca Ceresoli

Re: [PATCH] drm/amd/display: avoid NPD when ASIC does not support DMUB

2025-03-13 Thread Alex Deucher
Applied. Thanks. Alex On Thu, Mar 13, 2025 at 11:17 AM Leo Li wrote: > > > > On 2025-03-13 07:29, Thadeu Lima de Souza Cascardo wrote: > > On Wed, Feb 05, 2025 at 10:06:38AM -0300, Thadeu Lima de Souza Cascardo > > wrote: > >> ctx->dmub_srv will de NULL if the ASIC does not support DMUB, which

Re: [PATCH] drm/amdgpu/gfx12: correct cleanup of 'me' field with gfx_v12_0_me_fini()

2025-03-13 Thread Markus Elfring
… > can only release 'pfp' field of 'gfx'. The release function of 'me' field > should be gfx_v12_0_me_fini(). Do you care for an imperative wording in such a change description? https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rs

Re: [PATCH] drm/komeda: Remove unnecessary NULL check before clk_prepare_enable()

2025-03-13 Thread Liviu Dudau
On Thu, Mar 13, 2025 at 04:29:07PM +0800, Chen Ni wrote: > clk_prepare_enable() already checked NULL clock parameter. > Remove unneeded NULL check for clk here. You're not saving anything here. If mdev->aclk is NULL you still end up calling clk_prepare() and clk_enable() even if they return zero i

[PATCH v4 11/14] sh: Add support for suppressing warning backtraces

2025-03-13 Thread Alessandro Carminati
From: Guenter Roeck Add name of functions triggering warning backtraces to the __bug_table object section to enable support for suppressing WARNING backtraces. To limit image size impact, the pointer to the function name is only added to the __bug_table section if both CONFIG_KUNIT_SUPPRESS_BACK

[PATCH v8 2/6] drm/sched: Add scheduler unit testing infrastructure and some basic tests

2025-03-13 Thread Tvrtko Ursulin
Implement a mock scheduler backend and add some basic test to exercise the core scheduler code paths. Mock backend (kind of like a very simple mock GPU) can either process jobs by tests manually advancing the "timeline" job at a time, or alternatively jobs can be configured with a time duration in

[PATCH v8 4/6] drm/sched: Add basic priority tests

2025-03-13 Thread Tvrtko Ursulin
Add some basic tests for exercising entity priority handling. Signed-off-by: Tvrtko Ursulin Cc: Christian König Cc: Danilo Krummrich Cc: Matthew Brost Cc: Philipp Stanner Acked-by: Christian König --- drivers/gpu/drm/scheduler/tests/tests_basic.c | 95 ++- 1 file changed, 94

Re: [PATCH] drm/amdgpu/gfx12: correct cleanup of 'me' field with gfx_v12_0_me_fini()

2025-03-13 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Mar 12, 2025 at 6:09 AM Wentao Liang wrote: > > In gfx_v12_0_cp_gfx_load_me_microcode_rs64(), gfx_v12_0_pfp_fini() is > incorrectly used to free 'me' field of 'gfx', since gfx_v12_0_pfp_fini() > can only release 'pfp' field of 'gfx'. The release function of 'me' fi

Re: [RFC PATCH 00/19] drm, drm/xe: Multi-device GPUSVM

2025-03-13 Thread Thomas Hellström
On Thu, 2025-03-13 at 13:57 +0100, Christian König wrote: > Am 13.03.25 um 13:50 schrieb Thomas Hellström: > > Hi, Christian > > > > On Thu, 2025-03-13 at 11:19 +0100, Christian König wrote: > > > Am 12.03.25 um 22:03 schrieb Thomas Hellström: > > > > This RFC implements and requests comments for

[PATCH RFC 0/3] Initial work for Rust abstraction for HID device driver development

2025-03-13 Thread Rahul Rameshbabu
Hello, I am a hobbyist developer who has been working on a project to create a new Rust HID device driver and the needed core abstractions for writing more HID device drivers in Rust. My goal is to support the USB Monitor Control Class needed for functionality such as backlight control for monitor

[PATCH RFC 3/3] rust: hid: demo the core abstractions for probe and remove

2025-03-13 Thread Rahul Rameshbabu
This is a very basic "hello, world!" implementation to illustrate that the probe and remove callbacks are working as expected. I chose an arbitrary device I had on hand for populating in the HID device id table. [ +0.012968] monitor_control: Probing HID device vendor: 2389 product: 29204 using

[PATCH v8 1/6] drm: Move some options to separate new Kconfig

2025-03-13 Thread Tvrtko Ursulin
Move some options out into a new debug specific kconfig file in order to make things a bit cleaner. Signed-off-by: Tvrtko Ursulin Cc: Christian König Cc: Danilo Krummrich Cc: Matthew Brost Cc: Philipp Stanner Acked-by: Christian König --- drivers/gpu/drm/Kconfig | 109 ++--

Re: [PATCH v2 2/7] drm/bridge: synopsys: Add DW DPTX Controller support library

2025-03-13 Thread Piotr Oniszczuk
> Wiadomość napisana przez Andy Yan w dniu 13 mar 2025, o > godz. 01:23: > > > Hi Piotr, > 在 2025-03-12 22:23:15,"Piotr Oniszczuk" 写道: > > This series still based on Linux 6.14 rc4. > > Did you apply the three dependency patch mentioned in my cover letter? Thx! I noticed https://lore.k

Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-13 Thread Andy Shevchenko
On Thu, Mar 13, 2025 at 11:06:54AM +, Aditya Garg wrote: > > On 13 Mar 2025, at 4:18 PM, Petr Mladek wrote: > > On Thu 2025-03-13 09:13:23, Aditya Garg wrote: > >>> On 13 Mar 2025, at 2:27 PM, Andy Shevchenko > >>> wrote: > >>> On Thu, Mar 13, 2025 at 08:53:28AM +, Aditya Garg wrote: > >

[PATCH v4 6/7] drm/v3d: Use V3D_SMS registers for power on/off and reset on V3D 7.x

2025-03-13 Thread Maíra Canal
In addition to the standard reset controller, V3D 7.x requires configuring the V3D_SMS registers for proper power on/off and reset. Add the new registers to `v3d_regs.h` and ensure they are properly configured during device probing, removal, and reset. This change fixes GPU reset issues on the Ras

[PATCH v4 3/7] drm/v3d: Associate a V3D tech revision to all supported devices

2025-03-13 Thread Maíra Canal
The V3D driver currently determines the GPU tech version (33, 41...) by reading a register. This approach has worked so far since this information wasn’t needed before powering on the GPU. V3D 7.1 introduces new registers that must be written to power on the GPU, requiring us to know the V3D versi

[PATCH v4 1/7] drm/v3d: Don't run jobs that have errors flagged in its fence

2025-03-13 Thread Maíra Canal
The V3D driver still relies on `drm_sched_increase_karma()` and `drm_sched_resubmit_jobs()` for resubmissions when a timeout occurs. The function `drm_sched_increase_karma()` marks the job as guilty, while `drm_sched_resubmit_jobs()` sets an error (-ECANCELED) in the DMA fence of that guilty job.

[PATCH v4 4/7] dt-bindings: gpu: v3d: Add per-compatible register restrictions

2025-03-13 Thread Maíra Canal
In order to enforce per-SoC register rules, add per-compatible restrictions. V3D 3.3 (represented by brcm,7268-v3d) has a cache controller (GCA), which is not present in other V3D generations. Declaring these differences helps ensure the DTB accurately reflect the hardware design. While not ideal,

[PATCH v4 2/7] drm/v3d: Set job pointer to NULL when the job's fence has an error

2025-03-13 Thread Maíra Canal
Similar to commit e4b5ccd392b9 ("drm/v3d: Ensure job pointer is set to NULL after job completion"), ensure the job pointer is set to `NULL` when a job's fence has an error. Failing to do so can trigger kernel warnings in specific scenarios, such as: 1. v3d_csd_job_run() assigns `v3d->csd_job = job

Re: [PATCH RFC 1/2] drm/panel: Add new helpers for refcounted panel allocatons

2025-03-13 Thread Maxime Ripard
Hi Anusha, In addition to the feedback Luca already provided, I have a few comments On Wed, Mar 12, 2025 at 08:54:42PM -0400, Anusha Srivatsa wrote: > Introduce reference counted allocations for panels to avoid > use-after-free. The patch adds the macro devm_drm_bridge_alloc() > to allocate a new

[PATCH] drm/mxsfb: fix missing rollback on failure in mxsfb_probe()

2025-03-13 Thread Luca Ceresoli
ev_register(drm, 0); if (ret) --- base-commit: f9f087d946266bc5da7c3a17bd8fd9d01969e3cf change-id: 20250313-mxsfb_probe-fix-rollback-on-error-3074b9080f34 Best regards, -- Luca Ceresoli

Re: [PATCH RFC 1/2] drm/panel: Add new helpers for refcounted panel allocatons

2025-03-13 Thread Maxime Ripard
On Thu, Mar 13, 2025 at 11:09:44AM +0100, Luca Ceresoli wrote: > Hello Anusha, > > On Wed, 12 Mar 2025 20:54:42 -0400 > Anusha Srivatsa wrote: > > > Introduce reference counted allocations for panels to avoid > > use-after-free. The patch adds the macro devm_drm_bridge_alloc() > > to allocate a

Re: [PATCH v16 5/7] drm/vkms: Create KUnit tests for YUV conversions

2025-03-13 Thread Maxime Ripard
Hi, On Mon, Mar 10, 2025 at 11:12:59AM +0200, Pekka Paalanen wrote: > On Fri, 7 Mar 2025 15:50:41 +0100 > Louis Chauvet wrote: > > > Le 07/03/2025 à 11:20, Maxime Ripard a écrit : > > > On Wed, Feb 19, 2025 at 02:35:14PM +0100, Louis Chauvet wrote: > > >> > > >> > > >> Le 19/02/2025 à 11:15, M

Re: [PATCH v2 0/2] Use proper printk format in appletbdrm

2025-03-13 Thread Alyssa Rosenzweig
series looks ok to me. Who is pushing this to drm-misc-next? (I can if nobody else does)

Re: [RFC PATCH 0/3] gpu: nova-core: add basic timer subdevice implementation

2025-03-13 Thread Simona Vetter
On Fri, Mar 07, 2025 at 10:55:57AM -0400, Jason Gunthorpe wrote: > On Fri, Mar 07, 2025 at 02:09:12PM +0100, Simona Vetter wrote: > > > > A driver can do a health check immediately in remove() and make a > > > decision if the device is alive or not to speed up removal in the > > > hostile hot unpl

Re: [PATCH] drm/mxsfb: fix missing rollback on failure in mxsfb_probe()

2025-03-13 Thread Thomas Zimmermann
e call to the top? No extra cleanup would be required then. Best regards Thomas ret = drm_dev_register(drm, 0); if (ret) --- base-commit: f9f087d946266bc5da7c3a17bd8fd9d01969e3cf change-id: 20250313-mxsfb_probe-fix-rollback-on-error-3074b9080f34 Best regards, -- -- Thomas Zimmer

Re: [PATCH] drm/amd/display: avoid NPD when ASIC does not support DMUB

2025-03-13 Thread Thadeu Lima de Souza Cascardo
On Wed, Feb 05, 2025 at 10:06:38AM -0300, Thadeu Lima de Souza Cascardo wrote: > ctx->dmub_srv will de NULL if the ASIC does not support DMUB, which is > tested in dm_dmub_sw_init. > > However, it will be dereferenced in dmub_hw_lock_mgr_cmd if > should_use_dmub_lock returns true. > > This has be

[PATCH v4 02/14] kunit: bug: Count suppressed warning backtraces

2025-03-13 Thread Alessandro Carminati
From: Guenter Roeck Count suppressed warning backtraces to enable code which suppresses warning backtraces to check if the expected backtrace(s) have been observed. Using atomics for the backtrace count resulted in build errors on some architectures due to include file recursion, so use a plain

Re: [PATCH v5 RESEND 1/2] dmaengine: qcom: gpi: Add GPI Block event interrupt support

2025-03-13 Thread Jyothi Kumar Seerapu
Hi Vinod, Thanks for the review comments. On 3/11/2025 2:30 AM, Vinod Koul wrote: On 12-02-25, 17:35, Jyothi Kumar Seerapu wrote: GSI hardware generates an interrupt for each transfer completion. For multiple messages within a single transfer, this results in N interrupts for N messages, leadin

Re: [PATCH 1/2] fbcon: Register sysfs groups through device_add_group

2025-03-13 Thread Shixiong Ou
在 2025/3/13 00:47, Thomas Weißschuh 写道: Hi, On Tue, Mar 11, 2025 at 07:28:55PM +0800, oushixiong1...@163.com wrote: From: Shixiong Ou Use device_add_group() to simplify creation and removal. Signed-off-by: Shixiong Ou --- drivers/video/fbdev/core/fbcon.c | 48 +++

Re: [PATCH v2 07/10] arm64: dts: qcom: sa8775p-ride: add anx7625 DSI to DP bridge nodes

2025-03-13 Thread Ayushi Makhija
On 3/12/2025 5:18 PM, Krzysztof Kozlowski wrote: > On Tue, Mar 11, 2025 at 05:54:42PM +0530, Ayushi Makhija wrote: >> Add anx7625 DSI to DP bridge device nodes. >> >> Signed-off-by: Ayushi Makhija >> --- >> arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 208 - >> 1 file changed,

Re: [RFC PATCH 00/19] drm, drm/xe: Multi-device GPUSVM

2025-03-13 Thread Christian König
Am 13.03.25 um 13:50 schrieb Thomas Hellström: > Hi, Christian > > On Thu, 2025-03-13 at 11:19 +0100, Christian König wrote: >> Am 12.03.25 um 22:03 schrieb Thomas Hellström: >>> This RFC implements and requests comments for a way to handle SVM >>> with multi-device, >>> typically with fast interco

[PATCH v4 00/14] Add support for suppressing warning backtraces

2025-03-13 Thread Alessandro Carminati
Some unit tests intentionally trigger warning backtraces by passing bad parameters to kernel API functions. Such unit tests typically check the return value from such calls, not the existence of the warning backtrace. Such intentionally generated warning backtraces are neither desirable nor useful

[PATCH v4 01/14] bug/kunit: Core support for suppressing warning backtraces

2025-03-13 Thread Alessandro Carminati
From: Guenter Roeck Some unit tests intentionally trigger warning backtraces by passing bad parameters to API functions. Such unit tests typically check the return value from those calls, not the existence of the warning backtrace. Such intentionally generated warning backtraces are neither desi

[PATCH v4 06/14] x86: Add support for suppressing warning backtraces

2025-03-13 Thread Alessandro Carminati
From: Guenter Roeck Add name of functions triggering warning backtraces to the __bug_table object section to enable support for suppressing WARNING backtraces. To limit image size impact, the pointer to the function name is only added to the __bug_table section if both CONFIG_KUNIT_SUPPRESS_BACK

Re: [PATCH v5 04/16] drm/atomic: Introduce helper to lookup connector by encoder

2025-03-13 Thread Maxime Ripard
Hi, On Thu, Mar 13, 2025 at 04:09:54PM +0800, Andy Yan wrote: > At 2025-03-05 19:55:19, "Andy Yan" wrote: > >At 2025-03-04 19:10:47, "Maxime Ripard" wrote: > >>With the bridges switching over to drm_bridge_connector, the direct > >>association between a bridge driver and its connector was lost.

[PATCH] fbcon: Use static attribute groups for sysfs entries

2025-03-13 Thread oushixiong1025
From: Shixiong Ou Using device_create_with_groups() to simplify creation and removal. Same as commit 1083a7be4504 ("tty: Use static attribute groups for sysfs entries"). Signed-off-by: Shixiong Ou --- drivers/video/fbdev/core/fbcon.c | 67 +--- 1 file changed, 19 in

Re: [PATCH v4 5/7] dt-bindings: gpu: v3d: Add SMS register to BCM2712 compatible

2025-03-13 Thread Krzysztof Kozlowski
On 13/03/2025 15:43, Maíra Canal wrote: > V3D 7.1 exposes a new register block, called V3D_SMS. As BCM2712 has a > V3D 7.1 core, add a new register item to its compatible. Similar to the > GCA, which is specific for V3D 3.3, SMS should only be added for V3D 7.1 > variants (such as brcm,2712-v3d). >

[PATCH v4 7/7] dt-bindings: gpu: Add V3D driver maintainer as DT maintainer

2025-03-13 Thread Maíra Canal
As established in commit 89d04995f76c ("MAINTAINERS: Drop Emma Anholt from all M lines."), Emma is no longer active in the Linux kernel and dropped the V3D maintainership. Therefore, remove Emma as one of the DT maintainers and add the current V3D driver maintainer. Acked-by: Emma Anholt Acked-by

Re: [PATCH] drm/amd/display: avoid NPD when ASIC does not support DMUB

2025-03-13 Thread Rodrigo Siqueira
On 03/13, Thadeu Lima de Souza Cascardo wrote: > On Wed, Feb 05, 2025 at 10:06:38AM -0300, Thadeu Lima de Souza Cascardo wrote: > > ctx->dmub_srv will de NULL if the ASIC does not support DMUB, which is > > tested in dm_dmub_sw_init. > > > > However, it will be dereferenced in dmub_hw_lock_mgr_cmd

Re: [PATCH] drm/mxsfb: fix missing rollback on failure in mxsfb_probe()

2025-03-13 Thread Luca Ceresoli
Hello Thomas, On Thu, 13 Mar 2025 15:40:43 +0100 Thomas Zimmermann wrote: > > @@ -365,9 +365,10 @@ static int mxsfb_probe(struct platform_device *pdev) > > * located anywhere in RAM > > */ > > ret = aperture_remove_all_conflicting_devices(mxsfb_driver.name); > > - if (ret) > > -

Re: [PATCH RFC 0/3] Initial work for Rust abstraction for HID device driver development

2025-03-13 Thread Benjamin Tissoires
Hi, [quick reply because I am completely under the water for the next 2 weeks] On Mar 13 2025, Rahul Rameshbabu wrote: > Hello, > > I am a hobbyist developer who has been working on a project to create a new > Rust > HID device driver and the needed core abstractions for writing more HID device

[PATCH] drm/komeda: Remove unnecessary NULL check before clk_prepare_enable()

2025-03-13 Thread Chen Ni
clk_prepare_enable() already checked NULL clock parameter. Remove unneeded NULL check for clk here. Signed-off-by: Chen Ni --- drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/

[PATCH v7 5/6] drm/xe/xe_gt_pagefault: Add address_type field to pagefaults

2025-03-13 Thread Jonathan Cavitt
Add a new field to the xe_pagefault struct, address_type, that tracks the type of fault the pagefault incurred. Signed-off-by: Jonathan Cavitt --- drivers/gpu/drm/xe/xe_gt_pagefault.c | 3 +++ drivers/gpu/drm/xe/xe_gt_pagefault.h | 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/gpu/

[RFC PATCH 06/19] drm/pagemap, drm/xe: Add refcounting to struct drm_pagemap and manage lifetime

2025-03-13 Thread Thomas Hellström
Remove the xe embedded drm_pagemap, and instead allocate and reference count. This is a step towards adding drm_pagemaps on demand. Signed-off-by: Thomas Hellström --- drivers/gpu/drm/drm_pagemap.c| 58 +++- drivers/gpu/drm/xe/xe_device_types.h | 2 +- drivers/gp

[PULL] drm-xe-fixes

2025-03-13 Thread Rodrigo Vivi
Hi Dave and Sima, Here goes xe fixes for this week. It is worth mention that we are disabling D3Cold on BMG because we found some bugs where depending on the combination of BMG card and the host, the PCI upstream port link port re-training might fail on D3Cold -> D0 blowing things up. But while w

Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-13 Thread Aditya Garg
> On 13 Mar 2025, at 2:19 PM, Andy Shevchenko > wrote: > > On Thu, Mar 13, 2025 at 07:26:05AM +, Aditya Garg wrote: On 13 Mar 2025, at 12:58 AM, Andy Shevchenko wrote: >>> On Wed, Mar 12, 2025 at 07:14:36PM +, Aditya Garg wrote: > On 12 Mar 2025, at 9:05 PM, Sven Peter

Re: [PATCH v4 07/14] arm64: Add support for suppressing warning backtraces

2025-03-13 Thread Alessandro Carminati
Hello Will, On Thu, Mar 13, 2025 at 1:25 PM Will Deacon wrote: > > On Thu, Mar 13, 2025 at 11:43:22AM +, Alessandro Carminati wrote: > > diff --git a/arch/arm64/include/asm/bug.h b/arch/arm64/include/asm/bug.h > > index 28be048db3f6..044c5e24a17d 100644 > > --- a/arch/arm64/include/asm/bug.h

  1   2   3   >